Re: [edk2] [patch] DuetPkg: Add SortLib/UefiBootManagerLib

2017-03-19 Thread Ni, Ruiyu
Reviewed-by: Ruiyu Ni Thanks/Ray > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Dandan Bi > Sent: Monday, March 20, 2017 2:28 PM > To: edk2-devel@lists.01.org > Cc: Ni, Ruiyu > Subject: [edk2] [patch] DuetPkg: Add SortLib/UefiBootManagerL

Re: [edk2] [patch] EmulatorPkg: Add SortLib/UefiBootManagerLib

2017-03-19 Thread Ni, Ruiyu
Reviewed-by: Ruiyu Ni Thanks/Ray > -Original Message- > From: Bi, Dandan > Sent: Monday, March 20, 2017 2:28 PM > To: edk2-devel@lists.01.org > Cc: Ni, Ruiyu > Subject: [patch] EmulatorPkg: Add SortLib/UefiBootManagerLib > > ConPlatformDxe uses the UefiBootManagerLib, > and UefiBootMan

[edk2] [patch] DuetPkg: Add SortLib/UefiBootManagerLib

2017-03-19 Thread Dandan Bi
ConPlatformDxe uses the UefiBootManagerLib, and UefiBootManagerLib consumes SortLib. Cc: Ruiyu Ni Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi --- DuetPkg/DuetPkgIa32.dsc | 4 +++- DuetPkg/DuetPkgX64.dsc | 4 +++- 2 files changed, 6 insertions(+), 2 deletion

[edk2] [patch] EmulatorPkg: Add SortLib/UefiBootManagerLib

2017-03-19 Thread Dandan Bi
ConPlatformDxe uses the UefiBootManagerLib, and UefiBootManagerLib consumes SortLib. Cc: Ruiyu Ni Contributed-under: TianoCore Contribution Agreement Signed-off-by: Dandan Bi --- EmulatorPkg/EmulatorPkg.dsc | 2 ++ 1 file changed, 2 insertions(+) diff --git a/EmulatorPkg/EmulatorPkg.dsc b/Emul

Re: [edk2] [PATCH v2 03/12] MdeModulePkg/RamDiskDxe: fix C string literal catenation in info messages

2017-03-19 Thread Wu, Hao A
Reviewed-by: Hao Wu Best Regards, Hao Wu > -Original Message- > From: Tian, Feng > Sent: Monday, March 20, 2017 10:26 AM > To: Zeng, Star; Laszlo Ersek; edk2-devel-01 > Cc: Ard Biesheuvel; Wu, Hao A; Leif Lindholm; Tian, Feng > Subject: RE: [PATCH v2 03/12] MdeModulePkg/RamDiskDxe: fix

Re: [edk2] [PATCH v2 03/12] MdeModulePkg/RamDiskDxe: fix C string literal catenation in info messages

2017-03-19 Thread Tian, Feng
Ok to me as well. Reviewed-by: Feng Tian Thanks Feng -Original Message- From: Zeng, Star Sent: Monday, March 20, 2017 10:16 AM To: Laszlo Ersek ; edk2-devel-01 Cc: Ard Biesheuvel ; Tian, Feng ; Wu, Hao A ; Leif Lindholm ; Zeng, Star Subject: RE: [PATCH v2 03/12] MdeModulePkg/RamDis

Re: [edk2] [PATCH v2 05/12] ArmPkg: introduce EDKII Platform Has ACPI Protocol, and plug-in library

2017-03-19 Thread Zeng, Star
Laszlo, Could the implementation have multiple instances of PlatformHasAcpiLib to return unsuccessfully in the constructor when EFI_ACPI_TABLE_PROTOCOL is not needed? And then eliminate PlatformHasAcpiDtDxe, gEdkiiPlatformHasAcpiProtocolGuid and gEdkiiPlatformHasDeviceTreeProtocolGuid? Thanks,

Re: [edk2] [PATCH v2 03/12] MdeModulePkg/RamDiskDxe: fix C string literal catenation in info messages

2017-03-19 Thread Zeng, Star
I am ok with this patch. Feng and Hao, do you have any comments? Thanks, Star -Original Message- From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Saturday, March 18, 2017 4:47 AM To: edk2-devel-01 Cc: Ard Biesheuvel ; Tian, Feng ; Wu, Hao A ; Leif Lindholm ; Zeng, Star Subject: [P

Re: [edk2] [RFC PATCH] MdeModulePkg/AcpiTableDxe: inhibit table publication until we have a FADT

2017-03-19 Thread Zeng, Star
In fact, I prefer the Laszlo's proposal to prevent the production of EFI_ACPI_TABLE_PROTOCOL by NULL library class, but not the special handling in core module AcpiTableDxe. Then AcpiTableDxe could be not run(by adding DEPEX in NULL library class) or be unloaded(by returning unsuccessful in cons

Re: [edk2] [patch] MdeModulePkg/DxeCapsuleLibFmp: Fix build failure

2017-03-19 Thread Yao, Jiewen
Reviewed-by: jiewen@intel.com > -Original Message- > From: Bi, Dandan > Sent: Monday, March 20, 2017 9:41 AM > To: edk2-devel@lists.01.org > Cc: Yao, Jiewen > Subject: [patch] MdeModulePkg/DxeCapsuleLibFmp: Fix build failure > > Move the definition of variable "mEsrtTable" and > "mIs

[edk2] [patch] MdeModulePkg/DxeCapsuleLibFmp: Fix build failure

2017-03-19 Thread Dandan Bi
Move the definition of variable "mEsrtTable" and "mIsVirtualAddrConverted" to DxeCapsuleLib.c. Cc: Jiewen Yao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi --- MdeModulePkg/Library/DxeCapsuleLibFmp/DxeCapsuleLib.c | 4 ++-- MdeModulePkg/Library/DxeCapsuleL

Re: [edk2] [PATCH] MdeModulePkg/BootGraphicsResourceTableDxe: don't allocate below 4 GB

2017-03-19 Thread Zeng, Star
I am ok with this patch. Jiewen and Liming, do you have any comments? Thanks, Star -Original Message- From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] Sent: Monday, March 20, 2017 1:20 AM To: edk2-devel@lists.01.org; Zeng, Star ; Tian, Feng Cc: Ard Biesheuvel Subject: [PATCH] M

[edk2] [PATCH] MdeModulePkg/BootGraphicsResourceTableDxe: don't allocate below 4 GB

2017-03-19 Thread Ard Biesheuvel
The BGRT table has an 8 byte field for the memory address of the image data, and yet the driver explicitly allocates below 4 GB. This results in an ASSERT() on systems that do not have any memory below 4 GB to begin with. Since neither the PI, the UEFI or the ACPI spec contain any mention of why t