Re: [edk2] Using Intel UDk debugger

I have built my application with /Od and /Oy-, and GENFW_FLAGS as --keepexceptiontable. After loading DebugAgentDxe I have set an unresolved breakpoint in main routine of my application, but when I start my application in the target no breakpoint is hit. But when the application crashes the symbols

Re: [edk2] [PATCH v3] MdePkg: BaseIoLibIntrinsic (IoLib class) library

Leo: There is no change for the existing ones. For new features, only nasm will be added. Thanks Liming > -Original Message- > From: Duran, Leo [mailto:leo.du...@amd.com] > Sent: Thursday, March 30, 2017 8:31 PM > To: Gao, Liming ; edk2-de...@ml01.01.org > Cc: Kinney, Michael D ; Singh,

[edk2] [PATCH V2] SecurityPkg: SecureBootConfigDxe: Support AUTH_2 enrollment to DBX

Update SecureBootConfigDxe to support AUTH_2 format data enrollment to DBX. Free opened file handle resource after we exit PK/KEK/DB/DBX/DBT enrollment page. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Chao Zhang Reviewed-by: Long Qin --- .../SecureBootConfigDxe/Secur

Re: [edk2] [Patch] MdeModulePkg: Remove unsupported PcdExpression usage in module INF

Reviewed-by: Feng Tian Thanks Feng -Original Message- From: Gao, Liming Sent: Friday, March 31, 2017 1:04 PM To: edk2-devel@lists.01.org Cc: Tian, Feng ; Zeng, Star Subject: [Patch] MdeModulePkg: Remove unsupported PcdExpression usage in module INF https://bugzilla.tianocore.org/show

Re: [edk2] [PATCH] SecureBoot UI Update

Laszlo: I checked my patch. It did contains such info. I use index 1, 2 in front of some comment line. Not sure it is the reason why these info are filtered. I will send patch again. -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo

Re: [edk2] [PATCH 00/10] Use a better algorithm to calculate MTRR

Serials Reviewed-by: Jeff Fan Please updating the correct Copyright date when you push this serial of patches. -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ruiyu Ni Sent: Wednesday, March 29, 2017 11:04 AM To: edk2-devel@lists.01.org Subject:

[edk2] [Patch] MdeModulePkg: Remove unsupported PcdExpression usage in module INF

https://bugzilla.tianocore.org/show_bug.cgi?id=442 PcdExpression used in INF to control PCD and Source is unsupported feature. Current sample usage in module INF brings confuse. Cc: Feng Tian Cc: Star Zeng Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Liming Gao --- M

Re: [edk2] Vfr compiler error

Hi Liming, That solves the build issues. :) Thank you, Naveen -Original Message- From: Gao, Liming [mailto:liming@intel.com] Sent: Friday, March 31, 2017 6:15 AM To: Dong, Eric; Santhapur Naveen; edk2-devel@lists.01.org Subject: RE: Vfr compiler error Naveen: This has be

Re: [edk2] Using Intel UDk debugger

Yes. If you want to enable flow control, you could set gEfiMdeModulePkgTokenSpaceGuid.PcdSerialUseHardwareFlowControl|TRUE in SourceLevelDebugPkg.dsc when you build DebugAgentDxe.efi. It could improve the serial port communication quality. Thanks! Jeff -Original Message- From: Arka Sh

Re: [edk2] Using Intel UDk debugger

Thanks a lot Jeff. Setting FlowControl to 0 worked. Now I am able to break into the target system. Just wondering is it same as mentioned in UDK_Debugger_Tool_User_Manual_V1.11.pdf 2.2.3.2 "If the platform-specific Serial Port Library does not support hardware flow control, flow control on the host

Re: [edk2] Using Intel UDk debugger

It's good start. Please drop the putty from now. Please check the following setting in SoftDebugger.ini on HOST side, and change FlowControl to 0 and change Trace to 0x10 [Debug Port] Channel = Serial Port = COM1 FlowControl = 0 BaudRate = 115200 Server = [Maintenance] ; Uncomment the below lin

Re: [edk2] Using Intel UDk debugger

After changing the putty settings I am getting this message "Send INIT break packet and try to connect the HOST (Intel(R) UDK Debugger Tool v1.5)" followed by þ?Yºþ?Yºþ?YºHOST connection is failed! Am I missing some other settings ? Regards, Arka On Fri, Mar 31, 2017 at 7:58 AM, Fan, Jeff wrote

Re: [edk2] Using Intel UDk debugger

It's better if there is no Serial driver to manage the serial port. DebugAgentDxe built from SourceLevelDebugPkg is consuming MdeModulePkg\Library\BaseSerialPortLib16550\BaseSerialPortLib16550.inf to read/write data from serial port. SerialPortLib|MdeModulePkg/Library/BaseSerialPortLib16550/B

Re: [edk2] Using Intel UDk debugger

When I load DebugAgentDxe I get cFÃ×ÿ?käÿÿÿã+þ in putty. Also when I boot to shell there is not IsaSerialDxe or any other driver managing the serial port. I manually located the serial port with "devices". In the shell when I load DebugAgentDxe I get the same text as mentioned in Step 8 of section

Re: [edk2] [PATCH v2 07/11] CryptoPkg: Clean-up CRT Library Wrapper.

Laszlo, Thanks for catching this. I was using GCC5 toolchain for few validations, the build looks OK. Yes, should have more toolchain validations. :-( I am also confused about this nonull warning. Maybe strncasecmp function could have been defined as the different prototype (explicitely or im

Re: [edk2] Using Intel UDk debugger

DebugAgentDxe will consume Serial Port to setup debug channel with HOST. Please shutdown the UDK debug HOST software and use any serial tool (Like putty). Are there any output when you load DebugAgentDxe in shell? Could you paste here? You need to make sure the DebugAgentDxe used the correct

Re: [edk2] Using Intel UDk debugger

Thanks a lot Mike. You are right. I have installed WinDbg 6.11.1404. Now the issue I mentioned earlier is not seen. But I am still not able to break into target system. I have loaded the DebugAgentDxe and loading was success. But in the shell I can find that still the serial port handle is not mana

Re: [edk2] Vfr compiler error

Naveen: This has been supported in the latest BaseTools. Please update edk2-BaseTools-win32 repo, and try again. Thanks Liming > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Dong, > Eric > Sent: Thursday, March 30, 2017 9:28 PM > To: Sant

Re: [edk2] [PATCH v2 1/1] OvmfPkg: Allow multiple add-pointer linker commands to same ACPI table

On 03/30/17 12:40, Phil Dennis-Jordan wrote: > From: Phil Dennis-Jordan > > ACPI tables may contain multiple fields which point to the same > destination table. For example, in some revisions, the FADT contains > both DSDT and X_DSDT fields, and they may both point to the DSDT. > > Previously, i

Re: [edk2] [PATCH 0/6] Embedded|ArmPlatformPkg: spring cleaning + DtPlatformDxe switch

On 03/29/17 15:48, Ard Biesheuvel wrote: > This implements the upstream part of switching VExpress TC2 and the AArch64 > FVP Foundation/Base models to the new DtPlatformDxe driver, which is much > simpler and only allows ACPI or DT to be enabled but never both. > > Patches #1 and #2 tweak the new

Re: [edk2] ArmCpuLib users

> Eugene, what is your take on this? I just checked and we don't use it anywhere. Thanks! Eugene ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [PATCH v2 07/11] CryptoPkg: Clean-up CRT Library Wrapper.

Qin, this patch (commit fc9fa685d689c) seems to break *some* GCC builds: On 03/23/17 14:19, Qin Long wrote: [snip] > +/* Compare first n bytes of string s1 with string s2, ignoring case */ > +int strncasecmp (const char *s1, const char *s2, size_t n) > +{ > + int Val; > + > + ASSERT(s1 != NUL

Re: [edk2] [RFT PATCH 2/3] ArmPlatformPkg/ArmJunoPkg: add PciHostBridgeLib implementation

On 30 March 2017 at 17:34, Jeremy Linton wrote: > Hi, > > > On 03/30/2017 05:45 AM, Ard Biesheuvel wrote: >> >> In order to be able to switch to the generic PCI host bridge driver, >> implement the glue library that exposes the PCIe parameters to the >> common driver. Since the Juno performs some

Re: [edk2] [RFT PATCH 2/3] ArmPlatformPkg/ArmJunoPkg: add PciHostBridgeLib implementation

Hi, On 03/30/2017 05:45 AM, Ard Biesheuvel wrote: In order to be able to switch to the generic PCI host bridge driver, implement the glue library that exposes the PCIe parameters to the common driver. Since the Juno performs some initialization of the PCIe control registers as well, copy that co

Re: [edk2] [PATCH] SecureBoot UI Update

On 03/30/17 04:00, Zhang, Chao B wrote: > --- > .../SecureBootConfigDxe/SecureBootConfig.vfr | 38 +++- > .../SecureBootConfigDxe/SecureBootConfigImpl.c | 196 > - > .../SecureBootConfigDxe/SecureBootConfigImpl.h | 32 > .../SecureBootConfigDxe/SecureBootC

Re: [edk2] [PATCH v2] ArmVirtPkg/PlatformHasAcpiDtDxe: allow guest level ACPI disable override

On 03/30/17 10:40, Ard Biesheuvel wrote: > On 29 March 2017 at 20:35, Laszlo Ersek wrote: >> On 03/29/17 21:10, Ard Biesheuvel wrote: > [...] >>> >>> How on earth is having two ways to disable ACPI rather than one going >>> to cause fragmentation? Unlike v1, this patch does not allow you to >>> ex

Re: [edk2] [PATCH v1 1/1] OvmfPkg: Allow multiple add-pointer linker commands to same ACPI table

On 03/30/17 12:41, Phil Dennis-Jordan wrote: > On Thu, Mar 30, 2017 at 2:06 PM, Laszlo Ersek wrote: >> This is a very good first patch! >> >> I have a few requests. I'll generally rehash the points from >> . >> >> On 03/29/17 09:50, Phil Denni

Re: [edk2] Using Intel UDk debugger

Hi Arka, I have seen that error when the wrong version of WinDbg is used. What version of WinDbg did you install? Does it match the version listed in the UDK Debugger manual? Mike > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Arka > Shar

Re: [edk2] [RFC PATCH v1 0/2] OvmfPkg/QemuVideoDxe: Add VMWare SVGA2 framebuffer support

On 03/30/17 12:51, Phil Dennis-Jordan wrote: > On Thu, Mar 30, 2017 at 2:33 PM, Laszlo Ersek wrote: >> On 03/29/17 10:19, Phil Dennis-Jordan wrote: >>> This extends the QemuVideoDxe driver to support the VMWare SVGA2 display >>> device implemented by Qemu. Drivers for this device exist for guest O

Re: [edk2] [PATCH 1/3] MdeModulePkg/Include: Add IOMMU protocol definition.

On 30 March 2017 at 13:37, Yao, Jiewen wrote: > Thanks for the info. > > > > Comment inline. > > > > > > > > > > From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > Sent: Wednesday, March 29, 2017 10:23 PM > To: Yao, Jiewen > Cc: Kinney, Michael D ; Ni, Ruiyu > ; Leo Duran ; > edk2-devel@li

Re: [edk2] Vfr compiler error

Hi Naveen, Current VfrCompiler not support get value from PCD. Do you use PCD function in the data structure? Thanks, Eric -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Santhapur Naveen Sent: Thursday, March 30, 2017 8:27 PM To: edk2-devel@l

Re: [edk2] [PATCH 1/3] MdeModulePkg/Include: Add IOMMU protocol definition.

Thanks for the info. Comment inline. From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] Sent: Wednesday, March 29, 2017 10:23 PM To: Yao, Jiewen Cc: Kinney, Michael D ; Ni, Ruiyu ; Leo Duran ; edk2-devel@lists.01.org; Brijesh Singh Subject: Re: [edk2] [PATCH 1/3] MdeModulePkg/Include:

Re: [edk2] [PATCH v3] MdePkg: BaseIoLibIntrinsic (IoLib class) library

Liming, Should we remove the .asm code from the standard BaseIoLibIntrinsic.inf as well? (I'd prefer being consistent in both .INF instances: .ASM included or not) Thanks, Leo > -Original Message- > From: Gao, Liming [mailto:liming@intel.com] > Sent: Wednesday, March 29, 2017 11:51

[edk2] Vfr compiler error

Hi guys, Facing some kind of error while building Nt32Pkg VfrCompile... IScsiConfigNVDataStruc.h(211): ERROR 12288: FixedPcdGet8 : unexpected token VfrCompile... IScsiConfigNVDataStruc.h(211): ERROR 12288: ( : unexpected token VfrCompile... IScsiConfigNVDataStruc.h(211

[edk2] HP X2 10 Touchscreen Issue

Hi All, Apologies if this is the wrong place for this (I see that most posts are for git commits) I am currently having a UEFI development issue with an HP X2 10 tablet, specifically the i2c touchscreen. I was wondering if someone from HP who frequents the list would be able to offer some ins

Re: [edk2] [RFT PATCH 0/3] ArmJunoPkg: move to generic PCI support code

On 30 March 2017 at 11:45, Ard Biesheuvel wrote: > This moves the OHCI/EHCI PCI 'emulation' and the PCIe host bridge driver > to generic code. > > The diffstat says it all. > Code can be found here git://git.linaro.org/people/ard.biesheuvel/uefi-next.git arm-cleanup-combined with the OpenPlatfo

Re: [edk2] [RFC PATCH v1 0/2] OvmfPkg/QemuVideoDxe: Add VMWare SVGA2 framebuffer support

On Thu, Mar 30, 2017 at 2:33 PM, Laszlo Ersek wrote: > On 03/29/17 10:19, Phil Dennis-Jordan wrote: >> This extends the QemuVideoDxe driver to support the VMWare SVGA2 display >> device implemented by Qemu. Drivers for this device exist for guest OSes >> which do not support Qemu's other display a

[edk2] [RFT PATCH 2/3] ArmPlatformPkg/ArmJunoPkg: add PciHostBridgeLib implementation

In order to be able to switch to the generic PCI host bridge driver, implement the glue library that exposes the PCIe parameters to the common driver. Since the Juno performs some initialization of the PCIe control registers as well, copy that code in the library's constructor. Contributed-under:

[edk2] [RFT PATCH 1/3] ArmPlatformPkg/ArmJunoDxe: use the generic non-discoverable device support

Replace the open coded reimplementation of 'PCI emulation' with a pair of calls into NonDiscoverableDeviceRegistrationLib to register the OHCI and EHCI controllers. These will be picked up by the generic driver instead. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Bie

[edk2] [RFT PATCH 0/3] ArmJunoPkg: move to generic PCI support code

This moves the OHCI/EHCI PCI 'emulation' and the PCIe host bridge driver to generic code. The diffstat says it all. Ard Biesheuvel (3): ArmPlatformPkg/ArmJunoDxe: use the generic non-discoverable device support ArmPlatformPkg/ArmJunoPkg: add PciHostBridgeLib implementation ArmPlatformPk

[edk2] [RFT PATCH 3/3] ArmPlatformPkg/ArmJunoPkg: remove PCI host bridge driver

Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel --- ArmPlatformPkg/ArmJunoPkg/Drivers/PciHostBridgeDxe/PciHostBridge.c | 199 -- ArmPlatformPkg/ArmJunoPkg/Drivers/PciHostBridgeDxe/PciHostBridge.h | 324 - ArmP

Re: [edk2] [PATCH v1 1/1] OvmfPkg: Allow multiple add-pointer linker commands to same ACPI table

On Thu, Mar 30, 2017 at 2:06 PM, Laszlo Ersek wrote: > This is a very good first patch! > > I have a few requests. I'll generally rehash the points from > . > > On 03/29/17 09:50, Phil Dennis-Jordan wrote: >> From: Phil Dennis-Jordan >> >> AC

[edk2] [PATCH v2 0/1] OvmfPkg/AcpiPlatformDxe: Fix bug 368, multiply pointed-to tables

This fixes the bug in OVMF's Qemu ACPI table linker which caused it to fail or misbehave when multiple fields point to the same table. Previously, each pointer caused the pointed-to table to be installed via the EFI_ACPI_TABLE_PROTOCOL. However, each table must only be installed once via this mecha

[edk2] [PATCH v2 1/1] OvmfPkg: Allow multiple add-pointer linker commands to same ACPI table

From: Phil Dennis-Jordan ACPI tables may contain multiple fields which point to the same destination table. For example, in some revisions, the FADT contains both DSDT and X_DSDT fields, and they may both point to the DSDT. Previously, if Qemu created QEMU_LOADER_ADD_POINTER linker commands for

Re: [edk2] Using Intel UDk debugger

I have also verified the null modem connection by booting to windows in my target pc, and I am able to break it in WinDbg. So the communication is ok. In the target system shell when I load the DebugAgentDxe it is not appeared in the "drivers -b". Also in my system the serial port is not managed by

Re: [edk2] Using Intel UDk debugger

Thanks Jeff for your reply. I followed the steps as mentioned in "9.11 Debugging a standalone module loaded in a UEFI shell". I have built DebugAgentDxe and loaded it in my target system. I cross checked in my target system UEFI setup Serial is enabled. In host I have installed WinDbgX64 and UDK de

Re: [edk2] [PATCH v2] ArmVirtPkg/PlatformHasAcpiDtDxe: allow guest level ACPI disable override

On 29 March 2017 at 20:35, Laszlo Ersek wrote: > On 03/29/17 21:10, Ard Biesheuvel wrote: [...] >> >> How on earth is having two ways to disable ACPI rather than one going >> to cause fragmentation? Unlike v1, this patch does not allow you to >> expose both DT and ACPI tables at the same time. > >

Re: [edk2] [PATCH V2] BaseTools: Update Brotli and BrotliCompress mode and format

Reviewed-by: Liming Gao >-Original Message- >From: Song, BinX >Sent: Thursday, March 30, 2017 4:23 PM >To: edk2-devel@lists.01.org >Cc: Gao, Liming >Subject: [PATCH V2] BaseTools: Update Brotli and BrotliCompress mode and >format > >V2: >- Update correct patch info > >V1: >- Add x mode f

Re: [edk2] [patch] NetworkPkg: Fix some bugs related to iSCSI keyword configuration.

Reviewed-by: Ye Ting -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Zhang Lubo Sent: Friday, March 24, 2017 4:43 PM To: edk2-devel@lists.01.org Cc: Ye, Ting ; Fu, Siyuan ; Wu, Jiaxin Subject: [edk2] [patch] NetworkPkg: Fix some bugs related t

Re: [edk2] [PATCH] SecureBoot UI Update

Reviewed-by: Long Qin And some typos need to be corrected when check-in: +EnrollAuthenication2Descriptor ( --> EnrollAuthentication2Description ( +return EnrollAuthenication2Descriptor(Private, VariableName); --> EnrollAuthentication2Descriptor +If

[edk2] [PATCH V2] BaseTools: Update Brotli and BrotliCompress mode and format

V2: - Update correct patch info V1: - Add x mode for Brotli and BrotliCompress - Change Brotli and BrotliCompress format from DOS to UNIX Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Bell Song --- BaseTools/BinWrappers/PosixLike/Brotli | 58

Re: [edk2] ArmCpuLib users

On 30 March 2017 at 07:05, Michael Zimmermann wrote: > I just found out that ArmCpuLib seems to be unused even though it's > included in a few dsc files. > Is it deprecated and should we remove it or are there external users? > None that I am aware of, but it is hard to tell. Eugene, what is you

Re: [edk2] [Patch] CryptoPkg/BaseCryptLib: Fix Build Warning issue in PEI Module

Reviewed-by: Ye Ting -Original Message- From: Long, Qin Sent: Thursday, March 30, 2017 3:47 PM To: Ye, Ting ; Dong, Eric ; Wu, Hao A ; edk2-devel@lists.01.org Subject: [Patch] CryptoPkg/BaseCryptLib: Fix Build Warning issue in PEI Module The memory free operation is empty function in

Re: [edk2] [Patch] CryptoPkg/BaseCryptLib: Fix Build Warning issue in PEI Module

Reviewed-by: Eric Dong -Original Message- From: Long, Qin Sent: Thursday, March 30, 2017 3:47 PM To: Ye, Ting; Dong, Eric; Wu, Hao A; edk2-devel@lists.01.org Subject: [Patch] CryptoPkg/BaseCryptLib: Fix Build Warning issue in PEI Module The memory free operation is empty function in PEI

[edk2] [Patch] CryptoPkg/BaseCryptLib: Fix Build Warning issue in PEI Module

The memory free operation is empty function in PEI. The compiler optimization will bring the build warning in openssl/crypto/mem.c: warning C4718: 'CRYPTO_free': recursive call has no side effects, deleting This patch uses '/wd4718' to silence the build warning for PEI mo

[edk2] [PATCH] BaseTools: Update Brotli and BrotliCompress mode and format

- Add x mode for Brotli and BrotliCompress - Change Brotli and BrotliCompress format from DOS to UNIX Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Bell Song --- BaseTools/BinWrappers/PosixLike/Brotli | 0 BaseTools/BinWrappers/PosixLike/BrotliCom