[edk2] [Patch] BaseTools: update error message for SKUID_IDENTIFIER format

2017-03-31 Thread Yonghong Zhu
Per DSC spec, the SkuUiName use '|' as separator, so this patch update the error message to use '|' but not space as separator. Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Yonghong Zhu --- BaseTools/Source/Python/Common/Misc.py | 4 ++-- 1 file changed,

Re: [edk2] [Patch] MdeModulePkg/DxeHttpLib: Avoid the pointless comparison of UINTN with zero

2017-03-31 Thread Zhang, Lubo
Reviewed-by: Zhang Lubo -Original Message- From: Wu, Jiaxin Sent: Saturday, April 01, 2017 8:22 AM To: edk2-devel@lists.01.org Cc: Bi, Dandan ; Zhang, Lubo ; Ye, Ting ; Fu, Siyuan ; Wu, Jiaxin Subject: [Patch] MdeModulePkg/DxeHttpLib: Avoid the pointless comparison of UINTN with zero

[edk2] [PATCH v2 3/4] CryptoPkg/BaseCryptLib: Adding NULL checking in time() wrapper.

2017-03-31 Thread Long Qin
From: Qin Long There are some explicit time(NULL) calls in openssl-1.1.0xx source, but the dummy time() wrapper in ConstantTimeClock.c (used by PEI and SMM module) has no any checks on NULL parameter. This is one bug and will cause the memory access issue. This patch adds the NULL parameter check

[edk2] [PATCH v2 0/4] Resolving Some CryptoPkg Build Issues

2017-03-31 Thread Long Qin
From: Qin Long V2: Updated the patches as the comments from Laszlo (ler...@redhat.com). And filed two TianoCore BZ (#455, #456) to track the further follow-ups on openssl and EDKII-CryptoPkg: https://bugzilla.tianocore.org/show_bug.cgi?id=455 https://bugzilla.tianocore.org/show_bug.

[edk2] [PATCH v2 1/4] CryptoPkg/OpensslLib: Suppress extra build warnings in openssl source

2017-03-31 Thread Long Qin
From: Qin Long (Need further follow-ups as described in https://bugzilla.tianocore.org/show_bug.cgi?id=455) This patch added some extra build options to suppress possible warnings when building openssl source under GCC48 and VS2010. Including: Adding "-Wno-error=maybe-uninitialized" to supp

[edk2] [PATCH v2 2/4] CryptoPkg: Fix possible unresolved external symbol issue.

2017-03-31 Thread Long Qin
From: Qin Long The compiler (visual studio) may optimize some explicit strcmp call in openssl source to use the intrinsic memcmp call. In CrtLibSupport.h, we just use #define to mapping memcmp to CompareMem API. So in Link phase, this kind of intrinsic optimization will cause the "unresolved exte

[edk2] [PATCH v2 4/4] CryptoPkg: One workaround to resolve potential build issue.

2017-03-31 Thread Long Qin
From: Qin Long This patch duplicates one e_os2.h with minor changes into "CryptoPkg/Include/openssl/" as one workaround to resolve some external components/modules build issue. (NOTE: This duplicated e_os2.h may be removed after upstreaming the changes into openssl. Refer to htt

[edk2] [patch 1/3] BaseTools/UPT: Use a simple way to get package path

2017-03-31 Thread hesschen
Instead of parsing all content of DEC file, just get the package path only to save time. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: hesschen --- .../Source/Python/UPT/Core/DependencyRules.py | 56 ++ 1 file changed, 36 insertions(+), 20 deleti

[edk2] [patch 3/3] BaseTools/UPT: Fix a parser issue

2017-03-31 Thread hesschen
Update the method to get PCD information and support empty section. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: hesschen --- BaseTools/Source/Python/UPT/GenMetaFile/GenInfFile.py | 5 +++-- BaseTools/Source/Python/UPT/GenMetaFile/GenMetaFileMisc.py | 13 -

[edk2] [patch 2/3] BaseTools/UPT: Support Unicode path

2017-03-31 Thread hesschen
Update the IpiDb.py to support Unicode path for localization Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: hesschen --- BaseTools/Source/Python/UPT/Core/IpiDb.py | 8 BaseTools/Source/Python/UPT/UPT.py| 7 ++- 2 files changed, 10 insertions(+), 5 del

Re: [edk2] [PATCH] MdePkg/Shell.h: Update Shell version from 2.1 to 2.2

2017-03-31 Thread Gao, Liming
Reviewed-by: Liming Gao Please add the commit message to support UEFI Shell spec 2.2. >-Original Message- >From: Ni, Ruiyu >Sent: Friday, March 31, 2017 10:24 PM >To: edk2-devel@lists.01.org >Cc: Kinney D Michael ; Carsey, Jaben >; Gao, Liming >Subject: [PATCH] MdePkg/Shell.h: Update Sh

Re: [edk2] Using Intel UDk debugger

2017-03-31 Thread Ni, Ruiyu
Arka, Can you make sure that the source code is not modified after the image symbol is generated by compiler? And can you send me a screenshot of WinDbg when you are using the unresolved breakpoint feature? I need to see which command is auto-pasted to WinDbg from UDK Debugger. Thanks/Ray > -

[edk2] Do edk2 contains Intel Edison Platform?

2017-03-31 Thread wang xiaofeng
Hi , Do anyone knows whether there is an open source edk2 bios platform project for Intel Edison board? Can QuarkSocpkg support Edison ? Thanks in advance! ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo

[edk2] [patch] MdeModulePkg/UefiHiiLib:Fix incorrect comparison expression

2017-03-31 Thread Dandan Bi
Fix the incorrect comparison between pointer and constant zero character. https://bugzilla.tianocore.org/show_bug.cgi?id=416 Cc: Eric Dong Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi --- MdeModulePkg/Library/UefiHiiLib/HiiLib.c | 2 +- 1 fil

Re: [edk2] [Patch 2/4] CryptoPkg: Fix possible unresolved external symbol issue.

2017-03-31 Thread Long, Qin
> -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Saturday, April 01, 2017 2:45 AM > To: Long, Qin; edk2-devel@lists.01.org > Cc: Ye, Ting; Wu, Hao A; Tian, Feng; Dong, Eric > Subject: Re: [Patch 2/4] CryptoPkg: Fix possible unresolved external symbol > issue. >

Re: [edk2] [Patch 4/4] CryptoPkg: One workaround to resolve potential build issue.

2017-03-31 Thread Long, Qin
Yes, will follow the openssl upstreaming and next clean-ups. Thanks. > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Saturday, April 01, 2017 2:50 AM > To: Long, Qin; edk2-devel@lists.01.org > Cc: Ye, Ting; Wu, Hao A; Tian, Feng; Dong, Eric > Subject: Re: [Pat

Re: [edk2] [Patch] BaseTools: Enhance StrDefs.h to include ImageDefs.h

2017-03-31 Thread Gao, Liming
Reviewed-by: Liming Gao >-Original Message- >From: Zhu, Yonghong >Sent: Friday, March 31, 2017 10:22 PM >To: edk2-devel@lists.01.org >Cc: Gao, Liming >Subject: [Patch] BaseTools: Enhance StrDefs.h to include ImageDefs.h > >Enhance StrDefs.h to include ImageDefs.h for VfrCompiler to suppo

Re: [edk2] [Patch] BaseTools: Enhance expression to support some more operation

2017-03-31 Thread Gao, Liming
Reviewed-by: Liming Gao >-Original Message- >From: Zhu, Yonghong >Sent: Friday, March 31, 2017 10:22 PM >To: edk2-devel@lists.01.org >Cc: Gao, Liming >Subject: [Patch] BaseTools: Enhance expression to support some more >operation > >Enhance expression to support some more operation that

Re: [edk2] [Patch 3/4] CryptoPkg/BaseCryptLib: Adding NULL checking in timer() wrapper.

2017-03-31 Thread Long, Qin
Got it. Will correct the commit message. Thanks. > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Saturday, April 01, 2017 2:46 AM > To: Long, Qin; edk2-devel@lists.01.org > Cc: Ye, Ting; Wu, Hao A; Tian, Feng; Dong, Eric > Subject: Re: [Patch 3/4] CryptoPkg/Bas

Re: [edk2] [Patch 1/4] CryptoPkg/OpensslLib: Suppress extra build warnings in openssl source

2017-03-31 Thread Long, Qin
Exactly. Thanks, Laszlo. Since we will keep the openssl source original after this upgrade, I have to leverage extra build option to suppress these two warnings this time. Yes, I prefer to keep /Werror as possible, I will follow-up the next openssl PR and a TianoCore BZ. Best Regards & Thanks

Re: [edk2] [PATCH v2 0/3] UefiCpuPkg/PiSmmCpuDxeSmm: Check all SMM ranges found

2017-03-31 Thread Yao, Jiewen
Reviewed-by: jiewen@intel.com > -Original Message- > From: Fan, Jeff > Sent: Saturday, April 1, 2017 8:52 AM > To: edk2-devel@lists.01.org > Cc: Yao, Jiewen ; Kinney, Michael D > ; Tian, Feng > Subject: [PATCH v2 0/3] UefiCpuPkg/PiSmmCpuDxeSmm: Check all SMM ranges > found > > NX/Smm

[edk2] [PATCH v2 0/3] UefiCpuPkg/PiSmmCpuDxeSmm: Check all SMM ranges found

2017-03-31 Thread Jeff Fan
NX/SmmProfile feature required to protect all SMM ranges. This update is to check additonal saved SMM ranges besides the range specified by mCpuHotPlugData.SmrrBase/mCpuHotPlugData.SmrrSiz. v2: #1: Add #define SMRR_MAX_ADDRESS to clarify SMRR requirement. Cc: Jiewen Yao Cc: Michael Kinney Cc:

[edk2] [PATCH v2 3/3] UefiCpuPkg/PiSmmCpuDxeSmm: Update saved SMM ranges check in SmmProfile

2017-03-31 Thread Jeff Fan
SmmProfile feature required to protect all SMM ranges by structure mProtectionMemRangeTemplate. This update is to add additonal save SMM ranges into mProtectionMemRangeTemplate besides the range specified by mCpuHotPlugData.SmrrBase/mCpuHotPlugData.SmrrSiz. Cc: Jiewen Yao Cc: Michael Kinney Cc:

[edk2] [PATCH v2 1/3] UefiCpuPkg/PiSmmCpuDxeSmm: Save SMM ranges info into global variables

2017-03-31 Thread Jeff Fan
v2: Add #define SMRR_MAX_ADDRESS to clarify SMRR requirement. Cc: Jiewen Yao Cc: Michael Kinney Cc: Feng Tian Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jeff Fan --- UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.c | 44 -- UefiCpuPkg/PiSmmC

[edk2] [PATCH v2 2/3] UefiCpuPkg/PiSmmCpuDxeSmm: Add IsInSmmRanges() to check SMM range

2017-03-31 Thread Jeff Fan
Internal function IsInSmmRanges() is added t check SMM range by saved SMM ranges beside by mCpuHotPlugData.SmrrBase/mCpuHotPlugData.SmrrSiz. Cc: Jiewen Yao Cc: Michael Kinney Cc: Feng Tian Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jeff Fan --- UefiCpuPkg/PiSmmCpuD

[edk2] [Patch] MdeModulePkg/DxeHttpLib: Avoid the pointless comparison of UINTN with zero

2017-03-31 Thread Jiaxin Wu
UINTN is unsigned integer, so it's pointless to compare it with zero. Cc: Bi Dandan Cc: Zhang Lubo Cc: Ye Ting Cc: Fu Siyuan Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Wu Jiaxin --- MdeModulePkg/Library/DxeHttpLib/DxeHttpLib.c | 2 +- MdeModulePkg/Library/DxeHttpL

Re: [edk2] [RFC v2] GitBook documentation process

2017-03-31 Thread Kinney, Michael D
Hello, One more EDK II Gitbook update this week. The EDK II Build Specification has been converted and is ready for review. https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Draft-Specification Mike > -Original Message- > From: Kinney, Michael D > Sent: Tuesday, March 28, 2

[edk2] Request: please test NASM 2.13rc9

2017-03-31 Thread H. Peter Anvin
Hello, NASM 2.13rc9 is out, and it is expected to be very close to the final 2.13. I would really appreciate some help testing this prerelease, to make sure: a) it doesn't break anyone's code; b) it isn't missing any critical features(*). 2.13rc9, as well as git tree and nightly build, is avail

Re: [edk2] [RFC PATCH 0/6] OVMF: HFS+ (and Mac OS X boot)

2017-03-31 Thread Gabriel L. Somlo
Hi Phil, On Thu, Mar 30, 2017 at 12:22:16PM +1300, Phil Dennis-Jordan wrote: > First off, thanks for going to the effort of building an HFS+ driver! > Due to travel, I've only just got around to checking these out, sorry. > > Before I can try to help out with cleaning the patches up to the > exte

Re: [edk2] [Patch 4/4] CryptoPkg: One workaround to resolve potential build issue.

2017-03-31 Thread Laszlo Ersek
On 03/31/17 19:05, Qin Long wrote: > This patch duplicates one e_os2.h with minor changes into > "CryptoPkg/Include/openssl/" as one workaround to resolve some > external components/modules build issue. > The BaseCryptLib consumer should ONLY include "BaseCryptLib.h" to > use the exposed APIs. But

Re: [edk2] [Patch 3/4] CryptoPkg/BaseCryptLib: Adding NULL checking in timer() wrapper.

2017-03-31 Thread Laszlo Ersek
On 03/31/17 19:05, Qin Long wrote: > There are some explicit timer(NULL) calls in openssl-1.1.0xx source, > but the dummy timer() wrapper in ConstantTimeClock.c (used by PEI > and SMM module) has no any checks on NULL parameter. This will > cause the memory access issue. > This patch adds the NULL

Re: [edk2] [Patch 2/4] CryptoPkg: Fix possible unresolved external symbol issue.

2017-03-31 Thread Laszlo Ersek
On 03/31/17 19:05, Qin Long wrote: > The compiler (visual studio) may optimize some explicit strcmp call > to use the intrinsic memcmp call. In CrtLibSupport.h, we just use > #define to mapping memcmp to CompareMem API. So in Link phase, this > kind of intrinsic optimization will cause the "unreso

Re: [edk2] [Patch 1/4] CryptoPkg/OpensslLib: Suppress extra build warnings in openssl source

2017-03-31 Thread Laszlo Ersek
On 03/31/17 19:05, Qin Long wrote: > This patch added some extra build options to suppress possible warnings > when building openssl source under GCC48 and VS2010. Including: > > Adding "-Wno-error=maybe-uninitialized" to suppress the following GCC48 > build warning: > OpensslLib/openssl/ssl/sta

Re: [edk2] DisconnectController API not working.

2017-03-31 Thread Andrew Fish
> On Mar 31, 2017, at 5:26 AM, Amit kumar wrote: > > > Hi , > > I am trying to disconnect a controller from the usb mass storage driver, for > which i am using > >Status = gBS->DisconnectController ( > ControllerHandle, > NULL, >

[edk2] [Patch 4/4] CryptoPkg: One workaround to resolve potential build issue.

2017-03-31 Thread Qin Long
This patch duplicates one e_os2.h with minor changes into "CryptoPkg/Include/openssl/" as one workaround to resolve some external components/modules build issue. The BaseCryptLib consumer should ONLY include "BaseCryptLib.h" to use the exposed APIs. But some external modules call OpenSSL API direct

[edk2] [Patch 2/4] CryptoPkg: Fix possible unresolved external symbol issue.

2017-03-31 Thread Qin Long
The compiler (visual studio) may optimize some explicit strcmp call to use the intrinsic memcmp call. In CrtLibSupport.h, we just use #define to mapping memcmp to CompareMem API. So in Link phase, this kind of intrinsic optimization will cause the "unresolved external symbol" error. For example:

[edk2] [Patch 3/4] CryptoPkg/BaseCryptLib: Adding NULL checking in timer() wrapper.

2017-03-31 Thread Qin Long
There are some explicit timer(NULL) calls in openssl-1.1.0xx source, but the dummy timer() wrapper in ConstantTimeClock.c (used by PEI and SMM module) has no any checks on NULL parameter. This will cause the memory access issue. This patch adds the NULL parameter checking in timer() wrapper. Cc: T

[edk2] [Patch 0/4] *** Resolving CryptoPkg build issues ***

2017-03-31 Thread Qin Long
This patch series introduced some hotfixes and workaround to resolve the build issues under different toolchain, and from potential external consumers, including: - build warning under GCC48 and VS2010 toolchain; - Potential unresolved external symbol link issue; - One bug fix of timer() wrap

[edk2] [Patch 1/4] CryptoPkg/OpensslLib: Suppress extra build warnings in openssl source

2017-03-31 Thread Qin Long
This patch added some extra build options to suppress possible warnings when building openssl source under GCC48 and VS2010. Including: Adding "-Wno-error=maybe-uninitialized" to suppress the following GCC48 build warning: OpensslLib/openssl/ssl/statem/statem_clnt.c:2543:9: error: "len" may

Re: [edk2] [PATCH 00/10] Use a better algorithm to calculate MTRR

2017-03-31 Thread Laszlo Ersek
On 03/31/17 16:25, Ni, Ruiyu wrote: > Just fixed the build failure. sorry about that. No problem -- I wasn't annoyed or anything (such breakages are unavoidable without a centralized build farm, as no developer can test-build the tree with all the supported toolchains), I just wanted to report it.

Re: [edk2] [PATCH 00/10] Use a better algorithm to calculate MTRR

2017-03-31 Thread Ni, Ruiyu
Just fixed the build failure. sorry about that. Regards, Ray >-Original Message- >From: Laszlo Ersek [mailto:ler...@redhat.com] >Sent: Friday, March 31, 2017 5:11 PM >To: Ni, Ruiyu ; edk2-devel@lists.01.org >Subject: Re: [edk2] [PATCH 00/10] Use a better algorithm to calculate MTRR > >On

[edk2] [PATCH] MdePkg/Shell.h: Update Shell version from 2.1 to 2.2

2017-03-31 Thread Ruiyu Ni
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ruiyu Ni Cc: Michael D Kinney Cc: Jaben Carsey Cc: Liming Gao --- MdePkg/Include/Protocol/Shell.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/MdePkg/Include/Protocol/Shell.h b/MdePkg/Include/Prot

[edk2] [PATCH] MdePkg/Shell.h: Update Shell version from 2.1 to 2.2

2017-03-31 Thread Ruiyu Ni
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ruiyu Ni Cc: Kinney D Michael Cc: Jaben Carsey Cc: Liming Gao --- MdePkg/Include/Protocol/Shell.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/MdePkg/Include/Protocol/Shell.h b/MdePkg/Include/Prot

[edk2] [Patch] BaseTools: Enhance StrDefs.h to include ImageDefs.h

2017-03-31 Thread Yonghong Zhu
Enhance StrDefs.h to include ImageDefs.h for VfrCompiler to support IMAGE_TOKEN usage. Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Yonghong Zhu --- BaseTools/Source/Python/AutoGen/GenC.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/BaseTools/

[edk2] [Patch] BaseTools: Enhance expression to support some more operation

2017-03-31 Thread Yonghong Zhu
Enhance expression to support some more operation that allowed in the spec, eg: *, /, %, <<, >>, ~. Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Yonghong Zhu --- BaseTools/Source/Python/Common/Expression.py | 28 +++- 1 file chang

[edk2] [PATCH v2 12/13] Platforms/Juno: add DtPlatformDtbLoaderLib implementation

2017-03-31 Thread Ard Biesheuvel
In preparation of switching to DtPlatformDxe to supply the device tree image to the OS, add an implementation of DtPlatformDtbLoaderLib that loads the correct version from an FV. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel --- Platforms/ARM/Juno/Library

[edk2] [PATCH v2 11/13] Platforms/Juno: remove BdsLib dependency

2017-03-31 Thread Ard Biesheuvel
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel --- Platforms/ARM/Juno/ArmJuno.dsc | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/Platforms/ARM/Juno/ArmJuno.dsc b/Platforms/ARM/Juno/ArmJuno.dsc index b7b1fb8c8935..4ff2246822e6 100644

[edk2] [PATCH v2 13/13] Platforms/Juno: switch to DtPlatformDxe

2017-03-31 Thread Ard Biesheuvel
Switch to DtPLatformDxe, which uses embedded DTB binaries, or ACPI, but does not have the elaborate (but awkward) tooling to load FDT files from device paths. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel --- Platforms/ARM/Juno/ArmJuno.dsc| 15

[edk2] [PATCH v2 10/13] Platforms/Juno: switch to generic PCI host bridge driver

2017-03-31 Thread Ard Biesheuvel
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel --- Platforms/ARM/Juno/ArmJuno.dsc | 17 +++-- Platforms/ARM/Juno/ArmJuno.fdf | 4 ++-- 2 files changed, 13 insertions(+), 8 deletions(-) diff --git a/Platforms/ARM/Juno/ArmJuno.dsc b/Platforms/ARM

[edk2] [PATCH v2 09/13] Platforms/Juno: add PciHostBridgeLib implementation

2017-03-31 Thread Ard Biesheuvel
In order to be able to switch to the generic PCI host bridge driver, implement the glue library that exposes the PCIe parameters to the common driver. Since the Juno performs some initialization of the PCIe control registers as well, copy that code into the library's constructor. Contributed-under

[edk2] [PATCH v2 04/13] Platforms/VExpress: remove BdsLib library class resolutions

2017-03-31 Thread Ard Biesheuvel
ArmHwDxe and ArmFvpDxe no longer require a BdsLib library class resolution, so remove the explicit ones from the various .DSCs. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel --- Platforms/ARM/VExpress/ArmVExpress-CTA15-A7.dsc| 5 + Platforms/ARM/VE

[edk2] [PATCH v2 05/13] Platforms/TC2: move to new DtPlatformDxe driver

2017-03-31 Thread Ard Biesheuvel
Replace the slightly overengineered FdtPlatformDxe driver with the new and simple DtPlatformDxe driver, which simply exposes a single builtin device tree binary to the OS. Note that this driver is configurable, i.e., it allows ACPI to be selected instead of device tree, in which case AcpiPlatformD

[edk2] [PATCH v2 00/13] EDK2 spring cleaning -- OpenPlatformPkg edition

2017-03-31 Thread Ard Biesheuvel
This is the OpenPlatformPkg counterpart of the series ArmPlatformgPkg spring cleaning -- now includes Juno [v2] sent out out roughly the same time as this one. Note that they are inter- dependent, i.e., applying one without the other will not result in a working build. Changes since v1: - add

[edk2] [PATCH v2 03/13] Platforms/VExpress: get rid of Tiano compression

2017-03-31 Thread Ard Biesheuvel
There are some references to Tiano compression and to libraries that implement it, but we never use it. So get rid of it. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel --- Platforms/ARM/Juno/ArmJuno.fdf | 9 - Platforms/ARM/VExp

[edk2] [PATCH v2 02/13] Platforms/VExpress: remove unused StatusCode references

2017-03-31 Thread Ard Biesheuvel
We never use the status code facility, so remove the libraries and other references to it. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel --- Platforms/ARM/VExpress/ArmVExpress-FVP-AArch64.dsc | 1 - Platforms/ARM/VExpress/ArmVExpress-FVP-AArch64.fdf | 1

[edk2] [PATCH v2 08/13] Platforms/Juno: add non-discoverable device driver and library

2017-03-31 Thread Ard Biesheuvel
In preparation of moving ArmJunoDxe's support of the OHCI and EHCI controllers to the generic non-discoverable device infrastructure, add the prerequisite driver and library class resolution to the Juno platform description. Note that the FD image size needs to be increased slightly to accommodate

[edk2] [PATCH v2 07/13] Platforms/FVP-AArch64: switch to simpler DT platform driver

2017-03-31 Thread Ard Biesheuvel
Replace the elaborate but awkward FdtPlatformDxe with the new DtPlatformDxe, which supports embedded DTBs only. This is sufficient for virtually all use cases, and if it is not, there are various way to override the device tree binary presented to the OS. As a bonus, this driver makes ACPI and DT

[edk2] [PATCH v2 06/13] Platforms/FVP: add DtPlatformDtbLoaderLib implementation

2017-03-31 Thread Ard Biesheuvel
In preparation of switching to DtPlatformDxe to supply the device tree image to the OS, add an implementation of DtPlatformDtbLoaderLib that loads the correct version from an FV. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel --- Platforms/ARM/VExpress/Lib

[edk2] [PATCH v2 01/13] Platforms/VExpress: remove unused logo PCD

2017-03-31 Thread Ard Biesheuvel
This file and associated PCD are no longer used by our BDS code, so remove them. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel --- Platforms/ARM/VExpress/ArmVExpress-CTA15-A7.fdf| 7 --- Platforms/ARM/VExpress/ArmVExpress-FVP-AArch64.fdf | 7 --

[edk2] [PATCH v2 9/9] ArmPlatformPkg/ArmJunoDxe: remove FDT handling

2017-03-31 Thread Ard Biesheuvel
Change ArmJunoDxe to be compatible with the new DtPlatformDxe driver, which simply selects one of three embedded DTB binaries based on the current hardware. It also introduces a config screen in the UEFI setup menu that allows either ACPI or DT to be selected (but not both) For this module, it sim

[edk2] [PATCH v2 8/9] ArmPlatformPkg/ArmJunoDxe: simplify ACPI table installation

2017-03-31 Thread Ard Biesheuvel
Having a three way conditional with callbacks would make sense if the callbacks weren't (a) identical and (b) didn't return TRUE all the time. So get rid of the kludge. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel --- ArmPlatformPkg/ArmJunoPkg/Drivers/Arm

[edk2] [PATCH v2 6/9] ArmPlatformPkg/ArmJunoPkg: remove PCI host bridge driver

2017-03-31 Thread Ard Biesheuvel
This driver will no longer be used once we switch Juno to the generic PCI host bridge driver. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel --- ArmPlatformPkg/ArmJunoPkg/Drivers/PciHostBridgeDxe/PciHostBridge.c | 199 -- ArmPlatformP

[edk2] [PATCH v2 7/9] ArmPlatformPkg/ArmJunoDxe: remove BdsLib dependency

2017-03-31 Thread Ard Biesheuvel
The ArmJunoDxe driver does not actually depend on the deprecated BdsLib so remove the dependency declaration from the INF file. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel --- ArmPlatformPkg/ArmJunoPkg/Drivers/ArmJunoDxe/ArmJunoDxe.inf | 1 - 1 file chan

[edk2] [PATCH v2 5/9] ArmPlatformPkg/ArmJunoDxe: use the generic non-discoverable device support

2017-03-31 Thread Ard Biesheuvel
Replace the open coded reimplementation of 'PCI emulation' with a pair of calls into NonDiscoverableDeviceRegistrationLib to register the OHCI and EHCI controllers. These will be picked up by the generic driver instead. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Bie

[edk2] [PATCH v2 2/9] ArmPlatformPkg/ArmVExpressDxe: remove ARM support

2017-03-31 Thread Ard Biesheuvel
The 32-bit ARM support in this driver is unused, and thus untested. So let's just remove it. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel --- ArmPlatformPkg/ArmVExpressPkg/ArmVExpressDxe/Arm/ArmFvpDxeArm.c | 84 ArmPlatformPkg/ArmVEx

[edk2] [PATCH v2 0/9] ArmPlatformgPkg spring cleaning -- now includes Juno

2017-03-31 Thread Ard Biesheuvel
This implements the upstream part of switching VExpress TC2, Juno and the AArch64 FVP Foundation/Base models to the new DtPlatformDxe driver, which is much simpler and only allows ACPI or DT to be enabled but never both. In addition, this removes the Juno PCI host bridge driver, which is no longer

[edk2] [PATCH v2 3/9] ArmPlatformPkg/ArmVExpressDxe: remove unused cruft from ArmHwDxe

2017-03-31 Thread Ard Biesheuvel
Remove unused cruft from ArmHwDxe -- the only thing that remains is installation of the 'runaxf' shell command. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel --- ArmPlatformPkg/ArmVExpressPkg/ArmVExpressDxe/ArmHwDxe.c | 43 +--- ArmPlatf

[edk2] [PATCH v2 1/9] ArmPlatformPkg/ArmShellCmdRunAxf: remove BdsLib dependency

2017-03-31 Thread Ard Biesheuvel
Remove ArmShellCmdRunAxf's dependency on the deprecated BdsLib by cloning the ShutdownUefiBootServices() routine into a local source file; this is the only BdsLib feature 'runaxf' depends on. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel --- ArmPlatformPkg

[edk2] [PATCH v2 4/9] ArmPlatformPkg/ArmVExpressDxe: remove FDT handling

2017-03-31 Thread Ard Biesheuvel
Replace the elaborate but awkward handling of FDT images using device paths and string PCDs initialized to 128 spaces with a simple scheme involving a set of builtin DTBs and a bit of runtime logic to select between them. This is sufficient for ordinary use, which makes it more suitable as referen

Re: [edk2] [PATCH v2 3/3] EmbeddedPkg/DtPlatformDxe: load platform DTB via new library

2017-03-31 Thread Laszlo Ersek
On 03/31/17 14:22, Ard Biesheuvel wrote: > On 31 March 2017 at 12:39, Laszlo Ersek wrote: >> On 03/31/17 12:56, Ard Biesheuvel wrote: >>> To give platforms some room to decide which DTB is suitable and where >>> to load it from, indirect loading of the DTB image via the new >>> DtPlatformDtbLoader

[edk2] DisconnectController API not working.

2017-03-31 Thread Amit kumar
Hi , I am trying to disconnect a controller from the usb mass storage driver, for which i am using   Status = gBS->DisconnectController ( ControllerHandle, NULL, NULL );

Re: [edk2] [PATCH v2 0/3] EmbeddedPkg: revert DTB loading to platform lib

2017-03-31 Thread Ard Biesheuvel
On 31 March 2017 at 11:56, Ard Biesheuvel wrote: > This updates the recently added DtPlatformDxe to indirect loading of the > actual DTB binary to a separate library. A base implementation is provided > that preserves the original behavior. > > This way, we can allow platforms such as FVP or Juno

Re: [edk2] [PATCH v2 3/3] EmbeddedPkg/DtPlatformDxe: load platform DTB via new library

2017-03-31 Thread Ard Biesheuvel
On 31 March 2017 at 12:39, Laszlo Ersek wrote: > On 03/31/17 12:56, Ard Biesheuvel wrote: >> To give platforms some room to decide which DTB is suitable and where >> to load it from, indirect loading of the DTB image via the new >> DtPlatformDtbLoaderLib library class. > > I think you accidentally

Re: [edk2] [PATCH v2 3/3] EmbeddedPkg/DtPlatformDxe: load platform DTB via new library

2017-03-31 Thread Laszlo Ersek
On 03/31/17 12:56, Ard Biesheuvel wrote: > To give platforms some room to decide which DTB is suitable and where > to load it from, indirect loading of the DTB image via the new > DtPlatformDtbLoaderLib library class. I think you accidentally the verb in the above sentence :) > > Contributed-und

Re: [edk2] [PATCH v2 2/3] EmbeddedPkg: add base DtPlatformDtbLoaderLib implementation

2017-03-31 Thread Laszlo Ersek
On 03/31/17 12:56, Ard Biesheuvel wrote: > Introduce an implementation of the new DtPlatformDtbLoaderLib library > class that simply retrieves the first raw section for an FV file named s/for/of/ ? > gDtPlatformDefaultDtbFileGuid. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Sig

Re: [edk2] [PATCH v2 1/3] EmbeddedPkg: add DtPlatformDtbLoaderLib library class

2017-03-31 Thread Laszlo Ersek
On 03/31/17 12:56, Ard Biesheuvel wrote: > To abstract the way a platform reasons about which DTB is appropriate, > and the way it ultimately supplies the DTB image, introduce a new library > class to encapsulate this functionality. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Sig

[edk2] [PATCH v2 1/3] EmbeddedPkg: add DtPlatformDtbLoaderLib library class

2017-03-31 Thread Ard Biesheuvel
To abstract the way a platform reasons about which DTB is appropriate, and the way it ultimately supplies the DTB image, introduce a new library class to encapsulate this functionality. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel --- EmbeddedPkg/Embedded

[edk2] [PATCH v2 0/3] EmbeddedPkg: revert DTB loading to platform lib

2017-03-31 Thread Ard Biesheuvel
This updates the recently added DtPlatformDxe to indirect loading of the actual DTB binary to a separate library. A base implementation is provided that preserves the original behavior. This way, we can allow platforms such as FVP or Juno (which use the same firmware image but different DTB images

[edk2] [PATCH v2 2/3] EmbeddedPkg: add base DtPlatformDtbLoaderLib implementation

2017-03-31 Thread Ard Biesheuvel
Introduce an implementation of the new DtPlatformDtbLoaderLib library class that simply retrieves the first raw section for an FV file named gDtPlatformDefaultDtbFileGuid. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel --- EmbeddedPkg/EmbeddedPkg.dsc

[edk2] [PATCH v2 3/3] EmbeddedPkg/DtPlatformDxe: load platform DTB via new library

2017-03-31 Thread Ard Biesheuvel
To give platforms some room to decide which DTB is suitable and where to load it from, indirect loading of the DTB image via the new DtPlatformDtbLoaderLib library class. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel --- EmbeddedPkg/Drivers/DtPlatformDxe/D

Re: [edk2] [PATCH v2] ArmVirtPkg/PlatformHasAcpiDtDxe: allow guest level ACPI disable override

2017-03-31 Thread Ard Biesheuvel
On 31 March 2017 at 10:20, Marc Zyngier wrote: > On 30/03/17 09:40, Ard Biesheuvel wrote: >> On 29 March 2017 at 20:35, Laszlo Ersek wrote: >>> On 03/29/17 21:10, Ard Biesheuvel wrote: >> [...] How on earth is having two ways to disable ACPI rather than one going to cause fragmenta

Re: [edk2] [PATCH v2] ArmVirtPkg/PlatformHasAcpiDtDxe: allow guest level ACPI disable override

2017-03-31 Thread Ard Biesheuvel
On 30 March 2017 at 17:16, Laszlo Ersek wrote: > On 03/30/17 10:40, Ard Biesheuvel wrote: >> On 29 March 2017 at 20:35, Laszlo Ersek wrote: >>> On 03/29/17 21:10, Ard Biesheuvel wrote: >> [...] How on earth is having two ways to disable ACPI rather than one going to cause fragmenta

Re: [edk2] [PATCH v2] ArmVirtPkg/PlatformHasAcpiDtDxe: allow guest level ACPI disable override

2017-03-31 Thread Laszlo Ersek
On 03/31/17 12:16, Ard Biesheuvel wrote: > On 31 March 2017 at 10:59, Laszlo Ersek wrote: >> On 03/31/17 11:20, Marc Zyngier wrote: >>> On 30/03/17 09:40, Ard Biesheuvel wrote: On 29 March 2017 at 20:35, Laszlo Ersek wrote: > On 03/29/17 21:10, Ard Biesheuvel wrote: [...] >> >>>

Re: [edk2] [PATCH] BeagleBoardPkg: add missing BootLogoLib resolution

2017-03-31 Thread Ard Biesheuvel
On 31 March 2017 at 11:11, Laszlo Ersek wrote: > On 03/31/17 11:46, Ard Biesheuvel wrote: >> Recent changes to the PlatformBootManagerLib implementation in ArmPkg >> require its users to define a resolution for BootLogoLib. So add this >> missing resolution to Beagle. >> >> Contributed-under: Tian

Re: [edk2] [PATCH v2] ArmVirtPkg/PlatformHasAcpiDtDxe: allow guest level ACPI disable override

2017-03-31 Thread Ard Biesheuvel
On 31 March 2017 at 10:59, Laszlo Ersek wrote: > On 03/31/17 11:20, Marc Zyngier wrote: >> On 30/03/17 09:40, Ard Biesheuvel wrote: >>> On 29 March 2017 at 20:35, Laszlo Ersek wrote: On 03/29/17 21:10, Ard Biesheuvel wrote: >>> [...] > > How on earth is having two ways to disable ACP

Re: [edk2] [PATCH] BeagleBoardPkg: add missing BootLogoLib resolution

2017-03-31 Thread Laszlo Ersek
On 03/31/17 11:46, Ard Biesheuvel wrote: > Recent changes to the PlatformBootManagerLib implementation in ArmPkg > require its users to define a resolution for BootLogoLib. So add this > missing resolution to Beagle. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Ard

Re: [edk2] [PATCH v2] ArmVirtPkg/PlatformHasAcpiDtDxe: allow guest level ACPI disable override

2017-03-31 Thread Laszlo Ersek
On 03/31/17 11:59, Laszlo Ersek wrote: > On 03/31/17 11:20, Marc Zyngier wrote: >> On 30/03/17 09:40, Ard Biesheuvel wrote: >>> On 29 March 2017 at 20:35, Laszlo Ersek wrote: On 03/29/17 21:10, Ard Biesheuvel wrote: >>> [...] > > How on earth is having two ways to disable ACPI rather

Re: [edk2] [PATCH v2] ArmVirtPkg/PlatformHasAcpiDtDxe: allow guest level ACPI disable override

2017-03-31 Thread Laszlo Ersek
On 03/31/17 11:20, Marc Zyngier wrote: > On 30/03/17 09:40, Ard Biesheuvel wrote: >> On 29 March 2017 at 20:35, Laszlo Ersek wrote: >>> On 03/29/17 21:10, Ard Biesheuvel wrote: >> [...] How on earth is having two ways to disable ACPI rather than one going to cause fragmentation? Unl

Re: [edk2] [PATCH 0/6] Embedded|ArmPlatformPkg: spring cleaning + DtPlatformDxe switch

2017-03-31 Thread Laszlo Ersek
On 03/31/17 11:22, Ard Biesheuvel wrote: > On 30 March 2017 at 19:28, Laszlo Ersek wrote: > [...] >> >> What do you think of the following proposal instead (I have no strong >> feelings about this, just picking your mind): >> >> (1) In commit 779cc439e881 ("EmbeddedPkg: add DT platform driver to >

[edk2] [PATCH] BeagleBoardPkg: add missing BootLogoLib resolution

2017-03-31 Thread Ard Biesheuvel
Recent changes to the PlatformBootManagerLib implementation in ArmPkg require its users to define a resolution for BootLogoLib. So add this missing resolution to Beagle. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel --- BeagleBoardPkg/BeagleBoardPkg.dsc |

Re: [edk2] [PATCH 0/3] Arm*Pkg : remove ArmCpuLib

2017-03-31 Thread Ard Biesheuvel
On 31 March 2017 at 10:01, Laszlo Ersek wrote: > On 03/31/17 10:52, Ard Biesheuvel wrote: >> As pointed out by Michael, ArmCpuLib is not used, and doesn't contain >> anything particularly interesting or appropriate for doing in non-secure >> EL2/1. So let's remove it before someone decides to use

Re: [edk2] [PATCH v2] BaseTools/GCC AARCH64: force disable PIC code generation

2017-03-31 Thread Ard Biesheuvel
On 31 March 2017 at 09:59, Laszlo Ersek wrote: > On 03/31/17 10:40, Ard Biesheuvel wrote: >> As a security measure, some distro toolchains now default to PIC code >> generation, allowing executables (as opposed to shared libraries) using >> the objects to be built as PIE binaries, which can be loa

Re: [edk2] [PATCH 0/6] Embedded|ArmPlatformPkg: spring cleaning + DtPlatformDxe switch

2017-03-31 Thread Ard Biesheuvel
On 30 March 2017 at 19:28, Laszlo Ersek wrote: [...] > > What do you think of the following proposal instead (I have no strong > feelings about this, just picking your mind): > > (1) In commit 779cc439e881 ("EmbeddedPkg: add DT platform driver to > select between DT and ACPI", 2017-03-27), a drive

Re: [edk2] Using Intel UDk debugger

2017-03-31 Thread Arka Sharma
Thanks Jeff. Using CpuBreakPoint() has temporarily solved the purpose. But I need the symbols to be loaded properly. Please let me know if I missed something in building the application. As mentioned earlier I have disabled optimization and used --keepexceptiontable in GenFw. Is there something el

Re: [edk2] [PATCH 00/10] Use a better algorithm to calculate MTRR

2017-03-31 Thread Laszlo Ersek
On 03/29/17 05:03, Ruiyu Ni wrote: > The new algorithm finds out the more optimal MTRR solution for > current memory type settings. > Compare against the original algorithm, the new one guarantees > to find the correct MTRR solution, but doesn't guarantee to > find the most optimal MTRR solution. >

Re: [edk2] [PATCH 0/3] Arm*Pkg : remove ArmCpuLib

2017-03-31 Thread Laszlo Ersek
On 03/31/17 10:52, Ard Biesheuvel wrote: > As pointed out by Michael, ArmCpuLib is not used, and doesn't contain > anything particularly interesting or appropriate for doing in non-secure > EL2/1. So let's remove it before someone decides to use it. > > Ard Biesheuvel (3): > ArmVirtPkg: remove A

Re: [edk2] [PATCH v2] BaseTools/GCC AARCH64: force disable PIC code generation

2017-03-31 Thread Laszlo Ersek
On 03/31/17 10:40, Ard Biesheuvel wrote: > As a security measure, some distro toolchains now default to PIC code > generation, allowing executables (as opposed to shared libraries) using > the objects to be built as PIE binaries, which can be loaded at a random > virtual offset. > > However, our E

[edk2] [PATCH 3/3] ArmPkg: remove ArmCpuLib header and implementations

2017-03-31 Thread Ard Biesheuvel
Remove ArmCpuLib entirely. It is no longer used. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel --- ArmPkg/ArmPkg.dsc | 7 -- ArmPkg/Drivers/ArmCpuLib/ArmCortexA15Lib/ArmCortexA15Lib.c| 67 --

[edk2] [PATCH 1/3] ArmVirtPkg: remove ArmCpuLib references

2017-03-31 Thread Ard Biesheuvel
ArmCpuLib is never used anywhere, and is about to be removed. So remove any references from our .DSC files. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel --- ArmVirtPkg/ArmVirtQemu.dsc | 6 -- ArmVirtPkg/ArmVirtQemuKernel.dsc | 6 -- ArmVirtP

[edk2] [PATCH 2/3] BeagleBoardPkg: remove ArmCpuLib reference

2017-03-31 Thread Ard Biesheuvel
ArmCpuLib is not used, and will be removed. So drop the reference from our .DSC Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel --- BeagleBoardPkg/BeagleBoardPkg.dsc | 1 - 1 file changed, 1 deletion(-) diff --git a/BeagleBoardPkg/BeagleBoardPkg.dsc b/Beag

  1   2   >