[edk2] [Patch][edk2-platforms/devel-MinnowBoard3 3/3] Fix set variable issue

2017-04-04 Thread Guo, Mang
Change variable attribute to fix variable couldn't be set issue. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Guo Mang --- .../BroxtonPlatformPkg/Common/PlatformSettings/PlatformDxe/Platform.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Platfo

[edk2] [Patch][edk2-platforms/devel-MinnowBoard3 2/3] Override PiSmmCpuDxeSmm

2017-04-04 Thread Guo, Mang
Override PiSmmCpuDxeSmm to fix S3 failure issue. This override could be removed after upgrading core. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Guo Mang --- Platform/BroxtonPlatformPkg/PlatformDsc/Components.dsc | 2 +- Platform/BroxtonPlatformPkg/PlatformPkg.fdf

[edk2] [Patch][edk2-platforms/devel-MinnowBoard3 1/3] Fix get variable issue

2017-04-04 Thread Guo, Mang
Fix "AcpiGlobalVariable" couldn't be get issue. S3 memory info was saved in this variable. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Guo Mang --- .../PlatformPreMemPei/PlatformInitPreMem.c| 15 --- .../CseVariableStorageSelectorLib.c

Re: [edk2] [Patch] BaseTools: Add the missing copyrights in BrotliCompress.bat

2017-04-04 Thread Zhu, Yonghong
Reviewed-by: Yonghong Zhu Best Regards, Zhu Yonghong -Original Message- From: Gao, Liming Sent: Wednesday, April 05, 2017 12:57 PM To: edk2-devel@lists.01.org Cc: Zhu, Yonghong Subject: [Patch] BaseTools: Add the missing copyrights in BrotliCompress.bat Cc: Yonghong Zhu Contributed

[edk2] [Patch] BaseTools: Add the missing copyrights in BrotliCompress.bat

2017-04-04 Thread Liming Gao
Cc: Yonghong Zhu Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Liming Gao --- BaseTools/Source/C/BrotliCompress/BrotliCompress.bat | 13 + 1 file changed, 13 insertions(+) diff --git a/BaseTools/Source/C/BrotliCompress/BrotliCompress.bat b/BaseTools/Source/

Re: [edk2] [PATCH] MdeModulePkg: Fix GCC48/GCC49 build error

2017-04-04 Thread Gao, Liming
I agree to move this option to common GCC option. And, now GCC5 has this option. That means if the platform pass GCC5 build, it should not be impacted in GCC48/GCC49 by this change. Right? Thanks Liming > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Tuesday

Re: [edk2] DisconnectController API not working.

2017-04-04 Thread Amit kumar
No i am not trying to disconnect USB controller in use. From: Tian, Feng Sent: Wednesday, April 5, 2017 8:21:36 AM To: Andrew Fish; Amit kumar Cc: edk2-devel@lists.01.org; Tian, Feng Subject: RE: [edk2] DisconnectController API not working. Kumar, Do "map -r" at

Re: [edk2] [PATCH] UefiCpuPkg/MpLib.c: Load microcode before mtrr sync per IA32 SDM

2017-04-04 Thread Tian, Feng
Reviewed-by: Feng Tian Thanks Feng -Original Message- From: Fan, Jeff Sent: Wednesday, April 5, 2017 11:07 AM To: edk2-devel@lists.01.org Cc: Yao, Jiewen ; Kinney, Michael D ; Tian, Feng Subject: [PATCH] UefiCpuPkg/MpLib.c: Load microcode before mtrr sync per IA32 SDM Ref: https://b

Re: [edk2] [PATCH v2] MdeModulePkg/UefiHiiLib:Fix incorrect comparison expression

2017-04-04 Thread Dong, Eric
Reviewed-by: Eric Dong -Original Message- From: Bi, Dandan Sent: Wednesday, April 5, 2017 11:11 AM To: edk2-devel@lists.01.org Cc: Dong, Eric; Gao, Liming Subject: [PATCH v2] MdeModulePkg/UefiHiiLib:Fix incorrect comparison expression https://bugzilla.tianocore.org/show_bug.cgi?id=416

[edk2] [PATCH v2] MdeModulePkg/UefiHiiLib:Fix incorrect comparison expression

2017-04-04 Thread Dandan Bi
https://bugzilla.tianocore.org/show_bug.cgi?id=416 V2: The pointer StringPtr points to a string returned by ExtractConfig/ExportConfig, if it is NULL, function InternalHiiIfrValueAction will return FALSE. So in current usage model, the StringPtr can not be NULL before using it, so we can add ASS

[edk2] [PATCH] UefiCpuPkg/MpLib.c: Load microcode before mtrr sync per IA32 SDM

2017-04-04 Thread Jeff Fan
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=453 Cc: Jiewen Yao Cc: Michael Kinney Cc: Feng Tian Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jeff Fan --- UefiCpuPkg/Library/MpInitLib/MpLib.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff -

Re: [edk2] DisconnectController API not working.

2017-04-04 Thread Tian, Feng
Kumar, Do "map -r" at first please. PS: for the issue you encounter, are you trying to disconnect the usb controller in use? Please note at this time you are reading the file from usb key. It means the disconnect will never succeed. Thanks Feng -Original Message- From: edk2-devel [m

Re: [edk2] [patch] MdeModulePkg/UefiHiiLib:Fix incorrect comparison expression

2017-04-04 Thread Dong, Eric
It's better to add StringPtr != NULL check before use *StringPtr. -Original Message- From: Bi, Dandan Sent: Saturday, April 1, 2017 10:51 AM To: edk2-devel@lists.01.org Cc: Dong, Eric; Gao, Liming Subject: [patch] MdeModulePkg/UefiHiiLib:Fix incorrect comparison expression Fix the incorr

Re: [edk2] [patch 3/3] BaseTools/UPT: Fix a parser issue

2017-04-04 Thread Zhu, Yonghong
Reviewed-by: Yonghong Zhu Best Regards, Zhu Yonghong -Original Message- From: Chen, Hesheng Sent: Saturday, April 1, 2017 1:33 PM To: edk2-devel@lists.01.org Cc: Zhu, Yonghong Subject: [patch 3/3] BaseTools/UPT: Fix a parser issue Update the method to get PCD information and support

Re: [edk2] [patch 2/3] BaseTools/UPT: Support Unicode path

2017-04-04 Thread Zhu, Yonghong
Reviewed-by: Yonghong Zhu Best Regards, Zhu Yonghong -Original Message- From: Chen, Hesheng Sent: Saturday, April 1, 2017 1:33 PM To: edk2-devel@lists.01.org Cc: Zhu, Yonghong Subject: [patch 2/3] BaseTools/UPT: Support Unicode path Update the IpiDb.py to support Unicode path for lo

Re: [edk2] [patch 1/3] BaseTools/UPT: Use a simple way to get package path

2017-04-04 Thread Zhu, Yonghong
Reviewed-by: Yonghong Zhu Best Regards, Zhu Yonghong -Original Message- From: Chen, Hesheng Sent: Saturday, April 1, 2017 1:33 PM To: edk2-devel@lists.01.org Cc: Zhu, Yonghong Subject: [patch 1/3] BaseTools/UPT: Use a simple way to get package path Instead of parsing all content of

Re: [edk2] [PATCH v4] MdePkg: BaseIoLibIntrinsic (IoLib class) library

2017-04-04 Thread Gao, Liming
Leo: I just find one minor issue. Could you help update the comments in new module INF file? > +# Instance of I/O Library using compiler intrinsics. > +# > +# I/O Library that uses compiler intrinsics to perform IN and OUT > instructions > +# for IA-32 and x64. On IPF, I/O port requests a

Re: [edk2] [patch] UefiCpuPkg/MtrrLib:Fix VS2012 build failure

2017-04-04 Thread Ni, Ruiyu
Dandan, Thank you! I thought I fixed all the build failures. Reviewed-by: Ruiyu Ni Regards, Ray >-Original Message- >From: Bi, Dandan >Sent: Wednesday, April 5, 2017 9:07 AM >To: edk2-devel@lists.01.org >Cc: Ni, Ruiyu ; Fan, Jeff >Subject: [patch] UefiCpuPkg/MtrrLib:Fix VS2012 build f

[edk2] [patch] UefiCpuPkg/MtrrLib:Fix VS2012 build failure

2017-04-04 Thread Dandan Bi
Cc: Ruiyu Ni Cc: Jeff Fan Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi --- UefiCpuPkg/Library/MtrrLib/MtrrLib.c | 4 1 file changed, 4 insertions(+) diff --git a/UefiCpuPkg/Library/MtrrLib/MtrrLib.c b/UefiCpuPkg/Library/MtrrLib/MtrrLib.c index 8e84272.

Re: [edk2] Do edk2 contains Intel Edison Platform?

2017-04-04 Thread wang xiaofeng
Hi Brian, Thanks for your kindly answer! At 2017-04-04 01:50:10, "Richardson, Brian" wrote: >There is not a UEFI / EDK II port available for Edison. The Quark port is not >compatible. > >Thanks ... br >--- >Brian Richardson, Senior Technical Marketing Engineer, Intel Software >brian.r

Re: [edk2] [PATCH v3 0/6] Juno cleanup -- EDK2 edition

2017-04-04 Thread Ard Biesheuvel
On 4 April 2017 at 16:48, Ryan Harkin wrote: > On 4 April 2017 at 16:47, Ryan Harkin wrote: >> On 4 April 2017 at 13:30, Ard Biesheuvel wrote: >>> This is tagged as v3 because these patches have been isolated from a >>> ArmPlatformPkg cleanup series that is mostly about ACPI vs DT. >>> >>> This

Re: [edk2] [PATCH v3 0/6] Juno cleanup -- EDK2 edition

2017-04-04 Thread Ryan Harkin
On 4 April 2017 at 16:47, Ryan Harkin wrote: > On 4 April 2017 at 13:30, Ard Biesheuvel wrote: >> This is tagged as v3 because these patches have been isolated from a >> ArmPlatformPkg cleanup series that is mostly about ACPI vs DT. >> >> This series is specific to Juno; it replaces the cargo cul

Re: [edk2] [PATCH v3 0/6] Juno cleanup -- EDK2 edition

2017-04-04 Thread Ryan Harkin
On 4 April 2017 at 13:30, Ard Biesheuvel wrote: > This is tagged as v3 because these patches have been isolated from a > ArmPlatformPkg cleanup series that is mostly about ACPI vs DT. > > This series is specific to Juno; it replaces the cargo culted and ancient > PCI 'emulation' code with calls in

Re: [edk2] [PATCH] ArmVirtPkg/ArmVirtQemuKernel: increase slack space for DTB

2017-04-04 Thread Ard Biesheuvel
On 4 April 2017 at 15:59, Laszlo Ersek wrote: > On 04/04/17 16:45, Ard Biesheuvel wrote: >> The relocatable build of ArmVirtQemuKernel is designed to be executed >> from RAM, and contains some scratch memory at the start of the image >> to use as a stack very early on, and to preserve the DTB imag

Re: [edk2] [PATCH] ArmVirtPkg/ArmVirtQemuKernel: increase slack space for DTB

2017-04-04 Thread Laszlo Ersek
On 04/04/17 16:45, Ard Biesheuvel wrote: > The relocatable build of ArmVirtQemuKernel is designed to be executed > from RAM, and contains some scratch memory at the start of the image > to use as a stack very early on, and to preserve the DTB image received > from QEMU while it discovers and initia

[edk2] [PATCH] ArmVirtPkg/ArmVirtQemuKernel: increase slack space for DTB

2017-04-04 Thread Ard Biesheuvel
The relocatable build of ArmVirtQemuKernel is designed to be executed from RAM, and contains some scratch memory at the start of the image to use as a stack very early on, and to preserve the DTB image received from QEMU while it discovers and initializes memory. It turns out that 8 KB is a bit on

Re: [edk2] [PATCH 0/3] ArmVirtPkg: ignore DT nodes with a status != 'okay'

2017-04-04 Thread Ard Biesheuvel
On 4 April 2017 at 15:16, Laszlo Ersek wrote: > On 04/04/17 15:24, Ard Biesheuvel wrote: >> The DT passed to us by QEMU may contain nodes that are supposed to be >> consumed by the secure world only. In some case, their status may be >> set to 'secure', but 'disabled' occurs as well, if the secure

Re: [edk2] [PATCH 0/3] ArmVirtPkg: ignore DT nodes with a status != 'okay'

2017-04-04 Thread Laszlo Ersek
On 04/04/17 15:24, Ard Biesheuvel wrote: > The DT passed to us by QEMU may contain nodes that are supposed to be > consumed by the secure world only. In some case, their status may be > set to 'secure', but 'disabled' occurs as well, if the secure OS has > actually modified the DT. > > Since as a

[edk2] [PATCH v4] MdePkg: BaseIoLibIntrinsic (IoLib class) library

2017-04-04 Thread Leo Duran
This patch adds an SEV-specific .INF and corresponding assembly files, to unroll REP INSx/OUTSx on IoRead/WriteFifo#() routines when the SEV feature is enabled under a hypervisor environment. The new .INF only supports the IA32 and X64 architectures. This patch follows the series "[PATCH v3 0

[edk2] [PATCH v4] MdePkg: BaseIoLibIntrinsic (IoLib class) library

2017-04-04 Thread Leo Duran
This patch adds an SEV-specific .INF and corresponding assembly files, to unroll REP INSx/OUTSx on IoRead/WriteFifo#() routines when the SEV feature is enabled under a hypervisor environment. The new .INF only supports the IA32 and X64 architectures. Cc: Michael D Kinney Cc: Liming Gao Contribu

[edk2] [PATCH 2/3] ArmVirtPkg/FdtPL011SerialPortLib: take DT node 'status' property into account

2017-04-04 Thread Ard Biesheuvel
In some cases, (e.g., when running QEMU with TrustZone emulation), the DT may contain DT nodes whose status is set to 'secure'. Similarly, the status may be set to 'disabled' if the consumer of the DT image is expected to treat it as if it weren't there. So check whether a 'status' property is pre

[edk2] [PATCH 3/3] ArmVirtPkg/PlatformPeiLib: take DT node 'status' property into account

2017-04-04 Thread Ard Biesheuvel
In some cases, (e.g., when running QEMU with TrustZone emulation), the DT may contain DT nodes whose status is set to 'secure'. Similarly, the status may be set to 'disabled' if the consumer of the DT image is expected to treat it as if it weren't there. So check whether a 'status' property is pre

[edk2] [PATCH 0/3] ArmVirtPkg: ignore DT nodes with a status != 'okay'

2017-04-04 Thread Ard Biesheuvel
The DT passed to us by QEMU may contain nodes that are supposed to be consumed by the secure world only. In some case, their status may be set to 'secure', but 'disabled' occurs as well, if the secure OS has actually modified the DT. Since as a general rule, DT nodes should only be consumed if the

[edk2] [PATCH 1/3] ArmVirtPkg/FdtClientDxe: take DT memory node 'status' property into account

2017-04-04 Thread Ard Biesheuvel
In some cases, (e.g., when running QEMU with TrustZone emulation), the DT may contain memory nodes whose status is set to 'secure'. Similarly, the status may be set to 'disabled' if the consumer of the DT image is expected to treat it as if it weren't there. So check whether a 'status' property is

[edk2] [PATCH v3 6/6] ArmPlatformPkg/ArmJunoDxe: simplify ACPI table installation

2017-04-04 Thread Ard Biesheuvel
Having a three way conditional with callbacks would make sense if the callbacks weren't (a) identical and (b) didn't return TRUE all the time. So get rid of the kludge. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel --- ArmPlatformPkg/ArmJunoPkg/Drivers/Arm

[edk2] [PATCH v3 3/6] ArmPlatformPkg/ArmJunoDxe: use the generic non-discoverable device support

2017-04-04 Thread Ard Biesheuvel
Replace the open coded reimplementation of 'PCI emulation' with a pair of calls into NonDiscoverableDeviceRegistrationLib to register the OHCI and EHCI controllers. These will be picked up by the generic driver instead. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Bie

[edk2] [PATCH v3 4/6] ArmPlatformPkg/ArmJunoDxe: don't register OnEndOfDxe event on rev R0

2017-04-04 Thread Ard Biesheuvel
The ArmJunoDxe driver code registers a callback for the EndOfDxe event, at which time it does some manipulation of the PCI peripherals on the board. Given that R0 has no working PCIe, we can omit the registration of the callback altogether. Contributed-under: TianoCore Contribution Agreement 1.0 S

[edk2] [PATCH v3 2/6] ArmPlatformPkg/ArmJunoDxe: remove BdsLib dependency

2017-04-04 Thread Ard Biesheuvel
The ArmJunoDxe driver does not actually depend on the deprecated BdsLib so remove the dependency declaration from the INF file. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel --- ArmPlatformPkg/ArmJunoPkg/Drivers/ArmJunoDxe/ArmJunoDxe.inf | 1 - 1 file chan

[edk2] [PATCH v3 1/6] ArmPlatformPkg/ArmShellCmdRunAxf: remove BdsLib dependency

2017-04-04 Thread Ard Biesheuvel
Remove ArmShellCmdRunAxf's dependency on the deprecated BdsLib by cloning the ShutdownUefiBootServices() routine into a local source file; this is the only BdsLib feature 'runaxf' depends on. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel --- ArmPlatformPkg

[edk2] [PATCH v3 5/6] ArmPlatformPkg/ArmJunoPkg: remove PCI host bridge driver

2017-04-04 Thread Ard Biesheuvel
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel --- ArmPlatformPkg/ArmJunoPkg/Drivers/PciHostBridgeDxe/PciHostBridge.c | 199 -- ArmPlatformPkg/ArmJunoPkg/Drivers/PciHostBridgeDxe/PciHostBridge.h | 324 - ArmP

[edk2] [PATCH v3 0/6] Juno cleanup -- EDK2 edition

2017-04-04 Thread Ard Biesheuvel
This is tagged as v3 because these patches have been isolated from a ArmPlatformPkg cleanup series that is mostly about ACPI vs DT. This series is specific to Juno; it replaces the cargo culted and ancient PCI 'emulation' code with calls into the new non-discoverable device API, and removes the Ju

Re: [edk2] [PATCH v2 1/3] OvmfPkg: VMWare SVGA2 display device register definitions

2017-04-04 Thread Laszlo Ersek
On 04/04/17 01:17, Jordan Justen wrote: > On 2017-04-02 15:44:55, Phil Dennis-Jordan wrote: >> From: Phil Dennis-Jordan >> >> This adds a header file defining symbolic constants for the VMWare SVGA2 >> virtual display device in preparation for supporting it in QemuVideoDXE. >> >> It is an extract

Re: [edk2] [PATCH v2 3/3] OvmfPkg/QemuVideoDxe: VMWare SVGA II device support.

2017-04-04 Thread Laszlo Ersek
On 04/03/17 00:44, Phil Dennis-Jordan wrote: > From: Phil Dennis-Jordan > > In addition to the QXL, Cirrus, etc. VGA adapters, Qemu also implements > a basic version of VMWare's SVGA2 display device. Drivers for this > device exist for some guest OSes which do not support Qemu's other > display a

Re: [edk2] [PATCH v2 09/13] Platforms/Juno: add PciHostBridgeLib implementation

2017-04-04 Thread Ard Biesheuvel
On 31 March 2017 at 15:15, Ard Biesheuvel wrote: > In order to be able to switch to the generic PCI host bridge driver, > implement the glue library that exposes the PCIe parameters to the > common driver. Since the Juno performs some initialization of the > PCIe control registers as well, copy th

Re: [edk2] [PATCH v2 2/3] OvmfPkg/QemuVideoDxe: Helper functions for unaligned port I/O.

2017-04-04 Thread Laszlo Ersek
On 04/03/17 00:44, Phil Dennis-Jordan wrote: > From: Phil Dennis-Jordan > > The VMWare SVGA2 display device implemented by Qemu (-vga vmware) uses > an I/O-type BAR which is laid out such that some register offsets are > not aligned to the read/write width with which they are expected to be > acc

Re: [edk2] [PATCH v2 1/3] OvmfPkg: VMWare SVGA2 display device register definitions

2017-04-04 Thread Laszlo Ersek
On 04/03/17 00:44, Phil Dennis-Jordan wrote: > From: Phil Dennis-Jordan > > This adds a header file defining symbolic constants for the VMWare SVGA2 > virtual display device in preparation for supporting it in QemuVideoDXE. > > It is an extract of the file lib/vmware/svga_reg.h from commit > 329

[edk2] [RFC] [PATCH V3 3/3] MdeModulePkg/PciBus: Add IOMMU support.

2017-04-04 Thread Jiewen Yao
The responsibility of PciBus driver is to set IOMMU attribute, because only PciBus knows which device submits DMA access request. PciBus driver guarantee that the request to PciHostBridge is IOMMU page aligned memory, as such PciHostBridge can allocate non-existent memory for device memory, to sat

[edk2] [RFC] [PATCH V3 2/3] MdeModulePkg/PciHostBridge: Add IOMMU support.

2017-04-04 Thread Jiewen Yao
The responsibility of PciHostBridge is to allocate IOMMU page aligned memory for Map and AllocateBuffer, because PciHostBridge driver already handles Map() request to allocate another buffer for DMA read/write. If the max address requirement can not be satisfied, PciHostBridge may also allocate an

[edk2] [RFC] [PATCH V3 1/3] MdeModulePkg/Include: Add IOMMU protocol definition.

2017-04-04 Thread Jiewen Yao
This protocol is to abstract DMA access from IOMMU. 1) Intel "DMAR" ACPI table. 2) AMD "IVRS" ACPI table 3) ARM "IORT" ACPI table. There might be multiple IOMMU engines on one platform. For example, one for graphic and one for rest PCI devices (such as ATA/USB). All IOMMU engines are reported by o

[edk2] [RFC] [PATCH V3 0/3] Add IOMMU support.

2017-04-04 Thread Jiewen Yao
V3 == 1) Add Remap capability (from Ard Biesheuvel) Add EDKII_IOMMU_REMAP_ADDRESS API in IOMMU_PROTOCOL. NOTE: The code is not fully validated yet. The purpose is to collect feedback to decide the next step. V2 == 1) Enhance Unmap() in Pci