Re: [edk2] [Patch] CryptoPkg: Move openssl and CRT headers to private include section

2017-04-05 Thread Long, Qin
Yes, it's feasible. I still prefer to use "Library/Include" path setting for this, since only CryptoPkg/Library/* will refer to these internal header files. It may be cleaner to keep the current directory in root of CryptoPkg. Best Regards & Thanks, LONG, Qin > -Original Message- > Fro

Re: [edk2] [Patch] CryptoPkg: Move openssl and CRT headers to private include section

2017-04-05 Thread Gao, Liming
Qin: How about creating new Private directory in CryptoPkg, then move those internal header files into it? Thanks Liming >-Original Message- >From: Long, Qin >Sent: Thursday, April 06, 2017 1:56 PM >To: Gao, Liming ; Ye, Ting >Cc: edk2-devel@lists.01.org; Long, Qin >Subject: [Patch]

[edk2] [Patch] CryptoPkg: Move openssl and CRT headers to private include section

2017-04-05 Thread Long Qin
Moving the header files for openssl and CRT wrappers to the private include section, since these files should be referenced by CryptoPkg internally. This update was supported by new [Includes.Common.Private] setting in Package DEC file. The external consumer modules should only use the interfaces d

[edk2] [PATCH] UefiCpuPkg/CpuFeatures: Change CPU features name to follow IA32 SDM

2017-04-05 Thread Jeff Fan
Cc: Feng Tian Cc: Michael Kinney Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jeff Fan --- UefiCpuPkg/Include/Library/RegisterCpuFeaturesLib.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/UefiCpuPkg/Include/Library/RegisterCpuFeaturesLib.h b

Re: [edk2] [DxeNetLib] Why do we restrict each field to have the same leading zero format?

2017-04-05 Thread Wu, Jiaxin
Hi Gary, The issue has been gone since the version of 9f5ca5efbd0bb00c9d3577b95e6322e85cb0b118. Please check that. Thanks, Jiaxin > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Guoheyi > Sent: Wednesday, April 5, 2017 6:56 PM > To: edk2-d

Re: [edk2] [PATCH v4 3/3] OvmfPkg/QemuVideoDxe: VMWare SVGA device support

2017-04-05 Thread Laszlo Ersek
Apologies, I noticed something else: On 04/05/17 14:55, Phil Dennis-Jordan wrote: > From: Phil Dennis-Jordan > > In addition to the QXL, Cirrus, etc. VGA adapters, Qemu also implements > a basic version of VMWare's SVGA display device. Drivers for this > device exist for some guest OSes which do

Re: [edk2] [PATCH 5/6] MdePkg: Convert files to CRLF line ending

2017-04-05 Thread Gao, Liming
Reviewed-by: Liming Gao >-Original Message- >From: Wu, Hao A >Sent: Thursday, April 06, 2017 10:25 AM >To: edk2-devel@lists.01.org >Cc: Wu, Hao A ; Kinney, Michael D >; Gao, Liming >Subject: [PATCH 5/6] MdePkg: Convert files to CRLF line ending > >Cc: Michael Kinney >Cc: Liming Gao >Co

Re: [edk2] [edk2-FdfSpecification Patch] IMAGE_TYPE_ID is required in [FmpPayload] section

2017-04-05 Thread Zhu, Yonghong
Reviewed-by: Yonghong Zhu Best Regards, Zhu Yonghong -Original Message- From: Kinney, Michael D Sent: Thursday, April 6, 2017 11:38 AM To: edk2-devel@lists.01.org Cc: Gao, Liming ; Zhu, Yonghong ; Shaw, Kevin W Subject: [edk2-FdfSpecification Patch] IMAGE_TYPE_ID is required in [Fmp

[edk2] [edk2-FdfSpecification Patch] IMAGE_TYPE_ID is required in [FmpPayload] section

2017-04-05 Thread Michael Kinney
https://bugzilla.tianocore.org/show_bug.cgi?id=426 Update the EBNF for [FmpPayload] in Section 3.8 so IMAGE_TYPE_ID is required and must always be assigned to a valid registry format GUID value. Cc: Liming Gao Cc: Yonghong Zhu Cc: Kevin W Shaw Contributed-under: TianoCore Contribution Agreemen

[edk2] [edk2-FdfSpecification Patch] IMAGE_TYPE_ID is required in [FmpPayload] section

2017-04-05 Thread Michael Kinney
https://bugzilla.tianocore.org/show_bug.cgi?id=426 Update the EBNF for [FmpPayload] in Section 3.8 so IMAGE_TYPE_ID is required and must always be assigned to a valid registry format GUID value. Cc: Liming Gao Cc: Yonghong Zhu Cc: Kevin W Shaw Contributed-under: TianoCore Contribution Agreemen

Re: [edk2] [PATCH 2/6] IntelFsp2Pkg: Convert files to CRLF line ending

2017-04-05 Thread Yao, Jiewen
Reviewed-by: jiewen@intel.com > -Original Message- > From: Wu, Hao A > Sent: Thursday, April 6, 2017 10:25 AM > To: edk2-devel@lists.01.org > Cc: Wu, Hao A ; Yao, Jiewen > Subject: [PATCH 2/6] IntelFsp2Pkg: Convert files to CRLF line ending > > Cc: Jiewen Yao > Contributed-under: Ti

Re: [edk2] [PATCH 4/6] SignedCapsulePkg: Convert files to CRLF line ending

2017-04-05 Thread Yao, Jiewen
Reviewed-by: jiewen@intel.com > -Original Message- > From: Wu, Hao A > Sent: Thursday, April 6, 2017 10:25 AM > To: edk2-devel@lists.01.org > Cc: Wu, Hao A ; Yao, Jiewen > Subject: [PATCH 4/6] SignedCapsulePkg: Convert files to CRLF line ending > > Cc: Jiewen Yao > Contributed-under

Re: [edk2] [PATCH 3/6] IntelFsp2WrapperPkg: Convert files to CRLF line ending

2017-04-05 Thread Yao, Jiewen
Reviewed-by: jiewen@intel.com > -Original Message- > From: Wu, Hao A > Sent: Thursday, April 6, 2017 10:25 AM > To: edk2-devel@lists.01.org > Cc: Wu, Hao A ; Yao, Jiewen > Subject: [PATCH 3/6] IntelFsp2WrapperPkg: Convert files to CRLF line ending > > Cc: Jiewen Yao > Contributed-un

[edk2] [Patch][edk2-platforms/devel-MinnowBoard3] Add SATA initialization.

2017-04-05 Thread lushifex
Add additional SATA initialization code. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: lushifex --- .../BroxtonSiPkg/SouthCluster/ScInit/Dxe/ScInit.c | 3 + .../BroxtonSiPkg/SouthCluster/ScInit/Dxe/ScSata.c | 91 +- 2 files changed, 93 insertions(+

[edk2] [PATCH 5/6] MdePkg: Convert files to CRLF line ending

2017-04-05 Thread Hao Wu
Cc: Michael Kinney Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Hao Wu --- MdePkg/Include/IndustryStandard/Tls1.h | 186 ++-- MdePkg/Include/Protocol/Tls.h | 921 ++-- MdePkg/Include/Protocol/TlsConfig.h| 265 +++--- MdePkg/L

[edk2] [PATCH 4/6] SignedCapsulePkg: Convert files to CRLF line ending

2017-04-05 Thread Hao Wu
Cc: Jiewen Yao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Hao Wu --- SignedCapsulePkg/Readme.md | 22 ++-- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/SignedCapsulePkg/Readme.md b/SignedCapsulePkg/Readme.md index 67c78edfb4..03358e9

[edk2] [PATCH 0/6] Convert files to CRLF line ending

2017-04-05 Thread Hao Wu
This series converts the following file formats to CRLF line ending: .c .h .inf .uni .vfr .pl Hao Wu (6): CryptoPkg: Convert files to CRLF line ending IntelFsp2Pkg: Convert files to CRLF line ending IntelFsp2WrapperPkg: Convert files to CRLF line ending SignedCapsulePkg: Convert files to

[edk2] [PATCH 3/6] IntelFsp2WrapperPkg: Convert files to CRLF line ending

2017-04-05 Thread Hao Wu
Cc: Jiewen Yao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Hao Wu --- IntelFsp2WrapperPkg/Readme.md | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/IntelFsp2WrapperPkg/Readme.md b/IntelFsp2WrapperPkg/Readme.md index 0b0f81b033..dfcb4c

[edk2] [PATCH 2/6] IntelFsp2Pkg: Convert files to CRLF line ending

2017-04-05 Thread Hao Wu
Cc: Jiewen Yao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Hao Wu --- IntelFsp2Pkg/Readme.md | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/IntelFsp2Pkg/Readme.md b/IntelFsp2Pkg/Readme.md index 6e38e8ca61..719ce099e4 100644 --- a/Int

Re: [edk2] [Patch][edk2-platforms/devel-MinnowBoard3 3/3] Fix set variable issue

2017-04-05 Thread Wei, David
Reviewed-by: zwei4 Thanks, David Wei -Original Message- From: Guo, Mang Sent: Wednesday, April 05, 2017 2:58 PM To: edk2-devel@lists.01.org Cc: Wei, David ; Lu, ShifeiX A Subject: [Patch][edk2-platforms/devel-MinnowBoard3 3/3] Fix set variable issue

Re: [edk2] [Patch][edk2-platforms/devel-MinnowBoard3 1/3] Fix get variable issue

2017-04-05 Thread Wei, David
Reviewed-by: zwei4 Thanks, David Wei -Original Message- From: Guo, Mang Sent: Wednesday, April 05, 2017 2:57 PM To: edk2-devel@lists.01.org Cc: Wei, David ; Lu, ShifeiX A Subject: [Patch][edk2-platforms/devel-MinnowBoard3 1/3] Fix get variable issue

Re: [edk2] [Patch] BaseTools: Update tools_def.template to add -fno-builtin in GCC tool chain

2017-04-05 Thread Laszlo Ersek
On 04/06/17 02:45, Liming Gao wrote: > Now, -fno-builtin option is added for the specific GCC tool chain. > It is a generic option. It can be moved to common GCC option to keep > the consistent compiler option. > > Cc: Ard Biesheuvel > Cc: Yonghong Zhu > Contributed-under: TianoCore Contribution

Re: [edk2] [patch] UefiCpuPkg: Fix typos in UefiCpuPkg.dec

2017-04-05 Thread Fan, Jeff
Reviewed-by: Jeff Fan Thanks! -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Dandan Bi Sent: Thursday, April 06, 2017 8:53 AM To: edk2-devel@lists.01.org Cc: Fan, Jeff Subject: [edk2] [patch] UefiCpuPkg: Fix typos in UefiCpuPkg.dec Cc: Jeff Fan

[edk2] [patch] UefiCpuPkg: Fix typos in UefiCpuPkg.dec

2017-04-05 Thread Dandan Bi
Cc: Jeff Fan Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi --- UefiCpuPkg/UefiCpuPkg.dec | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/UefiCpuPkg/UefiCpuPkg.dec b/UefiCpuPkg/UefiCpuPkg.dec index e87f103..6f30ad0 100644 --- a/UefiCpuPkg/Uef

Re: [edk2] [Patch] BaseTools: update error message for SKUID_IDENTIFIER format

2017-04-05 Thread Gao, Liming
Reviewed-by: Liming Gao > -Original Message- > From: Zhu, Yonghong > Sent: Saturday, April 1, 2017 1:59 PM > To: edk2-devel@lists.01.org > Cc: Gao, Liming > Subject: [Patch] BaseTools: update error message for SKUID_IDENTIFIER format > > Per DSC spec, the SkuUiName use '|' as separator,

Re: [edk2] [PATCH v5] MdePkg: BaseIoLibIntrinsic (IoLib class) library

2017-04-05 Thread Gao, Liming
Leo: Seemly, this patch doesn't include new INF file. Could you create it again? Thanks Liming > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Leo > Duran > Sent: Wednesday, April 5, 2017 9:20 PM > To: edk2-de...@ml01.01.org > Cc: Kinney, Mi

Re: [edk2] [Patch] MdeModulePkg: Remove unsupported PcdExpression usage in module INF

2017-04-05 Thread Zeng, Star
Reviewed-by: Star Zeng Thanks, Star -Original Message- From: Gao, Liming Sent: Friday, March 31, 2017 1:04 PM To: edk2-devel@lists.01.org Cc: Tian, Feng ; Zeng, Star Subject: [Patch] MdeModulePkg: Remove unsupported PcdExpression usage in module INF https://bugzilla.tianocore.org/show

[edk2] [Patch] BaseTools: Update tools_def.template to add -fno-builtin in GCC tool chain

2017-04-05 Thread Liming Gao
Now, -fno-builtin option is added for the specific GCC tool chain. It is a generic option. It can be moved to common GCC option to keep the consistent compiler option. Cc: Ard Biesheuvel Cc: Yonghong Zhu Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Liming Gao Signed-of

[edk2] [edk2-FdfSpecification Patch] FILE RAW Multiple binaries and FmpPayload extensions

2017-04-05 Thread Michael Kinney
* Changed the FDF_SPECIFICATION value from 0x0001001A to 0x0001001B or 1.27 * Extended the FV and Capsule, FILE RAW statement formats to support multiple binary files. * Changed section 3.8 [FmpPayload] to add definitions for MONOTONIC_COUNT and CERTIFICATE_GUID, plus some notes about how t

[edk2] [edk2-FdfSpecification Patch] FILE RAW Multiple binaries and FmpPayload extensions

2017-04-05 Thread Michael Kinney
* Changed the FDF_SPECIFICATION value from 0x0001001A to 0x0001001B or 1.27 * Extended the FV and Capsule, FILE RAW statement formats to support multiple binary files. * Changed section 3.8 [FmpPayload] to add definitions for MONOTONIC_COUNT and CERTIFICATE_GUID, plus some notes about how t

Re: [edk2] [PATCH v5 4/4] MdePkg/BaseMemoryLibOptDxe ARM|AARCH64: disallow use in SEC & PEI phases

2017-04-05 Thread Ard Biesheuvel
On 5 April 2017 at 22:28, Jeremy Linton wrote: > Hi, > > > On 04/05/2017 03:34 PM, Ard Biesheuvel wrote: >> >> On 5 April 2017 at 21:12, Jeremy Linton wrote: >>> >>> Hi, >>> >>> On 09/09/2016 09:00 AM, Ard Biesheuvel wrote: The new accelerated ARM and AARCH64 implementations take a

Re: [edk2] [PATCH v5 4/4] MdePkg/BaseMemoryLibOptDxe ARM|AARCH64: disallow use in SEC & PEI phases

2017-04-05 Thread Jeremy Linton
Hi, On 04/05/2017 03:34 PM, Ard Biesheuvel wrote: On 5 April 2017 at 21:12, Jeremy Linton wrote: Hi, On 09/09/2016 09:00 AM, Ard Biesheuvel wrote: The new accelerated ARM and AARCH64 implementations take advantage of features that are only available when the MMU and Dcache are on. So restri

[edk2] [PATCH 1/2] ArmPlatformPkg/HdLcdArmVExpressLib: use write-combine mapping for VRAM

2017-04-05 Thread Ard Biesheuvel
Replace the uncached memory mapping of the framebuffer with a write- combining one. This improves performance, and avoids issues with unaligned accesses and DC ZVA instructions performed by the accelerated memcpy/memset routines. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-b

[edk2] [PATCH 2/2] ArmPlatformPkg/PL111LcdArmVExpressLib: use write-combine mapping for VRAM

2017-04-05 Thread Ard Biesheuvel
Replace the uncached memory mapping of the framebuffer with a write- combining one. This improves performance, and avoids issues with unaligned accesses and DC ZVA instructions performed by the accelerated memcpy/memset routines. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-b

Re: [edk2] [PATCH v5 4/4] MdePkg/BaseMemoryLibOptDxe ARM|AARCH64: disallow use in SEC & PEI phases

2017-04-05 Thread Ard Biesheuvel
On 5 April 2017 at 21:12, Jeremy Linton wrote: > Hi, > > On 09/09/2016 09:00 AM, Ard Biesheuvel wrote: >> >> The new accelerated ARM and AARCH64 implementations take advantage of >> features that are only available when the MMU and Dcache are on. So >> restrict the use of this library to the DXE p

Re: [edk2] [PATCH v5 4/4] MdePkg/BaseMemoryLibOptDxe ARM|AARCH64: disallow use in SEC & PEI phases

2017-04-05 Thread Jeremy Linton
Hi, On 09/09/2016 09:00 AM, Ard Biesheuvel wrote: The new accelerated ARM and AARCH64 implementations take advantage of features that are only available when the MMU and Dcache are on. So restrict the use of this library to the DXE phase or later. I don't think this is sufficient because DC ZV

Re: [edk2] [PATCH v4 3/3] OvmfPkg/QemuVideoDxe: VMWare SVGA device support

2017-04-05 Thread Jordan Justen
On 2017-04-05 06:58:33, Laszlo Ersek wrote: > > This is #2. > > Which one do you want to keep? I think we should drop #1, and keep #2. > > Do you wish to submit v5, or are you okay if I remove #1 for you at > commit time? > > With this tweak, > > Reviewed-by: Laszlo Ersek > > Before committi

Re: [edk2] UEFI Shell Lib Constructor and Shell Parameters Protocol

2017-04-05 Thread Tim Lewis
There are "load options" that are passed to drivers (as a part of the EFI_LOADED_IMAGE_PROTOCOL), but there is no guarantee as to their format (binary data or ASCII string or UCS-2 string). It is possible for "load" to be modified to create this data and populate it between the calls to LoadImag

Re: [edk2] UEFI Shell Lib Constructor and Shell Parameters Protocol

2017-04-05 Thread Carsey, Jaben
Glad to help. I do not think that UEFI drivers really have the concept of command line parameters... they use other methods for configuration... -Jaben > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > jim.dai...@dell.com > Sent: Wednesday

Re: [edk2] [PATCH] MdeModulePkg: move PlatformHasAcpiGuid from EmbeddedPkg

2017-04-05 Thread Ard Biesheuvel
On 5 April 2017 at 16:38, Leif Lindholm wrote: > On Wed, Apr 05, 2017 at 11:01:05AM +0100, Ard Biesheuvel wrote: >> On 5 April 2017 at 10:49, Laszlo Ersek wrote: >> > On 04/05/17 11:38, Ard Biesheuvel wrote: >> >> Given the agreement on the edk2-devel regarding the fact that the >> >> notion whet

Re: [edk2] [PATCH] MdeModulePkg: move PlatformHasAcpiGuid from EmbeddedPkg

2017-04-05 Thread Leif Lindholm
On Wed, Apr 05, 2017 at 11:01:05AM +0100, Ard Biesheuvel wrote: > On 5 April 2017 at 10:49, Laszlo Ersek wrote: > > On 04/05/17 11:38, Ard Biesheuvel wrote: > >> Given the agreement on the edk2-devel regarding the fact that the > >> notion whether or not a 'platform has ACPI' is a universal one, m

Re: [edk2] UEFI Shell Lib Constructor and Shell Parameters Protocol

2017-04-05 Thread Jim.Dailey
Thanks, Jaben. That makes sense. Now I see the real issue is with the "app" I ran across. It is a driver, and it was trying to access command line args. The driver crashed when it tried to access the command line, but it had been loaded in memory via the "load" command. So, it seems "load" has

Re: [edk2] [PATCH v4 0/4] Juno cleanup -- OpenPlatformPkg edition

2017-04-05 Thread Ard Biesheuvel
On 5 April 2017 at 15:11, Ard Biesheuvel wrote: > On 5 April 2017 at 15:10, Ryan Harkin wrote: >> On 5 April 2017 at 15:00, Ard Biesheuvel wrote: >>> Counterpart to the EDK2 series switching Juno to the generic >>> non-discoverable >>> device driver and generic PCI host bridge driver. >>> >>> v

Re: [edk2] UEFI Shell Lib Constructor and Shell Parameters Protocol

2017-04-05 Thread Carsey, Jaben
Jim, That protocol must be installed on your applications own image handle for it to be valid. Locating the protocol on some other image would result with finding the other image's command line parameters and the like... -Jaben > -Original Message- > From: edk2-devel [mailto:edk2-dev

Re: [edk2] [PATCH v4 2/4] Platforms/Juno: add PciHostBridgeLib implementation

2017-04-05 Thread Leif Lindholm
On Wed, Apr 05, 2017 at 03:00:53PM +0100, Ard Biesheuvel wrote: > In order to be able to switch to the generic PCI host bridge driver, > implement the glue library that exposes the PCIe parameters to the > common driver. Since the Juno performs some initialization of the > PCIe control registers as

Re: [edk2] [PATCH v4 resend v4 5/6] ArmPlatformPkg/ArmJunoPkg: remove PCI host bridge driver

2017-04-05 Thread Leif Lindholm
On Wed, Apr 05, 2017 at 02:58:06PM +0100, Ard Biesheuvel wrote: > We are switching the Juno platform to the generic host bridge driver, > which involves implementing PciHostBridgeLib for this platform, and > plugging it into MdeModulePkg's PciHostBridgeDxe.inf. > > Since the platform descriptions

Re: [edk2] [PATCH v3 1/6] ArmPlatformPkg/ArmShellCmdRunAxf: remove BdsLib dependency

2017-04-05 Thread Leif Lindholm
On Wed, Apr 05, 2017 at 02:11:44PM +0100, Ard Biesheuvel wrote: > On 5 April 2017 at 14:09, Leif Lindholm wrote: > > On Tue, Apr 04, 2017 at 01:30:05PM +0100, Ard Biesheuvel wrote: > >> Remove ArmShellCmdRunAxf's dependency on the deprecated BdsLib by > >> cloning the ShutdownUefiBootServices() ro

Re: [edk2] [PATCH v4 0/4] Juno cleanup -- OpenPlatformPkg edition

2017-04-05 Thread Ard Biesheuvel
On 5 April 2017 at 15:10, Ryan Harkin wrote: > On 5 April 2017 at 15:00, Ard Biesheuvel wrote: >> Counterpart to the EDK2 series switching Juno to the generic non-discoverable >> device driver and generic PCI host bridge driver. >> >> v4: fixed a number of non-functional issues -- include orderin

Re: [edk2] [PATCH v4 0/4] Juno cleanup -- OpenPlatformPkg edition

2017-04-05 Thread Ryan Harkin
On 5 April 2017 at 15:00, Ard Biesheuvel wrote: > Counterpart to the EDK2 series switching Juno to the generic non-discoverable > device driver and generic PCI host bridge driver. > > v4: fixed a number of non-functional issues -- include ordering, incorrect > BASE_NAME, commit log clarificati

[edk2] UEFI Shell Lib Constructor and Shell Parameters Protocol

2017-04-05 Thread Jim.Dailey
A question or two for all shell experts: In the UEFI Shell Lib constructor code, if the Shell protocol cannot be opened, then an attempt is made to locate it before "giving up". However, if the Shell parameters protocol cannot be opened, no attempt is made to locate it---the code simply leaves t

[edk2] [PATCH v4 2/4] Platforms/Juno: add PciHostBridgeLib implementation

2017-04-05 Thread Ard Biesheuvel
In order to be able to switch to the generic PCI host bridge driver, implement the glue library that exposes the PCIe parameters to the common driver. Since the Juno performs some initialization of the PCIe control registers as well, copy that code from the old EDK2 driver into the library's constr

[edk2] [PATCH v4 1/4] Platforms/Juno: add non-discoverable device driver and library

2017-04-05 Thread Ard Biesheuvel
In preparation of moving ArmJunoDxe's support of the OHCI and EHCI controllers to the generic non-discoverable device infrastructure, add the prerequisite driver and library class resolution to the Juno platform description. Note that the FD image size needs to be increased slightly to accommodate

[edk2] [PATCH v4 0/4] Juno cleanup -- OpenPlatformPkg edition

2017-04-05 Thread Ard Biesheuvel
Counterpart to the EDK2 series switching Juno to the generic non-discoverable device driver and generic PCI host bridge driver. v4: fixed a number of non-functional issues -- include ordering, incorrect BASE_NAME, commit log clarifications add RBs and TBs Ard Biesheuvel (4): Platforms/J

[edk2] [PATCH v4 4/4] Platforms/Juno: remove BdsLib dependency

2017-04-05 Thread Ard Biesheuvel
ArmJunoDxe no longer depends on BdsLib so we no longer have to specify a library class resolution for it. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel Reviewed-by: Leif Lindholm --- Platforms/ARM/Juno/ArmJuno.dsc | 5 + 1 file changed, 1 insertion(+)

[edk2] [PATCH v4 3/4] Platforms/Juno: switch to generic PCI host bridge driver

2017-04-05 Thread Ard Biesheuvel
Now that we have the prerequisites in place, switch to the generic PCI host bridge driver. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel Reviewed-by: Leif Lindholm --- Platforms/ARM/Juno/ArmJuno.dsc | 17 +++-- Platforms/ARM/Juno/ArmJuno.fdf |

[edk2] [PATCH v4 resend v4 6/6] ArmPlatformPkg/ArmJunoDxe: simplify ACPI table installation

2017-04-05 Thread Ard Biesheuvel
Having a three way conditional with callbacks would make sense if the callbacks weren't (a) identical and (b) didn't return TRUE all the time. So get rid of the kludge. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel Tested-by: Ryan Harkin Reviewed-by: Leif

Re: [edk2] [PATCH v4 3/3] OvmfPkg/QemuVideoDxe: VMWare SVGA device support

2017-04-05 Thread Laszlo Ersek
On 04/05/17 14:55, Phil Dennis-Jordan wrote: > From: Phil Dennis-Jordan > > In addition to the QXL, Cirrus, etc. VGA adapters, Qemu also implements > a basic version of VMWare's SVGA display device. Drivers for this > device exist for some guest OSes which do not support Qemu's other > display ad

[edk2] [PATCH v4 resend v4 5/6] ArmPlatformPkg/ArmJunoPkg: remove PCI host bridge driver

2017-04-05 Thread Ard Biesheuvel
We are switching the Juno platform to the generic host bridge driver, which involves implementing PciHostBridgeLib for this platform, and plugging it into MdeModulePkg's PciHostBridgeDxe.inf. Since the platform descriptions no longer live in upstream EDK2, the PciHostBridgeLib implementation (whic

[edk2] [PATCH v4 resend v4 0/6] Juno cleanup -- EDK2 edition

2017-04-05 Thread Ard Biesheuvel
This series is specific to Juno; it replaces the cargo culted and ancient PCI 'emulation' code with calls into the new non-discoverable device API, and removes the Juno specific PCI host bridge driver in favor of the generic one. v4: add missing commit log add TBs and RBs *no* code changes

[edk2] [PATCH v4 resend v4 4/6] ArmPlatformPkg/ArmJunoDxe: don't register OnEndOfDxe event on rev R0

2017-04-05 Thread Ard Biesheuvel
The ArmJunoDxe driver code registers a callback for the EndOfDxe event, at which time it does some manipulation of the PCI peripherals on the board. Given that R0 has no working PCIe, instead of conditionally performing these operations, omit the registration of the callback altogether on that plat

[edk2] [PATCH v4 resend v4 3/6] ArmPlatformPkg/ArmJunoDxe: use the generic non-discoverable device support

2017-04-05 Thread Ard Biesheuvel
Replace the open coded reimplementation of 'PCI emulation' with a pair of calls into NonDiscoverableDeviceRegistrationLib to register the OHCI and EHCI controllers. These will be picked up by the generic driver instead. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Bie

[edk2] [PATCH v4 resend v4 2/6] ArmPlatformPkg/ArmJunoDxe: remove BdsLib dependency

2017-04-05 Thread Ard Biesheuvel
The ArmJunoDxe driver does not actually depend on the deprecated BdsLib so remove the dependency declaration from the INF file. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel Tested-by: Ryan Harkin Reviewed-by: Leif Lindholm --- ArmPlatformPkg/ArmJunoPkg/

[edk2] [PATCH v4 resend v4 1/6] ArmPlatformPkg/ArmShellCmdRunAxf: remove BdsLib dependency

2017-04-05 Thread Ard Biesheuvel
Remove ArmShellCmdRunAxf's dependency on the deprecated BdsLib by cloning the ShutdownUefiBootServices() routine into a local source file; this is the only BdsLib feature 'runaxf' depends on. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel Tested-by: Ryan Har

Re: [edk2] [PATCH v4 0/6] Juno cleanup -- EDK2 edition

2017-04-05 Thread Ard Biesheuvel
Please disregard -- I failed to add Ryan's Tested-by On 5 April 2017 at 14:53, Ard Biesheuvel wrote: > This series is specific to Juno; it replaces the cargo culted and ancient > PCI 'emulation' code with calls into the new non-discoverable device API, > and removes the Juno specific PCI host br

[edk2] [PATCH v4 3/6] ArmPlatformPkg/ArmJunoDxe: use the generic non-discoverable device support

2017-04-05 Thread Ard Biesheuvel
Replace the open coded reimplementation of 'PCI emulation' with a pair of calls into NonDiscoverableDeviceRegistrationLib to register the OHCI and EHCI controllers. These will be picked up by the generic driver instead. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Bie

[edk2] [PATCH v4 4/6] ArmPlatformPkg/ArmJunoDxe: don't register OnEndOfDxe event on rev R0

2017-04-05 Thread Ard Biesheuvel
The ArmJunoDxe driver code registers a callback for the EndOfDxe event, at which time it does some manipulation of the PCI peripherals on the board. Given that R0 has no working PCIe, instead of conditionally performing these operations, omit the registration of the callback altogether on that plat

[edk2] [PATCH v4 0/6] Juno cleanup -- EDK2 edition

2017-04-05 Thread Ard Biesheuvel
This series is specific to Juno; it replaces the cargo culted and ancient PCI 'emulation' code with calls into the new non-discoverable device API, and removes the Juno specific PCI host bridge driver in favor of the generic one. v4: add missing commit log add acks *no* code changes Ard B

[edk2] [PATCH v4 1/6] ArmPlatformPkg/ArmShellCmdRunAxf: remove BdsLib dependency

2017-04-05 Thread Ard Biesheuvel
Remove ArmShellCmdRunAxf's dependency on the deprecated BdsLib by cloning the ShutdownUefiBootServices() routine into a local source file; this is the only BdsLib feature 'runaxf' depends on. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel Reviewed-by: Leif L

[edk2] [PATCH v4 2/6] ArmPlatformPkg/ArmJunoDxe: remove BdsLib dependency

2017-04-05 Thread Ard Biesheuvel
The ArmJunoDxe driver does not actually depend on the deprecated BdsLib so remove the dependency declaration from the INF file. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel Reviewed-by: Leif Lindholm --- ArmPlatformPkg/ArmJunoPkg/Drivers/ArmJunoDxe/ArmJu

Re: [edk2] [PATCH v3 3/6] ArmPlatformPkg/ArmJunoDxe: use the generic non-discoverable device support

2017-04-05 Thread Leif Lindholm
On Tue, Apr 04, 2017 at 01:30:07PM +0100, Ard Biesheuvel wrote: > Replace the open coded reimplementation of 'PCI emulation' with a pair > of calls into NonDiscoverableDeviceRegistrationLib to register the OHCI > and EHCI controllers. These will be picked up by the generic driver instead. > That

Re: [edk2] [PATCH v3 2/6] ArmPlatformPkg/ArmJunoDxe: remove BdsLib dependency

2017-04-05 Thread Leif Lindholm
On Tue, Apr 04, 2017 at 01:30:06PM +0100, Ard Biesheuvel wrote: > The ArmJunoDxe driver does not actually depend on the deprecated BdsLib > so remove the dependency declaration from the INF file. > Reviewed-by: Leif Lindholm > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off

[edk2] [PATCH v5] MdePkg: BaseIoLibIntrinsic (IoLib class) library

2017-04-05 Thread Leo Duran
This patch adds an SEV-specific .INF and corresponding assembly files, to unroll REP INSx/OUTSx on IoRead/WriteFifo#() routines when the SEV feature is enabled under a hypervisor environment. The new .INF only supports the IA32 and X64 architectures. Cc: Michael D Kinney Cc: Liming Gao Contribu

[edk2] [PATCH v5] MdePkg: BaseIoLibIntrinsic (IoLib class) library

2017-04-05 Thread Leo Duran
This patch adds an SEV-specific .INF and corresponding assembly files, to unroll REP INSx/OUTSx on IoRead/WriteFifo#() routines when the SEV feature is enabled under a hypervisor environment. The new .INF only supports the IA32 and X64 architectures. This patch follows the series "[PATCH v3 0

Re: [edk2] [PATCH v3 5/6] ArmPlatformPkg/ArmJunoPkg: remove PCI host bridge driver

2017-04-05 Thread Ard Biesheuvel
On 5 April 2017 at 14:18, Leif Lindholm wrote: > On Tue, Apr 04, 2017 at 01:30:09PM +0100, Ard Biesheuvel wrote: > > Should this not have come kind of commit message? > Oops, sorry about that. I'm pretty sure I added one at some point, but it got lost along the way. >> Contributed-under: TianoCo

Re: [edk2] [PATCH v3 6/6] ArmPlatformPkg/ArmJunoDxe: simplify ACPI table installation

2017-04-05 Thread Leif Lindholm
On Tue, Apr 04, 2017 at 01:30:10PM +0100, Ard Biesheuvel wrote: > Having a three way conditional with callbacks would make sense if the > callbacks weren't (a) identical and (b) didn't return TRUE all the > time. So get rid of the kludge. > Reviewed-by: Leif Lindholm > Contributed-under: TianoC

Re: [edk2] [PATCH v3 5/6] ArmPlatformPkg/ArmJunoPkg: remove PCI host bridge driver

2017-04-05 Thread Leif Lindholm
On Tue, Apr 04, 2017 at 01:30:09PM +0100, Ard Biesheuvel wrote: Should this not have come kind of commit message? > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Ard Biesheuvel > --- > ArmPlatformPkg/ArmJunoPkg/Drivers/PciHostBridgeDxe/PciHostBridge.c >

Re: [edk2] [PATCH v3 4/6] ArmPlatformPkg/ArmJunoDxe: don't register OnEndOfDxe event on rev R0

2017-04-05 Thread Leif Lindholm
On Tue, Apr 04, 2017 at 01:30:08PM +0100, Ard Biesheuvel wrote: > The ArmJunoDxe driver code registers a callback for the EndOfDxe event, > at which time it does some manipulation of the PCI peripherals on the > board. Given that R0 has no working PCIe, we can omit the registration > of the callbac

Re: [edk2] [PATCH v3 1/6] ArmPlatformPkg/ArmShellCmdRunAxf: remove BdsLib dependency

2017-04-05 Thread Ard Biesheuvel
On 5 April 2017 at 14:11, Ard Biesheuvel wrote: > On 5 April 2017 at 14:09, Leif Lindholm wrote: >> On Tue, Apr 04, 2017 at 01:30:05PM +0100, Ard Biesheuvel wrote: >>> Remove ArmShellCmdRunAxf's dependency on the deprecated BdsLib by >>> cloning the ShutdownUefiBootServices() routine into a local

Re: [edk2] [PATCH v4] MdePkg: BaseIoLibIntrinsic (IoLib class) library

2017-04-05 Thread Duran, Leo
Liming, Yes, agreed... I'll push a v5. Leo. > -Original Message- > From: Gao, Liming [mailto:liming@intel.com] > Sent: Tuesday, April 04, 2017 8:48 PM > To: Duran, Leo ; edk2-de...@ml01.01.org > Cc: Kinney, Michael D ; Singh, Brijesh > > Subject: RE: [edk2] [PATCH v4] MdePkg: BaseIoLi

Re: [edk2] [PATCH v3 1/6] ArmPlatformPkg/ArmShellCmdRunAxf: remove BdsLib dependency

2017-04-05 Thread Ard Biesheuvel
On 5 April 2017 at 14:09, Leif Lindholm wrote: > On Tue, Apr 04, 2017 at 01:30:05PM +0100, Ard Biesheuvel wrote: >> Remove ArmShellCmdRunAxf's dependency on the deprecated BdsLib by >> cloning the ShutdownUefiBootServices() routine into a local source >> file; this is the only BdsLib feature 'runa

Re: [edk2] [PATCH v3 1/6] ArmPlatformPkg/ArmShellCmdRunAxf: remove BdsLib dependency

2017-04-05 Thread Leif Lindholm
On Tue, Apr 04, 2017 at 01:30:05PM +0100, Ard Biesheuvel wrote: > Remove ArmShellCmdRunAxf's dependency on the deprecated BdsLib by > cloning the ShutdownUefiBootServices() routine into a local source > file; this is the only BdsLib feature 'runaxf' depends on. I was going to go through these indi

Re: [edk2] [PATCH v3 3/3] OvmfPkg/QemuVideoDxe: VMWare SVGA device support

2017-04-05 Thread Laszlo Ersek
On 04/05/17 14:37, Phil Dennis-Jordan wrote: >> In fact, above you already have a (BitsPerPixel == 32) check. At the end >> of that block, you could set PixelMask to MAX_UINT32 explicitly. And, >> you could add an "else" branch, simply with >> >> PixelMask = (1u << (BitsPerPixel - 1)) - 1; >> >>

[edk2] [PATCH v4 3/3] OvmfPkg/QemuVideoDxe: VMWare SVGA device support

2017-04-05 Thread Phil Dennis-Jordan
From: Phil Dennis-Jordan In addition to the QXL, Cirrus, etc. VGA adapters, Qemu also implements a basic version of VMWare's SVGA display device. Drivers for this device exist for some guest OSes which do not support Qemu's other display adapters, so supporting it in OVMF is useful in conjunction

[edk2] [PATCH v4 2/3] OvmfPkg/QemuVideoDxe: Helper functions for unaligned port I/O.

2017-04-05 Thread Phil Dennis-Jordan
From: Phil Dennis-Jordan The VMWare SVGA display device implemented by Qemu (-vga vmware) uses an I/O-type BAR which is laid out such that some register offsets are not aligned to the read/write width with which they are expected to be accessed. (The register value port has an offset of 1 and req

[edk2] [PATCH v4 1/3] OvmfPkg: VMWare SVGA display device register definitions

2017-04-05 Thread Phil Dennis-Jordan
From: Phil Dennis-Jordan This adds a header file defining symbolic constants for the VMWare SVGA virtual display device in preparation for supporting it in QemuVideoDxe. It is mostly an extract of the file lib/vmware/svga_reg.h from commit 329dd537456f93a806841ec8a8213aed11395def of VMWare's vmw

[edk2] [PATCH v4 0/3] OvmfPkg/QemuVideoDxe: Add VMWare SVGA framebuffer support

2017-04-05 Thread Phil Dennis-Jordan
This extends the QemuVideoDxe driver to support the VMWare SVGA display device implemented by Qemu. Drivers for this device exist for guest OSes which do not support Qemu's other display adapters, so supporting it in OVMF is useful in conjunction with those OSes. I've tried to follow the existing

Re: [edk2] [PATCH v3 3/3] OvmfPkg/QemuVideoDxe: VMWare SVGA device support

2017-04-05 Thread Phil Dennis-Jordan
On Wed, Apr 5, 2017 at 11:41 PM, Laszlo Ersek wrote: > On 04/05/17 11:58, Phil Dennis-Jordan wrote: >> From: Phil Dennis-Jordan >> >> In addition to the QXL, Cirrus, etc. VGA adapters, Qemu also implements >> a basic version of VMWare's SVGA display device. Drivers for this >> device exist for so

Re: [edk2] [PATCH v3 3/3] OvmfPkg/QemuVideoDxe: VMWare SVGA device support

2017-04-05 Thread Laszlo Ersek
On 04/05/17 11:58, Phil Dennis-Jordan wrote: > From: Phil Dennis-Jordan > > In addition to the QXL, Cirrus, etc. VGA adapters, Qemu also implements > a basic version of VMWare's SVGA display device. Drivers for this > device exist for some guest OSes which do not support Qemu's other > display ad

[edk2] [DxeNetLib] Why do we restrict each field to have the same leading zero format?

2017-04-05 Thread Guoheyi
Hi folks, We are using NetLibAsciiStrToIp6 function in DxeNetLib.c of MdeModulePkg to convert string to IPv6 address. We found this function will return invalid parameter with below input: 2001:3456:789a::f012:2:2003:2005 We trace the code and believe it is handled by the branch in line 295

Re: [edk2] [PATCH v3 2/3] OvmfPkg/QemuVideoDxe: Helper functions for unaligned port I/O.

2017-04-05 Thread Laszlo Ersek
On 04/05/17 11:57, Phil Dennis-Jordan wrote: > From: Phil Dennis-Jordan > > The VMWare SVGA display device implemented by Qemu (-vga vmware) uses > an I/O-type BAR which is laid out such that some register offsets are > not aligned to the read/write width with which they are expected to be > acce

Re: [edk2] [PATCH v3 1/3] OvmfPkg: VMWare SVGA display device register definitions

2017-04-05 Thread Laszlo Ersek
On 04/05/17 11:57, Phil Dennis-Jordan wrote: > From: Phil Dennis-Jordan > > This adds a header file defining symbolic constants for the VMWare SVGA > virtual display device in preparation for supporting it in > QemuVideoDxe. > > It is mostly an extract of the file lib/vmware/svga_reg.h from comm

Re: [edk2] [PATCH] MdeModulePkg: move PlatformHasAcpiGuid from EmbeddedPkg

2017-04-05 Thread Ard Biesheuvel
On 5 April 2017 at 10:49, Laszlo Ersek wrote: > On 04/05/17 11:38, Ard Biesheuvel wrote: >> Given the agreement on the edk2-devel regarding the fact that the >> notion whether or not a 'platform has ACPI' is a universal one, move >> the PlatformHasAcpi GUID to MdeModulePkg. >> >> Contributed-under

[edk2] [PATCH v3 1/3] OvmfPkg: VMWare SVGA display device register definitions

2017-04-05 Thread Phil Dennis-Jordan
From: Phil Dennis-Jordan This adds a header file defining symbolic constants for the VMWare SVGA virtual display device in preparation for supporting it in QemuVideoDxe. It is mostly an extract of the file lib/vmware/svga_reg.h from commit 329dd537456f93a806841ec8a8213aed11395def of VMWare's vmw

[edk2] [PATCH v3 3/3] OvmfPkg/QemuVideoDxe: VMWare SVGA device support

2017-04-05 Thread Phil Dennis-Jordan
From: Phil Dennis-Jordan In addition to the QXL, Cirrus, etc. VGA adapters, Qemu also implements a basic version of VMWare's SVGA display device. Drivers for this device exist for some guest OSes which do not support Qemu's other display adapters, so supporting it in OVMF is useful in conjunction

[edk2] [PATCH v3 2/3] OvmfPkg/QemuVideoDxe: Helper functions for unaligned port I/O.

2017-04-05 Thread Phil Dennis-Jordan
From: Phil Dennis-Jordan The VMWare SVGA display device implemented by Qemu (-vga vmware) uses an I/O-type BAR which is laid out such that some register offsets are not aligned to the read/write width with which they are expected to be accessed. (The register value port has an offset of 1 and req

[edk2] [PATCH v3 0/3] OvmfPkg/QemuVideoDxe: Add VMWare SVGA framebuffer support

2017-04-05 Thread Phil Dennis-Jordan
This extends the QemuVideoDxe driver to support the VMWare SVGA display device implemented by Qemu. Drivers for this device exist for guest OSes which do not support Qemu's other display adapters, so supporting it in OVMF is useful in conjunction with those OSes. I've tried to follow the existing

Re: [edk2] Using Intel UDk debugger

2017-04-05 Thread Arka Sharma
When I try to set break point after launching the application and CpuBreakpoint() is hit and symbols are seen in lmv command, the breakpoints are set using F9. I can list them with bl. But if I attempt to set a breakpoint with F9 before CpuBreakpoint is called WinDbg pops up a dialog box throwing t

Re: [edk2] [PATCH] MdeModulePkg: move PlatformHasAcpiGuid from EmbeddedPkg

2017-04-05 Thread Laszlo Ersek
On 04/05/17 11:38, Ard Biesheuvel wrote: > Given the agreement on the edk2-devel regarding the fact that the > notion whether or not a 'platform has ACPI' is a universal one, move > the PlatformHasAcpi GUID to MdeModulePkg. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-b

Re: [edk2] [PATCH 2/2] NetworkPkg/TcpDxe: Fix unconditional window shrinking

2017-04-05 Thread Fu, Siyuan
Hi, Andrey When the client received such a segment that moves the right edge of send window back to the left said, the client actually have no idea about whether the server is "shrinking the window" or just "reducing window size". Actually, if the server reduced the advertised windows size too

[edk2] [PATCH] MdeModulePkg: move PlatformHasAcpiGuid from EmbeddedPkg

2017-04-05 Thread Ard Biesheuvel
Given the agreement on the edk2-devel regarding the fact that the notion whether or not a 'platform has ACPI' is a universal one, move the PlatformHasAcpi GUID to MdeModulePkg. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel Reviewed-by: "Zeng, Star" --- Ar

  1   2   >