Re: [edk2] [patch] BaseTools/ECC: Change check rule for Ifndef statement

Reviewed-by: Hao Wu Also tested upon codes in MdePkg\Library\BaseLib, the reported issues for '#ifndef DISABLE_NEW_DEPRECATED_INTERFACES' used in file MdePkg\Library\BaseLib\String.c now go away. Best Regards, Hao Wu > -Original Message- > From: edk2-devel

[edk2] 答复: [ScsiDiskDxe] Implict type conversion bug

Thanks for your quick fix :) -邮件原件- 发件人: Zeng, Star [mailto:star.z...@intel.com] 发送时间: 2017年4月10日 17:48 收件人: Guoheyi; edk2-devel@lists.01.org 抄送: Tian, Feng; Zeng, Star 主题: RE: [edk2] [ScsiDiskDxe] Implict type conversion bug Hao has sent patch for this issue. You can search emails with

Re: [edk2] SUT hangs after performing a warm boot.

Ok, I didn't loop in another email discussion. I just reviewed the patch from Lubo, and I think it may be related to this issue since both of them are triggered by Ip6NdFasterTimerTicking. Thanks, Jiaxin > -Original Message- > From: Santhapur Naveen [mailto:nave...@amiindia.co.in] >

Re: [edk2] [PATCH] MdeModulePkg/BootManagerMenu: Add assertion to indicate no DIV by 0

Reviewed-by: Hao Wu Best Regards, Hao Wu > -Original Message- > From: Ni, Ruiyu > Sent: Tuesday, April 11, 2017 10:22 AM > To: edk2-devel@lists.01.org > Cc: Wu, Hao A > Subject: [PATCH] MdeModulePkg/BootManagerMenu: Add assertion to indicate > no DIV by 0 > >

[edk2] [PATCH] MdeModulePkg/BootManagerMenu: Add assertion to indicate no DIV by 0

BootMenuSelectItem() contains code to DIV BootMenuData->ItemCount. When BootMenuData->ItemCount can be 0, the DIV operation may trigger CPU exception. But in logic, this case won't happen. So add assertion to indicate it. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by:

Re: [edk2] SUT hangs after performing a warm boot.

Hi Jiaxin, I think this patch is for another fix which causes ASSERT. But anyways I'll give it a try and update you. Thanks, Naveen -Original Message- From: Wu, Jiaxin [mailto:jiaxin...@intel.com] Sent: Tuesday, April 11, 2017 7:05 AM To: Santhapur Naveen;

[edk2] [PATCH 2/2] IntelFrameworkPkg/UefiLib: Avoid mis-calculate of graphic console size

The commit adds check in function InternalPrintGraphic() to ensure that the expression: Blt->Width * Blt->Height * sizeof (EFI_GRAPHICS_OUTPUT_BLT_PIXEL) will not overflow in the UINTN range. The commit also adds an explicit UINT32 type cast for 'Blt->Width' to avoid possible overflow in the

[edk2] [PATCH 0/2] UefiLib: Avoid mis-calculate of graphic console size

The series add checks to avoid potential mis-calculate of graphic console size in MdePkg(IntelFrameworkPkg)/UefiLib. Hao Wu (2): MdePkg/UefiLib: Avoid mis-calculate of graphic console size IntelFrameworkPkg/UefiLib: Avoid mis-calculate of graphic console size

[edk2] [PATCH 1/2] MdePkg/UefiLib: Avoid mis-calculate of graphic console size

The commit adds check in function InternalPrintGraphic() to ensure that the expression: Blt->Width * Blt->Height * sizeof (EFI_GRAPHICS_OUTPUT_BLT_PIXEL) will not overflow in the UINTN range. The commit also adds an explicit UINT32 type cast for 'Blt->Width' to avoid possible overflow in the

[edk2] [PATCH] MdeModulePkg/Dxe/Image: Restore mCurrentImage on all paths

This commit makes sure that in function CoreStartImage(), module variable 'mCurrentImage' is restored to the current start image context on all code paths. Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Hao Wu ---

Re: [edk2] Using USB-Ethernet adapter in UEFI on an arm64 platform

Ax88772b driver's quality is better than Ax88772. But all of them aren't handled no-data case without latency. So if possible, I would suggest you to not use Ax88772x device. Realtek usb2lan is a good choice but the disadvantage of it is there looks like has no corresponding open-source UEFI

Re: [edk2] [edk2-FdfSpecification Patch] FILE RAW Multiple binaries and FmpPayload extensions

Reviewed-by: Yonghong Zhu -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Michael Kinney Sent: Wednesday, April 5, 2017 3:54 PM To: edk2-devel@lists.01.org Cc: Gao, Liming Subject: [edk2]

Re: [edk2] [PATCH v2] MdeModulePkg/ScsiDiskDxe: Fix undefined behavior in signed left shift

Reviewed-by: Feng Tian Thanks Feng -Original Message- From: Wu, Hao A Sent: Tuesday, April 11, 2017 9:30 AM To: edk2-devel@lists.01.org; ler...@redhat.com; guoh...@huawei.com Cc: Wu, Hao A ; Tian, Feng Subject: [PATCH v2]

Re: [edk2] SUT hangs after performing a warm boot.

Hi Naveen, Can you help to verify whether the attached patch can resolve your issue? Thanks, Jiaxin > -Original Message- > From: Santhapur Naveen [mailto:nave...@amiindia.co.in] > Sent: Monday, April 10, 2017 7:31 PM > To: Wu, Jiaxin ; edk2-devel@lists.01.org >

Re: [edk2] [edk2-FdfSpecification PATCH 0/2] Allow macros in !include file paths

The patches are good to me. Reviewed-by: Yonghong Zhu Best Regards, Zhu Yonghong -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Michael Kinney Sent: Saturday, April 08, 2017 10:45 AM To: edk2-devel@lists.01.org

[edk2] [PATCH v2] MdeModulePkg/ScsiDiskDxe: Fix undefined behavior in signed left shift

In function GetMediaInfo(), the following expression: ScsiDiskDevice->BlkIo.Media->LastBlock = (Capacity10->LastLba3 << 24) | (Capacity10->LastLba2 << 16) | (Capacity10->LastLba1 << 8) |

Re: [edk2] [PATCH] MdeModulePkg/ScsiDiskDxe: Fix potential implicit sign extension

> -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Monday, April 10, 2017 11:47 PM > To: Wu, Hao A; edk2-devel@lists.01.org > Cc: Tian, Feng; guoh...@huawei.com > Subject: Re: [edk2] [PATCH] MdeModulePkg/ScsiDiskDxe: Fix potential implicit > sign extension > >

Re: [edk2] MemoryProfile at UDK2015

Perfect. Thanks for the answer Brian! Em seg, 10 de abr de 2017 às 16:26, Richardson, Brian < brian.richard...@intel.com> escreveu: > UDL2015 is a stable snapshot of EDK II modules validated on Intel > architecture platforms. This module isn't validated as part of that > snapshot, hence the

Re: [edk2] MemoryProfile at UDK2015

UDL2015 is a stable snapshot of EDK II modules validated on Intel architecture platforms. This module isn't validated as part of that snapshot, hence the omission. You can still use this module with UDK2015, as long as you pull from the git hash or SVN revision from the UDK2015 release notes.

[edk2] MemoryProfile at UDK2015

Hi everyone. I was taking a look on how to detect a memory leak, and found this page: https://github.com/tianocore/tianocore.github.io/wiki/Memory-leak-detection-with-memory-profile-feature When trying to follow these steps, I noticed that we don't have the MemoryProfileLib available at the

[edk2] [RFT PATCH] EmbeddedPkg/AndroidFastbootApp: remove dependency on deprecated BdsLib

One of the last remaining modules with a dependency on the deprecated BdsLib implementation from ArmPkg is the Android fastboot application. Its only dependency on BdsLib is BdsStartEfiApplication(), which is used in the most peculiar way: the fastboot app loads the kernel image into memory, and

Re: [edk2] [PATCH v3 0/3] ArmPlatformPkg: FVP spring cleaning -- EDK2 edition

On Mon, Apr 10, 2017 at 05:21:49PM +0100, Ard Biesheuvel wrote: > This v3 of the ArmPlatformPkg now only contains FVP changes. TC2 and Juno > will receive a similar treatment once we have sorted out how the loading of > the DTB image from the NOR flash will be implemented. > > So what remains

[edk2] [PATCH v3 2/3] ArmPlatformPkg/ArmVExpressDxe: remove unused cruft from ArmHwDxe

Remove unused cruft from ArmHwDxe -- the only thing that remains is installation of the 'runaxf' shell command. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel --- ArmPlatformPkg/ArmVExpressPkg/ArmVExpressDxe/ArmHwDxe.c | 43

[edk2] [PATCH v3 3/3] ArmPlatformPkg/ArmVExpressDxe: remove FDT handling from ArmFvpDxe

Replace the elaborate but awkward handling of FDT images using device paths and string PCDs initialized to 128 spaces with a simple scheme involving a set of builtin DTBs and a bit of runtime logic to select between them. This is sufficient for ordinary use, which makes it more suitable as

[edk2] [PATCH v3 1/3] ArmPlatformPkg/ArmVExpressDxe: remove ARM support

The 32-bit ARM support in this driver is unused, and thus untested. So let's just remove it. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel --- ArmPlatformPkg/ArmVExpressPkg/ArmVExpressDxe/Arm/ArmFvpDxeArm.c | 84

[edk2] [PATCH v3 0/3] ArmPlatformPkg: FVP spring cleaning -- EDK2 edition

This v3 of the ArmPlatformPkg now only contains FVP changes. TC2 and Juno will receive a similar treatment once we have sorted out how the loading of the DTB image from the NOR flash will be implemented. So what remains here is two somewhat unrelated cleanup patches, and the meat in #3 which

Re: [edk2] Using USB-Ethernet adapter in UEFI on an arm64 platform

Hi Feng, Thank you for your explanation. I have Cisco 300M AX88772A-based adapter, so AX88772 (with no "b") driver was picked up. I had to modify it with circular buffer to get ping and tftp going. Also I had to receive packets in GetStatus rather than in SN_Receive (otherwise I could never get

Re: [edk2] Running pieces of PEI from binary UEFI images

> On Apr 10, 2017, at 12:48 AM, Stefano Cristalli > wrote: > > Hello everyone, > > I'm interested in experimenting with the PEI phase using EmulatorPkg, > OVMF and other EDKII parts that could be useful. > In particular, I'm interested in the possibility of

Re: [edk2] [PATCH] MdeModulePkg/ScsiDiskDxe: Fix potential implicit sign extension

(Gary, is your Linaro email still alive?) On 04/10/17 09:43, Hao Wu wrote: > In function GetMediaInfo(), the following expression: > ScsiDiskDevice->BlkIo.Media->LastBlock = (Capacity10->LastLba3 << 24) | > (Capacity10->LastLba2 << 16) | >

Re: [edk2] SUT hangs after performing a warm boot.

Hi Jiaxin, Below are the simple reproduction steps: BIOS UEFI Class3 (1) Connect LAN cable (Realtek) (2) Do cold boot or warm boot stress (Windows 10) Please let me know for any additional information you may need. Thanks, Naveen -Original

Re: [edk2] [Patch] BaseTools: Add option in CLANG38 to disable warning unknown-warning-option

Reviewed-by: Yonghong Zhu Best Regards, Zhu Yonghong -Original Message- From: Gao, Liming Sent: Monday, April 10, 2017 1:28 PM To: edk2-devel@lists.01.org Cc: Zhu, Yonghong Subject: [Patch] BaseTools: Add option in CLANG38 to disable

Re: [edk2] [ScsiDiskDxe] Implict type conversion bug

Hao has sent patch for this issue. You can search emails with title "[edk2] [PATCH] MdeModulePkg/ScsiDiskDxe: Fix potential implicit sign extension". Thanks, Star -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Guoheyi Sent: Monday, April 10,

[edk2] [ScsiDiskDxe] Implict type conversion bug

Hi folks, In MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDisk.c, Line 2757, we have the code as below: ScsiDiskDevice->BlkIo.Media->LastBlock = (Capacity10->LastLba3 << 24) | (Capacity10->LastLba2 << 16) |

[edk2] Running pieces of PEI from binary UEFI images

Hello everyone, I'm interested in experimenting with the PEI phase using EmulatorPkg, OVMF and other EDKII parts that could be useful. In particular, I'm interested in the possibility of integrating parts of an existing pre-built binary UEFI image with such environments. If the image was

[edk2] [PATCH] MdeModulePkg/ScsiDiskDxe: Fix potential implicit sign extension

In function GetMediaInfo(), the following expression: ScsiDiskDevice->BlkIo.Media->LastBlock = (Capacity10->LastLba3 << 24) | (Capacity10->LastLba2 << 16) | (Capacity10->LastLba1 << 8) |

[edk2] [PATCH 1/3] MdeModulePkg: Error Level is not used correctly

Cc: Feng Tian Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jeff Fan --- .../Universal/Acpi/BootScriptExecutorDxe/ScriptExecute.c | 10 +- .../Universal/Acpi/BootScriptExecutorDxe/X64/SetIdtEntry.c | 4 ++--

[edk2] [PATCH 0/3] Error Level is not used correctly

Some modules mis-used error level when outputting debug message. Jeff Fan (3): MdeModulePkg: Error Level is not used correctly SecurityPkg: Error Level is not used correctly UefiCpuPkg: Error Level is not used correctly .../Acpi/BootScriptExecutorDxe/ScriptExecute.c | 10 ++--

[edk2] [PATCH 2/3] SecurityPkg: Error Level is not used correctly

Cc: Jiewen Yao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jeff Fan --- SecurityPkg/Library/Tpm2DeviceLibRouter/Tpm2DeviceLibRouterDxe.c | 4 ++-- SecurityPkg/Library/Tpm2DeviceLibRouter/Tpm2DeviceLibRouterPei.c | 4 ++--

[edk2] [PATCH 3/3] UefiCpuPkg: Error Level is not used correctly

Cc: Feng Tian Cc: Jiewen Yao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jeff Fan --- UefiCpuPkg/CpuDxe/CpuPageTable.c | 2 +- UefiCpuPkg/Universal/Acpi/S3Resume2Pei/S3Resume.c | 68

[edk2] [PATCH] MdeModulePkg/DxeCore: Add ASSERT to ensure no subtract underflow

For function SplitRecord() in file PropertiesTable.c, there is a potential subtract underflow case for line: return TotalNewRecordCount - 1; However, such case will not happen since the logic in function SplitTable() ensure that when calling SplitRecord(), the variable 'TotalNewRecordCount'