Re: [edk2] [PATCH] MdeModulePkg: Add EFI_GCD_MEMORY_SPACE_NOTIFY_PROTOCOL

2017-04-14 Thread Duran, Leo
All, Let's please drop this patch for now... We're evaluating Yao's suggestion (which looks OK so far). Thanks, Leo. From: Yao, Jiewen [mailto:jiewen@intel.com] Sent: Wednesday, April 12, 2017 10:06 PM To: Duran, Leo ; Zeng, Star ; Laszlo Ersek ; Kinney, Michael D ; edk2-de...@ml01.01.org

Re: [edk2] [PATCH 2/2] NetworkPkg/TcpDxe: Fix unconditional window shrinking

2017-04-14 Thread ate...@kraftway.ru
Hello, Siyuan, Thank you for your reply. I created a bug#486 in bugzilla for this case. And answering your questions: 1. In frame 4496 client sends data starting from 589546 with len of 1448 and ending with 590994 seq number. Previously offered window from server was in frame 4495 Wnd=5632 ACK

[edk2] [PATCH] EmbeddedPkg/AndroidFastbootApp: support sparse image

2017-04-14 Thread Haojian Zhuang
Support sparse image that is reformatted from large raw image and splitted into a few smaller images. The sparse image follows the rule of Android Sparse Image format. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Haojian Zhuang --- .../AndroidFastboot/AndroidFastbootApp

Re: [edk2] [PATCH 2/2] NetworkPkg/TcpDxe: Fix unconditional window shrinking

2017-04-14 Thread Fu, Siyuan
Hi, Andrey I’d like to compare the original code logic and your suggested change: Original: Right = Seg->Ack + Seg->Wnd; ... if (TCP_SEQ_LT (Right, Tcb->SndNxt)) { <- check if “Seg->Ack+ Seg->Wnd– SndNxt < 0” Change to: if (TCP_SEQ_LT (Tcb->SndUna + Tcb->SndWnd, Tcb-

[edk2] [Patch][edk2-platforms/devel-MinnowBoard3] Fix issue in PlatformSMM

2017-04-14 Thread Guo, Mang
Change code to set R_SMI_EN earlier in S3 boot path to make sure all SMI were detected. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Guo Mang --- Platform/BroxtonPlatformPkg/Common/PlatformSmm/Platform.c | 13 - Platform/BroxtonPlatformPkg/Common/PlatformSm

Re: [edk2] [Patch] CryptoPkg: Correct some minor issues in function comments

2017-04-14 Thread Ye, Ting
Reviewed-by: Ye Ting -Original Message- From: Long, Qin Sent: Friday, April 14, 2017 4:35 PM To: Ye, Ting ; edk2-devel@lists.01.org Cc: Long, Qin Subject: [Patch] CryptoPkg: Correct some minor issues in function comments Correct some minor comment issues in BaseCryptLib.h and CryptPkc

[edk2] [Patch] CryptoPkg: Correct some minor issues in function comments

2017-04-14 Thread Long Qin
Correct some minor comment issues in BaseCryptLib.h and CryptPkcs7Verify.c, including: - missed "out" in parameter property for ARC4 interfaces; - Wrong Comment tail in Pkcs7GetAttachedContent function Cc: Ting Ye Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Qin Long