Re: [edk2] [PATCH v2 1/1] MdeModulePkg/PiSmmCore: Pad POOL_HEADER to be 8-byte aligned

Thanks, this is better. I recall that I have submitted a bugzillar before to enhance Smm FreePool to catch buffer overflow https://bugzilla.tianocore.org/show_bug.cgi?id=407 Maybe we can use below structure, then we do not need PAD. typedef struct { // Proposal for SMM core UINT32 Si

[edk2] Unable to boot OVMF on qemu-x86_64

Hi All, I am facing an issue booting OVMF on qemu, could you please help me? I have cloned EDKII, and built OVMF for X64 using GCC5. I have followed the steps given at https://wiki.ubuntu.com/UEFI/EDK2. Then I have used qemu-system-x86_64 to boot OVMF, but it fails, I don't see anything on tty0

Re: [edk2] [edk2-BuildSpecification PATCH] Clarify alignment requirements for VPD VOID* PCDs

Reviewed-by: Yonghong Zhu Best Regards, Zhu Yonghong -Original Message- From: Kinney, Michael D Sent: Tuesday, April 18, 2017 12:41 PM To: edk2-devel@lists.01.org Cc: Gao, Liming ; Zhu, Yonghong ; Shaw, Kevin W Subject: [edk2-BuildSpecification PATCH] Clarify alignment requirements

[edk2] [Patch][edk2-platforms/devel-MinnowBoard3] Fix setup assert issue

Debug BIOS will assert if change setup and save. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Guo Mang --- .../PlatformSettings/PlatformSetupDxe/SetupInfoRecords.c | 15 +-- 1 file changed, 1 insertion(+), 14 deletions(-) diff --git a/Platform/BroxtonPlat

Re: [edk2] [patch] MdeModulePkg/BMMUiLib: Update codes of initializing ConsoleXXXCheck array

Reviewed-by: Eric Dong -Original Message- From: Bi, Dandan Sent: Tuesday, April 18, 2017 11:50 AM To: edk2-devel@lists.01.org Cc: Dong, Eric Subject: [patch] MdeModulePkg/BMMUiLib: Update codes of initializing ConsoleXXXCheck array When initializing ConsoleOutCheck/ConsoleInCheck/Conso

[edk2] [edk2-BuildSpecification PATCH] Clarify alignment requirements for VPD VOID* PCDs

https://bugzilla.tianocore.org/show_bug.cgi?id=490 GitHub branch for review: https://github.com/mdkinney/edk2-BuildSpecification/tree/Bugzilla_490_ClarifyVpdPcdAlignment GitHub branch compare against latest DRAFT for review: https://github.com/tianocore-docs/edk2-BuildSpecification/compar

[edk2] [edk2-BuildSpecification PATCH] Clarify alignment requirements for VPD VOID* PCDs

https://bugzilla.tianocore.org/show_bug.cgi?id=490 Clarify when error or warning messages are generated for VOID* PCDs when VPD offset is not aligned. Unicode string VPD PCDs must be 2-byte aligned. Byte array {} VPD PCDs should be 8-byte aligned, but is only a warning message if they are not 8-by

Re: [edk2] [PATCH 2/2] NetworkPkg/TcpDxe: Fix unconditional window shrinking

Hi, Andrey Thanks for provide the log file. I think your point is right, that the server is not really reduce the window size, since it could still ACK the whole data to 199866. I searched the IETF and finally found the RFC7323, it’s an updated version of TCP window scale option, and discussed

[edk2] [patch] MdeModulePkg/BMMUiLib: Update codes of initializing ConsoleXXXCheck array

When initializing ConsoleOutCheck/ConsoleInCheck/ConsoleErrCheck array in BMM_FAKE_NV_DATA structure, also need to consider whether the terminal device is ConOut/ConIn/ConErr or not. Cc: Eric Dong Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi --- .../BootMaint

Re: [edk2] [RFC] [PATCH V3 3/3] MdeModulePkg/PciBus: Add IOMMU support.

Yes, I agree. It is a little complicated. NeedAllocateNonExisting is TRUE when: A. IoMMU is present (AND) B. We need remap a Buffer below 4GiB, but we cannot find enough memory there. Because CommonBuffer and Read/WriteBuffer is handled in different way, we have to separate #B to be 2 cases.

Re: [edk2] [RFC] [PATCH V3 2/3] MdeModulePkg/PciHostBridge: Add IOMMU support.

Thanks Leo. Answer below: From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Duran, Leo Sent: Tuesday, April 18, 2017 3:33 AM To: Yao, Jiewen ; edk2-devel@lists.01.org Cc: Ni, Ruiyu ; Singh, Brijesh ; Ard Biesheuvel Subject: Re: [edk2] [RFC] [PATCH V3 2/3] MdeModulePkg/PciHo

[edk2] [PATCH v2 0/1] MdeModulePkg/PiSmmCore: Pad POOL_HEADER to be 8-byte aligned

V2 changes: Add comments for the purpose of the newly added 'Padding' field in structure 'POOL_HEADER'. Cc: Jiewen Yao Hao Wu (1): MdeModulePkg/PiSmmCore: Pad POOL_HEADER to be 8-byte aligned MdeModulePkg/Core/PiSmmCore/PiSmmCore.h | 8 1 file changed, 8 insertions(+) -- 2.12.0.wi

[edk2] [PATCH v2 1/1] MdeModulePkg/PiSmmCore: Pad POOL_HEADER to be 8-byte aligned

According to the PI spec (Vol 4, Section 3.2 SmmAllocatePool()): The SmmAllocatePool() function ... All allocations are eight-byte aligned. The commit adds a padding field in structure 'POOL_HEADER' to ensure the above requirement is met. Cc: Jiewen Yao Contributed-under: TianoCore Contribution

Re: [edk2] [edk2-DscSpecification PATCH] Declare Pre/Post build scripts in [Defines] section

Reviewed-by: Yonghong Zhu Best Regards, Zhu Yonghong -Original Message- From: Kinney, Michael D Sent: Tuesday, April 18, 2017 9:08 AM To: edk2-devel@lists.01.org Cc: Gao, Liming ; Zhu, Yonghong ; Shaw, Kevin W Subject: [edk2-DscSpecification PATCH] Declare Pre/Post build scripts in

Re: [edk2] [edk2-BuildSpecification PATCH] Declare Pre/Post build scripts in [Defines] section

Reviewed-by: Yonghong Zhu Best Regards, Zhu Yonghong -Original Message- From: Kinney, Michael D Sent: Tuesday, April 18, 2017 9:06 AM To: edk2-devel@lists.01.org Cc: Gao, Liming ; Zhu, Yonghong ; Shaw, Kevin W Subject: [edk2-BuildSpecification PATCH] Declare Pre/Post build scripts in

[edk2] [PATCH] UefiCpuPkg/PiSmmCpuDxeSmm: Lock should be acquired

SMM BSP's *busy* state should be acquired. We could use AcquireSpinLock() instead of AcquireSpinLockOrFail(). Cc: Hao Wu Cc: Feng Tian Cc: Michael Kinney Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jeff Fan --- UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c | 2 +- 1 file ch

[edk2] [PATCH] MdeModulePkg/PiSmmCore: Pad POOL_HEADER to be 8-byte aligned

According to the PI spec (Vol 4, Section 3.2 SmmAllocatePool()): The SmmAllocatePool() function ... All allocations are eight-byte aligned. The commit adds a padding field in structure 'POOL_HEADER' to ensure the above requirement is met. Cc: Jiewen Yao Contributed-under: TianoCore Contribution

[edk2] [edk2-DscSpecification PATCH] Declare Pre/Post build scripts in [Defines] section

https://bugzilla.tianocore.org/show_bug.cgi?id=484 GitHub branch for review: https://github.com/mdkinney/edk2-DscSpecification/tree/Bugzilla_484_PrePostBuild GitHub branch compare against latest DRAFT for review: https://github.com/tianocore-docs/edk2-DscSpecification/compare/master...m

[edk2] [edk2-DscSpecification PATCH] Declare Pre/Post build scripts in [Defines] section

https://bugzilla.tianocore.org/show_bug.cgi?id=484 Add support for PREBUILD and POSTBUILD defines in the [Defines] section of an DSC to declare scripts that are executed before and after normal DSC/FDF file processing. Cc: Liming Gao Cc: Yonghong Zhu Cc: Kevin W Shaw Contributed-under: TianoCo

[edk2] [edk2-BuildSpecification PATCH] Declare Pre/Post build scripts in [Defines] section

https://bugzilla.tianocore.org/show_bug.cgi?id=483 GitHub branch for review: https://github.com/mdkinney/edk2-BuildSpecification/tree/Bugzilla_483_PrePostBuild GitHub branch compare against latest DRAFT for review: https://github.com/tianocore-docs/edk2-BuildSpecification/compare/master

[edk2] [edk2-BuildSpecification PATCH] Declare Pre/Post build scripts in [Defines] section

https://bugzilla.tianocore.org/show_bug.cgi?id=483 Add support for PREBUILD and POSTBUILD defines in the [Defines] section of an DSC to declare scripts that are executed before and after normal DSC/FDF file processing. Cc: Liming Gao Cc: Yonghong Zhu Cc: Kevin W Shaw Contributed-under: TianoCo

[edk2] NASM 2.13rc20 - hopefully final, please help test

After quite a number of iterations, we now have a NASM release with Mach-O DWARF support and a number of other enhancements. This is what I fully expect to be the final release minus any bug fixes. Although this is quite a jump in version numbers from the previously announced rc20, a lot of the i

Re: [edk2] [RFC] [PATCH V3 3/3] MdeModulePkg/PciBus: Add IOMMU support.

Hi Yao, Regarding RootBridgeIoMap() I'm wondering if may be possible to simplify the logic requiring flags "NeedMap" and "NeedAllocateNonExisting"? For example, it seems like (NeedAllocateNonExisting==TRUE) implies (gIoMmuProtocol != NULL), but that did not seem obvious at a glance. Leo. > --

Re: [edk2] [RFC] [PATCH V3 2/3] MdeModulePkg/PciHostBridge: Add IOMMU support.

Hi Yao, Just a couple of quick comments: 1) gIoMmuProtocol is declared (global) by PciHostBridge.c, but it is not initialized to NULL. 2) Would it be OK to do a one-time LocateProtocol() of gIoMmuProtocol in InitializePciHostBridge()? BTW, besides the global declaration, gIoMmuProtocol is cu

Re: [edk2] [PATCH 2/2] NetworkPkg/TcpDxe: Fix unconditional window shrinking

Hello, Siyuan Sorry for providing incomplete log. I think missing packets is not the case here since all packets reached client. I made another log and I am attaching it to this email (full wireshark log from start of transmission). I am also attaching log from TcpDxe driver (added debug print

Re: [edk2] [RFC] [PATCH V3 1/3] MdeModulePkg/Include: Add IOMMU protocol definition.

Hi Ard Thanks for the feedback. Detailed comment below: From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] Sent: Monday, April 17, 2017 9:43 PM To: Yao, Jiewen Cc: edk2-devel@lists.01.org; Ni, Ruiyu ; Leo Duran ; Brijesh Singh Subject: Re: [RFC] [PATCH V3 1/3] MdeModulePkg/Include: Add I

Re: [edk2] [PATCH] MdeModulePkg: ScsiDiskDxe: fix to support EFI_ERASE_BLOCK_PROTOCOL

Hi Hao, I tried the discard operation on my UFS device. It just return 0. And erase operation isn’t supported on my UFS device. If I don’t support discard operation, I can’t erase blocks at all. Best Regards Haojian From: Wu, Hao A Sent: 2017年4月17日 9:59 To: Haojian Z

Re: [edk2] [RFC] [PATCH V3 1/3] MdeModulePkg/Include: Add IOMMU protocol definition.

On 4 April 2017 at 08:06, Jiewen Yao wrote: > This protocol is to abstract DMA access from IOMMU. > 1) Intel "DMAR" ACPI table. > 2) AMD "IVRS" ACPI table > 3) ARM "IORT" ACPI table. > > There might be multiple IOMMU engines on one platform. > For example, one for graphic and one for rest PCI devi

Re: [edk2] [PATCH] ShellPkg/ConsistMapping: Remove unneeded memory reallocation

Reviewed-by: Jaben Carsey > -Original Message- > From: Ni, Ruiyu > Sent: Sunday, April 16, 2017 11:29 PM > To: edk2-devel@lists.01.org > Cc: Michael Turner ; Carsey, Jaben > > Subject: [PATCH] ShellPkg/ConsistMapping: Remove unneeded memory > reallocation > Importance: High > > Contribu

Re: [edk2] [PATCH] ShellPkg/Pci: Always dump the extended config space for PCIE

Reviewed-by: Jaben Carsey > -Original Message- > From: Ni, Ruiyu > Sent: Sunday, April 16, 2017 8:13 PM > To: edk2-devel@lists.01.org > Cc: Carsey, Jaben ; Jim Dailey > Subject: [PATCH] ShellPkg/Pci: Always dump the extended config space for PCIE > Importance: High > > It is to align to

Re: [edk2] NvmExpressDxe async application crash with UDK debugger

There is a mistake I had in my code. The NVMe command Packet is a local variable to ReadSectors, whose address is being passed to PassThru. So PassThru will return after pushing the command to async submission queue and create an AsyncRequest and insert it in AsyncPassThruQueueand return. So the A

Re: [edk2] [Patch] BaseTools: Update the Conf directory to use the absolute path

Reviewed-by: Liming Gao >-Original Message- >From: Zhu, Yonghong >Sent: Monday, April 17, 2017 5:23 PM >To: edk2-devel@lists.01.org >Cc: Gao, Liming >Subject: [Patch] BaseTools: Update the Conf directory to use the absolute >path > >Update the Conf directory to use the absolute path for

[edk2] [Patch] BaseTools: Update the Conf directory to use the absolute path

Update the Conf directory to use the absolute path for build_rule.txt and tools_def.txt. Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Yonghong Zhu --- BaseTools/Source/Python/AutoGen/AutoGen.py | 8 1 file changed, 4 insertions(+), 4 deletions(-

Re: [edk2] [Patch] NetworkPkg: Correct the proxy DHCP offer handing

Reviewed-by: Ye Ting -Original Message- From: Wu, Jiaxin Sent: Monday, April 17, 2017 11:40 AM To: edk2-devel@lists.01.org Cc: RickF ; Ye, Ting ; Fu, Siyuan ; Zhang, Lubo ; Wu, Jiaxin Subject: [Patch] NetworkPkg: Correct the proxy DHCP offer handing When PXE10/WFM11a offer received,

[edk2] [Patch] MdeModulePkg/DeviceManagerUiLib: Fix the network device MAC display issue

Network device tile (STR_FORM_NETWORK_DEVICE_TITLE) is dynamic adjusted according the different MAC value. So, the string value shouldn't be treated as a constant string (Network Device). Otherwise, the display will be incorrect. Reproduce: Device Manager->Network Device List, select to enter MAC,

Re: [edk2] SUT hangs after performing a warm boot.

Jiaxin, Filed a bug in the bugzilla https://bugzilla.tianocore.org/show_bug.cgi?id=489 Let me know if you may need any details. Regards, Naveen -Original Message- From: Wu, Jiaxin [mailto:jiaxin...@intel.com] Sent: Monday, April 17, 2017 12:12 PM To: Santhapur Naveen; ed