Re: [edk2] [ edk2-BuildSpecification PATCH 2/2] Add --pcd flag to override PCD values on command line

Hi Mike, A typo error for the word "assignment" in the sentence "PCD value assignmenment from command-line". We can delete one "the" from the sentence "+the the precedence (high to low) to assign a value to a PCD". Besides, should we also add the FDF file's rules in following 8.2.5 chapter ?

Re: [edk2] [edk2-DscSpecification PATCH] Allow nested !include statements

Reviewed-by: Yonghong Zhu Best Regards, Zhu Yonghong -Original Message- From: Kinney, Michael D Sent: Wednesday, April 26, 2017 4:29 AM To: edk2-devel@lists.01.org Cc: Gao, Liming ; Zhu, Yonghong ; Shaw, Kevin W

Re: [edk2] [edk2-FdfSpecification PATCH] Allow nested !include statements

Reviewed-by: Yonghong Zhu Best Regards, Zhu Yonghong -Original Message- From: Kinney, Michael D Sent: Wednesday, April 26, 2017 4:31 AM To: edk2-devel@lists.01.org Cc: Gao, Liming ; Zhu, Yonghong ; Shaw, Kevin W

Re: [edk2] [edk2-UniSpecification PATCH] Clean up Related Information section

Reviewed-by: Yonghong Zhu Best Regards, Zhu Yonghong -Original Message- From: Kinney, Michael D Sent: Wednesday, April 26, 2017 8:33 AM To: edk2-devel@lists.01.org Cc: Carsey, Jaben ; Zhu, Yonghong ; Shaw, Kevin

Re: [edk2] [edk2-UniSpecification PATCH] Allow .uni files on disk to be UTF-8 without a BOM

Reviewed-by: Yonghong Zhu Best Regards, Zhu Yonghong -Original Message- From: Kinney, Michael D Sent: Wednesday, April 26, 2017 9:07 AM To: edk2-devel@lists.01.org Cc: Carsey, Jaben ; Zhu, Yonghong ; Shaw, Kevin

Re: [edk2] [PATCH V2 0/4] Add SmmIoLib

Reviewed-by: Jeff Fan -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Jiewen Yao Sent: Monday, April 24, 2017 10:15 PM To: edk2-devel@lists.01.org Subject: [edk2] [PATCH V2 0/4] Add SmmIoLib V2 Remove

[edk2] [edk2-UniSpecification PATCH] Allow .uni files on disk to be UTF-8 without a BOM

https://bugzilla.tianocore.org/show_bug.cgi?id=507 Cc: Jaben Carsey Cc: Yonghong Zhu Cc: Kevin W Shaw Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Michael Kinney ---

[edk2] [edk2-UniSpecification PATCH] Allow .uni files on disk to be UTF-8 without a BOM

https://bugzilla.tianocore.org/show_bug.cgi?id=507 GitHub branch for review: * https://github.com/mdkinney/edk2-UniSpecification/tree/Bugzilla_507_SupportUtf8Files GitHub word diff view of the patches in this series: * [1/1]

Re: [edk2] [PATCH V2 2/4] MdePkg/SmmIoLib: Add sample instance.

Thanks. But this MemSpaceMap is allocated by DxeCore services. It is UEFI memory instead of SMRAM, I think using gBS->FreePool is more proper. Thank you Yao Jiewen From: Carsey, Jaben Sent: Monday, April 24, 2017 10:59 PM To: Yao, Jiewen ; edk2-devel@lists.01.org Cc: Fan,

[edk2] [edk2-UniSpecification PATCH] Clean up Related Information section

https://bugzilla.tianocore.org/show_bug.cgi?id=506 GitHub branch for review: * https://github.com/mdkinney/edk2-UniSpecification/tree/Bugzilla_506_CleanUpRelatedItems GitHub word diff view of the patches in this series: * [1/1]

[edk2] [edk2-UniSpecification PATCH] Clean up Related Information section

https://bugzilla.tianocore.org/show_bug.cgi?id=506 Cc: Jaben Carsey Cc: Yonghong Zhu Cc: Kevin W Shaw Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Michael Kinney ---

[edk2] [edk2-FdfSpecification PATCH] Allow nested !include statements

https://bugzilla.tianocore.org/show_bug.cgi?id=353 Cc: Liming Gao Cc: Yonghong Zhu Cc: Kevin W Shaw Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Michael Kinney ---

[edk2] [edk2-FdfSpecification PATCH] Allow nested !include statements

https://bugzilla.tianocore.org/show_bug.cgi?id=353 GitHub branch for review: * https://github.com/mdkinney/edk2-FdfSpecification/tree/Bugzilla_353_AllowNestedIncludes GitHub word diff view of the patches in this series: * [1/1]

[edk2] [edk2-DscSpecification PATCH] Allow nested !include statements

https://bugzilla.tianocore.org/show_bug.cgi?id=353 Cc: Liming Gao Cc: Yonghong Zhu Cc: Kevin W Shaw Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Michael Kinney ---

[edk2] [edk2-DscSpecification PATCH] Allow nested !include statements

https://bugzilla.tianocore.org/show_bug.cgi?id=353 GitHub branch for review: * https://github.com/mdkinney/edk2-DscSpecification/tree/Bugzilla_353_AllowNestedIncludes GitHub word diff view of the patches in this series: * [1/1]

Re: [edk2] Unable to boot OVMF on qemu-x86_64

The Ubuntu wiki info isn't quite up to date. We're maintaining updated build instructions on the TianoCore Wiki: https://github.com/tianocore/tianocore.github.io/wiki/Using-EDK-II-with-Native-GCC#Ubuntu_1604_LTS__Ubuntu_1610

[edk2] [ edk2-BuildSpecification PATCH 1/2] Clean up minor formatting issues

Cc: Liming Gao Cc: Yonghong Zhu Cc: Kevin W Shaw Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Michael Kinney --- .../43_pre-build_stage_overview.md | 22

[edk2] [ edk2-BuildSpecification PATCH 2/2] Add --pcd flag to override PCD values on command line

https://bugzilla.tianocore.org/show_bug.cgi?id=480 Cc: Liming Gao Cc: Yonghong Zhu Cc: Kevin W Shaw Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Michael Kinney ---

[edk2] [ edk2-BuildSpecification PATCH 0/2] Add --pcd flag to override PCD values on command line

https://bugzilla.tianocore.org/show_bug.cgi?id=480 GitHub branch for review: * https://github.com/mdkinney/edk2-BuildSpecification/tree/Bugzilla_480_CommandLinePcdOverride GitHub word diff view of the patches in this series: * [1/2]

[edk2] [RFC v3 14/15] OvmfPkg/QemuFwCfgLib: Add SEV support

From: Brijesh Singh When SEV is enabled, use a bounce buffer to perform the DMA operation. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Brijesh Singh --- OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgLib.c | 54

[edk2] [RFC v3 15/15] OvmfPkg/AmdSevDxe: Add AmdSevDxe driver

From: Brijesh Singh When SEV is enabled, the MMIO memory range must be mapped as unencrypted (i.e C-bit cleared). The patch adds a DXE driver that runs early in boot and clears the memory encryption attribute from MMIO and NonExistent memory ranges. By clearing the C-bit

[edk2] [RFC v3 11/15] OvmfPkg/QemuFwCfgLib: Implement SEV internal functions for PEI phase

From: Brijesh Singh The patch implements the SEV specific internal fucntion for PEI phase. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Brijesh Singh --- OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgPeiLib.inf | 1 +

[edk2] [RFC v3 12/15] OvmfPkg/QemuFwCfgLib: Implement SEV internal function for Dxe phase

From: Brijesh Singh When SEV is enabled, the DMA must be performed on unencrypted pages. So when get asked to perfom FWCFG DMA read or write, we allocate a intermediate (bounce buffer) unencrypted buffer and use this buffer for DMA read or write. Contributed-under:

[edk2] [RFC v3 13/15] OvmfPkg/QemuFwCfgLib: Add option to dynamic alloc FW_CFG_DMA Access

From: Brijesh Singh Update InternalQemuFwCfgDmaBytes() to work with DMA Access pointer. The change provides the flexibility to dynamically allocate the "Access" when SEV is enabled. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Brijesh Singh

[edk2] [RFC v3 10/15] OvmfPkg/QemuFwCfgLib: Implement SEV internal function for SEC phase

From: Brijesh Singh Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Brijesh Singh --- OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgSecLib.inf | 1 + OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgSec.c | 57 2

[edk2] [RFC v3 09/15] OvmfPkg/QemuFwCfgLib: Prepare for SEV support

From: Brijesh Singh Add SEV specific internal functions which will be used while intergrating the SEV support into QemuFwCfgLib. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Brijesh Singh ---

[edk2] [RFC v3 02/15] OvmfPkg/ResetVector: Set C-bit when building initial page table

From: Brijesh Singh SEV guest VMs have the concept of private and shared memory. Private memory is encrypted with the guest-specific key, while shared memory may be encrypted with hypervisor key. Certain types of memory (namely instruction pages and guest page tables) are

[edk2] [RFC v3 05/15] OvmfPkg/PlatformPei: Set memory encryption PCD when SEV is enabled

From: Brijesh Singh Secure Encrypted Virtualization (SEV) guest VMs have the concept of private and shared memory. Private memory is encrypted with the guest-specific key, while shared memory may be encrypted with hypervisor key. Certain types of memory (namely

[edk2] [RFC v3 07/15] OvmfPkg/BmDmaLib: Add SEV support

From: Brijesh Singh When SEV is enabled, the DMA operations must be performed on a shared (i.e unencrypted) pages. The patch adds SEV specific hooks to use the bounce buffer when caller map/unmap host address to a DMA address and similarly clears/set memory encryption

[edk2] [RFC v3 08/15] OvmfPkg/QemuFwCfgLib: Provide Pei and Dxe specific library

From: Brijesh Singh Current QemuFwCfgLib.inf is used in both Pei and Dxe phases. Add Pei and Dxe inf file to provide a seperate QemuFwCfg library for Pei and Dxe phase. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Brijesh Singh

[edk2] [RFC v3 04/15] OvmfPkg/BaseMemcryptSevLib: Add SEV helper library

From: Brijesh Singh Add Secure Encrypted Virtualization (SEV) helper library. The library provides the routines to: - set or clear memory encryption bit for a given memory region. - query whether SEV is enabled. Contributed-under: TianoCore Contribution Agreement 1.0

[edk2] [RFC v3 01/15] UefiCpuPkg: Define AMD Memory Encryption specific CPUID and MSR

From: Brijesh Singh The patch defines AMD's Memory Encryption Information CPUID leaf and SEV status MSR. The complete description for CPUID leaf is available in APM volume 2, Section 15.34. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Brijesh

[edk2] [RFC v3 03/15] OvmfPkg: Update dsc to use IoLib from BaseIoLibIntrinsicSev.inf

From: Brijesh Singh When SEV is enabled then we must unroll the rep String I/O instructions. The patch updates dsc file to use SEV version of IoLib inf. The main difference between BaseIoLibIntrinsic.inf and BaseIoLibIntrinsicSev.inf is, SEV version checks if its running

[edk2] [RFC v3 00/15] x86: Secure Encrypted Virtualization (AMD)

From: Brijesh Singh This RFC series provides support for AMD's new Secure Encrypted Virtualization (SEV) feature. SEV is an extension to the AMD-V architecture which supports running multiple VMs under the control of a hypervisor. The SEV feature allows the memory

[edk2] [Patch] CryptoPkg/SmmCryptLib: Enable HMAC-SHA256 support for SMM.

Enable HMAC-SHA256 cipher support in SmmCryptLib instance. Cc: Ting Ye Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Qin Long --- CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf | 4 ++-- 1 file changed, 2 insertions(+), 2

Re: [edk2] [PATCH 2/2] ShellPkg/Shell: eliminate double-free in RunSplitCommand()

Please excuse the mistake, I suppose I was running a search for "FreePool", which of course did not find "SHELL_FREE_NON_NULL". Thanks for fixing it up! Reviewed-by: Marvin Häuser -Ursprüngliche Nachricht- Von: Laszlo Ersek [mailto:ler...@redhat.com]

Re: [edk2] [PATCH 0/2] ShellPkg/Shell: fix double free in pipeline processing

I am good with the series. Good research and description! Reviewed-by: Jaben Carsey > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Tuesday, April 25, 2017 6:57 AM > To: edk2-devel-01 > Cc: Carsey, Jaben

Re: [edk2] [PATCH] UefiCpuPkg/PiSmmCpuDxeSmm: Lock should be acquired

On 04/25/17 02:54, Fan, Jeff wrote: > Laszlo, > > There is no any real issue we encountered. > > Some static code check tool reported AcquireSpinLockOrFai() return value was > not been checked. > Then I found we may ignore some issue if AcquireSpinLockOrFai() return FALSE > (even it will not

[edk2] [PATCH 2/2] ShellPkg/Shell: eliminate double-free in RunSplitCommand()

Commit bd3fc8133b2b ("ShellPkg/App: Fix memory leak and save resources.", 2016-05-20) added a FreePool() call for Split->SplitStdIn, near end of the RunSplitCommand(), right after the same shell file was closed with CloseFile(). The argument was: > 1) RunSplitCommand() allocates the initial

[edk2] [PATCH 0/2] ShellPkg/Shell: fix double free in pipeline processing

The first patch cleans up a bit of mess around the SPLIT_LIST structure. This is unrelated to the actual bug being fixed in the series, it just prepares the grounds. The second patch fixes the bug. Repo: https://github.com/lersek/edk2.git Branch: shell_split Cc: Jaben Carsey

[edk2] [PATCH 1/2] ShellPkg/Shell: clean up bogus member types in SPLIT_LIST

The "SPLIT_LIST.SplitStdOut" and "SPLIT_LIST.SplitStdIn" members currently have type (SHELL_FILE_HANDLE *). This is wrong; SHELL_FILE_HANDLE is already a pointer, there's no need to store a pointer to a pointer. The error is obvious if we check where and how these members are used: - In the

[edk2] [RFC 0/2] PCD: Extended SKU support 2 - sub SKU

- Requirement Simplify the PCDs configuring for multiple SKUs in DSC. - Current limitation There is no sub SKU support for now. The PCD statements for different platform components need to be centralized for different SKUs, and the relationship between different SKUs is hard to build, then it

[edk2] [RFC 1/2] Example: The PCDs configuring for multiple SKUs with current SKU usage

--- Nt32Pkg/Nt32Pkg.dec | 9 Nt32Pkg/Nt32Pkg.dsc | 125 2 files changed, 134 insertions(+) diff --git a/Nt32Pkg/Nt32Pkg.dec b/Nt32Pkg/Nt32Pkg.dec index 06da067bc1d9..7b330359c5d2 100644 --- a/Nt32Pkg/Nt32Pkg.dec +++

[edk2] [RFC 2/2] Example: The PCDs configuring for multiple SKUs with sub SKU support

--- Nt32Pkg/Nt32Pkg.dsc | 116 1 file changed, 16 insertions(+), 100 deletions(-) diff --git a/Nt32Pkg/Nt32Pkg.dsc b/Nt32Pkg/Nt32Pkg.dsc index 573875fe4b95..7b468c18ad7a 100644 --- a/Nt32Pkg/Nt32Pkg.dsc +++ b/Nt32Pkg/Nt32Pkg.dsc @@ -86,16

[edk2] [RFC] PCD: Extended SKU support 1 - inheritance

- Requirement Simplify the PCDs configuring for multiple SKUs in DSC. - Current limitation Non-DEFAULT SKU could only derive from DEFAULT SKU, but could not derive from another non-DEFAULT SKU. For example below, SkuA and SkuB could only derive from DEFAULT, but SkuB could not derive from

Re: [edk2] [PATCH] UefiCpuPkg: Move ProgramVirtualWireMode() to MpInitLib

Reviewed-by: Feng Tian -Original Message- From: Fan, Jeff Sent: Friday, April 21, 2017 1:30 PM To: edk2-devel@lists.01.org Cc: Tian, Feng ; Kinney, Michael D Subject: [PATCH] UefiCpuPkg: Move

Re: [edk2] [PATCH v2] UefiCpuPkg/MpLib.c: Set AP state after X2APIC mode enabled

Reviewed-by: Feng Tian -Original Message- From: Fan, Jeff Sent: Tuesday, April 25, 2017 2:54 PM To: edk2-devel@lists.01.org Cc: Tian, Feng ; Kinney, Michael D Subject: [PATCH v2] UefiCpuPkg/MpLib.c: Set AP state

Re: [edk2] [PATCH] MdeModulePKg/BDS: Build meaningful description for Wi-Fi boot option

Reviewed-by: Wu Jiaxin Thanks, Jiaxin > -Original Message- > From: Ni, Ruiyu > Sent: Thursday, April 20, 2017 11:23 AM > To: edk2-devel@lists.01.org > Cc: Wang, Fan ; Wu, Jiaxin > Subject: [PATCH] MdeModulePKg/BDS: Build

[edk2] [PATCH v2] UefiCpuPkg/MpLib.c: Set AP state after X2APIC mode enabled

After X2APIC mode is enabled, APs need to be set tp IDLE state, otherwise APs cannot be waken up by MP PPI services. https://bugzilla.tianocore.org/show_bug.cgi?id=505 Cc: Feng Tian Cc: Michael Kinney Contributed-under: TianoCore Contribution

[edk2] [PATCH] UefiCpuPkg/MpLib.c: Set AP state after X2APIC mode enabled

After X2APIC mode is enabled, APs need to be set tp IDLE state, otherwise APs cannot be waken up by MP PPI services. https://bugzilla.tianocore.org/show_bug.cgi?id=500 Cc: Feng Tian Cc: Michael Kinney Contributed-under: TianoCore Contribution