[edk2] [Patch 2/2] BaseTools: Clean up tools_def.template for XCODE5

Reorganize the statements for XCODE5 to match other tool chains and remove dependency on XCLANG and XCODE32 Cc: Andrew Fish Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Michael D Kinney --- BaseTools/Conf/tools_def.template | 54

[edk2] [Patch 1/2] BaseTools: Add -D NO_MSABI_VARGS to X64 XCODE5 CC_FLAGS

https://bugzilla.tianocore.org/show_bug.cgi?id=561 Update BaseTools/Conf/tools_def.template to add the define -D NO_MSABI_VAARGS To CC_FLAGS for X64 XCODE5 builds. The llvm/clang compiler used in XCODE5 builds supports the _ms_ versions of the vararg builtins, but the compiler generates build e

[edk2] [Patch 0/2] BaseTools: Fix XCODE5 build breaks for varargs

* Add -D NO_MSABI_VAARGS to X64 XCODE CC_FLAGS * Clean up XCODE5 tool chain statements Cc: Andrew Fish Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Michael D Kinney Michael Kinney (2): BaseTools: Add -D NO_MSABI_VARGS to X64 XCODE5 CC_FLAGS BaseTool

[edk2] [Patch] UefiCpuPkg: Use FINIT instead of hex values

https://bugzilla.tianocore.org/show_bug.cgi?id=560 Update X64 NASM file to match IA32 NASM file and use FINIT instruction instead of hand assembled hex values for the FINIT instruction. Cc: Jeff Fan Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Michael D

[edk2] [Patch] OvmfPkg: Add XCODE5 statements to fix build break

https://bugzilla.tianocore.org/show_bug.cgi?id=559 The XCODE5 tool chain has a FAMILY of GCC. The GCC statements in the [BuildOptions] section add flags that are not compatible with XCODE5. Add empty XCODE5 statements in [BuildOptions] sections to prevent the use of the GCC flags in XCODE5 build

[edk2] [Patch] edk2: Add .DS_Store to .gitignore for macOS

https://bugzilla.tianocore.org/show_bug.cgi?id=558 macOS may generate .DS_Store files in directories. The .gitignore file is updated to ignore these .DS_Store files. Cc: Andrew Fish Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Michael D Kinney --- .git

Re: [edk2] [Patch] MdeModulePkg/LogoDxe: Return error if HII Package not present

Liming, I agree. I have entered a feature request for XCODE5. https://bugzilla.tianocore.org/show_bug.cgi?id=557 Mike > -Original Message- > From: Gao, Liming > Sent: Thursday, May 18, 2017 6:30 PM > To: Kinney, Michael D ; edk2-devel@lists.01.org > Cc: Dong, Eric ; Zeng, Star ; > A

Re: [edk2] [PATCH] MdePkg: Fix undefined behavior on variadic parameters

On Thu, May 18, 2017 at 6:06 AM, Andrew Fish wrote: > Sergei, > > We are hitting this too. > > Our temporary work around was to suppress the warning for the libraries via > our platforms DSC file so we did not need to override things in edk2. > > You can override the library build options if you

Re: [edk2] [PATCH] MdePkg: Fix undefined behavior on variadic parameters

On Thu, May 18, 2017 at 1:19 PM, Laszlo Ersek wrote: > On 05/16/17 14:10, Sergei Temerkhanov wrote: >> On Tue, May 16, 2017 at 8:10 AM, Gao, Liming wrote: >>> Sergey: >>> Could you give more detail on the undefined behavior on variadic >>> parameters? >>> >>> I see https://bugzilla.tianocore

Re: [edk2] [PATCH] Arm: GICv3: Don't access GIC_ICDIPR for interrupts 0..31

On Thu, May 18, 2017 at 7:08 PM, Ard Biesheuvel wrote: > On 16 May 2017 at 03:56, Sergey Temerkhanov wrote: >> These registers are reserved for PPIs and unimplemented on >> some architectures >> > > > What do you mean by 'architectures'? GIC core implementations. > Could you elaborate on which

Re: [edk2] [Patch] MdeModulePkg/LogoDxe: Return error if HII Package not present

Reviewed-by: Star Zeng -Original Message- From: Kinney, Michael D Sent: Friday, May 19, 2017 1:32 AM To: edk2-devel@lists.01.org Cc: Zeng, Star ; Dong, Eric ; Andrew Fish Subject: [Patch] MdeModulePkg/LogoDxe: Return error if HII Package not present https://bugzilla.tianocore.org/show

Re: [edk2] [PATCH] MdeModulePkg PCD: Fix TmpTokenSpaceBufferCount not assigned correctly

Reviewed-by: Liming Gao >-Original Message- >From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Star >Zeng >Sent: Thursday, May 18, 2017 4:41 PM >To: edk2-devel@lists.01.org >Cc: Gao, Liming ; Zeng, Star >Subject: [edk2] [PATCH] MdeModulePkg PCD: Fix >TmpTokenSpaceBuf

Re: [edk2] [PATCH 8/8] Vlv2TbltDevicePkg/FvbRuntimeDxe: correct NumOfLba vararg type in EraseBlocks()

Reviewed-by: zwei4 Thanks, David Wei -Original Message- From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Thursday, May 18, 2017 11:04 PM To: edk2-devel-01 Cc: Wei, David ; Justen, Jordan L ; Guo, Mang Subject: [PATCH 8/8] Vlv2TbltDevicePkg/FvbRu

Re: [edk2] [PATCH] MdePkg: Fix undefined behavior on variadic parameters

Laszlo: Based on your analysis, the parameter type should be changed from BOOLEAN to INT32 to match its promotion type. Right? Thanks Liming >-Original Message- >From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of >Laszlo Ersek >Sent: Thursday, May 18, 2017 6:20 PM >T

Re: [edk2] [Patch] MdeModulePkg/LogoDxe: Return error if HII Package not present

Mike: The code change is good. Reviewed-by: Liming Gao But, I think we still need to figure out the solution to create resource section in XCODE5. Thanks Liming >-Original Message- >From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of >Michael Kinney >Sent: Frid

Re: [edk2] [Patch] UefiCpuPkg/BaseUefiCpuLib: Use NASM read-only data section name

Reviewed-by: Jeff Fan -Original Message- From: Kinney, Michael D Sent: Friday, May 19, 2017 2:44 AM To: edk2-devel@lists.01.org Cc: Fan, Jeff; Andrew Fish Subject: [Patch] UefiCpuPkg/BaseUefiCpuLib: Use NASM read-only data section name https://bugzilla.tianocore.org/show_bug.cgi?id=556

Re: [edk2] [Patch] UefiCpuPkg/PiSmmCpuDxeSmm: Add missing JMP instruction

Reviewed-by: Jeff Fan -Original Message- From: Kinney, Michael D Sent: Friday, May 19, 2017 2:14 AM To: edk2-devel@lists.01.org Cc: Fan, Jeff; Andrew Fish; Laszlo Ersek Subject: [Patch] UefiCpuPkg/PiSmmCpuDxeSmm: Add missing JMP instruction https://bugzilla.tianocore.org/show_bug.cgi?id

Re: [edk2] [PATCH v2 3/5] OvmfPkg/PlatformPei: align EmuVariableNvStore at any page boundary

On 05/18/17 17:14, Laszlo Ersek wrote: > EmuVariableFvbRuntimeDxe now uses a 4KB (EFI_PAGE_SIZE) block size. > > Cc: Jordan Justen > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Laszlo Ersek > Regression-tested-by: Gary Lin > --- > > Notes: > v2: > - no chan

Re: [edk2] [PATCH v2 4/5] OvmfPkg/README: document 4MB flash layout

On 05/18/17 17:14, Laszlo Ersek wrote: > Cc: Jordan Justen > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=527 > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Laszlo Ersek > --- > > Notes: > v2: > - no changes > > OvmfPkg/README | 39 ---

Re: [edk2] [PATCH v2 2/5] OvmfPkg/EmuVariableFvbRuntimeDxe: change block size to 4KB

On 05/18/17 23:09, Laszlo Ersek wrote: > On 05/18/17 22:56, Jordan Justen wrote: >> On 2017-05-18 12:40:30, Laszlo Ersek wrote: >>> On 05/18/17 20:49, Jordan Justen wrote: On 2017-05-18 08:14:33, Laszlo Ersek wrote: > diff --git a/OvmfPkg/EmuVariableFvbRuntimeDxe/Fvb.h > b/OvmfPkg/Emu

Re: [edk2] [PATCH v2 1/5] OvmfPkg/EmuVariableFvbRuntimeDxe: strip trailing whitespace

On 05/18/17 17:14, Laszlo Ersek wrote: > Cc: Jordan Justen > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Laszlo Ersek > Regression-tested-by: Gary Lin > --- > > Notes: > v2: > - no changes > - add Gary's R-t-b > > OvmfPkg/EmuVariableFvbRuntimeDxe/Fvb.h

Re: [edk2] [PATCH 6/8] OvmfPkg/QemuFlashFvbServicesRuntimeDxe: correct NumOfLba vararg type in EraseBlocks()

On 05/18/17 17:04, Laszlo Ersek wrote: > According to the PI spec, Volume 3, > EFI_FIRMWARE_VOLUME_BLOCK2_PROTOCOL.EraseBlocks(): > >> The variable argument list is a list of tuples. Each tuple describes a >> range of LBAs to erase and consists of the following: >> * An EFI_LBA that indicates the

Re: [edk2] [PATCH 5/8] OvmfPkg/EmuVariableFvbRuntimeDxe: correct NumOfLba vararg type in EraseBlocks()

On 05/18/17 17:04, Laszlo Ersek wrote: > According to the PI spec, Volume 3, > EFI_FIRMWARE_VOLUME_BLOCK2_PROTOCOL.EraseBlocks(): > >> The variable argument list is a list of tuples. Each tuple describes a >> range of LBAs to erase and consists of the following: >> * An EFI_LBA that indicates the

Re: [edk2] [PATCH 3/8] EmulatorPkg/FvbServicesRuntimeDxe: correct NumOfLba vararg type in EraseBlocks()

On 05/18/17 17:04, Laszlo Ersek wrote: > According to the PI spec, Volume 3, > EFI_FIRMWARE_VOLUME_BLOCK2_PROTOCOL.EraseBlocks(): > >> The variable argument list is a list of tuples. Each tuple describes a >> range of LBAs to erase and consists of the following: >> * An EFI_LBA that indicates the

Re: [edk2] [PATCH 1/8] ArmPlatformPkg/NorFlashDxe: correct NumOfLba vararg type in EraseBlocks()

On 05/18/17 17:04, Laszlo Ersek wrote: > According to the PI spec, Volume 3, > EFI_FIRMWARE_VOLUME_BLOCK2_PROTOCOL.EraseBlocks(): > >> The variable argument list is a list of tuples. Each tuple describes a >> range of LBAs to erase and consists of the following: >> * An EFI_LBA that indicates the

Re: [edk2] [PATCH] BaseTools/GCC ARM/AARCH64: Force disable PIE

On 18 May 2017 at 22:05, dann frazier wrote: > After Debian's toolchain switched to PIE by default, our edk2 builds began > to fail to build (GCC49 w/ gcc 6.3). This patch fixes the build by forcing > off PIE for both ARM and AARCH64 builds. > > Contributed-under: TianoCore Contribution Agreement

[edk2] [PATCH] BaseTools/GCC ARM/AARCH64: Force disable PIE

After Debian's toolchain switched to PIE by default, our edk2 builds began to fail to build (GCC49 w/ gcc 6.3). This patch fixes the build by forcing off PIE for both ARM and AARCH64 builds. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: dann frazier --- BaseTools/Conf/to

Re: [edk2] [PATCH v2 2/5] OvmfPkg/EmuVariableFvbRuntimeDxe: change block size to 4KB

On 05/18/17 22:56, Jordan Justen wrote: > On 2017-05-18 12:40:30, Laszlo Ersek wrote: >> On 05/18/17 20:49, Jordan Justen wrote: >>> On 2017-05-18 08:14:33, Laszlo Ersek wrote: diff --git a/OvmfPkg/EmuVariableFvbRuntimeDxe/Fvb.h b/OvmfPkg/EmuVariableFvbRuntimeDxe/Fvb.h index 4247d21

Re: [edk2] [PATCH v2 2/5] OvmfPkg/EmuVariableFvbRuntimeDxe: change block size to 4KB

On 2017-05-18 12:40:30, Laszlo Ersek wrote: > On 05/18/17 20:49, Jordan Justen wrote: > > On 2017-05-18 08:14:33, Laszlo Ersek wrote: > >> diff --git a/OvmfPkg/EmuVariableFvbRuntimeDxe/Fvb.h > >> b/OvmfPkg/EmuVariableFvbRuntimeDxe/Fvb.h > >> index 4247d21d72f8..beb11e3f9a90 100644 > >> --- a/OvmfP

Re: [edk2] [PATCH 1/8] ArmPlatformPkg/NorFlashDxe: correct NumOfLba vararg type in EraseBlocks()

On 2017-05-18 12:29:09, Laszlo Ersek wrote: > On 05/18/17 19:21, Jordan Justen wrote: > > On 2017-05-18 08:04:20, Laszlo Ersek wrote: > >> // All blocks must be within range > >> -DEBUG ((DEBUG_BLKIO, "FvbEraseBlocks: Check if: ( StartingLba=%ld + > >> NumOfLba=%d - 1 ) > LastBlock=%ld.\n

Re: [edk2] [PATCH v2 2/5] OvmfPkg/EmuVariableFvbRuntimeDxe: change block size to 4KB

On 05/18/17 20:49, Jordan Justen wrote: > On 2017-05-18 08:14:33, Laszlo Ersek wrote: >> diff --git a/OvmfPkg/EmuVariableFvbRuntimeDxe/Fvb.h >> b/OvmfPkg/EmuVariableFvbRuntimeDxe/Fvb.h >> index 4247d21d72f8..beb11e3f9a90 100644 >> --- a/OvmfPkg/EmuVariableFvbRuntimeDxe/Fvb.h >> +++ b/OvmfPkg/EmuVa

Re: [edk2] [PATCH 1/8] ArmPlatformPkg/NorFlashDxe: correct NumOfLba vararg type in EraseBlocks()

On 05/18/17 19:21, Jordan Justen wrote: > On 2017-05-18 08:04:20, Laszlo Ersek wrote: >> According to the PI spec, Volume 3, >> EFI_FIRMWARE_VOLUME_BLOCK2_PROTOCOL.EraseBlocks(): >> >>> The variable argument list is a list of tuples. Each tuple describes a >>> range of LBAs to erase and consists of

Re: [edk2] [Patch] UefiCpuPkg/PiSmmCpuDxeSmm: Add missing JMP instruction

On 05/18/17 20:14, Michael Kinney wrote: > https://bugzilla.tianocore.org/show_bug.cgi?id=555 > > Add JMP instruction in SmiEntry.S file that is missing. This > updates SmiEntry.S to match the logic in SmiEntry.asm and > SmiEntry.nasm. > > The default BUILDRULEORDER has .nasm higher priority tha

Re: [edk2] [PATCH v2 2/5] OvmfPkg/EmuVariableFvbRuntimeDxe: change block size to 4KB

On 2017-05-18 08:14:33, Laszlo Ersek wrote: > diff --git a/OvmfPkg/EmuVariableFvbRuntimeDxe/Fvb.h > b/OvmfPkg/EmuVariableFvbRuntimeDxe/Fvb.h > index 4247d21d72f8..beb11e3f9a90 100644 > --- a/OvmfPkg/EmuVariableFvbRuntimeDxe/Fvb.h > +++ b/OvmfPkg/EmuVariableFvbRuntimeDxe/Fvb.h > @@ -58,8 +58,14 @@

[edk2] [Patch] UefiCpuPkg/BaseUefiCpuLib: Use NASM read-only data section name

https://bugzilla.tianocore.org/show_bug.cgi?id=556 NASM requires read-only data sections to use the section name .rodata. This fix changes .rdata to .rodata. The build failure from use of .rdata is seen when using the XCODE5 tool chain. Section "7.8.1 macho extensions to the SECTION Directive"

Re: [edk2] SMBios configuration table not present until late stage of boot

On 05/18/17 17:28, Tomas Pilar (tpilar) wrote: > This is what I was afraid of. I am writing an IHV network driver that > lives in optionROM. Out of curiosity, if you can share it, what do you need the sytem UUID in a network driver for? Thank you, Laszlo > > Cheers, > Tom > > On 18/05/17 16:25

[edk2] [Patch] UefiCpuPkg/PiSmmCpuDxeSmm: Add missing JMP instruction

https://bugzilla.tianocore.org/show_bug.cgi?id=555 Add JMP instruction in SmiEntry.S file that is missing. This updates SmiEntry.S to match the logic in SmiEntry.asm and SmiEntry.nasm. The default BUILDRULEORDER has .nasm higher priority than .asm or .S, so this issue was not seen with MSFT or G

[edk2] [Patch] MdeModulePkg/LogoDxe: Return error if HII Package not present

https://bugzilla.tianocore.org/show_bug.cgi?id=554 Update LogoDxe module to exit with an error instead of ASSERT_EFI_ERROR() if the HII Package with the logo image is not present. If a tool chain does not support generation of PE/COFF resource sections, then this module can not produce the logo f

Re: [edk2] [Patch] PcAtChipsetPkg/SerialIoLib: Remove negative value shift

On 05/18/17 19:03, Michael Kinney wrote: > https://bugzilla.tianocore.org/show_bug.cgi?id=553 > > Remove left shift of negative values that always evaluate > to 0 to address build errors from the llvm/clang compiler > used in the XCODE5 tool chain. > > Cc: Ruiyu Ni > Cc: Andrew Fish > Cc: Laszl

Re: [edk2] SMBios configuration table not present until late stage of boot

> On May 18, 2017, at 8:28 AM, Tomas Pilar (tpilar) > wrote: > > This is what I was afraid of. I am writing an IHV network driver that lives > in optionROM. > Tomas, I think this issue is fixed in the current Specs and edk2 code. The PI Spec defines an Protocol, gEfiSmbiosProtocolGuid, fo

Re: [edk2] [PATCH 1/8] ArmPlatformPkg/NorFlashDxe: correct NumOfLba vararg type in EraseBlocks()

On 2017-05-18 08:04:20, Laszlo Ersek wrote: > According to the PI spec, Volume 3, > EFI_FIRMWARE_VOLUME_BLOCK2_PROTOCOL.EraseBlocks(): > > > The variable argument list is a list of tuples. Each tuple describes a > > range of LBAs to erase and consists of the following: > > * An EFI_LBA that indica

[edk2] [Patch] PcAtChipsetPkg/SerialIoLib: Remove negative value shift

https://bugzilla.tianocore.org/show_bug.cgi?id=553 Remove left shift of negative values that always evaluate to 0 to address build errors from the llvm/clang compiler used in the XCODE5 tool chain. Cc: Ruiyu Ni Cc: Andrew Fish Cc: Laszlo Ersek Contributed-under: TianoCore Contribution Agreemen

Re: [edk2] [PATCH] Arm: GICv3: Don't access GIC_ICDIPR for interrupts 0..31

On 16 May 2017 at 03:56, Sergey Temerkhanov wrote: > These registers are reserved for PPIs and unimplemented on > some architectures > What do you mean by 'architectures'? Could you elaborate on which SoC needs this? > Signed-off-by: Sergey Temerkhanov > --- > ArmPkg/Drivers/ArmGic/GicV3/ArmG

Re: [edk2] Convention for creating dynamic HII forms

On 2017-05-11 00:53, Dong, Eric wrote: Hi Dev, I add my comments below. Thanks, Eric -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of dgur...@codeaurora.org Sent: Thursday, May 11, 2017 4:39 AM To: edk2-devel@lists.01.org Subject: [edk2] Convent

Re: [edk2] SMBios configuration table not present until late stage of boot

This is what I was afraid of. I am writing an IHV network driver that lives in optionROM. Cheers, Tom On 18/05/17 16:25, jim.dai...@dell.com wrote: It is a tricky problem. What I would like is for a new protocol to be defined, which should not rely on devices, to contain certain identifying i

Re: [edk2] SMBios configuration table not present until late stage of boot

It is a tricky problem. What I would like is for a new protocol to be defined, which should not rely on devices, to contain certain identifying information like this that would be useful to device drivers. It could be created early in DXE. What I fear is some future requirement that SMBIOS be mad

[edk2] [PATCH v2 5/5] OvmfPkg: make the 4MB flash size the default (again)

The previously default 2MB can be explicitly selected with -D FD_SIZE_2MB or -D FD_SIZE_IN_KB=2048 Cc: Jordan Justen Suggested-by: Jordan Justen Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek (cherry picked from commit bba8dfbec3bbc4fba7fa6398ba3cf765

[edk2] [PATCH v2 4/5] OvmfPkg/README: document 4MB flash layout

Cc: Jordan Justen Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=527 Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek --- Notes: v2: - no changes OvmfPkg/README | 39 1 file changed, 31 insertions(+), 8 deletions(-) diff --g

[edk2] [PATCH v2 3/5] OvmfPkg/PlatformPei: align EmuVariableNvStore at any page boundary

EmuVariableFvbRuntimeDxe now uses a 4KB (EFI_PAGE_SIZE) block size. Cc: Jordan Justen Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek Regression-tested-by: Gary Lin --- Notes: v2: - no changes - add Gary's R-t-b OvmfPkg/PlatformPei/Platform.c |

[edk2] [PATCH v2 2/5] OvmfPkg/EmuVariableFvbRuntimeDxe: change block size to 4KB

EmuVariableFvbRuntimeDxe currently produces a Firmware Volume Block protocol that is based on a block map of two blocks, each block having PcdFlashNvStorageFtwSpareSize for size. (The total size is 2 * PcdFlashNvStorageFtwSpareSize.) FaultTolerantWriteDxe in turn expects the block size to be a po

[edk2] [PATCH v2 0/5] OvmfPkg: complete the 4MB flash image support ("-bios" / emulated variables)

Version 2 of the series at . Changes are listed per patch. Repo: https://github.com/lersek/edk2.git Branch: emu4k_v2 Note that this series depends on patch #5 in the series [edk2] [PATCH 0/8] several Pkgs: FVB driver: correct N

[edk2] [PATCH v2 1/5] OvmfPkg/EmuVariableFvbRuntimeDxe: strip trailing whitespace

Cc: Jordan Justen Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek Regression-tested-by: Gary Lin --- Notes: v2: - no changes - add Gary's R-t-b OvmfPkg/EmuVariableFvbRuntimeDxe/Fvb.h | 16 +++ OvmfPkg/EmuVariableFvbRuntimeDxe/Fvb.c | 44

Re: [edk2] SMBios configuration table not present until late stage of boot

This does make sense. Do you have a suggestion how I would go about finding/creating a unique identifier for the system during preboot? Cheers, Tom On 18/05/17 16:11, jim.dai...@dell.com wrote: Not a helpful comment, but I wanted to air my feelings on the topic: I view SMBIOS as data strictly

Re: [edk2] [PATCH 1/8] ArmPlatformPkg/NorFlashDxe: correct NumOfLba vararg type in EraseBlocks()

On 18 May 2017 at 16:04, Laszlo Ersek wrote: > According to the PI spec, Volume 3, > EFI_FIRMWARE_VOLUME_BLOCK2_PROTOCOL.EraseBlocks(): > >> The variable argument list is a list of tuples. Each tuple describes a >> range of LBAs to erase and consists of the following: >> * An EFI_LBA that indicate

Re: [edk2] SMBios configuration table not present until late stage of boot

Not a helpful comment, but I wanted to air my feelings on the topic: I view SMBIOS as data strictly for OS-level consumption and not for any pre-boot code. I'm sure I'm in the minority, however. One of the problems is that the BIOS needs to have scanned all devices/resources and perhaps executed

[edk2] [PATCH 8/8] Vlv2TbltDevicePkg/FvbRuntimeDxe: correct NumOfLba vararg type in EraseBlocks()

According to the PI spec, Volume 3, EFI_FIRMWARE_VOLUME_BLOCK2_PROTOCOL.EraseBlocks(): > The variable argument list is a list of tuples. Each tuple describes a > range of LBAs to erase and consists of the following: > * An EFI_LBA that indicates the starting LBA > * A UINTN that indicates the numb

[edk2] [PATCH 6/8] OvmfPkg/QemuFlashFvbServicesRuntimeDxe: correct NumOfLba vararg type in EraseBlocks()

According to the PI spec, Volume 3, EFI_FIRMWARE_VOLUME_BLOCK2_PROTOCOL.EraseBlocks(): > The variable argument list is a list of tuples. Each tuple describes a > range of LBAs to erase and consists of the following: > * An EFI_LBA that indicates the starting LBA > * A UINTN that indicates the numb

[edk2] [PATCH 7/8] QuarkPlatformPkg/SpiFvbServices: correct NumOfLba vararg type in EraseBlocks()

According to the PI spec, Volume 3, EFI_FIRMWARE_VOLUME_BLOCK2_PROTOCOL.EraseBlocks(): > The variable argument list is a list of tuples. Each tuple describes a > range of LBAs to erase and consists of the following: > * An EFI_LBA that indicates the starting LBA > * A UINTN that indicates the numb

[edk2] [PATCH 1/8] ArmPlatformPkg/NorFlashDxe: correct NumOfLba vararg type in EraseBlocks()

According to the PI spec, Volume 3, EFI_FIRMWARE_VOLUME_BLOCK2_PROTOCOL.EraseBlocks(): > The variable argument list is a list of tuples. Each tuple describes a > range of LBAs to erase and consists of the following: > * An EFI_LBA that indicates the starting LBA > * A UINTN that indicates the numb

[edk2] [PATCH 5/8] OvmfPkg/EmuVariableFvbRuntimeDxe: correct NumOfLba vararg type in EraseBlocks()

According to the PI spec, Volume 3, EFI_FIRMWARE_VOLUME_BLOCK2_PROTOCOL.EraseBlocks(): > The variable argument list is a list of tuples. Each tuple describes a > range of LBAs to erase and consists of the following: > * An EFI_LBA that indicates the starting LBA > * A UINTN that indicates the numb

[edk2] [PATCH 3/8] EmulatorPkg/FvbServicesRuntimeDxe: correct NumOfLba vararg type in EraseBlocks()

According to the PI spec, Volume 3, EFI_FIRMWARE_VOLUME_BLOCK2_PROTOCOL.EraseBlocks(): > The variable argument list is a list of tuples. Each tuple describes a > range of LBAs to erase and consists of the following: > * An EFI_LBA that indicates the starting LBA > * A UINTN that indicates the numb

[edk2] [PATCH 4/8] Nt32Pkg/FvbServicesRuntimeDxe: correct NumOfLba vararg type in EraseBlocks()

According to the PI spec, Volume 3, EFI_FIRMWARE_VOLUME_BLOCK2_PROTOCOL.EraseBlocks(): > The variable argument list is a list of tuples. Each tuple describes a > range of LBAs to erase and consists of the following: > * An EFI_LBA that indicates the starting LBA > * A UINTN that indicates the numb

[edk2] [PATCH 2/8] DuetPkg/FvbRuntimeService: correct NumOfLba vararg type in EraseBlocks()

According to the PI spec, Volume 3, EFI_FIRMWARE_VOLUME_BLOCK2_PROTOCOL.EraseBlocks(): > The variable argument list is a list of tuples. Each tuple describes a > range of LBAs to erase and consists of the following: > * An EFI_LBA that indicates the starting LBA > * A UINTN that indicates the numb

[edk2] [PATCH 0/8] several Pkgs: FVB driver: correct NumOfLba vararg type in EraseBlocks()

The same fix is replicated for every FVB driver. Details are in the individual (mostly identical) commit messages. Repo: https://github.com/lersek/edk2.git Branch: num_of_lba_uintn Cc: Andrew Fish Cc: Ard Biesheuvel Cc: David Wei Cc: Jordan Justen Cc: Kelly Steele Cc: Leif Lindholm Cc: Ma

[edk2] SMBios configuration table not present until late stage of boot

Hi, I am trying to read the system UUID from the System Table (Type 1) in the SMBios set of tables. I am doing this during DriverBinding.Start() part of the UEFI_DRIVER initialisation. Unfortunately the gST->ConfigurationTable only contains 6 tables and SMBios is not one of them. Once I boo

Re: [edk2] [PATCH 0/5] OvmfPkg: complete the 4MB flash image support ("-bios" / emulated variables)

On 05/16/17 06:20, Gary Lin wrote: > On Mon, May 15, 2017 at 05:40:59PM -0700, Jordan Justen wrote: >> On 2017-05-12 01:40:34, Laszlo Ersek wrote: >>> On 05/12/17 04:02, Gary Lin wrote: On Mon, May 08, 2017 at 12:27:59PM +0800, Gary Lin wrote: > On Sat, May 06, 2017 at 09:30:18PM +0200, La

Re: [edk2] How to look up ACPI device node from DXE driver

Thanks Laszlo! EFI_ACPI_SDT_PROTOCOL is indeed helpful. 2017-05-18 13:59 GMT+03:00 Laszlo Ersek : > On 05/16/17 14:55, Evgeny Yakovlev wrote: > > I am writing a DXE driver for a paravirtualized HyperV storage device for > > OvmfPkg. Host hypervisor exposes the presence of this device through ACPI

Re: [edk2] How to look up ACPI device node from DXE driver

On 05/16/17 14:55, Evgeny Yakovlev wrote: > I am writing a DXE driver for a paravirtualized HyperV storage device for > OvmfPkg. Host hypervisor exposes the presence of this device through ACPI > device node in DSDT. Specific AML path itself may be different from host to > host but device UID is al

Re: [edk2] [PATCH] MdePkg: Fix undefined behavior on variadic parameters

On 05/16/17 14:10, Sergei Temerkhanov wrote: > On Tue, May 16, 2017 at 8:10 AM, Gao, Liming wrote: >> Sergey: >> Could you give more detail on the undefined behavior on variadic >> parameters? >> >> I see https://bugzilla.tianocore.org/show_bug.cgi?id=410 describe this >> issues found in the

Re: [edk2] UEFI_DRIVER dependencies

On 05/18/17 08:25, Michael Zimmermann wrote: > Andrew, doesn't that only address the case where an UEFI_DRIVER has > dependencies on certain dxe drivers?(which, as you said will always be > available). > It's still unclear to me how an UEFI_DRIVER can depend on another > UEFI_DRIVER this way withou

Re: [edk2] [RFC v4 06/13] OvmfPkg:AmdSevDxe: add AmdSevDxe driver

On 05/16/17 22:25, Brijesh Singh wrote: > > > On 05/16/2017 12:56 PM, Jordan Justen wrote: >> On 2017-05-16 05:04:58, Brijesh Singh wrote: >>> Hi Jordan, >>> >>> On 5/15/17 12:47 PM, Jordan Justen wrote: On 2017-05-11 11:01:57, Brijesh Singh wrote: > > We basically need some kind of

[edk2] [PATCH] MdeModulePkg PCD: Fix TmpTokenSpaceBufferCount not assigned correctly

When DynamicEx PCD is only used in PEI code, but not DXE code, current implementation of DxePcdGetNextTokenSpace does not assign TmpTokenSpaceBufferCount correctly, but leaves it as initial value, then DxePcdGetNextTokenSpace may return incorrect token space guid and status. This patch is to fix t

Re: [edk2] [PATCH V5 0/3] Add IOMMU support.

Thank you Ard. You are right. We also notice that and submitted a new patch in the morning – “[patch] MdeModulePkg/PciHostBridgeDxe: Fix EBC build failure” Thank you Yao Jiewen From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] Sent: Thursday, May 18, 2017 4:38 PM To: Duran, Leo ; Yao, Jie

Re: [edk2] [PATCH V5 0/3] Add IOMMU support.

On 13 May 2017 at 20:27, Duran, Leo wrote: > Reviewed-by: Leo Duran > > Thanks, > Leo. > These patches are breaking the build for me under Clang. Apologies for not spotting that at review time.

Re: [edk2] [PATCH 5/7] OvmfPkg/PlatformPei: don't allocate reserved mem varstore if SMM_REQUIRE

On 05/15/17 20:09, Jordan Justen wrote: > On 2017-05-05 14:02:56, Laszlo Ersek wrote: >> For the emulated variable store, PlatformPei allocates reserved memory (as >> early as possible, so that the address remains the same during reboot), >> and PcdEmuVariableNvStoreReserved carries the address to