[edk2] [edk2-BuildSpecification PATCH V2] Add EBNF for --pcd flag command line flag

2017-05-27 Thread Michael Kinney
https://bugzilla.tianocore.org/show_bug.cgi?id=523 Cc: Liming Gao Cc: Yonghong Zhu Cc: Kevin W Shaw Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Michael Kinney --- README.md | 3 ++- appendix_d_buildexe_command/d4_usage.md | 32

[edk2] [edk2-BuildSpecification PATCH V2] Add EBNF for --pcd flag command line flag

2017-05-27 Thread Michael Kinney
Changes in V2 * Section D.4.3 - Change INC to INF * Support both hexidecimal and decimal PCD values on command line * Support both 0x and 0X prefix for hexidecimal PCD values * Add missing EBNF defintion https://bugzilla.tianocore.org/show_bug.cgi?id=523 GitHub branch for review: * https://git

[edk2] [edk2-DscSpecification PATCH] Allow mixed PCD access methods

2017-05-27 Thread Michael Kinney
https://bugzilla.tianocore.org/show_bug.cgi?id=521 GitHub branch for review: * https://github.com/mdkinney/edk2-DscSpecification/tree/Bugzilla_521_AllowMixedPcdAccessTypes GitHub word diff view of the patches in this series: * [1/1] https://github.com/mdkinney/edk2-DscSpecification/commit/fa5

[edk2] [edk2-DscSpecification PATCH] Allow mixed PCD access methods

2017-05-27 Thread Michael Kinney
https://bugzilla.tianocore.org/show_bug.cgi?id=521 Cc: Liming Gao Cc: Yonghong Zhu Cc: Kevin W Shaw Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Michael Kinney --- 2_dsc_overview/28_pcd_section_processing.md | 12 ++-- 3_edk_ii_dsc_file_format/310_pcd_sectio

[edk2] [edk2-DscSpecification PATCH] Update Precedence of PCD Values

2017-05-27 Thread Michael Kinney
https://bugzilla.tianocore.org/show_bug.cgi?id=519 Cc: Liming Gao Cc: Yonghong Zhu Cc: Kevin W Shaw Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Michael Kinney --- 2_dsc_overview/28_pcd_section_processing.md | 56 ++--- README.md

[edk2] [edk2-DscSpecification PATCH] Update Precedence of PCD Values

2017-05-27 Thread Michael Kinney
https://bugzilla.tianocore.org/show_bug.cgi?id=519 GitHub branch for review: * https://github.com/mdkinney/edk2-DscSpecification/tree/Bugzilla_519_UpdatePrecedenceOfPcdValues GitHub word diff view of the patches in this series: * [1/1] https://github.com/mdkinney/edk2-DscSpecification/commit/

[edk2] [edk2-FdfSpecification PATCH] Update Precedence of PCD Values

2017-05-27 Thread Michael Kinney
https://bugzilla.tianocore.org/show_bug.cgi?id=520 Cc: Liming Gao Cc: Yonghong Zhu Cc: Kevin W Shaw Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Michael Kinney --- 2_fdf_design_discussion/21_processing_overview.md | 26 +++ README.md

[edk2] [edk2-FdfSpecification PATCH] Update Precedence of PCD Values

2017-05-27 Thread Michael Kinney
https://bugzilla.tianocore.org/show_bug.cgi?id=520 GitHub branch for review: * https://github.com/mdkinney/edk2-FdfSpecification/tree/Bugzilla_520_UpdatePrecedenceOfPcdValues GitHub word diff view of the patches in this series: * [1/1] https://github.com/mdkinney/edk2-FdfSpecification/commit/

Re: [edk2] [Patch] SourceLevelDebugPkg/SecPeiDebugAgentLib: Fix duplicate symbol

2017-05-27 Thread Ard Biesheuvel
On 26 May 2017 at 23:06, Kinney, Michael D wrote: > Felix, > > Yes. I agree. I will work on a Bugzilla issue for this topic > and I prefer the idea of updating Base.h to check _MSC_VER value. > > The one challenge is that 'static' could be added in front of > GLOBAL_REMOVE_IF_UNREFERENCED, and i

Re: [edk2] [PATCH] BaseTools/Scripts: discard .gnu.hash section in GCC builds

2017-05-27 Thread Gao, Liming
Ard: I just run BaseTools\Scripts\PatchCheck.py to check the latest patches. It reports one issue in this patch. Could you fix it? The commit message format passed all checks. Code format is not valid: * Line ending ('\n') is not CRLF File: BaseTools/Scripts/GccBase.lds Line: *(.hash

[edk2] [RFC V2 1/5] BaseTool/VfrCompiler: Support Bit fields in EFI/Buffer VarStore

2017-05-27 Thread Dandan Bi
Enhance VfrCompiler to parse following case: 1. EFI/Buffer VarStore can contain bit fields in their structure. 2. For question Oneof/Checkbox/numeric, their storage can be bit fields of an EFI VarStore/Buffer VarStore. Cc: Eric Dong Cc: Liming Gao Contributed-under: TianoCore Contribution Agr

[edk2] [RFC V2 2/5] MdeModulePkg: Add guid/flags to implement BitFiled support

2017-05-27 Thread Dandan Bi
Cc: Eric Dong Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi --- MdeModulePkg/Include/Guid/MdeModuleHii.h | 19 ++- MdeModulePkg/MdeModulePkg.dec| 4 2 files changed, 22 insertions(+), 1 deletion(-) diff --git a

[edk2] [RFC V2 3/5] MdeModulePkg/SetupBrowser: Handle questions with Bit VarStore

2017-05-27 Thread Dandan Bi
For oneof/numeric/CheckBox(storage can be Bit VarStore) If we want question value can be updated and shown correctly in UI page, we need do enhancements in following cases: 1. Parse the Ifr data to get the bit VarStore info correctly. 2. Set/get value to/from bit VarStore correctly. Cc: Eric Dong

[edk2] [RFC V2 5/5] MdeModulePkg/DriverSample: Add sample questions with bit VarStore

2017-05-27 Thread Dandan Bi
1.Construct EFI/Buffer VarStore with: (a) bit fields (b) nested structure( the nested structure contains bit fields). 2.Construct oneof/numeric/check to refer the bit fields of the EFI VarStore. Cc: Eric Dong Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: D

[edk2] [RFC V2 4/5] MdeModulePkg/HiiDatabase: Handle questions with Bit VarStore

2017-05-27 Thread Dandan Bi
For oneof/numeric/checkbox, their storage may be bit field. When generating string to get default value for these questions, we need to parse the Ifr data to get the bit Varstore info,and then generating the correct string. Cc: Eric Dong Cc: Liming Gao Contributed-under: TianoCore Contribution

[edk2] [RFC V2 0/5] Support Bit fields in EFI/Buffer VarStore

2017-05-27 Thread Dandan Bi
V2: Not only support bit filed for EFI variable storage but also for buffer storage. And add sample questions to refer bit filed in buffer storage. Did some code/logic refining work. Proposal: In VFR file, the storage of some Question may use Bit field in an EFI VarStore. So we propose t

Re: [edk2] [edk2-BuildSpecification PATCH] Add EBNF for --pcd flag command line flag

2017-05-27 Thread Zhu, Yonghong
Hi Mike, Some comment, please check it. thanks. 1. How about change the PcdValue as below since we also support the integer value. ::= {} {} {} {} ::= {} {} ::= {(0-9)} {(1-9)(0-9)+} 2. How about change HexNumber to support the upper case "0X" ? ::= {"0x"} {