Re: [edk2] [patch] MdeModulePkg/MnpDxe: Fix EBC build hang issue

Reviewed-by: Fu Siyuan -Original Message- From: Bi, Dandan Sent: 2017年6月2日 13:05 To: edk2-devel@lists.01.org Cc: Fu, Siyuan Subject: [patch] MdeModulePkg/MnpDxe: Fix EBC build hang issue Cc: Fu Siyuan Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi

[edk2] [patch] MdeModulePkg/MnpDxe: Fix EBC build hang issue

Cc: Fu Siyuan Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi --- MdeModulePkg/Universal/Network/MnpDxe/MnpConfig.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/MdeModulePkg/Universal/Network/MnpDxe/MnpConfig.c b/MdeModulePkg/Universal

Re: [edk2] [PATCH] ShellPkg/alias: Fix bug to support upper-case alias

Jaben, Old code also honors the returning status when delete an alias. Please check the line I marked as "<--" in below. // // We must be trying to remove one if Alias is NULL // if (Alias == NULL) { // // remove an alias (but passed in COMMAND parameter) // Status

[edk2] [PATCH 2/2] EmulatorPkg/build.sh: Merge GCC toolchain detection from OVMF

Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jordan Justen Cc: Laszlo Ersek --- EmulatorPkg/build.sh | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/EmulatorPkg/build.sh b/EmulatorPkg/build.sh index 7f74391120..a196c3e9f3 100755 --- a/Emu

[edk2] [PATCH 1/2] EmulatorPkg/Unix/Host: Add GCC5 CC/DLINK commands (for GCC >= 5)

Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jordan Justen Cc: Laszlo Ersek Cc: Ard Biesheuvel --- EmulatorPkg/Unix/Host/Host.inf | 2 ++ 1 file changed, 2 insertions(+) diff --git a/EmulatorPkg/Unix/Host/Host.inf b/EmulatorPkg/Unix/Host/Host.inf index d83857a1fd..339

Re: [edk2] [RFC PATCH] OvmfPkg/AcpiPlatformDxe: lift 4 GB alloc limit for modern ACPI systems

On 06/01/17 14:25, Laszlo Ersek wrote: > In QEMU, we could tie both of these extensions to new machine types. > > The result would be: > > firmware QEMU QEMU machine type result > - --- > old new old

Re: [edk2] Problem in EFI_BOOT_SERVICES.OpenProtocol()

> On Jun 1, 2017, at 10:40 AM, Amit kumar wrote: > > Certainly i will do that. > Meanwhile can i submit the patch too ? Yes as long as you follow the process. Thanks, Andrew Fish > Amit > From: af...@apple.com > on behalf of Andrew Fish

Re: [edk2] Problem in EFI_BOOT_SERVICES.OpenProtocol()

Certainly i will do that. Meanwhile can i submit the patch too ? Amit From: af...@apple.com on behalf of Andrew Fish Sent: Thursday, June 1, 2017 11:08:59 PM To: Amit kumar Cc: edk2-devel@lists.01.org Subject: Re: [edk2] Problem in EFI_BOOT_SERVICES.OpenProtoc

Re: [edk2] Problem in EFI_BOOT_SERVICES.OpenProtocol()

> On Jun 1, 2017, at 10:37 AM, Amit kumar wrote: > > Hello Andrew, > > Thanks for quick reply and acknowledging my query. > Please file a bugzilla against the code. Thanks, Andrew Fish > Amit > From: af...@apple.com > on behalf of Andre

Re: [edk2] Problem in EFI_BOOT_SERVICES.OpenProtocol()

Hello Andrew, Thanks for quick reply and acknowledging my query. Amit From: af...@apple.com on behalf of Andrew Fish Sent: Thursday, June 1, 2017 10:59:03 PM To: Amit kumar Cc: edk2-devel@lists.01.org Subject: Re: [edk2] Problem in EFI_BOOT_SERVICES.OpenProt

Re: [edk2] Problem in EFI_BOOT_SERVICES.OpenProtocol()

> On Jun 1, 2017, at 10:13 AM, Amit kumar wrote: > > Hello Andrew, > > As per UEFI Spec EFI_ALREADY_STARTED is treated as error code, thus PciIo > (The Interface 3rd parameter ) should remain NULL. > But afterOpenProtocol call even though Status = EFI_ALREADY_STARTED PciIo > (The Interfac

Re: [edk2] Problem in EFI_BOOT_SERVICES.OpenProtocol()

Hello Andrew, As per UEFI Spec EFI_ALREADY_STARTED is treated as error code, thus PciIo (The Interface 3rd parameter ) should remain NULL. But afterOpenProtocol call even though Status = EFI_ALREADY_STARTED PciIo (The Interface 3rd parameter ) is getting modified and it not NULL anymore. Is

Re: [edk2] Problem in EFI_BOOT_SERVICES.OpenProtocol()

> On Jun 1, 2017, at 9:46 AM, Amit kumar wrote: > > Hi, > I am trying to open PciIoProtocol and facing some issue. > > below is the code > > EFI_PCI_IO_PROTOCOL *PciIo=NULL; > EFI_STATUS Status; > > Status = gBS->OpenProtocol ( > Controller, >

Re: [edk2] [RFC] migration of OpenPlatformPkg to tianocore

Hi Leif, For directory name convention, I do recommend if a directory contains a package DEC file, then the directory should end in "Pkg". I would not recommend a change to the behavior of PACKAGES_PATH at this time. Let's attempt to work through the detailed proposal with current PACKAGES_PATH b

[edk2] Problem in EFI_BOOT_SERVICES.OpenProtocol()

Hi, I am trying to open PciIoProtocol and facing some issue. below is the code EFI_PCI_IO_PROTOCOL *PciIo=NULL; EFI_STATUS Status; Status = gBS->OpenProtocol ( Controller, &gEfiPciIoProtocolGuid, (VOID **) &PciIo,

Re: [edk2] [RFC PATCH] OvmfPkg/AcpiPlatformDxe: lift 4 GB alloc limit for modern ACPI systems

On 06/01/17 17:16, Igor Mammedov wrote: > On Thu, 1 Jun 2017 14:25:48 +0200 > Laszlo Ersek wrote: > >> On 06/01/17 13:22, Ard Biesheuvel wrote: >>> ACPI supports architectures such as arm64, which did not exist when the >>> original 32-bit ACPI 1.0 was introduced. These days, ACPI tables can all

Re: [edk2] [PATCH] ShellPkg/alias: Fix bug to support upper-case alias

I think we have to leave the behavior the same. The spec says this: " If the environment variable does not exist and the Value is an empty string, there is no action." I do not think we can change that to an error return without a spec change. -Jaben > -Original Message- > From: Carse

Re: [edk2] [PATCH] ShellPkg/alias: Fix bug to support upper-case alias

I just think we may want to have the behavior act the same as it does today for delete. > -Original Message- > From: Ni, Ruiyu > Sent: Thursday, June 01, 2017 8:19 AM > To: Carsey, Jaben ; edk2-devel@lists.01.org > Cc: Kinney, Michael D ; Shah, Tapan > (tapands...@hpe.com) > Subject: RE:

Re: [edk2] [PATCH v6 00/17] x86: Secure Encrypted Virtualization (AMD)

> On Jun 1, 2017, at 8:01 AM, Brijesh Singh wrote: > > Hi Andrew, > > The goal is to clear the "C" bit in PTE for all the MMIO areas in the GCD > memory > space map. I think Leo looked at SetMemoryAttributes() based on Mike's > feedback, > but I believe SetMemoryAttribute may get called on an

Re: [edk2] [RFC] migration of OpenPlatformPkg to tianocore

Hi Jiewen, Apologies for ridicilously slow response - I caught a bad cold and am only now getting back on track with this. Many thanks for having a look, and your comments. On Fri, May 05, 2017 at 02:03:43PM +, Yao, Jiewen wrote: > Some comments for the build failure. > > I think we might h

Re: [edk2] [PATCH] ShellPkg/alias: Fix bug to support upper-case alias

I was using AliasLower. I am not sure whether the change is smallest. But I tried best to make the new implementation cleaner. I think that's what we really need. Did you see any issue if we return EFI_NOT_FOUND (when variable doesn't exist)? Regards, Ray >-Original Message- >From: Cars

Re: [edk2] [RFC PATCH] OvmfPkg/AcpiPlatformDxe: lift 4 GB alloc limit for modern ACPI systems

On Thu, 1 Jun 2017 14:25:48 +0200 Laszlo Ersek wrote: > On 06/01/17 13:22, Ard Biesheuvel wrote: > > ACPI supports architectures such as arm64, which did not exist when the > > original 32-bit ACPI 1.0 was introduced. These days, ACPI tables can all > > support 64-bit memory addresses, and so QEM

Re: [edk2] [PATCH v6 00/17] x86: Secure Encrypted Virtualization (AMD)

Hi Andrew, The goal is to clear the "C" bit in PTE for all the MMIO areas in the GCD memory space map. I think Leo looked at SetMemoryAttributes() based on Mike's feedback, but I believe SetMemoryAttribute may get called on any range without specifying types (we are interested in MMIO ranges, whi

Re: [edk2] [PATCH] ShellPkg/alias: Fix bug to support upper-case alias

Why not just use the AliasLower and make the overall change much smaller? Looks like the old version did the conversion, but didn't use the result. Also, I notice that we are now checking the return value upon delete, which was explicitly not done in the old version. There was this comment bef

Re: [edk2] [PATCH v6 00/17] x86: Secure Encrypted Virtualization (AMD)

On 06/01/17 15:48, Andrew Fish wrote: > Laszlo, > > The current design is DXE IPL and gEfiCpuArchProtocolGuid abstract the CPU > specifics from the DXE Core. > > https://github.com/tianocore/edk2/blob/master/MdeModulePkg/Core/Dxe/Gcd/Gcd.c#L866 > if (Operation == GCD_SET_ATTRIBUTES_MEMORY_OPE

Re: [edk2] [PATCH] ShellPkg/alias: Fix bug to support upper-case alias

Including Tapan for review. Thanks/Ray > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Ruiyu Ni > Sent: Thursday, June 1, 2017 10:12 PM > To: edk2-devel@lists.01.org > Cc: Carsey, Jaben ; Kinney, Michael D > > Subject: [edk2] [PATCH] ShellP

[edk2] [PATCH] ShellPkg/alias: Fix bug to support upper-case alias

alias in UEFI Shell is case insensitive. Old code saves the alias to variable storage without converting the alias to lower-case, which results upper case alias setting doesn't work. The patch converts the alias to lower case before saving to variable storage. Contributed-under: TianoCore Contribu

Re: [edk2] Reconfiguring the PEI blob for the Overdrive1000 (AMD A1100)

On 1 June 2017 at 13:55, Rebecca Cran wrote: > On Thu, 1 Jun 2017 07:29:05 + > Ard Biesheuvel wrote: > >> Which PEI binary are you referring to? There is the PEI core, and a >> collection of PEI modules (PEIMs) that do various platform related >> things, including PCIe link training (and beli

Re: [edk2] Reconfiguring the PEI blob for the Overdrive1000 (AMD A1100)

On Thu, 1 Jun 2017 07:29:05 + Ard Biesheuvel wrote: > Which PEI binary are you referring to? There is the PEI core, and a > collection of PEI modules (PEIMs) that do various platform related > things, including PCIe link training (and believe me, looking at that > code will make your eyes ble

Re: [edk2] [PATCH v6 00/17] x86: Secure Encrypted Virtualization (AMD)

Laszlo, The current design is DXE IPL and gEfiCpuArchProtocolGuid abstract the CPU specifics from the DXE Core. https://github.com/tianocore/edk2/blob/master/MdeModulePkg/Core/Dxe/Gcd/Gcd.c#L866 if (Operation == GCD_SET_ATTRIBUTES_MEMORY_OPERATION) { // // Call CPU Arch Protocol to at

Re: [edk2] [PATCH v6 02/17] OvmfPkg/ResetVector: Set C-bit when building initial page table

On 06/01/2017 03:09 AM, Jordan Justen wrote: On 2017-05-26 07:43:50, Brijesh Singh wrote: SEV guest VMs have the concept of private and shared memory. Private memory is encrypted with the guest-specific key, while shared memory may be encrypted with hypervisor key. Certain types of memory (nam

Re: [edk2] [PATCH v2 0/2] MdeModulePkg/UsbBus: Fix system hang when failed to uninstall UsbIo

Reviewed-by: Star Zeng to this patch series. Thanks, Star -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ruiyu Ni Sent: Thursday, June 1, 2017 7:40 PM To: edk2-devel@lists.01.org Subject: [edk2] [PATCH v2 0/2] MdeModulePkg/UsbBus: Fix system hang

Re: [edk2] [staging/apei]: New branch request for APEI work

Andrew, Mike - any comments? I'd be happy to set this up. / Leif On Thu, May 25, 2017 at 01:29:06PM +0100, Achin Gupta wrote: > Hi All, > > I would like to create a branch for implementing support for APEI in EDK2. The > intent is to upstream modules that are capable of creating the HEST, B

Re: [edk2] [RFC PATCH] OvmfPkg/AcpiPlatformDxe: lift 4 GB alloc limit for modern ACPI systems

On 06/01/17 13:22, Ard Biesheuvel wrote: > ACPI supports architectures such as arm64, which did not exist when the > original 32-bit ACPI 1.0 was introduced. These days, ACPI tables can all > support 64-bit memory addresses, and so QEMU has been updated to emit > 64-bit table and entry point types

[edk2] [PATCH v2 1/2] MdeModulePkg/UsbBus: Fix system hang when failed to uninstall UsbIo

When "reconnect -r" is typed in shell, UsbFreeInterface() is called to uninstall the UsbIo and DevicePath. But When a UsbIo is opened by a driver and that driver rejects to close the UsbIo in Stop(), the uninstall doesn't succeed. But UsbFreeInterface () frees the DevicePath memory without check wh

[edk2] [PATCH v2 0/2] MdeModulePkg/UsbBus: Fix system hang when failed to uninstall UsbIo

Please refer to first patch for details. Patch 2/2 is to correct debug message to ease future debugging. Ruiyu Ni (2): MdeModulePkg/UsbBus: Fix system hang when failed to uninstall UsbIo MdeModulePkg/UsbBus: Correct debug message MdeModulePkg/Bus/Usb/UsbBusDxe/UsbEnumer.c | 43 +

[edk2] [PATCH v2 2/2] MdeModulePkg/UsbBus: Correct debug message

Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ruiyu Ni Cc: Star Zeng --- MdeModulePkg/Bus/Usb/UsbBusDxe/UsbUtility.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/MdeModulePkg/Bus/Usb/UsbBusDxe/UsbUtility.c b/MdeModulePkg/Bus/Usb/UsbBusDxe/Us

[edk2] [RFC PATCH] OvmfPkg/AcpiPlatformDxe: lift 4 GB alloc limit for modern ACPI systems

ACPI supports architectures such as arm64, which did not exist when the original 32-bit ACPI 1.0 was introduced. These days, ACPI tables can all support 64-bit memory addresses, and so QEMU has been updated to emit 64-bit table and entry point types on arm64/mach-virt. For the UEFI side, this mean

Re: [edk2] [PATCH v6 00/17] x86: Secure Encrypted Virtualization (AMD)

On 06/01/17 09:40, Jordan Justen wrote: > On 2017-05-29 14:59:46, Brijesh Singh wrote: >> >> >> On 5/29/17 3:38 PM, Jordan Justen wrote: >>> On 2017-05-29 04:16:15, Laszlo Ersek wrote: (looks like I was the one to comment as second reviewer after all :) ) On 05/26/17 23:05, Jordan Ju

Re: [edk2] [edk2-staging/BaseToolsOpt]: Add new branch BaseToolsOpt

Laszlo: Yes. We will analyze cProfile data and optimize the parse logic. Thanks Liming >-Original Message- >From: Laszlo Ersek [mailto:ler...@redhat.com] >Sent: Wednesday, May 31, 2017 7:21 PM >To: Gao, Liming ; edk2-devel@lists.01.org >Cc: Kinney, Michael D >Subject: Re: [edk2] [edk2-

Re: [edk2] [PATCH v3] BaseTools/GCC ARM/AARCH64: Force disable PIE

On 1 June 2017 at 00:45, Gao, Liming wrote: > Reviewed-by: Liming Gao > Pushed as a6b5380642c4 Thanks, Ard. >>-Original Message- >>From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] >>Sent: Thursday, June 01, 2017 1:31 AM >>To: dann frazier ; Gao, Liming ; >>Zhu, Yonghong >>Cc:

Re: [edk2] [PATCH v6 02/17] OvmfPkg/ResetVector: Set C-bit when building initial page table

On 2017-05-26 07:43:50, Brijesh Singh wrote: > SEV guest VMs have the concept of private and shared memory. Private > memory is encrypted with the guest-specific key, while shared memory > may be encrypted with hypervisor key. Certain types of memory (namely > instruction pages and guest page table

Re: [edk2] [PATCH v6 00/17] x86: Secure Encrypted Virtualization (AMD)

On 2017-05-29 14:59:46, Brijesh Singh wrote: > > > On 5/29/17 3:38 PM, Jordan Justen wrote: > > On 2017-05-29 04:16:15, Laszlo Ersek wrote: > >> (looks like I was the one to comment as second reviewer after all :) ) > >> > >> On 05/26/17 23:05, Jordan Justen wrote: > >>> On 2017-05-26 07:43:48, B

Re: [edk2] Reconfiguring the PEI blob for the Overdrive1000 (AMD A1100)

On 1 June 2017 at 02:31, Rebecca Cran wrote: > Hi, > > I recently got an ARM64 SoftIron Overdrive 1000 box which uses AMD's Opteron > A1100, and while it's nice having most of the platform firmware be open > source, the part I'm missing is the PEI, which is implemented in a binary > blob. Apparent