Star,
I don't recommend to add the additional check for performance consideration.
Because we have no idea what the input VariableName buffer is like.
If the VariableName is like ['\0', '?', '?', '?'] with MaxLen equals to 4,
"VariableName[MaxLen-1] != 0" check is redundant.
The NT32 case you met c
Hi,
On 06/23/17 22:41, Supreeth Venkatesh wrote:
> ***
> PI v1.5 Specification Volume 4 defines Management Mode Core Interface.
> In order to support Management Mode Core Interface, Module Types
> MM_STANDALONE, MM_CORE_STANDALONE are needed.
> PI specification v1.5 defines the following new fi
This patch adds SUP_MODULE_MM_STANDALONE and
SUP_MODULE_MM_CORE_STANDALONE data types and includes it in
SUP_MODULE_LIST.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jiewen Yao
Signed-off-by: Supreeth Venkatesh
---
BaseTools/Source/Python/Common/DataType.py | 4 +++-
This patch registers MM_STANDALONE and MM_CORE_STANDALONE module types
with CommonClass and PackageIncludePkgHeaderClass in CommonDataClass.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jiewen Yao
Signed-off-by: Supreeth Venkatesh
---
BaseTools/Source/Python/CommonData
PI v1.5 Specification Volume 4 defines Management Mode Core Interface.
In order to support Management Mode Core Interface, Module Types
MM_STANDALONE, MM_CORE_STANDALONE are needed.
This patch ensures that MM_STANDALONE, MM_CORE_STANDALONE Modules are
treated as EFI Boot Service Driver in GenFw too
This patch registers MM_STANDALONE and MM_CORE_STANDALONE with Ffs class.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jiewen Yao
Signed-off-by: Supreeth Venkatesh
---
BaseTools/Source/Python/Eot/FvImage.py | 2 ++
1 file changed, 2 insertions(+)
diff --git a/BaseTool
This patch registers MM_STANDALONE and MM_CORE_STANDALONE module type
with python build tools.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jiewen Yao
Signed-off-by: Supreeth Venkatesh
---
BaseTools/Source/Python/build/BuildReport.py | 4 +++-
BaseTools/Source/Python/b
This patch verifies MM_CORE_STANDALONE module compatibility with PI
specification version.
Also, it registers MM_STANDALONE/MM_CORE_STANDALONE modules with
FdfParser class and provides mapping between MM_STANDALONE and
MM_CORE_STANDALONE module type in FDF with
EFI_FV_FILETYPE_MM_STANDALONE and EFI
This patch checks SUP_MODULE_MM_CORE_STANDALONE and
SUP_MODULE_MM_STANDALONE module compatibility with PI specification
version.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jiewen Yao
Signed-off-by: Supreeth Venkatesh
---
BaseTools/Source/Python/Workspace/WorkspaceDat
This patch adds support for FdfParser tool to parse MM_STANDALONE and
MM_CORE_STANDALONE modules.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jiewen Yao
Signed-off-by: Supreeth Venkatesh
---
BaseTools/Source/Python/Common/FdfParserLite.py | 4 ++--
1 file changed, 2 i
This patch adds changes to auto generate MM_CORE_STANDALONE and
MM_STANDALONE Entry Point templates.
Also, it adds changes to help auto generate dependency expressions for
MM_STANDALONE modules.
PI Specification v1.5 specifies Management Mode System Table (MMST)
which is a collection of common se
PI specification v1.5 defines new firmware volume file types.
This patch adds the new file type EFI_FV_FILETYPE_MM_STANDALONE and
EFI_FV_FILETYPE_MM_CORE_STANDALONE in GenFfs tool.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jiewen Yao
Signed-off-by: Supreeth Venkatesh
***
PI v1.5 Specification Volume 4 defines Management Mode Core Interface.
In order to support Management Mode Core Interface, Module Types MM_STANDALONE,
MM_CORE_STANDALONE are needed.
PI specification v1.5 defines the following new file types:
#define EFI_FV_FILETYPE_MM_STANDALONE 0x0E
#define
On 22 June 2017 at 15:21, Leif Lindholm wrote:
> On Thu, Jun 22, 2017 at 10:31:59AM +0100, Scott Telford wrote:
>> Add SEC phase implementation for Cadence CSP platform configured with
>> a single Cortex-A53 processor and GIC-500.
>>
>> Based on ArmPlatformPkg/Sec, with required parts of
>> ArmPkg
On 22 June 2017 at 15:12, Leif Lindholm wrote:
> On Thu, Jun 22, 2017 at 10:31:58AM +0100, Scott Telford wrote:
>> Add PciHostBridgeLib implementation for the Cadence PCIe Root Complex.
>> This library is derived from
>> Platforms/ARM/Juno/Library/JunoPciHostBridgeLib in OpenPlatformPkg.
>>
>> Con
On 22 June 2017 at 15:02, Leif Lindholm wrote:
> On Thu, Jun 22, 2017 at 10:31:57AM +0100, Scott Telford wrote:
>> Add serial port library to support the Cadence IP6528 UART used in the
>> Cadence CSP platform.
>>
>> Contributed-under: TianoCore Contribution Agreement 1.0
>> Signed-off-by: Scott T
On 22 June 2017 at 14:50, Leif Lindholm wrote:
> On Thu, Jun 22, 2017 at 10:31:56AM +0100, Scott Telford wrote:
>> Add libraries (CadenceCspLib, CadenceCspSecLib,
>> CadenceCspResetSystemLib) to support the Cadence Configurable System
>> Platform (CSP) configured with a single ARM Cortex-A53, GIC-
Hello,
Testing a system with NVMe Intel SSD drive doesn't give a meaningful
description in the shell or converting the device path to text in
general using the EDK2 (you only get a "?"). It appears it's because
the MESSAGING_DEVICE_PATH for this Intel NVMe is vendor defined.
Where do you find th
Liming,
No issue. I will update v4 to indicate Name change.
Supreeth
-Original Message-
From: Gao, Liming [mailto:liming@intel.com]
Sent: Thursday, June 22, 2017 10:23 PM
To: Supreeth Venkatesh ; edk2-devel@lists.01.org
Cc: leif.lindh...@linaro.org; Kinney, Michael D ;
Achin Gupta ;
On 06/23/17 02:59, Fu Siyuan wrote:
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Fu Siyuan
> Cc: Ye Ting
> Cc: Wu Jiaxin
> ---
> NetworkPkg/HttpBootDxe/HttpBootImpl.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/NetworkPkg/HttpBootDxe/HttpBootImpl.c
>
Requirement:
In current working model, to change the default setting in HII VarStore, VFR
source files have to be modified. There is no platform override way. This
requirement is to move such configure setting to platform DSC, and provide the
centralized setting in platform DSC. The idea is to
Good catch. Reviewed-by: Liming Gao
>-Original Message-
>From: Zeng, Star
>Sent: Friday, June 23, 2017 5:45 PM
>To: edk2-devel@lists.01.org
>Cc: Zeng, Star ; Gao, Liming
>Subject: [PATCH] MdeModulePkg DxeCore: Only free ScratchBuffer when it is
>not NULL
>
>There is a case that ExtractGu
Change since v3:
1) Fixed issue when Attributes = EFI_OPEN_PROTOCOL_TEST_PROTOCOL
and Inteface = NULL case. [Reported by:star.zeng at intel.com]
Change Since v2:
1) Modified to use EFI_ERROR to get status code
Change since v1:
1) Fixed typo protocal to protocol
2) Fixed coding style
Modified sou
Reviewed-by: jiewen@intel.com
> -Original Message-
> From: Wu, Hao A
> Sent: Thursday, June 22, 2017 10:56 AM
> To: edk2-devel@lists.01.org
> Cc: Wu, Hao A ; Yao, Jiewen
> Subject: [PATCH] IntelSiliconPkg: Add package DSC file
>
> Cc: Jiewen Yao
> Contributed-under: TianoCore Contri
On 06/22/17 22:37, Brijesh Singh wrote:
> Add the shorter-term library instance outlined in the previous patch to
> OvmfPkg, so that we can imbue PciHostBridgeDxe with a protocol dependency
> on gEdkiiIoMmuProtocolGuid OR gIoMmuAbsentProtocolGuid.
>
> Cc: Jordan Justen
> Cc: Laszlo Ersek
> Contr
On 06/22/17 22:37, Brijesh Singh wrote:
> Platforms that optionally provide an IOMMU protocol should do so by
> including a DXE driver (usually called IoMmuDxe) that produces either
> the IOMMU protocol -- if the underlying capabilities are available --,
> or gIoMmuAbsentProtocolGuid, to signal tha
There is a case that ExtractGuidedSectionGetInfo return 0 for
ScratchBufferSize and ScratchBuffer will be NULL, after AllocatePool
fails to allocate buffer for AllocatedOutputBuffer, the code will
call FreePool (ScratchBuffer), but ScratchBuffer == NULL.
This patch is to only free ScratchBuffer wh
On 06/22/17 22:37, Brijesh Singh wrote:
> SEV guest VMs have the concept of private and shared memory. Private
> memory is encrypted with the guest-specific key, while shared memory
> may be encrypted with hypervisor key. Certain types of memory (namely
> instruction pages and guest page tables) ar
Ray,
It is to pass the check quickly and avoid scanning all the chars in
VariableName by StrnLenS for normal boot without invalid cases.
I did experiments in the code of GetNextVariableName with below debug code for
normal boot on NT32 and my real platforms, all the cases will go into the
branc
Star,
What's the benefit of this check "VariableName[MaxLen - 1] != 0"?
I think this check "StrnLenS (VariableName, MaxLen) == MaxLen" should be enough.
Thanks/Ray
> -Original Message-
> From: Zeng, Star
> Sent: Friday, June 23, 2017 4:08 PM
> To: edk2-devel@lists.01.org
> Cc: Zeng, Star
Reviewed-by: Liming Gao
>-Original Message-
>From: Zhu, Yonghong
>Sent: Tuesday, June 20, 2017 4:05 PM
>To: edk2-devel@lists.01.org
>Cc: Feng, YunhuaX ; Gao, Liming
>
>Subject: [Patch] BaseTools: Fix the bug that use '|' or '||' in DSC file's Pcd
>value
>
>From: Yunhua Feng
>
>Fix the b
Reviewed-by: Liming Gao
>-Original Message-
>From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Star
>Zeng
>Sent: Friday, June 23, 2017 4:08 PM
>To: edk2-devel@lists.01.org
>Cc: Zeng, Star
>Subject: [edk2] [PATCH V2 0/3] Update comments and code for
>GetNextVariableNa
"The size must be large enough to fit input string supplied in
VariableName buffer" is added in the description for VariableNameSize.
And two cases of EFI_INVALID_PARAMETER are added.
1. The input values of VariableName and VendorGuid are not a name and
GUID of an existing variable.
2. Null-term
"The size must be large enough to fit input string supplied in
VariableName buffer" is added in the description for VariableNameSize.
And two cases of EFI_INVALID_PARAMETER are added.
1. The input values of VariableName and VendorGuid are not a name and
GUID of an existing variable.
2. Null-term
V2: Add changes for EmuVariable and FsVariable.
"The size must be large enough to fit input string supplied in
VariableName buffer" is added in the description for VariableNameSize.
And two cases of EFI_INVALID_PARAMETER are added.
1. The input values of VariableName and VendorGuid are not a name
"The size must be large enough to fit input string supplied in
VariableName buffer" is added in the description for VariableNameSize.
And two cases of EFI_INVALID_PARAMETER are added.
1. The input values of VariableName and VendorGuid are not a name and
GUID of an existing variable.
2. Null-term
Please ignore the previous mail. It is my mistake.
For this patch, Reviewed-by: Liming Gao
>-Original Message-
>From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Gao,
>Liming
>Sent: Friday, June 23, 2017 3:51 PM
>To: Zhu, Yonghong ; edk2-devel@lists.01.org
>Cc: Feng,
c:\r9tip\allpkg\edk2\mdemodulepkg\universal\pcd\pei\Service.h
>-Original Message-
>From: Zhu, Yonghong
>Sent: Thursday, June 22, 2017 4:10 PM
>To: edk2-devel@lists.01.org
>Cc: Feng, YunhuaX ; Gao, Liming
>
>Subject: [Patch] BaseTools: Enhance DEC Defines section format check
>
>From: Yunhu
38 matches
Mail list logo
