Re: [edk2] [Patch V3 3/8] edk2: Remove commit message details from Contributions.txt

On Fri, Jul 21, 2017 at 02:16:54PM -0700, Jordan Justen wrote: > On 2017-07-19 22:44:06, Michael D Kinney wrote: > > https://bugzilla.tianocore.org/show_bug.cgi?id=629 > > > > Remove the change description, commit message, and > > patch email section from Contributions.txt. This > > section is

Re: [edk2] [Patch V3 3/8] edk2: Remove commit message details from Contributions.txt

On 2017-07-19 22:44:06, Michael D Kinney wrote: > https://bugzilla.tianocore.org/show_bug.cgi?id=629 > > Remove the change description, commit message, and > patch email section from Contributions.txt. This > section is not part of the TianoCore Contribution > Agreement. Neither are the ~35

Re: [edk2] DHCP Option 61 support

Option 61 is listed in dhcp.h of the EDK II NetworkPkg, which applies to generic stack support. https://github.com/tianocore/edk2/blob/master/MdePkg/Include/IndustryStandard/Dhcp.h The link you provided applies to specific Intel products, which are removing Option 61 from specific versions of

Re: [edk2] Adding OpenSSL as the submodule of EDKII project...

Long,Qin I think this is a great idea and great step forward for making edk2 more consumable. We already do this for our internal clones of edk2 and would like to see more work like this done to make edk2 consumable in a sustainable and easy way. For example we also use submodules within our

[edk2] [Suggestion/Bug] Extend the usage of 'shared' modules

Dear developers, Dear KabylakeSiliconPkg devs: If you are not interested in the suggestion of generic, shared modules, please read my comment on 2) nevertheless, as it contains a potential bug report. Sorry, but I could not verify this yet. I have been exploring the code of most of the Intel

Re: [edk2] [RFC v1 0/3] Add VIRTIO_F_IOMMU_PLATFORM support

On 7/20/17 10:24 PM, Jason Wang wrote: > > > On 2017年07月20日 06:09, Brijesh Singh wrote: >> I have found that OVMF fails to detect the disk when iommu_platform >> is set from >> qemu cli. The failure occurs during the feature bit negotiation. >> >> Recently, EDKII introduced IOMMU protocol

[edk2] [PATCH] UefiCpuPkg: Add BOOLEAN casts to return statements.

Old versions of the Visual Studio C compiler return a value of type 'int' for comparisons, which is what the C99 standard defines in the sections 6.5.8 and 6.5.9. When the result of a comparison is returned, int is implicitely casted to BOOLEAN, which is smaller, and hence a warning about a

[edk2] [PATCH] UefiCpuPkg/CpuCommonFeaturesLib: Fix the documentation of PpinSupport().

The documentation of PpinSupport() refers to 'Enhanced Intel SpeedStep'. This patch fixes these referneces. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marvin Haeuser --- UefiCpuPkg/Library/CpuCommonFeaturesLib/Ppin.c | 4 ++--

[edk2] [PATCH] UefiCpuPkg/PiSmmCpuDxeSmm: Cast the return value of GetPageTableBase().

The value returned by GetPageTableBase() is of type UINT64, which is implicitely casted to UINTN by the return statement. To purge the 'possible loss of data' warning on 32-bit platforms, with this patch, the value is casted to UINTN before returning. Contributed-under: TianoCore Contribution

Re: [edk2] [PATCH] MdePkg UsbFunctionIo.h: Update comments for GetDeviceInfo return status

Reviewed-by: Liming Gao >-Original Message- >From: Zeng, Star >Sent: Wednesday, July 19, 2017 6:29 PM >To: edk2-devel@lists.01.org >Cc: Zeng, Star ; Gao, Liming >Subject: [PATCH] MdePkg UsbFunctionIo.h: Update comments for

[edk2] [PATCH v2 1/3] MdeModulePkg/SetupBrowser: Record the reset status in all SendForm

After calling SendForm to enter front page, configuration change in some driver may require system reset. Currently the reset status is saved in SendForm level. Then SendForm can return the reset status. IsResetRequired API also can return the reset status before exiting browser. It return the

[edk2] [PATCH v2 2/3] MdeModulePkg/BMUiLib: Check reset requirement before exiting UiApp

V2: Refine the comments. In UI page, some configuration change may require system reset. BootManagerUiLib misses this check before exiting UiApp to boot other boot options. Now add the check. Cc: Eric Dong Cc: Liming Gao Contributed-under: TianoCore

[edk2] [PATCH v2 0/3] Check reset requirement before exiting UiApp

V2: Refine the comments in patch 2 and 3. Patch 1 enahce the IsResetRequired API to return to reset info in system level. Patch 2 Check reset requirement before exiting UiApp (thorugh boot option). Patch 3 Check reset requirement before exiting UiApp (through boot from file). Cc: Eric Dong

[edk2] [PATCH v2 3/3] MdeModulePkg/BMMUiLib: Check reset requirement before exiting UiApp

V2: Refine the comments. In UI page, some configuration change may require system reset. BootMaintenanceManagerUiLib misses this check before exiting UiApp to boot other boot options. Now add the check. Cc: Eric Dong Cc: Liming Gao Contributed-under:

[edk2] [PATCH] MdeModulePkg SmmLockBoxDxeLib: Get SmmCommRegion for COMM buffer

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=593 Currently, SmmCommunciate fails in RestoreLockBox after SmmReadyToLock since COMM buffer is in stack instead of using SmmCommRegion by gEdkiiPiSmmCommunicationRegionTableGuid. This patch is to get SmmCommRegion by

[edk2] [PATCH] QuarkSocPkg/QNCSmmDispatcher: Fix use after free issue #2

As part of commit 5f82e02, ActiveRecordInDb was introduced as a copy of RecordInDb as latter may be freed by the callback function. This commit replaces an access of RecordInDb after the callback function has been executed with an access to ActiveRecordInDb. Contributed-under: TianoCore