Re: [edk2] [PATCH 3/3] UefiCpuPkg PiSmmCommunicationSmm: Deprecate SMM Communication ACPI Table

2017-07-26 Thread Yao, Jiewen
Reviewed-by: jiewen@intel.com > -Original Message- > From: Zeng, Star > Sent: Thursday, July 20, 2017 9:56 PM > To: edk2-devel@lists.01.org > Cc: Zeng, Star ; Jiewen Yao ; Fan, > Jeff > Subject: [PATCH 3/3] UefiCpuPkg PiSmmCommunicationSmm: Deprecate SMM > Communication ACPI Table >

[edk2] [PATCH] ShellPkg: Avoid buffer out-of-bound access

2017-07-26 Thread Ruiyu Ni
PathSize is the number of bytes in PathForReturn buffer so PathForReturn[PathSize - 1] incorrectly accesses the last character in the buffer, PathForReturn[PathSize / sizeof (CHAR16) - 1] should be used. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ruiyu Ni Cc: Steven Sh

Re: [edk2] [PATCH] MdePkg/SecPeiDxeTimerLibCpu: Consume UefiCpuPkg LAPIC code.

2017-07-26 Thread Marvin Häuser
Hey Jeff, That would definitely fix the compilation issue. Do I see it right that for 32-bit platforms, it's just ApicBase and for 64-bit platforms, it's ApicBase and ApicBaseHi? If yes, maybe ~(UINTN)0xFFF should be used to play safe? Thanks, Marvin. > -Original Message- > From: Fan, J

Re: [edk2] [PATCH 2/7] IntelSiliconPkg/Include: Add PlatformVtdPolicy Protocol

2017-07-26 Thread Zeng, Star
How about we update the description for EDKII_PLATFORM_VTD_POLICY_GET_EXCEPTION_DEVICE_LIST? + Get a list of handles for the exception devices. -> + Get a list of the exception devices. With this update, Reviewed-by: Star Zeng to the whole patch series. Thanks, Star -Original Message--

Re: [edk2] [PATCH] UefiCpuPkg: Add BOOLEAN casts to return statements.

2017-07-26 Thread Marvin Häuser
Hi Jeff, Visual Studio 2005 (and .NET 2003, though it is too old to compile using EDK2. Maybe it should be deprecated?) is the version generating those errors, all newer versions are fine. Thanks and regards, Marvin. > -Original Message- > From: Fan, Jeff [mailto:jeff@intel.com] >

Re: [edk2] [PATCH] ShellPkg/map: Recognize CDROM change

2017-07-26 Thread Gao, Liming
Reviewed-by: Liming Gao >-Original Message- >From: Ni, Ruiyu >Sent: Tuesday, July 25, 2017 3:45 PM >To: edk2-devel@lists.01.org >Cc: Kinney, Michael D ; Gao, Liming > >Subject: [PATCH] ShellPkg/map: Recognize CDROM change > >The patch adds logic to probe the media change for physical >blo

[edk2] [PATCH] Nt32Pkg: Always use 0x2000 for maxim variable size

2017-07-26 Thread Ruiyu Ni
Currently the PcdMaxVariableSize is controlled by the below condition check: !if $(SECURE_BOOT_ENABLE) == TRUE || $(TLS_ENABLE) == TRUE gEfiMdeModulePkgTokenSpaceGuid.PcdMaxVariableSize|0x2000 !endif But for other case, PcdMaxVariableSize is also required with the value of 0x2000 (e,g. NetworkP

[edk2] [PATCH] ShellPkg/ShellLib: Remove unused macros

2017-07-26 Thread Ruiyu Ni
MAX_FILE_NAME_LEN and FIND_X_FILE_BUFFER_SIZE are not used by ShellLib so remove them. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ruiyu Ni Cc: Michael D Kinney Cc: Liming Gao --- ShellPkg/Include/Library/ShellLib.h | 5 + ShellPkg/Library/UefiShellL

Re: [edk2] [Patch V4 0/6] Update to Tiano Contribution Agreement 1.1

2017-07-26 Thread Laszlo Ersek
On 07/25/17 18:06, Kinney, Michael D wrote: > Laszlo, > > If you look at patch V4 #6, you will see the Readme.md has been > added that lists all the licenses in use. There are more than > just the default BSD license and the 3 components in the OvmfPkg. > I prefer the idea of using Readme.md to

Re: [edk2] [RFC v1 0/3] Add VIRTIO_F_IOMMU_PLATFORM support

2017-07-26 Thread Laszlo Ersek
On 07/26/17 05:32, Jason Wang wrote: > > > On 2017年07月26日 02:17, Laszlo Ersek wrote: >> Adding Ard >> >> On 07/20/17 00:09, Brijesh Singh wrote: >>> I have found that OVMF fails to detect the disk when iommu_platform >>> is set from >>> qemu cli. The failure occurs during the feature bit negotiat

[edk2] Disable BIOS menu or set password EDK2

2017-07-26 Thread Zach Smith
I am trying to remove the ability to use the BIOS-like menu on my minnowboard, which is running EDK2 firmware: https://github.com/tianocore/edk2-platforms/tree/minnowboard-max-udk2015 However I have been unable to locate anywhere that I can turn this capability off. Is there a way to do this? Fa

Re: [edk2] [PATCH 1/1] OvmfPkg/PlatformPei: support >=1TB high RAM, and discontiguous high RAM

2017-07-26 Thread Laszlo Ersek
On 07/26/17 02:13, Jordan Justen wrote: > On 2017-07-10 20:22:31, Laszlo Ersek wrote: >> +STATIC >> +EFI_STATUS >> +E820HighRamIterate ( >> + IN E820_HIGH_RAM_ENTRY_CALLBACK Callback, >> + IN OUT VOID *Context >> + ) > > I think a simpler option would be: > > STATIC

Re: [edk2] [Patch v4 3/6] edk2: Update to TianoCore Contribution Agreement 1.1

2017-07-26 Thread Jordan Justen
On 2017-07-25 10:55:45, Kinney, Michael D wrote: > Hi Jordan, > > I also considered changing CodeModule to Module. I will > make that change. > > I like the idea of providing a chapter or section reference > in a document patch when applicable. I will update the > tianocore-docs wiki with that

Re: [edk2] [Patch v4 3/6] edk2: Update to TianoCore Contribution Agreement 1.1

2017-07-26 Thread Kinney, Michael D
Hi Jordan, Not sure I understand the 'whitespace' usage. Can you provide some example subject lines for documentation patches that I can add to the tianocore-docs wiki? Larger documents are broken up into directories in the document repository with a chapter number and/or chapter title in the

Re: [edk2] [Patch v4 3/6] edk2: Update to TianoCore Contribution Agreement 1.1

2017-07-26 Thread Jordan Justen
On 2017-07-26 10:45:41, Kinney, Michael D wrote: > Hi Jordan, > > Not sure I understand the 'whitespace' usage. Previously I had given some examples of the style guide: * whitespace: Change indentation to 5 spaces * case: All functions must now use StUdLyCaPs If it was instead: * ch5: Change

Re: [edk2] [Patch v4 3/6] edk2: Update to TianoCore Contribution Agreement 1.1

2017-07-26 Thread Laszlo Ersek
On 07/26/17 20:20, Jordan Justen wrote: > On 2017-07-26 10:45:41, Kinney, Michael D wrote: >> Hi Jordan, >> >> Not sure I understand the 'whitespace' usage. > > Previously I had given some examples of the style guide: > > * whitespace: Change indentation to 5 spaces > > * case: All functions mus

Re: [edk2] [PATCH] Nt32Pkg: Always use 0x2000 for maxim variable size

2017-07-26 Thread Wu, Jiaxin
Reviewed-by: Jiaxin Wu > -Original Message- > From: Ni, Ruiyu > Sent: Wednesday, July 26, 2017 5:27 PM > To: edk2-devel@lists.01.org > Cc: Wu, Jiaxin > Subject: [PATCH] Nt32Pkg: Always use 0x2000 for maxim variable size > > Currently the PcdMaxVariableSize is controlled by the below c

[edk2] [Patch 0/6] BaseTools: Fix some segmentation fault in Tools

2017-07-26 Thread Yonghong Zhu
Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Yonghong Zhu Yonghong Zhu (6): BaseTools/Split: Fix the segmentation fault in GetSplitValue() BaseTools/GenSec: Fix a segmentation fault in main() BaseTools/GenFfs: Fix a segmentation fault from vsprintf(

[edk2] [Patch 1/6] BaseTools/Split: Fix the segmentation fault in GetSplitValue()

2017-07-26 Thread Yonghong Zhu
Fixes: https://bugzilla.tianocore.org/show_bug.cgi?id=538 Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Yonghong Zhu --- BaseTools/Source/C/Split/Split.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/BaseTools/Source/C/Spli

[edk2] [Patch 2/6] BaseTools/GenSec: Fix a segmentation fault in main()

2017-07-26 Thread Yonghong Zhu
Fixes: https://bugzilla.tianocore.org/show_bug.cgi?id=537 Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Yonghong Zhu --- BaseTools/Source/C/GenSec/GenSec.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/BaseTools/Source/C/GenSe

[edk2] [Patch 3/6] BaseTools/GenFfs: Fix a segmentation fault from vsprintf()/vfprintf()

2017-07-26 Thread Yonghong Zhu
Fixes: https://bugzilla.tianocore.org/show_bug.cgi?id=536 Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Yonghong Zhu --- BaseTools/Source/C/GenFfs/GenFfs.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/BaseTools/Source/C/GenFfs/

[edk2] [Patch 4/6] BaseTools/EfiRom: Fix a segmentation fault from vsprintf()/vfprintf()

2017-07-26 Thread Yonghong Zhu
Fixes: https://bugzilla.tianocore.org/show_bug.cgi?id=534 Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Yonghong Zhu --- BaseTools/Source/C/EfiRom/EfiRom.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/BaseTools/Source/C/EfiRom/

[edk2] [Patch 6/6] BaseTools/GenCrc32: Fix a bug to hand empty file for decode

2017-07-26 Thread Yonghong Zhu
Fixes: https://bugzilla.tianocore.org/show_bug.cgi?id=535 Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Yonghong Zhu --- BaseTools/Source/C/GenCrc32/GenCrc32.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/BaseTools/Source/C/G

[edk2] [Patch 5/6] BaseTools/EfiLdrImage: Fix a segmentation fault from vfprintf()

2017-07-26 Thread Yonghong Zhu
Fixes: https://bugzilla.tianocore.org/show_bug.cgi?id=533 Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Yonghong Zhu --- BaseTools/Source/C/EfiLdrImage/EfiLdrImage.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/BaseTools/Source

[edk2] [patch] BaseTools/VfrCompile: Fix segmentation fault issues

2017-07-26 Thread Dandan Bi
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=532 (1) Add NULL check before using a pointer. (2) Use "%s" format string in DebugError function to avoid crash caused by incorrect input. Cc: Bo Chen Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Da

[edk2] [PATCH] MdeModulePkg/PciBus: Avoid hang when BUS pad resource is not in top

2017-07-26 Thread Ruiyu Ni
PciScanBus() assumes the GetResourcePadding() puts BUS descriptor in the very beginning, if it's not, the Descriptors will be updated to point to middle of the pool buffer, which can cause FreePool(Descriptors) hang in DEBUG image. No functionality impact to RELEASE image. Contributed-under: Tiano

[edk2] [Patch] BaseTools: Fix the bug to correctly check Pcd type that in FDF file

2017-07-26 Thread Yonghong Zhu
We set Pcd value in FDF and used this Pcd as PatchableInModule type in module, it cause build report generate failure. because we incorrectly set the Pcd type during check whether the Pcd is used. Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Yonghong Zhu

Re: [edk2] [PATCH] ShellPkg/ShellLib: Remove unused macros

2017-07-26 Thread Gao, Liming
Reviewed-by: Liming Gao >-Original Message- >From: Ni, Ruiyu >Sent: Wednesday, July 26, 2017 5:34 PM >To: edk2-devel@lists.01.org >Cc: Kinney, Michael D ; Gao, Liming > >Subject: [PATCH] ShellPkg/ShellLib: Remove unused macros > >MAX_FILE_NAME_LEN and FIND_X_FILE_BUFFER_SIZE are not u

[edk2] [Patch] NetworkPkg: Display HTTP redirection info to the screen if need.

2017-07-26 Thread Fu Siyuan
HTTP defines a set of status code for redirecting a request to a different URI in Section 6.4 of RFC7231 and also RFC7583. This patch updates the HTTP boot driver to display the redirection info to the screen so the user would have chance to know new URI address of the HTTP boot image. Contributed

Re: [edk2] [PATCH] MdeModulePkg/PciBus: Avoid hang when BUS pad resource is not in top

2017-07-26 Thread Zeng, Star
Reviewed-by: Star Zeng -Original Message- From: Ni, Ruiyu Sent: Thursday, July 27, 2017 11:06 AM To: edk2-devel@lists.01.org Cc: Zeng, Star Subject: [PATCH] MdeModulePkg/PciBus: Avoid hang when BUS pad resource is not in top PciScanBus() assumes the GetResourcePadding() puts BUS descr