Re: [edk2] [Patch 1/2] CryptoPkg/TlsLib: Remove the redundant free of BIO objects

2017-07-30 Thread Long, Qin
Reviewed-by: Long Qin -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Jiaxin Wu Sent: Monday, July 31, 2017 1:41 PM To: edk2-devel@lists.01.org Cc: Ye, Ting ; Wu, Jiaxin ; Long, Qin Subject: [edk2] [Patch 1/2] CryptoPkg/TlsLib: Remove the redun

[edk2] [Patch 1/2] CryptoPkg/TlsLib: Remove the redundant free of BIO objects

2017-07-30 Thread Jiaxin Wu
TLS BIO objects (InBio/OutBio) will be freed by SSL_free() function. So, the following free operation (BIO_free) in TlsFree is redundant. It can be removed directly. Cc: Ye Ting Cc: Long Qin Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Wu Jiaxin --- CryptoPkg/Library/

[edk2] [Patch 2/2] NetworkPkg/HttpDxe: Destroy the TLS instance when cleaning up the HTTP child

2017-07-30 Thread Jiaxin Wu
During clean up the HTTP child, all resources used by it should be cleaned. But currently, TLS instance is not destroyed. This patch is to fix this issue. Cc: Ye Ting Cc: Fu Siyuan Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Wu Jiaxin --- NetworkPkg/HttpDxe/HttpImpl

[edk2] [Patch 0/2] Fix the bug when cleaning up the TLS instance

2017-07-30 Thread Jiaxin Wu
Cc: Ye Ting Cc: Fu Siyuan Cc: Long Qin Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Wu Jiaxin Jiaxin Wu (2): CryptoPkg/TlsLib: Remove the redundant free of BIO objects NetworkPkg/HttpDxe: Destroy the TLS instance when cleaning up the HTTP child CryptoPkg/Library

Re: [edk2] [PATCH 2/3] UefiCpuPkg SecCore: Add SecPerformancePpiCallBack

2017-07-30 Thread Fan, Jeff
Reviewed-by: Jeff Fan -Original Message- From: Zeng, Star Sent: Monday, July 31, 2017 11:32 AM To: edk2-devel@lists.01.org Cc: Zeng, Star; Gao, Liming; Fan, Jeff Subject: [PATCH 2/3] UefiCpuPkg SecCore: Add SecPerformancePpiCallBack Add SecPerformancePpiCallBack to get SEC performance d

Re: [edk2] [PATCH 1/3] UefiCpuPkg SecCore: Adjust PeiTemporaryRamBase&Size to be 8byte aligned

2017-07-30 Thread Fan, Jeff
Reviewed-by: Jeff Fan -Original Message- From: Zeng, Star Sent: Monday, July 31, 2017 11:32 AM To: edk2-devel@lists.01.org Cc: Zeng, Star; Gao, Liming; Fan, Jeff Subject: [PATCH 1/3] UefiCpuPkg SecCore: Adjust PeiTemporaryRamBase&Size to be 8byte aligned As HOB which has 8byte aligned

[edk2] [PATCH 2/3] UefiCpuPkg SecCore: Add SecPerformancePpiCallBack

2017-07-30 Thread Star Zeng
Add SecPerformancePpiCallBack to get SEC performance data and build HOB to convey the SEC performance data to DXE phase. Cc: Liming Gao Cc: Jeff Fan Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Star Zeng --- UefiCpuPkg/SecCore/SecCore.inf | 7 +++ UefiCpuPkg/SecC

[edk2] [PATCH 3/3] MdeModulePkg FirmwarePerfPei: Remove SEC performance data getting code

2017-07-30 Thread Star Zeng
Current SEC performance data getting code in FirmwarePerformancePei may get wrong SEC performance data if FirmwarePerformancePei executes after memory discovered. And as SecCore has added SecPerformancePpiCallBack to get SEC performance data and build HOB to convey the SEC performance data to DXE

[edk2] [PATCH 0/3] Add SecPerformancePpiCallBack to get SEC performance data in SecCore

2017-07-30 Thread Star Zeng
Current SEC performance data getting code in FirmwarePerformancePei may get wrong SEC performance data if FirmwarePerformancePei executes after memory discovered, it can be removed after SecPerformancePpiCallBack is added in SecCore. Cc: Liming Gao Cc: Jeff Fan Star Zeng (3): UefiCpuPkg SecCo

[edk2] [PATCH 1/3] UefiCpuPkg SecCore: Adjust PeiTemporaryRamBase&Size to be 8byte aligned

2017-07-30 Thread Star Zeng
As HOB which has 8byte aligned requirement will be built based on them in PEI phase. Cc: Liming Gao Cc: Jeff Fan Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Star Zeng --- UefiCpuPkg/SecCore/SecMain.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff -

Re: [edk2] [PATCH 0/2] Handle notification PPI from SEC

2017-07-30 Thread Gao, Liming
Reviewed-by: Liming Gao >-Original Message- >From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Star >Zeng >Sent: Friday, July 28, 2017 5:12 PM >To: edk2-devel@lists.01.org >Cc: Zeng, Star >Subject: [edk2] [PATCH 0/2] Handle notification PPI from SEC > >This patch ser

Re: [edk2] [PATCH v3 1/2] EmbeddedPkg/AndroidBoot: boot android kernel from storage

2017-07-30 Thread Leif Lindholm
On Sun, Jul 30, 2017 at 10:22:15PM +0800, Jun Nie wrote: > >> + Status = EfiGetSystemConfigurationTable (&gFdtTableGuid, (VOID > >> **)&FdtBase); > >> + if (!EFI_ERROR (Status)) { > >> >>> > >> >>>Should this not be > >> >>> if (EFI_ERROR (Status) && Status != EFI_NOT_FOUND) > >> >

Re: [edk2] [PATCH v3 1/2] EmbeddedPkg/AndroidBoot: boot android kernel from storage

2017-07-30 Thread Jun Nie
2017-07-28 22:52 GMT+08:00 Leif Lindholm : > On Fri, Jul 28, 2017 at 10:18:49PM +0800, Jun Nie wrote: >> On 2017年07月28日 21:06, Leif Lindholm wrote: >> >On Fri, Jul 28, 2017 at 05:47:46PM +0800, Jun Nie wrote: >> >>On 2017年07月27日 22:09, Leif Lindholm wrote: >> >>>On Thu, Jul 27, 2017 at 06:07:19PM +

[edk2] [Patch] NetworkPkg/Ip6Dxe: Fix the IPv6 PXE boot option goes missing issue

2017-07-30 Thread Jiaxin Wu
This patch is to fix the potential issue recorded at Bugzilla 636: https://bugzilla.tianocore.org/show_bug.cgi?id=636 The issue is caused by the IPv6 policy switching after PXEv6 boot. When IP policy is changing, the IPv6 children used by PXE.UdpRead() will be destroyed. Then, PXE Stop() function