[edk2] [Patch v2] Vlv2TbltDevicePkg: Remove reference deprecated macro.

2017-08-03 Thread Eric Dong
v2 changes include: 1. Use MSR data structure instead of redefin local macro. Cc: Jeff Fan Cc: Ruiyu Ni Cc: David Wei Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Eric Dong ---

[edk2] [Patch] Edk2: Update UefiCpuPkg owner.

2017-08-03 Thread Eric Dong
Cc: Jeff Fan Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Eric Dong --- Maintainers.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Maintainers.txt b/Maintainers.txt index 39b5b67..9d1b9fb 100644 ---

Re: [edk2] [Patch 4/7] QuarkSocPkg MtrrLib: Remove reference deprecated macro.

2017-08-03 Thread Dong, Eric
Ray, I check the spec, found the Quark definition has some small difference with normal MSR. So I prefer not do this change for Quark. Thanks, Eric -Original Message- From: Ni, Ruiyu Sent: Thursday, August 3, 2017 6:22 PM To: Dong, Eric ; edk2-devel@lists.01.org

Re: [edk2] Issue of step by step debugging of OVMF SEC code in QEMU

2017-08-03 Thread Andrew Fish
It is generally hard to debug across x86 processor mode transitions, and to debug 16-bit real mode code with modern tools. There are a few places in the x86 that still require 16-bit real mode for handoffs (like the reset vector) so you tend to hit this issue more in debugging firmware.

[edk2] [PATCH V3] MdeModulePkg/DisplayEngine: Fix incorrect display issue

2017-08-03 Thread Dandan Bi
In a form, some new menus may be dynamically inserted between highlight menu and previous top of screen menu when some question are refreshed. So the highlight menu and previous top of screen menu perhaps can't be shown in one page. Existing codes miss to handle this case then will cause incorrect

Re: [edk2] [Patch v4 2/3] UefiCpuPkg: Add Processor Trace feature definition.

2017-08-03 Thread Fan, Jeff
Reviewed-by: Jeff Fan -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Eric Dong Sent: Friday, August 04, 2017 11:37 AM To: edk2-devel@lists.01.org Cc: Ni, Ruiyu; Fan, Jeff Subject: [edk2] [Patch v4 2/3] UefiCpuPkg: Add

Re: [edk2] [Patch v4 1/3] UefiCpuPkg: Add Pcds used by processor trace feature.

2017-08-03 Thread Fan, Jeff
Reviewed-by: Jeff Fan -Original Message- From: Dong, Eric Sent: Friday, August 04, 2017 11:37 AM To: edk2-devel@lists.01.org Cc: Fan, Jeff; Ni, Ruiyu Subject: [Patch v4 1/3] UefiCpuPkg: Add Pcds used by processor trace feature. Cc: Jeff Fan Cc:

Re: [edk2] Issue of step by step debugging of OVMF SEC code in QEMU

2017-08-03 Thread wang xiaofeng
Hi Andrew, THe problem is solved, after the SEC code switch to protected mode, gdb can work well now At 2017-08-04 11:26:16, "wang xiaofeng" wrote: HI Andrew, How can I adjust the debugger to correct mode? Or I have to enable the debug after swtich to

[edk2] [Patch v4 3/3] UefiCpuPkg: Enable Processor Trace feature.

2017-08-03 Thread Eric Dong
Cc: Jeff Fan Cc: Ruiyu Ni Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Eric Dong --- .../CpuCommonFeaturesLib/CpuCommonFeatures.h | 66 +++ .../CpuCommonFeaturesLib/CpuCommonFeaturesLib.c| 11 +

[edk2] [Patch v4 0/3] Enable Processor Trace feature

2017-08-03 Thread Eric Dong
Enable processor trace feature. V2 update: 1. Add device capability check logic in Support function. 2. Correct the function comments. V3 update: 1. Get device capability in Suport function instead of GetConfigData function. V4 update: 1. Base on the global point to allocate buffer instead

[edk2] [Patch v4 1/3] UefiCpuPkg: Add Pcds used by processor trace feature.

2017-08-03 Thread Eric Dong
Cc: Jeff Fan Cc: Ruiyu Ni Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Eric Dong --- UefiCpuPkg/UefiCpuPkg.dec | 8 1 file changed, 8 insertions(+) diff --git a/UefiCpuPkg/UefiCpuPkg.dec

[edk2] [Patch v4 2/3] UefiCpuPkg: Add Processor Trace feature definition.

2017-08-03 Thread Eric Dong
Cc: Jeff Fan Cc: Ruiyu Ni Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Eric Dong --- UefiCpuPkg/Include/Library/RegisterCpuFeaturesLib.h | 1 + 1 file changed, 1 insertion(+) diff --git

Re: [edk2] Issue of step by step debugging of OVMF SEC code in QEMU

2017-08-03 Thread wang xiaofeng
HI Andrew, How can I adjust the debugger to correct mode? Or I have to enable the debug after swtich to protected mode? At 2017-08-04 10:57:16, "Andrew Fish" wrote: >The reset vector is 16-bit real mode, so you have the debugger in the wrong >mode. The code should

Re: [edk2] Issue of step by step debugging of OVMF SEC code in QEMU

2017-08-03 Thread Andrew Fish
The reset vector is 16-bit real mode, so you have the debugger in the wrong mode. The code should transition to 32 bit protected early in the flow. Sent from my iPhone > On Aug 3, 2017, at 7:47 PM, wang xiaofeng wrote: > > Hello, > I am tring to add my own SEC code

[edk2] Issue of step by step debugging of OVMF SEC code in QEMU

2017-08-03 Thread wang xiaofeng
Hello, I am tring to add my own SEC code base on OVMF and run on QEMU. Since the code cannot run I need to step to step trace the assembly code . The hang point is very early before I can use either UDK or debug serial output. I tried to use gdb to connect to QEMU.I start gdb in

Re: [edk2] [Patch V2 2/4] DuetPkg: Fix Xcode 9 Beta treating 32-bit left shift as undefined

2017-08-03 Thread Wu, Hao A
Reviewed-by: Hao Wu Best Regards, Hao Wu > -Original Message- > From: Zhu, Yonghong > Sent: Thursday, August 03, 2017 5:00 PM > To: edk2-devel@lists.01.org > Cc: Ni, Ruiyu; Wu, Hao A; Andrew Fish > Subject: [Patch V2 2/4] DuetPkg: Fix Xcode 9 Beta treating 32-bit

[edk2] [PATCH v3 0/1] Use BusMasterCommonBuffer to map FW_CFG_DMA_ACCESS

2017-08-03 Thread Brijesh Singh
The patch applies on top of Laszlo's IoMmuDxe cleanup series [1]. Commit is also available at https://github.com/codomania/edk2/tree/qemufwcfg-sev [1] https://lists.01.org/pipermail/edk2-devel/2017-August/012808.html Changes since v2: * Changes to address v2 feedbacks. Changes since v1: * Drop

[edk2] [PATCH v3 1/1] OvmfPkg/QemuFwCfgLib: Use BusMasterCommonBuffer to map FW_CFG_DMA_ACCESS

2017-08-03 Thread Brijesh Singh
Commit 09719a01b11b (OvmfPkg/QemuFwCfgLib: Implement SEV internal function for Dxe phase) uses IOMMU protocol to allocate and free FW_CFG_DMA_ACCESS buffer when SEV is active. During initial commits we made assumption that IOMMU.AllocateBuffer() will provide PlainTextAddress (i.e C-bit cleared).

Re: [edk2] [PATCH v2 1/1] OvmfPkg : QemuFwCfgLib: Use BusMasterCommandBuffer to map FW_CFG_DMA_ACCESS

2017-08-03 Thread Laszlo Ersek
On 08/04/17 00:07, Brijesh Singh wrote: > Hi Laszlo, > > Thanks for the detail review, I will soon send v3 with all your feedback > addressed. I must admit that I have constant struggle with formating issues > in EDKII contributions. While browsing the code, several packages have > code and

Re: [edk2] [PATCH v2 1/1] OvmfPkg : QemuFwCfgLib: Use BusMasterCommandBuffer to map FW_CFG_DMA_ACCESS

2017-08-03 Thread Brijesh Singh
Hi Laszlo, Thanks for the detail review, I will soon send v3 with all your feedback addressed. I must admit that I have constant struggle with formating issues in EDKII contributions. While browsing the code, several packages have code and comment exceeding 79 char. But looking at your previous

Re: [edk2] Announcing the edk2-platforms master branch

2017-08-03 Thread Kinney, Michael D
Leif, Thanks for all the work on this! I have updated the default branch on edk2-platforms to be the master branch. Mike > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On > Behalf Of Leif Lindholm > Sent: Thursday, August 3, 2017 7:09 AM > To:

Re: [edk2] [PATCH v2 1/1] OvmfPkg : QemuFwCfgLib: Use BusMasterCommandBuffer to map FW_CFG_DMA_ACCESS

2017-08-03 Thread Laszlo Ersek
On 08/03/17 18:10, Brijesh Singh wrote: > Commit 09719a01b11b (OvmfPkg/QemuFwCfgLib: Implement SEV internal function > for Dxe phase) > uses IOMMU protocol to allocate and free FW_CFG_DMA_ACCESS buffer > when SEV is active. During initial commits we made assumption that > IOMMU.AllocateBuffer()

Re: [edk2] Building UDK2017 with VS2015 fails - please help

2017-08-03 Thread Kinney, Michael D
Tahnia, My guess is that you are not using NASM. It appears that InternalMemIsZeroBuffer is only implemented for NASM and not ASM. Which is a bug since building with ASM results in a missing function. Your tools_def.txt file is missing this statement. Please make sure this statement is

[edk2] [PATCH v3 1/2] MdePkg/BaseLib: Add IsNodeInList() function.

2017-08-03 Thread Marvin Häuser
This patch adds IsNodeInList() to BaseLib, which verifies the given Node is part of the doubly-linked List provided. V2: - Rename "List" to "FirstEntry" and "Node" to "SecondEntry" to clarify that "FirstEntry" does not need to be the doubly-linked list's head node. V3: - Remove ASSERTs

[edk2] [PATCH v3 2/2] MdePkg/BaseLib: Update internal LinkedList verifications.

2017-08-03 Thread Marvin Häuser
1) Replace InternalBaseLibIsNodeInList() with InternalBaseLibIsListValid(). - The verification whether Node is within the doubly-linked List is now done by IsNodeInList(). - Whether the list is valid is returned. 2) The comments within InsertHeadList() and InsertTailList() stated

Re: [edk2] [PATCH 05/11] ShellPkg/UefiShellLevel2CommandsLib: Remove unnecessary EFIAPI

2017-08-03 Thread Palmer, Thomas
Ruiyu, Sorry for replying to old patch, I was cleaning out some old sandboxes when I stumbled onto this issue. Why is EFIAPI removed from InternalCharToUpper in UefiShellLevel2CommandsLib.c? It is present in both BaseLibInternals.h and String.c. Without EFIAPI, GCC builds

[edk2] [RFC Patch 2/3] BaseTools/Scripts: Add python script to run a makefile

2017-08-03 Thread Michael D Kinney
Add the python script RunMakefile.py that can be used in a PREBUILD/POSTBUIILD action to invoke a makefile passing in context as makefile defines. The command line arguments passed into RunMakefile.py are converted to the following set of defines. * ACTIVE_PLATFORM * TARGET_ARCH * TOOL_CHAIN_TAG

[edk2] [RFC Patch 1/3] BaseTools/build: Expand PREBUILD/POSTBUILD DSC actions

2017-08-03 Thread Michael D Kinney
* Extend PREBUILD/POSTBUILD define values to support more than one argument. * Delay normalization of PREBUILD/POSTBUILD define values until all arguments in the define values can be processed. * Convert PREBUILD/POSTBUILD build define value arguments that are WORKSPACE or PACKAGES_PATH

[edk2] [RFC Patch 3/3] BaseTools/Scripts: Add sample makefile for use with RunMakefile.py

2017-08-03 Thread Michael D Kinney
Add sample makefile that can be used to test RunMakefile.py script and can also be used as a template to start a new PREBUILD/POSTBUILD makefile. Cc: Liming Gao Cc: Yonghong Zhu Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by:

[edk2] [RFC Patch 0/3] Expand PREBUILD/POSTBUILD actions

2017-08-03 Thread Michael D Kinney
A platform DSC file can provide PREBUILD and POSTBUILD actions in the [Defines] section of the DSC file. The EDK II DSC specification only allows a single argument for these two defines, which means the PREBUILD and POSTBUILD actions are limited to simple batch files, shell scripts, or

Re: [edk2] [PATCH v2 2/2] MdePkg/BaseLib: Update internal LinkedList verifications.

2017-08-03 Thread Gao, Liming
I have no preference. Please go ahead. > -Original Message- > From: Marvin H?user [mailto:marvin.haeu...@outlook.com] > Sent: Thursday, August 3, 2017 11:43 PM > To: edk2-devel@lists.01.org > Cc: Gao, Liming ; Kinney, Michael D > >

[edk2] [PATCH v2 1/1] OvmfPkg : QemuFwCfgLib: Use BusMasterCommandBuffer to map FW_CFG_DMA_ACCESS

2017-08-03 Thread Brijesh Singh
Commit 09719a01b11b (OvmfPkg/QemuFwCfgLib: Implement SEV internal function for Dxe phase) uses IOMMU protocol to allocate and free FW_CFG_DMA_ACCESS buffer when SEV is active. During initial commits we made assumption that IOMMU.AllocateBuffer() will provide PlainTextAddress (i.e C-bit cleared).

[edk2] [PATCH v2 0/1] OvmfPkg/QemuFwCfgLib: Use BusMasterCommandBuffer to map FW_CFG_DMA_ACCESS

2017-08-03 Thread Brijesh Singh
The patch applies on top of Laszlo's IoMmuDxe cleanup series [1]. Commit is also available at https://github.com/codomania/edk2/tree/qemufwcfg-sev [1] https://lists.01.org/pipermail/edk2-devel/2017-August/012808.html Changes since v1: * Drop Patch 1 through 3, they are covered by Laszlo's

Re: [edk2] [PATCH v2 2/2] MdePkg/BaseLib: Update internal LinkedList verifications.

2017-08-03 Thread Marvin H?user
Hey Liming, I noticed that and assumed that a second call is not going to hurt much (only used in DEBUG afterall). To work around that, the macro could be modified to either call IsNodeInList() or InternalBaseLibIsListValid() based on the PCD value, though one would have to know/check the PCD's

[edk2] [PATCH] BaseTools/edksetup.sh: fix invalid test for current working directory

2017-08-03 Thread Chris Ruffin
edksetup.sh implements a test that requires the current working directory to contain the edksetup.sh script. This test has the side effect of requiring the WORKSPACE to be set to the same directory as the edksetup.sh. In a multiple workspace configuration, it is required to be able to have a

Re: [edk2] [PATCH v2 2/2] MdePkg/BaseLib: Update internal LinkedList verifications.

2017-08-03 Thread Gao, Liming
Marvin: If PcdVerifyNodeInList is set TRUE, InternalBaseLibIsListValid() will be checked twice in two ASSERT(). In the original logic, InternalBaseLibIsListValid only runs once. Could we work out the same check logic? Thanks Liming > -Original Message- > From: edk2-devel

Re: [edk2] [PATCH 1/2] MdePkg: Add definition for SecHobData PPI

2017-08-03 Thread Gao, Liming
Reviewed-by: Liming Gao for this serials. > -Original Message- > From: Zeng, Star > Sent: Wednesday, August 2, 2017 6:37 PM > To: edk2-devel@lists.01.org > Cc: Zeng, Star ; Gao, Liming > Subject: [PATCH 1/2] MdePkg: Add

Re: [edk2] [PATCH] BaseTools/Conf: apply nasmb, asm16 build rule order

2017-08-03 Thread Gao, Liming
Reviewed-by: Liming Gao > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Chris > Ruffin > Sent: Thursday, August 3, 2017 4:30 AM > To: edk2-devel@lists.01.org > Subject: [edk2] [PATCH] BaseTools/Conf: apply nasmb, asm16

Re: [edk2] [PATCH] IntelFsp2Pkg: Delete useless external TempRamInitApi API

2017-08-03 Thread Gao, Liming
Jiewen: The change is in SecFspSecPlatformLibNull. This library instance provides the dummy function. It should not be used by any real FSP. We meet with the build issue with /WHOLEARCHIVE option. Because this library depends on the external TempRamInitApi(), but FspSecCoreS and FspSecCoreT

Re: [edk2] [PATCH 10/12] OvmfPkg/IoMmuDxe: implement in-place decryption/encryption for Map/Unmap

2017-08-03 Thread Laszlo Ersek
On 08/03/17 16:35, Brijesh Singh wrote: > Laszlo, > > One minor issue, I got compilation error with GCC48. > > /home/brijesh/codomania/edk2-new/edk2/OvmfPkg/IoMmuDxe/AmdSevIoMmu.c: In > function ‘IoMmuUnmap’: > /home/brijesh/codomania/edk2-new/edk2/OvmfPkg/IoMmuDxe/AmdSevIoMmu.c:408:25: > error:

Re: [edk2] [PATCH 10/12] OvmfPkg/IoMmuDxe: implement in-place decryption/encryption for Map/Unmap

2017-08-03 Thread Brijesh Singh
Laszlo, One minor issue, I got compilation error with GCC48. /home/brijesh/codomania/edk2-new/edk2/OvmfPkg/IoMmuDxe/AmdSevIoMmu.c: In function ‘IoMmuUnmap’: /home/brijesh/codomania/edk2-new/edk2/OvmfPkg/IoMmuDxe/AmdSevIoMmu.c:408:25: error: ‘CommonBufferHeader’ may be used uninitialized in

Re: [edk2] [PATCH 00/12] OvmfPkg/IoMmuDxe: cleanups and fixes

2017-08-03 Thread Laszlo Ersek
On 08/03/17 16:10, Brijesh Singh wrote: > Hi Laszlo, > > On 08/02/2017 04:24 PM, Laszlo Ersek wrote: >> This series is proposed as a replacement (or a replacement "basis") for >> patches #1 through #3 of Brijesh's series >> >>[PATCH v1 0/4] OvmfPkg : IoMmuDxe: BusMasterCommonBuffer support

Re: [edk2] [Patch v3 3/3] UefiCpuPkg: Enable Processor Trace feature.

2017-08-03 Thread Fan, Jeff
Eric, Typo: " Protected Processor Inventory Number" should be " Intel Processor Trace " + @param[in] StateIf TRUE, then the Protected Processor Inventory + Number feature must be enabled. + If FALSE, then the Protected

Re: [edk2] [Patch 1/3] UefiCpuPkg: Add definition for LMCE feature.

2017-08-03 Thread Fan, Jeff
Reviewed-by: Jeff Fan -Original Message- From: Dong, Eric Sent: Tuesday, August 01, 2017 3:51 PM To: edk2-devel@lists.01.org Cc: Fan, Jeff; Ni, Ruiyu Subject: [Patch 1/3] UefiCpuPkg: Add definition for LMCE feature. Cc: Jeff Fan Cc: Ruiyu Ni

Re: [edk2] [Patch 3/3] UefiCpuPkg PiSmmCpuDxeSmm: Check LMCE capability when wait for AP.

2017-08-03 Thread Fan, Jeff
Reviewed-by: Jeff Fan -Original Message- From: Dong, Eric Sent: Tuesday, August 01, 2017 3:51 PM To: edk2-devel@lists.01.org Cc: Fan, Jeff; Ni, Ruiyu Subject: [Patch 3/3] UefiCpuPkg PiSmmCpuDxeSmm: Check LMCE capability when wait for AP. Cc: Jeff Fan

Re: [edk2] [PATCH 00/12] OvmfPkg/IoMmuDxe: cleanups and fixes

2017-08-03 Thread Brijesh Singh
Hi Laszlo, On 08/02/2017 04:24 PM, Laszlo Ersek wrote: This series is proposed as a replacement (or a replacement "basis") for patches #1 through #3 of Brijesh's series [PATCH v1 0/4] OvmfPkg : IoMmuDxe: BusMasterCommonBuffer support when SEV is active

Re: [edk2] [Patch 2/3] UefiCpuPkg CpuCommonFeaturesLib: Enable LMCE feature.

2017-08-03 Thread Fan, Jeff
Eric, Typo: " Protected Processor Inventory Number" should be " Local machine check exception " + @param[in] StateIf TRUE, then the Protected Processor Inventory + Number feature must be enabled. + If FALSE, then the

[edk2] Announcing the edk2-platforms master branch

2017-08-03 Thread Leif Lindholm
Hi all, A little over two years ago, I set up OpenPlatformPkg [1] as a way to prototype a single source tree for multiple platforms, built against edk2. Last year, we finalised the rules for how such a tree could be integrated into the edk2-platforms [2] repository, and I have now completed the

Re: [edk2] [Patch v3 3/3] UefiCpuPkg: Enable Processor Trace feature.

2017-08-03 Thread Fan, Jeff
Eric, In ProcTraceInitialize(), we cannot assume ProcessorNumber 0 is always BSP. + if (ProcessorNumber == 0) { +IsBsp = TRUE; The recommended method is to allocate memory in ProcTraceGetConfigData(). Or add one buffer point in ConfigData structure. If buffer point is NULL, allocate

Re: [edk2] [PATCH] UefiCpuPkg/Msr: Add a missing IvyBridge processor signature

2017-08-03 Thread Dong, Eric
Reviewed-by: Eric Dong -Original Message- From: Wu, Hao A Sent: Wednesday, August 2, 2017 4:30 PM To: edk2-devel@lists.01.org Cc: Wu, Hao A ; Dong, Eric ; Fan, Jeff Subject: [PATCH] UefiCpuPkg/Msr: Add a

Re: [edk2] [PATCH] IntelFsp2Pkg: Delete useless external TempRamInitApi API

2017-08-03 Thread Yao, Jiewen
Hi May I know what test you have done to remove this? Have you built a real FSP and boot it with FSP Wrapper? Thank you Yao Jiewen > -Original Message- > From: Song, BinX > Sent: Thursday, August 3, 2017 1:47 PM > To: edk2-devel@lists.01.org > Cc: Yao, Jiewen ;

Re: [edk2] [Patch 4/7] QuarkSocPkg MtrrLib: Remove reference deprecated macro.

2017-08-03 Thread Ni, Ruiyu
Eric, Please refer to the below code sample to avoid defining local macros. MSR_IA32_MTRR_DEF_TYPE_REGISTER DefType; // // Enable Cache MTRR // DefType.Uint64 = AsmReadMsr64 (MSR_IA32_MTRR_DEF_TYPE); DefType.Bits.E = 1; DefType.Bits.FE = 1; AsmWriteMsr64 (MSR_IA32_MTRR_DEF_TYPE,

[edk2] [Patch 0/7] Remove deprecated macro.

2017-08-03 Thread Eric Dong
Remove the deprecated macro and change code which use the macro. Eric Dong (7): QuarkSocPkg MtrrLib: Enhance get mtrr mask logic. Vlv2TbltDevicePkg: Enhance get mtrr mask logic. UefiCpuPkg CpuDxe: Enhance get mtrr mask logic. QuarkSocPkg MtrrLib: Remove reference deprecated macro.

[edk2] [Patch 7/7] UefiCpuPkg MtrrLib: Remove deprecated micro.

2017-08-03 Thread Eric Dong
Cc: Jeff Fan Cc: Ruiyu Ni Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Eric Dong --- UefiCpuPkg/Include/Library/MtrrLib.h | 27 --- 1 file changed, 27 deletions(-) diff --git

[edk2] [Patch 2/7] Vlv2TbltDevicePkg: Enhance get mtrr mask logic.

2017-08-03 Thread Eric Dong
In order to not use the deprecated macro, refine get mtrr mask value logic. Cc: Jeff Fan Cc: Ruiyu Ni Cc: David Wei Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Eric Dong ---

[edk2] [Patch 5/7] Vlv2TbltDevicePkg: Remove reference deprecated macro.

2017-08-03 Thread Eric Dong
Cc: Jeff Fan Cc: Ruiyu Ni Cc: David Wei Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Eric Dong --- Vlv2TbltDevicePkg/PlatformInitPei/MemoryPeim.c | 10 ++ 1 file changed, 6

[edk2] [Patch 4/7] QuarkSocPkg MtrrLib: Remove reference deprecated macro.

2017-08-03 Thread Eric Dong
Cc: Jeff Fan Cc: Ruiyu Ni Cc: Michael D Kinney Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Eric Dong --- .../QuarkNorthCluster/Library/MtrrLib/MtrrLib.c| 26

[edk2] [Patch 3/7] UefiCpuPkg CpuDxe: Enhance get mtrr mask logic.

2017-08-03 Thread Eric Dong
In order to not use the deprecated macro, refine get mtrr mask value logic. Cc: Jeff Fan Cc: Ruiyu Ni Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Eric Dong --- UefiCpuPkg/CpuDxe/CpuDxe.c | 13 ++---

[edk2] [Patch 6/7] UefiCpuPkg CpuDxe: Remove reference deprecated macro.

2017-08-03 Thread Eric Dong
Cc: Jeff Fan Cc: Ruiyu Ni Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Eric Dong --- UefiCpuPkg/CpuDxe/CpuDxe.c | 22 +++--- UefiCpuPkg/CpuDxe/CpuDxe.h | 1 + 2 files changed, 12

[edk2] [Patch][edk2-platforms/devel-MinnowBoard3-UDK2017] Enable source level debug.

2017-08-03 Thread zwei4
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: zwei4 --- Platform/BroxtonPlatformPkg/BuildBios.bat | 2 +- .../PlatformDsc/Components.IA32.dsc | 3 +++ .../BroxtonPlatformPkg/PlatformDsc/Components.dsc | 4

[edk2] [Patch V2 3/4] IntelFrameworkModulePkg: Fix Xcode 9 Beta treating 32-bit left shift as undefined

2017-08-03 Thread Yonghong Zhu
Bug: https://bugzilla.tianocore.org/show_bug.cgi?id=635 Cc: Liming Gao Cc: Michael D Kinney Cc: Jeff Fan Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Andrew Fish ---

[edk2] [Patch V2 4/4] MdePkg: Fix Xcode 9 Beta treating 32-bit left shift as undefined

2017-08-03 Thread Yonghong Zhu
Bug: https://bugzilla.tianocore.org/show_bug.cgi?id=635 Cc: Liming Gao Cc: Michael D Kinney Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Andrew Fish ---

[edk2] [Patch V2 2/4] DuetPkg: Fix Xcode 9 Beta treating 32-bit left shift as undefined

2017-08-03 Thread Yonghong Zhu
Bug: https://bugzilla.tianocore.org/show_bug.cgi?id=635 Cc: Ruiyu Ni Cc: Hao Wu Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Andrew Fish --- DuetPkg/EfiLdr/TianoDecompress.c | 6 +++--- 1 file changed, 3

[edk2] [Patch V2 1/4] BaseTools: Fix Xcode 9 Beta treating 32-bit left shift as undefined

2017-08-03 Thread Yonghong Zhu
Bug: https://bugzilla.tianocore.org/show_bug.cgi?id=635 Cc: Liming Gao Cc: Michael D Kinney Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Andrew Fish --- BaseTools/Source/C/Common/Decompress.c

[edk2] [Patch V2 0/4] Fix Xcode 9 Beta treating 32-bit left shift as undefined behavior

2017-08-03 Thread Yonghong Zhu
V2: Fix build MdeModulePkg failure by use LShiftU64() rather than << operator. Bug: https://bugzilla.tianocore.org/show_bug.cgi?id=635 Yonghong Zhu (4): BaseTools: Fix Xcode 9 Beta treating 32-bit left shift as undefined DuetPkg: Fix Xcode 9 Beta treating 32-bit left shift as undefined

Re: [edk2] [Patch] NetworkPkg/HttpDxe: Support HTTP Patch method

2017-08-03 Thread Ye, Ting
Reviewed-by: Ye Ting -Original Message- From: Wu, Jiaxin Sent: Wednesday, August 02, 2017 4:01 PM To: edk2-devel@lists.01.org Cc: Ye, Ting ; Fu, Siyuan ; Wu, Jiaxin Subject: [Patch] NetworkPkg/HttpDxe:

Re: [edk2] [Patch] NetworkPkg: iSCSI should allow to set 6 or 12 length of ISID keyword.

2017-08-03 Thread Fu, Siyuan
Ting, Thanks, I will update it when commit the patch. Siyuan -Original Message- From: Ye, Ting Sent: Thursday, August 3, 2017 4:37 PM To: Fu, Siyuan ; edk2-devel@lists.01.org Cc: Wu, Jiaxin Subject: RE: [edk2] [Patch] NetworkPkg: iSCSI should

Re: [edk2] [Patch] NetworkPkg: iSCSI should allow to set 6 or 12 length of ISID keyword.

2017-08-03 Thread Ye, Ting
Hi Siyuan, I would suggest to add more info to below error message, such as below: Error! Only last 3 bytes are configurable, please input 6 hex numbers for last 3 bytes only or 12 hex numbers for full SSID! + L"Error! Only last 3 bytes are configurable, please input 6 or 12 hex

Re: [edk2] [Patch] NetworkPkg: Display HTTP redirection info to the screen if need.

2017-08-03 Thread Ye, Ting
Reviewed-by: Ye Ting -Original Message- From: Fu, Siyuan Sent: Thursday, July 27, 2017 11:44 AM To: edk2-devel@lists.01.org Cc: Ye, Ting ; Wu, Jiaxin Subject: [Patch] NetworkPkg: Display HTTP redirection info to the screen if

[edk2] [Patch] NetworkPkg: iSCSI should allow to set 6 or 12 length of ISID keyword.

2017-08-03 Thread Fu Siyuan
The last 3 bytes of ISID should be able to changed by setting the keyword with a value with length 6 (only last 3 bytes) or 12 (full ISID) according to the keyword definition in UEFI configuration namespace website. Cc: Ye Ting Cc: Wu Jiaxin

[edk2] [PATCH v2] MdeModulePkg/DisplayEngine: Fix incorrect display issue

2017-08-03 Thread Dandan Bi
V2: Refine the codes to make the logic clear. In a form, some new menus may be dynamically inserted between highlight menu and previous top of screen menu when some question are refreshed. So the highlight menu and previous top of screen menu perhaps can't be shown in one page. Existing codes