Reviewed and tested it. Looks good to me. Thanks for addressing my offline
comment, Michael. :)
Reviewed-by: Sunny Wang
Regards,
Sunny Wang
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Michael
D Kinney
Sent: Tuesday, August 15, 2017 6:30 AM
Current code allocate buffer for the pointer which later get value
from PCD database. but current code error use "=" for this case.
Use AllocateCopyPool instead to fix it.
V2 enhanced to directly use AllocateCopyPool to get the PCD value.
Cc: Ruiyu Ni
Cc: Shao Ming
Contributed-under: TianoCore
How about to use AllocateCopyPool()?
Thanks/Ray
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Eric Dong
> Sent: Tuesday, August 15, 2017 1:32 PM
> To: edk2-devel@lists.01.org
> Cc: Ni, Ruiyu ; Shao, Ming ;
> s...@ml01.01.org
> Subject: [ed
UefiCpuLib inf file reference itself in [LibraryClasses]
section, this is not necessary. This patch remove it.
Cc: Ruiyu Ni
Cc: Ming Shao
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Eric Dong
---
UefiCpuPkg/Library/BaseUefiCpuLib/BaseUefiCpuLib.inf | 6 +-
1 file
Current debug message when enable/disable CPU feature not
correct. This patch enhances it to make it more accurate.
Cc: Ruiyu Ni
Cc: Shao, Ming
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Eric Dong
---
UefiCpuPkg/Library/RegisterCpuFeaturesLib/CpuFeaturesInitialize.c
Current code allocate buffer for the pointer which later get value
from PCD database. but current code error use "=" for this case.
Use CopyMem instead to fix it.
Cc: Ruiyu Ni
Cc: Shao, Ming
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Eric Dong
---
UefiCpuPkg/Library
Update the POSTBUILD step that creates the installer for the
test framework to use a python script. This expands the OS
compatibility to include Windows, Linux, and Mac OS X.
Cc: Andrew Fish
Cc: Supreeth Venkatesh
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Michael Ki
Update the DSC files to improve debug of the TestFrameworkPkg
and TestCasePkg.
* If -b DEBUG build, then enable DEBUG() messages on the standard
error console device with messages of type DEBUG_ERROR,
DEBUG_VERBOSE, DEBUG_INFO, DEBUG_WARN, and DEBUG_INIT enabled.
* If -b DEBUG build, then enab
The patch is a bug fix for TestFrameworkPkg/Support/TestProfile
driver. AsciiStrCpy() function was used to copy overlapping
strings, which triggered an ASSERT().
The function was used on overlapping strings in a couple of places:
1. _alltrim(): AsciiStrCpy() is replaced with CopyMem(), which can
New in V2
* Update the DSC files to improve debug of the TestFrameworkPkg
and TestCasePkg.
The patch is a bug fix for TestFrameworkPkg/Support/TestProfile
driver. AsciiStrCpy() function was used to copy overlapping
strings, which triggered an ASSERT().
Cc: Andrew Fish
Cc: Michael Kinney
Contr
Add one sample case about how to use HiiPopup protocol
to draw message box.
Cc: Eric Dong
Cc: Liming Gao
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Dandan Bi
---
.../Universal/DriverSampleDxe/DriverSample.c | 29 ++
.../Universal/DriverSamp
Patch 1: Add the definition of HII Popup Protocol.
Patch 2: Add the implementation of HII Popup Protocol.
Patch 3: Add one sample use case of HII Popup Protocol.
Cc: Eric Dong
Cc: Liming Gao
Dandan Bi (3):
MdePkg/HiiPopup: Add HII Popup Protocol definitions
MdeModulePkg/DisplayEngine: Add im
Add the implementation of HiiPopup protocol in DisplayEngineDxe,
since DisplayEngineDxe is responsible for drawing tasks.
Cc: Eric Dong
Cc: Liming Gao
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Dandan Bi
---
.../DisplayEngineDxe/DisplayEngineDxe.inf | 4 +
Add definitions for HII Popup Protocol according to UEFI2.7.
Cc: Eric Dong
Cc: Liming Gao
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Dandan Bi
---
MdePkg/Include/Protocol/HiiPopup.h | 81 ++
MdePkg/MdePkg.dec | 3
Reviewed-by: Ruiyu Ni
Thanks/Ray
> -Original Message-
> From: Kinney, Michael D
> Sent: Tuesday, August 15, 2017 6:30 AM
> To: edk2-devel@lists.01.org
> Cc: Ni, Ruiyu ; Wu, Hao A ;
> Kinney, Michael D
> Subject: [Patch] Nt32/PlatformBootManagerLib: Enable STD_ERROR on all
> consoles
>
Add STD_ERROR flag to all output consoles that the Nt32
platform supports so all messages sent to the standard
error console device(s) are visible by default.
The Boot Maintenance Manager can be used to manually disable
standard error output to specific console devices.
UEFI Applications and UEFI
Hi Rafael,
It's certainly possible although not trivial.
One possible approach is DUET which can emulate UEFI environment on top of
the legacy BIOS. So you could have your legacy bootloader load DUET, which
would in turn load and boot the UEFI-compatible OS. This page may be of
use: http://www.rod
Hi Andrew.
Thanks a lot for the guidance!!
Rafael R. Machado
Em dom, 13 de ago de 2017 às 15:08, Andrew Fish escreveu:
> On Aug 13, 2017, at 6:07 AM, Rafael Machado <
> rafaelrodrigues.mach...@gmail.com> wrote:
>
> Thanks a lot Andrew and Rod. Your comments clarified a lot.
>
> Just onde last q
Reviewed-by: Cinnamon Shia
-Original Message-
From: Gao, Liming [mailto:liming@intel.com]
Sent: Monday, August 14, 2017 2:59 PM
To: Zeng, Star ; edk2-devel@lists.01.org
Cc: Ni, Ruiyu ; Shia, Cinnamon
Subject: RE: [PATCH 2/2] ShellPkg UefiDpLib: Init CustomCumulativeData.MinDur
Revi
Reviewed-by: Cinnamon Shia
-Original Message-
From: Gao, Liming [mailto:liming@intel.com]
Sent: Monday, August 14, 2017 2:59 PM
To: Zeng, Star ; edk2-devel@lists.01.org
Cc: Shia, Cinnamon
Subject: RE: [PATCH 1/2] PerformancePkg DP: Init CustomCumulativeData.MinDur
Reviewed-by: Limi
Cc: Michael D Kinney
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Star Zeng
---
Contributions.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Contributions.txt b/Contributions.txt
index bd2f11f407fa..3c2dc1cf86a3 100644
--- a/Contributions.txt
++
The Tx and Rx rings are accessed by both guest and hypervisor, allocate
the rings using newly added VirtIo->AllocateSharedPages() and map it with
BusMasterCommonBuffer so that it can be accessed by both guest and
hypervisor.
Cc: Ard Biesheuvel
Cc: Jordan Justen
Cc: Tom Lendacky
Cc: Laszlo Ersek
This feature indicates that the device is behind an IOMMU that translates
bus addresses from the device into physical addresses in memory. If this
feature bit is set to 0, then the device emits physical addresses which
are not translated further, even though an IOMMU may be present.
see [1] for mo
Update VirtioNetTransmit() to map the callers transmit buffer to a device
address and use the DeviceAddress in vring descriptors.
Since the transmit buffers are returned back to caller in
VirtioNetGetStatus() hence we maintain a simple list to map DeviceAddress
to HostAddress. The list is used for
A network packets are transmitted by placing then into a transmit queue,
each packet is preceded by a VIRTIO_1_0_NET_REQ header. VirtioNetInitTx(),
builds the header once and fills the vring descriptors with the system
physical address of header.
The patch uses VirtIo->AllocateSharedPages() to all
RxBuf is shared between guest and hypervisor, use AllocateSharedPages()
to allocate this memory region and map it with BusMasterCommonBuffer
operation so that it can be accessed by guest and hypervisor.
Cc: Ard Biesheuvel
Cc: Jordan Justen
Cc: Tom Lendacky
Cc: Laszlo Ersek
Contributed-under: T
The VirtioScsiPassThru(), programs the vring descriptor using the host
addresses pointed-by virtio-scsi request, response and memory that is
referenced inside the request and response header.
The patch uses newly introduced VIRTIO_DEVICE_PROTOCOL.MapSharedBuffer()
function to map system memory to
patch maps the host address to a device address for buffers (including
rings, device specifc request and response pointed by vring descriptor,
and any further memory reference by those request and response).
Cc: Ard Biesheuvel
Cc: Jordan Justen
Cc: Tom Lendacky
Cc: Laszlo Ersek
Contributed-und
The SynchronousRequest(), programs the vring descriptor with the buffers
pointed-by virtio-blk requests, status and memory that is referenced
inside the request header.
The patch uses VIRTIO_DEVICE_PROTOCOL.MapSharedBuffer() function to map
host address to device address and programs the vring des
Cc: Ard Biesheuvel
Cc: Jordan Justen
Cc: Tom Lendacky
Cc: Laszlo Ersek
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Brijesh Singh
---
OvmfPkg/Library/VirtioLib/VirtioLib.c | 14 +++---
1 file changed, 11 insertions(+), 3 deletions(-)
diff --git a/OvmfPkg/Lib
Cc: Ard Biesheuvel
Cc: Jordan Justen
Cc: Tom Lendacky
Cc: Laszlo Ersek
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Brijesh Singh
---
OvmfPkg/VirtioPciDeviceDxe/VirtioPciDevice.h| 24 ++--
OvmfPkg/VirtioPciDeviceDxe/VirtioPciFunctions.c | 24 +
VirtioRingMap() maps the ring buffer system physical to a bus address.
When an IOMMU is used for translating the address then bus address can
start at a different offset from the system physical address.
- MMIO and legacy virtio device does not use IOMMU to translate the
addresses hence RingBase
virtio drivers uses VirtioRingMap() to map the ring buffer host address
to a device address. If an IOMMU is present then RingBaseShift contains
the offset from the host address.
Suggested-by: Laszlo Ersek
Cc: Ard Biesheuvel
Cc: Jordan Justen
Cc: Tom Lendacky
Cc: Laszlo Ersek
Contributed-under
Suggested-by: Laszlo Ersek
Cc: Ard Biesheuvel
Cc: Jordan Justen
Cc: Tom Lendacky
Cc: Laszlo Ersek
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Brijesh Singh
---
OvmfPkg/VirtioPciDeviceDxe/VirtioPciDevice.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
di
Add functions to map and unmap the ring buffer with BusMasterCommonBuffer
so that ring can be accessed by both guest and hypervisor.
Cc: Ard Biesheuvel
Cc: Jordan Justen
Cc: Tom Lendacky
Cc: Laszlo Ersek
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Brijesh Singh
---
Cc: Ard Biesheuvel
Cc: Jordan Justen
Cc: Tom Lendacky
Cc: Laszlo Ersek
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Brijesh Singh
---
OvmfPkg/Include/Protocol/VirtioDevice.h | 22 +---
1 file changed, 14 insertions(+), 8 deletions(-)
diff --git a/Ovm
The patch extends VIRTIO_DEVICE_PROTOCOL to provide the following new
member functions:
- AllocateSharedPages : allocate a memory region suitable for sharing
between guest and hypervisor (e.g ring buffer).
- FreeSharedPages: free the memory allocated using AllocateSharedPages ().
- MapSharedB
Passing the VirtIo protocol instance will allow the vring to use
VIRTIO_DEVICE_PROTOCOL.AllocateSharedPages () to allocate vring buffer.
Cc: Ard Biesheuvel
Cc: Jordan Justen
Cc: Tom Lendacky
Cc: Laszlo Ersek
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Brijesh Singh
The function can be used for mapping the system physical address to virtio
device address using VIRTIO_DEVICE_PROTOCOL.MapSharedBuffer (). The
function helps centralizing error handling, and it allows caller to pass
in constant or other evaluated expression for NumberOfBytes.
Cc: Ard Biesheuvel
C
The patch implements the newly added IOMMU-like member functions by
respectively delegating the job to:
- VIRTIO_DEVICE_PROTOCOL.AllocateSharedPages() ->
EFI_PCI_IO_PROTOCOL.AllocateBuffer()
- VIRTIO_DEVICE_PROTOCOL.FreeSharedPages() ->
EFI_PCI_IO_PROTOCOL.FreeBuffer()
- VIRTIO_DEVICE_PR
The patch implements the newly added IOMMU-like member functions by
respectively delegating the job to:
- VIRTIO_DEVICE_PROTOCOL.AllocateSharedPages () ->
MemoryAllocationLib.AllocatePages()
- VIRTIO_DEVICE_PROTOCOL.FreeSharedPages () ->
MemoryAllocationLib.FreePages ()
- VIRTIO_DEVICE_P
Suggested-by: Laszlo Ersek
Cc: Ard Biesheuvel
Cc: Jordan Justen
Cc: Tom Lendacky
Cc: Laszlo Ersek
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Brijesh Singh
---
OvmfPkg/Virtio10Dxe/Virtio10.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/OvmfPk
The patch implements the newly added IOMMU-like member functions by
respectively delegating the job to:
- VIRTIO_DEVICE_PROTOCOL.AllocateSharedPages () ->
MemoryAllocationLib.AllocatePages()
- VIRTIO_DEVICE_PROTOCOL.FreeSharedPages () ->
MemoryAllocationLib.FreePages ()
- VIRTIO_DEVICE_P
Currently, virtio drivers provides the system physical address to the device.
However, some systems may feature an IOMMU that requires the drivers to pass
the device addresses to the device - which are then translated by the IOMMU
into physical addresses in memory. The patch series introduces new
Cc: Ard Biesheuvel
Cc: Jordan Justen
Cc: Tom Lendacky
Cc: Laszlo Ersek
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Brijesh Singh
---
OvmfPkg/Library/VirtioMmioDeviceLib/VirtioMmioDevice.h | 28
++--
OvmfPkg/Library/VirtioMmioDeviceLib/Virti
On Thu, 10 Aug 2017 00:13:57 +0200
Laszlo Ersek wrote:
> On 08/09/17 22:47, Rebecca Cran wrote:
> > I've been investigating adding support for Qemu's nvdimm devices to
> > OVMF. I was thinking such support would go into PlatformPei, but it
> > looks like I can only read the ACPI NFIT in the DXE
In PI 1.5 version, system management mode name(SMM) has been changed
to Management Mode(MM). It impacts the current code which still use
SMM/Smram/SMI keywords. This patch add new definition which use
MM/MmRam/MMI keywords to follow new spec definitions.
Cc: Michael D Kinney
Cc: Liming Gao
Contr
After update current code to follow new spec definition(rename SMM
to MM), update code for current SMM related definitions to keep
compatibility.
Whether keep current definition or use typedef/#define to reference
new add definition (added by former patch) are based on the structure
name or functi
In PI spec 1.5, System Management Mode name has been changed to Management
mode, it also change all SMM related driver name to avoid use SMI/SmRam/SMM
keywords.
This patch series add new definition which use Management mode nomenclature.
Also in order to maintain continuity, this patch also use
Add valid/default values for PCD PcdCpuProcTraceMemSize and
PcdCpuProcTraceOutputScheme in the comment part.
Cc: Liming Gao
Cc: Ruiyu Ni
Cc: Michael D Kinney
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Eric Dong
---
UefiCpuPkg/UefiCpuPkg.dec | 28 +++
Add prompt/help string for pcd PcdCpuProcTraceOutputScheme
and PcdCpuProcTraceMemSize in UefiCpuPkg.uni file.
Cc: Liming Gao
Cc: Ruiyu Ni
Cc: Michael D Kinney
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Eric Dong
---
UefiCpuPkg/UefiCpuPkg.uni | 30 ++
v2 changes includes: Add valid values and prompt/help string for new
add pcd PcdCpuProcTraceMemSize and PcdCpuProcTraceOutputScheme.
v3 changes includes: Add comments for default values for new
added pcd PcdCpuProcTraceMemSize and PcdCpuProcTraceOutputScheme.
Also update the help string in the .
Reviewed-by: Liming Gao
>-Original Message-
>From: Zhu, Yonghong
>Sent: Monday, August 07, 2017 12:00 PM
>To: edk2-devel@lists.01.org
>Cc: Gao, Liming ; Kinney, Michael D
>; Andrew Fish
>Subject: [Patch] BaseTools: Fix Segmentation fault: 11 when build AppPkg
>with XCODE5
>
>it is a bug
Reviewed-by: Liming Gao
>-Original Message-
>From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Star
>Zeng
>Sent: Friday, August 11, 2017 11:35 AM
>To: edk2-devel@lists.01.org
>Cc: Zeng, Star
>Subject: [edk2] [PATCH 0/2] DxeCore: Fix double free pages on LoadImage
>fa
54 matches
Mail list logo
