Re: [edk2] meaning of EFI_ABSOLUTE_POINTER_PROTOCOL axis values

2017-08-21 Thread Ramesh R .
Hi Michael, The values are related to the display device resolution. Each Protocol has the EFI_ABSOLUTE_POINTER_MODE defined and it has the value of the actual screen hardware resolution ( not the current display resolution). The touched values are based screen hardware resolution. Thanks

[edk2] [Patch] BaseTools: Roll back GenFw Change to keep unknown field in RSDS debug entry

2017-08-21 Thread Liming Gao
https://lists.01.org/pipermail/edk2-devel/2017-August/013488.html These fields are actually a GUID and DWORD respectively: the GUID identifies the PDB to make it possible to verify that a given PDB matches the PE file, and the DWORD is the "age" of the PDB which is simply a helper value that is inc

Re: [edk2] latest basetools build pdb cannot be load by IDA6.95

2017-08-21 Thread Gao, Liming
Matthijs: Thanks for your detail explanation. I will send this patch to keep GUID and DWORD in RSDS entry. Thanks Liming >-Original Message- >From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of >Matthijs Lavrijsen >Sent: Tuesday, August 22, 2017 12:33 PM >To: Gao, Li

Re: [edk2] latest basetools build pdb cannot be load by IDA6.95

2017-08-21 Thread Matthijs Lavrijsen
I just compiled GenFw to verify this, and the issue is indeed caused by e4129b0e5897d76885170bec9da996b266f185f9. The problem is not with zeroing debug directories than the CodeView one, but setting the 'unknown' fields of the RSDS entry to zero. These fields are actually a GUID and DWORD respecti

Re: [edk2] latest basetools build pdb cannot be load by IDA6.95

2017-08-21 Thread Gao, Liming
Xiaofeng: Could you help verify the change in GenFw tool? You can refer to https://github.com/tianocore/tianocore.github.io/wiki/Windows-systems Compile Tools section to compile GenFw tool, and try it. Thanks Liming From: wang xiaofeng [mailto:winggundu...@163.com] Sent: Tuesday, August 22,

Re: [edk2] [PATCH v2 17/23] OvmfPkg/VirtioBlkDxe: map host address to device address

2017-08-21 Thread Brijesh Singh
On 8/21/17 10:24 AM, Laszlo Ersek wrote: [Snip]... > (25) I think you intended to add the empty line above the "ReleaseQueue" > label, not below it. > >>VirtioRingUninit (Dev->VirtIo, &Dev->Ring); >> >> Failed: > (26) You forgot to call UnmapSharedBuffer() in the VirtioBlkUninit() > func

Re: [edk2] [Patch 1/2] UefiCpuPkg: Add comments for PCDs definition.

2017-08-21 Thread Dong, Eric
Mike, I think you misuse PcdCpuFeaturesSetting for PcdCpuProcTraceMemSize, right? ProcTrace feature is checked by BIT44(CPU_FEATURE_PROC_TRACE) in PcdCpuFeaturesSetting. If you think define OutputSchemeInvalid is redundant and propose to remove it. I think we can also remove ProcTraceMemDisable

Re: [edk2] latest basetools build pdb cannot be load by IDA6.95

2017-08-21 Thread wang xiaofeng
Liming, Do you think we should roll back the change? I am not sure whether any source level debug tool will have the same issue with pdb information change. 在 2017-08-21 17:33:30,"wang xiaofeng" 写道: Liming, It should be the change that lead to IDA cannot load pdb. I just roll bac

Re: [edk2] [PATCH v2 18/23] OvmfPkg/VirtioScsiDxe: Use DeviceAddresses in vring descriptors

2017-08-21 Thread Laszlo Ersek
After all, I've taken a look here as well. I'm not going to point out all the earlier remarks (please do address them here anyway, because they certainly apply), I'll just say what I feel is specific to this patch: On 08/14/17 13:36, Brijesh Singh wrote: > The VirtioScsiPassThru(), programs the vr

Re: [edk2] [PATCH v2 edk2-platforms 0/3] Re-enable the second SATA controller on Overdrive

2017-08-21 Thread Leif Lindholm
On Mon, Aug 21, 2017 at 10:20:11AM -0400, Alan Ott wrote: > On 08/21/2017 10:12 AM, Leif Lindholm wrote: > > On Sun, Aug 20, 2017 at 03:33:32PM -0400, Alan Ott wrote: > > > Without the PCD for the second SATA Controller being specified, the boot > > > will hang. These patches fix it. > > > > Given

[edk2] meaning of EFI_ABSOLUTE_POINTER_PROTOCOL axis values

2017-08-21 Thread Michael Zimmermann
Do the axis-values returned by this protocol need to have any relation to the device's screen so I can reliably calculate which pixel was touched?(at least with the rule of three). If not every application using the touchscreen would have to provide it's own calibration tool and store the results

Re: [edk2] [PATCH v2 4/6] OvmfPkg: Enable UDF file system support

2017-08-21 Thread Laszlo Ersek
On 08/20/17 20:15, Paulo Alcantara wrote: > This patch enables UDF file system support by default. > > Cc: Jordan Justen > Cc: Laszlo Ersek > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Paulo Alcantara > --- > OvmfPkg/OvmfPkgIa32.dsc| 1 + > OvmfPkg/OvmfPkgIa32

Re: [edk2] [PATCH v2 5/6] ArmVirtPkg: Enable UDF file system support

2017-08-21 Thread Laszlo Ersek
On 08/20/17 20:15, Paulo Alcantara wrote: > This patch enables UDF file system support by default. > > Cc: Laszlo Ersek > Cc: Ard Biesheuvel > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Paulo Alcantara > --- > ArmVirtPkg/ArmVirtQemu.dsc | 3 ++- > ArmVir

Re: [edk2] [PATCH v2 23/23] OvmfPkg/Virtio: define VIRITO_F_IOMMU_PLATFORM feature bit

2017-08-21 Thread Laszlo Ersek
On 08/14/17 13:36, Brijesh Singh wrote: > This feature indicates that the device is behind an IOMMU that translates > bus addresses from the device into physical addresses in memory. If this > feature bit is set to 0, then the device emits physical addresses which > are not translated further, eve

Re: [edk2] [PATCH v2 5/6] ArmVirtPkg: Enable UDF file system support

2017-08-21 Thread Ard Biesheuvel
On 20 August 2017 at 19:15, Paulo Alcantara wrote: > This patch enables UDF file system support by default. > > Cc: Laszlo Ersek > Cc: Ard Biesheuvel > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Paulo Alcantara Reviewed-by: Ard Biesheuvel > --- > ArmVirtPkg/Arm

Re: [edk2] [PATCH v2 17/23] OvmfPkg/VirtioBlkDxe: map host address to device address

2017-08-21 Thread Laszlo Ersek
On 08/14/17 13:36, Brijesh Singh wrote: > The SynchronousRequest(), programs the vring descriptor with the buffers (1) you likely meant "The SynchronousRequest() function" > pointed-by virtio-blk requests, status and memory that is referenced > inside the request header. > > The patch uses VIRTI

[edk2] [PATCH edk2-platforms] Contributions.txt: update to latest version from EDK2

2017-08-21 Thread Leif Lindholm
Update to require TianoCore Contribution Agreement 1.1, taken from commmit fc9f971e9745 ("edk2: Fix typo in Contributions.txt") Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Leif Lindholm --- Contributions.txt | 93 +--

Re: [edk2] [PATCH v2 edk2-platforms 0/3] Re-enable the second SATA controller on Overdrive

2017-08-21 Thread Alan Ott
On 08/21/2017 10:12 AM, Leif Lindholm wrote: On Sun, Aug 20, 2017 at 03:33:32PM -0400, Alan Ott wrote: Without the PCD for the second SATA Controller being specified, the boot will hang. These patches fix it. Given Ard's RB, I'm happy for this to go in. However, would you be happy to contribut

Re: [edk2] [PATCH v2 edk2-platforms 0/3] Re-enable the second SATA controller on Overdrive

2017-08-21 Thread Leif Lindholm
On Sun, Aug 20, 2017 at 03:33:32PM -0400, Alan Ott wrote: > Without the PCD for the second SATA Controller being specified, the boot > will hang. These patches fix it. Given Ard's RB, I'm happy for this to go in. However, would you be happy to contribute these under TianoCore Contribution Agreemen

Re: [edk2] [PATCH v2 16/23] OvmfPkg/VirtioRngDxe: map host address to device address

2017-08-21 Thread Laszlo Ersek
On 08/14/17 13:36, Brijesh Singh wrote: > patch maps the host address to a device address for buffers (including > rings, device specifc request and response pointed by vring descriptor, > and any further memory reference by those request and response). > > Cc: Ard Biesheuvel > Cc: Jordan Justen

Re: [edk2] [PATCH V3] IntelFsp2Pkg: Fix build error with WHOLEARCHIVE option

2017-08-21 Thread Yao, Jiewen
Reviewed-by: jiewen@intel.com > -Original Message- > From: Song, BinX > Sent: Monday, August 21, 2017 4:45 PM > To: Yao, Jiewen > Cc: edk2-devel@lists.01.org > Subject: [PATCH V3] IntelFsp2Pkg: Fix build error with WHOLEARCHIVE option > > V3: > - Update dummy TempRamInitApi function

Re: [edk2] latest basetools build pdb cannot be load by IDA6.95

2017-08-21 Thread wang xiaofeng
Liming, It should be the change that lead to IDA cannot load pdb. I just roll back to previous GENFW and IDA can load pdb file now. At 2017-08-21 16:29:55, "Yao, Jiewen" wrote: >FYI: here is IDA https://www.hex-rays.com/products/ida/overview.shtml > >Thank you >Yao Jiewen > > >From:

[edk2] [PATCH V3] IntelFsp2Pkg: Fix build error with WHOLEARCHIVE option

2017-08-21 Thread Song, BinX
V3: - Update dummy TempRamInitApi function and remove unnecessary info V2: - Recover TempRamInitApi API and add dummy TempRamInitApi function to fix build error with WHOLEARCHIVE option V1: - Delete useless external TempRamInitApi API to fix /WHOLEARCHIVE build error Cc: Jiewen Yao Contribu

[edk2] [PATCH V3 3/3] MdeModulePkg/DriverSample: Add sample case for popup protocol

2017-08-21 Thread Dandan Bi
Add one sample case about how to use HiiPopup protocol to draw message box. Cc: Eric Dong Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi --- .../Universal/DriverSampleDxe/DriverSample.c | 29 ++ .../Universal/DriverSamp

[edk2] [PATCH V3 0/3] Add HII Popup Protocol

2017-08-21 Thread Dandan Bi
Patch 1: Add the definition of HII Popup Protocol. Patch 2: Add the implementation of HII Popup Protocol. Patch 3: Add one sample use case of HII Popup Protocol. V3: Updates in pacth 2: Separate DrawMessageBox() function into CalculatePopupPosition() DrawMessageBox() and GetUserSelection() three f

[edk2] [PATCH V3 1/3] MdePkg/HiiPopup: Add HII Popup Protocol definitions

2017-08-21 Thread Dandan Bi
Add definitions for HII Popup Protocol according to UEFI2.7. Cc: Eric Dong Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi --- MdePkg/Include/Protocol/HiiPopup.h | 81 ++ MdePkg/MdePkg.dec | 3

[edk2] [PATCH V3 2/3] MdeModulePkg/DisplayEngine: Add implementation of HiiPopup protocol

2017-08-21 Thread Dandan Bi
V3: Separate DrawMessageBox() function into CalculatePopupPosition() DrawMessageBox() and GetUserSelection() three functions and refine related codes. Add the implementation of HiiPopup protocol in DisplayEngineDxe, since DisplayEngineDxe is responsible for drawing tasks. Cc: Eric Dong Cc: Limin

Re: [edk2] latest basetools build pdb cannot be load by IDA6.95

2017-08-21 Thread Yao, Jiewen
FYI: here is IDA https://www.hex-rays.com/products/ida/overview.shtml Thank you Yao Jiewen From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Gao, Liming Sent: Monday, August 21, 2017 4:17 PM To: wang xiaofeng ; edk2-devel@lists.01.org Subject: Re: [edk2] latest basetools bu

Re: [edk2] [PATCH V2] IntelFsp2Pkg: Fix build error with WHOLEARCHIVE option

2017-08-21 Thread Song, BinX
Hi Jiewen, Yes, I will update. Best Regards, Bell Song > -Original Message- > From: Yao, Jiewen > Sent: Monday, August 21, 2017 4:26 PM > To: Song, BinX > Cc: edk2-devel@lists.01.org > Subject: RE: [PATCH V2] IntelFsp2Pkg: Fix build error with WHOLEARCHIVE > option > > Hi > Can we add

Re: [edk2] [PATCH V2] IntelFsp2Pkg: Fix build error with WHOLEARCHIVE option

2017-08-21 Thread Yao, Jiewen
Hi Can we add "JMP $" before ret for the empty function? It is to prevent the empty function is linked by mistake. Thank you Yao Jiewen > -Original Message- > From: Song, BinX > Sent: Monday, August 21, 2017 2:35 PM > To: Yao, Jiewen > Cc: edk2-devel@lists.01.org > Subject: [PATCH V2] I

Re: [edk2] [PATCH V2] IntelFsp2Pkg: Fix build error with WHOLEARCHIVE option

2017-08-21 Thread Song, BinX
Hi Liming, Got it, will update V3. Best Regards, Bell Song > -Original Message- > From: Gao, Liming > Sent: Monday, August 21, 2017 4:20 PM > To: Song, BinX ; Yao, Jiewen > Cc: edk2-devel@lists.01.org > Subject: RE: [PATCH V2] IntelFsp2Pkg: Fix build error with WHOLEARCHIVE > option >

Re: [edk2] [PATCH V2] IntelFsp2Pkg: Fix build error with WHOLEARCHIVE option

2017-08-21 Thread Gao, Liming
Bin: Please remove VS2015 from the comments in source files. Thanks Liming >-Original Message- >From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of >Song, BinX >Sent: Monday, August 21, 2017 2:35 PM >To: Yao, Jiewen >Cc: edk2-devel@lists.01.org >Subject: [edk2] [PATC

Re: [edk2] latest basetools build pdb cannot be load by IDA6.95

2017-08-21 Thread Gao, Liming
Xiaofeng: What is IDA? What message is required by it? Recently, I make the change in BaseTools to clear the unused field in DebugEntry to zero. It may impact IDA. Here is the change. Could you help identify whether this change cause IDA load issue? SHA-1: e4129b0e5897d76885170bec9da996b26