[edk2] [Patch][edk2-platforms/minnowboard-max-udk2017] Vlv2TbltDevicePkg: Enable signed capsule.

2017-09-15 Thread Guo, Mang
Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Guo Mang --- .../PlatformFlashAccessLib.c | 638 + .../PlatformFlashAccessLib.inf | 61 ++ .../SystemFirmwareDescriptor.acpi | Bin 0 -> 172 bytes

[edk2] [Patch][edk2-platforms/minnowboard-max-udk2017] Vlv2TbltDevicePkg: Changed value of PcdFlashAreaBaseAddress

2017-09-15 Thread Guo, Mang
The PCD PcdFlashAreaBaseAddress should be 0xFF80, but it's 0xFFC0 due to wrong value assignment in platform fdf. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Guo Mang --- Vlv2TbltDevicePkg/PlatformDxe/Platform.c | 8 Vlv2TbltDevicePkg/PlatformDxe/

Re: [edk2] PI 1.6 vs. edk2 - EfiGcdMemoryTypePersistent (EFI_GCD_MEMORY_TYPE)

2017-09-15 Thread Gao, Liming
Rebecca: Thanks for your catch issue. I will provide the patch to fix it. To be compatible, I will keep EfiGcdMemoryTypePersistent and EfiGcdMemoryTypePersistentMemory both. Thanks Liming > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of >

[edk2] [PATCH 2/4] IntelSiliconPkg/PlatformVTdSampleDxe: Move to feature dir.

2017-09-15 Thread Jiewen Yao
Move PlatformVTdSampleDxe to Feature/VTd/PlatformVTdSampleDxe. Suggested-by: Star Zeng Cc: Star Zeng Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jiewen Yao --- IntelSiliconPkg/Feature/VTd/PlatformVTdSampleDxe/PlatformVTdSampleDxe.c | 409

[edk2] [PATCH 0/4] IntelSiliconPkg: move VTd related modules to feature dir.

2017-09-15 Thread Jiewen Yao
This patch is to address the feedback from Star.Zeng during code review. We group 4 VTd related modules to Feature/VTd dir to better maintance. No code update, only location move. Suggested-by: Star Zeng Cc: Star Zeng Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jiewe

[edk2] [PATCH 4/4] IntelSiliconPkg/PlatformIntelVTdInfoSamplePei: Move to feature dir.

2017-09-15 Thread Jiewen Yao
Move PlatformIntelVTdInfoSamplePei to Feature/VTd/. Suggested-by: Star Zeng Cc: Star Zeng Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jiewen Yao --- IntelSiliconPkg/Feature/VTd/PlatformVTdInfoSamplePei/PlatformVTdInfoSamplePei.c | 65 I

[edk2] [PATCH 3/4] IntelSiliconPkg/IntelVTdPmrPei: Move to feature dir.

2017-09-15 Thread Jiewen Yao
Move IntelVTdPmrPei to Feature/VTd/IntelVTdPmrPei. Suggested-by: Star Zeng Cc: Star Zeng Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jiewen Yao --- IntelSiliconPkg/Feature/VTd/IntelVTdPmrPei/IntelVTdPmr.c | 314 ++ IntelSiliconPkg/Feature/VTd/Intel

Re: [edk2] [PATCH] Fix not able to change serial attributes

2017-09-15 Thread Zeng, Star
Pankaj, Thanks for the contribution. Could you help update the title to be like MdeModulePkg SerialDxe: XX? In fact, I agree the fix as it matches the code at MdeModulePkg/Bus/Pci/PciSioSerialDxe/SerialIo.c and IntelFrameworkModulePkg/Bus/Isa/IsaSerialDxe/Serial.c. But I am curious abou

Re: [edk2] Functionality issues in UDF support

2017-09-15 Thread Yao, Jiewen
Hi Laszlo/Ruiyu/Star I went through the whole conversation and have some thought: For staging, I quote the description from https://github.com/tianocore/edk2-staging I think UDF matches all below criteria. "edk2 required quality criteria" is the key. We have lots of features there - such as St

Re: [edk2] Functionality issues in UDF support

2017-09-15 Thread Yao, Jiewen
Hi Laszlo and Ruiyu I can think 1 possible alternative, for your consideration only. 1) Move the feature to OvmfPkg. As such, it won't block us at this moment. Once the UDF solution has good quality, we can move it back to MdeModulePkg. Thank you Yao Jiewen From: Laszlo Ersek [mailto:ler

[edk2] [PATCH] BaseTools/tools_def AARCH64: enable frame pointers for RELEASE builds

2017-09-15 Thread Ard Biesheuvel
Commit 8f0b62a5dac0 ("BaseTools/tools_def AARCH64: enable frame pointers for DEBUG builds") removed the -fomit-frame-pointer switch from the shared CFLAGS between AARCH64 DEBUG and RELEASE build, and move it to the RELEASE specific ones, so that DEBUG builds can produce a backtrace when a crash occ

[edk2] [PATCH v2] ArmPkg/PlatformBootManagerLib: process pending capsules

2017-09-15 Thread Ard Biesheuvel
Process any capsule HOBs that were left for us by CapsulePei. This involves calling ProcessCapsules() twice, as explained in the comment in DxeCapsuleLibFmp [sic]. 1) The first call must be before EndOfDxe. The system capsules is processed. If device capsule FMP protocols are exposted at this t

Re: [edk2] [PATCH] RFC Inform UEFI memory to Linux

2017-09-15 Thread Ard Biesheuvel
On 15 September 2017 at 03:13, Leif Lindholm wrote: > On Fri, Sep 15, 2017 at 08:02:34PM +0530, Meenakshi Aggarwal wrote: >> From: Udit Kumar >> >> While creating Hob list, ArmPlatformPkg is hiding UEFI memory. >> whereas this memory can be used by OS. >> >> This patch, allows OS to use UEFI code

Re: [edk2] [PATCH 0/7] MdeModulePkg/Udf: Code refinements

2017-09-15 Thread Paulo Alcantara
Hi Hao, On 15/09/2017 01:57, Hao Wu wrote: The series introduces the following code refinements for UdfDxe & PartitionDxe: a. Add checks to ensure no possible NULL pointer dereference b. Reslove operands of different size in bitwise operations c. Use compare operator for non-boolean comparisons

[edk2] PI 1.6 vs. edk2 - EfiGcdMemoryTypePersistent (EFI_GCD_MEMORY_TYPE)

2017-09-15 Thread Rebecca Cran
I've noticed an inconsistency between the PI 1.6 specification and the edk2 implementation of EFI_GCD_MEMORY_TYPE: PI says it's EfiGcdMemoryTypePersistent while Pi/PiDxeCis.h has EfiGcdMemoryTypePersistentMemory. Since the EfiGcdMemoryTypePersistent is mentioned several times in the spec I'm

Re: [edk2] Functionality issues in UDF support

2017-09-15 Thread Laszlo Ersek
On 09/15/17 18:40, Ni, Ruiyu wrote: > Laszlo, > Please do not add a PCD for this. Too many PCDs are no good to the project. I understand that new MdeModulePkg PCDs are not liked, but what do you propose instead? If we simply revert the PartitionDxe changes, then people that want to experiment with

Re: [edk2] Functionality issues in UDF support

2017-09-15 Thread Laszlo Ersek
On 09/15/17 18:27, Paulo Alcantara wrote: > Laszlo, > > On 15/09/2017 12:51, Laszlo Ersek wrote: >> On 09/15/17 09:38, Ni, Ruiyu wrote: >>> Paulo, >>> Supporting multiple LVDs can be considered as a long-term task, or >>> can be added >>> per request. >>> But I think a urgent fix in PartitionDxe d

Re: [edk2] Functionality issues in UDF support

2017-09-15 Thread Ni, Ruiyu
Laszlo, Please do not add a PCD for this. Too many PCDs are no good to the project. 发自我的 iPhone > 在 2017年9月16日,上午12:27,Paulo Alcantara 写道: > > Laszlo, > >> On 15/09/2017 12:51, Laszlo Ersek wrote: >>> On 09/15/17 09:38, Ni, Ruiyu wrote: >>> Paulo, >>> Supporting multiple LVDs can be considered

Re: [edk2] Functionality issues in UDF support

2017-09-15 Thread Paulo Alcantara
Laszlo, On 15/09/2017 12:51, Laszlo Ersek wrote: On 09/15/17 09:38, Ni, Ruiyu wrote: Paulo, Supporting multiple LVDs can be considered as a long-term task, or can be added per request. But I think a urgent fix in PartitionDxe driver is to: 1. create child BLK only for the portion covered by the

Re: [edk2] [PATCH] ArmPkg/PlatformBootManagerLib: process pending capsules

2017-09-15 Thread Ard Biesheuvel
On 15 September 2017 at 09:22, Leif Lindholm wrote: > On Mon, Sep 11, 2017 at 05:50:29PM +0100, Ard Biesheuvel wrote: >> Process any capsule HOBs that were left for us by CapsulePei. This >> involves calling ProcessCapsules() twice, as explained in the comment >> in DxeCapsuleLibFmp [sic]. >> >> 1

Re: [edk2] [PATCH] ArmPkg/PlatformBootManagerLib: process pending capsules

2017-09-15 Thread Leif Lindholm
On Mon, Sep 11, 2017 at 05:50:29PM +0100, Ard Biesheuvel wrote: > Process any capsule HOBs that were left for us by CapsulePei. This > involves calling ProcessCapsules() twice, as explained in the comment > in DxeCapsuleLibFmp [sic]. > > 1) The first call must be before EndOfDxe. The system capsul

Re: [edk2] [PATCH] ArmPkg: ARM v8.2 updates for detecting FP

2017-09-15 Thread Leif Lindholm
On Thu, Sep 14, 2017 at 05:11:21PM +0100, evan.ll...@arm.com wrote: > From: Sami Mujawar I have fixed Sami's email address up before pushing. > The ARMv8.2-FP16 extension introduces support for half precision > floating point and the processor ID registers have been updated to > enable detection

Re: [edk2] Functionality issues in UDF support

2017-09-15 Thread Laszlo Ersek
On 09/15/17 09:38, Ni, Ruiyu wrote: > Paulo, > Supporting multiple LVDs can be considered as a long-term task, or can be > added > per request. > But I think a urgent fix in PartitionDxe driver is to: > 1. create child BLK only for the portion covered by the LVD > 2. Do not create child BLK for LV

Re: [edk2] [PATCH v1] MdePkg: Add definitions for the SPI protocols introduced in UEFI PI 1.6.

2017-09-15 Thread Marvin Häuser
Hey Dandan, Sorry for the mistakes, I will send them a part of a V2 once you finished reviewing. No problem for the delay, it's not high priority at all. Thanks for reviewing it! There are problems within the specification regarding the SPI protocols anyway. I wanted to report these, though I d

Re: [edk2] [PATCH] MdeModulePkg/UdfDxe: Remove negative comparison of unsigned number

2017-09-15 Thread Laszlo Ersek
On 09/15/17 15:02, Ni, Ruiyu wrote: > Agree with most of your words. > Build farm is very needed for this case. > > But as I said in another mail, there is a bug (#707) in current implementation > and I expect it to be fixed ASAP. Our QA is complaining! I'm looking into it. Laszlo __

Re: [edk2] [PATCH 0/2] Options to remove code

2017-09-15 Thread Leif Lindholm
Hi Evan, On Wed, Sep 13, 2017 at 07:16:19PM +0100, evan.ll...@arm.com wrote: > From: EvanLloyd > > There are a number of cases where it is desirable to remove unused code. > An obvious instance might be on an emulator, where executing irrelevant > code can add hours to the boot time. This chang

Re: [edk2] [PATCH] MdeModulePkg/UdfDxe: Remove negative comparison of unsigned number

2017-09-15 Thread Zeng, Star
Really thanks for the contribution (by using your free time). :) Please help take care the issue raised at https://lists.01.org/pipermail/edk2-devel/2017-September/014694.html and https://bugzilla.tianocore.org/show_bug.cgi?id=707 with high priority, and also the review request at https://lists

Re: [edk2] [PATCH] MdeModulePkg/UdfDxe: Remove negative comparison of unsigned number

2017-09-15 Thread Zeng, Star
Basically, people are totally encouraged and welcome to contribute, no one can make sure his/her patch will never break anything. I want to emphasize I was not challenging the code/people. Staging branch does not mean it is unmaintained, here I do not want to argue the position of Staging branch

Re: [edk2] [PATCH 2/2] OvmfPkg/VirtioNetDxe: log debug message in VirtioNetExitBoot()

2017-09-15 Thread Brijesh Singh
On 09/15/2017 03:57 AM, Laszlo Ersek wrote: The other four virtio device drivers (VirtioBlkDxe, VirtioGpuDxe, VirtioRngDxe, VirtioScsiDxe) log such messages at this point; follow suit. Cc: Brijesh Singh Cc: Jordan Justen Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by:

Re: [edk2] [PATCH 1/2] OvmfPkg/VirtioNetDxe: document Rx/Tx allocs and mappings on Init/Shutdown

2017-09-15 Thread Brijesh Singh
On 09/15/2017 03:57 AM, Laszlo Ersek wrote: Document the following actions on the EfiSimpleNetworkStarted <-> EfiSimpleNetworkInitialized state transitions: * from commit 46b11f00ac70 ("OvmfPkg/VirtioNetDxe: alloc RxBuf using AllocateSharedPages()", 2017-09-14): VirtioNetInitRx ->

[edk2] [PATCH] Fix not able to change serial attributes

2017-09-15 Thread Pankaj Bansal
Issue : When try to change serial attributes using sermode command, the default values are set Cause : The SerialReset command resets the attributes' values to default Fix : Serial Reset command should set the attributes which have been changed by user after calling SerialSetAttributes. Contribute

Re: [edk2] [PATCH] MdeModulePkg/UdfDxe: Remove negative comparison of unsigned number

2017-09-15 Thread Ni, Ruiyu
Agree with most of your words. Build farm is very needed for this case. But as I said in another mail, there is a bug (#707) in current implementation and I expect it to be fixed ASAP. Our QA is complaining! -Original Message- From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Friday, S

Re: [edk2] Functionality issues in UDF support

2017-09-15 Thread Ni, Ruiyu
Laszlo, I may not state the problem very clearly. I saw two problems: 1. ParitionDxe shouldn't create BLK handle for the entire media again. Our QA complains several new but unexpected BLK devices are seen. This bug is easy to fix and needs to be fixed ASAP. So I created a BZ (https://

Re: [edk2] Functionality issues in UDF support

2017-09-15 Thread Laszlo Ersek
On 09/15/17 09:38, Ni, Ruiyu wrote: > Paulo, > Supporting multiple LVDs can be considered as a long-term task, or can be > added > per request. > But I think a urgent fix in PartitionDxe driver is to: > 1. create child BLK only for the portion covered by the LVD > 2. Do not create child BLK for LV

Re: [edk2] Functionality issues in UDF support

2017-09-15 Thread Laszlo Ersek
Hello All, On 09/15/17 09:38, Ni, Ruiyu wrote: > Paulo, > Supporting multiple LVDs can be considered as a long-term task, or can be > added > per request. > But I think a urgent fix in PartitionDxe driver is to: > 1. create child BLK only for the portion covered by the LVD > 2. Do not create chil

Re: [edk2] [PATCH] MdeModulePkg/UdfDxe: Remove negative comparison of unsigned number

2017-09-15 Thread Laszlo Ersek
Hi Star, On 09/15/17 08:14, Zeng, Star wrote: > Hi, > > Based on recent issues about UDF since the code was pushed for > https://lists.01.org/pipermail/edk2-devel/2017-September/014360.html, I > want to raise some questions kindly. > > https://lists.01.org/pipermail/edk2-devel/2017-September/01440

Re: [edk2] [PATCH] RFC Inform UEFI memory to Linux

2017-09-15 Thread Leif Lindholm
On Fri, Sep 15, 2017 at 08:02:34PM +0530, Meenakshi Aggarwal wrote: > From: Udit Kumar > > While creating Hob list, ArmPlatformPkg is hiding UEFI memory. > whereas this memory can be used by OS. > > This patch, allows OS to use UEFI code area. > > Contributed-under: TianoCore Contribution Agree

Re: [edk2] Failed to clear configuration in Ip4Config2 Protocol

2017-09-15 Thread Karunakar P
Hello All, Could you please anyone provide comment on this? Thank you, karunakar From: Karunakar P Sent: Wednesday, September 13, 2017 7:04 PM To: 'edk2-devel@lists.01.org' Subject: RE: RE: Failed to clear configuration in Ip4Config2 Protocol Hello All, I was trying to verify the feature "Allo

Re: [edk2] Check Ipv6 Support for ISCSI attempt page

2017-09-15 Thread Karunakar P
Hello all, We have a Broadcom NIC card which doesn't support IPv6 (Ipv6Supported flag is 0). 1) But the HTTPv6 boot options are shown. Unlike in PXE (PxeBcCheckIpv6Support()), the HTTP drivers in edk2 do not have a condition check whether the card supports IPv6 or not. 2) If the card do

Re: [edk2] [PATCH 2/5] EmbeddedPkg: Introduce HardwareInterrupt2 protocol

2017-09-15 Thread Alexei Fedorov
In "Signal to the hardware that the End Of Intrrupt state has been reached." Intrrupt -> Interrupt From: edk2-devel on behalf of Leif Lindholm Sent: 14 September 2017 17:42:24 To: Evan Lloyd Cc: edk2-devel@lists.01.org; nd; Ard Biesheuvel Subject: Re: [edk2]

[edk2] [PATCH 2/2] OvmfPkg/VirtioNetDxe: log debug message in VirtioNetExitBoot()

2017-09-15 Thread Laszlo Ersek
The other four virtio device drivers (VirtioBlkDxe, VirtioGpuDxe, VirtioRngDxe, VirtioScsiDxe) log such messages at this point; follow suit. Cc: Brijesh Singh Cc: Jordan Justen Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Laszlo Ersek --- OvmfPkg/VirtioNetDxe/Events.c

[edk2] [PATCH 1/2] OvmfPkg/VirtioNetDxe: document Rx/Tx allocs and mappings on Init/Shutdown

2017-09-15 Thread Laszlo Ersek
Document the following actions on the EfiSimpleNetworkStarted <-> EfiSimpleNetworkInitialized state transitions: * from commit 46b11f00ac70 ("OvmfPkg/VirtioNetDxe: alloc RxBuf using AllocateSharedPages()", 2017-09-14): VirtioNetInitRx -> { VirtIo->AllocateSharedPages, VirtioMapAllBytesI

[edk2] [PATCH 0/2] OvmfPkg/VirtioNetDxe: update TechNotes, log message at ExitBootServices

2017-09-15 Thread Laszlo Ersek
Repo: https://github.com/lersek/edk2.git Branch: vnet_technotes_exitboot_after_map Cc: Brijesh Singh Cc: Jordan Justen Laszlo Ersek (2): OvmfPkg/VirtioNetDxe: document Rx/Tx allocs and mappings on Init/Shutdown OvmfPkg/VirtioNetDxe: log debug message in VirtioNetExitBoot() OvmfPkg/V

[edk2] [PATCH] RFC Inform UEFI memory to Linux

2017-09-15 Thread Meenakshi Aggarwal
From: Udit Kumar While creating Hob list, ArmPlatformPkg is hiding UEFI memory. whereas this memory can be used by OS. This patch, allows OS to use UEFI code area. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Meenakshi Aggarwal Signed-off-by: Udit Kumar --- ArmPlatf

[edk2] [Patch] BaseTools: Fix a bug to correct SourceFileList

2017-09-15 Thread Yonghong Zhu
We met a case that use two microcode files in the Microcode.inf file, one is .mcb file, another is .txt file. then it cause build failure because the SourceFileList include the .txt file's output file, while this output file is still not be generated, so it cause GetFileDependency report failure.

Re: [edk2] [PATCH v1] MdePkg: Add definitions for the SPI protocols introduced in UEFI PI 1.6.

2017-09-15 Thread Bi, Dandan
Hi Marvin, Thank you for your contribution. I am reviewing this patch now. Currently I just take a look at the SMM SPI part and find: 1. There is a typo in LegacySpiSmmController.h The definition should be EFI_LEGACY_SPI_SMM_CONTROLLER_GUID, not EFI_LEGACY_SPI_SMM_FLASH_PROTOCOL_GUID. Typo: #de

Re: [edk2] Functionality issues in UDF support

2017-09-15 Thread Ni, Ruiyu
Paulo, Supporting multiple LVDs can be considered as a long-term task, or can be added per request. But I think a urgent fix in PartitionDxe driver is to: 1. create child BLK only for the portion covered by the LVD 2. Do not create child BLK for LVD that's actually an Eltorito LVD I submitted a Bu

Re: [edk2] Functionality issues in UDF support

2017-09-15 Thread Paulo Alcantara
On September 15, 2017 4:10:10 AM GMT-03:00, "Ni, Ruiyu" wrote: >Paulo, >Can current code support multiple volumes in CDROM? No. It can handle only a single UDF logical volume. I think I never found an UDF disk or image with more than a LVD (Logical Volume Descriptior). Although I think I als

Re: [edk2] Functionality issues in UDF support

2017-09-15 Thread Ni, Ruiyu
Paulo, Can current code support multiple volumes in CDROM? Thanks/Ray > -Original Message- > From: Paulo Alcantara [mailto:pca...@zytor.com] > Sent: Friday, September 15, 2017 2:26 PM > To: Ni, Ruiyu ; Laszlo Ersek > Cc: edk2-devel@lists.01.org; Wu, Hao A ; Zeng, Star > > Subject: RE: F

Re: [edk2] Functionality issues in UDF support

2017-09-15 Thread Ni, Ruiyu
Star, Eltorito file system access should work. But UDF support may not work as expected if there are multiple volumes in the CDROM. Thanks/Ray > -Original Message- > From: Zeng, Star > Sent: Friday, September 15, 2017 3:01 PM > To: Paulo Alcantara ; Ni, Ruiyu ; > Laszlo Ersek > Cc: edk2-

Re: [edk2] [edk2-VfrSpecification PATCH V2] Add union data type and bit fields in VFR Data Struct Definition

2017-09-15 Thread Gao, Liming
Reviewed-by: Liming Gao >-Original Message- >From: Bi, Dandan >Sent: Friday, September 15, 2017 3:04 PM >To: edk2-devel@lists.01.org >Cc: Dong, Eric ; Gao, Liming >Subject: [edk2-VfrSpecification PATCH V2] Add union data type and bit fields >in VFR Data Struct Definition > >V2: Add a not

[edk2] [edk2-VfrSpecification PATCH V2] Add union data type and bit fields in VFR Data Struct Definition

2017-09-15 Thread Dandan Bi
V2: Add a note in the doc:for the bit field, the number of the bit width could not exceed 32. https://bugzilla.tianocore.org/show_bug.cgi?id=683 Cc: Eric Dong Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Dandan Bi Reviewed-by: Eric Dong --- .../23_vf

Re: [edk2] Functionality issues in UDF support

2017-09-15 Thread Zeng, Star
How serious is this issue? Only causing more BLKs are shown, but not impacting Eltorito? Or impacting Eltorito definitely? Thanks, Star -Original Message- From: Paulo Alcantara [mailto:pca...@zytor.com] Sent: Friday, September 15, 2017 2:26 PM To: Ni, Ruiyu ; Laszlo Ersek Cc: edk2-dev