[edk2] [Patch][edk2-platforms/devel-MinnowBoard3-UDK2017] Board Name.

2017-09-25 Thread lushifex
Correct board names according to different boards. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: lushifex --- .../BensonGlacier/BoardInitDxe/BoardInitDxe.c | 2 +- .../Board/LeafHill/BoardInitDxe/BoardInitDxe.c | 2 +- .../Board/MinnowBoard3/BoardInitDxe/Board

Re: [edk2] [Patch] UefiCpuPkg/CpuCommonFeaturesLib: Add check for input parameter.

2017-09-25 Thread Ni, Ruiyu
Reviewed-by: Ruiyu Ni -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Eric Dong Sent: Tuesday, September 26, 2017 10:48 AM To: edk2-devel@lists.01.org Cc: Shao, Ming ; Ni, Ruiyu Subject: [edk2] [Patch] UefiCpuPkg/CpuCommonFeaturesLib: Add check f

Re: [edk2] [Patch] Build Spec: Build report to display every module's build time

2017-09-25 Thread Gao, Liming
Reviewed-by: Liming Gao > -Original Message- > From: Zhu, Yonghong > Sent: Monday, September 25, 2017 10:34 AM > To: edk2-devel@lists.01.org > Cc: Gao, Liming ; Kinney, Michael D > ; Shaw, Kevin W > Subject: [Patch] Build Spec: Build report to display every module's build time > > fixe

Re: [edk2] [Patch] FDF Spec: Per PI 1.6 to extend FFS alignment to 16M

2017-09-25 Thread Gao, Liming
Reviewed-by: Liming Gao > -Original Message- > From: Zhu, Yonghong > Sent: Monday, September 25, 2017 11:42 AM > To: edk2-devel@lists.01.org > Cc: Gao, Liming ; Kinney, Michael D > ; Shaw, Kevin W > Subject: [Patch] FDF Spec: Per PI 1.6 to extend FFS alignment to 16M > > Cc: Liming Gao

Re: [edk2] [Patch 02/11] FatPkg: Update Ppi/Protocol usage in Fat INF to match source code logic

2017-09-25 Thread Gao, Liming
Ray: There is no such key. OK, I will keep its usage to TO_START. Thanks Liming > -Original Message- > From: Ni, Ruiyu > Sent: Monday, September 25, 2017 8:44 PM > To: Gao, Liming ; edk2-devel@lists.01.org > Subject: RE: [Patch 02/11] FatPkg: Update Ppi/Protocol usage in Fat INF to > m

Re: [edk2] [PATCH] BaseTools/Conf: Support LLVM39 and LLVM40 in CLANG38 toolchain

2017-09-25 Thread Shi, Steven
Besides the GetBestLanguage() , there are several other lib functions have the same problem which are listed in attachment https://bugzilla.tianocore.org/attachment.cgi?id=97 of the Bug410. These functions can also cause the build fails with CLANG38 in my side with clang version 4.0 or clang 5.

[edk2] [Patch] UefiCpuPkg/CpuCommonFeaturesLib: Add check for input parameter.

2017-09-25 Thread Eric Dong
The ConfigData parameter initialized in *GetConfigData function should not be NULL in later *Support, *Initilize function, so just add ASSERT code check in these functions. Cc: Ming Shao Cc: Ruiyu Ni Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Eric Dong --- UefiCpu

Re: [edk2] [PATCH] MdeModulePkg/UdfDxe: Resolve potential NULL pointer dereference

2017-09-25 Thread Paulo Alcantara
On September 25, 2017 10:36:48 PM GMT-03:00, Hao Wu wrote: >Within function GetAllocationDescriptorLsn(): > >The call to GetPdFromLongAd() may return NULL and it will be later >dereferenced in GetShortAdLsn(). > >This commit adds ASSERT to resolve the potential NULL pointer >dereference. > >Cc:

[edk2] [PATCH] MdeModulePkg/UdfDxe: Resolve potential NULL pointer dereference

2017-09-25 Thread Hao Wu
Within function GetAllocationDescriptorLsn(): The call to GetPdFromLongAd() may return NULL and it will be later dereferenced in GetShortAdLsn(). This commit adds ASSERT to resolve the potential NULL pointer dereference. Cc: Paulo Alcantara Cc: Ruiyu Ni Cc: Star Zeng Cc: Eric Dong Contribute

Re: [edk2] [PATCH v2 2/6] MdeModulePkg/DxeIpl: Implement NULL pointer detection

2017-09-25 Thread Wang, Jian J
Good catch. Thanks for the feedback. > -Original Message- > From: Yao, Jiewen > Sent: Monday, September 25, 2017 4:51 PM > To: Wang, Jian J ; edk2-devel@lists.01.org > Cc: Zeng, Star ; Dong, Eric ; Laszlo > Ersek ; Kinney, Michael D ; > Justen, Jordan L ; Wolman, Ayellet > > Subject: RE:

Re: [edk2] [Patch 06/11] NetworkPkg: Update Protocol/Guid usage in INF file to match source code logic

2017-09-25 Thread Fu, Siyuan
Reviewed-by: Fu Siyuan -Original Message- From: Gao, Liming Sent: Monday, September 25, 2017 7:06 PM To: edk2-devel@lists.01.org Cc: Fu, Siyuan ; Wu, Jiaxin Subject: [Patch 06/11] NetworkPkg: Update Protocol/Guid usage in INF file to match source code logic Contributed-under: TianoCor

Re: [edk2] [PATCH v2] TFTP : tftp fix for full volume case

2017-09-25 Thread Fu, Siyuan
Reviewed-by: Fu Siyuan -Original Message- From: Meenakshi Aggarwal [mailto:meenakshi.aggar...@nxp.com] Sent: Monday, September 25, 2017 11:06 PM To: edk2-devel@lists.01.org; Ni, Ruiyu ; Carsey, Jaben Cc: ard.biesheu...@linaro.org; leif.lindh...@linaro.org; Fu, Siyuan ; Ye, Ting ; Meen

[edk2] [PATCH 7/7] OvmfPkg/PciHotPlugInitDxe: translate QEMU's resource reservation hints

2017-09-25 Thread Laszlo Ersek
Parse QEMU_PCI_BRIDGE_CAPABILITY_RESOURCE_RESERVATION from the bridges' conventional config spaces. Translate the fields as follows: * BusNumbers: * 0 -- no reservation; * (-1) -- firmware default, i.e. no reservation; * otherwise -- reserve the requested value. (NB, bus number reservation

[edk2] [PATCH 2/7] OvmfPkg/IndustryStandard: define PCI Capabilities for QEMU's PCI Bridges

2017-09-25 Thread Laszlo Ersek
QEMU has recently gained the ability to provide various hints about its PCI bridges. The hints take the form of vendor-specific PCI capabilities. Define macros and types under "OvmfPkg/Include/IndustryStandard" to describe these capabilities. The definitions correspond to "docs/pcie_pci_bridge.txt

[edk2] [PATCH 4/7] OvmfPkg/PciHotPlugInitDxe: clean up addr. range for non-prefetchable MMIO

2017-09-25 Thread Laszlo Ersek
The non-prefetchable MMIO aperture of a bridge can never fall outside of the 32-bit address space. Namely, the MemoryBase and MemoryLimit fields in PCI_BRIDGE_CONTROL_REGISTER have type UINT16, and based on the PCI-to-PCI Bridge Architecture Spec, Chapter 3.2, the actual MMIO aperture is determined

[edk2] [PATCH 6/7] OvmfPkg/PciHotPlugInitDxe: add helper functions for setting up paddings

2017-09-25 Thread Laszlo Ersek
Extract the SetIoPadding() and SetMmioPadding() functions, so that we can set EFI_ACPI_ADDRESS_SPACE_DESCRIPTOR fields using parameter names and values that are more friendly than the original field names and their expected values. Introduce the HighBitSetRoundUp32() and HighBitSetRoundUp64() func

[edk2] [PATCH 5/7] OvmfPkg/PciHotPlugInitDxe: generalize RESOURCE_PADDING composition

2017-09-25 Thread Laszlo Ersek
PciHotPlugInitDxe has a static variable called "mPadding" (of type RESOURCE_PADDING), which describes two constant resource reservations: - MmioPadding: 2MB of non-prefetchable (hence 32-bit) MMIO space, - IoPadding: 512B of IO space. In the GetResourcePadding() member function of EFI_PCI_HOT_PL

[edk2] [PATCH 0/7] OvmfPkg/PciHotPlugInitDxe: obey PCI resource reservation hints from QEMU

2017-09-25 Thread Laszlo Ersek
Repo: https://github.com/lersek/edk2.git Branch: pci_resource_reserve "OvmfPkg/PciHotPlugInitDxe" implements EFI_PCI_HOT_PLUG_INIT_PROTOCOL from the PI spec. Currently it returns fixed resource reservations (512B IO space and 2MB non-prefetchable 32-bit MMIO space) for all bridges. This is not f

[edk2] [PATCH 1/7] MdePkg/IndustryStandard/Pci23: add vendor-specific capability header

2017-09-25 Thread Laszlo Ersek
Revision 2.2 of the PCI Spec defines Capability IDs 0 through 6, inclusive, in Appendix H. It reserves IDs 7 through 255. Revision 2.3 of the PCI Spec adds Capability IDs 7 through 0xC, inclusive, in Appendix H. Capability ID 9 stands for "Vendor Specific". Add the EFI_PCI_CAPABILITY_ID_VENDOR ma

[edk2] [PATCH 3/7] OvmfPkg/PciHotPlugInitDxe: clean up protocol usage comment

2017-09-25 Thread Laszlo Ersek
The driver always produces an instance of the EFI_PCI_HOT_PLUG_INIT_PROTOCOL. The "SOMETIMES_PRODUCES" remark is an oversight from the original v1->v2 patch update; v2 should have stated "ALWAYS_PRODUCES": http://mid.mail-archive.com/1468242274-12686-5-git-send-email-lersek@redhat.com > Notes: >

[edk2] [PATCH] UefiCpuPkg/SmmCpuFeaturesLib: replace hard-coded machine code

2017-09-25 Thread Chris Ruffin
Replace hard-coded machine code with equivalent assembly source code. Changes tested by checking for machine code equivalence by disassembling the original and changed code. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Chris Ruffin Cc: Yao, Jiewen Cc: Kinney, Michael D

[edk2] How do i generate a SHA256 hash in UEFI

2017-09-25 Thread Amit kumar
Hi , I am trying to write a uefi standalone application ( not a uefi shell app), which generates a sh256 hash, can some body tell me the right way to do it. Do i really need to use hash protocol. Is there any other way to do it without using this protocol ? Best Regards Amit Kumar _

Re: [edk2] multiple paddings in the same PCI resource tree

2017-09-25 Thread Laszlo Ersek
On 09/23/17 00:52, Laszlo Ersek wrote: > Hi Ray, > > I ran into an interesting problem, while working on > "OvmfPkg/PciHotPlugInitDxe": > > It is an assertion failure in CalculateResourceAperture(), in > "MdeModulePkg/Bus/Pci/PciBusDxe/PciResourceSupport.c": > >> VOID >> CalculateResourceApertur

Re: [edk2] [Patch 01/11] MdePkg: Correct BaseS3PciSegmentLib module name to match its uni file

2017-09-25 Thread Ni, Ruiyu
Reviewed-by: Ruiyu Ni -Original Message- From: Gao, Liming Sent: Monday, September 25, 2017 7:06 PM To: edk2-devel@lists.01.org Cc: Ni, Ruiyu Subject: [Patch 01/11] MdePkg: Correct BaseS3PciSegmentLib module name to match its uni file Contributed-under: TianoCore Contribution Agreemen

Re: [edk2] [Patch 05/11] ShellPkg: Update Guid usage in ShellLib INF to match source code logic

2017-09-25 Thread Ni, Ruiyu
Reviewed-by: Ruiyu Ni -Original Message- From: Gao, Liming Sent: Monday, September 25, 2017 7:06 PM To: edk2-devel@lists.01.org Cc: Carsey, Jaben ; Ni, Ruiyu Subject: [Patch 05/11] ShellPkg: Update Guid usage in ShellLib INF to match source code logic Contributed-under: TianoCore Cont

Re: [edk2] [Patch 03/11] PcAtChipsetPkg: Update GUID usage in PcRtc INF to match the source code

2017-09-25 Thread Ni, Ruiyu
Reviewed-by: Ruiyu Ni -Original Message- From: Gao, Liming Sent: Monday, September 25, 2017 7:06 PM To: edk2-devel@lists.01.org Cc: Ni, Ruiyu Subject: [Patch 03/11] PcAtChipsetPkg: Update GUID usage in PcRtc INF to match the source code Contributed-under: TianoCore Contribution Agreem

Re: [edk2] [Patch 02/11] FatPkg: Update Ppi/Protocol usage in Fat INF to match source code logic

2017-09-25 Thread Ni, Ruiyu
Liming, There is no keyword such as "SOMETIMES_TO_START"? The DiskIo2 is indeed a TO_START protocol, but optional. -Original Message- From: Gao, Liming Sent: Monday, September 25, 2017 7:06 PM To: edk2-devel@lists.01.org Cc: Ni, Ruiyu Subject: [Patch 02/11] FatPkg: Update Ppi/Protocol us

Re: [edk2] [PATCH] BaseTools/Conf: Support LLVM39 and LLVM40 in CLANG38 toolchain

2017-09-25 Thread Marvin Häuser
Hey Liming and Laszlo, Thanks for your answers! I rather thought of this (I didn't check whether Language1 should be CONST, but doesn't matter for now): CHAR8 * EFIAPI GetBestLanguage ( IN CONST CHAR8 *SupportedLanguages, IN BOOLEAN Iso639Language, IN CHAR8 *Langua

Re: [edk2] [Patch 04/11] UefiCpuPkg: Update Guid usage in DxeMpInitLib INF to match source code logic

2017-09-25 Thread Dong, Eric
Reviewed-by: Eric Dong -Original Message- From: Gao, Liming Sent: Monday, September 25, 2017 7:06 PM To: edk2-devel@lists.01.org Cc: Dong, Eric Subject: [Patch 04/11] UefiCpuPkg: Update Guid usage in DxeMpInitLib INF to match source code logic Contributed-under: TianoCore Contribution

Re: [edk2] [Patch 11/11] MdeModulePkg: Update Ppi/Protocol/Guid usage in INF files

2017-09-25 Thread Zeng, Star
Reviewed-by: Star Zeng -Original Message- From: Gao, Liming Sent: Monday, September 25, 2017 7:06 PM To: edk2-devel@lists.01.org Cc: Zeng, Star ; Dong, Eric Subject: [Patch 11/11] MdeModulePkg: Update Ppi/Protocol/Guid usage in INF files Contributed-under: TianoCore Contribution Agreem

Re: [edk2] [PATCH] IntelFrameworkModulePkg FwVolDxe: Support FFS_ATTRIB_DATA_ALIGNMENT_2

2017-09-25 Thread Gao, Liming
Reviewed-by: Liming Gao >-Original Message- >From: Zeng, Star >Sent: Monday, September 25, 2017 6:15 PM >To: edk2-devel@lists.01.org >Cc: Zeng, Star ; Gao, Liming >Subject: [PATCH] IntelFrameworkModulePkg FwVolDxe: Support >FFS_ATTRIB_DATA_ALIGNMENT_2 > >Follow PI 1.6 spec to support FFS

Re: [edk2] [PATCH 0/2] Follow PI 1.6 to support FFS_ATTRIB_DATA_ALIGNMENT_2

2017-09-25 Thread Gao, Liming
Reviewed-by: Liming Gao >-Original Message- >From: Zeng, Star >Sent: Friday, September 22, 2017 6:22 PM >To: edk2-devel@lists.01.org >Cc: Zeng, Star ; Gao, Liming ; >Zhu, Yonghong >Subject: [PATCH 0/2] Follow PI 1.6 to support >FFS_ATTRIB_DATA_ALIGNMENT_2 > >The BaseTools update patch ha

[edk2] [Patch 11/11] MdeModulePkg: Update Ppi/Protocol/Guid usage in INF files

2017-09-25 Thread Liming Gao
Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Liming Gao Cc: Star Zeng Cc: Eric Dong --- MdeModulePkg/Core/Dxe/DxeMain.inf | 2 +- MdeModulePkg/Core/PiSmmCore/PiSmmCore.inf | 2 +- .../BootMaintenanceManagerUiLib.inf

[edk2] [Patch 09/11] IntelFsp2Pkg: Update Section Name in INF files

2017-09-25 Thread Liming Gao
Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Liming Gao Cc: Jiewen Yao --- IntelFsp2Pkg/FspNotifyPhase/FspNotifyPhasePeim.inf | 3 +-- .../Library/BaseCacheAsRamLibNull/BaseCacheAsRamLibNull.inf | 6 +++--- IntelFsp2Pkg/Library/BaseCacheLib/Base

[edk2] [Patch 10/11] IntelFsp2WrapperPkg: Update Protocol/Guid usage in INF files

2017-09-25 Thread Liming Gao
Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Liming Gao Cc: Jiewen Yao --- IntelFsp2WrapperPkg/FspWrapperNotifyDxe/FspWrapperNotifyDxe.inf | 6 +++--- IntelFsp2WrapperPkg/FspmWrapperPeim/FspmWrapperPeim.inf | 9 ++--- IntelFsp2WrapperPkg/FspsWrapperPeim/Fs

[edk2] [Patch 08/11] SecurityPkg: Update Guid usage in INF file to match source code logic

2017-09-25 Thread Liming Gao
Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Liming Gao Cc: Chao Zhang --- .../FmpAuthenticationLibRsa2048Sha256.inf | 6 +++--- .../Library/HashLibBaseCryptoRouter/HashLibBaseCryptoRouterPei.inf | 2 +- 2 files changed, 4 insertions(+), 4 del

[edk2] [Patch 07/11] SignedCapsulePkg: Update Guid usage in INF file to match source code logic

2017-09-25 Thread Liming Gao
Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Liming Gao Cc: Jiewen Yao --- .../Library/EdkiiSystemCapsuleLib/EdkiiSystemCapsuleLib.inf | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/SignedCapsulePkg/Library/EdkiiSystemCapsuleLib/Edkii

[edk2] [Patch 06/11] NetworkPkg: Update Protocol/Guid usage in INF file to match source code logic

2017-09-25 Thread Liming Gao
Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Liming Gao Cc: Siyuan Fu Cc: Jiaxin Wu --- NetworkPkg/HttpDxe/HttpDxe.inf | 2 +- NetworkPkg/IScsiDxe/IScsiDxe.inf | 2 +- NetworkPkg/TlsAuthConfigDxe/TlsAuthConfigDxe.inf | 8 3 fi

[edk2] [Patch 04/11] UefiCpuPkg: Update Guid usage in DxeMpInitLib INF to match source code logic

2017-09-25 Thread Liming Gao
Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Liming Gao Cc: Eric Dong --- UefiCpuPkg/Library/MpInitLib/DxeMpInitLib.inf | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/UefiCpuPkg/Library/MpInitLib/DxeMpInitLib.inf b/UefiCpuPkg/Library/MpInitLib/DxeM

[edk2] [Patch 05/11] ShellPkg: Update Guid usage in ShellLib INF to match source code logic

2017-09-25 Thread Liming Gao
Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Liming Gao Cc: Jaben Carsey Cc: Ruiyu Ni --- ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ShellPkg/Library/UefiHandleParsingLib/UefiHandle

[edk2] [Patch 00/11] Correct Ppi/Protocol/Guid usage in module INF files

2017-09-25 Thread Liming Gao
Update Ppi/Protocol/Guid usage described in INF file to match its source logic. Update Module base name in INF file to match its uni file. Update Section name in INF file to follow INF spec. Liming Gao (11): MdePkg: Correct BaseS3PciSegmentLib module name to match its uni file FatPkg: Update P

[edk2] [Patch 02/11] FatPkg: Update Ppi/Protocol usage in Fat INF to match source code logic

2017-09-25 Thread Liming Gao
Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Liming Gao Cc: Ruiyu Ni --- FatPkg/EnhancedFatDxe/Fat.inf | 2 +- FatPkg/FatPei/FatPei.inf | 10 +++--- 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/FatPkg/EnhancedFatDxe/Fat.inf b/FatPkg/EnhancedF

[edk2] [Patch 01/11] MdePkg: Correct BaseS3PciSegmentLib module name to match its uni file

2017-09-25 Thread Liming Gao
Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Liming Gao Cc: Ruiyu Ni --- MdePkg/Library/BaseS3PciSegmentLib/BaseS3PciSegmentLib.inf | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/MdePkg/Library/BaseS3PciSegmentLib/BaseS3PciSegmentLib.inf b/MdeP

[edk2] [Patch 03/11] PcAtChipsetPkg: Update GUID usage in PcRtc INF to match the source code

2017-09-25 Thread Liming Gao
Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Liming Gao Cc: Ruiyu Ni --- .../PcatRealTimeClockRuntimeDxe/PcatRealTimeClockRuntimeDxe.inf | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/PcAtChipsetPkg/PcatRealTimeClockRuntimeDxe/PcatRealTim

[edk2] [PATCH] IntelFrameworkModulePkg FwVolDxe: Support FFS_ATTRIB_DATA_ALIGNMENT_2

2017-09-25 Thread Star Zeng
Follow PI 1.6 spec to support FFS_ATTRIB_DATA_ALIGNMENT_2 for FFS alignment extended to support maximum 16MB. Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Star Zeng Note: This patch is to update IntelFrameworkModulePkg as a supplement of https://lists.01

Re: [edk2] [PATCH] BaseTools/Conf: Support LLVM39 and LLVM40 in CLANG38 toolchain

2017-09-25 Thread Gao, Liming
Laszlo: This is a better way. The bug https://bugzilla.tianocore.org/show_bug.cgi?id=410 only lists GetBestLanguage() API. I am not sure whether they are similar cases in edk2. If have, we had better fix them together. Thanks Liming >-Original Message- >From: Laszlo Ersek [mailto:ler

[edk2] [PATCH v2] TFTP : tftp fix for full volume case

2017-09-25 Thread Meenakshi Aggarwal
Issue : When storage media is full, tftp was resulting in ASSERT MdeModulePkg/Core/Dxe/Mem/Page.c, because number of pages was zero. Reason: While doing tftp, function call ShellWriteFile was modifying FileSize variable. In case of full disk it was coming out to be Zero. Fix: Storage the original

Re: [edk2] [PATCH] TFTP : tftp fix for full volume case

2017-09-25 Thread Ni, Ruiyu
+ Siyuan and Ting. -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Meenakshi Aggarwal Sent: Monday, September 25, 2017 10:37 PM To: edk2-devel@lists.01.org; Ni, Ruiyu ; Carsey, Jaben Cc: leif.lindh...@linaro.org; ard.biesheu...@linaro.org Subjec

Re: [edk2] Linux CentOS 7.3 can get DHCP IPv4 IP address with configuring DHCP server as per RFC3021

2017-09-25 Thread Karunakar P
Hi Fu Siyuan, Thanks for your conformation. We would like to use /31s to save IPv4 addresses. When it's a point-to-point link (server to router), the extra network address and broadcast address is wasted. RFC 3021 solves the problem by using a broadcast address of 255.255.255.255 on such subne

Re: [edk2] [PATCH v2 2/6] MdeModulePkg/DxeIpl: Implement NULL pointer detection

2017-09-25 Thread Yao, Jiewen
Hi I do not think NULL pointer is related to NX. As long as NullPointer PCD is true and IA32PAE is supported, we can build page table. +BuildPageTablesIa32Pae = (BOOLEAN) (IsIa32PaeSupport () +&& IsExecuteDisableBitAvailable () +

[edk2] [PATCH] TFTP : tftp fix for full volume case

2017-09-25 Thread Meenakshi Aggarwal
Issue : When storage media is full, tftp was resulting in ASSERT MdeModulePkg/Core/Dxe/Mem/Page.c, because number of pages was zero. Reason: While doing tftp, function call ShellWriteFile was modifying FileSize variable. In case of full disk it was coming out to be Zero. Fix: Storage the original

Re: [edk2] [PATCH v2 1/6] MdeModulePkg/MdeModulePkg.dec: Add NULL pointer detection PCD

2017-09-25 Thread Wang, Jian J
Sure. Thanks for the feedback. > -Original Message- > From: Zeng, Star > Sent: Monday, September 25, 2017 4:01 PM > To: Wang, Jian J ; edk2-devel@lists.01.org > Cc: Dong, Eric ; Laszlo Ersek ; Yao, > Jiewen ; Kinney, Michael D > ; Justen, Jordan L ; > Wolman, Ayellet ; Zeng, Star > ; Gao,

Re: [edk2] [PATCH] BaseTools/Conf: Support LLVM39 and LLVM40 in CLANG38 toolchain

2017-09-25 Thread Laszlo Ersek
On 09/25/17 06:59, Gao, Liming wrote: > Marvin: > My concern is that the fix is an incompatible change. It requires to modify > library API. In fact, this is an undefined behavior. But, current compiler > (VS, GCC and Clang) makes it work. So, I prefer to keep the code as-is, and > disable th

Re: [edk2] [PATCH v2 1/6] MdeModulePkg/MdeModulePkg.dec: Add NULL pointer detection PCD

2017-09-25 Thread Zeng, Star
You may need also add PcdNullPointerDetectionPropertyMask prompt and help into the MdeModulePkg.uni. Thanks, Star -Original Message- From: Wang, Jian J Sent: Thursday, September 21, 2017 1:20 PM To: edk2-devel@lists.01.org Cc: Wang, Jian J ; Zeng, Star ; Dong, Eric ; Laszlo Ersek ; Yao

Re: [edk2] Linux CentOS 7.3 can get DHCP IPv4 IP address with configuring DHCP server as per RFC3021

2017-09-25 Thread Fu, Siyuan
Hi, Karunakar May I know that whether you have a real requirement that must use the point-2-point link in your environment, or you just found this problem in your test? BestRegards Fu Siyuan From: Fu, Siyuan Sent: Monday, September 25, 2017 3:50 PM To: Karunakar P ; 'edk2-devel@lists.01.org'

Re: [edk2] Linux CentOS 7.3 can get DHCP IPv4 IP address with configuring DHCP server as per RFC3021

2017-09-25 Thread Fu, Siyuan
Hi, Karunakar You are correct that EDK2 doesn't support rfc3201. The most obvious problem that come to my mind is the NetIp4IsUnicast() function in NetLib, which has the assumption that the host address part should not be all zero or all one (or to say, -1 in the rfc3201). I think that's why th

Re: [edk2] [PATCH v4 0/2] UDF partition driver fix

2017-09-25 Thread Zeng, Star
Pushed at https://github.com/tianocore/edk2/compare/e921f58d4458...baaa3cee1eaf. Thanks all. :) Star -Original Message- From: Ni, Ruiyu Sent: Monday, September 25, 2017 8:31 AM To: Paulo Alcantara ; edk2-devel@lists.01.org Cc: Kinney, Michael D ; Gao, Liming ; Laszlo Ersek ; Zeng, Star

Re: [edk2] Linux CentOS 7.3 can get DHCP IPv4 IP address with configuring DHCP server as per RFC3021

2017-09-25 Thread Ye, Ting
Hi Karunakar, May I ask whether the CentOS can get IP address from BIOS or from DHCP server? I am confused about your question. Thanks, Ting From: Karunakar P [mailto:karunak...@amiindia.co.in] Sent: Monday, September 25, 2017 3:02 PM To: 'edk2-devel@lists.01.org' Cc: Wu, Jiaxin ; Fu, Siyuan

Re: [edk2] Linux CentOS 7.3 can get DHCP IPv4 IP address with configuring DHCP server as per RFC3021

2017-09-25 Thread Karunakar P
Hello All, It is known that current EDKII doesn't support RFC3021, We could see the following behavior which is PXE boot fails whereas Cent OS can get IP address from the same BIOS. [Configuration Used] DHCP server setting under Ubuntu: 1. /etc/dhcp/dhcpd.conf # RFC3021-Using 31-bit perfixes