Re: [edk2] [PATCH v3] CryptoPkg: Add new API to retrieve commonName of X.509 certificate

2017-09-27 Thread Long, Qin
Yes, they are legacy version with old style alignment. It's first try to address this return status change in this new API. We may update some APIs depending on requirement and impacts evaluations later. Best Regards & Thanks, LONG, Qin -Original Message- From: Zhang, Chao B Sent: Th

Re: [edk2] [PATCH] MdeModulePkg/BdsDxe: Don't delete "BootNext" until booting it

2017-09-27 Thread Wang, Sunny (HPS SW)
The change Looks good to me. Also, Good to see you adding the comment about why we need to cache BootNext before all the platform hook function calls. :) Reviewed-by: Sunny Wang Regards, Sunny Wang -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf

[edk2] [PATCH 1/2] ShellPkg/dh: Add mapping of new UEFI/PI protocols

2017-09-27 Thread Ruiyu Ni
From: Huajing Li Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Huajing Li Reviewed-by: Ruiyu Ni Cc: Jaben Carsey --- .../UefiHandleParsingLib/UefiHandleParsingLib.c| 56 ++ .../UefiHandleParsingLib/UefiHandleParsingLib.inf | 40 +++

[edk2] [PATCH 2/2] ShellPkg/UefiHandleParsingLib.c: Map SmmPciRootBridgeIo correctly

2017-09-27 Thread Ruiyu Ni
From: Huajing Li The current implementation has a typo that maps SmmPciRootBridgeIo to "PciRootBridgeIo". Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Huajing Li Reviewed-by: Ruiyu Ni Cc: Jaben Carsey --- ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.c

[edk2] [PATCH 0/2] Add mapping of new UEFI/PI protocols

2017-09-27 Thread Ruiyu Ni
Huajing Li (2): ShellPkg/dh: Add mapping of new UEFI/PI protocols ShellPkg/UefiHandleParsingLib.c: Map SmmPciRootBridgeIo correctly .../UefiHandleParsingLib/UefiHandleParsingLib.c| 58 +- .../UefiHandleParsingLib/UefiHandleParsingLib.inf | 40 +++ .../Uefi

[edk2] [Patch] FDF Spec: Per PI 1.6 to support FV extended header contain FV used size

2017-09-27 Thread Yonghong Zhu
Cc: Liming Gao Cc: Michael Kinney Cc: Kevin W Shaw Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Yonghong Zhu --- 2_fdf_design_discussion/25_[fv]_sections.md | 2 +- 3_edk_ii_fdf_file_format/36_[fv]_sections.md | 2 ++ README.md| 1

Re: [edk2] [PATCH] MdeModulePkg/BdsDxe: Don't delete "BootNext" until booting it

2017-09-27 Thread Zeng, Star
Ok, got it, tks. The new comment is showing why cache "BootNext" logic is still kept there, the commit log is showing the reason of the patch change. Make sense. :) Reviewed-by: Star Zeng Thanks, Star -Original Message- From: Ni, Ruiyu Sent: Thursday, September 28, 2017 2:18 PM To: Z

Re: [edk2] [PATCH] MdeModulePkg/BdsDxe: Don't delete "BootNext" until booting it

2017-09-27 Thread Ni, Ruiyu
I didn't change the position of code to cache "BootNext", because: This could avoid the "BootNext" (set by PlatformBootManagerLib) be consumed in *this* boot. Maybe this time it's more clear. Thanks/Ray > -Original Message- > From: Zeng, Star > Sent: Thursday, September 28, 2017 2:13 PM

Re: [edk2] [PATCH] MdeModulePkg/BdsDxe: Don't delete "BootNext" until booting it

2017-09-27 Thread Zeng, Star
The commit log is saying the "BootNext" *DELETED* (before PlatformBootManagerLib) may be *LOST* if there is reset during PlatformBootManagerLib. I realized it. The comment is saying to avoid the "BootNext" "SET" by PlatformBootManagerLib. Sorry I am not getting the point. Thanks, Star -Ori

Re: [edk2] [PATCH v3] CryptoPkg: Add new API to retrieve commonName of X.509 certificate

2017-09-27 Thread Zhang, Chao B
Qin: What about other X509 related interface, such as X509GetTBSCert, X509GetSubjectName. They all return TRUE/FALSE. It looks inconsistent between these interfaces -Original Message- From: Long, Qin Sent: Thursday, September 21, 2017 10:48 AM To: ler...@redhat.com; Ye, Ting ; Z

Re: [edk2] [PATCH] MdeModulePkg/BdsDxe: Don't delete "BootNext" until booting it

2017-09-27 Thread Ni, Ruiyu
This could avoid the "BootNext" set by PlatformBootManagerLib be consumed in *this* boot. If I add "*" around "this", is it more clear? Thanks/Ray > -Original Message- > From: Zeng, Star > Sent: Thursday, September 28, 2017 2:00 PM > To: Ni, Ruiyu ; edk2-devel@lists.01.org > Cc: Dong, E

Re: [edk2] [PATCH] MdeModulePkg/BdsDxe: Don't delete "BootNext" until booting it

2017-09-27 Thread Zeng, Star
I am ok with the code logic change, but a little confused by the new comment. It seems not match with the commit log. " This could avoid the "BootNext" set by PlatformBootManagerLib be consumed in this boot. " Thanks, Star -Original Message- From: Ni, Ruiyu Sent: Thursday, September 2

Re: [edk2] [patch] ShellPkg/Dh: Refine variable naming style

2017-09-27 Thread Ni, Ruiyu
Reviewed-by: Ruiyu Ni Thanks/Ray > -Original Message- > From: Bi, Dandan > Sent: Thursday, September 28, 2017 10:45 AM > To: edk2-devel@lists.01.org > Cc: Ni, Ruiyu ; Carsey, Jaben > Subject: [patch] ShellPkg/Dh: Refine variable naming style > > Avoid using only lower-case characters f

[edk2] [PATCH] MdeModulePkg/BdsDxe: Don't delete "BootNext" until booting it

2017-09-27 Thread Ruiyu Ni
Current implementation deletes the "BootNext" before calling any PlatformBootManagerLib APIs, but if system resets in PlatformBootManagerLib APIs, "BootNext" is not consumed but lost. The patch defers the deletion of "BootNext" to before booting it. Contributed-under: TianoCore Contribution Agree

[edk2] [Patch] NetworkPkg/UefiPxeBcDxe: Fix the redundant condition check

2017-09-27 Thread Jiaxin Wu
Cc: Santhapur Naveen Cc: Ye Ting Cc: Fu Siyuan Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Wu Jiaxin --- NetworkPkg/UefiPxeBcDxe/PxeBcSupport.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/NetworkPkg/UefiPxeBcDxe/PxeBcSupport.c b/NetworkPk

Re: [edk2] [PATCH v3 4/5] MdeModulePkg/DxeNetLib: Fix negative value left shift

2017-09-27 Thread Wu, Jiaxin
Reviewed-by: Wu Jiaxin > -Original Message- > From: Wu, Hao A > Sent: Thursday, September 28, 2017 12:32 PM > To: edk2-devel@lists.01.org > Cc: Wu, Hao A ; Shi, Steven ; > Fu, Siyuan ; Ye, Ting ; Wu, Jiaxin > ; Long, Qin ; Zeng, Star > ; Dong, Eric ; Paolo Bonzini > > Subject: [PATCH v

[edk2] [Patch 2/2] NetworkPkg/HttpDxe: Clarify the usage of HttpConfigData in HTTP protocol

2017-09-27 Thread Jiaxin Wu
Cc: Ye Ting Cc: Fu Siyuan Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Wu Jiaxin --- NetworkPkg/HttpDxe/HttpImpl.c | 20 +++- NetworkPkg/HttpDxe/HttpImpl.h | 18 ++ 2 files changed, 21 insertions(+), 17 deletions(-) diff --git a/Network

[edk2] [Patch 0/2] Clarify the usage of HttpConfigData in HTTP protocol

2017-09-27 Thread Jiaxin Wu
Cc: Ye Ting Cc: Fu Siyuan Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Wu Jiaxin Jiaxin Wu (2): MdePkg/Http.h: Clarify the usage of HttpConfigData in HTTP protocol NetworkPkg/HttpDxe: Clarify the usage of HttpConfigData in HTTP protocol MdePkg/Include/Protoco

[edk2] [Patch 1/2] MdePkg/Http.h: Clarify the usage of HttpConfigData in HTTP protocol

2017-09-27 Thread Jiaxin Wu
Cc: Ye Ting Cc: Fu Siyuan Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Wu Jiaxin --- MdePkg/Include/Protocol/Http.h | 16 +--- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/MdePkg/Include/Protocol/Http.h b/MdePkg/Include/Protocol/Http.h inde

Re: [edk2] [PATCH v3 2/6] MdeModulePkg/DxeIpl: Implement NULL pointer detection

2017-09-27 Thread Wang, Jian J
>From this perspective, you're right. > -Original Message- > From: Zeng, Star > Sent: Thursday, September 28, 2017 1:10 PM > To: Wang, Jian J ; edk2-devel@lists.01.org > Cc: Dong, Eric ; Laszlo Ersek ; Yao, > Jiewen ; Kinney, Michael D > ; Justen, Jordan L ; > Wolman, Ayellet ; Zeng, Star

Re: [edk2] [PATCH v2 6/6] MdeModulePkg/AtaAtapiPassThru: Fix possible out of range left shift

2017-09-27 Thread Zeng, Star
Got it, thanks for the information. :) Star -Original Message- From: Gao, Liming Sent: Thursday, September 28, 2017 11:57 AM To: Zeng, Star ; Wu, Hao A ; edk2-devel@lists.01.org Cc: Wu, Hao A ; Dong, Eric Subject: RE: [edk2] [PATCH v2 6/6] MdeModulePkg/AtaAtapiPassThru: Fix possible ou

Re: [edk2] [PATCH v3 5/5] MdeModulePkg/AtaAtapiPassThru: Fix possible out of range left shift

2017-09-27 Thread Zeng, Star
Reviewed-by: Star Zeng -Original Message- From: Wu, Hao A Sent: Thursday, September 28, 2017 12:32 PM To: edk2-devel@lists.01.org Cc: Wu, Hao A ; Shi, Steven ; Zeng, Star ; Dong, Eric Subject: [PATCH v3 5/5] MdeModulePkg/AtaAtapiPassThru: Fix possible out of range left shift REF: htt

Re: [edk2] [PATCH v3 2/6] MdeModulePkg/DxeIpl: Implement NULL pointer detection

2017-09-27 Thread Zeng, Star
I am curious about what is potential future change. Thanks, Star -Original Message- From: Wang, Jian J Sent: Thursday, September 28, 2017 11:50 AM To: Zeng, Star ; edk2-devel@lists.01.org Cc: Dong, Eric ; Laszlo Ersek ; Yao, Jiewen ; Kinney, Michael D ; Justen, Jordan L ; Wolman, Ayelle

Re: [edk2] [PATCH v3 2/6] MdeModulePkg/DxeIpl: Implement NULL pointer detection

2017-09-27 Thread Zeng, Star
If NULL pointer detection is disabled, the code should be behave same with before, and ClearLegacyMemory() is not needed to be called because DxeCore will behave same with before to handle the first 4K page clear , right? Thanks, Star -Original Message- From: Wang, Jian J Sent: Thursda

Re: [edk2] [PATCH v3 3/6] MdeModulePkg/Core/Dxe: Add EndOfDxe workaround

2017-09-27 Thread Wang, Jian J
Thanks for the feedback. Please see my comments below. > -Original Message- > From: Zeng, Star > Sent: Thursday, September 28, 2017 11:35 AM > To: Wang, Jian J ; edk2-devel@lists.01.org > Cc: Dong, Eric ; Laszlo Ersek ; Yao, > Jiewen ; Kinney, Michael D > ; Justen, Jordan L ; > Wolman, Aye

[edk2] [PATCH v3 1/5] MdePkg/PrintLib: Fix possible negative value left shift

2017-09-27 Thread Hao Wu
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=702 Within function InternalPrintLibSPrintMarker(), possible left shift of a negative value is found in: "(*(ArgumentString + 1) << 8)" which involves undefined behavior. Since '*(ArgumentString + 1)' is of type CONST CHAR8 (signed), it will be

[edk2] [PATCH v3 4/5] MdeModulePkg/DxeNetLib: Fix negative value left shift

2017-09-27 Thread Hao Wu
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=698 Within function NetRandomInitSeed(), left shift a negative value is used in: "~Time.Hour << 24" which involves undefined behavior. Since Time.Hour is of type UINT8 (range from 0 to 23), hence ~Time.Hour will be a negative value (of type int

[edk2] [PATCH v3 0/5] Resolve undefined behaviours in left shift OPs

2017-09-27 Thread Hao Wu
Based on the feedbacks from Liming, the V3 series drops the patch for MdeModulePkg/Crc32. Since the left shift operation "1 << Index" will be removed by an under-reviewing patch series: [Patch 0/2] Add CalculateCrc32() API in MdePkg BaseLib V2 history: According to the feebacks from Paolo, the f

[edk2] [PATCH v3 2/5] MdeModulePkg/PrintLib: Fix possible negative value left shift

2017-09-27 Thread Hao Wu
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=702 Within function InternalPrintLibSPrintMarker(), possible left shift of a negative value is found in: "(*(ArgumentString + 1) << 8)" which involves undefined behavior. Since '*(ArgumentString + 1)' is of type CONST CHAR8 (signed), it will be

[edk2] [PATCH v3 5/5] MdeModulePkg/AtaAtapiPassThru: Fix possible out of range left shift

2017-09-27 Thread Hao Wu
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=699 Within function AhciModeInitialization(), left shift operations of 'BIT0' in the following statements: "if ((PortImplementBitMap & (BIT0 << Port)) != 0) {" will incur possible out of range left shift when Port is 31, since "1 << 31" is possi

[edk2] [PATCH v3 3/5] MdeModulePkg/Tpl: Fix negative value left shift

2017-09-27 Thread Hao Wu
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=695 Within function CoreRestoreTpl(), left shift a negative value -2 is used in: "while (((-2 << NewTpl) & gEventPending) != 0) {" which involves undefined behavior. According to the C11 spec, Section 6.5.7: > 4 The result of E1 << E2 is E1 lef

Re: [edk2] [PATCH v2 2/6] MdeModulePkg/PrintLib: Fix possible negative value left shift

2017-09-27 Thread Gao, Liming
Reviewed-by: Liming Gao >-Original Message- >From: Wu, Hao A >Sent: Thursday, September 21, 2017 2:46 PM >To: edk2-devel@lists.01.org >Cc: Wu, Hao A ; Shi, Steven ; >Kinney, Michael D ; Gao, Liming > >Subject: [PATCH v2 2/6] MdeModulePkg/PrintLib: Fix possible negative value >left shift >

Re: [edk2] [PATCH v2 1/6] MdePkg/PrintLib: Fix possible negative value left shift

2017-09-27 Thread Gao, Liming
Reviewed-by: Liming Gao >-Original Message- >From: Wu, Hao A >Sent: Thursday, September 21, 2017 2:46 PM >To: edk2-devel@lists.01.org >Cc: Wu, Hao A ; Shi, Steven ; >Kinney, Michael D ; Gao, Liming > >Subject: [PATCH v2 1/6] MdePkg/PrintLib: Fix possible negative value left shift > >REF:

Re: [edk2] [PATCH v2 5/6] MdeModulePkg/Crc32: Fix possible out of range left shift

2017-09-27 Thread Wu, Hao A
Got it. I will send a new series to drop this patch. Best Regards, Hao Wu > -Original Message- > From: Gao, Liming > Sent: Thursday, September 28, 2017 11:54 AM > To: Wu, Hao A; edk2-devel@lists.01.org > Cc: Wu, Hao A; Paolo Bonzini; Dong, Eric; Zeng, Star > Subject: RE: [edk2] [PATCH v2

Re: [edk2] [PATCH v2 6/6] MdeModulePkg/AtaAtapiPassThru: Fix possible out of range left shift

2017-09-27 Thread Gao, Liming
Star: Crc32 change is not required . I just gives my comment on it. So, there is no consistent issue here. We can keep this patch. Thanks Liming >-Original Message- >From: Zeng, Star >Sent: Monday, September 25, 2017 2:25 PM >To: Wu, Hao A ; edk2-devel@lists.01.org >Cc: Wu, Hao A ; Dong

Re: [edk2] [PATCH v3 2/6] MdeModulePkg/DxeIpl: Implement NULL pointer detection

2017-09-27 Thread Wang, Jian J
Clearing this block of memory has nothing to do with NULL pointer detection. I'm not sure the extra check is necessary. > -Original Message- > From: Zeng, Star > Sent: Thursday, September 28, 2017 11:31 AM > To: Wang, Jian J ; edk2-devel@lists.01.org > Cc: Dong, Eric ; Laszlo Ersek ; Yao,

Re: [edk2] [PATCH v2 5/6] MdeModulePkg/Crc32: Fix possible out of range left shift

2017-09-27 Thread Gao, Liming
Hao: I sent another patch to introduce CacluateCrc32() API in BaseLib. It will update MdeModulePkg Crc32 to depend on BaseLib. And, BaseLib CacluateCrc32() has no such logic. So, I think this patch is not necessary. Thanks Liming >-Original Message- >From: edk2-devel [mailto:edk2-deve

Re: [edk2] [PATCH v3 2/6] MdeModulePkg/DxeIpl: Implement NULL pointer detection

2017-09-27 Thread Wang, Jian J
Please see my comments inline below. > -Original Message- > From: Zeng, Star > Sent: Thursday, September 28, 2017 11:24 AM > To: Wang, Jian J ; edk2-devel@lists.01.org > Cc: Dong, Eric ; Laszlo Ersek ; Yao, > Jiewen ; Kinney, Michael D > ; Justen, Jordan L ; > Wolman, Ayellet ; Zeng, Star

Re: [edk2] [PATCH v3 1/6] MdeModulePkg/MdeModulePkg.dec, .uni: Add NULL pointer detection PCD

2017-09-27 Thread Zeng, Star
Reviewed-by: Star Zeng -Original Message- From: Wang, Jian J Sent: Thursday, September 28, 2017 9:04 AM To: edk2-devel@lists.01.org Cc: Wang, Jian J ; Zeng, Star ; Dong, Eric ; Laszlo Ersek ; Yao, Jiewen ; Kinney, Michael D ; Justen, Jordan L ; Wolman, Ayellet Subject: [PATCH v3 1/6]

Re: [edk2] [PATCH v3 3/6] MdeModulePkg/Core/Dxe: Add EndOfDxe workaround

2017-09-27 Thread Zeng, Star
Some comments to this patch. 1. How about using lower TPL TPL_CALLBACK instead of TPL_NOTIFY for the notification? 2. Should GCD SetMemorySpaceCapabilities + SetMemorySpaceAttributes be used instead of gCpu->SetMemoryAttributes()? Thanks, Star -Original Message- From: Wang, Jian J Sent

Re: [edk2] [PATCH v3 2/6] MdeModulePkg/DxeIpl: Implement NULL pointer detection

2017-09-27 Thread Zeng, Star
Another comment. Should IsNullDetectionEnabled() be checked before calling ClearLegacyMemory()? Thanks, Star -Original Message- From: Zeng, Star Sent: Thursday, September 28, 2017 11:24 AM To: Wang, Jian J ; edk2-devel@lists.01.org Cc: Dong, Eric ; Laszlo Ersek ; Yao, Jiewen ; Kinney, M

Re: [edk2] [PATCH v3 2/6] MdeModulePkg/DxeIpl: Implement NULL pointer detection

2017-09-27 Thread Zeng, Star
Minor comments to this patch. 1. IsNullDetectionEnabled() function is put in DxeLoad.c that is shared by all ARCHs, and the function is consuming PcdNullPointerDetectionPropertyMask, but PcdNullPointerDetectionPropertyMask is only declared in "[Pcd.IA32,Pcd.X64]" in inf. I am not sure whether i

[edk2] [Patch][edk2-platforms/devel-MinnowBoard3-UDK2017] Update Minor Version of BIOS ID.

2017-09-27 Thread zwei4
Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: zwei4 --- Platform/BroxtonPlatformPkg/BiosId.env | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Platform/BroxtonPlatformPkg/BiosId.env b/Platform/BroxtonPlatformPkg/BiosId.env index 8de9eb87f..13b7d3be9 1

[edk2] [patch] ShellPkg/Dh: Refine variable naming style

2017-09-27 Thread Dandan Bi
Avoid using only lower-case characters for variable name. Cc: Ruiyu Ni Cc: Jaben Carsey Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Dandan Bi --- ShellPkg/Library/UefiShellDriver1CommandsLib/Dh.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

Re: [edk2] [PATCH] [edk2-platforms/devel-MinnowBoard3-UDK2017] Enable SueCreek

2017-09-27 Thread Gao, Liming
Yeonsil: Please send the patch by git send-email way. We don't use attachment for patch review. Thanks Liming > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Wei, > David > Sent: Thursday, September 28, 2017 9:50 AM > To: Yoon, Yeon Sil ;

Re: [edk2] [PATCH] MdeModulePkg/PciBusDxe: Enable Bus Master on P2P bridges on demand

2017-09-27 Thread Yao, Jiewen
Reviewed-by: jiewen@intel.com > -Original Message- > From: Ni, Ruiyu > Sent: Friday, August 25, 2017 3:43 PM > To: edk2-devel@lists.01.org > Cc: Ruiyu Ni ; Sean Brogan > ; Yao, Jiewen ; Kinney, > Michael D > Subject: [PATCH] MdeModulePkg/PciBusDxe: Enable Bus Master on P2P bridges > o

[edk2] [PATCH] UefiCpuPkg/SmmCpuFeaturesLib: replace hard-coded machine code

2017-09-27 Thread Chris Ruffin
Replace hard-coded machine code with equivalent assembly source code. Changes tested by checking for machine code equivalence by disassembling the original and changed code. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Chris Ruffin Cc: Jiewen Yao Cc: Michael D Kinney -

[edk2] [PATCH] [edk2-platforms/devel-MinnowBoard3-UDK2017] Enable SueCreek

2017-09-27 Thread Wei, David
Hi Yeon Sil, Only one comment: We need to add some code in _STA to make sure that this device is only reported to OS when it is actually present on the board. We will make some change to your patch as reference. Thanks, David Wei Intel SSG/STO/UEFI BIOS From: Yoon, Yeon Sil Sent: Thursday, S

[edk2] [PATCH v3 6/6] OvmfPkg/QemuVideoDxe: Bypass NULL pointer detection during VBE SHIM installing

2017-09-27 Thread Jian J Wang
QemuVideoDxe driver will link VBE SHIM into page 0. If NULL pointer detection is enabled, this driver will fail to load. NULL pointer detection bypassing code is added to prevent such problem during boot. Please note that Windows 7 will try to access VBE SHIM during boot if it's installed, and the

[edk2] [PATCH v3 5/6] IntelFrameworkModulePkg/Csm: Add code to bypass NULL pointer detection

2017-09-27 Thread Jian J Wang
Legacy has to access interrupt vector, BDA, etc. located in memory between 0-4095. To allow as much code as possible to be monitered by NULL pointer detection, we add code to temporarily disable this feature right before those memory access and enable it again afterwards. > According to Laszlo, ge

[edk2] [PATCH v3 4/6] UefiCpuPkg/PiSmmCpuDxeSmm: Implement NULL pointer detection for SMM code

2017-09-27 Thread Jian J Wang
The mechanism behind is the same as NULL pointer detection enabled in EDK-II core. SMM has its own page table and we have to disable page 0 again in SMM mode. Cc: Star Zeng Cc: Eric Dong Cc: Laszlo Ersek Cc: Jiewen Yao Cc: Michael Kinney Cc: Jordan Justen Cc: Ayellet Wolman Suggested-by: Ay

[edk2] [PATCH v3 1/6] MdeModulePkg/MdeModulePkg.dec, .uni: Add NULL pointer detection PCD

2017-09-27 Thread Jian J Wang
From: "Wang, Jian J" > According to Star's feedback, add prompt and help string in uni file PCD PcdNullPointerDetectionPropertyMask is a bitmask used to control the NULL address detection functionality in code for different phases. If enabled, accessing NULL address in UEFI or SMM code can be c

[edk2] [PATCH v3 0/6] Add NULL pointer detection feature

2017-09-27 Thread Jian J Wang
The mechanism behind is to trigger a page fault exception at address 0. This can be made by disabling page 0 (0-4095) during page table setup. So this feature can only be available on platform with paging enabled. Once this feature is enabled, any code, like CSM, which has to access memory in page

[edk2] [PATCH v3 2/6] MdeModulePkg/DxeIpl: Implement NULL pointer detection

2017-09-27 Thread Jian J Wang
> According to Jiewen's feedback, change the page split condition > for NULL pointer detection to exclude IsExecuteDisableBitAvailable() > (Ia32/DxeLoadFunc.c) NULL pointer detection is done by making use of paging mechanism of CPU. During page table setup, if enabled, the first 4-K page (0-4095)

[edk2] [PATCH v3 3/6] MdeModulePkg/Core/Dxe: Add EndOfDxe workaround

2017-09-27 Thread Jian J Wang
One of issue caused by enabling NULL pointer detection is that some PCI device OptionROM, binary drivers and binary OS boot loaders may have NULL pointer access bugs, which will prevent BIOS from booting and is almost impossible to fix. BIT7 of PCD PcdNullPointerDetectionPropertyMask is used as a w

Re: [edk2] [Patch][edk2-platforms/devel-MinnowBoardMax-UDK2017] Change GCC shell

2017-09-27 Thread Rebecca Cran
On 9/27/2017 3:09 AM, Guo, Mang wrote: Change GCC shell from MinimumShell to UefiShell in ShellBinPkg. Thanks. I've been wondering about this now that GCC correctly sets -Os in the build options to reduce the binary size to around the same as Visual C++. -- Rebecca

Re: [edk2] [PATCH edk2-platforms v4 00/11] Update D03/D05 binary for edk2 update and bug fix.

2017-09-27 Thread Heyi Guo
Really sorry for that. We made some stupid mistake to cause the patches in a mess. Please ignore them and we will send a new series. Regards, Heyi On 2017/9/28 2:27, Leif Lindholm wrote: Hi Heyi, Apologies for delay, Connect is keeping me busy. First of all, please ensure to generate these

[edk2] [PATCH] Platform/ARM: Reorganize Lcd Graphics Output

2017-09-27 Thread evan . lloyd
From: Girish Pathak This corresponds to the recently submitted edk2 change "ArmPlatformPkg: Reorganize Lcd Graphics Output". This change enables building of a common LcdGraphicsOutputDxe, replacing PL111LcdGraphicsOutputDxe and HdLcdGraphicsOutputDxe. One of the different hardware implementatio

[edk2] [PATCH v2 2/2] ArmPkg/Include: Add SVC function IDs for Management Mode.

2017-09-27 Thread Supreeth Venkatesh
SVCs are in the range 0xC460 - 0xC47f. The functions available to the secure MM partition: 1. Signal completion of MM event handling. 2. Set/Get memory attributes for a memory region at runtime. 3. Get version number of secure partition manager. Also, it defines memory attributes required

[edk2] [PATCH v2 1/2] ArmPkg/Include: Add standard SMC function IDs for MM interface.

2017-09-27 Thread Supreeth Venkatesh
This patch adds a list of function IDs that fall under the standard SMC range as defined in http://infocenter.arm.com/help/topic/com.arm.doc.den0060a/DEN0060A_ARM_MM_Interface_Specification.pdf. SMCs associated with Management Mode are in the range 0xC440 - 0xC45f (64 bit) and 0x8440 -

Re: [edk2] [PATCH edk2-platforms v4 00/11] Update D03/D05 binary for edk2 update and bug fix.

2017-09-27 Thread Leif Lindholm
Hi Heyi, Apologies for delay, Connect is keeping me busy. First of all, please ensure to generate these patches with --no-binary. Secondly, something has gone wrong with this series: there are binary files being added to edk2-platforms and source code to edk2-non-osi. There is even the addition

Re: [edk2] [PATCH] ShellPkg/dh: Add the 'dh' dump support for Partition Info protocol

2017-09-27 Thread Carsey, Jaben
> -Original Message- > From: Wu, Hao A > Sent: Wednesday, September 27, 2017 5:43 AM > To: edk2-devel@lists.01.org > Cc: Wu, Hao A ; Ni, Ruiyu ; > Carsey, Jaben > Subject: [PATCH] ShellPkg/dh: Add the 'dh' dump support for Partition Info > protocol > Importance: High > > REF: https://bu

Re: [edk2] [Patch] BaseTools: Fix the regression bug to build single module

2017-09-27 Thread Gao, Liming
Reviewed-by: Liming Gao > -Original Message- > From: Zhu, Yonghong > Sent: Wednesday, September 27, 2017 9:22 PM > To: edk2-devel@lists.01.org > Cc: Gao, Liming > Subject: [Patch] BaseTools: Fix the regression bug to build single module > > The bug is introduced by 1b8eca to collect sin

[edk2] [Patch] BaseTools: Fix the regression bug to build single module

2017-09-27 Thread Yonghong Zhu
The bug is introduced by 1b8eca to collect single module's build time. Now the fix solution is copied from Platform build. Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Yonghong Zhu --- BaseTools/Source/Python/build/build.py | 12 1 file chan

[edk2] [PATCH] ShellPkg/dh: Add the 'dh' dump support for Partition Info protocol

2017-09-27 Thread Hao Wu
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=655 The dump information will include: a. The type of the partition (Mbr, Gpt or Other); b. Whether the partition is an EFI System Partition. Cc: Ruiyu Ni Cc: Jaben Carsey Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by:

Re: [edk2] Linux CentOS 7.3 can get DHCP IPv4 IP address with configuring DHCP server as per RFC3021

2017-09-27 Thread Karunakar P
Hi Siyuan, I've filled a New Bug in Bugzilla and following are the details. https://bugzilla.tianocore.org/show_bug.cgi?id=722 Thanks, Karunakar From: Fu, Siyuan [mailto:siyuan...@intel.com] Sent: Wednesday, September 27, 2017 1:46 PM To: Karunakar P; 'edk2-devel@lists.01.org' Cc: Wu, Jiaxin; Ye

[edk2] [Patch][edk2-platforms/devel-MinnowBoardMax-UDK2017] Change GCC shell

2017-09-27 Thread Guo, Mang
Change GCC shell from MinimumShell to UefiShell in ShellBinPkg. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Guo Mang --- Vlv2TbltDevicePkg/PlatformPkgGcc.fdf | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Vlv2TbltDevicePkg/PlatformPkgGcc.fdf b/Vl

Re: [edk2] Linux CentOS 7.3 can get DHCP IPv4 IP address with configuring DHCP server as per RFC3021

2017-09-27 Thread Fu, Siyuan
Hi, Karunakar We haven't received requirement for this feature before so we don't have plan now. I think you can submit a Bugzilla ticket for this feature request, we will follow up to investigate it. BestRegards Fu Siyuan From: Karunakar P [mailto:karunak...@amiindia.co.in] Sent: Monday, Sept

Re: [edk2] [PATCH] SecurityPkg\SmmTcg2PhysicalPresenceLib.c Handle reserved or unimplemented PP Operation

2017-09-27 Thread Yao, Jiewen
Reviewed-by: jiewen@intel.com > -Original Message- > From: Zeng, Star > Sent: Wednesday, September 27, 2017 3:57 PM > To: Zhang, Chao B ; edk2-devel@lists.01.org > Cc: Yao, Jiewen ; Zeng, Star > Subject: RE: [PATCH] SecurityPkg\SmmTcg2PhysicalPresenceLib.c Handle > reserved or unimple

Re: [edk2] [PATCH] SecurityPkg\SmmTcg2PhysicalPresenceLib.c Handle reserved or unimplemented PP Operation

2017-09-27 Thread Zeng, Star
Reviewed-by: Star Zeng -Original Message- From: Zhang, Chao B Sent: Friday, September 22, 2017 2:54 PM To: edk2-devel@lists.01.org Cc: Yao, Jiewen ; Zeng, Star ; Zhang, Chao B Subject: [PATCH] SecurityPkg\SmmTcg2PhysicalPresenceLib.c Handle reserved or unimplemented PP Operation Seve

[edk2] [Patch][edk2-platforms/devel-MinnowBoard3-UDK2017] Changed Max Baud Rate

2017-09-27 Thread Guo, Mang
Change Max Baud Rate to 115200. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Guo Mang --- .../BroxtonSiPkg/SouthCluster/Include/ScRegs/RegsLpss.h | 9 +++-- .../PeiDxeSmmPchSerialIoUartLib/PeiDxeSmmPchSerialIoUartLib.c| 3 +-- 2 files changed, 8 insert

Re: [edk2] [Patch V2] Build spec: add description for build with binary cache

2017-09-27 Thread Gao, Liming
Reviewed-by: Liming Gao >-Original Message- >From: Zhu, Yonghong >Sent: Tuesday, September 19, 2017 2:48 PM >To: edk2-devel@lists.01.org >Cc: Gao, Liming ; Kinney, Michael D >; Shaw, Kevin W >Subject: [Patch V2] Build spec: add description for build with binary cache > >V2: >change the o