Re: [edk2] [Patch] UefiCpuPkg/PiSmmCpuDxeSmm: Add check to void use null pointer.

Hao, Agree with your suggestion, I will remove the if code when I merge the change. Thanks, Eric -Original Message- From: Wu, Hao A Sent: Monday, October 9, 2017 11:39 AM To: Dong, Eric ; edk2-devel@lists.01.org Cc: Ni, Ruiyu Subject: RE:

Re: [edk2] [Patch] UefiCpuPkg/PiSmmCpuDxeSmm: Add check to void use null pointer.

> -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Eric > Dong > Sent: Monday, October 09, 2017 11:18 AM > To: edk2-devel@lists.01.org > Cc: Ni, Ruiyu > Subject: [edk2] [Patch] UefiCpuPkg/PiSmmCpuDxeSmm: Add check to void use > null pointer. > >

Re: [edk2] [Patch] UefiCpuPkg/PiSmmCpuDxeSmm: Add check to void use null pointer.

Reviewed-by: Ruiyu Ni Thanks/Ray > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Eric > Dong > Sent: Monday, October 9, 2017 11:18 AM > To: edk2-devel@lists.01.org > Cc: Ni, Ruiyu > Subject: [edk2]

Re: [edk2] [PATCH v3] Ifconfig : Fixed False information about Media State.

For me, the hard-code string looks good to me here. I'm also fine if you stick to move in UNI file. Thanks, Jiaxin > -Original Message- > From: Ni, Ruiyu > Sent: Monday, October 9, 2017 10:09 AM > To: Wu, Jiaxin ; Meenakshi Aggarwal > ;

[edk2] [Patch] UefiCpuPkg/PiSmmCpuDxeSmm: Add check to void use null pointer.

Current code logic not check the pointer before use it. This may has potential issue, this patch add code to check it. Cc: Ruiyu Ni Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Eric Dong --- UefiCpuPkg/PiSmmCpuDxeSmm/CpuS3.c |

Re: [edk2] [PATCH] MdeModulePkg/PciBus: Count multiple hotplug resource paddings

Reviewed-by: Star Zeng -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ruiyu Ni Sent: Saturday, September 30, 2017 1:11 PM To: edk2-devel@lists.01.org Cc: Laszlo Ersek Subject: [edk2] [PATCH]

Re: [edk2] [PATCH v3] Ifconfig : Fixed False information about Media State.

Do you need to put all the hard-code string in UNI file for localization? Thanks/Ray > -Original Message- > From: Wu, Jiaxin > Sent: Monday, October 9, 2017 9:29 AM > To: Meenakshi Aggarwal ; Carsey, Jaben > ; edk2-devel@lists.01.org;

Re: [edk2] MTFTP file transfer timeout error

Hi, Vabhav Sorry for the late response, I just came back from the vacation. The default retry count for tftp shell command is 6, which means the ACK packet will be retransmitted 6 times before the code goes to the Mtftp4CleanOperation() you marked below. The MTFTP driver always saves the last

Re: [edk2] [PATCH v3] Ifconfig : Fixed False information about Media State.

I agree with Jaben. If NetLibDetectMedia return error status, we can output as below: ShellPrintHiiEx (-1, -1, NULL, STRING_TOKEN (STR_IFCONFIG_INFO_MEDIA_STATE), gShellNetwork1HiiHandle, L"Media state unknown"); Thanks, Jiaxin > -Original Message- > From: Meenakshi Aggarwal

[edk2] [PATCH] MdeModulePkg/PciHostBridgeDxe: Fixed PCI DMA Map/Umap bounce buffer

The patch corrects the logic of transferring data between a bounce buffer and a real buffer above 4GB: 1. In the case of mapping a bounce buffer for the write operation, data from a real buffer should be copied into a bounce buffer. 2.In the case of unmapping a bounce buffer for the read

[edk2] [platforms: PATCH v2 4/5] Marvell/Drivers: Pp2Dxe: Rework PHY handling

Hitherto PHY handling in Pp2Dxe was not flexible. It allowed for using only single MDIO controller, which may not be true on Armada 80x0 SoCs. For this purpose introduce the MDIO description, using the new structures and template in MvHwDescLib. This change enables addition of multiple CP110

[edk2] [platforms: PATCH v2 5/5] Platform/Marvell/Armada: Remove ParsePcdLib

Current PCD handling in libraries and drivers allow to get rid of this code. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marcin Wojtas Reviewed-by: Leif Lindholm Reviewed-by: Ard Biesheuvel ---

[edk2] [platforms: PATCH v2 3/5] Marvell/Library: UtmiLib: Move devices description to MvHwDescLib

This patch introduces UTMI description, using the new structures and template in MvHwDescLib. This change enables more flexible addition of multiple CP with UTMI PHY's and also significantly reduces amount of used PCD's for that purpose. Update PortingGuide documentation accordingly. This patch

[edk2] [platforms: PATCH v2 1/5] Marvell/Library: ComPhyLib: Remove PCD string parsing

Simplify obtaining lane data, using arrays with direct enum values, rather than strings. This is another step to completely remove ParsePcdLib. This patch replaces string-based description of ComPhy lanes on Armada 70x0 DB with the enum values of type and speed - for that purpose new [Defines]

[edk2] [platforms: PATCH v2 2/5] Marvell/Drivers: MvI2cDxe: Move devices description to MvHwDescLib

This patch introduces I2c description, using the new structures and template in MvHwDescLib. This change enables more flexible addition of multiple I2c controllers and also allows for removal of string PCD parsing. Update Armada 70x0 DB description and PortingGuide accordingly. Contributed-under:

[edk2] [platforms: PATCH v2 0/5] Armada 7k/8k - ParsePcdLib removal

Hi, This is a second version of the patchset with the complete removal of ParsePcdLib and cleanup of boards' PCD representation. According to v1 remarks, I modified PCD names and introduced macros in Armada.dsc.inc, so that the readability of boards .dsc could increse. More details can befound in

Re: [edk2] [PATCH v3] Ifconfig : Fixed False information about Media State.

It is hard to say when can an API fail because its dependent on implementation. > -Original Message- > From: Carsey, Jaben [mailto:jaben.car...@intel.com] > Sent: Friday, October 06, 2017 7:32 PM > To: Meenakshi Aggarwal ; edk2- > de...@lists.01.org; Wu,