Re: [edk2] [patch] Security/OpalHii.c: Handle NULL Request or Request with no elements

2017-10-15 Thread Dong, Eric
Reviewed-by: Eric Dong > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Dandan Bi > Sent: Monday, October 16, 2017 11:37 AM > To: edk2-devel@lists.01.org > Cc: Dong, Eric ; Zhang, Chao B >

[edk2] [patch] Security/OpalHii.c: Handle NULL Request or Request with no elements

2017-10-15 Thread Dandan Bi
According to UEFI spec, for the ExtractConfig function in EFI_HII_CONFIG_ACCESS_PROTOCOL,If a NULL is passed in for the Request field or if a ConfigHdr is passed in with no request elements, all of the settings being abstracted by this function will be returned in the Results field. The

Re: [edk2] [PATCH 0/4] Update MTRR algorithm to calculate optimal settings

2017-10-15 Thread Ni, Ruiyu
I have tested to boot OVMF 32PEI+64DXE. I have tested using random memory settings: 1. Generate random memory settings and tried to convert the settings to MTRRs. 2. Read back the MTRRs and verify the settings match to the desired memory settings. Thanks/Ray > -Original Message- >

Re: [edk2] [PATCH 1/1] MdePkg/IoLib: Add support for big-endian MMIO

2017-10-15 Thread Gao, Liming
Meenakshi: I suggest to introduce new IoLib library instance, not to add new IoLib APIs. New IoLib library instance will perform IO operation as the big endian. You can update MdePkg/Library/BaseIoLibIntrinsic instance, add new source file and new INF for it. UINT32 EFIAPI MmioRead32 ( IN

Re: [edk2] [PATCH 0/4] Update MTRR algorithm to calculate optimal settings

2017-10-15 Thread Yao, Jiewen
Thanks. Would you mind to share to all of us on which platform has been tested and which unit test has been done? As such people can have more confidence. With the test description message added, reviewed-by: jiewen@intel.com Thank you Yao Jiewen > -Original Message- > From:

Re: [edk2] [PATCH] SecurityPkg:AuthVariableLib:Implement ECR1707 for Private Auth Variable

2017-10-15 Thread Gary Lin
On Thu, Oct 12, 2017 at 05:14:25PM +0800, Zhang, Chao B wrote: > ECR1707 for UEFI2.7 clarified certificate management rule for private > time-based > AuthVariable.Trusted cert rule changed from whole signer's certificate stack > to > top-level issuer cert tbscertificate + SignerCert CN for

Re: [edk2] [PATCH 5/5] Platforms/AMD/Overdrive: add signed capsule update support

2017-10-15 Thread Ard Biesheuvel
On 15 October 2017 at 20:10, Leif Lindholm wrote: > On Sun, Oct 15, 2017 at 10:54:53AM +0100, Ard Biesheuvel wrote: >> Wire up the various modules and boilerplate configuration snippets >> to implement signed capsule update for AMD Overdrive. Note that this >> uses the

Re: [edk2] [PATCH 5/5] Platforms/AMD/Overdrive: add signed capsule update support

2017-10-15 Thread Leif Lindholm
On Sun, Oct 15, 2017 at 10:54:53AM +0100, Ard Biesheuvel wrote: > Wire up the various modules and boilerplate configuration snippets > to implement signed capsule update for AMD Overdrive. Note that this > uses the insecure default key. > > The secure firmware on this SoC does not implement warm

Re: [edk2] [PATCH v5 1/2] UefiCpuPkg/SmmCpuFeaturesLib: Use global variables to replace macros

2017-10-15 Thread Paolo Bonzini
On 14/10/2017 17:51, Duran, Leo wrote: >>> + // Override PSD offset for AMD >>> + // >>> + if (SmmStandardSignatureIsAuthenticAMD ()) { >>> +gStmPsdOffset = AMD_SMM_PSD_OFFSET; } >>> + >> I think the right thing to do here would be to use the SMM state save map >> revision; in the case of

[edk2] [PATCH 3/5] Silicon/Amd/Styx: fix flasher support

2017-10-15 Thread Ard Biesheuvel
The StyxFlashUefi application was not migrated correctly from OpenPlatformPkg to edk2-platforms. It will be superseded shortly by capsule update support, but let's put it back into a working state before we remove it. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard

[edk2] [PATCH 2/5] Silicon/AMD/Styx: update SMMU id to MMU-401

2017-10-15 Thread Ard Biesheuvel
The IORT spec has been updated to include more specific defines for the MMU-401, which supports more page sizes than the generic SMMU v1. Note that this requires an OS that understands these new definitions. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel

[edk2] [PATCH 1/5] Platform/AMD/Overdrive: remove StatusCodeLib references

2017-10-15 Thread Ard Biesheuvel
This fixes a reboot issue, which is caused by the inclusion of the wrong flavor of StatusCodeLib into ResetSystemRuntimeDxe. However, we don't use status codes in the first place, so let's replace all occurrences with the NULL resolution. Contributed-under: TianoCore Contribution Agreement 1.1

[edk2] [PATCH 0/5] Platform/AMD/Overdrive: implement capsule support + some fixes

2017-10-15 Thread Ard Biesheuvel
This implements signed capsule update for AMD overdrive. Due to the lack of support for warm reboot in the secure firmware, this only works from the boot environment, not from the OS. To update, build CapsuleApp [from MdeModulePkg] and issue the following command FS0:> CapsuleApp

[edk2] [PATCH 5/5] Platforms/AMD/Overdrive: add signed capsule update support

2017-10-15 Thread Ard Biesheuvel
Wire up the various modules and boilerplate configuration snippets to implement signed capsule update for AMD Overdrive. Note that this uses the insecure default key. The secure firmware on this SoC does not implement warm reboot, so we cannot support capsules that persist across reset. Instead,

[edk2] [PATCH 4/5] Silicon/AMD/Styx: add PlatformFlashAccessLib implementation

2017-10-15 Thread Ard Biesheuvel
In preparation of adding capsule support to the AMD Styx aka Seattle based platforms, implement a PlatformFlashAccessLib instance that invokes the ISCP to update the FV containing our UEFI image. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel