Re: [edk2] [PATCH] ShellPkg: Fix type mismatch with GCC

2017-10-29 Thread Gao, Liming
That's good. >-Original Message- >From: Ni, Ruiyu >Sent: Monday, October 30, 2017 1:25 PM >To: Gao, Liming ; Alcantara, Paulo ; >Carsey, Jaben ; edk2-devel@lists.01.org >Subject: RE: [PATCH] ShellPkg: Fix type mismatch with GCC

Re: [edk2] [PATCH] ShellPkg: Fix type mismatch with GCC

2017-10-29 Thread Ni, Ruiyu
I have a pending task to remove the dependency of InternalCharToUpper(). Below two bugs require the same fix. 664 [Shell] UnicodeCollation->StriColl() should be used to replace StrinCmp in UefiShellLevel2CommandsLib 294 Strnicmp() should use UNICODE_COLLATION.StrUpr() instead of converting

Re: [edk2] [PATCH] ShellPkg: Fix type mismatch with GCC

2017-10-29 Thread Gao, Liming
I suggest to rename it and add its implementation in ShellPkg. We don't expect to use the internal function from another library or driver. Another way is to propose adding StrniCmp() API into BaseLib. Thanks Liming >-Original Message- >From: edk2-devel

[edk2] [RFC] MdeModulePkg/NonDiscoverablePciDeviceDxe: NonCoherentPciIoAllocateBuffer issue with AArch64

2017-10-29 Thread Heyi Guo
Hi folks, In NonDiscoverablePciDeviceDxe driver, NonCoherentPciIoAllocateBuffer may allocate EFI_MEMORY_UC buffer depending on input Attributes and GCD capabilities. If it does, it actually allocates memory of "device" type in AArch64, but not "normal uncacheable" memory. For "device" memory

Re: [edk2] [Patch][edk2-platforms/devel-MinnowBoard3-UDK2017] Build script.

2017-10-29 Thread Wei, David
Reviewed-by: zwei4 Thanks, David Wei Intel SSG/STO/UEFI BIOS > -Original Message- > From: Lu, ShifeiX A > Sent: Monday, October 30, 2017 9:59 AM > To: edk2-devel@lists.01.org > Cc: Wei, David > Subject:

[edk2] [Patch][edk2-platforms/devel-MinnowBoard3-UDK2017] Build script.

2017-10-29 Thread lushifex
Enhance build script. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jarlstrom, Laurie Signed-off-by: lushifex --- BuildBIOS.bat| 104 + BuildBIOS.sh

Re: [edk2] [PATCH V3 0/2] IntelSiliconPkg: Add Pre-Memory DMA protection in PEI

2017-10-29 Thread Zeng, Star
Reviewed-by: Star Zeng -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Jiewen Yao Sent: Friday, October 27, 2017 8:28 PM To: edk2-devel@lists.01.org Cc: Zeng, Star Subject: [edk2] [PATCH V3 0/2]

Re: [edk2] [platforms: PATCH v3 00/10] Armada 7k/8k - misc improvements pt.2

2017-10-29 Thread Leif Lindholm
On Fri, Oct 27, 2017 at 06:31:43PM +0200, Marcin Wojtas wrote: > Hi, > > I send v3 with minor fixes, requested in latest review. Details > can be found in the changelog below. > > The patches are available in the github: >