Re: [edk2] [PATCH] BaseTools/tools_def: suppress GCC predefined macros in DTB compilation

Ard: I have no other comments. Reviewed-by: Liming Gao Thanks Liming >-Original Message- >From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] >Sent: Thursday, October 26, 2017 6:12 PM >To: edk2-devel@lists.01.org >Cc: leif.lindh...@linaro.org; Gao, Liming

Re: [edk2] Storing Non volatile variables on SD/NAND

Thanks Jeremy > Hi, > > On 10/27/2017 10:09 PM, Udit Kumar wrote: > >> (along those lines) > >> > >> 6 - Build an emulated disk controller as well as NV region in el3 (or > >> el2) and export them to UEFI & the OS as real devices. Then > >> trap/forward requests to the actual storage device,

[edk2] [PATCH 1/2] MdeModulePkg/EmmcBlockIoPei: Support IoMmu

Update the EmmcBlockIoPei driver to consume IOMMU_PPI to allocate DMA buffer. If no IOMMU_PPI exists, this driver still calls PEI service to allocate DMA buffer, with assumption that DRAM==DMA. This is a compatible change. Cc: Star Zeng Cc: Jiewen Yao

[edk2] [PATCH 2/2] MdeModulePkg/SdBlockIoPei: Support IoMmu

Update the SdBlockIoPei driver to consume IOMMU_PPI to allocate DMA buffer. If no IOMMU_PPI exists, this driver still calls PEI service to allocate DMA buffer, with assumption that DRAM==DMA. This is a compatible change. Cc: Star Zeng Cc: Jiewen Yao

[edk2] [PATCH 0/2] IoMMu support for SD/eMMC PEI stack

The series adds the IoMMu support for the SD/eMMC PEI stack. Cc: Star Zeng Cc: Jiewen Yao Hao Wu (2): MdeModulePkg/EmmcBlockIoPei: Support IoMmu MdeModulePkg/SdBlockIoPei: Support IoMmu MdeModulePkg/Bus/Sd/EmmcBlockIoPei/DmaMem.c | 249

[edk2] [platforms: PATCH 4/6] Marvell/Applications: SpiTool: Do not override existing slave device

Current usage of sf command requires running 'sf probe' prior to executing any other option. Because it is done in two separate steps, it turned out that SpiMasterProtocol->SetupDevice could easily overwrite valid Slave pointer when performing second operation. Fix the issue by allocating Slave

[edk2] [platforms: PATCH 5/6] Marvell/Drivers: MvSpiFlash: Fix bank selection for Spansion

Spansion SPI flash devices use different command for bank selection. Update it, basing on the first byte of flash ID. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marcin Wojtas --- Platform/Marvell/Drivers/Spi/Devices/MvSpiFlash.c | 5 +

[edk2] [platforms: PATCH 6/6] Marvell/Drivers: MvSpiDxe: Keep data in SPI_DEVICE structure

In the MvSpiDxe driver obtaining host register base address, controller clock and device maximum frequency directly from PCDs was done all over the code. This patch cleans up the parameters' handling and enables accessing them from SPI_DEVICE structure fields. Contributed-under: TianoCore

[edk2] [platforms: PATCH 2/6] Marvell/Drivers: MvSpiFlash: Enable dynamic SPI Flash detection

Hitherto mechanism of fixing SPI flash model in the PCDs, occured to be very inefficient and problematic. Enable dynamic detection by reworking MvSpiFlashReadId() command, which now uses newly added NorFlashInfoLib, that helps to obtain description of the JEDEC compliant devices. This patch

[edk2] [platforms: PATCH 3/6] Marvell/Drivers: MvSpiFlash: Remove duplicated macros

Flash commands macros are already defined locally, so remove them from the protocol header. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marcin Wojtas --- Platform/Marvell/Include/Protocol/SpiFlash.h | 11 --- 1 file changed, 11 deletions(-)

[edk2] [platforms: PATCH 0/6] Armada 7k/8k SPI improvements pt 2.

Hi, I submit a series, which comprises a major rework allowing to make use of dynamic SPI NOR flash detection with recently implemented NorFlashInfoLib. Comparing to initial version of the patches, apart from the flash info table extraction, also the functional changes around ReadId are taken

[edk2] [PATCH v2] MdeModulePkg/UfsBlockIoPei: Support IoMmu

V2 changes: Resource cleanup logic update in UfsEndOfPei(). V1 history: Update the UfsBlockIoPei driver to consume IOMMU_PPI to allocate DMA buffer. If no IOMMU_PPI exists, this driver still calls PEI service to allocate DMA buffer, with assumption that DRAM==DMA. This is a compatible change.

[edk2] [PATCH v2] MdePkg: Add definitions for the SPI protocols introduced in PI 1.6.

This commit adds header files for the SPI protocols introduced in the UEFI PI 1.6 specification, as well as their GUIDs to MdePkg.dec. EFI_SPI_TRANSACTION_TYPE assumes an enum with its members ordered the way they are listed in the specification, as there are no values given explicitely.

Re: [edk2] Storing Non volatile variables on SD/NAND

Hi, On 10/27/2017 10:09 PM, Udit Kumar wrote: (along those lines) 6 - Build an emulated disk controller as well as NV region in el3 (or el2) and export them to UEFI & the OS as real devices. Then trap/forward requests to the actual storage device, which is "hidden". This AFAIK was the basic

[edk2] [PATCH 1/1] EmbeddedPkg: Implement NorFlashLib

The SPI NOR flash drivers which base on ArmPlatformPkg's NorFlashDxe usually make use of static declarations of the flash instances with their type and parameters. As a result it implies hardcoding the exact way flash handling, not to mention the code does not look very nice. Much better solution

Re: [edk2] [RFC] MdeModulePkg/NonDiscoverablePciDeviceDxe: NonCoherentPciIoAllocateBuffer issue with AArch64

On 30 October 2017 at 15:13, Heyi Guo wrote: > Hi Ard, > > > On 10/30/2017 04:21 PM, Ard Biesheuvel wrote: >> >> On 30 October 2017 at 03:52, Heyi Guo wrote: >>> >>> Hi folks, >>> >>> In NonDiscoverablePciDeviceDxe driver, NonCoherentPciIoAllocateBuffer

Re: [edk2] [RFC] MdeModulePkg/NonDiscoverablePciDeviceDxe: NonCoherentPciIoAllocateBuffer issue with AArch64

Hi Ard, On 10/30/2017 04:21 PM, Ard Biesheuvel wrote: On 30 October 2017 at 03:52, Heyi Guo wrote: Hi folks, In NonDiscoverablePciDeviceDxe driver, NonCoherentPciIoAllocateBuffer may allocate EFI_MEMORY_UC buffer depending on input Attributes and GCD capabilities. If it

Re: [edk2] [PATCH] MdeModulePkg/NonDiscoverable: fix memory override bug

Hi Ray, It seems Ard already provided his R-B :) Thanks. Heyi On 10/30/2017 06:23 PM, Ni, Ruiyu wrote: I will wait for Ard's feedback. It's an ARM specific module. Thanks/Ray -Original Message- From: Zeng, Star Sent: Monday, October 30, 2017 6:07 PM To: Ni, Ruiyu

Re: [edk2] [PATCH] ShellPkg: Fix type mismatch with GCC

Ruiyu, Thanks for letting me know. I agree with below changes and they look good to me. Please go ahead and fix them. Hopefully I'll get a chance to review/test it. Paulo -Original Message- From: Gao, Liming [mailto:liming@intel.com] Sent: Monday, October 30, 2017 3:27 AM To:

Re: [edk2] [PATCH] MdeModulePkg/NonDiscoverable: fix memory override bug

I will wait for Ard's feedback. It's an ARM specific module. Thanks/Ray > -Original Message- > From: Zeng, Star > Sent: Monday, October 30, 2017 6:07 PM > To: Ni, Ruiyu ; Heyi Guo ; linaro- > u...@lists.linaro.org; edk2-devel@lists.01.org > Cc:

Re: [edk2] [PATCH] MdeModulePkg/NonDiscoverable: fix memory override bug

Ray, Please help take a review to this patch. Thanks, Star -Original Message- From: Heyi Guo [mailto:heyi@linaro.org] Sent: Monday, October 30, 2017 1:48 PM To: linaro-u...@lists.linaro.org; edk2-devel@lists.01.org Cc: Heyi Guo ; Zeng, Star

Re: [edk2] [Patch][edk2-platforms/devel-MinnowBoard3-UDK2017] Add I2C table.

Reviewed-by: zwei4 Thanks, David Wei Intel SSG/STO/UEFI BIOS > -Original Message- > From: Lu, ShifeiX A > Sent: Monday, October 30, 2017 5:06 PM > To: edk2-devel@lists.01.org > Cc: Wei, David > Subject:

[edk2] [Patch][edk2-platforms/devel-MinnowBoard3-UDK2017] Add I2C table.

Add I2C table for on-board WM8731 I2S audio. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: lushifex --- .../PlatformSsdt/Audio/AudioCodec_INT343A.asl | 17 + 1 file changed, 5 insertions(+), 12 deletions(-) diff --git

[edk2] [Patch][edk2-platforms/devel-MinnowBoard3-UDK2017] Enable audio.

Enable on-board audio. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: lushifex --- .../PlatformSsdt/Audio/AudioCodec_INT343A.asl | 17 + 1 file changed, 5 insertions(+), 12 deletions(-) diff --git

Re: [edk2] [RFC] MdeModulePkg/NonDiscoverablePciDeviceDxe: NonCoherentPciIoAllocateBuffer issue with AArch64

On 30 October 2017 at 03:52, Heyi Guo wrote: > Hi folks, > > In NonDiscoverablePciDeviceDxe driver, NonCoherentPciIoAllocateBuffer may > allocate EFI_MEMORY_UC buffer depending on input Attributes and GCD > capabilities. If it does, it actually allocates memory of "device"

Re: [edk2] [PATCH] MdeModulePkg/NonDiscoverable: fix memory override bug

On 30 October 2017 at 05:47, Heyi Guo wrote: > For PciIoPciRead interface, memory prior to Buffer would be written > with zeros if Offset was larger than sizeof (Dev->ConfigSpace), which > would cause serious system exception. > > So we add a pre-check branch to avoid memory