[edk2] [PATCH] EmbeddedPkg/PrePiLib: add support for v2 sections

2017-12-10 Thread Michael Zimmermann
Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Michael Zimmermann --- EmbeddedPkg/Library/PrePiLib/FwVol.c | 63 1 file changed, 51 insertions(+), 12 deletions(-) diff --git a/EmbeddedPkg/Library/PrePiLib/FwVol.c b/EmbeddedPkg/Library/PrePiLib/FwVol.c

Re: [edk2] PrePiLib's FwVol.c can't handle padding before volume header

2017-12-10 Thread Michael Zimmermann
without the big file at the end it looks very similar: c4 cc 4a 17 00 00 00 00 00 00 00 00 00 00 00 00 |..J.| 0010 00 00 00 00 78 e5 8c 8c 3d 8a 1c 4f 99 35 89 61 |x...=..O.5.a| 0020 85 c3 2d d3 c0 cc 4a 00 00 00 00 00 5f 46 56 48 |..-...J._FVH| 003

Re: [edk2] [PATCH 0/3] Correct function description for ALLOCATE_BUFFER

2017-12-10 Thread Yao, Jiewen
Reviewed-by: jiewen@intel.com > -Original Message- > From: Zeng, Star > Sent: Monday, December 11, 2017 2:54 PM > To: edk2-devel@lists.01.org > Cc: Zeng, Star ; Yao, Jiewen ; Ni, > Ruiyu ; Gao, Liming ; Kinney, > Michael D > Subject: [PATCH 0/3] Correct function description for ALLOCA

Re: [edk2] [PATCH 0/3] Correct function description for ALLOCATE_BUFFER

2017-12-10 Thread Ni, Ruiyu
Reviewed-by: Ruiyu Ni Thanks/Ray > -Original Message- > From: Zeng, Star > Sent: Monday, December 11, 2017 2:54 PM > To: edk2-devel@lists.01.org > Cc: Zeng, Star ; Yao, Jiewen ; > Ni, Ruiyu ; Gao, Liming ; Kinney, > Michael D > Subject: [PATCH 0/3] Correct function description for ALLOC

[edk2] [PATCH 3/3] IntelSilicon: Correct function description for AllocateBuffer

2017-12-10 Thread Star Zeng
DUAL_ADDRESS_CYCLE is missing in the EFI_UNSUPPORTED return status description. Cc: Jiewen Yao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Star Zeng --- IntelSiliconPkg/Feature/VTd/IntelVTdDxe/BmDma.c | 2 +- IntelSiliconPkg/Feature/VTd/IntelVTdDxe/IntelVT

[edk2] [PATCH 0/3] Correct function description for ALLOCATE_BUFFER

2017-12-10 Thread Star Zeng
According to UEFI spec, DUAL_ADDRESS_CYCLE is missing in the EFI_UNSUPPORTED return status description for ALLOCATE_BUFFER interface. Same issue is also in IOMMU interface. Cc: Jiewen Yao Cc: Ruiyu Ni Cc: Liming Gao Cc: Michael D Kinney Star Zeng (3): MdePkg PciIo.h: Correct function descri

[edk2] [PATCH 2/3] MdeModulePkg: Correct function description for AllocateBuffer

2017-12-10 Thread Star Zeng
DUAL_ADDRESS_CYCLE is missing in the EFI_UNSUPPORTED return status description. Cc: Jiewen Yao Cc: Ruiyu Ni Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Star Zeng --- MdeModulePkg/Bus/Pci/PciBusDxe/PciIo.c | 4 ++-- MdeModulePkg/Bus/Pci/PciBusDxe/PciIo.h | 4 ++-- Mde

[edk2] [PATCH 1/3] MdePkg PciIo.h: Correct function description for ALLOCATE_BUFFER

2017-12-10 Thread Star Zeng
DUAL_ADDRESS_CYCLE is missing in the EFI_UNSUPPORTED return status description. Cc: Jiewen Yao Cc: Ruiyu Ni Cc: Liming Gao Cc: Michael D Kinney Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Star Zeng --- MdePkg/Include/Protocol/PciIo.h | 4 ++-- 1 file changed, 2 ins

Re: [edk2] [PATCH] SecurityPkg:Tcg2Smm: Add MSFT copyright

2017-12-10 Thread Long, Qin
Reviewed-by: Long Qin Best Regards & Thanks, LONG, Qin -Original Message- From: Zhang, Chao B Sent: Monday, December 11, 2017 9:34 AM To: edk2-devel@lists.01.org Cc: Long, Qin ; Yao, Jiewen ; Zhang, Chao B Subject: [PATCH] SecurityPkg:Tcg2Smm: Add MSFT copyright Add MSFT copyright f

Re: [edk2] [Patch] Build spec: Add clarification for the binary cache files

2017-12-10 Thread Gao, Liming
Reviewed-by: Liming Gao >-Original Message- >From: Zhu, Yonghong >Sent: Monday, December 04, 2017 11:45 AM >To: edk2-devel@lists.01.org >Cc: Gao, Liming ; Kinney, Michael D >; Shaw, Kevin W >Subject: [Patch] Build spec: Add clarification for the binary cache files > >Add clarification fo

[edk2] [PATCH 2/2] MdeModulePkg/PiSmmCore: Fix issues in Heap Guard

2017-12-10 Thread Jian J Wang
One issue is that macros defined in HeapGuard.h GUARD_HEAP_TYPE_PAGE GUARD_HEAP_TYPE_POOL doesn't match the definition of PCD PcdHeapGuardPropertyMask in MdeModulePkg.dec. This patch fixed it by exchanging the BIT0 and BIT1 of them. Another is that method AdjustMemoryF() will return a bi

[edk2] [PATCH 0/2] Fix issues in Heap Guard

2017-12-10 Thread Jian J Wang
One issue is that macros defined in HeapGuard.h GUARD_HEAP_TYPE_PAGE GUARD_HEAP_TYPE_POOL doesn't match the definition of PCD PcdHeapGuardPropertyMask in MdeModulePkg.dec. This patch fixed it by exchanging the BIT0 and BIT1 of them. Another is that method AdjustMemoryF() will return a bi

[edk2] [PATCH 1/2] MdeModulePkg/DxeCore: Fix issues in Heap Guard

2017-12-10 Thread Jian J Wang
One issue is that macros defined in HeapGuard.h GUARD_HEAP_TYPE_PAGE GUARD_HEAP_TYPE_POOL doesn't match the definition of PCD PcdHeapGuardPropertyMask in MdeModulePkg.dec. This patch fixed it by exchanging the BIT0 and BIT1 of them. Another is that method AdjustMemoryF() will return a bi

[edk2] [PATCH] SecurityPkg:Tcg2Smm: Add MSFT copyright

2017-12-10 Thread Zhang, Chao B
Add MSFT copyright for TPM SIRQ feature. Cc: Long Qin Cc: Jiewen Yao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Chao Zhang --- SecurityPkg/Tcg/Tcg2Smm/Tpm.asl | 1 + 1 file changed, 1 insertion(+) diff --git a/SecurityPkg/Tcg/Tcg2Smm/Tpm.asl b/SecurityPkg/Tcg/Tcg2S

Re: [edk2] [Patch v2] MdeModulePkg: Free NET_BUF data after it is sent out to avoid memory leak

2017-12-10 Thread Fu, Siyuan
Reviewed-by: Fu Siyuan > -Original Message- > From: Wang, Fan > Sent: Monday, November 27, 2017 2:44 PM > To: edk2-devel@lists.01.org > Cc: Wu, Jiaxin ; Ye, Ting ; Fu, > Siyuan ; Wang, Fan > Subject: [Patch v2] MdeModulePkg: Free NET_BUF data after it is sent out > to avoid memory leak >

Re: [edk2] [PATCH] MdeModulePkg/ScsiDisk: Return EFI_NO_MEDIA when no media presents

2017-12-10 Thread Zeng, Star
Reviewed-by: Star Zeng -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ruiyu Ni Sent: Thursday, December 7, 2017 5:55 PM To: edk2-devel@lists.01.org Cc: Wu, Hao A ; Zeng, Star Subject: [edk2] [PATCH] MdeModulePkg/ScsiDisk: Return EFI_NO_MEDIA whe

Re: [edk2] [PATCH] MdeModulePkg: loose VA_COPY with no matching VA_END on a return path

2017-12-10 Thread Zeng, Star
Reviewed-by: Star Zeng and pushed at a0460be7e88539649cd10139491dd6955c54fb14. Thanks, Star -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Zenith432 Sent: Sunday, December 10, 2017 1:05 AM To: edk2-devel@lists.01.org Subject: [edk2] [PATCH] Mde

Re: [edk2] PrePiLib's FwVol.c can't handle padding before volume header

2017-12-10 Thread Ard Biesheuvel
On 10 December 2017 at 22:18, Michael Zimmermann wrote: > Exactly. If I shift the pointer by 4 bytes from within PrePiLib the device > boots just fine. > > I'm not sure if the size is the root cause but right now it only happens > when adding a ~15mb binary efi to the end of fvmain. > It appears

Re: [edk2] PrePiLib's FwVol.c can't handle padding before volume header

2017-12-10 Thread Michael Zimmermann
Exactly. If I shift the pointer by 4 bytes from within PrePiLib the device boots just fine. I'm not sure if the size is the root cause but right now it only happens when adding a ~15mb binary efi to the end of fvmain. On Dec 10, 2017 11:13 PM, "Ard Biesheuvel" wrote: On 10 December 2017 at 21:5

Re: [edk2] PrePiLib's FwVol.c can't handle padding before volume header

2017-12-10 Thread Ard Biesheuvel
On 10 December 2017 at 21:58, Michael Zimmermann wrote: > VolInfo doesn't seem to complain about FVMAIN_COMPACT.Fv: > https://pastebin.com/ueUnepXF > > Does VolInfo support Fs's as well? because it fails on mine(even on a > working one). > You mean to dissect the FFS that contains the FV? Not sur

Re: [edk2] PrePiLib's FwVol.c can't handle padding before volume header

2017-12-10 Thread Michael Zimmermann
VolInfo doesn't seem to complain about FVMAIN_COMPACT.Fv: https://pastebin.com/ueUnepXF Does VolInfo support Fs's as well? because it fails on mine(even on a working one). On Sun, Dec 10, 2017 at 10:49 PM, Ard Biesheuvel wrote: > On 10 December 2017 at 21:45, Michael Zimmermann > wrote: >> The

Re: [edk2] PrePiLib's FwVol.c can't handle padding before volume header

2017-12-10 Thread Ard Biesheuvel
On 10 December 2017 at 21:45, Michael Zimmermann wrote: > The layout is basically the same as in ArmVirtQemuKernel.fdf but I've > changed the size to 8MB and these are the usage stats: > FV Space Information > FVMAINDEVICE [99%Full] 57856 total, 57800 used, 56 free > FVMAINMSM8960 [99%Full] 222336

Re: [edk2] PrePiLib's FwVol.c can't handle padding before volume header

2017-12-10 Thread Michael Zimmermann
The layout is basically the same as in ArmVirtQemuKernel.fdf but I've changed the size to 8MB and these are the usage stats: FV Space Information FVMAINDEVICE [99%Full] 57856 total, 57800 used, 56 free FVMAINMSM8960 [99%Full] 222336 total, 222312 used, 24 free FVMAIN_COMPACT [63%Full] 8380416 total

Re: [edk2] PrePiLib's FwVol.c can't handle padding before volume header

2017-12-10 Thread Ard Biesheuvel
On 10 December 2017 at 21:22, Ard Biesheuvel wrote: > cc BaseTools maintainers > > On 10 December 2017 at 20:58, Michael Zimmermann > wrote: >> 'uefitool' shows me that there are 4 bytes of padding right before >> FVMAIN when adding large(20MB) uncompressed FV's. >> >> FwVol fails detecting that

Re: [edk2] PrePiLib's FwVol.c can't handle padding before volume header

2017-12-10 Thread Ard Biesheuvel
cc BaseTools maintainers On 10 December 2017 at 20:58, Michael Zimmermann wrote: > 'uefitool' shows me that there are 4 bytes of padding right before > FVMAIN when adding large(20MB) uncompressed FV's. > > FwVol fails detecting that and complains about the signature not being > correct. > > Than

[edk2] PrePiLib's FwVol.c can't handle padding before volume header

2017-12-10 Thread Michael Zimmermann
'uefitool' shows me that there are 4 bytes of padding right before FVMAIN when adding large(20MB) uncompressed FV's. FwVol fails detecting that and complains about the signature not being correct. Thanks Michael ___ edk2-devel mailing list edk2-devel@li

Re: [edk2] [PATCH 4/4] BaseTools: resolve initialization order errors in VfrFormPkg.h

2017-12-10 Thread Zenith432
On 10/12/2017 03:52 PM, Gao, Liming wrote: I think these patches resolves CLANG build issues in BaseTools. Do you verify them with GCC or VS tool chain? GCC 7.2 does not give any of the warnings generated by clang while compiling BaseTools. After applying the 4 BaseTools patches, it still doe

Re: [edk2] [PATCH] MdePkg: correct and clarify documentation of VA_LIST in Base.h

2017-12-10 Thread Zenith432
On 10/12/2017 03:53 PM, Gao, Liming wrote: Could you add bug 457 link in the commit message? --- Subject: [PATCH] MdePkg: correct and clarify documentation of VA_LIST in Base.h This is to resolve bug 457. https://bugzilla.tianocore.org/show_bug.cgi?id=457 Contributed-under: TianoCore Contribut

Re: [edk2] [PATCH] MdePkg: resolve bug 741

2017-12-10 Thread Zenith432
On 10/12/2017 15:52, Gao, Liming wrote: > For 4, 'unsigned char' goes default argument promotion to int. This is CLANG compiler behavior. Does GCC and VS compiler follow this rule? > > Disable varargs warning is the temp solution. For long term, we expect to figure out the compatible solution.

Re: [edk2] [PATCH] MdePkg: correct and clarify documentation of VA_LIST in Base.h

2017-12-10 Thread Gao, Liming
Could you add bug 457 link in the commit message? > -Original Message- > From: Zenith432 [mailto:zenith...@users.sourceforge.net] > Sent: Sunday, December 10, 2017 5:32 PM > To: edk2-devel@lists.01.org > Cc: Kinney, Michael D ; Gao, Liming > > Subject: [PATCH] MdePkg: correct and clarif

Re: [edk2] [PATCH] MdePkg: resolve bug 741

2017-12-10 Thread Gao, Liming
For 4, 'unsigned char' goes default argument promotion to int. This is CLANG compiler behavior. Does GCC and VS compiler follow this rule? Disable varargs warning is the temp solution. For long term, we expect to figure out the compatible solution. If all supported compilers follow this rule, I

Re: [edk2] [PATCH 4/4] BaseTools: resolve initialization order errors in VfrFormPkg.h

2017-12-10 Thread Gao, Liming
I think these patches resolves CLANG build issues in BaseTools. Do you verify them with GCC or VS tool chain? > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Zenith432 > Sent: Saturday, December 9, 2017 10:45 PM > To: edk2-devel@lists.01.or

Re: [edk2] [PATCH v3 4/6] ArmPkg/Library/CompilerIntrinsicsLib: Enable VS2017/ARM builds

2017-12-10 Thread Gao, Liming
Include ArmPkg maintainers for review. > -Original Message- > From: Pete Batard [mailto:p...@akeo.ie] > Sent: Friday, December 8, 2017 10:06 PM > To: edk2-devel@lists.01.org > Cc: Gao, Liming > Subject: [PATCH v3 4/6] ArmPkg/Library/CompilerIntrinsicsLib: Enable > VS2017/ARM builds > >

Re: [edk2] [PATCH edk2-platforms] [PATCH v3 2/9] Platform/NXP : Add support for Watchdog driver

2017-12-10 Thread Gao, Liming
Leif: I have no strong opinion. PI spec doesn't require WdogRegisterHandler must be supported. So, this implementation doesn't break spec. For this platform, if there is no register handler or no critical register handler, this Watchdog driver can be used. Thanks Liming > -Original Messa

Re: [edk2] [PATCH] MdePkg/Uefi ARM: only support native ARM/Thumb images

2017-12-10 Thread Gao, Liming
Reviewed-by: Liming Gao > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ard > Biesheuvel > Sent: Friday, December 8, 2017 11:55 PM > To: edk2-devel@lists.01.org > Cc: Kinney, Michael D ; Gao, Liming > ; leif.lindh...@linaro.org; Ard Biesheuv

Re: [edk2] Ubuntu Build EDK2 Issue

2017-12-10 Thread Gao, Liming
Build run command is for NT32 platform only. NT32 is Windows emulator. It only supports VS tool chain on Windows. So, on Linux, you don't need to specify Build run command. Thanks Liming > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > An

[edk2] [PATCH] MdePkg: correct and clarify documentation of VA_LIST in Base.h

2017-12-10 Thread Zenith432
This is to resolve bug 457. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Zenith432 --- MdePkg/Include/Base.h | 24 1 file changed, 20 insertions(+), 4 deletions(-) diff --git a/MdePkg/Include/Base.h b/MdePkg/Include/Base.h index 02140a5a..19f36