[edk2] [Patch] NetworkPkg: Recycle the ICMP error message in PXE driver.

2017-12-20 Thread Fu Siyuan
This patch updates PxeBcIcmpErrorDpcHandle() and PxeBcIcmp6ErrorDpcHandle() to recycle the ICMP packet after copy it to PXE mode data. Cc: Ye Ting Cc: Wu Jiaxin Cc: Wang Fan Contributed-under: TianoCore Contribution Agreement 1.0

Re: [edk2] [Patch] MdeModulePkg/SnpDxe: Check the value of Nii->Id before use it directly.

2017-12-20 Thread Fu, Siyuan
Hi, Jiaxin In the line you are modifying the UDNI is always not started. You should move the Nii->Id to the line after PxeStart(), not to check it here. BestRegards Fu Siyuan > -Original Message- > From: Wu, Jiaxin > Sent: Thursday, December 21, 2017 3:13 PM > To:

Re: [edk2] [Patch] MdeModulePkg/Ip4Dxe: Clean up IP4 interface if failed to open ARP protocol.

2017-12-20 Thread Ye, Ting
Reviewed-by: Ye Ting -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Fu, Siyuan Sent: Wednesday, December 13, 2017 10:16 AM To: edk2-devel@lists.01.org Cc: Ye, Ting ; Wang, Fan ; Wu,

Re: [edk2] [Patch 00/14] Enable Structure PCD support in edk2

2017-12-20 Thread Zeng, Star
Another, please also more comments for the fields in NV_STORE_DEFAULT_BUFFER_HEADER. Thanks, Star -Original Message- From: Zeng, Star Sent: Thursday, December 21, 2017 3:11 PM To: Gao, Liming ; edk2-devel@lists.01.org Cc: Zhu, Yonghong ;

Re: [edk2] [Patch 00/14] Enable Structure PCD support in edk2

2017-12-20 Thread Zeng, Star
Liming, I have some comments to the patch series about MdeModulePkg changes. For MdeModulePkg: Update PCD driver to support Dynamic PcdVpdBaseAddress, Could the if condition adjustment be removed? And how about declaring "extern UINT32 mVpdBaseAddress;" in Service.h instead of Service.c? For

[edk2] [Patch 2/2] NetworkPkg/HttpBootDxe: Break the HttpBoot Callback function when meet redirect status.

2017-12-20 Thread Jiaxin Wu
In HttpBootCallback(), when data type is HttpBootHttpResponse, function may meet the resource redirect error. In current implementation, function will still go ahead to find header for HTTP_HEADER_CONTENT_LENGTH, this is not expected. Function should break in redirect status error handling. Cc:

[edk2] [Patch 0/2] Fix some issues in HttpBootDxe driver.

2017-12-20 Thread Jiaxin Wu
Cc: Wang Fan Cc: Ye Ting Cc: Fu Siyuan Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Wu Jiaxin Jiaxin Wu (2): NetworkPkg/HttpBootDxe: Avoid the potential memory leak when eror

Re: [edk2] [PATCH] MdeModulePkg/MdeModulePkg.dec: Clarify usage of PcdHeapGuardPropertyMask

2017-12-20 Thread Wang, Jian J
Thanks. .uni file will be updated accordingly. Regards, Jian > -Original Message- > From: Zeng, Star > Sent: Thursday, December 21, 2017 1:15 PM > To: Wang, Jian J ; edk2-devel@lists.01.org > Cc: Dong, Eric ; Zeng, Star >

[edk2] [Patch] CryptoPkg/TlsLib: Add some parameter check and clarification.

2017-12-20 Thread Jiaxin Wu
Cc: Ye Ting Cc: Long Qin Cc: Fu Siyuan Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Wu Jiaxin --- CryptoPkg/Include/Library/TlsLib.h | 6 ++ CryptoPkg/Library/TlsLib/TlsConfig.c |

Re: [edk2] [PATCH] MdeModulePkg/MdeModulePkg.dec: Clarify usage of PcdHeapGuardPropertyMask

2017-12-20 Thread Zeng, Star
Please also the *.uni file accordingly, with that, Reviewed-by: Star Zeng Thanks, Star -Original Message- From: Wang, Jian J Sent: Thursday, December 21, 2017 1:08 PM To: edk2-devel@lists.01.org Cc: Zeng, Star ; Dong, Eric

Re: [edk2] UEFI App embedded on another uefi app

2017-12-20 Thread Ni, Ruiyu
Your requirement doesn't need any PCD knowledge. I think all you need to do: 1. Study to know how to embedded a binary to your PE image a). Either by converting that binary to a big C array b). Or by creating a new resource section, including that binary 2. In your entrypoint of the

[edk2] [PATCH] IntelSiliconPkg MicrocodeUpdateDxe: Fix (ExtendedTableLength & 0x3)!=0

2017-12-20 Thread Star Zeng
The first 48 bytes contain the microcode update header. DataSize must be a multiple of DWORDs. TotalSize is always a multiple of 1024. Both size of CPU_MICROCODE_EXTENDED_TABLE_HEADER and CPU_MICROCODE_EXTENDED_TABLE are multiple of DWORDs. So (ExtendedTableLength & 0x3)!=0 should be

Re: [edk2] [PATCH v2] ArmPkg/ArmMmuLib ARM: fix page size granularity in initial MMU setting

2017-12-20 Thread Ard Biesheuvel
On 20 December 2017 at 19:28, M1cha wrote: > From what I can see this bug dates back to the commit from 2011 where > support for this was added: 2cf4b60895f8a > > The first problem is that PopulateLevel2PageTable overflows the > translation table buffer because it

Re: [edk2] [PATCH] ArmPkg/ArmMmuLib ARM: fix page size granularity in initial MMU setting

2017-12-20 Thread Ard Biesheuvel
On 19 December 2017 at 08:57, M1cha wrote: > From what I can see this bug dates back to the commit from 2011 where > support for this was added: 2cf4b60895f8a > > The first problem is that PopulateLevel2PageTable overflows the > translation table buffer because it

Re: [edk2] [RFC] MdeModulePkg/PciHostBridge: Add address translation support

2017-12-20 Thread Ard Biesheuvel
On 20 December 2017 at 15:17, gary guo wrote: > On Wed, Dec 20, 2017 at 09:13:58AM +, Ard Biesheuvel wrote: >> Hi Heyi, >> >> On 20 December 2017 at 08:21, Heyi Guo wrote: >> > PCIe on some ARM platforms requires address translation, not only for >>

Re: [edk2] Mapping frame buffer memory as uncached

2017-12-20 Thread Ard Biesheuvel
On 20 December 2017 at 15:17, Alexei Fedorov wrote: > Hi Ard, > > > The side effect of the following commit on 6 April: > > > ArmPlatformPkg/FVP: map motherboard VRAM as uncached memory > > The VRAM of the PL111 on the FVP Base/Foundation models is described as > device

[edk2] Mapping frame buffer memory as uncached

2017-12-20 Thread Alexei Fedorov
Hi Ard, The side effect of the following commit on 6 April: ArmPlatformPkg/FVP: map motherboard VRAM as uncached memory The VRAM of the PL111 on the FVP Base/Foundation models is described as device memory rather than uncached memory, which is not an accurate description of the nature of the

[edk2] [Patch][edk2-platforms/devel-MinnowBoard3-UDK2017] Change BIOS Version

2017-12-20 Thread lushifex
Change BIOS Minor Version Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: lushifex --- Platform/BroxtonPlatformPkg/BiosId.env | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Platform/BroxtonPlatformPkg/BiosId.env

[edk2] [Patch][edk2-platforms/devel-MinnowBoard3-UDK2017] Binaries reorganize.

2017-12-20 Thread lushifex
Change binaries from Common folder to Board folder. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: lushifex --- Platform/BroxtonPlatformPkg/BuildBxtBios.sh| 56 +++--- .../Common/Tools/Stitch/IFWIStitch_Simple.bat | 36

[edk2] [RFC] MdeModulePkg/PciHostBridge: Add address translation support

2017-12-20 Thread Heyi Guo
PCIe on some ARM platforms requires address translation, not only for legacy IO access, but also for 32bit memory BAR access as well. There will be "Address Translation Unit" or something similar in PCI host bridges to translation CPU address to PCI address and vice versa. So we think it may be