This patch adds support for DS3232 RTC Library
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Wasim Khan
---
Silicon/Maxim/Library/Ds3232RtcLib/Ds3232Rtc.h | 49 +++
Silicon/Maxim/Library/Ds3232RtcLib/Ds3232RtcLib.c | 370 +
.../Maxim/Library/Ds3
This patch adds support of adding ArmPlatformLib
for NXP LS2088ARDB board
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Wasim Khan
---
.../Library/PlatformLib/ArmPlatformLib.c | 106 +++
.../Library/PlatformLib/ArmPlatformLib.inf | 80 +
Added SocInit function that initializes peripherals
and print board and soc information for LS2088ARDB Board.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Wasim Khan
---
.../LS2088aRdbPkg/Include/Library/PlatformLib.h| 28
Silicon/NXP/Chassis/Chassis.c
In Silicon/NXP, we are keeping our SoC specific information and remaining code
will be kept in Platform/NXP.
Following patches will add support of NXP LS2088A RDB board in edk2-platforms.
Platform/NXP/LS2088aRdbPkg will host .dsc and .fdf files to support compilation
for LS2088A RDB board.
Loo
Added firware device, description and declaration files for LS2088ARDB.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Wasim Khan
---
Platform/NXP/LS2088aRdbPkg/LS2088aRdbPkg.dec | 29
Platform/NXP/LS2088aRdbPkg/LS2088aRdbPkg.dsc | 95 +
Platform/NXP/LS
On 22 December 2017 at 07:23, M1cha wrote:
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Michael Zimmermann
> ---
> MdePkg/Include/Base.h | 10 ++
> 1 file changed, 10 insertions(+)
>
> diff --git a/MdePkg/Include/Base.h b/MdePkg/Include/Base.h
> index 22ab5d
On 22 December 2017 at 07:23, M1cha wrote:
> When compiling with any ARM toolchain and Os, registers can get
> trashed when returning for the second time from SetJump because GCC
> only handles this correctly when using standard names like 'setjmp' or
> 'getcontext'. When different names are used
On 22 December 2017 at 07:23, M1cha wrote:
> This fixes compiler warnings when using them in functions which
> should return a value but rely on LongJump to never return instead.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Michael Zimmermann
Reviewed-by: Ard Bies
On 22 December 2017 at 12:16, Meenakshi Aggarwal
wrote:
> Following patches add support for pci emulation layer
> and SATA on NXP boards.
>
> Null Library for USB is also present to give completeness
> to Pci Emulation layer.
>
> Meenakshi Aggarwal (3):
> USB: Added Support of DWC3 USB controlle
On 21 December 2017 at 18:48, Vabhav wrote:
> Following patches will add support of NXP PCI Host Bridge Driver in
> edk2-platforms directory 'edk2-platforms/Platform/NXP'
>
Why do you need a new PciHostBridgeDxe driver? Can't you use the one
in MdeModulePkg instead?
> Updated Directory structur
I see the .h file updates here.
I think the C files in MdePkg/Library/BaseLib also need
to be updated for this patch series to be complete.
Thanks,
Mike
> -Original Message-
> From: M1cha [mailto:sigmaepsilo...@gmail.com]
> Sent: Thursday, December 21, 2017 11:24 PM
> To: edk2-devel@lis
Is adding attributes to both header and source files an UEFI coding
convention?
Because for the compiler it's only necessary to do that in the header files
afaik.
Thanks
Michael
On Fri, Dec 22, 2017 at 6:55 PM, Kinney, Michael D <
michael.d.kin...@intel.com> wrote:
> I see the .h file updates he
The reason for that is that I was lazy when doing copy&paste ;)
I'll send a v2.
On Fri, Dec 22, 2017 at 4:24 PM, Ard Biesheuvel
wrote:
> On 22 December 2017 at 07:23, M1cha wrote:
> > Contributed-under: TianoCore Contribution Agreement 1.1
> > Signed-off-by: Michael Zimmermann
> > ---
> > Mde
From: Girish Pathak
Minor code change, replaces magic number with macro in LCD disable.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Girish Pathak
Signed-off-by: Evan Lloyd
---
ArmPlatformPkg/Library/PL111Lcd/PL111Lcd.c | 3 +--
1 file changed, 1 insertion(+), 2 dele
From: EvanLloyd
This patch series addresses comments on the original
(https://lists.01.org/pipermail/edk2-devel/2017-September/015321.html)
reworking of the Graphics Output Protocol code in ArmPlatformPkg.
It also contains updates for the new SCMI protocol.
After a number of format and quality
From: Girish Pathak
This change adds CONST qualifiers (mainly to arguments
of functions) in PL111 and HdLcd libraries.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Girish Pathak
Signed-off-by: Evan Lloyd
---
ArmPlatformPkg/Library/HdLcd/HdLcd.c | 4 ++--
ArmPl
From: Girish Pathak
LcdIdentify function does not currently check presence of HDLCD
controller.
Implement this functionality by reading HDLCD_REG_VERSION and checking
against the PRODUCT_ID field to detect presence of HDLCD controller.
Contributed-under: TianoCore Contribution Agreement 1.1
Sig
From: Girish Pathak
There is no functional modification in this change
some comments are modified and a few new comments are added.
This is to prevent mixing formatting changes with functional
changes.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Girish Pathak
Signed-o
From: Girish Pathak
There is no functional modification in this change
As preparation for further work, the formatting is corrected to meet
the EDKII coding standard.
Of specific note, some invalid include guards were fixed.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by:
From: Girish Pathak
This change moves some ASSERTs in error handling code
to improve efficiency in DEBUG build.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Girish Pathak
Signed-off-by: Evan Lloyd
---
ArmPlatformPkg/Library/HdLcd/HdLcd.c | 11 ---
ArmPl
From: Girish Pathak
This change introduces a new SCMI protocol driver for
Arm Platforms. The driver currently supports only clock
and performance management protocols. Other protocols
will be added as and when needed.
Clock management protocol is used to configure the HDLCD clock
on Juno platfor
From: Girish Pathak
Add definitions for new display modes such as HD 720.
This has no effect on existing display drivers.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Girish Pathak
Signed-off-by: Evan Lloyd
---
ArmPlatformPkg/Include/Library/LcdPlatformLib.h | 60 +++
From: Girish Pathak
The LcdPlatformGetTimings interface function takes similar sets of
multiple parameters for horizontal and vertical timings which can be
aggregated in a common data type. This change defines a structure
SCAN_TIMINGS for this which can be used to describe both horizontal and
ver
From: Girish Pathak
Currently framebuffer memory is either reserved in special VRAM or
dynamically allocated using boot services memory allocation functions.
When allocated using boot services calls the memory has to be allocated
as EfiBootServicesData. Unfortunately failures have been seen with
From: Girish Pathak
This change adds support for the ARM Mali DP500/DP500/DP650 display
processors using the GOP protocol. It has been tested on FVP base
models + DP550 support. This change adds platform independant LcdHwLib
library. A corresponding platform specific library will be submitted
to
From: Girish Pathak
Current HDLCD and PL111 platform libraries do not support display modes
with PixelBlueGreenRedReserved8BitPerColor format, i.e. because of
historical confusion, they do not support the UEFI default
PixelBlueGreenRedReserved8BitPerColor format
In LcdPlatformLib for PL111, LcdP
From: Girish Pathak
This change adds a new PCD PcdArmHdlcdSwapBlueRedSelect
to swap values for HDLCD RED_SELECT and BLUE_SELECT registers
on platforms where blue and red hardware lines are swapped.
If set to TRUE in the platform dsc, HDLCD library will swap the values
while setting RED_SELECT an
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Michael Zimmermann
---
MdePkg/Include/Base.h | 8
1 file changed, 8 insertions(+)
diff --git a/MdePkg/Include/Base.h b/MdePkg/Include/Base.h
index 22ab5d3715fb..9c8f5d643f42 100644
--- a/MdePkg/Include/Base.h
+++ b/M
Michael,
For many aspects of a function declaration and function implementation the C
compiler requires the headers to match. I think it is good practice to have
them match.
In general, when implementing a library instance, you can take a copy of the
library
class .h file into a library instan
From: Ard Biesheuvel
This change fixes incorrect MODULE_TYPE of HDLCD and PL111
LcdPlatformLibs. Currently set MODUL_TYPE DXE_DRIVER is incorrect
for these platform libraries. Hence set this to type BASE.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Girish Pathak
---
From: Girish Pathak
There is no functional modification in this change
As preparation for further work, the formatting is corrected to meet
the EDKII coding standard.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Girish Pathak
Signed-off-by: Evan Lloyd
---
Platform/AR
From: Girish Pathak
PCD PcdPL111LcdMaxMode is not used in HDLCD platform library.
Presence of this PCD in HDLCD is probably due to copy/paste code
from PL111 Lcd platform library. This change removes it from
the HdLcdArmVExpressLib.inf file.
Contributed-under: TianoCore Contribution Agreement 1.
From: EvanLloyd
This patch series addresses comments on the original
(https://lists.01.org/pipermail/edk2-devel/2017-September/015356.html)
reworking of the Graphics Output Protocol code in Platform/ARM.
It also contains updates for the new SCMI protocol (MTL Library).
After a number of format a
From: Girish Pathak
PL111_CLCD_SITE and ARM_VE_MOTHERBOARD_SITE are both constants and
available at build time. Use conditional compilation to process the code
based on the value of PL111_CLCD_SITE, instead of selecting code in a
switch statement at runtime.
Contributed-under: TianoCore Contribu
From: Girish Pathak
This change replaces PcdGet32 with FixedPcdGet32 for the PCDs which
are defined as fixed PCDs.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Girish Pathak
Signed-off-by: Evan Lloyd
---
Platform/ARM/VExpressPkg/Library/HdLcdArmVExpressLib/HdLcdArmVE
From: Girish Pathak
None of the ArmPlatformSys* functions returns EFI_TIMEOUT. Hence checking
this in the do {} while loop in LcdPlatformSetMode is wrong. Therefore
remove this comparision and as a result remove the do {} while loop.
Contributed-under: TianoCore Contribution Agreement 1.1
Signe
From: Girish Pathak
Current HDLCD and PL111 platform libraries do not support display modes
with PixelBlueGreenRedReserved8BitPerColor format, i.e. because of
historical confusion, they do not support the UEFI default
PixelBlueGreenRedReserved8BitPerColor
LcdPlatformLib for PL111, LcdPlatformQu
From: Girish Pathak
This minor change removes some unecessary initializations and variables
in PL111LcdArmVExpress.c
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Girish Pathak
Signed-off-by: Evan Lloyd
---
Platform/ARM/VExpressPkg/Library/PL111LcdArmVExpressLib/PL111
From: Girish Pathak
This change adds some debug assertions e.g to catch NULL pointer errors
missing in PL11Lcd and HdLcd platform libraries.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Girish Pathak
Signed-off-by: Evan Lloyd
---
Platform/ARM/VExpressPkg/Library/HdLc
From: Girish Pathak
There is no functional modification in this change.
In this change some comments in HDLCD and PL111LCD platform library
code are modified and a few new comments are added. This is to
prevent mixing formatting changes with functional changes.
Contributed-under: TianoCore Contr
From: Girish Pathak
This change adds some STATIC and CONST qualifiers (mainly to arguments
of functions) in PL111 and HdLcd platform libraries.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Girish Pathak
Signed-off-by: Evan Lloyd
---
Platform/ARM/VExpressPkg/Library/
From: Girish Pathak
This fix changes the cache attribute of Non-Trusted SRAM on the Juno
platform to device memory. This change is required to avoid coherency
problems as Non-Trusted SRAM is used as a shared memory between the
application processor and the SCP for communication. This change is a
From: Girish Pathak
The LcdPlatformGetTimings interface function takes similar sets of
multiple parameters for horizontal and vertical timings which can be
aggregated in a common data type. This change defines a structure
SCAN_TIMINGS for this which can be used to describe both horizontal and
ver
From: Girish Pathak
This change uses two PCDs, PcdArmLcdFrameBufferBase and
PcdArmLcdFrameBufferSize introduced in correspondiong EDK2 patch to
reserve framebuffer in DRAM if these values are defined in platform
specific DSC file, avoiding the need to allocate dynamically.
This allows the framebu
From: Girish Pathak
This change adds LcdPlatformLib implementation for ARM Mali
DP500/DP500/DP650 display processors for models (with DP550 support).
NOTE: Versions for actual hardware are liable to require extra handling
for clock input changes, etc.
Contributed-under: TianoCore Contribution A
From: Girish Pathak
This change adds a new Mailbox Transport Layer library for the Juno
platform. This library is required for ArmScmiDxe driver communication
with the SCP.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Girish Pathak
---
Platform/ARM/JunoPkg/ArmJuno.dec
From: Girish Pathak
This change adds the HDLCD platform lib for the Juno plaform. This
library will be instantiated as a LcdPlatformLib to link with
LcdGraphicsOutputDxe for the Juno platform.
HDLCD platform library depends on the Arm SCMI DXE driver for
communication with the SCP for clock sett
From: EvanLloyd
Because of copy/paste effects, HdLcdArmVExpress.c contained a
table entry "LCD_BPP Bpp;" specifying the Bits per Pixel for each mode.
However, all modes are LCD_BITS_PER_PIXEL_24.
This change removes the table entry and related use of the field.
Contributed-under: TianoCore Cont
This fixes compiler warnings when using them in functions which
should return a value but rely on LongJump to never return instead.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Michael Zimmermann
---
MdePkg/Include/Library/BaseLib.h | 1 +
MdePkg/Library/Bas
When compiling with any ARM toolchain and Os, registers can get
trashed when returning for the second time from SetJump because GCC
only handles this correctly when using standard names like 'setjmp' or
'getcontext'. When different names are used you have to use the
attribute 'returns_twice' to tel
I've already discussed this in past but never actually sent proper
patches for some reason.
This patch series is about fixing problems with these functions when
using GCC.
V2:
* add attributes to C-files too
* remove useless condition in RETURNS_TWICE macro
M1cha (3):
MdePkg: add RETURNS_TWICE
On 22 December 2017 at 19:08, wrote:
> From: EvanLloyd
>
Hello Evan,
Before reviewing in detail, could you please confirm that replying to
the addresses below is going to work as expected for non @arm.com
reviewers? They look a bit odd, but perhaps the arm.com SMTP server
doesn't care??
Cc: A
52 matches
Mail list logo
