Re: [edk2] [PATCH] CryptoPkg/OpensslLib: Update OpenSSL version to 1.1.0g

Reviewed-by: Ye Ting -Original Message- From: Long, Qin Sent: Friday, December 22, 2017 2:28 PM To: edk2-devel@lists.01.org Cc: Ye, Ting Subject: [PATCH] CryptoPkg/OpensslLib: Update OpenSSL version to 1.1.0g Update the supported OpenSSL version

Re: [edk2] [Patch] MdeModulePkg/NetLib: Refine coding style for API NetLibDetectMediaWaitTimeout

Reviewed-by: Dandan Bi Thanks, Dandan -Original Message- From: Wang, Fan Sent: Monday, December 25, 2017 10:46 AM To: edk2-devel@lists.01.org Cc: Wang, Fan ; Bi, Dandan Subject: [Patch] MdeModulePkg/NetLib: Refine coding

[edk2] [Patch] NetworkPkg/IScsiDxe: Correct the DnsMode value according the target info.

This patch is to resolve the issue recorded @ https://bugzilla.tianocore.org/show_bug.cgi?id=823. Cc: Ye Ting Cc: Fu Siyuan Cc: Karunakar P Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Wu Jiaxin

[edk2] [PATCH] UefiCpuPkg: Update AESNI support checking logic

With correct model CPU, current checking logic will always execute AsmReadMsr64 operation and then check ECX.AESNI[bit 25] = 1. Update checking logic to check ECX.AESNI[bit 25] = 1 first and then do AsmReadMsr64 operation. Cc: Eric Dong Cc: Laszlo Ersek

Re: [edk2] [PATCH 1/3] MdePkg: add RETURNS_TWICE attribute

Micha: Could you add comments for new macro RETURNS_TWICE like others, such as ANALYZER_NORETURN? >-Original Message- >From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] >Sent: Friday, December 22, 2017 11:24 PM >To: M1cha >Cc: edk2-devel@lists.01.org;

[edk2] [Patch] MdeModulePkg/NetLib: Refine coding style for API NetLibDetectMediaWaitTimeout

From: Wang Fan Cc: Dandan Bi Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Wang Fan --- MdeModulePkg/Library/DxeNetLib/DxeNetLib.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git

Re: [edk2] [PATCH] MdeModulePkg/Core: Fix heap guard issues

Sorry for the email title. This is not a series patch. And I missed one more issue addressed by this patch: c. NULL address handling due to allocation failure When allocation failure, normally a NULL will be returned. But Heap Guard code will still try to adjust the starting address of it, which

Re: [edk2] [PATCH 3/4] UefiCpuPkg/UefiCpuPkg.uni: Add missing string definition for new PCDs

Sure. Thanks. Regards, Jian > -Original Message- > From: Bi, Dandan > Sent: Monday, December 25, 2017 9:59 AM > To: Wang, Jian J ; edk2-devel@lists.01.org > Cc: Dong, Eric ; Laszlo Ersek > Subject: RE: [PATCH 3/4]

Re: [edk2] [PATCH 1/4] MdePkg/BaseLib.h: Coding style clean-up

Ok. Thanks for catching it. Regards, Jian > -Original Message- > From: Bi, Dandan > Sent: Monday, December 25, 2017 9:51 AM > To: Wang, Jian J ; edk2-devel@lists.01.org > Cc: Zeng, Star ; Dong, Eric > Subject: RE: [PATCH

[edk2] [PATCH 1/2] MdeModulePkg/Core: Fix heap guard issues

Two issues addressed here: a. Make NX memory protection and heap guard to be compatible The solution is to check PcdDxeNxMemoryProtectionPolicy in Heap Guard to see if the free memory should be set to NX, and set the Guard page to NX before it's freed back to memory pool. This can solve the issue

[edk2] [PATCH] MdePkg/BasePrintLib: Fix incorrect Precision position calculation

Due to the a potential hole in the stop condition of for-loop, the two continuous access to ArgumentString (index, index+1) inside the loop might cause the string ending character ('\0') to be read. Cc: Michael D Kinney Cc: Liming Gao Cc: Jiewen

Re: [edk2] [PATCH 2/4] MdeModulePkg/Core: Coding style clean-up

Reviewed-by: Dandan Bi Thanks, Dandan -Original Message- From: Wang, Jian J Sent: Monday, December 25, 2017 9:07 AM To: edk2-devel@lists.01.org Cc: Bi, Dandan ; Zeng, Star ; Dong, Eric Subject: [PATCH

Re: [edk2] [PATCH 4/4] UefiCpuPkg: Update code to use new structure field names

Reviewed-by: Dandan Bi Thanks, Dandan -Original Message- From: Wang, Jian J Sent: Monday, December 25, 2017 9:07 AM To: edk2-devel@lists.01.org Cc: Bi, Dandan ; Dong, Eric ; Laszlo Ersek Subject: [PATCH

Re: [edk2] [PATCH 3/4] UefiCpuPkg/UefiCpuPkg.uni: Add missing string definition for new PCDs

Hi Jian, Could you add the "string" keyword before the string token when you commit the patch. You can refer to other codes in the uni file. With this update, Reviewed-by: Dandan Bi Thanks, Dandan -Original Message- From: Wang, Jian J Sent: Monday, December 25,

Re: [edk2] [PATCH 1/4] MdePkg/BaseLib.h: Coding style clean-up

Hi Jian, This patch is fine. Could you help to add a period(.) for following function description when you commit the patch? Thanks! /** Load given selector into TR register // Add a period(.) here, or ECC tool will report an error here. @param[in] Selector Task segment selector

Re: [edk2] [PATCH 00/17] BaseTools/C: Code refinements

Reviewed-by: Liming Gao >-Original Message- >From: Wu, Hao A >Sent: Tuesday, December 19, 2017 11:29 AM >To: edk2-devel@lists.01.org >Cc: Wu, Hao A ; Gao, Liming ; >Zhu, Yonghong >Subject: [PATCH

Re: [edk2] [PATCH] SecurityPkg: Remove RngTest Application from SecurityPkg

Reviewed-by: Chao Zhang -Original Message- From: Long, Qin Sent: Friday, December 22, 2017 3:10 PM To: edk2-devel@lists.01.org Cc: Zhang, Chao B Subject: [PATCH] SecurityPkg: Remove RngTest Application from SecurityPkg BZ#:

Re: [edk2] [PATCH 2/4] MdeModulePkg/Core: Coding style clean-up

Reviewed-by: Star Zeng -Original Message- From: Wang, Jian J Sent: Monday, December 25, 2017 9:07 AM To: edk2-devel@lists.01.org Cc: Bi, Dandan ; Zeng, Star ; Dong, Eric Subject: [PATCH 2/4]

[edk2] [PATCH 2/4] MdeModulePkg/Core: Coding style clean-up

Cc: Dandan Bi Cc: Star Zeng Cc: Eric Dong Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jian J Wang --- MdeModulePkg/Core/DxeIplPeim/X64/VirtualMemory.c | 5 + 1 file changed, 5

[edk2] [PATCH 3/4] UefiCpuPkg/UefiCpuPkg.uni: Add missing string definition for new PCDs

Cc: Dandan Bi Cc: Eric Dong Cc: Laszlo Ersek Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jian J Wang --- UefiCpuPkg/UefiCpuPkg.uni | 16 ++-- 1 file changed, 14

[edk2] [PATCH 1/4] MdePkg/BaseLib.h: Coding style clean-up

Cc: Dandan Bi Cc: Star Zeng Cc: Eric Dong Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jian J Wang --- MdePkg/Include/Library/BaseLib.h | 72

[edk2] [PATCH 0/4] Coding style clean-up

This patch series are meant for cleaning up code according to coding style requirements. Jian J Wang (4): MdePkg/BaseLib.h: Coding style clean-up MdeModulePkg/Core: Coding style clean-up UefiCpuPkg/UefiCpuPkg.uni: Add missing string definition for new PCDs UefiCpuPkg: Update code to use

[edk2] [PATCH 4/4] UefiCpuPkg: Update code to use new structure field names

Due to coding style fix of the structure definition in BaseLib.h, all code referencing those structure must be updated accordingly. Cc: Dandan Bi Cc: Eric Dong Cc: Laszlo Ersek Contributed-under: TianoCore Contribution Agreement 1.1