[edk2] [Patch] BaseTools: Update SkuId checker to make sure it be valid UINT64 value

2017-12-25 Thread Liming Gao
Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Liming Gao Cc: Yonghong Zhu Cc: Signed-off-by: Bob Feng --- BaseTools/Source/Python/Common/Misc.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/BaseTools/Source/Python/Common/Misc.py b/BaseTools

Re: [edk2] [RFC] MdeModulePkg/PciHostBridge: Add address translation support

2017-12-25 Thread Guo Heyi
Hi Ard, Ray, Have we come to the final conclusion? Or are we still waiting for more comments on this? Thanks, Gary On Thu, Dec 21, 2017 at 10:07:51AM +, Ard Biesheuvel wrote: > On 21 December 2017 at 09:59, Ni, Ruiyu wrote: > > On 12/21/2017 5:52 PM, Ard Biesheuvel wrote: > >> > >> On 21

[edk2] [Patch 3/3] NetworkPkg/TcpDxe: Check TCP payload for release version.

2017-12-25 Thread Jiaxin Wu
TCP payload check is implemented by TcpVerifySegment(), but all the function calls of TcpVerifySegment() are placed in ASSERT(), which is only valid for debug version: ASSERT (TcpVerifySegment (Nbuf) != 0); This patch is to enable the check for release version. Cc: Ye Ting Cc: Fu Siyuan Cc: W

[edk2] [Patch 1/2] NetworkPkg/HttpDxe: Fix the memory leak issue in HttpRequest().

2017-12-25 Thread Jiaxin Wu
Cc: Wang Fan Cc: Ye Ting Cc: Fu Siyuan Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Wu Jiaxin --- NetworkPkg/HttpDxe/HttpImpl.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/NetworkPkg/HttpDxe/HttpImpl.c b/NetworkPkg/HttpDxe/HttpImpl.c ind

[edk2] [Patch 0/2] NetworkPkg/HttpDxe: Fix some issues in HttpDxe

2017-12-25 Thread Jiaxin Wu
Cc: Wang Fan Cc: Ye Ting Cc: Fu Siyuan Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Wu Jiaxin Jiaxin Wu (2): NetworkPkg/HttpDxe: Fix the memory leak issue in HttpRequest(). NetworkPkg/HttpDxe: Remove the unnecessary ASSERT. NetworkPkg/HttpDxe/HttpImpl.c | 17 +++

[edk2] [Patch 2/2] NetworkPkg/HttpDxe: Remove the unnecessary ASSERT.

2017-12-25 Thread Jiaxin Wu
Cc: Wang Fan Cc: Ye Ting Cc: Fu Siyuan Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Wu Jiaxin --- NetworkPkg/HttpDxe/HttpImpl.c | 9 + 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/NetworkPkg/HttpDxe/HttpImpl.c b/NetworkPkg/HttpDxe/HttpImpl.c in

Re: [edk2] [Patch] BaseTools: Update copyright year info of DSC/DEC/INF BuilData.py file

2017-12-25 Thread Gao, Liming
Reviewed-by: Liming Gao > -Original Message- > From: Zhu, Yonghong > Sent: Tuesday, December 26, 2017 2:08 PM > To: edk2-devel@lists.01.org > Cc: Gao, Liming > Subject: [Patch] BaseTools: Update copyright year info of DSC/DEC/INF > BuilData.py file > > The DecBuildData.py, DscBuildData

[edk2] [Patch] BaseTools: Update copyright year info of DSC/DEC/INF BuilData.py file

2017-12-25 Thread Yonghong Zhu
The DecBuildData.py, DscBuildData.py and InfBuildData.py were separated from WorkspaceDatabase.py, so we updated to use same copyright year info. Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Yonghong Zhu --- BaseTools/Source/Python/Workspace/DecBuildData

Re: [edk2] [Patch 1/5 v2] MdeModulePkg/DxeHttpLib: Add boundary condition check.

2017-12-25 Thread Gary Lin
On Tue, Dec 26, 2017 at 10:36:47AM +0800, Jiaxin Wu wrote: > v2: > * Fix GCC the build error. > > This patch is to add the boundary condition check to make sure > the accessed buffer is valid. > > Cc: Gary Lin > Cc: Ye Ting > Cc: Fu Siyuan > Cc: Wang Fan > Contributed-under: TianoCore Contrib

Re: [edk2] [Patch] BaseTools: Fix building FatPkg failed issue

2017-12-25 Thread Gao, Liming
Reviewed-by: Liming Gao >-Original Message- >From: Feng, Bob C >Sent: Tuesday, December 26, 2017 11:34 AM >To: edk2-devel@lists.01.org >Cc: Feng, Bob C ; Gao, Liming >Subject: [Patch] BaseTools: Fix building FatPkg failed issue > >Using property instead of vairable for DecPcds. > >Contri

[edk2] [Patch] BaseTools: Fix building FatPkg failed issue

2017-12-25 Thread BobCF
Using property instead of vairable for DecPcds. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Bob Feng CC: Liming Gao --- BaseTools/Source/Python/Workspace/DscBuildData.py | 18 -- 1 file changed, 16 insertions(+), 2 deletions(-) diff --git a/BaseTools/

[edk2] [Patch][edk2-platforms/devel-MinnowBoardMax-UDK2017] Fix License Header.

2017-12-25 Thread zwei4
Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: zwei4 Cc: michael.d.kin...@intel.com Cc: mike...@intel.com --- .../Library/SerialPortLib/PlatformSerialPortLib.h | 128 +++-- .../Library/SerialPortLib/SerialPortLib.c | 514 ++--- Vlv2TbltDevicePkg/L

[edk2] [Patch 1/5 v2] MdeModulePkg/DxeHttpLib: Add boundary condition check.

2017-12-25 Thread Jiaxin Wu
v2: * Fix GCC the build error. This patch is to add the boundary condition check to make sure the accessed buffer is valid. Cc: Gary Lin Cc: Ye Ting Cc: Fu Siyuan Cc: Wang Fan Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Wu Jiaxin --- MdeModulePkg/Library/DxeHttpLi

Re: [edk2] [Patch 1/5] MdeModulePkg/DxeHttpLib: Add boundary condition check.

2017-12-25 Thread Wu, Jiaxin
Thanks to catch that. Best Regards! Jiaxin > -Original Message- > From: Gary Lin [mailto:g...@suse.com] > Sent: Tuesday, December 26, 2017 9:56 AM > To: Wu, Jiaxin > Cc: edk2-devel@lists.01.org; Ye, Ting ; Wang, Fan > ; Fu, Siyuan > Subject: Re: [edk2] [Patch 1/5] MdeModulePkg/DxeHttpLi

Re: [edk2] [Patch 1/5] MdeModulePkg/DxeHttpLib: Add boundary condition check.

2017-12-25 Thread Gary Lin
On Tue, Dec 26, 2017 at 09:33:45AM +0800, Jiaxin Wu wrote: > This patch is to add the boundary condition check to make sure > the accessed buffer is valid. > > Cc: Ye Ting > Cc: Fu Siyuan > Cc: Wang Fan > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Wu Jiaxin > ---

Re: [edk2] [Patch 0/5] MdeModulePkg/DxeHttpLib: Fix series issues in DxeHttpLib.

2017-12-25 Thread Fu, Siyuan
Reviewed-by: Fu Siyuan > -Original Message- > From: Wu, Jiaxin > Sent: Tuesday, December 26, 2017 9:34 AM > To: edk2-devel@lists.01.org > Cc: Ye, Ting ; Fu, Siyuan ; Wang, > Fan ; Wu, Jiaxin > Subject: [Patch 0/5] MdeModulePkg/DxeHttpLib: Fix series issues in > DxeHttpLib. > > Cc: Ye Ti

[edk2] [Patch 0/5] MdeModulePkg/DxeHttpLib: Fix series issues in DxeHttpLib.

2017-12-25 Thread Jiaxin Wu
Cc: Ye Ting Cc: Fu Siyuan Cc: Wang Fan Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Wu Jiaxin Jiaxin Wu (5): MdeModulePkg/DxeHttpLib: Add boundary condition check. MdeModulePkg/DxeHttpLib: Avoid the potential memory leak when error happen. MdeModulePkg/DxeHt

[edk2] [Patch 1/5] MdeModulePkg/DxeHttpLib: Add boundary condition check.

2017-12-25 Thread Jiaxin Wu
This patch is to add the boundary condition check to make sure the accessed buffer is valid. Cc: Ye Ting Cc: Fu Siyuan Cc: Wang Fan Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Wu Jiaxin --- MdeModulePkg/Library/DxeHttpLib/DxeHttpLib.c | 39 --

[edk2] [Patch 3/5] MdeModulePkg/DxeHttpLib: Check the input parameters for some APIs.

2017-12-25 Thread Jiaxin Wu
Cc: Ye Ting Cc: Fu Siyuan Cc: Wang Fan Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Wu Jiaxin --- MdeModulePkg/Include/Library/HttpLib.h | 1 + MdeModulePkg/Library/DxeHttpLib/DxeHttpLib.c | 25 - 2 files changed, 21 insertions(+), 5 del

[edk2] [Patch 4/5] MdeModulePkg/DxeHttpLib: Correct some return Status.

2017-12-25 Thread Jiaxin Wu
Cc: Ye Ting Cc: Fu Siyuan Cc: Wang Fan Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Wu Jiaxin --- MdeModulePkg/Include/Library/HttpLib.h | 5 +++-- MdeModulePkg/Library/DxeHttpLib/DxeHttpLib.c | 11 ++- 2 files changed, 9 insertions(+), 7 deletions(-)

[edk2] [Patch 2/5] MdeModulePkg/DxeHttpLib: Avoid the potential memory leak when error happen.

2017-12-25 Thread Jiaxin Wu
Cc: Ye Ting Cc: Fu Siyuan Cc: Wang Fan Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Wu Jiaxin --- MdeModulePkg/Library/DxeHttpLib/DxeHttpLib.c | 5 + 1 file changed, 5 insertions(+) diff --git a/MdeModulePkg/Library/DxeHttpLib/DxeHttpLib.c b/MdeModulePkg/Library

[edk2] [Patch 5/5] MdeModulePkg/DxeHttpLib: Refine some coding style.

2017-12-25 Thread Jiaxin Wu
Cc: Ye Ting Cc: Fu Siyuan Cc: Wang Fan Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Wu Jiaxin --- MdeModulePkg/Include/Library/HttpLib.h | 4 +- MdeModulePkg/Library/DxeHttpLib/DxeHttpLib.c | 118 +-- 2 files changed, 60 insertions(+),

Re: [edk2] [PATCH 1/2] MdeModulePkg/Core: Fix heap guard issues

2017-12-25 Thread Yao, Jiewen
It is pity to add this alignment requirement, because the some special case tail overflow might not be caught. If any other driver has such assumption, we may add ASSERT() to make sure the memory allocated is 8-byte aligned. As such we can catch this problem earlier, such as the Variable driver

Re: [edk2] [PATCH 1/3] MdePkg: add RETURNS_TWICE attribute

2017-12-25 Thread Michael Zimmermann
Liming: The other macros have comments both before the compiler directives and before each define for each compiler. To me it looks like these are slightly differently formulated only and kinda redundant too. Is there a rule or do you have suggestions for writing comments for this kind of macro? O

Re: [edk2] [Patch] MdeModulePkg HiiDataBaseDxe: Initialize the local variable before reference

2017-12-25 Thread Dong, Eric
Reviewed-by: Eric Dong -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Liming Gao Sent: Monday, December 25, 2017 6:25 PM To: edk2-devel@lists.01.org Subject: [edk2] [Patch] MdeModulePkg HiiDataBaseDxe: Initialize the local variable before refer

[edk2] [Patch] MdeModulePkg HiiDataBaseDxe: Initialize the local variable before reference

2017-12-25 Thread Liming Gao
Make VS2012x86 and GCC48 pass build Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Liming Gao --- MdeModulePkg/Universal/HiiDatabaseDxe/Database.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/MdeModulePkg/Universal/HiiDatabaseDxe/Database.c b/MdeModulePkg/Unive

Re: [edk2] [Patch 00/14] Enable Structure PCD support in edk2

2017-12-25 Thread Ard Biesheuvel
On 25 December 2017 at 10:10, Gao, Liming wrote: > Ard: > Thanks for your quick report. I verify it with GCC5 and GCC49 tool chain on > IA32 and X64 arch. But, I don't get this warning. Could you let me how to > catch it? > This is using GCC48 for ARM/AARCH64. The diagnostic may be inaccurate

Re: [edk2] [Patch 00/14] Enable Structure PCD support in edk2

2017-12-25 Thread Gao, Liming
Ard: Thanks for your quick report. I verify it with GCC5 and GCC49 tool chain on IA32 and X64 arch. But, I don't get this warning. Could you let me how to catch it? >-Original Message- >From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] >Sent: Monday, December 25, 2017 6:04 PM >To

Re: [edk2] [Patch 00/14] Enable Structure PCD support in edk2

2017-12-25 Thread Ard Biesheuvel
On 25 December 2017 at 09:36, Gao, Liming wrote: > Hi, all > I just push this feature in edk2 trunk. Revision c40dbe5e7bf9.. > 7c7362651323. If you find any issue, please let me know. > Hello Liming, The patch MdeModulePkg HiiDataBase: Enable Firmware to retrieve the default setting breaks

Re: [edk2] [Patch 00/14] Enable Structure PCD support in edk2

2017-12-25 Thread Gao, Liming
Hi, all I just push this feature in edk2 trunk. Revision c40dbe5e7bf9.. 7c7362651323. If you find any issue, please let me know. Thanks Liming >-Original Message- >From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of >Liming Gao >Sent: Friday, December 01, 2017 10:59

[edk2] [Patch]Vlv2TbltDevicePkg:Fix License Header.

2017-12-25 Thread zwei4
Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Wei, David Cc: Kinney, Michael D Cc: Wu, Mike --- .../Library/SerialPortLib/PlatformSerialPortLib.h | 128 +++-- .../Library/SerialPortLib/SerialPortLib.c | 514 ++--- Vlv2TbltDevicePkg/Library/Seri