The code without this patch will have incorrect value shown for handle, please
update the commit title.
With title updated,
Reviewed-by: Star Zeng
Thanks,
Star
-Original Message-
From: Gao, Liming
Sent: Thursday, December 28, 2017 2:36 PM
To: edk2-devel@lists.01.org
Cc: Zeng, Star
Su
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Liming Gao
Cc: Star Zeng
---
MdeModulePkg/Core/Pei/FwVol/FwVol.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/MdeModulePkg/Core/Pei/FwVol/FwVol.c
b/MdeModulePkg/Core/Pei/FwVol/FwVol.c
index 7cb295c..80
Reviewed-by: Star Zeng
Thanks,
Star
-Original Message-
From: Gao, Liming
Sent: Thursday, December 28, 2017 12:54 PM
To: edk2-devel@lists.01.org
Cc: Zeng, Star
Subject: [Patch] MdeModulePkg HiiDataBase: Fix the potential NULL pointer access
Contributed-under: TianoCore Contribution Agre
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Liming Gao
Cc: Star Zeng
---
MdeModulePkg/Universal/HiiDatabaseDxe/Database.c | 11 ---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git a/MdeModulePkg/Universal/HiiDatabaseDxe/Database.c
b/MdeModulePkg/Un
Reviewed-by: jiewen@intel.com
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Liming
> Gao
> Sent: Wednesday, December 27, 2017 11:23 PM
> To: edk2-devel@lists.01.org
> Cc: Yao, Jiewen
> Subject: [edk2] [Patch 1/4] IntelFspWrapperPkg: Conv
Reviewed-by: Star Zeng
Thanks,
Star
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Jian J
Wang
Sent: Thursday, December 28, 2017 10:38 AM
To: edk2-devel@lists.01.org
Subject: [edk2] [PATCH v2 0/2] Fix error in PrintLib
> v2:
>a. Correct inc
Reviewed-by: Liming Gao
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Jian J
> Wang
> Sent: Thursday, December 28, 2017 10:38 AM
> To: edk2-devel@lists.01.org
> Subject: [edk2] [PATCH v2 0/2] Fix error in PrintLib
>
> > v2:
> >a. Corre
> v2:
>Add in v2
Due to a potential hole in the stop condition of loop, the two continuous
access to ArgumentString (index, index+1) inside the loop might cause the
string ending character ('\0') and the byte after it to be read.
Cc: Michael D Kinney
Cc: Liming Gao
Cc: Jiewen Yao
Cc: Star
> v2:
>a. Correct incorrect description in commit log
>b. Fix another similar issue in the same function
>c. Fix similar issues in MdeModulePkg/DxePrintLibPrint2Protocol
Due to a potential hole in the stop condition of the loop, the two continuous
access to ArgumentString (index, index
> v2:
>a. Correct incorrect description in commit log
>b. Fix another similar issue in the same function
Due to a potential hole in the stop condition of loop, the two continuous
access to ArgumentString (index, index+1) inside the loop might cause the
string ending character ('\0') and th
Sure.
Regards,
Jian
> -Original Message-
> From: Gao, Liming
> Sent: Thursday, December 28, 2017 9:57 AM
> To: Wang, Jian J ; Kinney, Michael D
> ; edk2-devel@lists.01.org
> Cc: Yao, Jiewen ; Zeng, Star
> Subject: RE: [edk2] [PATCH] MdePkg/BasePrintLib: Fix incorrect Precision
> positio
Reviewed-by : Chao Zhang
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Liming
Gao
Sent: Wednesday, December 27, 2017 11:23 PM
To: edk2-devel@lists.01.org
Cc: Long, Qin
Subject: [edk2] [Patch 4/4] SecurityPkg: Convert source file to DOS format
Jian:
MdePkg/Library/BasePrintLib/PrintLibInternal.c line 1171 has the similar
issue. Could you fix it also?
And, MdeModulePkg\Library\DxePrintLibPrint2Protocol\PrintLib.c have the same
issue. Could you sync this fix to it?
Thanks
Liming
> -Original Message-
> From: Wang, Jian J
> S
Reviewed-by: Chao Zhang
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Liming
Gao
Sent: Thursday, December 28, 2017 9:10 AM
To: edk2-devel@lists.01.org
Cc: Long, Qin
Subject: [edk2] [Patch] SecurityPkg: Convert source file to DOS format
Contri
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Liming Gao
Cc: Qin Long
---
.../Include/Ppi/FirmwareVolumeInfoPrehashedFV.h| 148 ++---
1 file changed, 74 insertions(+), 74 deletions(-)
diff --git a/SecurityPkg/Include/Ppi/FirmwareVolumeInfoPrehashedFV
Theoretically, yes. But I think it's a rare case in which someone
will use ESP in a structure but not to represent ESP register.
Regards,
Jian
> -Original Message-
> From: Kinney, Michael D
> Sent: Thursday, December 28, 2017 8:37 AM
> To: Wang, Jian J ; edk2-devel@lists.01.org; Kinney,
Reviewed-by: Jiaxin Wu
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Liming Gao
> Sent: Wednesday, December 27, 2017 11:23 PM
> To: edk2-devel@lists.01.org
> Cc: Wu, Jiaxin
> Subject: [edk2] [Patch 2/4] NetworkPkg: Convert source file t
Jian,
I think . is the correct way to list
this type of exception. Otherwise we can miss incorrect
use of that field name.
Mike
> -Original Message-
> From: Wang, Jian J
> Sent: Wednesday, December 27, 2017 4:28 PM
> To: Kinney, Michael D ;
> edk2-devel@lists.01.org
> Subject: RE: [edk2
I revisit the code again. You're right that the commit log is not correct.
The '\0' would be read and even the one pass it.
Regards,
Jian
> -Original Message-
> From: Kinney, Michael D
> Sent: Thursday, December 28, 2017 12:38 AM
> To: Wang, Jian J ; edk2-devel@lists.01.org; Kinney,
> Mi
Current ECC use . in exception list to exclude those
special
field name spec defined. Whenever there's a new structure introduced with those
field
names, which have been added to exception list, the ECC will still report
coding style
violation. Maybe we can just use to do field name match for a
This fixes compiler warnings when using them in functions which
should return a value but rely on LongJump to never return instead.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Michael Zimmermann
---
V3: fix VS compilation errors
MdePkg/Include/Library/BaseLib.h
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Michael Zimmermann
---
V3: add code comments
MdePkg/Include/Base.h | 20
1 file changed, 20 insertions(+)
diff --git a/MdePkg/Include/Base.h b/MdePkg/Include/Base.h
index 22ab5d3715fb..8c7345609ed5 10064
Is the commit log correct?
Is the issue that the character past the '\0' could be read?
Mike
> -Original Message-
> From: Wang, Jian J
> Sent: Tuesday, December 26, 2017 6:14 PM
> To: Wang, Jian J ; edk2-
> de...@lists.01.org
> Cc: Kinney, Michael D ; Yao,
> Jiewen ; Zeng, Star
> ; Gao,
Yes. Please revert.
I am not sure I understand the ECC tool update you are suggesting.
Can you provide more details?
Mike
> -Original Message-
> From: Wang, Jian J
> Sent: Tuesday, December 26, 2017 4:40 PM
> To: Kinney, Michael D ; edk2-
> de...@lists.01.org
> Subject: RE: [edk2] [PATC
Michael:
I try VS compiler. When I add NORETURN as the first attribute of the function
declaration. It can pass build. On VS compiler, NORETURN is required to be
placed ahead of EFIAPI.
VOID
EFIAPI
NORETURN
LongJump (
IN BASE_LIBRARY_JUMP_BUFFER *JumpBuffer,
IN UINTN
The upstream version of the Linux NETSEC driver expects the PHY DT
node to appear under a MDIO subnode, so fix this in the device tree.
Fix the node name as well, this should be 'ethernet' not 'netsec'
Also, move the PHY subnode into the per-platform .dts file so we can
set the unit address in the
Remove a %r without an associated parameter.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ard Biesheuvel
---
Silicon/Socionext/SynQuacer/Drivers/SynQuacerI2cDxe/SynQuacerI2cDxe.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
a/Silicon/Socionext/SynQ
Do a global replace of gPcf8563RealTimeClockLibI2cMasterProtolGuid with
gPcf8563RealTimeClockLibI2cMasterProtocolGuid.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ard Biesheuvel
---
Silicon/NXP/Library/Pcf8563RealTimeClockLib/Pcf8563RealTimeClockLib.c | 2 +-
Silicon
Instead of registering a notification callback on the driver binding
protocol, and attempting to connect our I2C master handle each time
a new driver is registered, switch to the more obvious approach of
registering a notification callback on the I2C master protocol directly.
The original code was
Align the UART DT nodes:
- use 'uart' not 'fuart' as node name for the second serial port
- create an alias 'serial1' for the second serial port
- use UART clock reference instead of hardcoded frequency
- split 'clocks' property into 1 cell per phandle
Contributed-under: TianoCore Contribution Agr
Some stuff I have accumulated over the past couple of weeks, consisting
of
- Fixes for the I2C RTC handling; for some reason (probably due to having
added HII screens to PlatformDxe), the dispatch order had changed, and
the RTC no longer worked. (#1 - #4)
- The DT binding for NETSEC has changed
To ensure that the I2C master protocol is installed immediately onto
the handles created by PlatformDxe in its entry point, force the
SynQuacerI2cDxe driver to be loaded before PlatformDxe. These handles
are recursively connected by the DXE core as soon as they appear, and
so ensuring that the I2C
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Liming Gao
Cc: Qin Long
---
.../SecureBootConfigDxe/SecureBootConfigImpl.c | 26 +++---
1 file changed, 13 insertions(+), 13 deletions(-)
diff --git
a/SecurityPkg/VariableAuthenticated/SecureBootConfigDx
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Liming Gao
Cc: Wu Hao A
---
.../Library/DebugAgent/SecPeiDebugAgent/SecPeiDebugAgentLib.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git
a/SourceLevelDebugPkg/Library/DebugAgent/SecPeiDebugAgen
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Liming Gao
Cc: Wu Jiaxin
---
NetworkPkg/HttpDxe/HttpProto.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/NetworkPkg/HttpDxe/HttpProto.c b/NetworkPkg/HttpDxe/HttpProto.c
index 925281a9c0..d7fe271168 1006
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Liming Gao
Cc: Jiewen Yao
---
.../Library/PeiFspWrapperApiTestLib/PeiFspWrapperApiTestLib.inf | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
a/IntelFsp2WrapperPkg/Library/PeiFspWrapperApiTestLib/Pe
Liming Gao (4):
IntelFspWrapperPkg: Convert INF file to dos format
NetworkPkg: Convert source file to DOS format
SourceLevelDebugPkg: Convert source file to DOS format
SecurityPkg: Convert source file to DOS format
.../PeiFspWrapperApiTestLib.inf| 2 +-
NetworkPkg/Htt
On 27 December 2017 at 13:02, Vabhav Sharma wrote:
>
>
>>-Original Message-
>>From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org]
>>Sent: Friday, December 22, 2017 9:04 PM
>>To: Vabhav Sharma
>>Cc: Leif Lindholm ; Kinney, Michael D
>>; edk2-devel@lists.01.org; Udit Kumar
>>; Varun Set
>-Original Message-
>From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org]
>Sent: Friday, December 22, 2017 9:04 PM
>To: Vabhav Sharma
>Cc: Leif Lindholm ; Kinney, Michael D
>; edk2-devel@lists.01.org; Udit Kumar
>; Varun Sethi
>Subject: Re: [PATCH edk2-platforms 0/3] Platform/NXP-Add
reviewed by jiewen@intel.com
thank you!
Yao, Jiewen
> 在 2017年12月27日，下午7:07，Zeng, Star 写道：
>
> Enhance DumpModuleImageInfo() for page fault with I/D set.
>
> If it is page fault with I/D set, the (E/R)IP in SystemContext
> could not be used for DumpModuleImageInfo(), instead of, the next
>
Enhance DumpModuleImageInfo() for page fault with I/D set.
If it is page fault with I/D set, the (E/R)IP in SystemContext
could not be used for DumpModuleImageInfo(), instead of, the next
IP of the IP triggering this page fault could be found from stack
by (E/R)SP in SystemContext.
IA32 SDM:
— I/
On 27 December 2017 at 09:59, Long, Qin wrote:
> This makes sense to me.
> Reviewed-by: Long Qin
>
Thanks. Pushed as c24d664dca26
> -Original Message-
> From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org]
> Sent: Wednesday, December 27, 2017 5:27 PM
> To: edk2-devel@lists.01.org; Lo
This makes sense to me.
Reviewed-by: Long Qin
Best Regards & Thanks,
LONG, Qin
-Original Message-
From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org]
Sent: Wednesday, December 27, 2017 5:27 PM
To: edk2-devel@lists.01.org; Long, Qin ; Ye, Ting
Cc: Ard Biesheuvel
Subject: [PATCH]
Reviewed-by: Liming Gao
>-Original Message-
>From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
>BobCF
>Sent: Wednesday, December 27, 2017 2:04 PM
>To: edk2-devel@lists.01.org
>Cc: Gao, Liming
>Subject: [edk2] [Patch] BaseTools: Remove 'COMMON' in PCD SkuInfoList
>
>'
Jian:
I prefer to roll back this change. So, the definition in BaseLib.h can be
kept in the same style.
Thanks
Liming
>-Original Message-
>From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
>Wang, Jian J
>Sent: Wednesday, December 27, 2017 8:40 AM
>To: Kinney, Micha
We recently added -Wno-error=format to the OpenSslLib build script to
work around an issue in the upstream OpenSSL code. This does not inhibit
the warning, but prevents it from breaking the build by not treating it
as a fatal error.
Unfortunately, this interacts poorly with the -Wno-unused-const-v
Reviewed-by: Star Zeng
Thanks,
Star
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Liming
Gao
Sent: Wednesday, December 27, 2017 5:12 PM
To: edk2-devel@lists.01.org
Subject: [edk2] [Patch] MdePkg: Update PI spec version to 1.6 in MdePkg.dec
Con
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Liming Gao
---
MdePkg/MdePkg.dec | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/MdePkg/MdePkg.dec b/MdePkg/MdePkg.dec
index 603e498..3c61a8f 100644
--- a/MdePkg/MdePkg.dec
+++ b/MdePkg/MdePkg.dec
@@ -2,7 +
On 27 December 2017 at 08:53, Long, Qin wrote:
> Thanks, Ard.
> Reviewed-by: Long Qin
>
Thanks. Pushed as 08ba82934ebd
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ard
> Biesheuvel
> Sent: Wednesday, December 27, 2017 4:05 PM
> To: edk2
Thanks, Ard.
Reviewed-by: Long Qin
Best Regards & Thanks,
LONG, Qin
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ard
Biesheuvel
Sent: Wednesday, December 27, 2017 4:05 PM
To: edk2-devel@lists.01.org; Long, Qin ; Ye, Ting
Cc: Ard Biesheuvel
After talked with Siyuan, we agree to use the int 0-1 value instead of Boolean
type so as to keep the same coding style in TcpInput.c.
Thanks,
Jiaxin
> -Original Message-
> From: Fu, Siyuan
> Sent: Wednesday, December 27, 2017 11:03 AM
> To: Wu, Jiaxin ; edk2-devel@lists.01.org
> Cc: Ye
Reviewed-by: Eric Dong
-Original Message-
From: Song, BinX
Sent: Wednesday, December 27, 2017 3:54 PM
To: edk2-devel@lists.01.org
Cc: Dong, Eric ; ler...@redhat.com
Subject: [PATCH] UefiCpuPkg: Fix comment typo for MtrrLibApplyFixedMtrrs
function
Fix comment typo for MtrrLibApplyFixedM
On GCC Build: openssl-1.1.0g introduced one additional build warning:
...\openssl\crypto\asn1\x_int64.c:105:32: error: format '%ld' expects
argument of type 'long int', but argument 3 has type 'int64_t
{aka long long int}' [-Werror=format=]
return BIO_printf(out, "%"BIO_PRI64"d\n", **(i
53 matches
Mail list logo
