Re: [edk2] [PATCH] RFC : Ping : Fix for loss of first ping packet

Hi, I have shared patch with correction in subject. Please see if it is visible to you now. Thanks, Meenakshi > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Thursday, February 15, 2018 5:59 PM > To: Meenakshi Aggarwal ; > ruiyu...@intel.com; jaben.car...@i

[edk2] [PATCH v3 3/4] Platform/Hisilicon/HiKey: use Hisilicon common file

Use common file Hisilicon.dsc.inc/Hisilicon.fdf.inc to reduce redundant contents in both HiKey.dsc and HiKey.fdf. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Haojian Zhuang Reviewed-by: Leif Lindholm --- Platform/Hisilicon/HiKey/HiKey.dsc | 205 +++

[edk2] [PATCH v3 4/4] Platform/Hisilicon/HiKey960: add skeleton of HiKey960

Add skeleton of HiKey960 platform. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Haojian Zhuang Reviewed-by: Leif Lindholm --- Platform/Hisilicon/HiKey960/HiKey960.dsc | 263 + Platform/Hisilicon/HiKey960/HiKey960.fdf | 214 ++

[edk2] [PATCH v3 1/4] Platform/Hisilicon/HiKey: include DxePcdLib for HiiDatabase

Include DxePcdLib for HiiDatabase. Otherwise, PlatformBootManager can't be launched successfully. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Haojian Zhuang Reviewed-by: Leif Lindholm --- Platform/Hisilicon/HiKey/HiKey.dsc | 7 +-- 1 file changed, 5 insertions(+),

[edk2] [PATCH v3 0/4] support hikey960

Changelog: v3: * Sort the patch sequence. * Add CONFIG_NO_DEBUGLIB in HiKey/HiKey960 dsc file. v2: * Use Hisilicon common file. * Move SerialPorLib & DebugLib of DXE_RUNTIME out of Hisilicon.dsc.inc. * Remove unused PCD values from HiKey960 dsc file. * Fix to enter boot manager on HiKe

[edk2] [PATCH v3 2/4] Platform/Hisilicon: move out SerialPortLib from common file

Dw8250SerialPortRuntimeLib only exists in D02. DebugLib isn't necessary on HiKey platform. So add CONFIG_NO_DEBUGLIB on it. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Haojian Zhuang --- Platform/Hisilicon/D02/Pv660D02.dsc | 1 + Platform/Hisilicon/HiKey/HiKey.dsc |

Re: [edk2] [PATCH v2 3/4] Platform/Hisilicon: move out dxe runtime lib from common file

On 02/15/2018 11:41 PM, Leif Lindholm wrote: > On Mon, Feb 12, 2018 at 11:45:06AM +, Leif Lindholm wrote: >> On Sat, Feb 10, 2018 at 01:31:06AM +0800, Haojian Zhuang wrote: >>> With the SerialPortLib and DebugLib, Dxe runtime driver can't >>> be executed well on HiKey. Serial logs are missing.

[edk2] [PATCH] MdePkg/Include/IndustryStandard: Add PCI Express 4.0 header file

The header includes Physical Layer PCI Express Extended Capability definitions described in section 7.7.5 of PCI Express Base Specification rev. 4.0. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Felix Polyudov --- MdePkg/Include/IndustryStandard/PciExpress40.h | 69

Re: [edk2] [Patch 3/3] MdeModulePkg/BootLogoLib: Use Boot Logo 2 Protocol

Sean, Thanks for the feedback. I have posted V2 with this change. Mike From: Sean Brogan [mailto:sean.bro...@microsoft.com] Sent: Tuesday, February 13, 2018 7:21 PM To: Kinney, Michael D ; edk2-devel@lists.01.org Cc: Bret Barkelew ; Yao, Jiewen ; Zeng, Star ; Dong, Eric Subject: Re: [Patch 3

[edk2] [Patch v2 3/3] MdeModulePkg/BootLogoLib: Use Boot Logo 2 Protocol

https://bugzilla.tianocore.org/show_bug.cgi?id=799 Based on content from the following branch/commit: https://github.com/Microsoft/MS_UEFI/tree/share/MsCapsuleSupport https://github.com/Microsoft/MS_UEFI/commit/33bab4031a417d7d5a7d356c15a14c2e60302b2d Add check to see if the Boot Logo 2 Protocol

[edk2] [Patch v2 2/3] MdeModulePkg/BootGraphicsResourceDxe: Add Boot Logo 2 Protocol

From: Michael D Kinney https://bugzilla.tianocore.org/show_bug.cgi?id=799 Based on content from the following branch/commit: https://github.com/Microsoft/MS_UEFI/tree/share/MsCapsuleSupport https://github.com/Microsoft/MS_UEFI/commit/33bab4031a417d7d5a7d356c15a14c2e60302b2d Update BootGraphicsR

[edk2] [Patch v2 1/3] MdeModulePkg: Add Boot Logo 2 Protocol

https://bugzilla.tianocore.org/show_bug.cgi?id=799 Based on content from the following branch/commit: https://github.com/Microsoft/MS_UEFI/tree/share/MsCapsuleSupport https://github.com/Microsoft/MS_UEFI/commit/33bab4031a417d7d5a7d356c15a14c2e60302b2d Add new Boot Logo 2 Protocol that adds a GetB

[edk2] [Patch v2 0/3] MdeModulePkg: Add Boot Logo 2 Protocol

V2: * Make Boot Logo2 Protocol higher priority than Boot Logo Protocol. If both are present, then only use Boot Logo 2 Protocol Branch for review: https://github.com/mdkinney/edk2/tree/Bug_799_BootLogo2Protocol_V4 https://bugzilla.tianocore.org/show_bug.cgi?id=799 Based on content from the fol

Re: [edk2] [Patch] MdeModulePkg PeiCore: Add error message to describe PEIM load failure

On 02/08/2018 04:31 AM, Laszlo Ersek wrote: On 02/08/18 11:24, Gao, Liming wrote: Laszlo: 11p address is big to cover most real address. It can align and save the message length. > Good point, it can go up to 2^44 - 1, covering 16 TB of RAM. Tiny little 16-banger. Buy a real computer.

[edk2] [PATCH 4/4] MdePkg/BaseSafeIntLib: fix undefined behavior in SafeInt64Mult()

If we have to negate UnsignedResult (due to exactly one of Multiplicand and Multiplier being negative), and UnsignedResult is exactly MIN_INT64_MAGNITUDE (value 2^63), then the statement *Result = - ((INT64)UnsignedResult); invokes both implementation-defined behavior and undefined behavi

[edk2] [PATCH 0/4] MdePkg/BaseSafeIntLib: fix undefined behavior in INT64 Sub/Add/Mult

Repo: https://github.com/lersek/edk2.git Branch: signed_range_checks Based on the discussion starting at . Cc: Bret Barkelew Cc: Liming Gao Cc: Michael D Kinney Cc: Sean Brogan Laszlo Ersek (4): MdePkg/BaseSafeIntLib: f

[edk2] [PATCH 1/4] MdePkg/BaseSafeIntLib: fix undefined behavior in SafeInt64Sub()

The subtraction in the assignment SignedResult = Minuend - Subtrahend; is performed with unchecked INT64 operands. According to ISO C, if the mathematical result of signed integer subtraction cannot be represented in the result type, the behavior is undefined. (Refer to ISO C99 6.5p5. 6.2.5p9 o

[edk2] [PATCH 3/4] MdePkg/BaseSafeIntLib: clean up parentheses in MIN_INT64_MAGNITUDE

The definition of the MIN_INT64_MAGNITUDE macro is correct, but it's harder to read than necessary: the sub-expression (( (UINT64) - (MIN_INT64 + 1) )) is doubly parenthesized. Reusing one pair of the outer parens, rewrite the sub-expression (without change in meaning) so that the minus sig

[edk2] [PATCH 2/4] MdePkg/BaseSafeIntLib: fix undefined behavior in SafeInt64Add()

The addition in the assignment SignedResult = Augend + Addend; is performed with unchecked INT64 operands. According to ISO C, if the mathematical result of signed integer addition cannot be represented in the result type, the behavior is undefined. (Refer to ISO C99 6.5p5. 6.2.5p9 only exempts

[edk2] [PATCH edk2-platforms 0/5] Add Secure96 mezzanine support

This series adds preliminary support for the Secure96 mezzanine board, an expansion board that can be plugged into the low speed connector on the Socionext SynQuacer based Developer Box platform. I have attempted to implement this in a reusable way, i.e., the secure96 specific parts are in separat

[edk2] [PATCH edk2-platforms 5/5] Platform/Socionext/DeveloperBox: add Secure96 support

Add the drivers and set the PCD values according to our integration of the LS connector on Developer Box so that, when selected in the menu, the device tree presented in the OS is augmented with nodes describing the various peripherals that are present on the Secure96 mezzanine board. Contributed-

[edk2] [PATCH edk2-platforms 4/5] Silicon/SynQuacer/PlatformDxe: add menu option to select mezzanine

96boards mezzanines are not runtime discoverable, so it is up to the user to tell the firmware what is connected. So add a pulldown entry that allows a selection to be made: note that boards are only expected to have a single LS connector, so a pulldown is appropriate here. If Secure96 has been se

[edk2] [PATCH edk2-platforms 3/5] Platform: add support for 96boards Secure96 mezzanine adapter

Add an overlay device tree describing the Secure96 mezzanine adapter, parameterised using PCDs. This allows this image, and the accompanying driver to be incorporated into any platform that may have such a board connected to its 96board low speed (LS) connector. Note that this relies on runtime su

[edk2] [PATCH edk2-platforms 2/5] Silicon/SynQuaver/DeviceTree: add node for I2C controller

Add a node for the I2C controller #1 to the device tree so the OS may attach to it. This is the I2C controller that is attached to the 96boards mezzanine connector on Developer Box. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel --- Silicon/Socionext/SynQua

[edk2] [PATCH edk2-platforms 1/5] Silicon/SynQuaver/DeviceTree: add node for SPI controller

Add a node for the SPI controller to the device tree so the OS may attach to it. This is the SPI controller that is attached to the 96boards mezzanine connector on Developer Box. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel --- Silicon/Socionext/SynQuacer

Re: [edk2] [PATCH edk2-platforms] AMD, Hisilicon, Socionext: fix build after DxeCapsuleLibFmp changes

On Wed, Feb 14, 2018 at 09:11:59PM +, Kinney, Michael D wrote: > Reviewed-by: Michael D Kinney Thanks - pushed as ce6c2604be. Regards, Leif > Mike > > > -Original Message- > > From: Leif Lindholm [mailto:leif.lindh...@linaro.org] > > Sent: Tuesday, February 13, 2018 8:46 AM > > To

Re: [edk2] [PATCH v2 3/4] Platform/Hisilicon: move out dxe runtime lib from common file

On Mon, Feb 12, 2018 at 11:45:06AM +, Leif Lindholm wrote: > On Sat, Feb 10, 2018 at 01:31:06AM +0800, Haojian Zhuang wrote: > > With the SerialPortLib and DebugLib, Dxe runtime driver can't > > be executed well on HiKey. Serial logs are missing. > > "Can't be executed well"? Does this mean it

[edk2] [PATCH] ArmPkg/PlatformBootManagerLib: add hotkey to fastboot

It checkes whether AndroidFastbootApp exists in boot menu. If it exists, add hotkey 'F' to AndroidFastbootApp. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Haojian Zhuang --- ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c | 40 ++ 1 file changed,

[edk2] [PATCH 0/2] add boot options in HiKey

ChangeLog: v1: *Create boot options in emu variable region. Haojian Zhuang (2): Platform/Hisilicon/HiKey960: add boot options Platform/Hisilicon/HiKey: add boot options Platform/Hisilicon/HiKey/HiKey.dsc | 3 + Platform/Hisilicon/HiKey/HiKey.fdf | 239

[edk2] [PATCH 1/2] Platform/Hisilicon/HiKey960: add boot options

Add four boot options in emu variable region. They are "Boot on SD", "Grub", "Android Boot" and "Android Fastboot". Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Haojian Zhuang --- Platform/Hisilicon/HiKey960/HiKey960.dsc | 3 + Platform/Hisilicon/HiKey960/HiKey960.fdf

[edk2] [PATCH 2/2] Platform/Hisilicon/HiKey: add boot options

Add four boot options into emu variable region. They're "Boot on SD", "Grub", "Android Boot" and "Android Fastboot". Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Haojian Zhuang --- Platform/Hisilicon/HiKey/HiKey.dsc | 3 + Platform/Hisilicon/HiKey/HiKey.fdf | 239

[edk2] [edk2 PATCH v2 1/1] Maintainers.txt: Add StandaloneMmPkg and maintainers

From: Achin Gupta This patch adds maintainers, reviewer and directory for the StandaloneMmPkg. This package will host an implementation of Standalone Management Mode as specified in the Platform Initialization (PI) Specification, Volume 4: Management Mode Core Interface. Contributed-under: Tiano

[edk2] [edk2 PATCH v2 0/1] *** Add StandaloneMmPkg and maintainers ***

From: Achin Gupta PI Specification v1.5 "Volume 4: Management Mode Core Interface" introduces the concept of MM Standalone Mode. The StandaloneMmPkg will host an implementation of this feature. Development of this package was done in edk2-staging [1]. Support for MM in Standalone Mode was origin

Re: [edk2] [edk2 PATCH v1 1/1] Maintainers.txt: Add StandaloneMmPkg and maintainers

On Thu, Feb 15, 2018 at 09:17:36AM +, achin.gu...@arm.com wrote: > From: Achin Gupta > > This patch adds maintainers, reviewer and directory for the > StandaloneMmPkg. This package will host an implementation of Standalone > Management Mode as specified in the Platform Initialization (PI) >

Re: [edk2] [PATCH] EmbeddedPkg/FdtLib: incorporate missing overlay support

On Thu, Feb 15, 2018 at 10:34:28AM +, Ard Biesheuvel wrote: > Commit a099239015eb ("EmbeddedPkg/FdtLib: Update FdtLib to v1.4.5") > updated our FdtLib implementation to a more recent upstream version, > but omitted fdt_overlay.c due to its ambiguous licensing situation. > This has been resolved

Re: [edk2] [PATCH] RFC : Ping : Fix for loss of first ping packet

Hi Meenakshi, On 02/15/18 13:08, Meenakshi Aggarwal wrote: > Hi, > > Any comment? I don't see your original patch email on the list, either in my personal folder, or in the archive at . Can you resend? Also, I suggest a subjec

Re: [edk2] [PATCH] RFC : Ping : Fix for loss of first ping packet

Hi, Any comment? Thanks & Regards, Meenakshi > -Original Message- > From: Meenakshi Aggarwal [mailto:meenakshi.aggar...@nxp.com] > Sent: Tuesday, February 13, 2018 8:52 PM > To: ruiyu...@intel.com; jaben.car...@intel.com; edk2-devel@lists.01.org > Cc: Udit Kumar ; Varun Sethi ; > Meenaks

Re: [edk2] [PATCH v2 0/2] NetworkPkg: Support the platform to configure HTTPS CipherList.

Hi Jiaxin, On 02/13/18 03:01, Wu, Jiaxin wrote: > Thanks Laszlo. > > If no other comments, I will commit this patch by the end of today. Thank you again for the patches. I have a workflow-related request: please do not add my "Reviewed-by" to patches for which I didn't post a "Reviewed-by" *verb

[edk2] [PATCH] EmbeddedPkg/FdtLib: incorporate missing overlay support

Commit a099239015eb ("EmbeddedPkg/FdtLib: Update FdtLib to v1.4.5") updated our FdtLib implementation to a more recent upstream version, but omitted fdt_overlay.c due to its ambiguous licensing situation. This has been resolved now, so take the latest upstream version of the file (which received no

[edk2] [edk2 PATCH v1 1/1] Maintainers.txt: Add StandaloneMmPkg and maintainers

From: Achin Gupta This patch adds maintainers, reviewer and directory for the StandaloneMmPkg. This package will host an implementation of Standalone Management Mode as specified in the Platform Initialization (PI) Specification, Volume 4: Management Mode Core Interface. Contributed-under: Tiano

[edk2] [edk2 PATCH v1 0/1] *** Add StandaloneMmPkg and maintainers ***

From: Achin Gupta PI Specification v1.5 "Volume 4: Management Mode Core Interface" introduces the concept of MM Standalone Mode. The StandaloneMmPkg will host an implementation of this feature. Development of this package was done in edk2-staging [1]. Support for MM in Standalone Mode was origin