Re: [edk2] [PATCH edk2-platforms v1 13/14] Hisilicon/Library: Add OsBootLib

2018-02-25 Thread Guo Heyi
Hi Peter, Thanks for your detailed explanation. I still have one question: On normal platforms, there are more boot options created by UEFI other than the hard disk boot option created by OS installation, like PXE network boot, USB stick boot, etc. If we use the PlatformRecovery method, will

Re: [edk2] [Patch] BaseTools GenFv: Update error message to describe PE image alignment

2018-02-25 Thread Zhu, Yonghong
Reviewed-by: Yonghong Zhu Best Regards, Zhu Yonghong -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Liming Gao Sent: Thursday, February 08, 2018 3:30 PM To: edk2-devel@lists.01.org Subject: [edk2] [Patch] BaseTools GenFv: Update error message

Re: [edk2] [Patch] BaseTools: Add the missing basic definition in C BaseType.h

2018-02-25 Thread Zhu, Yonghong
Reviewed-by: Yonghong Zhu Best Regards, Zhu Yonghong -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Liming Gao Sent: Thursday, February 08, 2018 9:14 PM To: edk2-devel@lists.01.org Subject: [edk2] [Patch] BaseTools: Add the missing basic defi

Re: [edk2] TPM 2.0 Manufacutre ID wrong byte order

2018-02-25 Thread Lin, Derek (HPS UEFI Dev)
I agree. Add comments to make this clear seems good. It's good enough for me. Thanks, Derek -Original Message- From: Zhang, Chao B [mailto:chao.b.zh...@intel.com] Sent: Saturday, February 24, 2018 2:26 PM To: Lin, Derek (HPS UEFI Dev) ; edk2-devel@lists.01.org Cc: Yao, Jiewen ; Zeng, Sta

Re: [edk2] [PATCH] MdeModulePkg SmmLockBox: Return updated Length for EFI_BUFFER_TOO_SMALL

2018-02-25 Thread Yao, Jiewen
Reviewed-by: jiewen@intel.com > -Original Message- > From: Zeng, Star > Sent: Saturday, February 24, 2018 6:21 PM > To: edk2-devel@lists.01.org > Cc: Zeng, Star ; Yao, Jiewen > Subject: [PATCH] MdeModulePkg SmmLockBox: Return updated Length for > EFI_BUFFER_TOO_SMALL > > The updated

[edk2] [Patch] BaseTools: Update GenFw to correct DebugEntry Offset when convert XIP image

2018-02-25 Thread Liming Gao
DebugEntry FileOffset is required to be updated to the virtual address if the input image is converted to XIP image. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Liming Gao --- BaseTools/Source/C/GenFw/GenFw.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/Ba

[edk2] [patch] MdePkg/BaseSafeIntLib: Fix VS2015 IA32 NOOPT build failure

2018-02-25 Thread Dandan Bi
There are VS2015 NOOPT IA32 build failure like below in BaseSafeIntLib. XXX.lib(XXX.obj): error LNK2001: unresolved external symbol __allmul XXX.lib(XXX.obj): error LNK2001: unresolved external symbol __allshl XXX.lib(XXX.obj): error LNK2001: unresolved external symbol __aullshr This patch replace

[edk2] [RFC] Add Platform Include path in modules

2018-02-25 Thread Pankaj Bansal
When we are writing the drivers for IP modules, then sometimes we want that Platform specific customizations or platform dependent values be supplied to IP module driver. normally we achieve this using Pcd values. But sometimes we want to use header files for such data.e.g. if the values are compl

Re: [edk2] [RFC] MdePkg/BaseLib: Change BitField functions.

2018-02-25 Thread Pankaj Bansal
Hello Laszlo, Thanks for your explanation. Now I understand the usage of bit field functions. Regards, Pankaj Bansal > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Friday, February 23, 2018 5:43 PM > To: Pankaj Bansal ; Gao, Liming > ; edk2-devel@lists.01.or

[edk2] [Patch] BaseTools: Add more error message when PcdValue is wrong

2018-02-25 Thread Liming Gao
For structure PCD, its field name is wrong and cause build failure. Its build error message will output to let user aware what's wrong. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Liming Gao Cc: Feng Bob C --- BaseTools/Source/Python/Workspace/DscBuildData.py | 2 ++

Re: [edk2] [Patch] BaseTools: Update GenFw to correct DebugEntry Offset when convert XIP image

2018-02-25 Thread Zhu, Yonghong
Reviewed-by: Yonghong Zhu Best Regards, Zhu Yonghong -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Liming Gao Sent: Monday, February 26, 2018 1:52 PM To: edk2-devel@lists.01.org Subject: [edk2] [Patch] BaseTools: Update GenFw to correct Debu

Re: [edk2] [Patch] BaseTools: Add more error message when PcdValue is wrong

2018-02-25 Thread Zhu, Yonghong
Reviewed-by: Yonghong Zhu Best Regards, Zhu Yonghong -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Liming Gao Sent: Monday, February 26, 2018 3:15 PM To: edk2-devel@lists.01.org Subject: [edk2] [Patch] BaseTools: Add more error message when

Re: [edk2] [RFC] Add Platform Include path in modules

2018-02-25 Thread Kinney, Michael D
Hi, Can you provide a simple example that shows how this feature is used and how it works? Thanks, Mike > -Original Message- > From: edk2-devel [mailto:edk2-devel- > boun...@lists.01.org] On Behalf Of Pankaj Bansal > Sent: Sunday, February 25, 2018 10:29 PM > To: edk2-devel@lists.01.or

[edk2] [Patch] BaseTools: Fix a bug override Pcd by DSC Components section

2018-02-25 Thread Yonghong Zhu
The case is: define a VOID* pcd in DEC file, eg: Value is {0x1}. then override this PCD on DSC component section, eg: Value is {0x1, 0x2, 0x3}, the max size of this PCD is calculate wrong which cause build error. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Yonghong Zhu