Re: [edk2] [PATCH v2 1/1] ArmPkg/TimerDxe: Add ISB for timer compare value reload

On Tue, Mar 13, 2018 at 09:33:33AM +, Marc Zyngier wrote: > On 13/03/18 00:31, Heyi Guo wrote: > > If timer interrupt is level sensitive, reloading timer compare > > register has a side effect of clearing GIC pending status, so a "ISB" > > is needed to make sure this instruction is executed bef

[edk2] EFI ExitBootServices() function crashes in QEMU

Hello I am implementing a simple UEFI bootloader. Most EFI functions that I tried work me - I can clear Console, print text, successfully read files from system partition, allocate memory pages. But if I try to read memory map and then call ExitBootServices() QEMU crashes for me: > qemu-system-

[edk2] [PATCH v1 5/5] BaseTools: RangeExpression - remove unused variable

remove a never used variable. Cc: Yonghong Zhu Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jaben Carsey --- BaseTools/Source/Python/Common/RangeExpression.py | 9 + 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/BaseTools/Source/P

[edk2] [PATCH v1 2/5] BaseTools: Expression refactor function

The function is about C Names, not C Strings. Move the re.compile outside the function call Cc: Yonghong Zhu Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jaben Carsey --- BaseTools/Source/Python/Common/Expression.py | 11 +-- 1 file changed, 5 i

[edk2] [PATCH v1 4/5] BaseTools: Expression - remove variable

The InArary variable serves no purpose. just do the work immediately. Cc: Yonghong Zhu Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jaben Carsey --- BaseTools/Source/Python/Common/Expression.py | 3 --- 1 file changed, 3 deletions(-) diff --git a/Base

[edk2] [PATCH v1 3/5] BaseTools: Expression - change from series of if to elif

since the first character of the string cannot be found by multiple if statements, use elif to optomize the behavior. Cc: Yonghong Zhu Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jaben Carsey --- BaseTools/Source/Python/Common/Expression.py | 8 ---

[edk2] [PATCH v1 1/5] BaseTools: Expression - remove redundant variable

Str is created and not needed. Cc: Yonghong Zhu Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jaben Carsey --- BaseTools/Source/Python/Common/Expression.py | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/BaseTools/Source/Py

[edk2] [PATCH v1 0/5] BaseTools - some simple cleanups for BaseTools

cleanup up some BaseTools code for simplicity. Jaben Carsey (5): BaseTools: Expression - remove redundant variable BaseTools: Expression refactor function BaseTools: Expression - change from series of if to elif BaseTools: Expression - remove variable BaseTools: RangeExpression - remove

[edk2] [PATCH 2/6] OvmfPkg/QemuBootOrderLib: add missing EFIAPI specifiers

Public library APIs should be declared as EFIAPI. Cc: Ard Biesheuvel Cc: Jordan Justen Cc: Shannon Zhao Cc: Xiang Zheng Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Laszlo Ersek --- OvmfPkg/Include/Library/QemuBootOrderLib.h | 2 ++ OvmfPkg/Library/QemuBoot

[edk2] [PATCH 6/6] ArmVirtPkg/PlatformBootManagerLib: minimize the set of connected devices

Prefer ConnectDevicesFromQemu() to EfiBootManagerConnectAll(). Cc: Ard Biesheuvel Cc: Jordan Justen Cc: Shannon Zhao Cc: Xiang Zheng Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Laszlo Ersek --- ArmVirtPkg/Library/PlatformBootManagerLib/PlatformBm.c | 12 ++-

[edk2] [PATCH 1/6] OvmfPkg/QemuBootOrderLib: wrap overlong line

81 characters is too many. Cc: Ard Biesheuvel Cc: Jordan Justen Cc: Shannon Zhao Cc: Xiang Zheng Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Laszlo Ersek --- OvmfPkg/Library/QemuBootOrderLib/QemuBootOrderLib.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)

[edk2] [PATCH 5/6] OvmfPkg/PlatformBootManagerLib: minimize the set of connected devices

Prefer ConnectDevicesFromQemu() to EfiBootManagerConnectAll(). Cc: Ard Biesheuvel Cc: Jordan Justen Cc: Shannon Zhao Cc: Xiang Zheng Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Laszlo Ersek --- OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.c | 16 ++---

[edk2] [PATCH 0/6] OvmfPkg, ArmVirtQemu: leaner platform BDS policy for connecting devices

Repo: https://github.com/lersek/edk2.git Branch: qemu_bootorder_connect Adding tens or hundreds of bootable devices to a QEMU VM config slows the OVMF and ArmVirtQemu boots to a crawl, several people have reported in the past. There are at least two reasons for this (high pflash traffic due to

[edk2] [PATCH 4/6] OvmfPkg/QemuBootOrderLib: add ConnectDevicesFromQemu()

QemuBootOrderLib expects PlatformBootManagerLib to call the following triplet: (1) EfiBootManagerConnectAll(), (2) EfiBootManagerRefreshAllBootOption(), (3) SetBootOrderFromQemu(). This leads to bad performance, when many devices exist such that the firmware can drive them, but they aren't marked

[edk2] [PATCH 3/6] OvmfPkg/QemuBootOrderLib: clean up translation of virtio-net over MMIO

The "/MAC(" suffix of the translated UEFI devpath prefix is unnecessary for matching, because the virtio-mmio base address in VenHwString is unique anyway. Furthermore, the partial string "MAC(" cannot be processed by ConvertTextToDevicePath(), which will become relevant later in this series. Remov

Re: [edk2] [RFC] Remove X86 .asm and .S assembly files in EDK2

Liming, After further evaluation on use of NASM with macho there are a couple issues that need to be resolved before the .asm and .S files can be removed from all components. The details are at: https://bugzilla.tianocore.org/show_bug.cgi?id=881 NASM issues to be resolved are: https://bugzilla

Re: [edk2] [edk2 PATCH v2 1/1] Maintainers.txt: Add StandaloneMmPkg and maintainers

Reviewed-by: Michael D Kinney Mike > -Original Message- > From: achin.gu...@arm.com [mailto:achin.gu...@arm.com] > Sent: Thursday, February 15, 2018 5:32 AM > To: edk2-devel@lists.01.org > Cc: af...@apple.com; Kinney, Michael D > ; leif.lindh...@linaro.org; > Yao, Jiewen ; > supreeth.ven

[edk2] [PATCH v3] edksetup.sh: Update help section regarding positional parameters

It is possible to source edksetup.sh from another script. If the sourcing script has any set positional parameters that are not supported by edksetup.sh, the help section is always shown. This patch updates the help section informing the user about these possible unsupported set positional paramete

Re: [edk2] [PATCH v2] edksetup.sh: Update help section regarding positional parameters

Hi Liming: Thank you for your reply. Yes, I agree that it is OK to pass supported positional parameters through a sourcing script. I will reword my patch considering this. Thanks! -Arvind. -

Re: [edk2] [Patch v2] EmbeddedPkg: Correct the way of handling sections with a large size

On 8 March 2018 at 00:55, Ge Song wrote: > Correct the way of handling EFI_SECTION_GUID_DEFINED type sections > with a large size > > Cc: Leif Lindholm > Cc: Ard Biesheuvel > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ge Song > Reviewed-by: Ard Biesheuvel Pushed

Re: [edk2] [PATCH] ShellPkg/[hex]edit: Fix mouse freeze issue

Reviewed-by: Jaben Carsey > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Ruiyu Ni > Sent: Tuesday, March 13, 2018 12:41 AM > To: edk2-devel@lists.01.org > Cc: Carsey, Jaben > Subject: [edk2] [PATCH] ShellPkg/[hex]edit: Fix mouse freeze iss

Re: [edk2] [PATCH] ShellPkg/Dmpstore: Enhance display information for Auth3 variable.

Reviewed-by: Jaben Carsey Looks good. Please clarify that this is an output flag, not a command line flag in the commit log. > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > chenc2 > Sent: Tuesday, March 13, 2018 12:37 AM > To: edk2-devel

Re: [edk2] [PATCH] OvmfPkg/Gop: clear the screen to black in SetMode()

> -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo > Ersek > Sent: Tuesday, March 13, 2018 9:10 PM > To: Ni, Ruiyu ; edk2-devel@lists.01.org > Cc: Justen, Jordan L ; Ard Biesheuvel > > Subject: Re: [edk2] [PATCH] OvmfPkg/Gop: clear the sc

Re: [edk2] [PATCH v2] edksetup.sh: Update help section regarding positional parameters

Arvind: The caller script may set the supported parameters by edksetup.sh. So, the notes may be updated not to set the unknown parameter. Thanks Liming > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Arvind > Prasanna > Sent: Tuesday, March

Re: [edk2] [PATCH 00/45] ArmVirtPkg, OvmfPkg: list module-internal headers in INF files

On 03/11/18 02:48, Laszlo Ersek wrote: > Repo: https://github.com/lersek/edk2.git > Branch: hdr_inf_cleanup > > In > , > Mike explained why it's a good idea to list module-internal *.h files in > t

Re: [edk2] [PATCH] OvmfPkg/Gop: clear the screen to black in SetMode()

Hi Ray, On 03/13/18 11:05, Ruiyu Ni wrote: > Today's implementation forgot to clear the screen to black in > SetMode(). It causes SCT SetMode() test fails. > > The patch adds the clear screen operation in SetMode() to fix > the SCT failure. > > Contributed-under: TianoCore Contribution Agreement

Re: [edk2] [PATCH 0/3] SouceLevelDebugPkg DebugCommUsb3: Enhancements after supporting IOMMU

Good finding. The typo has been fixed in local. Thanks very much. Star -Original Message- From: Wu, Hao A Sent: Tuesday, March 13, 2018 8:56 PM To: Zeng, Star ; edk2-devel@lists.01.org Cc: Yao, Jiewen ; Ni, Ruiyu Subject: RE: [PATCH 0/3] SouceLevelDebugPkg DebugCommUsb3: Enhancements aft

Re: [edk2] [PATCH 0/3] SouceLevelDebugPkg DebugCommUsb3: Enhancements after supporting IOMMU

> -Original Message- > From: Zeng, Star > Sent: Monday, March 12, 2018 11:37 AM > To: Wu, Hao A; edk2-devel@lists.01.org > Cc: Yao, Jiewen; Ni, Ruiyu; Zeng, Star > Subject: RE: [PATCH 0/3] SouceLevelDebugPkg DebugCommUsb3: > Enhancements after supporting IOMMU > > I have handled the mistak

Re: [edk2] [PATCH] MdeModulePkg PCD: Remove PCD_TYPE_SKU_ENABLED in PCD_TYPE_ALL_SET

Not wait more time any more as it is an urgent build failure. Pushed at d154a4dfaec4bf25acaca643e9ac15a3bc8d7a12. Thanks all. Star -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ard Biesheuvel Sent: Tuesday, March 13, 2018 8:42 PM To: Zeng, Star

Re: [edk2] [PATCH] MdeModulePkg PCD: Remove PCD_TYPE_SKU_ENABLED in PCD_TYPE_ALL_SET

Reviewed-by: Eric Dong -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Star Zeng Sent: Tuesday, March 13, 2018 5:04 PM To: edk2-devel@lists.01.org Cc: Gao, Liming ; Zeng, Star ; Thomas Lamprecht Subject: [edk2] [PATCH] MdeModulePkg PCD: Remove P

Re: [edk2] [PATCH] MdeModulePkg PCD: Remove PCD_TYPE_SKU_ENABLED in PCD_TYPE_ALL_SET

On 13 March 2018 at 09:04, Star Zeng wrote: > Remove PCD_TYPE_SKU_ENABLED in PCD_TYPE_ALL_SET. > This change was missing at e8d2a9805286a2fd4f613697cf0cccb4a1ebc90d. > > Cc: Liming Gao > Cc: Thomas Lamprecht > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Star Zeng A

[edk2] [PATCH] OvmfPkg/Gop: clear the screen to black in SetMode()

Today's implementation forgot to clear the screen to black in SetMode(). It causes SCT SetMode() test fails. The patch adds the clear screen operation in SetMode() to fix the SCT failure. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ruiyu Ni Cc: Jordan Justen Cc: Laszl

Re: [edk2] [PATCH] MdeModulePkg PCD: Remove PCD_TYPE_SKU_ENABLED in PCD_TYPE_ALL_SET

Maybe. I am using the MS outlook. Thanks, Star -Original Message- From: Thomas Lamprecht [mailto:t.lampre...@proxmox.com] Sent: Tuesday, March 13, 2018 5:22 PM To: Zeng, Star ; edk2-devel@lists.01.org Cc: Gao, Liming Subject: Re: [edk2] [PATCH] MdeModulePkg PCD: Remove PCD_TYPE_SKU_ENABL

Re: [edk2] [PATCH v2 1/1] ArmPkg/TimerDxe: Add ISB for timer compare value reload

On 13/03/18 00:31, Heyi Guo wrote: > If timer interrupt is level sensitive, reloading timer compare > register has a side effect of clearing GIC pending status, so a "ISB" > is needed to make sure this instruction is executed before enabling > CPU IRQ, or else we may get spurious timer interrupts.

Re: [edk2] [PATCH] MdeModulePkg PCD: Remove PCD_TYPE_SKU_ENABLED in PCD_TYPE_ALL_SET

On 03/13/2018 10:04 AM, Star Zeng wrote: > Remove PCD_TYPE_SKU_ENABLED in PCD_TYPE_ALL_SET. > This change was missing at e8d2a9805286a2fd4f613697cf0cccb4a1ebc90d. > > Cc: Liming Gao > Cc: Thomas Lamprecht > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Star Zeng > ---

Re: [edk2] [PATCH] MdeModulePkg PCD: Remove PCD_TYPE_SKU_ENABLED in PCD_TYPE_ALL_SET

On 03/13/2018 10:04 AM, Star Zeng wrote: > Remove PCD_TYPE_SKU_ENABLED in PCD_TYPE_ALL_SET. > This change was missing at e8d2a9805286a2fd4f613697cf0cccb4a1ebc90d. > > Cc: Liming Gao > Cc: Thomas Lamprecht > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Star Zeng > ---

Re: [edk2] [Patch] MdeModulePkg PCD: Remove unused PCD attribute PCD_TYPE_SKU_ENABLED

Please help check the patch at https://lists.01.org/pipermail/edk2-devel/2018-March/022668.html. Thanks, Star -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Thomas Lamprecht Sent: Tuesday, March 13, 2018 4:33 PM To: Gao, Liming ; edk2-devel@list

[edk2] [PATCH] MdeModulePkg PCD: Remove PCD_TYPE_SKU_ENABLED in PCD_TYPE_ALL_SET

Remove PCD_TYPE_SKU_ENABLED in PCD_TYPE_ALL_SET. This change was missing at e8d2a9805286a2fd4f613697cf0cccb4a1ebc90d. Cc: Liming Gao Cc: Thomas Lamprecht Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Star Zeng --- MdeModulePkg/Include/Guid/PcdDataBaseSignatureGuid.h |

Re: [edk2] [PATCH] MdeModulePkg/PiSmmCore: fix mem alloc issues in heap guard

Reviewed-by: jiewen@intelc.om > -Original Message- > From: Wang, Jian J > Sent: Tuesday, March 13, 2018 4:34 PM > To: edk2-devel@lists.01.org > Cc: Zeng, Star ; Dong, Eric ; Yao, > Jiewen > Subject: [PATCH] MdeModulePkg/PiSmmCore: fix mem alloc issues in heap guard > > This patch fix

[edk2] [PATCH] MdeModulePkg/PiSmmCore: fix mem alloc issues in heap guard

This patch fixes the same issues in Heap Guard in DXE core, which is fixed in another patch. Cc: Star Zeng Cc: Eric Dong Cc: Jiewen Yao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jian J Wang --- MdeModulePkg/Core/PiSmmCore/HeapGuard.c | 8 ++-- 1 file changed,

Re: [edk2] [Patch] MdeModulePkg PCD: Remove unused PCD attribute PCD_TYPE_SKU_ENABLED

On 03/07/2018 09:15 AM, Liming Gao wrote: > PcdDb optimization has handled PCD DB for each SKU, not for single PCD. > So, this PCD attribute is not used any more. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Liming Gao > Cc: Reviewed-by: Liming Gao This fails my

Re: [edk2] [PATCH] SecurityPkg OpalPasswordDxe: Move OPAL request variable definition

Reviewed-by: jiewen@intel.com > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Star > Zeng > Sent: Tuesday, March 13, 2018 9:29 AM > To: edk2-devel@lists.01.org > Cc: Zhang, Chao B ; Yao, Jiewen > ; Dong, Eric ; Zeng, Star > > Subject: [edk

Re: [edk2] [PATCH] SecurityPkg OpalPasswordPei: Continue when AhciModeInitialize is failed

Reviewed-by: jiewen@intel.com > -Original Message- > From: Zeng, Star > Sent: Tuesday, March 13, 2018 4:16 PM > To: edk2-devel@lists.01.org > Cc: Zeng, Star ; Yao, Jiewen ; > Dong, Eric ; Zhang, Chao B > Subject: [PATCH] SecurityPkg OpalPasswordPei: Continue when > AhciModeInitialize

[edk2] [PATCH] SecurityPkg OpalPasswordPei: Continue when AhciModeInitialize is failed

Continue to next loop instead of going to unlock OPAL password when AhciModeInitialize is failed. It is just error handling. Cc: Jiewen Yao Cc: Eric Dong Cc: Chao Zhang Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Star Zeng --- SecurityPkg/Tcg/Opal/OpalPassword/Opal

Re: [edk2] [PATCH v5 4/6] MdeModulePkg/PciHostBridgeDxe: Add support for address translation

On 13 March 2018 at 07:31, Guo Heyi wrote: > Hi Ray, > > If the major concern is about backward compatibility, we can think about ways > to > get around of this, e.g. add a feature PCD to turn on translation and set the > default value to false. > I don't think that is necessary. Like any other

[edk2] [Patch] MdeModulePkg BrotliLib: Rename function with the specific lib name

This change is to avoid the function conflict. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Liming Gao Cc: Star Zeng --- .../Library/BrotliCustomDecompressLib/BrotliDecompress.c | 14 +++--- .../BrotliDecompressLibInternal.h | 6 +++-

[edk2] [PATCH] ShellPkg/[hex]edit: Fix mouse freeze issue

In edit or hexedit, the mouse cursor doesn't move when moving the mouse. The root cause is 5563281fa2b31093a1cbd415553b9264c5136e89 * ShellPkg/[hex]edit: use SimpleTextInEx to read console wrongly uses WaitForEvent() to listen keyboard input. It blocks the code execution when there is no keyboard i

[edk2] [PATCH] ShellPkg/Dmpstore: Enhance display information for Auth3 variable.

Add "EA" flag for dumping auth3 variable. When dumping Auth3 variable, it will not only displaying variable content but also in addition to metadata. Give a warning message when dumping auth3 variable. Cc: Ni Ruiyu Cc: Zhang Chao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off

Re: [edk2] [PATCH] SecurityPkg OpalPasswordDxe: Return directly if no any device

Reviewed-by: jiewen@intel.com > -Original Message- > From: Zeng, Star > Sent: Tuesday, March 13, 2018 9:29 AM > To: edk2-devel@lists.01.org > Cc: Zeng, Star ; Yao, Jiewen ; > Dong, Eric ; Zhang, Chao B > Subject: [PATCH] SecurityPkg OpalPasswordDxe: Return directly if no any device >

Re: [edk2] [PATCH v5 4/6] MdeModulePkg/PciHostBridgeDxe: Add support for address translation

Hi Ray, If the major concern is about backward compatibility, we can think about ways to get around of this, e.g. add a feature PCD to turn on translation and set the default value to false. Thanks, Heyi On Tue, Mar 13, 2018 at 11:00:12AM +0800, Ni, Ruiyu wrote: > On 3/13/2018 1:18 AM, Ard Biesh