Thanks all.
Push the patch at 0c9f2cb10b7ddec56a3440e77219fd3ab1725e5c. :)
Star
-Original Message-
From: Kinney, Michael D
Sent: Thursday, April 5, 2018 4:28 AM
To: Yao, Jiewen ; Zeng, Star ;
edk2-devel@lists.01.org; Kinney, Michael D
Cc: Ni, Ruiyu ; Yi Li ; Dong, Eric
; Renhao Liang
Jiewen,
Responses below.
Mike
> -Original Message-
> From: Yao, Jiewen
> Sent: Wednesday, April 4, 2018 5:03 PM
> To: Kinney, Michael D ;
> edk2-devel@lists.01.org
> Cc: Sean Brogan ; Zeng, Star
> ; Dong, Eric
> ; Wei, David
> ; Guo, Mang ;
> Steele, Kelly
> Subject: RE: [Patch 0/9] Add
Hi Jiewen,
Responses below.
A couple require some comments from Sean or Bret.
Mike
> -Original Message-
> From: Yao, Jiewen
> Sent: Wednesday, April 4, 2018 4:29 PM
> To: Kinney, Michael D ;
> edk2-devel@lists.01.org
> Cc: Sean Brogan
> Subject: RE: [RFC 0/4] Add FmpDevicePkg
>
> Hi
Thanks Mike.
It is a good feature to add progress support.
Some thought below:
1) for EDKII_FIRMWARE_MANAGEMENT_PROGRESS_PROTOCOL
Do you think if we need add full support for WatchdogTimer services?
Such as WatchdogCode, WatchdogData?
Or should we add a version field for the protocol for future e
Hi Mike
It is great to see this feature. Thanks for doing this.
Some thought below:
1) Do we must add V1 as suffix for the FmpPayloadHeaderLib?
I think we can just use that FmpPayloadHeaderLib.
If we have second version, we can use FmpPayloadHeaderLibV2.
2) The check in GetFmpPayloadHeaderSize()
From: "Kinney, Michael D"
https://bugzilla.tianocore.org/show_bug.cgi?id=922
Based on content from the following branch:
https://github.com/Microsoft/MS_UEFI/tree/share/MsCapsuleSupport/MsCapsuleUpdatePkg
The FmpDxe directory contains 2 INF files. FmpDxe.inf
is a DXE driver that is used in a
From: "Kinney, Michael D"
https://bugzilla.tianocore.org/show_bug.cgi?id=922
Based on content from the following branch:
https://github.com/Microsoft/MS_UEFI/tree/share/MsCapsuleSupport/MsCapsuleUpdatePkg
Adds a DSC file that is used to verify that all of the
FmpDevicePkg libraries and modules
From: "Kinney, Michael D"
https://bugzilla.tianocore.org/show_bug.cgi?id=922
Based on content from the following branch:
https://github.com/Microsoft/MS_UEFI/tree/share/MsCapsuleSupport/MsCapsuleUpdatePkg
Create FmpDevicePkg with library classes and PCDs used to
customize the behavior of a Fir
From: "Kinney, Michael D"
https://bugzilla.tianocore.org/show_bug.cgi?id=922
Based on content from the following branch:
https://github.com/Microsoft/MS_UEFI/tree/share/MsCapsuleSupport/MsCapsuleUpdatePkg
Add library instances for FmpDeviceLib, CapsuleUpdatePolicyLib,
and FmpPayloadHeaderLib.
https://bugzilla.tianocore.org/show_bug.cgi?id=922
Based on content from the following branch:
https://github.com/Microsoft/MS_UEFI/tree/share/MsCapsuleSupport/MsCapsuleUpdatePkg
Branch for review:
https://github.com/mdkinney/edk2/tree/Bug_922_FmpDevicePkg
This package provides an implementati
-Original Message-
From: Ard Biesheuvel
Sent: Wednesday, April 4, 2018 3:06 PM
To: jbrasen.qdt
Cc: edk2-devel@lists.01.org
Subject: Re: [edk2] GenFds issue with multiple paths in PACKAGES_PATH
On 4 April 2018 at 19:00, jbrasen.qdt
wrote:
> Hello,
>
> I am trying to update my build sof
On 4 April 2018 at 19:00, jbrasen.qdt
wrote:
> Hello,
>
> I am trying to update my build software to the current edk2-platforms
> layout and am running into some issues with the final part of the build.
>
> It seems that the output is being generated under
> edk2/Build/Qdf_RBL/DEBUG_CLANG
by changing from list to set(), we can skip all the preprocessing
to prevent duplication and we dont need to convert to a set() later
on for each use
Cc: Liming Gao
Cc: Yonghong Zhu
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey
---
BaseTools/Source/Python/
no real functional change. just code cleanup.
Jaben Carsey (3):
BaseTools: move RegEx to root of file and share it
BaseTools: Autogen - change from list to set
BaseTools: small cleanup
BaseTools/Source/Python/AutoGen/AutoGen.py| 51 ++--
BaseTools/Source/Python/Com
just deleting else: then pass as they have no effect.
Cc: Liming Gao
Cc: Yonghong Zhu
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey
---
BaseTools/Source/Python/AutoGen/AutoGen.py | 15 ---
1 file changed, 15 deletions(-)
diff --git a/BaseTools
make it easy to import and use by others
Cc: Liming Gao
Cc: Yonghong Zhu
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey
---
BaseTools/Source/Python/Common/Expression.py | 4 ++--
BaseTools/Source/Python/Common/RangeExpression.py | 5 ++---
2 files chan
This patch series is also available for review on the
following branch:
https://github.com/mdkinney/edk2/tree/Bug_801_DisplayUpdateProgressLib
Mike
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-
> boun...@lists.01.org] On Behalf Of Michael D Kinney
> Sent: Wednesday, April
Star,
Thanks for adding the comments
Reviewed-by: Michael D Kinney
Mike
> -Original Message-
> From: Yao, Jiewen
> Sent: Wednesday, April 4, 2018 1:13 AM
> To: Zeng, Star ; edk2-
> de...@lists.01.org
> Cc: Ni, Ruiyu ; Yi Li
> ; Dong, Eric
> ; Renhao Liang
> ; Gao, Liming
> ; Heyi Guo ;
https://bugzilla.tianocore.org/show_bug.cgi?id=801
Based on content from the following branch/commits:
https://github.com/Microsoft/MS_UEFI/tree/share/MsCapsuleSupport
Cc: Sean Brogan
Cc: David Wei
Cc: Mang Guo
Signed-off-by: Michael D Kinney
Contributed-under: TianoCore Contribution Agreemen
https://bugzilla.tianocore.org/show_bug.cgi?id=801
Based on content from the following branch/commits:
https://github.com/Microsoft/MS_UEFI/tree/share/MsCapsuleSupport
Add DisplayUpdateProgressLib instances for text consoles
and graphical consoles.
Cc: Sean Brogan
Cc: Star Zeng
Cc: Eric Dong
https://bugzilla.tianocore.org/show_bug.cgi?id=801
Add PerformFlashWriteWithProgress() to the PlatformFlashAccessLib.
This allows the platform to inform the user of progress when a
firmware storage device is being updated with a new firmware
image.
Cc: David Wei
Cc: Mang Guo
Signed-off-by: Mich
From: "Kinney, Michael D"
https://bugzilla.tianocore.org/show_bug.cgi?id=801
Use PlatformFlashWriteWithProgress() instead of PlatformFLashWrite()
so the user can be informed of the progress as a capsule is used
to update a firmware image in a firmware device.
Cc: Jiewen Yao
Signed-off-by: Mich
https://bugzilla.tianocore.org/show_bug.cgi?id=801
Add a new API to the PlatformFlashAccessLib that passes
in an optional Progress() function along with a start and
end percentage to call the Progress() function with.
If the Progress() function is not NULL, then it is the
Progress() function that
From: "Kinney, Michael D"
https://bugzilla.tianocore.org/show_bug.cgi?id=801
Based on content from the following branch/commits:
https://github.com/Microsoft/MS_UEFI/tree/share/MsCapsuleSupport
Cc: Sean Brogan
Cc: Kelly Steele
Signed-off-by: Michael D Kinney
Contributed-under: TianoCore Cont
https://bugzilla.tianocore.org/show_bug.cgi?id=801
Based on content from the following branch/commits:
https://github.com/Microsoft/MS_UEFI/tree/share/MsCapsuleSupport
Add the DisplayUpdateProgressLib class that is used
to inform the user of progress during updates of
firmware images in firmware
https://bugzilla.tianocore.org/show_bug.cgi?id=801
Add PerformFlashWriteWithProgress() to the PlatformFlashAccessLib.
This allows the platform to inform the user of progress when a
firmware storage device is being updated with a new firmware
image.
Cc: Kelly Steele
Signed-off-by: Michael D Kinne
From: "Kinney, Michael D"
https://bugzilla.tianocore.org/show_bug.cgi?id=801
Based on content from the following branch/commits:
https://github.com/Microsoft/MS_UEFI/tree/share/MsCapsuleSupport
* Change Update_Image_Progress() to UpdateImageProcess()
* Call DisplayUpdateProgressLib from UpdateI
https://bugzilla.tianocore.org/show_bug.cgi?id=801
Based on content from:
https://github.com/Microsoft/MS_UEFI/blob/share/MsCapsuleSupport/MsCapsuleUpdatePkg/Include/Library/DisplayUpdateProgressLib.h
https://github.com/Microsoft/MS_UEFI/tree/share/MsCapsuleSupport/MsCapsuleUpdatePkg/Library/Disp
Hello,
I am trying to update my build software to the current edk2-platforms layout
and am running into some issues with the final part of the build.
It seems that the output is being generated under
edk2/Build/Qdf_RBL/DEBUG_CLANG35/AARCH64/edk2-QDT-platforms-restricted/Silicon/QualcommD
On 04/04/18 10:56, Gao, Liming wrote:
> Laszlo:
> I have no other comments. The patch is good to me. Reviewed-by: Liming Gao
>
Thank you Liming! I also thank Mike for the initial idea with the labels
after the instructions, and for his v1 review.
Commit range aae02dccf5b0..d22c995a4814.
Lasz
InfClassObject will be deleted.
Cc: Liming Gao
Cc: Yonghong Zhu
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey
---
BaseTools/Source/Python/build/BuildReport.py | 16 +++-
1 file changed, 15 insertions(+), 1 deletion(-)
diff --git a/BaseTools/So
These files are not used by any tool:
BaseTools/Source/Python/Common/DecClassObject.py
BaseTools/Source/Python/Common/DscClassObject.py
BaseTools/Source/Python/Common/FdfClassObject.py
BaseTools/Source/Python/Common/InfClassObject.py
Cc: Liming Gao
Cc: Yonghong Zhu
Contributed-under: TianoCore C
Delete 4 files that we dont need (first copying the one dictionary we do need)
Jaben Carsey (2):
BaseTools: copy a dictionary from InfClassObject to BuildReport
BaseTools: Remove unneeded files
BaseTools/Source/Python/Common/DecClassObject.py | 553
BaseTools/Source/Python/Common/D
On 04/03/18 17:08, Gao, Liming wrote:
> Laszlo:
> Could you use one pack to scope all structure definitions?
I didn't do that originally because the affected structure definitions
are spread out over a larger part of the code, intermixed with enums,
#defines, and other structures, *and* it is not
Laszlo:
I have no other comments. The patch is good to me. Reviewed-by: Liming Gao
Thanks
Liming
>-Original Message-
>From: Laszlo Ersek [mailto:ler...@redhat.com]
>Sent: Tuesday, April 03, 2018 8:57 PM
>To: edk2-devel-01
>Cc: Kinney, Michael D ; Dong, Eric
>; Gao, Liming
>Subject: R
This debug message should be info instead of error. This patch is to
change the debug level to DEBUG_INFO.
DEBUG((DEBUG_ERROR, "checking FV0x%08x - 0x%x\n",
FvHeader, FvHeader->FvLength));// "Mark"
This comment is inaccurate. This patch is to remove it.
//
// Check section
//
This
Thanks.
Reviewed-by: jiewen@intel.com
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Star
> Zeng
> Sent: Wednesday, April 4, 2018 10:08 AM
> To: edk2-devel@lists.01.org
> Cc: Ni, Ruiyu ; Yi Li ; Dong,
> Eric
> ; Renhao Liang ; Gao, Limin
Good news.
Thanks,
Star
From: Rob Taglang [mailto:r...@taglang.io]
Sent: Wednesday, April 4, 2018 12:49 AM
To: Laszlo Ersek
Cc: Ni, Ruiyu ; edk2-devel@lists.01.org; Ming Huang
; Zeng, Star
Subject: Re: [edk2] OVMF UsbBulkTransfer returns EFI_OUT_OF_RESOURCES
Hello,
Thanks for you help, I got
38 matches
Mail list logo
