Re: [edk2] [edk2-platforms Patch V2 3/6] SynQuacer/PlatformFlashAccessLib: Add progress API

2018-04-11 Thread Kinney, Michael D
Ard, I agree. I mentioned it in the patch summary. I will add it to the commit log for each patch. Thanks, Mike > -Original Message- > From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > Sent: Wednesday, April 11, 2018 11:18 PM > To: Kinney, Michael D > Cc: edk2-devel@lists.01.

Re: [edk2] [PATCH v2 0/9] {Ovmf, Mde, Network, Crypto}Pkg: fixes+features for setting HTTPS cipher suites

2018-04-11 Thread Long, Qin
Hi, Laszlo, The updated patch series looks good to me. Reviewed-by: Long Qin Best Regards & Thanks, LONG, Qin -Original Message- From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Wednesday, April 11, 2018 6:43 PM To: edk2-devel@lists.01.org Cc: Ard Biesheuvel ; Gary Ching-Pang Lin

Re: [edk2] [PATCH 09/10] ArmVirtPkg/PlatformHasAcpiDtDxe: depend on gEfiVariableArchProtocolGuid

2018-04-11 Thread Ard Biesheuvel
On 12 April 2018 at 02:55, Laszlo Ersek wrote: > PlatformHasAcpiDtDxe consumes the DynamicHii PCD called > "gArmVirtTokenSpaceGuid.PcdForceNoAcpi". The PcdGetBool() library call > terminates in gRT->GetVariable(), in the MdeModulePkg/Universal/PCD/Dxe > driver. Put "gEfiVariableArchProtocolGuid" o

Re: [edk2] [edk2-platforms Patch V2 3/6] SynQuacer/PlatformFlashAccessLib: Add progress API

2018-04-11 Thread Ard Biesheuvel
On 12 April 2018 at 03:01, Kinney, Michael D wrote: > https://bugzilla.tianocore.org/show_bug.cgi?id=801 > > Add PerformFlashWriteWithProgress() to the PlatformFlashAccessLib. > This allows the platform to inform the user of progress when a > firmware storage device is being updated with a new fir

Re: [edk2] [patch 0/3] MdeModulePkg/UiApp: Signal event when enter/exit setup menu

2018-04-11 Thread Bi, Dandan
Good suggestion. Thanks Star. I will cover them in V2 patches. Thanks, Dandan -Original Message- From: Zeng, Star Sent: Thursday, April 12, 2018 2:03 PM To: Bi, Dandan ; Kinney, Michael D ; edk2-devel@lists.01.org Cc: Dong, Eric ; Gao, Liming ; Zeng, Star Subject: RE: [edk2] [patch 0/

Re: [edk2] [patch 0/3] MdeModulePkg/UiApp: Signal event when enter/exit setup menu

2018-04-11 Thread Zeng, Star
If the cases can be listed completely, then it will be better to also add them in the comments for the two GUIDs, then consumer can easily know them. Thanks, Star -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Bi, Dandan Sent: Thursday, April 1

Re: [edk2] [PATCH 0/2] add sanity check for SetMemoryAttributes

2018-04-11 Thread Zeng, Star
Reviewed-by: Star Zeng -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Jian J Wang Sent: Wednesday, April 11, 2018 4:39 PM To: edk2-devel@lists.01.org Subject: [edk2] [PATCH 0/2] add sanity check for SetMemoryAttributes Heap Guard feature needs

Re: [edk2] [PATCH v2] MdeModulePkg/PiSmmIpl: fix non-executable SMM RAM

2018-04-11 Thread Wang, Jian J
Right, I checked the GCD code. Capabilities has only effect with "set" attributes. Regards, Jian > -Original Message- > From: Zeng, Star > Sent: Thursday, April 12, 2018 1:38 PM > To: Wang, Jian J ; edk2-devel@lists.01.org > Cc: Dong, Eric ; Yao, Jiewen ; Ni, > Ruiyu ; Kinney, Michael D

Re: [edk2] [PATCH v2] MdeModulePkg/PiSmmIpl: fix non-executable SMM RAM

2018-04-11 Thread Zeng, Star
Has no need to set paging capability as the code is going to clear paging attribute. With that refined, Reviewed-by: Star Zeng . Thanks, Star -Original Message- From: Wang, Jian J Sent: Thursday, April 12, 2018 12:58 PM To: edk2-devel@lists.01.org Cc: Zeng, Star ; Dong, Eric ; Yao, J

Re: [edk2] [patch 0/3] MdeModulePkg/UiApp: Signal event when enter/exit setup menu

2018-04-11 Thread Tim Lewis
If we start to see UEFI drivers that are using this, then it is a spec issue, because it means that systems which do not implement the event will not function correctly. Tim -Original Message- From: edk2-devel On Behalf Of Bi, Dandan Sent: Wednesday, April 11, 2018 9:53 PM To: Tim Lewis

[edk2] [PATCH v2] MdeModulePkg/PiSmmIpl: fix non-executable SMM RAM

2018-04-11 Thread Jian J Wang
> v2 changes: >a. Remove redundant code and fill-up potential logic hole >b. Code clean-up >c. Fix error in commit log This patch fixes an issue introduced by commit 5b91bf82c67b586b9588cbe4bbffa1588f6b5926 and 0c9f2cb10b7ddec56a3440e77219fd3ab1725e5c This issue will only happe

Re: [edk2] [patch 0/3] MdeModulePkg/UiApp: Signal event when enter/exit setup menu

2018-04-11 Thread Bi, Dandan
There is no need to update UEFI spec, just implementation related. It has no impact to the modules which do not care these two events. Thanks, Dandan -Original Message- From: Tim Lewis [mailto:tim.le...@insyde.com] Sent: Thursday, April 12, 2018 11:49 AM To: Bi, Dandan ; Kinney, Michael

Re: [edk2] [patch 0/3] MdeModulePkg/UiApp: Signal event when enter/exit setup menu

2018-04-11 Thread Tim Lewis
This is starting to sound like something that requires a UEFI spec update. Tim -Original Message- From: edk2-devel On Behalf Of Bi, Dandan Sent: Wednesday, April 11, 2018 8:47 PM To: Kinney, Michael D ; edk2-devel@lists.01.org Cc: Bi, Dandan ; Dong, Eric ; Gao, Liming Subject: Re: [edk2]

Re: [edk2] [patch 0/3] MdeModulePkg/UiApp: Signal event when enter/exit setup menu

2018-04-11 Thread Bi, Dandan
Hi all, All setup menu enter/exit cases includes: a. UiApp entry point is called and then setup menu is shown (enter setup menu) b. User select Continue menu in setup menu to exit. (exit setup menu) c. User select Reset menu in setup

Re: [edk2] [patch 0/3] MdeModulePkg/UiApp: Signal event when enter/exit setup menu

2018-04-11 Thread Bi, Dandan
Hi Mike, We can't move the enter/exit event signaling into the FormBrowwer SendForm() function. Because we can't decide whether enter/exit setup through SendForm() is called or not. Some examples: 1. SendForm() is not called when exit setup menu and re-enter setup menu. Such as, SendForm() i

Re: [edk2] [PATCH] CryptoPkg/OpensslLib: Update OpenSSL version to 1.1.0h

2018-04-11 Thread Long, Qin
Hi, Laszlo, You are right. "--remote" is really incorrect here. And thanks you so much to point out this. Best Regards & Thanks, LONG, Qin -Original Message- From: Long, Qin Sent: Wednesday, April 11, 2018 4:39 PM To: 'Laszlo Ersek' ; Ye, Ting Cc: edk2-devel@lists.01.org Subject: RE:

[edk2] [PATCH v2 2/2] CryptoPkg/OpensslLib: Update OpenSSL version to 1.1.0h

2018-04-11 Thread Long Qin
(https://bugzilla.tianocore.org/show_bug.cgi?id=927) (V2 Update: Removing the wrong "--remote" option from git submodule update command in this commit message. Thanks Leszlo's clarification to correct this) Update OpenSSL version to 1.1.0h release (27-Mar-2018) to include the fix for

[edk2] [PATCH v2 1/2] CryptoPkg/OpensslLib: Fix the documentation about submodule update

2018-04-11 Thread Long Qin
This patch is to drop "--remote" option from the original suggested submodule update command ("$ git submodule update --recursive --remote") in HOWTO document. "--remote" option will integrate changes from the upstream subproject with the submodules's "current HEAD", instead of using the edk2 supe

[edk2] [PATCH v2 0/2] Update OpenSSL version to 1.1.0h

2018-04-11 Thread Long Qin
Updating the supported OpenSSL version to 1.1.0h release. Additional patch is to address / fix one HOWTO documentation issue about submodule update command which used the wrong "--remote" option. (Thanks Laszlo's catch). Long Qin (2): CryptoPkg/OpensslLib: Fix the documentation about submodule u

[edk2] VT-d : VER_REG register question

2018-04-11 Thread Tiger Liu(BJ-RD)
Hi, Jiewen: I have a question about VER_REG register's content. (VT-d spec) Does current Intel chipset support VT-d spec 2.4 ? It seems VER_REG always display 1.0 , why? Thanks Best wishes, ? ? CONFIDENTIAL NOTE: This email contains confi

Re: [edk2] [Patch V2 1/9] MdeModulePkg: Add DisplayUpdateProgressLib class

2018-04-11 Thread Zeng, Star
Is it more flexible (may be for further extension) to use PCD instead of protocol for the ProgressBarForegroundColor and WatchdogSeconds policies? Thanks, Star -Original Message- From: Kinney, Michael D Sent: Thursday, April 12, 2018 8:48 AM To: edk2-devel@lists.01.org Cc: Kinney, Micha

[edk2] [Patch][edk2-platforms/devel-MinnowBoard3-UDK2017] Change BIOS Version.

2018-04-11 Thread zwei4
Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: David Wei --- Platform/BroxtonPlatformPkg/BiosId.env | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Platform/BroxtonPlatformPkg/BiosId.env b/Platform/BroxtonPlatformPkg/BiosId.env index d7e8aa6841..350fa

Re: [edk2] [Patch V2 7/9] Vlv2TbltDevicePkg/PlatformFlashAccessLib: Add progress API

2018-04-11 Thread Wei, David
Reviewed-by: David Wei Thanks, David Wei Intel SSG/STO/UEFI BIOS -Original Message- From: Kinney, Michael D Sent: Thursday, April 12, 2018 8:48 AM To: edk2-devel@lists.01.org Cc: Kinney, Michael D ; Wei, David ; Guo, Mang Subject: [Patch V2 7/9] V

Re: [edk2] [patch] MdeModulePkg/FPDT: Add error message for unsupported case

2018-04-11 Thread Gao, Liming
Reviewed-by: Liming Gao > -Original Message- > From: Bi, Dandan > Sent: Wednesday, April 11, 2018 9:27 AM > To: edk2-devel@lists.01.org > Cc: Gao, Liming > Subject: [patch] MdeModulePkg/FPDT: Add error message for unsupported case > > We have updated performance infrastructure in previo

Re: [edk2] [Patch V2 3/9] Vlv2Tbl2DevicePkg: Add DisplayUpdateProgressLib mapping

2018-04-11 Thread Wei, David
Reviewed-by: David Wei Thanks, David Wei Intel SSG/STO/UEFI BIOS -Original Message- From: Kinney, Michael D Sent: Thursday, April 12, 2018 8:48 AM To: edk2-devel@lists.01.org Cc: Kinney, Michael D ; Sean Brogan ; Wei, David ; Guo, Mang Subject: [Pa

Re: [edk2] [patch 0/3] MdeModulePkg/UiApp: Signal event when enter/exit setup menu

2018-04-11 Thread Kinney, Michael D
Dandan Bi, Is it possible to move the enter/exit event signaling into the FormBrowwer SendForm() function? The current patch set adds these signal calls in all the places that SendForm() is called and if one of these is missed, a notification will be missed. Mike > -Original Message- >

[edk2] [patch 1/3] MdeModulePkg/UiApp: Signal event when enter/exit setup menu

2018-04-11 Thread Dandan Bi
These changes are to support notify callbacks when enter/exit setup menu, since some driver may need to hook setup enter/exit points to do something. We will signal setup enter/exit events for all setup menu enter/exit cases.Then the module which pay attention to these events can execute the callb

[edk2] [patch 3/3] MdeModulePkg/BMUiLib: Signal event when enter/exit setup menu

2018-04-11 Thread Dandan Bi
These changes are to support notify callbacks when enter/exit setup menu, since some driver may need to hook setup enter/exit points to do something. We will signal setup enter/exit events for all setup menu enter/exit cases.Then the module which pay attention to these events can execute the callb

[edk2] [patch 2/3] MdeModulePkg/BMMUiLib: Signal event when enter/exit setup menu

2018-04-11 Thread Dandan Bi
These changes are to support notify callbacks when enter/exit setup menu, since some driver may need to hook setup enter/exit points to do something. We will signal setup enter/exit events for all setup menu enter/exit cases.Then the module which pay attention to these events can execute the callb

[edk2] [patch 0/3] MdeModulePkg/UiApp: Signal event when enter/exit setup menu

2018-04-11 Thread Dandan Bi
These changes are to support notify callbacks when enter/exit setup menu, since some driver may need to hook setup enter/exit points to do something. We will signal setup enter/exit events for all setup menu enter/exit cases.Then the module which pay attention to these events can execute the callb

Re: [edk2] [Patch V2 0/9] Add DisplayUpdateProgressLib for capsules

2018-04-11 Thread Kinney, Michael D
I have also posted a branch for review. https://github.com/mdkinney/edk2/tree/Bug_801_DisplayUpdateProgressLib_V2 Mike > -Original Message- > From: Kinney, Michael D > Sent: Wednesday, April 11, 2018 5:48 PM > To: edk2-devel@lists.01.org > Cc: Sean Brogan ; Zeng, Star > ; Dong, Eric ;

[edk2] [edk2-platforms Patch V2 4/6] AMD/OverdriveBoard: Add DisplayUpdateProgressLib mapping

2018-04-11 Thread Kinney, Michael D
https://bugzilla.tianocore.org/show_bug.cgi?id=801 Based on content from the following branch/commits: https://github.com/Microsoft/MS_UEFI/tree/share/MsCapsuleSupport Cc: Ard Biesheuvel Cc: Leif Lindholm Signed-off-by: Michael D Kinney Contributed-under: TianoCore Contribution Agreement 1.1 -

[edk2] [edk2-platforms Patch V2 2/6] Hisilicon/PlatformFlashAccessLib: Add progress API

2018-04-11 Thread Kinney, Michael D
https://bugzilla.tianocore.org/show_bug.cgi?id=801 Add PerformFlashWriteWithProgress() to the PlatformFlashAccessLib. This allows the platform to inform the user of progress when a firmware storage device is being updated with a new firmware image. Cc: Ard Biesheuvel Cc: Leif Lindholm Signed-of

[edk2] [edk2-platforms Patch V2 1/6] Styx/PlatformFlashAccessLib: Add progress API

2018-04-11 Thread Kinney, Michael D
https://bugzilla.tianocore.org/show_bug.cgi?id=801 Add PerformFlashWriteWithProgress() to the PlatformFlashAccessLib. This allows the platform to inform the user of progress when a firmware storage device is being updated with a new firmware image. Cc: Ard Biesheuvel Cc: Leif Lindholm Signed-of

[edk2] [edk2-platforms Patch V2 5/6] Socionext/DeveloperBox: Add DisplayUpdateProgressLib mapping

2018-04-11 Thread Kinney, Michael D
https://bugzilla.tianocore.org/show_bug.cgi?id=801 Based on content from the following branch/commits: https://github.com/Microsoft/MS_UEFI/tree/share/MsCapsuleSupport Cc: Ard Biesheuvel Cc: Leif Lindholm Signed-off-by: Michael D Kinney Contributed-under: TianoCore Contribution Agreement 1.1 -

[edk2] [edk2-platforms Patch V2 6/6] Socionext/SynQuacerEvalBoard: Add DisplayUpdateProgressLib mapping

2018-04-11 Thread Kinney, Michael D
https://bugzilla.tianocore.org/show_bug.cgi?id=801 Based on content from the following branch/commits: https://github.com/Microsoft/MS_UEFI/tree/share/MsCapsuleSupport Cc: Ard Biesheuvel Cc: Leif Lindholm Signed-off-by: Michael D Kinney Contributed-under: TianoCore Contribution Agreement 1.1 -

[edk2] [edk2-platforms Patch V2 0/6] Add DisplayUpdateProgressLib for capsules

2018-04-11 Thread Kinney, Michael D
https://bugzilla.tianocore.org/show_bug.cgi?id=801 Based on content from the following branch/commits: https://github.com/Microsoft/MS_UEFI/tree/share/MsCapsuleSupport * Add DisplayUpdateProgressLib mappings for platforms that use the DxeCapsuleLibFmp. * Add the PerformFlashWriteWithProgress()

[edk2] [edk2-platforms Patch V2 3/6] SynQuacer/PlatformFlashAccessLib: Add progress API

2018-04-11 Thread Kinney, Michael D
https://bugzilla.tianocore.org/show_bug.cgi?id=801 Add PerformFlashWriteWithProgress() to the PlatformFlashAccessLib. This allows the platform to inform the user of progress when a firmware storage device is being updated with a new firmware image. Cc: Ard Biesheuvel Cc: Leif Lindholm Signed-of

Re: [edk2] [PATCH] MdeModulePkg/PiSmmIpl: fix non-executable SMM RAM

2018-04-11 Thread Wang, Jian J
Yeah, you're right. I'll update the log text. Thanks for catching it. Regards, Jian > -Original Message- > From: Zeng, Star > Sent: Wednesday, April 11, 2018 4:00 PM > To: Wang, Jian J ; edk2-devel@lists.01.org > Cc: Dong, Eric ; Yao, Jiewen ; Ni, > Ruiyu ; Kinney, Michael D ; > Zeng, Sta

[edk2] [PATCH 02/10] ArmPkg/ArmGicDxe: annotate protocol usage in "ArmGicDxe.inf"

2018-04-11 Thread Laszlo Ersek
"ArmGicDxe.inf" currently does not document how the protocols in the [Protocols] section are used. Such comments help us analyze behavior, so let's add them now. - gHardwareInterruptProtocolGuid and gHardwareInterrupt2ProtocolGuid are always produced on the InterruptDxeInitialize() -> (GicV2DxeI

[edk2] [PATCH 05/10] ArmPlatformPkg/NorFlashDxe: initialize varstore headers eagerly

2018-04-11 Thread Laszlo Ersek
The lazy initialization of the varstore FVB makes no longer sense at this point: - "mNorFlashInstanceTemplate.Initialize" is NULL; - in NorFlashCreateInstance(), we only set Instance->Initialize to non-NULL -- namely NorFlashFvbInitialize() -- if the FVB stands for the variable store (see "Co

[edk2] [PATCH 04/10] EmbeddedPkg: introduce NvVarStoreFormattedLib

2018-04-11 Thread Laszlo Ersek
Some platforms don't format a variable store template at build time; instead they format the non-volatile varstore flash chip during boot, dynamically. Introduce NvVarStoreFormattedLib to enable such platforms to delay the "variable read" service drivers until the platform specific module(s) report

[edk2] [PATCH 09/10] ArmVirtPkg/PlatformHasAcpiDtDxe: depend on gEfiVariableArchProtocolGuid

2018-04-11 Thread Laszlo Ersek
PlatformHasAcpiDtDxe consumes the DynamicHii PCD called "gArmVirtTokenSpaceGuid.PcdForceNoAcpi". The PcdGetBool() library call terminates in gRT->GetVariable(), in the MdeModulePkg/Universal/PCD/Dxe driver. Put "gEfiVariableArchProtocolGuid" on PlatformHasAcpiDtDxe's DEPEX so that we not attempt th

[edk2] [PATCH 03/10] ArmPkg/CpuDxe: order CpuDxe after ArmGicDxe via protocol depex

2018-04-11 Thread Laszlo Ersek
Commit 61a7b0ec634f ("ArmPkg/Gic: force GIC driver to run before CPU arch protocol driver", 2018-02-06) explains why CpuDxe should be dispatched after ArmGicDxe. To implement the ordering, we should use a regular protocol depex rather than the less flexible AFTER opcode. ArmGicDxe installs gHardwa

[edk2] [PATCH 07/10] ArmPlatformPkg/NorFlashDxe: depend on gEfiCpuArchProtocolGuid

2018-04-11 Thread Laszlo Ersek
NorFlashFvbInitialize() calls gDS->SetMemorySpaceAttributes() to mark the varstore flash region as uncached. This DXE service depends on the CPU Architectural protocol, and the DXE core is allowed to return EFI_NOT_AVAILABLE_YET if it hasn't dispatched ArmPkg/Drivers/CpuDxe earlier. Make the depend

[edk2] [PATCH 08/10] ArmPlatformPkg/PL031RealTimeClockLib: depend on gEfiCpuArchProtocolGuid

2018-04-11 Thread Laszlo Ersek
The RealTimeClockLib class is declared under EmbeddedPkg, so that platforms can provide the internals for the EmbeddedPkg/RealTimeClockRuntimeDxe driver. In turn the driver produces the Real Time Clock Arch Protocol, without which UEFI drivers cannot be dispatched. The PL031RealTimeClockLib instan

[edk2] [PATCH 06/10] ArmPlatformPkg/NorFlashDxe: cue the variable driver with NvVarStoreFormatted

2018-04-11 Thread Laszlo Ersek
The BEFORE depex opcode that we currently use to force ourselves in front of the variable driver cannot be combined with other depex opcodes. Replace the depex with TRUE, and signal NvVarStoreFormattedLib through the installation of "gEdkiiNvVarStoreFormattedGuid". Platforms that rely on NorFlashD

[edk2] [PATCH 10/10] ArmVirtPkg/ArmVirtQemu: hook NvVarStoreFormattedLib into VariableRuntimeDxe

2018-04-11 Thread Laszlo Ersek
In spite of both ArmVirtQemu and ArmVirtQemuKernel formatting the variable store template at build time, link NvVarStoreFormattedLib into VariableRuntimeDxe via NULL class resolution on both platforms. This lets us test the depexes implemented in the previous patches. Cc: Ard Biesheuvel Cc: Leif

[edk2] [PATCH 01/10] Omap35xxPkg/InterruptDxe: replace CPU Arch Protocol depex with notify

2018-04-11 Thread Laszlo Ersek
In a later patch, we'll modify the depex of "ArmPkg/Drivers/CpuDxe/CpuDxe.inf" (currently "AFTER gArmGicDxeFileGuid") to "gHardwareInterruptProtocolGuid OR gHardwareInterrupt2ProtocolGuid". Considering platforms that include "ArmPkg/Drivers/CpuDxe/CpuDxe.inf", there are two classes: (1) The platf

[edk2] [PATCH 00/10] ArmPkg, ArmPlatformPkg, ArmVirtPkg, EmbeddedPkg, Omap35xxPkg: depex fixes

2018-04-11 Thread Laszlo Ersek
Repo: https://github.com/lersek/edk2.git Branch: depex_fixes ArmVirtQemu boots again, it just took a few more patches than I expected :) Some of these patches will have to be ported to edk2-platforms, I think. Cc: Ard Biesheuvel Cc: Leif Lindholm Cc: Steve Capper Cc: Supreeth Venkatesh Th

[edk2] [Patch V2 9/9] SignedCapsulePkg/SystemFirmwareUpdateDxe: Use progress API

2018-04-11 Thread Kinney, Michael D
https://bugzilla.tianocore.org/show_bug.cgi?id=801 Use PlatformFlashWriteWithProgress() instead of PlatformFLashWrite() so the user can be informed of the progress as a capsule is used to update a firmware image in a firmware device. Cc: Jiewen Yao Signed-off-by: Michael D Kinney Contributed-un

[edk2] [Patch V2 3/9] Vlv2Tbl2DevicePkg: Add DisplayUpdateProgressLib mapping

2018-04-11 Thread Kinney, Michael D
From: Michael D Kinney https://bugzilla.tianocore.org/show_bug.cgi?id=801 Based on content from the following branch/commits: https://github.com/Microsoft/MS_UEFI/tree/share/MsCapsuleSupport Cc: Sean Brogan Cc: David Wei Cc: Mang Guo Signed-off-by: Michael D Kinney Contributed-under: TianoC

[edk2] [Patch V2 6/9] SignedCapsulePkg/PlatformFlashAccessLib: Add progress API

2018-04-11 Thread Kinney, Michael D
From: Michael D Kinney https://bugzilla.tianocore.org/show_bug.cgi?id=801 Add a new API to the PlatformFlashAccessLib that passes in an optional Progress() function along with a start and end percentage to call the Progress() function with. If the Progress() function is not NULL, then it is the

[edk2] [Patch V2 4/9] QuarkPlatformPkg: Add DisplayUpdateProgressLib mapping

2018-04-11 Thread Kinney, Michael D
https://bugzilla.tianocore.org/show_bug.cgi?id=801 Based on content from the following branch/commits: https://github.com/Microsoft/MS_UEFI/tree/share/MsCapsuleSupport Cc: Sean Brogan Cc: Kelly Steele Signed-off-by: Michael D Kinney Contributed-under: TianoCore Contribution Agreement 1.1 ---

[edk2] [Patch V2 5/9] MdeModulePkg/DxeCapsuleLibFmp: Add progress bar support

2018-04-11 Thread Kinney, Michael D
https://bugzilla.tianocore.org/show_bug.cgi?id=801 Based on content from the following branch/commits: https://github.com/Microsoft/MS_UEFI/tree/share/MsCapsuleSupport * Change Update_Image_Progress() to UpdateImageProcess() * Call DisplayUpdateProgressLib from UpdateImageProgress(). * Split out

[edk2] [Patch V2 8/9] QuarkPlatformPkg/PlatformFlashAccessLib: Add progress API

2018-04-11 Thread Kinney, Michael D
From: Michael D Kinney https://bugzilla.tianocore.org/show_bug.cgi?id=801 Add PerformFlashWriteWithProgress() to the PlatformFlashAccessLib. This allows the platform to inform the user of progress when a firmware storage device is being updated with a new firmware image. Cc: Kelly Steele Signe

[edk2] [Patch V2 7/9] Vlv2TbltDevicePkg/PlatformFlashAccessLib: Add progress API

2018-04-11 Thread Kinney, Michael D
From: Michael D Kinney https://bugzilla.tianocore.org/show_bug.cgi?id=801 Add PerformFlashWriteWithProgress() to the PlatformFlashAccessLib. This allows the platform to inform the user of progress when a firmware storage device is being updated with a new firmware image. Cc: David Wei Cc: Mang

[edk2] [Patch V2 2/9] MdeModulePkg: Add DisplayUpdateProgressLib instances

2018-04-11 Thread Kinney, Michael D
From: Michael D Kinney https://bugzilla.tianocore.org/show_bug.cgi?id=801 Based on content from the following branch/commits: https://github.com/Microsoft/MS_UEFI/tree/share/MsCapsuleSupport Add DisplayUpdateProgressLib instances for text consoles and graphical consoles. Cc: Sean Brogan Cc: S

[edk2] [Patch V2 0/9] Add DisplayUpdateProgressLib for capsules

2018-04-11 Thread Kinney, Michael D
https://bugzilla.tianocore.org/show_bug.cgi?id=801 Based on content from: https://github.com/Microsoft/MS_UEFI/blob/share/MsCapsuleSupport/MsCapsuleUpdatePkg/Include/Library/DisplayUpdateProgressLib.h https://github.com/Microsoft/MS_UEFI/tree/share/MsCapsuleSupport/MsCapsuleUpdatePkg/Library/Disp

[edk2] [Patch V2 1/9] MdeModulePkg: Add DisplayUpdateProgressLib class

2018-04-11 Thread Kinney, Michael D
From: Michael D Kinney https://bugzilla.tianocore.org/show_bug.cgi?id=801 Based on content from the following branch/commits: https://github.com/Microsoft/MS_UEFI/tree/share/MsCapsuleSupport Add the DisplayUpdateProgressLib class that is used to inform the user of progress during updates of fir

Re: [edk2] [PATCH v1 4/4] BaseTools: merge towards minimum PCD MAX methods

2018-04-11 Thread Feng, Bob C
Reviewed-by: Feng, Bob C -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Jaben Sent: Thursday, April 12, 2018 7:08 AM To: edk2-devel@lists.01.org Cc: Feng, Bob ; Gao, Liming Subject: [edk2] [PATCH v1 4/4] BaseTools: merge towards minimum PCD MAX

[edk2] [PATCH v1 3/4] BaseTools: Remove un-needed list comprehension

2018-04-11 Thread Jaben
Cc: Liming Gao Cc: Yonghong Zhu Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jaben Carsey --- BaseTools/Source/Python/Common/DataType.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/BaseTools/Source/Python/Common/DataType.py b/BaseTools/Source/P

[edk2] [PATCH v1 2/4] BaseTools: replace 'UINT8', 'UINT16', 'UINT32', 'UINT64', 'VOID*' with shared constants.

2018-04-11 Thread Jaben
Cc: Liming Gao Cc: Yonghong Zhu Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jaben Carsey --- BaseTools/Source/Python/AutoGen/AutoGen.py | 26 +++--- BaseTools/Source/Python/AutoGen/GenC.py | 94 ++-- BaseTo

[edk2] [PATCH v1 0/4] BaseTools: refactoring (and one bug fix)

2018-04-11 Thread Jaben
refactor to reduce duplication remove a duplicate function name (I presume this branch never executes as it would have had exception) Jaben (4): BaseTools: remove duplicate function name BaseTools: replace 'UINT8','UINT16','UINT32','UINT64','VOID*' with shared constants. BaseTools: Remov

[edk2] [PATCH v1 1/4] BaseTools: remove duplicate function name

2018-04-11 Thread Jaben
Cc: Liming Gao Cc: Yonghong Zhu Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jaben Carsey --- BaseTools/Source/Python/Eot/FvImage.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/BaseTools/Source/Python/Eot/FvImage.py b/BaseTools/Source/Pytho

[edk2] [PATCH v1 4/4] BaseTools: merge towards minimum PCD MAX methods

2018-04-11 Thread Jaben
we have 5 different max val or max byte for PCDs. refactor and remove 2 methods. we need 3, as one computes for VOID* PCDs. Cc: Bob Feng Cc: Liming Gao Cc: Yonghong Zhu Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jaben Carsey --- BaseTools/Source/Python/Common/DataT

Re: [edk2] [PATCH v1 05/18] ArmPkg/ArmMmuLib: Add MMU library inf file suitable for use in S-EL0.

2018-04-11 Thread Achin Gupta
On Fri, Apr 06, 2018 at 03:42:10PM +0100, Supreeth Venkatesh wrote: > This patch adds the definitions, sources, packages and library classes > needed to compile and link MMU Library suitable for use in S-EL0. > > Currently, this is used only during the Standalone MM Core > initialization and hence

Re: [edk2] [PATCH v1 04/18] ArmPkg/ArmMmuLib: Add MMU Library suitable for use in S-EL0.

2018-04-11 Thread Achin Gupta
Hi Supreeth, On Fri, Apr 06, 2018 at 03:42:09PM +0100, Supreeth Venkatesh wrote: > The Standalone MM environment runs in S-EL0 in AArch64 on ARM Standard > Platforms. Privileged firmware e.g. ARM Trusted Firmware sets up its > architectural context including the initial translation tables for the

Re: [edk2] Boot failure for ArmVExpress-FVP-AArch64, CpuArch protocol does not appear to be registered

2018-04-11 Thread Steve Capper
On 11 April 2018 at 13:25, Laszlo Ersek wrote: > Hi Steve, Hi Laszlo, [...] > Summary: > (1) introduce a custom GUID for "NorFlashDxe has formatted the variable > store headers for the variable driver to read"; > (2) install the GUID in NorFlashDxe once it's done verifying and/or > form

Re: [edk2] Boot failure for ArmVExpress-FVP-AArch64, CpuArch protocol does not appear to be registered

2018-04-11 Thread Laszlo Ersek
On 04/11/18 18:10, Ard Biesheuvel wrote: > On 11 April 2018 at 17:34, Supreeth Venkatesh > wrote: >> Laszlo/Steve, >> >> I ran into the same problem on ArmVExpress-FVP-AArch64 while running >> management mode. >> I have fixed this problem in this patch by reordering driver load order here: >> htt

Re: [edk2] [edk2-platforms PATCH v1 3/3] VExpressPkg: Reorder driver load order for AARCH64 FVP.

2018-04-11 Thread Laszlo Ersek
On 04/06/18 16:46, Supreeth Venkatesh wrote: > ARM CPU driver inf file recently got updated to have a depedency > expression to load after GIC driver. > However, there are other Arm drivers like NorFlashDxe, MM Communication > drivers etc. which depends on ARM CPU driver for AddMemorySpace() and >

Re: [edk2] Boot failure for ArmVExpress-FVP-AArch64, CpuArch protocol does not appear to be registered

2018-04-11 Thread Laszlo Ersek
On 04/11/18 17:34, Supreeth Venkatesh wrote: > Laszlo/Steve, > > I ran into the same problem on ArmVExpress-FVP-AArch64 while running > management mode. > I have fixed this problem in this patch by reordering driver load > order here: > https://lists.01.org/pipermail/edk2-devel/2018-April/023550.ht

Re: [edk2] Boot failure for ArmVExpress-FVP-AArch64, CpuArch protocol does not appear to be registered

2018-04-11 Thread Ard Biesheuvel
On 11 April 2018 at 17:34, Supreeth Venkatesh wrote: > Laszlo/Steve, > > I ran into the same problem on ArmVExpress-FVP-AArch64 while running > management mode. > I have fixed this problem in this patch by reordering driver load order here: > https://lists.01.org/pipermail/edk2-devel/2018-April/0

Re: [edk2] Boot failure for ArmVExpress-FVP-AArch64, CpuArch protocol does not appear to be registered

2018-04-11 Thread Supreeth Venkatesh
Laszlo/Steve, I ran into the same problem on ArmVExpress-FVP-AArch64 while running management mode. I have fixed this problem in this patch by reordering driver load order here: https://lists.01.org/pipermail/edk2-devel/2018-April/023550.html Not sure whether Leif/Ard/Laszlo agree with this. Th

Re: [edk2] [PATCH v1 01/18] ArmPkg: Add PCDs needed for MM communication driver.

2018-04-11 Thread Achin Gupta
On Fri, Apr 06, 2018 at 03:42:06PM +0100, Supreeth Venkatesh wrote: > This patch defines PCDs to describe the base address and size of > communication buffer between normal world (uefi) and standalone MM > environment in the secure world. > > Contributed-under: TianoCore Contribution Agreement 1.1

Re: [edk2] [PATCH v1 03/18] ArmPkg/Include: Add MM interface SVC return codes.

2018-04-11 Thread Achin Gupta
Hi Supreeth, On Fri, Apr 06, 2018 at 03:42:08PM +0100, Supreeth Venkatesh wrote: > This patch adds the Management Mode(MM) SVC return codes as specified in > http://infocenter.arm.com/help/topic/com.arm.doc.den0060a/DEN0060A_ARM_MM_Interface_Specification.pdf. > Also, corrects SVC ID for retrievin

Re: [edk2] [PATCH 1/3] BaseTools: Correct GenSec argument dummy free memory issue

2018-04-11 Thread Carsey, Jaben
I have been wondering about that <> thing myself. Thanks! > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Laszlo Ersek > Sent: Wednesday, April 11, 2018 2:02 AM > To: Feng, YunhuaX ; edk2-devel@lists.01.org > Cc: Gao, Liming > Subject: Re:

Re: [edk2] [PATCH v1 3/3] BaseTools: use existing contrants to replace raw strings in python code.

2018-04-11 Thread Carsey, Jaben
I would like to replace all use of string constants with the ones in DataType. I just didn't get to the rest. > -Original Message- > From: Zhu, Yonghong > Sent: Tuesday, April 10, 2018 6:08 PM > To: Carsey, Jaben ; edk2-devel@lists.01.org > Cc: Gao, Liming ; Zhu, Yonghong > > Subject: R

Re: [edk2] [PATCH v1 02/18] ArmPkg/Drivers: Add EFI_MM_COMMUNICATION_PROTOCOL DXE driver.

2018-04-11 Thread Achin Gupta
Hi Supreeth, CIL. On Fri, Apr 06, 2018 at 03:42:07PM +0100, Supreeth Venkatesh wrote: > PI v1.5 Specification Volume 4 defines Management Mode Core Interface > and defines EFI_MM_COMMUNICATION_PROTOCOL. This protocol provides a > means of communicating between drivers outside of MM and MMI > hand

Re: [edk2] Boot failure for ArmVExpress-FVP-AArch64, CpuArch protocol does not appear to be registered

2018-04-11 Thread Laszlo Ersek
Hi Steve, On 04/11/18 12:30, Steve Capper wrote: > Hello, > I am trying to debug a boot problem for a recent build of EDK2 in an > Arm FVP model. > > I built EDK2 from the following branches: > Edk2: a146c532c754106431b063fec9985a838afd82be > Edk2-platforms: e74f53df8b18e4aed0c9df0942ce0c30f78a68e

[edk2] [PATCH v2 7/9] CryptoPkg/TlsLib: pre-compute OpensslCipherLength in TlsCipherMappingTable

2018-04-11 Thread Laszlo Ersek
In the next patches, we'll need the lengths of the TLS_CIPHER_MAPPING.OpensslCipher string fields. These lengths can be computed at build time; add the new field "OpensslCipherLength", and introduce the MAP() macro for populating it. While at it, add some horizontal whitespace to "TlsCipherMapping

[edk2] [PATCH v2 6/9] CryptoPkg/TlsLib: use binary search in the TlsGetCipherMapping() function

2018-04-11 Thread Laszlo Ersek
Improve the performance of the TlsGetCipherMapping() function by adopting the binary search from DhcpFindOptionFormat() [MdeModulePkg/Universal/Network/Dhcp4Dxe/Dhcp4Option.c]. Cc: Jiaxin Wu Cc: Qin Long Cc: Siyuan Fu Cc: Ting Ye Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=915 Contribu

[edk2] [PATCH v2 8/9] CryptoPkg/TlsLib: sanitize lib classes in internal header and INF

2018-04-11 Thread Laszlo Ersek
"InternalTlsLib.h" includes "BaseCryptLib.h", but the lib class is not listed in the INF file. The INF file lists a good number of lib classes, but none of the lib class headers are included by "InternalTlsLib.h". Synchronize & sort both lists, while removing those library classes that aren't act

[edk2] [PATCH v2 9/9] CryptoPkg/TlsLib: rewrite TlsSetCipherList()

2018-04-11 Thread Laszlo Ersek
Rewrite the TlsSetCipherList() function in order to fix the following issues: - Any cipher identifier in CipherId that is not recognized by TlsGetCipherMapping() will cause the function to return EFI_UNSUPPORTED. This is a problem because CipherId is an ordered preference list, and a caller

[edk2] [PATCH v2 2/9] MdePkg/Include/Protocol/Tls.h: pack structures from the TLS RFC

2018-04-11 Thread Laszlo Ersek
The structures defined in RFC 5246 are not to have any padding between fields or at the end; use the "pack" pragma as necessary. Cc: Jiaxin Wu Cc: Liming Gao Cc: Michael D Kinney Cc: Siyuan Fu Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=915 Contributed-under: TianoCore Contribution Agr

[edk2] [PATCH v2 3/9] NetworkPkg/TlsDxe: verify DataSize for EfiTlsCipherList

2018-04-11 Thread Laszlo Ersek
TlsSetSessionData() shouldn't just ignore an incomplete EFI_TLS_CIPHER element at the end of "Data": - Generally speaking, malformed input for a security API is best rejected explicitly. - Specifically speaking, the size of EFI_TLS_CIPHER is 2 bytes. If DataSize is 1 on input, then the initia

[edk2] [PATCH v2 5/9] CryptoPkg/TlsLib: replace TlsGetCipherString() with TlsGetCipherMapping()

2018-04-11 Thread Laszlo Ersek
In the following patches it will be useful if the IANA CipherId lookup returns a pointer to the whole matching IANA-to-OpenSSL mapping structure, not just the OpenSSL cipher suite name. Rename TLS_CIPHER_PAIR and TlsGetCipherString() to TLS_CIPHER_MAPPING and TlsGetCipherMapping() respectively, and

[edk2] [PATCH v2 0/9] {Ovmf, Mde, Network, Crypto}Pkg: fixes+features for setting HTTPS cipher suites

2018-04-11 Thread Laszlo Ersek
Repo: https://github.com/lersek/edk2.git Branch: tls_ciphers_v2 This is version 2 of the series posted earlier at 20180403145149.8925-1-lersek@redhat.com">http://mid.mail-archive.com/20180403145149.8925-1-lersek@redhat.com https://lists.01.org/pipermail/edk2-devel/2018-April/023402.html Ch

[edk2] [PATCH v2 4/9] NetworkPkg/TlsDxe: clean up byte order conversion for EfiTlsCipherList

2018-04-11 Thread Laszlo Ersek
Fix the following style issues: - "Data" is accessed through a pointer to UINT16 rather than to a pointer to EFI_TLS_CIPHER. While technically correct, UINT16 is harder to interpret against the UEFI spec. - Array subscripting is written with weird *(Pointer + Offset) expressions, rather tha

[edk2] [PATCH v2 1/9] OvmfPkg/TlsAuthConfigLib: configure trusted cipher suites for HTTPS boot

2018-04-11 Thread Laszlo Ersek
Read the list of trusted cipher suites from fw_cfg and to store it to EFI_TLS_CA_CERTIFICATE_VARIABLE. The fw_cfg file is formatted by the "update-crypto-policies" utility on the host side, so that the host settings take effect in guest HTTPS boot as well. QEMU forwards the file intact to the firm

[edk2] Boot failure for ArmVExpress-FVP-AArch64, CpuArch protocol does not appear to be registered

2018-04-11 Thread Steve Capper
Hello, I am trying to debug a boot problem for a recent build of EDK2 in an Arm FVP model. I built EDK2 from the following branches: Edk2: a146c532c754106431b063fec9985a838afd82be Edk2-platforms: e74f53df8b18e4aed0c9df0942ce0c30f78a68e2 Toolchain: Debian Stretch latest (though I have also tried L

Re: [edk2] [PATCH 1/3] BaseTools: Correct GenSec argument dummy free memory issue

2018-04-11 Thread Laszlo Ersek
On 04/11/18 09:57, Laszlo Ersek wrote: > Hello Yunhua, > > On 04/10/18 03:09, Feng, YunhuaX wrote: >> Free DummyFileBuffer and set DummyFileBuffer to NULL. >> >> Cc: Liming Gao >> Cc: Yonghong Zhu >> Contributed-under: TianoCore Contribution Agreement 1.1 >> >> Signed-off-by: Yunhua Feng >> ---

[edk2] [PATCH 2/2] MdeModulePkg/SmmCore: add sanity check for SetMemoryAttributes

2018-04-11 Thread Jian J Wang
Heap Guard feature needs enough memory and paging to work. Otherwise calling SetMemoryAttributes to change page attribute will fail. This patch add necessary check of result of calling SetMemoryAttributes. This can help users to debug their problem in enabling this feature. Cc: Star Zeng Cc: Eric

Re: [edk2] [PATCH] CryptoPkg/OpensslLib: Update OpenSSL version to 1.1.0h

2018-04-11 Thread Long, Qin
Thank you so much about this clarification, Laszlo. The submodule maintenance (commands for update / sync) looks a little confused to me. Let me check more locally before the V2. Best Regards & Thanks, LONG, Qin -Original Message- From: Laszlo Ersek [mailto:ler...@redhat.com] Sent:

[edk2] [PATCH 1/2] MdeModulePkg/DxeCore: add sanity check for SetMemoryAttributes

2018-04-11 Thread Jian J Wang
Heap Guard feature needs enough memory and paging to work. Otherwise calling SetMemoryAttributes to change page attribute will fail. This patch add necessary check of result of calling SetMemoryAttributes. This can help users to debug their problem in enabling this feature. Cc: Star Zeng Cc: Eric

[edk2] [PATCH 0/2] add sanity check for SetMemoryAttributes

2018-04-11 Thread Jian J Wang
Heap Guard feature needs enough memory and paging to work. Otherwise calling SetMemoryAttributes to change page attribute will fail. This patch add necessary check of result of calling SetMemoryAttributes. This can help users to debug their problem in enabling this feature. Jian J Wang (2): MdeM

Re: [edk2] [PATCH] CryptoPkg/OpensslLib: Update OpenSSL version to 1.1.0h

2018-04-11 Thread Laszlo Ersek
Hello Qin, On 04/11/18 10:11, Long Qin wrote: > (https://bugzilla.tianocore.org/show_bug.cgi?id=927) > > Update OpenSSL version to 1.1.0h release (27-Mar-2018) to include the > fix for CVE-2018-0739 issue (Handling of crafted recursive ASN.1 > structures can cause a stack overflow and resulting d

[edk2] [PATCH] CryptoPkg/OpensslLib: Update OpenSSL version to 1.1.0h

2018-04-11 Thread Long Qin
(https://bugzilla.tianocore.org/show_bug.cgi?id=927) Update OpenSSL version to 1.1.0h release (27-Mar-2018) to include the fix for CVE-2018-0739 issue (Handling of crafted recursive ASN.1 structures can cause a stack overflow and resulting denial of service, Refer to https://www.openssl.org/news/s

Re: [edk2] [PATCH] MdeModulePkg/PiSmmIpl: fix non-executable SMM RAM

2018-04-11 Thread Zeng, Star
It should be exposed by 5b91bf82c67b586b9588cbe4bbffa1588f6b5926 + 0c9f2cb10b7ddec56a3440e77219fd3ab1725e5c. With this information updated in commit log, Reviewed-by: Star Zeng . Thanks, Star -Original Message- From: Wang, Jian J Sent: Wednesday, April 11, 2018 3:30 PM To: edk2-devel@l

Re: [edk2] [PATCH 1/3] BaseTools: Correct GenSec argument dummy free memory issue

2018-04-11 Thread Laszlo Ersek
Hello Yunhua, On 04/10/18 03:09, Feng, YunhuaX wrote: > Free DummyFileBuffer and set DummyFileBuffer to NULL. > > Cc: Liming Gao > Cc: Yonghong Zhu > Contributed-under: TianoCore Contribution Agreement 1.1 > > Signed-off-by: Yunhua Feng > --- > BaseTools/Source/C/GenSec/GenSec.c | 3 ++- > 1

  1   2   >