Ok. I will update the comments.
Thanks/Ray
> -Original Message-
> From: Zeng, Star
> Sent: Monday, June 4, 2018 2:30 PM
> To: Ni, Ruiyu ; edk2-devel@lists.01.org
> Cc: Zeng, Star
> Subject: RE: [PATCH 2/4] MdeModulePkg: Add AtaAtapiPolicy protocol
> definition
>
> I see below definition
Thanks/Ray
> -Original Message-
> From: Wu, Hao A
> Sent: Monday, June 4, 2018 2:45 PM
> To: Ni, Ruiyu ; edk2-devel@lists.01.org
> Cc: Chiu, Chasel
> Subject: RE: [PATCH 4/4] MdeModulePkg/Ata/AtaAtapiPassThru:
> Enable/disable DEVSLP per policy
>
> > -Original Message-
> > Fro
> -Original Message-
> From: Ni, Ruiyu
> Sent: Monday, June 04, 2018 2:37 PM
> To: Wu, Hao A; edk2-devel@lists.01.org
> Cc: Chiu, Chasel
> Subject: RE: [PATCH 4/4] MdeModulePkg/Ata/AtaAtapiPassThru:
> Enable/disable DEVSLP per policy
>
> Hao,
> Thanks for the comments.
> Reply in below.
>
With update, Reviewed-by: Star Zeng .
-Original Message-
From: Gao, Liming
Sent: Monday, June 4, 2018 2:39 PM
To: Zeng, Star ; edk2-devel@lists.01.org
Cc: Ni, Ruiyu
Subject: RE: [edk2] [Patch] MdeModulePkg BootManagerMenuApp: Update usage info
for BootLogo protocol
Good catch. I will u
Good catch. I will update the commit message.
>-Original Message-
>From: Zeng, Star
>Sent: Monday, June 04, 2018 2:37 PM
>To: Gao, Liming ; edk2-devel@lists.01.org
>Cc: Ni, Ruiyu ; Zeng, Star
>Subject: RE: [edk2] [Patch] MdeModulePkg BootManagerMenuApp: Update
>usage info for BootLogo pro
Hao,
Thanks for the comments.
Reply in below.
Thanks/Ray
> -Original Message-
> From: Wu, Hao A
> Sent: Monday, June 4, 2018 2:21 PM
> To: Ni, Ruiyu ; edk2-devel@lists.01.org
> Cc: Chiu, Chasel
> Subject: RE: [PATCH 4/4] MdeModulePkg/Ata/AtaAtapiPassThru:
> Enable/disable DEVSLP per poli
Liming,
Should " If it is installed " be " If it is not installed " in the commit
message?
Thanks,
Star
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Liming
Gao
Sent: Tuesday, May 29, 2018 1:54 PM
To: edk2-devel@lists.01.org
Cc: Ni, Ruiyu
Su
I see below definition for PuisEnable.
+ /// others: Since PUIS setting is non-volatile, platform can use other value
than 0/1 to keep hardware PUIS setting.
+ ///
+ UINT8 PuisEnable;
What will the code do for DeviceSleepEnable and AggressiveDeviceSleepEnable
when their value is other val
Hi Ray,
Some comments:
1. Please help to add the 'EFI_' prefix for the new definitions added in .h
files.
2. Do we need to handle the case when AhciEnableDevSlp() returns with an error?
3. Please help to adjust the debug level for the below line within function
AhciEnableDevSlp():
DEBUG (
Reviewed-by: Ruiyu Ni
Thanks/Ray
> -Original Message-
> From: Gao, Liming
> Sent: Tuesday, May 29, 2018 1:54 PM
> To: edk2-devel@lists.01.org
> Cc: Ni, Ruiyu
> Subject: [Patch] MdeModulePkg BootManagerMenuApp: Update usage info
> for BootLogo protocol
>
> BootLogo protocol is not alway
Because the DxeResetSystemLib calls gRT->ResetSystem(), make sure
the gRT->ResetSystem() implementation doesn't call into
DxeResetSystemLib to avoid chicken-egg issue.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ruiyu Ni
Cc: Star Zeng
Cc: Liming Gao
---
MdeModulePkg/
Current DxeResetSystemLib depends on UefiRuntimeLib because it calls
EfiResetSystem() API exposed by UefiRuntimeLib.
Due to the commit:
"MdePkg/UefiRuntimeLib: Do not allow to be linked by DXE driver"
which reverts UefiRuntimeLib to only support DXE_RUNTIME_DRIVER,
removing UefiRuntimeLib dependen
When UefiRuntimeLib links to a DXE driver, its constructor
still registers a Virtual Address Change event. The event callback
will get called when RT.SetVirtualAddressMap() is called from OS.
But when the driver is a DXE driver, the memory occupied by the
callback function might be zeroed or used b
v2:
Fix the comments in 2/3 to solve Laszlo's concern.
Change DxeResetSystemLib to disallow to be linked by runtime/smm drivers.
Ruiyu Ni (3):
MdePkg/UefiRuntimeLib: Do not allow to be linked by DXE driver
MdeModulePkg/DxeResetSystemLib: Avoid depending on UefiRuntimeLib
MdeModulePkg:
One minor comment below.
> -Original Message-
> From: Ni, Ruiyu
> Sent: Friday, June 01, 2018 1:39 PM
> To: edk2-devel@lists.01.org
> Cc: Chiu, Chasel; Wu, Hao A
> Subject: [PATCH 1/4] MdeModulePkg/AtaAtapiPassThru: Spin up Power up
> in Standby devices
>
> The patch adds support to certa
Changelog:
v8:
* Rebase for virtual keyboard driver.
v7:
* Fix memory leakage on DevicePath.
v6:
* Remove redundant definition -- "GRUB_FILE_NAME".
v5:
* Avoid to merge device path and grub's file path in driver.
Merge them directly in DSC file.
* Avoid duplicated code to create boot
Create 4 predefined boot options for HiKey. They're
"Boot from SD", "Grub", "Android Boot" and "Android Fastboot".
Cc: Laszlo Ersek
Cc: Leif Lindholm
Cc: Ard Biesheuvel
Acked-by: Laszlo Ersek
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Haojian Zhuang
---
Platform/H
Create 4 boot options on HiKey960 platform. They're "Boot from SD",
"Grub", "Android Boot" and "Android Fastboot".
Cc: Laszlo Ersek
Cc: Leif Lindholm
Cc: Ard Biesheuvel
Acked-by: Laszlo Ersek
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Haojian Zhuang
---
Platform/H
When using PEI phase, UEFI interprets 0x0 address
of boot FV as an error. In order to avoid it, shift
it to 0x1000 and put a hardcoded 'jump to 0x1000' at
offset 0x0. This patch is a preparation for using PEI
by Armada platforms.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-b
In order to support new API of the PlatformFlashAccessLib, which
passes and optional Progress() function, introduce new callback
for updating data in the SPI flash, that can utilize it.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Marcin Wojtas
---
Silicon/Marvell/Drive
PEI phase will allow to use more robust platform initialization,
with new features like the capsule support. Wire up all
dependencies for that purpose.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Marcin Wojtas
---
Platform/Marvell/Armada70x0Db/Armada70x0Db.fdf | 15 +++
Reviewed-by: Star Zeng
Pushed at 38c977c148e92e2af17c5d346d9b4b2e7a18680a.
Thanks,
Star
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ard
Biesheuvel
Sent: Friday, June 1, 2018 10:00 PM
To: Marcin Wojtas ; Zeng, Star ; Dong,
Eric
Cc: Tian, Fe
From: David Sniatkiwicz
This patch adds necessary code that allows to update
firmware on Armada7k8k platforms, using generic gRT->UpdateCapsule,
i.e.
* PlatformFlashAccessLib implementation to write data to SPI flash
* SystemFirmwareDescriptor for FMP protocol
* SystemFirmwareUpdateConfig t
Hi,
This is a second version of the Marvell Armada SoCs capsule support.
There are 2 main changes - hiding PEI stack and heap base inside
reserved DRAM region and introducing Progress API handling.
More details can be found in the commit logs and a changelog
below.
The code is also available in t
All required components are in place, so we can now
add all necessary dependencies to build and use capsule support
for Armada7k8k platforms. It is conditionally enabled
with '-D CAPSULE_ENABLE' flag added during build time.
Because the capsule generation must be sequential,
due to boot requiremen
Hi Leif,
> -Original Message-
> From: Leif Lindholm [mailto:leif.lindh...@linaro.org]
> Sent: Thursday, April 19, 2018 8:14 PM
> To: Meenakshi Aggarwal
> Cc: ard.biesheu...@linaro.org; edk2-devel@lists.01.org; Udit Kumar
> ; Varun Sethi ; Vabhav Sharma
>
> Subject: Re: [PATCH edk2-platfo
Reviewed-by: Chasel Chiu
-Original Message-
From: Ni, Ruiyu
Sent: Friday, June 1, 2018 1:39 PM
To: edk2-devel@lists.01.org
Cc: Zeng, Star ; Chiu, Chasel
Subject: [PATCH 3/4] MdeModulePkg/AtaAtapiPassThru: enable/disable PUIS per
policy
Contributed-under: TianoCore Contribution Agree
Reviewed-by: Chasel Chiu
-Original Message-
From: Ni, Ruiyu
Sent: Friday, June 1, 2018 1:39 PM
To: edk2-devel@lists.01.org
Cc: Chiu, Chasel ; Wu, Hao A
Subject: [PATCH 1/4] MdeModulePkg/AtaAtapiPassThru: Spin up Power up in Standby
devices
The patch adds support to certain devices t
Reviewed-by: Chasel Chiu
-Original Message-
From: Ni, Ruiyu
Sent: Friday, June 1, 2018 1:39 PM
To: edk2-devel@lists.01.org
Cc: Chiu, Chasel ; Wu, Hao A
Subject: [PATCH 4/4] MdeModulePkg/Ata/AtaAtapiPassThru: Enable/disable DEVSLP
per policy
Contributed-under: TianoCore Contribution
No.
DxeResetSystemLib cannot be used by runtime driver.
1. the gRT is not converted by itself.
2. Even if we change the library implementation to convert gRT in
VirtualAddressChange callback,
when DXE driver links to this library, the problem similar to UefiRuntimeLib
still occurs.
So I will mak
Haha, you are correct! I forgot to update the commit messages!
My bad!!
I will post a new version to address all concerns, including Star's.
Thanks/Ray
> -Original Message-
> From: Laszlo Ersek
> Sent: Saturday, June 2, 2018 3:06 AM
> To: Ni, Ruiyu ; edk2-devel@lists.01.org
> Cc: Gao, Li
Thanks/Ray
> -Original Message-
> From: jim.dai...@dell.com
> Sent: Saturday, June 2, 2018 2:27 AM
> To: Ni, Ruiyu
> Cc: Carsey, Jaben ; fel...@mail.ru; edk2-
> de...@lists.01.org
> Subject: How to Interpret ReadKeyStrokeEX Data
>
> (Subject changed)
>
> I guess this is a question o
Could interfaces in DxeResetSystemLib be used by runtime code?
If yes, gRT needs to be converted for runtime environment as we discussed about
it at https://lists.01.org/pipermail/edk2-devel/2018-February/021260.html
before.
Thanks,
Star
-Original Message-
From: Ni, Ruiyu
Sent: Frida
33 matches
Mail list logo
