On 6 June 2018 at 15:29, Laszlo Ersek wrote:
> On 06/06/18 14:37, Ard Biesheuvel wrote:
>> Implement ResetSystemLib's EnterS3WithImmediateWake() routine using
>> a jump back to the PEI entry point with interrupts and MMU+caches
>> disabled. This is only possible at boot time, when we are sure that
Hi Gao,
I used the EFI_CALCULATE_CRC32 function from edkCompatibilityPkg\Foundation.
Thanks,
Guy
On Wed, Jun 6, 2018 at 6:00 PM, Gao, Liming wrote:
> Do you use CalculateCrc32() in BaseLib to calculate CRC32 value for the
> different buffer?
>
> > -Original Message-
> > From: edk2-dev
Hi Andrew,
1. i checked the region which stores the code itself (called it MainFV), so
it is supposed to get updated only if i change the code.
2. i compared the binaries after the build, not in the system.
Thanks!
On Wed, Jun 6, 2018 at 6:43 PM, Andrew Fish wrote:
>
> > On Jun 6, 2018, at 7:
As I said in other mailing - I only tested on cases in builld. If you want
standalone test cases I only have time next week to make some.
On Thu, 6/7/18, Shi, Steven wrote:
Subject: RE: [PATCH] BaseTools/GenFw: Add X64 GOTPCREL Support to GenFw
To
This issue only applies to GCC/ELF target.
When using -fpie ("small pie" model which is GCC extension to SYSV ABI) -
eliminates nearly all emission of GOTPCREL in object code (= loading addresses
from the GOT.)
However, when optimizing for size (-Os), sometimes emitted code only needs to
compu
On 7 June 2018 at 07:41, Zeng, Star wrote:
> Thanks, got the point.
>
> It seems vague that who to ensure the cache coherency. MMU? Caller of
> UpdateCapsule? UpdateCapsule? Consumer of capsule data?
>
Unfortunately, since the spec does not mention it at all, we cannot
rely on the caller of Upda
This was the warning(shown for __aeabi_memcpy, __aeabi_memcpy4 and
__aeabi_memcpy8):
ArmPkg/Library/CompilerIntrinsicsLib/memcpy.c:42:6: error: '__aeabi_memcpy8'
alias between functions of incompatible types 'void(void
*, const void *, size_t)' {aka 'void(void *, const void *, unsigned int)'} and
Thanks, got the point.
It seems vague that who to ensure the cache coherency. MMU? Caller of
UpdateCapsule? UpdateCapsule? Consumer of capsule data?
Thanks,
Star
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ard
Biesheuvel
Sent: Thursday, Jun
CC the arm maintainers
On Thu, Jun 7, 2018 at 7:07 AM Michael Zimmermann
wrote:
>
> From: M1cha
>
> GCC8 reported it with the following warning:
> ArmPkg/Library/ArmDisassemblerLib/ArmDisassembler.c: In function
> 'DisassembleArmInstruction':
> ArmPkg/Library/ArmDisassemblerLib/ArmDisassembler.c
From: M1cha
GCC8 reported it with the following warning:
ArmPkg/Library/ArmDisassemblerLib/ArmDisassembler.c: In function
'DisassembleArmInstruction':
ArmPkg/Library/ArmDisassemblerLib/ArmDisassembler.c:397:30: error: bitwise
comparison always evaluates to false [-Werror=tautological-compare]
if
On 7 June 2018 at 03:37, Zeng, Star wrote:
> Hi Ard,
>
> The input parameter CapsuleHeaderArray of UpdateCapsule has the virtual
> address.
>
It has the virtual address of the capsules yes. But how about the data
structures passed as the ScatterGatherList?
> CapsuleHeaderArray
> Virtual pointe
Hi Zenith,
BTW, besides the build pass, did you try to run a Uefi binary, e.g. a simple
shell application, which contain the GOTPCREL relocations? If yes. Please send
out your test case code as well. I appreciate if you could contribute your test
cases as the patch together.
Steven Shi
Intel\
Please see more details in https://bugzilla.tianocore.org/show_bug.cgi?id=970
Steven Shi
Intel\SSG\STO\UEFI Firmware
Tel: +86 021-61166522
iNet: 821-6522
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Shi,
> Steven
> Sent: Thursday, June
Yes. If we disable the '#pragma GCC visibility push (hidden)' in
ProcessorBind.h, the GOTPCREL support is mandatory. 3rd party module build
might need it. It's more complete to add GOTPCREL support.
The hidden #pragma can hide all ELF symbols' visibility, including 'extern'
functions, which is
From: Yunhua Feng
Add the logic to handle the case that Section header size larger than
elf file size.
Cc: Liming Gao
Cc: Yonghong Zhu
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Yunhua Feng
---
BaseTools/Source/C/GenFw/Elf32Convert.c | 3 +++
BaseTools/Source/C/G
From: Yunhua Feng
Add the logic to check whether mCoffAlignment is larger than
MAX_COFF_ALIGNMENT, and report error for it.
Cc: Liming Gao
Cc: Yonghong Zhu
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Yunhua Feng
---
BaseTools/Source/C/GenFw/Elf32Convert.c | 10
We plan to add a group of new Perf macros in performance library for
performance logging. Which will simplify the usage model of performance
measurement.
New Perf Macros:
Macros 1:
#define PERF_START_IMAGE_BEGIN(ModuleHandle)
#define PERF_START_IMAGE_END(ModuleHandle)
Macros 2:
#define PERF_LOAD_
Hi Ard,
The input parameter CapsuleHeaderArray of UpdateCapsule has the virtual address.
CapsuleHeaderArray
Virtual pointer to an array of virtual pointers to the capsules being passed
into update capsule. Each capsules is assumed to stored in contiguous virtual
memory. The capsules in the Caps
What's purpose to support GOTPCREL in GenFw? Could you introduce your usage
model?
> -Original Message-
> From: Zenith432 [mailto:zenith...@users.sourceforge.net]
> Sent: Thursday, June 7, 2018 2:01 AM
> To: edk2-devel@lists.01.org
> Cc: Shi, Steven ; Zhu, Yonghong
> ; Gao, Liming
> Sub
Hi Siva,
Per design, all successful attempts will be published to iBFT, no matter it is
currently used or aborted. Only failed attempts are not published.
I don't think the current behavior is wrong according to iBFT specification,
see
http://download.microsoft.com/download/7/E/7/7E7662CF-CBEA
On 06/06/18 10:21, Mohammad Younas Khan Pathan wrote:
> Hi All,
>
> If there is any generic library function, then we do not need to have
> 2 or more definitions for same function like IsLeapYear().
>
> Searching for 'isleapyear'
> By Mask:
> *.c
> ArmPlatformPkg\Library\PL0
Hello Younas,
On 06/06/18 10:28, Mohammad Younas Khan Pathan wrote:
> Hi all,
>
> I have updated the changes after removing all the unecessary return
> statements in EDKII packages.
>
> I have created EDKIIBug843 branch under master.
> Also attached the changes here.
>
> Please help to review a
Adds support for the following X64 ELF relocations to GenFw
R_X86_64_GOTPCREL
R_X86_64_GOTPCRELX
R_X86_64_REX_GOTPCRELX
CC: Shi Steven
CC: Yonghong Zhu
CC: Liming Gao
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Zenith432
---
BaseTools/Source/C/GenFw/Elf64Conve
On 29 May 2018 at 18:17, Michael D Kinney wrote:
> From: "Kinney, Michael D"
>
> https://bugzilla.tianocore.org/show_bug.cgi?id=801
>
> Use PlatformFlashWriteWithProgress() instead of PlatformFLashWrite()
> so the user can be informed of the progress as a capsule is used
> to update a firmware im
On 29 May 2018 at 18:17, Michael D Kinney wrote:
> From: "Kinney, Michael D"
>
> https://bugzilla.tianocore.org/show_bug.cgi?id=801
>
> Based on content from the following branch/commits:
> https://github.com/Microsoft/MS_UEFI/tree/share/MsCapsuleSupport
>
> * Change Update_Image_Progress() to Up
On 6 June 2018 at 18:07, Kinney, Michael D wrote:
> Ard,
>
> Thanks for adding the note. I was thinking that this could be done
> just before ResetSystem(). It could also be done in SEC phase.
>
> Since capsules are just one use of warm reset, would it make more sense
> to flush all the caches i
Ard,
Thanks for adding the note. I was thinking that this could be done
just before ResetSystem(). It could also be done in SEC phase.
Since capsules are just one use of warm reset, would it make more sense
to flush all the caches in either warm reset of SEC instead of just
the ranges used by c
Thanks for Testing.
Appreciate it.
Supreeth
-Original Message-
From: Sughosh Ganu
Sent: Wednesday, June 6, 2018 6:20 AM
To: Supreeth Venkatesh
Cc: edk2-devel@lists.01.org; jiewen@intel.com; liming@intel.com
Subject: Re: [edk2] [PATCH v3 00/17] *** Standalone Management Mode Core
> On Jun 6, 2018, at 7:18 AM, Guy Raviv wrote:
>
> Hi Everyone,
>
> I have an odd problem.
> In a specific module in my code (MRC training), code modification doesn't
> change the BIOS Crc calculation.
> 1. i checked in my project's fdf file if the FV base address and region
> size defined are
Do you use CalculateCrc32() in BaseLib to calculate CRC32 value for the
different buffer?
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Guy
> Raviv
> Sent: Wednesday, June 6, 2018 10:18 PM
> To: edk2-devel@lists.01.org
> Subject: [edk2] Crc
Hi Everyone,
I have an odd problem.
In a specific module in my code (MRC training), code modification doesn't
change the BIOS Crc calculation.
1. i checked in my project's fdf file if the FV base address and region
size defined are the same as the parameters i'm putting in the calculation.
2. i al
Thanks. Please also include the note in the final commit message.
Reviewed-by: jiewen@intel.com
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ard
> Biesheuvel
> Sent: Wednesday, June 6, 2018 5:10 AM
> To: edk2-devel@lists.01.org
> Cc: N
Hi all,
I have updated the changes after removing all the unecessary return
statements in EDKII packages.
I have created EDKIIBug843 branch under master.
Also attached the changes here.
Please help to review and share your comments.
Thank you,
Younas khan.
__
Hi All,
If there is any generic library function, then we do not need to have
2 or more definitions for same function like IsLeapYear().
Searching for 'isleapyear'
By Mask:
*.c
ArmPlatformPkg\Library\PL031RealTimeClockLib\PL031RealTimeClockLib.c(199)
:IsLeapYear (
ArmPlatf
On Wed, Jun 6, 2018 at 4:02 PM, Laszlo Ersek wrote:
> On 06/06/18 05:05, Prerna wrote:
> > Hi Laszlo,
> > I noticed that the following commit was used to make the 4MB flash layout
> > the default for edk2 builds briefly:
> >
> > bba8dfbec3bb OvmfPkg: make the 4MB flash size the default
> >
> > Ho
Hi Laszlo,
I noticed that the following commit was used to make the 4MB flash layout
the default for edk2 builds briefly:
bba8dfbec3bb OvmfPkg: make the 4MB flash size the default
However, it was later reverted :
6e49d01cfb43 Revert "OvmfPkg: make the 4MB flash size the default"
presumably to f
> On Jun 6, 2018, at 6:03 AM, jim.dai...@dell.com wrote:
>
> Thanks, Mike. I figured that out yesterday.
>
> I think the only problem now is that any shell built with the original change
> to edit will not work as expected if it is run on a system whose BIOS was
> created before the second ch
On 06/06/18 14:37, Ard Biesheuvel wrote:
> Implement ResetSystemLib's EnterS3WithImmediateWake() routine using
> a jump back to the PEI entry point with interrupts and MMU+caches
> disabled. This is only possible at boot time, when we are sure that
> the current CPU is the only one up and running.
Thanks, Mike. I figured that out yesterday.
I think the only problem now is that any shell built with the original change
to edit will not work as expected if it is run on a system whose BIOS was
created before the second change was made (i.e. pretty much every existing UEFI
BIOS in the world!
Make the function comments follow EDK2 coding style.
Cc: Sami Mujawar
Cc: Evan Lloyd
Cc: Jaben Carsey
Cc: Ruiyu Ni
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Dandan Bi
---
.../UefiShellAcpiViewCommandLib/AcpiParser.c | 130 ++--
.../UefiShellAcpiView
1. Separate variable definition and initialization.
2. Make the variable naming following Edk2 rule.
V2: Remove the updates of guard macros in header files.
Cc: Sami Mujawar
Cc: Evan Lloyd
Cc: Jaben Carsey
Cc: Ruiyu Ni
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Dan
ECC tool report some coding style issue in UefiShellAcpiViewCommandLib.
This patch series is to clean these issues.
V2: Remove the updates of guard macros in header files in patch 2.
Cc: Sami Mujawar
Cc: Evan Lloyd
Cc: Jaben Carsey
Cc: Ruiyu Ni
Dandan Bi (2):
ShellPkg/UefiShellAcpiViewComm
On Wed, Jun 06, 2018 at 02:37:01PM +0200, Ard Biesheuvel wrote:
> Implement ResetSystemLib's EnterS3WithImmediateWake() routine using
> a jump back to the PEI entry point with interrupts and MMU+caches
> disabled. This is only possible at boot time, when we are sure that
> the current CPU is the on
Implement ResetSystemLib's EnterS3WithImmediateWake() routine using
a jump back to the PEI entry point with interrupts and MMU+caches
disabled. This is only possible at boot time, when we are sure that
the current CPU is the only one up and running. Also, it depends on
the platform whether the PEI
On 6 June 2018 at 11:52, Ard Biesheuvel wrote:
> When capsule updates are staged for processing after a warm reboot,
> they are copied into memory with the MMU and caches enabled. When
> the capsule PEI gets around to coalescing the capsule, the MMU and
> caches may still be disabled, and so on ar
On Tue, Jun 5, 2018 at 3:43 AM, Supreeth Venkatesh
wrote:
> ***
> This patchset v3 contains only the patches that got feedback/comments frome
> the previous revision v2.
> The patches are
> [PATCH v3 06/17] StandaloneMmPkg: Delete StandaloneMmPkg file.
> [PATCH v3 13/17] StandaloneMmPkg: Add an A
This is a clone of the generic PSCI/SMC based ResetSystemLib from ArmPkg,
with an implementation of EnterS3WithImmediateWake () added that simply
disables interrupts, disables the MMU and jumps back to the PEI entry
point when called at boot time. This is sufficiently close to an
architected warm r
On 06/06/18 05:05, Prerna wrote:
> Hi Laszlo,
> I noticed that the following commit was used to make the 4MB flash layout
> the default for edk2 builds briefly:
>
> bba8dfbec3bb OvmfPkg: make the 4MB flash size the default
>
> However, it was later reverted :
>
> 6e49d01cfb43 Revert "OvmfPkg: ma
I am ok with that, you can propose patch.
Thanks,
Star
-Original Message-
From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org]
Sent: Tuesday, June 5, 2018 8:15 PM
To: Pipat/メタワニットポン ピパット
Cc: edk2-devel@lists.01.org; Ni, Ruiyu ; Dong, Eric
; Zeng, Star
Subject: Re: [edk2] MdeModuleP
When capsule updates are staged for processing after a warm reboot,
they are copied into memory with the MMU and caches enabled. When
the capsule PEI gets around to coalescing the capsule, the MMU and
caches may still be disabled, and so on architectures where uncached
accesses are incoherent with
Hi Dandan,
The Check Tool should be aligned with CSS, so it should be updated.
Regards.
Alexei
From: Bi, Dandan
Sent: 06 June 2018 03:42:07
To: Alexei Fedorov; edk2-devel@lists.01.org
Cc: Carsey, Jaben; Ni, Ruiyu
Subject: RE: [edk2] [patch 2/2] ShellPkg/UefiS
Hi Leo,
I am ok with the code change.
I was just curious about the motivation for the change.
1. No real issue met, but just to follow the doc 8.4.2 ?
2. Real issue met, then what is the issue ?
3. What is the default value of IER for your case ?
If the information are valuable, then they can be
Hello Ting,
Yes. In the use case we said:
NIC 1 - Target 1 : Login success
NIC 1 - Target 2 : Login success
NIC 2 - Target 1 : Login success
But iSCSI Driver will choose the first login session and abort the other in the
same NIC. But even it is aborted it is Published to IBFT.
As you said th
Hi Omkar,
If not MPIO, current iSCSI driver will try the configured attempts and only
publish the successful entries in iBFT. The failed attempts will be removed.
In your case, it looks the ESXi and SLES OS treat the multiple entries on one
NIC (different targets) are illegal.
Thanks,
Ting
-
Created in Bugzilla.
https://bugzilla.tianocore.org/show_bug.cgi?id=978
Thanks,
Derek
From: Yao, Jiewen [mailto:jiewen@intel.com]
Sent: Tuesday, June 5, 2018 11:14 PM
To: Lin, Derek (HPS UEFI Dev) ; Zhang, Chao B
Cc: edk2-devel@lists.01.org; Spottswood, Jason
Subject: RE: TPM 2.0 ACPI tabl
1. Update two typo
2. Correct the to use {} {}, this issue
was caused by flexible PCD value format extend.
Cc: Liming Gao
Cc: Michael Kinney
Cc: Kevin W Shaw
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Yonghong Zhu
---
3_edk_ii_dsc_file_format/310_pcd_sections.md
56 matches
Mail list logo
