Hi,All:
may be I should reply this to EDK2 group,sorry for this mail-size>600K,I had
trim the picture and attached my file again,and send it again.
After many test,my right key of "ls | grep -trim-last 0 | grep -trim-last 0" is:
1,before pipe out the buffer,trim off all in-visible wchars at
Yes. It is too late. The error message says the byte value is wrong. But, it
doesn't mention which PCD is wrong.
>-Original Message-
>From: Zhu, Yonghong
>Sent: Friday, July 06, 2018 9:58 AM
>To: Gao, Liming ; edk2-devel@lists.01.org
>Cc: Zhu, Yonghong
>Subject: RE: [edk2] [Patch V2] B
In GetGuidValue() function it already have this logic to handle it.
Best Regards,
Zhu Yonghong
-Original Message-
From: Gao, Liming
Sent: Friday, July 06, 2018 9:55 AM
To: Zhu, Yonghong ; edk2-devel@lists.01.org
Subject: RE: [edk2] [Patch V2] BaseTools: enable FixedAtBuild (VOID*) PCD
Yonghong:
On error handling, could you check VOID* PCD length to make sure its size is
16 when it is used in [Depex] section?
Thanks
Liming
>-Original Message-
>From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
>Yonghong Zhu
>Sent: Thursday, July 05, 2018 3:28 PM
>T
On Fri, Jul 06, 2018 at 12:46:10AM +, Zhu, Yonghong wrote:
> Hi Gary,
>
> The patch 1 and patch 2 are good to me.
> While for this patch 3, I think it is only for developer evaluation,
> developer can keep it on his local, so I don't prefer to commit it to master.
>
> I have a task on my
Hi Gary,
The patch 1 and patch 2 are good to me.
While for this patch 3, I think it is only for developer evaluation, developer
can keep it on his local, so I don't prefer to commit it to master.
I have a task on my plan to migrate BaseTools to Python 3, maybe this Q3 to
finish it.
Best Reg
The copyright year of the changed files should be updated.
Best Regards,
Zhu Yonghong
-Original Message-
From: Gao, Liming
Sent: Thursday, July 5, 2018 9:38 PM
To: edk2-devel@lists.01.org
Cc: Zhu, Yonghong
Subject: [Patch] BaseTools: Clean up source files
1. Do not use tab characters
2
In the SMM build, only an SMM driver is using the address range hence we
do not need to expose the flash MMIO range in EFI runtime mapping.
Cc: Ard Biesheuvel
Cc: Anthony Perard
Cc: Julien Grall
Cc: Justen Jordan L
Cc: Laszlo Ersek
Contributed-under: TianoCore Contribution Agreement 1.1
Signe
The Qemu flash range is marked as 'system ram' in EFI runtime memmap
but it is actually an IO address. The patch series updates the
EFI runtime memmap to add this range as Memory Mapped IO address.
Changes since v2:
- added cover letter and extend CC list to add all OvmfPkg
maintainers/reviewe
The flash memory range is an IO address and should be presented as Memory
Mapped IO in EFI Runtime mapping. This information can be used by OS
when mapping the flash memory range.
It is especially helpful in SEV guest case, in which IO addresses should
be mapped as unencrypted. If memory region is
AmdSevDxe maps the flash memory range with C=0, but
SetMemorySpaceAttributes() unconditionally resets the C-bit to '1'. Lets
restore the mapping back to C=0.
Cc: Ard Biesheuvel
Cc: Anthony Perard
Cc: Julien Grall
Cc: Justen Jordan L
Cc: Laszlo Ersek
Contributed-under: TianoCore Contribution A
On 7/5/18 9:41 AM, Laszlo Ersek wrote:
> Hi Brijesh,
>
> On 07/05/18 16:05, Brijesh Singh wrote:
>> [...]
> I'll need some time before I can look at this -- meanwhile, can you
> please repost the series with a dedicated cover letter email? If you
> wish you can include a short summary descriptio
Hi Brijesh,
On 07/05/18 16:05, Brijesh Singh wrote:
> [...]
I'll need some time before I can look at this -- meanwhile, can you
please repost the series with a dedicated cover letter email? If you
wish you can include a short summary description and v2/v3 etc updates
there; however, the main poin
Tom:
When I use VS2015 to compile it, I meet with below error. Could you fix them?
Edk2\MdePkg\Library\BaseLib\BitField.c(1002): error C2220: warning treated as
error - no 'object' file generated
Edk2\MdePkg\Library\BaseLib\BitField.c(1002): warning C4244: '=': conversion
from 'UINT64' to 'UIN
The flash memory range is an IO address and should be presented as Memory
Mapped IO in EFI Runtime mapping. This information can be used by OS
when mapping the flash memory range.
It is especially helpful in SEV guest case, in which IO addresses should
be mapped as unencrypted. If memory region is
In the SMM build, only an SMM driver is using the address range hence we
do not need to expose the flash MMIO range in EFI runtime mapping.
Cc: Justen Jordan L
Cc: Laszlo Ersek
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Brijesh Singh
---
.../FwBlockService.c
AmdSevDxe maps the flash memory range with C=0, but
SetMemorySpaceAttributes() unconditionally resets the C-bit to '1'. Lets
restore the mapping back to C=0.
Cc: Justen Jordan L
Cc: Laszlo Ersek
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Brijesh Singh
---
.../FvbSer
Laszlo，
Thanks your remind. You are right! I agree original commit message is correct
and neednt updating.
Eric, please ignore my comments on commit message.
Thanks!
Jeff
发自我的小米手机
在 Laszlo Ersek ，2018年7月5日 下午9:04写道：
Hi Jeff,
On 07/04/18 11:39, Fan Jeff wrote:
> Eric,
>
> Current implementa
1. Do not use tab characters
2. No trailing white space in one line
3. All files must end with CRLF
FormatDosFiles.py is used to clean up all source files in
BaseTools directory. The generated patch is too big.
It is placed in https://github.com/lgao4/edk2/tree/CleanupCode.
Contributed-under: T
On 07/05/18 15:04, Laszlo Ersek wrote:
> Hi Jeff,
>
> On 07/04/18 11:39, Fan Jeff wrote:
>> Eric,
>>
>> Current implementation does not call GetApicid() many times, Please correct
>> you commit message. Your fix is to improve the performance against the
>> current implementation.
>
> I think t
Hi Jeff,
On 07/04/18 11:39, Fan Jeff wrote:
> Eric,
>
> Current implementation does not call GetApicid() many times, Please correct
> you commit message. Your fix is to improve the performance against the
> current implementation.
I think the original commit message does make sense. Without t
On 07/04/18 03:55, Ni, Ruiyu wrote:
> On 7/4/2018 9:50 AM, Ruiyu Ni wrote:
>> v4:
>> 1. adds missing PlatformBootManagerLib instances modification for
>> platform ArmPkg and ArmVirtPkg.
>> 2. Remove single quote in #1/9
>> 3. Wrap the long comments in #3/9
>>
>> Ruiyu Ni (9):
>> M
On 07/04/18 03:50, Ruiyu Ni wrote:
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ruiyu Ni
> Cc: Laszlo Ersek
> Cc: Ard Biesheuvel
> Cc: Julien Grall
> ---
> .../Library/PlatformBootManagerLib/PlatformBm.c| 62
> +-
> 1 file changed, 61 inse
Hi Eric,
On 07/05/18 03:26, Dong, Eric wrote:
> Jeff,
>
> Got it. Will update the change log when I commit the changes.
please give me a bit more time to check this patch; I'll try to come to
it soon.
Thanks for your patience!
Laszlo
>
> Thanks,
> Eric
> From: Fan Jeff [mailto:vanjeff_...@hot
On 07/04/18 16:23, Zeng, Star wrote:
> Pushed at f88290964fe528ffeb67ff108e8174fc2ce52741.
Thank you!
Laszlo
> -Original Message-
> From: Zeng, Star
> Sent: Wednesday, July 4, 2018 10:00 PM
> To: Brijesh Singh ; edk2-devel@lists.01.org
> Cc: Tom Lendacky ; Dong, Eric ;
> Justen, Jordan
From: Yunhua Feng
V2: limit the PCD used in the [Depex] section should be used in the module
The PCD item used in INF [Depex] section must be defined as FixedAtBuild
type and VOID* datum type, and the size of the PCD must be 16 bytes.
Fixes: https://bugzilla.tianocore.org/show_bug.cgi?id=443
Cc
Add SpiAccess build option to change flash region access permission for host
CPU.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Guo Mang
---
BuildBIOS.bat| 1 +
BuildBIOS.sh | 5 +
Pl
27 matches
Mail list logo
