Re: [edk2] [PATCH v2] SecurityPkg: Fix assert when setting key from eMMC/SD/USB

2018-07-16 Thread Roman Bacik
Yes, it is being taking care of. On Mon, Jul 16, 2018 at 8:50 AM, Yao, Jiewen wrote: > Laszlo already filed one - https://bugzilla.tianocore. > org/show_bug.cgi?id=1008 > > I suggest we add to UefiLib instead of fixing all individual driver. > > Thank you > Yao Jiewen > > > > -Original Messa

[edk2] [Patch] BaseTools Script: Add the script to generate Structure PCD setting

2018-07-16 Thread Liming Gao
Here is this script usage. 1. Build one platform. 2. Use FCE tool to read HII config from the generated FD image. FCE read -i Platform.fd > Config.txt 3. Call the script to generate StructurePcd setting. ConvertFceToStructurePcd.py -p Build\PlatformPkg\DEBUG_VS2015x86 -c Config.txt -o OutputDir Ou

[edk2] [Patch V3] BaseTools: enable FixedAtBuild (VOID*) PCD use in the [DEPEX] section

2018-07-16 Thread Yonghong Zhu
From: Yunhua Feng V3: Add some invalid type and datum check V2: limit the PCD used in the [Depex] section should be used in the module The PCD item used in INF [Depex] section must be defined as FixedAtBuild type and VOID* datum type, and the size of the PCD must be 16 bytes. Fixes: https://bu

[edk2] [PATCH edk2-platforms 0/3] Add Platform-Generic Packages to support Windows IoT Core

2018-07-16 Thread Chris Co
REF: https://github.com/christopherco/edk2-platforms/tree/import_mspkg_v1 This patch adds a Platform/Microsoft directory to hold libraries and drivers that are specific to supporting Windows IoT Core but not necessarily specific to a Platform or Silicon. SdMmc DXE driver enables Windows IoT Core

[edk2] [PATCH edk2-platforms 2/3] Platform/Microsoft: Add MsPkg

2018-07-16 Thread Chris Co
MsPkg is a collection of libraries and drivers that are specific to supporting Windows IoT Core but are not Platform/Silicon specific. Cc: Ard Biesheuvel Cc: Leif Lindholm Cc: Michael D Kinney Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Christopher Co --- Platform/M

[edk2] [PATCH edk2-platforms 3/3] Platform/Microsoft: Add Lauterbach debug library

2018-07-16 Thread Chris Co
This debug library provides support for importing symbols to debug using Lauterbach. Derived from: ArmPkg\Library\DebugPeCoffExtraActionLib Cc: Ard Biesheuvel Cc: Leif Lindholm Cc: Michael D Kinney Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Christopher Co --- Pla

[edk2] [Patch] BaseTools: Remove the duplicate Pcd items

2018-07-16 Thread Yonghong Zhu
The case is the Pcd item both used in 1 module inf and 1 lib inf, and in the DSC component section, it override the Pcd value. In the module, the pcd value is the override value, but in the lib inf the pcd value is the value that in the DSC PCD section's value, then it cause the Pcd value is differ

[edk2] [Patch][edk2-platforms/devel-IntelAtomProcessorE3900] DMAR Table Installation.

2018-07-16 Thread zwei4
Move DMAR table into a separate FFS file to make it easier to be located and installed at proper time by VT-d library. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: David Wei CC: Mang Guo --- .../Common/Acpi/AcpiPlatformDxe/AcpiPlatform.c | 4 +- .../Common/Acpi/

[edk2] [Patch][edk2-platforms/devel-IntelAtomProcessorE3900] Enhance Implementation of EFI_PCI_ROOT_BRIDGE_IO_PROTOCOL.

2018-07-16 Thread zwei4
Enhance implementation of EFI_PCI_ROOT_BRIDGE_IO_PROTOCOL by introducing EDKII_IOMMU_PROTOCOL to support DMA remapping when VT-d is enabled. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: David Wei CC: Mang Guo --- .../NorthCluster/PciHostBridge/Dxe/PciHostBridge.c | 34

[edk2] [Patch v3 2/3] UefiCpuPkg/MpInitLib: Use BSP uCode for APs if possible.

2018-07-16 Thread Eric Dong
Search uCode costs much time, if AP has same processor type with BSP, AP can use BSP saved uCode info to get better performance. This change enables this solution. Cc: Laszlo Ersek Cc: Ruiyu Ni Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Eric Dong --- UefiCpuPkg/Lib

[edk2] [Patch v3 1/3] UefiCpuPkg/MpInitLib: Relocate uCode to memory to save time.

2018-07-16 Thread Eric Dong
Read uCode from memory has better performance than from flash. But it needs extra effort to let BSP copy uCode from flash to memory. Also BSP already enable cache in SEC phase, so it use less time to relocate uCode from flash to memory. After verification, if system has more than one processor, it

[edk2] [Patch v3 0/3] Optimize load uCode performance

2018-07-16 Thread Eric Dong
Use below three rules to optimize load uCode performance: 1. Let BSP relocate uCode from flash to memory for better performance. 2. BSP caches the CPU ID and address of uCode so AP doesn’t need to look for the uCode again if the CPU ID is same as BSP’s. 3. Only apply uCode in one thread of a co

Re: [edk2] [staging/FmpDevicePkg-master][PATCH] BaseTools GenerateCapsule: Change property to executable for Linux

2018-07-16 Thread Kinney, Michael D
Reviewed-by: Michael D Kinney Mike > -Original Message- > From: edk2-devel [mailto:edk2-devel- > boun...@lists.01.org] On Behalf Of Star Zeng > Sent: Monday, July 16, 2018 3:42 AM > To: edk2-devel@lists.01.org > Cc: Kinney, Michael D ; > Zeng, Star > Subject: [edk2] [staging/FmpDeviceP

Re: [edk2] [PATCH v2] SecurityPkg: Fix assert when setting key from eMMC/SD/USB

2018-07-16 Thread Yao, Jiewen
Laszlo already filed one - https://bugzilla.tianocore.org/show_bug.cgi?id=1008 I suggest we add to UefiLib instead of fixing all individual driver. Thank you Yao Jiewen > -Original Message- > From: Zhang, Chao B > Sent: Monday, July 16, 2018 11:10 PM > To: rba...@gmail.com; edk2-devel@l

Re: [edk2] [PATCH v2] SecurityPkg: Fix assert when setting key from eMMC/SD/USB

2018-07-16 Thread Zhang, Chao B
Hi Bacik: Tks for the fix. Would you please file another report in Bugzilla for RamDisk & Tls Configuration driver? They have same issue as SecureBootConfig driver -Original Message- From: rba...@gmail.com [mailto:rba...@gmail.com] Sent: Wednesday, July 11, 2018 6:51 AM To: edk2-deve

Re: [edk2] [PATCH v4 6/9] ArmPkg/PlatformBDS: Implement PlatformBootManagerUnableToBoot

2018-07-16 Thread Ard Biesheuvel
> On 16 Jul 2018, at 17:07, Ni, Ruiyu wrote: > > Can someone give a r-b for this patch? > Is Ack-by enough for a check-in? Hi Ray, Please go ahead and merge this patch with my ack. Ard. > >> -Original Message- >> From: Ard Biesheuvel >> Sent: Wednesday, July 11, 2018 10:21 PM >>

[edk2] [staging/FmpDevicePkg-master][PATCH] BaseTools GenerateCapsule: Change property to executable for Linux

2018-07-16 Thread Star Zeng
Cc: Michael D Kinney Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Star Zeng --- BaseTools/BinWrappers/PosixLike/GenerateCapsule | 0 1 file changed, 0 insertions(+), 0 deletions(-) mode change 100644 => 100755 BaseTools/BinWrappers/PosixLike/GenerateCapsule diff --git

Re: [edk2] [Patch] BaseTools: Fixed build Ovmfpkg failed issue.

2018-07-16 Thread Gao, Liming
This patch fixes the regression issues caused by 543f5ac30facfbb40eafb2b4908649a427784080. Without this fix, OvmfPkg will build failure. Thanks Liming >-Original Message- >From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of >BobCF >Sent: Monday, July 16, 2018 5:39 PM

[edk2] [Patch] BaseTools: Fixed build Ovmfpkg failed issue.

2018-07-16 Thread BobCF
Fixed a code bug. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Bob Feng Cc: Liming Gao --- BaseTools/Source/Python/Workspace/DscBuildData.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/BaseTools/Source/Python/Workspace/DscBuildData.py b/B

Re: [edk2] [PATCH v4 6/9] ArmPkg/PlatformBDS: Implement PlatformBootManagerUnableToBoot

2018-07-16 Thread Ni, Ruiyu
Can someone give a r-b for this patch? Is Ack-by enough for a check-in? Thanks/Ray > -Original Message- > From: Ard Biesheuvel > Sent: Wednesday, July 11, 2018 10:21 PM > To: Ni, Ruiyu > Cc: edk2-devel@lists.01.org; Leif Lindholm > Subject: Re: [PATCH v4 6/9] ArmPkg/PlatformBDS: Implem

Re: [edk2] [PATCH] UefiCpuPkg/CpuDxe: fix incorrect check of SMM mode

2018-07-16 Thread Dong, Eric
Reviewed-by: Eric Dong > -Original Message- > From: Wang, Jian J > Sent: Friday, July 13, 2018 1:54 PM > To: edk2-devel@lists.01.org > Cc: Dong, Eric ; Laszlo Ersek ; > Yao, Jiewen ; Zeng, Star > Subject: [PATCH] UefiCpuPkg/CpuDxe: fix incorrect check of SMM mode > > Current IsInSmm() m

Re: [edk2] [Patch] SecurityPkg:Tcg: Fix comment typos

2018-07-16 Thread Long, Qin
Reviewed-by: Long Qin (BTW: Please remove the extra "Signed-off-by" signature) Best Regards & Thanks, LONG, Qin > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Zhang, Chao B > Sent: Monday, July 16, 2018 3:21 PM > To: edk2-devel@lists.01.

Re: [edk2] reg: IP6 based Static IP Configuration in ISCSI

2018-07-16 Thread Sivaraman Nainar
Hello Ting, As you recommended with shell based IP assignment we are able to use the IP6 Static IP bases ISCSI connection. Thanks for your detailed clarification. -Siva -Original Message- From: Ye, Ting [mailto:ting...@intel.com] Sent: Wednesday, July 4, 2018 1:17 PM To: Sivaraman Nai

[edk2] [Patch] SecurityPkg:Tcg: Fix comment typos

2018-07-16 Thread Zhang, Chao B
"Triggle" is a typo. Fix it with "Trigger" Cc: Long Qin Cc: Jiewen Yao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Chao Zhang Signed-off-by: Zhang, Chao B --- SecurityPkg/Tcg/Tcg2Smm/Tpm.asl | 16 SecurityPkg/Tcg/TcgSmm/Tpm.asl | 16 ---

[edk2] [staging/FmpDevicePkg-UDK2018] staging/FmpDevicePkg-UDK2018: Update Readme.MD for new branch

2018-07-16 Thread Kinney, Michael D
Update Readme.MD for the FmpDevicePkg-UDK2018 branch in the edk2-staging repository. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Michael D Kinney --- CryptoPkg/Library/OpensslLib/openssl | 2 +- Readme.md| 159 +