[edk2] [PATCH 3/3] BaseTools: Use hashlib instead of md5

2018-08-07 Thread Feng, YunhuaX
Use from hashlib import md5 instead of import md5 due to md5 deprecated in python3 Cc: Liming Gao Cc: Yonghong Zhu Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Yunhua Feng --- BaseTools/Source/Python/UPT/GenMetaFile/GenDecFile.py | 4 ++-- BaseTools/Source/Python/UPT

[edk2] [PATCH 2/3] BaseTools: remove cmp due to deprecated in python3

2018-08-07 Thread Feng, YunhuaX
remove cmp due to deprecated in python3 Cc: Liming Gao Cc: Yonghong Zhu Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Yunhua Feng --- BaseTools/Source/Python/AutoGen/AutoGen.py | 6 +++--- BaseTools/Source/Python/BPDG/GenVpd.py | 4 ++-- 2 files changed, 5 insertio

[edk2] [PATCH 1/3] BaseTools: Modify class OrderedListDict

2018-08-07 Thread Feng, YunhuaX
class OrderedListDict(OrderedDict, defaultdict) will encounter multiple bases have instance lay-out conflict error on python3 Cc: Liming Gao Cc: Yonghong Zhu Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Yunhua Feng --- BaseTools/Source/Python/Workspace/WorkspaceCommon

[edk2] [PATCH 0/3] Optimizing code

2018-08-07 Thread Feng, YunhuaX
Modify class OrderedListDict, remove cmp and use hashlib instead of md5 Yunhua Feng (3): BaseTools: Modify class OrderedListDict BaseTools: remove cmp due to deprecated in python3 BaseTools: Use hashlib instead of md5 BaseTools/Source/Python/AutoGen/AutoGen.py| 6 +++--- BaseT

[edk2] [PATCH] BaseTools: Check GUID C structure format

2018-08-07 Thread Feng, YunhuaX
GUID C format must conform to {8,4,4,{2,2,2,2,2,2,2,2}} Cc: Liming Gao Cc: Yonghong Zhu Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Yunhua Feng --- BaseTools/Source/Python/Common/GlobalData.py | 7 +++ BaseTools/Source/Python/Common/Misc.py | 4 +++- 2 file

[edk2] [PATCH v3] IntelFrameworkModulePkg/Csm: Set CSM memory executable

2018-08-07 Thread Ruiyu Ni
Commit b22a62be5cdc8fd19d87ec1ecfa5b28fb9be50ad * IntelFrameworkModule/LegacyBios:Use reserved memory for legacy data allocates reserved memory for holding legacy code/data. But with PcdDxeNxMemoryProtectionPolicy set to certain value to forbid execution when code is in certain type of memory, it'

Re: [edk2] [PATCH 3/6] IntelFrameworkModulePkg IdeBusDxe: Remove redundant functions

2018-08-07 Thread Ni, Ruiyu
Reviewed-by: Ruiyu Ni Thanks/Ray > -Original Message- > From: edk2-devel On Behalf Of shenglei > Sent: Wednesday, August 8, 2018 11:09 AM > To: edk2-devel@lists.01.org > Cc: Gao, Liming > Subject: [edk2] [PATCH 3/6] IntelFrameworkModulePkg IdeBusDxe: Remove > redundant functions > > T

Re: [edk2] [PATCH 2/6] IntelFrameworkModulePkg Ps2KeyboardDxe: Remove a redundant function

2018-08-07 Thread Ni, Ruiyu
Reviewed-by: Ruiyu Ni Thanks/Ray > -Original Message- > From: edk2-devel On Behalf Of shenglei > Sent: Wednesday, August 8, 2018 11:09 AM > To: edk2-devel@lists.01.org > Cc: Gao, Liming > Subject: [edk2] [PATCH 2/6] IntelFrameworkModulePkg Ps2KeyboardDxe: > Remove a redundant function

Re: [edk2] [PATCH 1/6] IntelFrameworkModulePkg IsaIoDxe: Remove a redundant protocol

2018-08-07 Thread Ni, Ruiyu
Reviewed-by: Ruiyu Ni Thanks/Ray > -Original Message- > From: edk2-devel On Behalf Of shenglei > Sent: Wednesday, August 8, 2018 11:09 AM > To: edk2-devel@lists.01.org > Cc: Gao, Liming > Subject: [edk2] [PATCH 1/6] IntelFrameworkModulePkg IsaIoDxe: Remove a > redundant protocol > > R

Re: [edk2] [PATCH 5/6] IntelFrameworkModulePkg LegacyBiosDxe: Remove redundant LibraryClasses

2018-08-07 Thread Ni, Ruiyu
Reviewed-by: Ruiyu Ni Thanks/Ray > -Original Message- > From: edk2-devel On Behalf Of shenglei > Sent: Wednesday, August 8, 2018 11:09 AM > To: edk2-devel@lists.01.org > Cc: Gao, Liming > Subject: [edk2] [PATCH 5/6] IntelFrameworkModulePkg LegacyBiosDxe: > Remove redundant LibraryClass

Re: [edk2] [PATCH 6/6] IntelFrameworkModulePkg BdsDxe: Remove redundant functions

2018-08-07 Thread Ni, Ruiyu
Reviewed-by: Ruiyu Ni Thanks/Ray > -Original Message- > From: edk2-devel On Behalf Of shenglei > Sent: Wednesday, August 8, 2018 11:09 AM > To: edk2-devel@lists.01.org > Cc: Gao, Liming > Subject: [edk2] [PATCH 6/6] IntelFrameworkModulePkg BdsDxe: Remove > redundant functions > > The

[edk2] [PATCH v2] ShellPkg/set: Fix EfiShellSetEnv to use case sensitive compare

2018-08-07 Thread Ruiyu Ni
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=777 Per Shell spec, the environment variable has a case-sensitive name. But today's implementation of EfiShellSetEnv() compares the environment variable name case insensitively, which causes variable like "CWD" cannot be set due to "cwd" is pre-d

Re: [edk2] [PATCH] ShellPkg/set: Fix EfiShellSetEnv to use case sensitive compare

2018-08-07 Thread Ni, Ruiyu
It's a typo. V2 patch will correct this. Thanks/Ray > -Original Message- > From: edk2-devel On Behalf Of > jim.dai...@dell.com > Sent: Wednesday, August 8, 2018 2:27 AM > To: Ni, Ruiyu > Cc: Carsey, Jaben ; edk2-devel@lists.01.org > Subject: Re: [edk2] [PATCH] ShellPkg/set: Fix EfiShell

Re: [edk2] [PATCH edk2-platforms v1 06/38] Hisilicon/D06: Add OemMiscLibD06

2018-08-07 Thread Ming
在 8/3/2018 1:22 AM, Leif Lindholm 写道: > On Tue, Jul 24, 2018 at 03:08:50PM +0800, Ming Huang wrote: >> This library include BoardFeatureD06.c and OemMiscLibD06.c c file, >> use for several modules like PciHostBridgeLib and Smbios. >> Enlarge macro PCIEDEVICE_REPORT_MAX for D06. >> >> Contributed-

Re: [edk2] [PATCH v1 1/1] PatchCheck - add error message for invalid parameter

2018-08-07 Thread Zhu, Yonghong
Reviewed-by: Yonghong Zhu Best Regards, Zhu Yonghong -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Carsey, Jaben Sent: Friday, August 03, 2018 11:07 PM To: Gao, Liming ; edk2-devel@lists.01.org Subject: Re: [edk2] [PATCH v1 1/1] PatchCheck -

Re: [edk2] [PATCH] BaseTools: Add Dns and BluetoothLE DevicePath

2018-08-07 Thread Zhu, Yonghong
Reviewed-by: Yonghong Zhu Best Regards, Zhu Yonghong -Original Message- From: Feng, YunhuaX Sent: Monday, August 06, 2018 3:37 PM To: edk2-devel@lists.01.org Cc: Zhu, Yonghong ; Gao, Liming Subject: [PATCH] BaseTools: Add Dns and BluetoothLE DevicePath Add Dns and BluetoothLE for su

Re: [edk2] [PATCH] BaseTools: Fix report flexible value issue

2018-08-07 Thread Zhu, Yonghong
Reviewed-by: Yonghong Zhu Best Regards, Zhu Yonghong -Original Message- From: Feng, YunhuaX Sent: Tuesday, August 07, 2018 2:24 PM To: edk2-devel@lists.01.org Cc: Zhu, Yonghong ; Gao, Liming Subject: [PATCH] BaseTools: Fix report flexible value issue Report flexible value in INF fil

Re: [edk2] [PATCH] BaseTools: Remove duplicate function declaration

2018-08-07 Thread Zhu, Yonghong
Reviewed-by: Yonghong Zhu Best Regards, Zhu Yonghong -Original Message- From: Feng, YunhuaX Sent: Wednesday, August 08, 2018 9:59 AM To: edk2-devel@lists.01.org Cc: Zhu, Yonghong ; Gao, Liming Subject: [PATCH] BaseTools: Remove duplicate function declaration Remove duplicate functio

[edk2] [PATCH 3/6] IntelFrameworkModulePkg IdeBusDxe: Remove redundant functions

2018-08-07 Thread shenglei
The redundant functions which are never called have been removed. They are AtaNonDataCommandInExt,IDEBusDriverConfigurationSetOptions, GetResponse,IDEBusDriverConfigurationOptionsValid and IDEBusDriverConfigurationForceDefaults. https://bugzilla.tianocore.org/show_bug.cgi?id=1063 Cc: Liming Gao C

[edk2] [PATCH 6/6] IntelFrameworkModulePkg BdsDxe: Remove redundant functions

2018-08-07 Thread shenglei
The redundant functions which are never called have been removed. They are GetProducerString,ChangeVariableDevicePath, EfiReallocatePool,Var_UpdateAllConsoleOption and BOpt_IsEfiApp. https://bugzilla.tianocore.org/show_bug.cgi?id=1063 Cc: Liming Gao Contributed-under: TianoCore Contribution Agree

[edk2] [PATCH 2/6] IntelFrameworkModulePkg Ps2KeyboardDxe: Remove a redundant function

2018-08-07 Thread shenglei
The redundant function DisableKeyboard which is never called has been removed. https://bugzilla.tianocore.org/show_bug.cgi?id=1063 Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: shenglei --- .../Bus/Isa/Ps2KeyboardDxe/Ps2KbdCtrller.c| 25 --

[edk2] [PATCH 4/6] IntelFrameworkModulePkg Snp16Dxe: Remove redundant functions

2018-08-07 Thread shenglei
The redundant functions which are never called have been removed. They are PxeUndiSetMcastAddr, PxeUndiInitiateDiags,PxeUndiGetState PxeUndiForceInterrupt and PxeUndiSetPacketFilter. https://bugzilla.tianocore.org/show_bug.cgi?id=1063 Cc: Liming Gao Contributed-under: TianoCore Contribution Agree

[edk2] [PATCH 1/6] IntelFrameworkModulePkg IsaIoDxe: Remove a redundant protocol

2018-08-07 Thread shenglei
Remove a redundant protocol which is gEfiGenericMemTestProtocolGuid. https://bugzilla.tianocore.org/show_bug.cgi?id=1063 Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: shenglei --- IntelFrameworkModulePkg/Bus/Isa/IsaIoDxe/IsaDriver.h | 1 - IntelFramework

[edk2] [PATCH 5/6] IntelFrameworkModulePkg LegacyBiosDxe: Remove redundant LibraryClasses

2018-08-07 Thread shenglei
The redundant LibraryClasses which are PeCoffLib and CacheMaintenanceLib have been removed. https://bugzilla.tianocore.org/show_bug.cgi?id=1063 Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: shenglei --- IntelFrameworkModulePkg/Csm/LegacyBiosDxe/LegacyBios

[edk2] [PATCH 0/6] IntelFrameworkModulePkg: Remove something reduntdant

2018-08-07 Thread shenglei
A lot of redundant funcions which are never calld have been removed.I manually search these fuctions in source files to make sure that they are not used elsewhere. Also the IntelFrameworkModulePkg was built to ensure that. A redundant protocol and two LibraryClasses have been removed. shenglei (

Re: [edk2] [PATCH edk2-non-osi v1 1/1] Hisilicon/D06: Add binary modules

2018-08-07 Thread Ming
在 8/6/2018 6:21 PM, Leif Lindholm 写道: > On Tue, Jul 24, 2018 at 03:28:16PM +0800, Ming Huang wrote: >> Add initial binary for D06. >> Build commit infomation: >> edk2: e73f499 >> edk2-platforms: 7f223e6 >> HwPkg: e0bf35e >> TrusedFirmware: 4eda1d1 >> Tools: 6b286b1 > > The above information is a

[edk2] [PATCH] BaseTools: Remove duplicate function declaration

2018-08-07 Thread Feng, YunhuaX
Remove duplicate function declaration Cc: Liming Gao Cc: Yonghong Zhu Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Yunhua Feng --- BaseTools/Source/C/DevicePath/UefiDevicePathLib.h | 7 --- 1 file changed, 7 deletions(-) diff --git a/BaseTools/Source/C/DevicePath

Re: [edk2] [PATCH v1 1/1] PatchCheck - add error message for invalid parameter

2018-08-07 Thread Gao, Liming
Jaben: I verify this case. Your patch fixes it. Tested-by: Liming Gao Thanks Liming >-Original Message- >From: Carsey, Jaben >Sent: Friday, August 03, 2018 11:07 PM >To: Gao, Liming ; edk2-devel@lists.01.org >Subject: RE: [edk2] [PATCH v1 1/1] PatchCheck - add error message for invali

Re: [edk2] [PATCH 0/2] Fix ESRT out of date

2018-08-07 Thread Zeng, Star
Agree, thanks very much. :) Star -Original Message- From: Kinney, Michael D Sent: Wednesday, August 8, 2018 9:02 AM To: Zeng, Star ; edk2-devel@lists.01.org; Kinney, Michael D Subject: RE: [PATCH 0/2] Fix ESRT out of date Series Reviewed-by: Michael D Kinney The commit message in pat

Re: [edk2] [Patch] UefiCpuPkg/RegisterCpuFeaturesLib: Implement AllocateAcpiCpuData function.

2018-08-07 Thread Dong, Eric
Hi Laszlo, > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Saturday, August 4, 2018 12:46 AM > To: Dong, Eric > Cc: edk2-devel@lists.01.org; Ni, Ruiyu ; Marvin Häuser > ; Jeff Fan ; Ard > Biesheuvel > Subject: Re: [Patch] UefiCpuPkg/RegisterCpuFeaturesLib: I

Re: [edk2] [PATCH] FmpDevicePkg FmpDxe: Lock variables in entrypoint instead of callback

2018-08-07 Thread Kinney, Michael D
Reviewed-by: Michael D Kinney Mike > -Original Message- > From: Zeng, Star > Sent: Tuesday, August 7, 2018 3:28 AM > To: edk2-devel@lists.01.org > Cc: Zeng, Star ; Kinney, Michael D > > Subject: [PATCH] FmpDevicePkg FmpDxe: Lock variables in > entrypoint instead of callback > > Current

Re: [edk2] [PATCH 0/2] Fix ESRT out of date

2018-08-07 Thread Kinney, Michael D
Series Reviewed-by: Michael D Kinney The commit message in patch 2 should say "(reset is not required" Mike > -Original Message- > From: Zeng, Star > Sent: Monday, August 6, 2018 3:29 AM > To: edk2-devel@lists.01.org > Cc: Zeng, Star ; Kinney, Michael D > > Subject: [PATCH 0/2] Fix E

Re: [edk2] [PATCH] BaseTools: Optimizing code for function doesn't match

2018-08-07 Thread Zhu, Yonghong
Reviewed-by: Yonghong Zhu Best Regards, Zhu Yonghong -Original Message- From: Feng, YunhuaX Sent: Monday, August 06, 2018 9:11 AM To: edk2-devel@lists.01.org Cc: Zhu, Yonghong ; Gao, Liming Subject: [PATCH] BaseTools: Optimizing code for function doesn't match Optimizing code for fu

Re: [edk2] [PATCH] BaseTools: Use gGuidPattern for Guid regular expression

2018-08-07 Thread Zhu, Yonghong
Reviewed-by: Yonghong Zhu Best Regards, Zhu Yonghong -Original Message- From: Feng, YunhuaX Sent: Monday, August 06, 2018 9:02 AM To: edk2-devel@lists.01.org Cc: Zhu, Yonghong ; Gao, Liming Subject: [PATCH] BaseTools: Use gGuidPattern for Guid regular expression Use GlobalData.py gG

Re: [edk2] [PATCH] BaseTools: Debug message make confused

2018-08-07 Thread Zhu, Yonghong
Reviewed-by: Yonghong Zhu Best Regards, Zhu Yonghong -Original Message- From: Feng, YunhuaX Sent: Monday, August 06, 2018 9:09 AM To: edk2-devel@lists.01.org Cc: Zhu, Yonghong ; Gao, Liming Subject: [PATCH] BaseTools: Debug message make confused Debug message make confused Fix http

Re: [edk2] [platforms: PATCH v2 0/9] Armada7k8k DT/ACPI support

2018-08-07 Thread Marcin Wojtas
Hi Mark, wt., 7 sie 2018 o 23:48 Mark Kettenis napisał(a): > > > From: Marcin Wojtas > > Date: Tue, 7 Aug 2018 13:28:19 +0200 > > > > wt., 7 sie 2018 o 11:18 Ard Biesheuvel > > napisał(a): > > > > > > On 7 August 2018 at 10:58, Marcin Wojtas wrote: > > > > Hi, > > > > > > > > The second versi

Re: [edk2] Question about memory map entries

2018-08-07 Thread Yao, Jiewen
Hi It is unclear to me that which type you have put to MemoryTypeInfo table. By design, we only need put Reserved/Acpi/Runtime, which should be quite small. Do you put any other type into MemoryTypeInfo table? Thank you Yao Jiewen From: Rafael Machado [mailto:rafaelrodrigues.mach...@gmail.com]

[edk2] [PATCH v1 1/1] BaseTools: Eot - fix variable names

2018-08-07 Thread Jaben Carsey
1) currently a couple classes use m instead of self (including some mixed functions that should have previously failed). 2) deleted some blank lines. Cc: Yonghong Zhu Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jaben Carsey --- BaseTools/Source/Python/

Re: [edk2] [platforms: PATCH v2 0/9] Armada7k8k DT/ACPI support

2018-08-07 Thread Mark Kettenis
> From: Marcin Wojtas > Date: Tue, 7 Aug 2018 13:28:19 +0200 > > wt., 7 sie 2018 o 11:18 Ard Biesheuvel napisał(a): > > > > On 7 August 2018 at 10:58, Marcin Wojtas wrote: > > > Hi, > > > > > > The second version of the patchset modifies AcpiTables > > > directory structure in order to avoid pa

Re: [edk2] [PATCH edk2-platforms] Silicon/Hisilicon: add PlatformBootManagerUnableToBoot() to PlatformBm

2018-08-07 Thread Ard Biesheuvel
On 7 August 2018 at 22:51, Leif Lindholm wrote: > edk2 commit 1010873becc5, > ("MdeModulePkg/BdsDxe: Call PlatformBootManagerUnableToBoot()") broke the > d0x build, since they use their own PlatformBootManagerLib, which did not > include this function. > > Implement a trivial one, that just return

[edk2] [PATCH edk2-platforms] Silicon/Hisilicon: add PlatformBootManagerUnableToBoot() to PlatformBm

2018-08-07 Thread Leif Lindholm
edk2 commit 1010873becc5, ("MdeModulePkg/BdsDxe: Call PlatformBootManagerUnableToBoot()") broke the d0x build, since they use their own PlatformBootManagerLib, which did not include this function. Implement a trivial one, that just returns. Contributed-under: TianoCore Contribution Agreement 1.1

Re: [edk2] Question about memory map entries

2018-08-07 Thread Rafael Machado
Hi everyone Based on the information shared by the members, the understanding is that the current state of the system may impact fuutre boots. The problem is that in my case, due to specific requirements, before booting we need to stress the system's memory, allocating a big amount of memory and d

Re: [edk2] [PATCH] ShellPkg/set: Fix EfiShellSetEnv to use case sensitive compare

2018-08-07 Thread Jim.Dailey
Ray, Table 8 in version 2.2 of the Shell Spec says "lasterror" (lower-case L). Why compare to "Lasterror"? Regards, Jim -Original Message- From: Carsey, Jaben [mailto:jaben.car...@intel.com] Sent: Tuesday, August 7, 2018 12:57 PM To: Ni, Ruiyu; edk2-devel@lists.01.org Cc: Dailey, Jim S

Re: [edk2] [PATCH] ShellPkg/set: Fix EfiShellSetEnv to use case sensitive compare

2018-08-07 Thread Carsey, Jaben
Reviewed-by: Jaben Carsey > -Original Message- > From: Ni, Ruiyu > Sent: Tuesday, August 07, 2018 2:14 AM > To: edk2-devel@lists.01.org > Cc: Carsey, Jaben ; Jim Dailey > > Subject: [PATCH] ShellPkg/set: Fix EfiShellSetEnv to use case sensitive > compare > Importance: High > > REF: http

Re: [edk2] [PATCH edk2-platforms v1 0/2] Modify following Switch generic PciHostBridge

2018-08-07 Thread Ming
在 8/6/2018 6:57 PM, Leif Lindholm 写道: > On Sun, Aug 05, 2018 at 10:38:53AM +0800, Ming Huang wrote: >> The major features of this patchset include: >> 1. Remove D02 platform; >> 2. Fix a D03 issue about switch generic PciHostBridge; >> >> Code can also be found in github: >> https://github.com/h

Re: [edk2] [PATCH edk2-platforms v1 05/38] Platform/Hisilicon/D06: Add binary file for D06

2018-08-07 Thread Ming
在 8/3/2018 1:05 AM, Leif Lindholm 写道: > Could the subject be changed to "add edk2-non-osi components for D06"? > OK > I should point out that I really like how this is done as a separate > patch. > The binary libraries are need for following patch, so this patch is added here. > On Tue, Jul

[edk2] [PATCH edk2-non-osi v1 0/1] Remove D02 Platform

2018-08-07 Thread Ming Huang
The major features of this patchset include: 1. Remove D02 platform; Code can also be found in github: https://github.com/hisilicon/OpenPlatformPkg.git branch: rm-D02-non-osi *** BLURB HERE *** Ming Huang (1): Hisilicon/D02: Remove D02 platform .../AtaAtapiPassThru/AtaAtapiPassThru.inf

[edk2] [PATCH edk2-non-osi v1 1/1] Hisilicon/D02: Remove D02 platform

2018-08-07 Thread Ming Huang
D02 is no need to maintain now, so remove D02 platform binary. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ming Huang --- Platform/Hisilicon/D02/Drivers/AtaAtapiPassThru/AtaAtapiPassThru.inf | 28 -- Platform/Hisilicon/D02/Drivers/Net/SnpPV600D

Re: [edk2] [PATCH edk2-platforms 1/4] Platform/Solidrun: Add Hummingboard SmBios

2018-08-07 Thread Leif Lindholm
I'll start trickling through some generic comments on the code, apart from the general ones I made before. On Sun, Jul 22, 2018 at 01:30:34AM +, Chris Co wrote: > This adds SMBIOS support for SolidRun's i.MX6Q Hummingboard Edge. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Si

Re: [edk2] [PATCH 0/6] BaseTools/Source/C: take EXTRA_OPTFLAGS and EXTRA_LDFLAGS from the caller

2018-08-07 Thread Laszlo Ersek
On 08/07/18 07:27, Gao, Liming wrote: > Laszlo: > I mean to keep the minimal change in PCCT. I don't prevent the necessary > change in PCCT code. Per your comments, this change in PCCT is necessary. If > so, I am OK to this patch. > > Reviewed-by: Liming Gao Thanks -- I understand it bett

Re: [edk2] [PATCH v2 5/7] SecurityPkg/SecureBootConfigDxe: replace OpenFileByDevicePath() with UefiLib API

2018-08-07 Thread Zhang, Chao B
Reviewed-by : Chao Zhang -Original Message- From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Friday, August 3, 2018 8:16 PM To: edk2-devel-01 Cc: Zhang, Chao B ; Yao, Jiewen ; Roman Bacik Subject: [PATCH v2 5/7] SecurityPkg/SecureBootConfigDxe: replace OpenFileByDevicePath() with

Re: [edk2] [Patch] DSC Spec: Update SkuId and DefaultStore name as C name style

2018-08-07 Thread Zhu, Yonghong
Reviewed-by: Yonghong Zhu Best Regards, Zhu Yonghong -Original Message- From: Gao, Liming Sent: Tuesday, August 07, 2018 5:47 PM To: edk2-devel@lists.01.org Cc: Zhu, Yonghong Subject: [Patch] DSC Spec: Update SkuId and DefaultStore name as C name style Contributed-under: TianoCore C

Re: [edk2] [PATCH v2] IntelFrameworkModulePkg/Csm: Set CSM memory executable

2018-08-07 Thread Laszlo Ersek
Hi Ray, On 08/07/18 07:58, Ruiyu Ni wrote: > Commit b22a62be5cdc8fd19d87ec1ecfa5b28fb9be50ad > * IntelFrameworkModule/LegacyBios:Use reserved memory for legacy data > allocates reserved memory for holding legacy code/data. > > But with PcdDxeNxMemoryProtectionPolicy set to certain value to > forb

Re: [edk2] [platforms: PATCH v2 0/9] Armada7k8k DT/ACPI support

2018-08-07 Thread Marcin Wojtas
wt., 7 sie 2018 o 11:18 Ard Biesheuvel napisał(a): > > On 7 August 2018 at 10:58, Marcin Wojtas wrote: > > Hi, > > > > The second version of the patchset modifies AcpiTables > > directory structure in order to avoid passing relative > > paths in the boards' .inf files. > > > > The patches are ava

[edk2] [PATCH] FmpDevicePkg FmpDxe: Lock variables in entrypoint instead of callback

2018-08-07 Thread Star Zeng
Current code locks variables in PcdFmpDeviceLockEventGuid callback by VariableLock protocol whose interface will be closed at EndOfDxe. So the PcdFmpDeviceLockEventGuid callback needs be executed before the EndOfDxe callback in Variable driver. When PcdFmpDeviceLockEventGuid = gEfiEndOfDxeEventGrou

[edk2] [Patch] DSC Spec: Update SkuId and DefaultStore name as C name style

2018-08-07 Thread Liming Gao
Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Liming Gao Cc: Yonghong Zhu --- 3_edk_ii_dsc_file_format/310_pcd_sections.md| 15 +-- 3_edk_ii_dsc_file_format/313_[defaultstores]_section.md | 3 +-- 3_edk_ii_dsc_file_format/35_[defines]_section.md

Re: [edk2] [platforms: PATCH v2 0/9] Armada7k8k DT/ACPI support

2018-08-07 Thread Ard Biesheuvel
On 7 August 2018 at 10:58, Marcin Wojtas wrote: > Hi, > > The second version of the patchset modifies AcpiTables > directory structure in order to avoid passing relative > paths in the boards' .inf files. > > The patches are available in the github: > https://github.com/MarvellEmbeddedProcessors/e

[edk2] [PATCH] ShellPkg/set: Fix EfiShellSetEnv to use case sensitive compare

2018-08-07 Thread Ruiyu Ni
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=777 Per Shell spec, the environment variable has a case-sensitive name. But today's implementation of EfiShellSetEnv() compares the environment variable name case insensitively, which causes variable like "CWD" cannot be set due to "cwd" is pre-d

[edk2] [platforms: PATCH v2 1/9] Marvell/Armada7k8k: Import device tree

2018-08-07 Thread Marcin Wojtas
Add a device tree description of the Armada7k8k SoCs, whose sources are aligned to the Linux v4.18-rc7. Enablement for each board will be done in the follow-up commits. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marcin Wojtas --- Silicon/Marvell/Armada7k8k/DeviceTree/

[edk2] [platforms: PATCH v2 8/9] Marvell/Armada80x0Db: Enable ACPI support

2018-08-07 Thread Marcin Wojtas
This patch introduces DSDT table and adds necessary wiring in order to enable ACPI support on Armada 8040 DB. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marcin Wojtas --- Platform/Marvell/Armada80x0Db/Armada80x0Db.dsc | 3 + Silicon/Marvell/Armada7k8k/A

[edk2] [platforms: PATCH v2 5/9] Marvell/Armada80x0McBin: Enable device tree support

2018-08-07 Thread Marcin Wojtas
This patch enables compilation of the Armada 8040 MacchiatoBin device tree. Dsable OS acccess to the SPI flash and extend PCI ranges to use 256MB mmio32 and 4GB mmio64. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marcin Wojtas --- Platform/SolidRun/Armada80x0McBin/Arma

[edk2] [platforms: PATCH v2 9/9] Marvell/Armada80x0McBin: Enable ACPI support

2018-08-07 Thread Marcin Wojtas
This patch introduces DSDT table and adds necessary wiring in order to enable ACPI support on Armada 8040 MacchiatoBin. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marcin Wojtas --- Platform/SolidRun/Armada80x0McBin/Armada80x0McBin.dsc | 3 + Silicon/Marvell

[edk2] [platforms: PATCH v2 3/9] Marvell/Armada70x0Db: Enable device tree support

2018-08-07 Thread Marcin Wojtas
This patch enables compilation of the Armada 7040 DB device tree. Necessary adjustments are added, so that the OS can use efi-rtc and has no access to the SPI flash Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marcin Wojtas --- Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.

[edk2] [platforms: PATCH v2 6/9] Marvell/Armada7k8k: Add common ACPI tables

2018-08-07 Thread Marcin Wojtas
This patch adds ACPI tables and necessary headers, which are common for Armada7k8k SoCs. Per-board tables and wiring up of support will be done in the follow-up commits. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marcin Wojtas --- Silicon/Marvell/Armada7k8k/AcpiTables

[edk2] [platforms: PATCH v2 4/9] Marvell/Armada80x0Db: Enable device tree support

2018-08-07 Thread Marcin Wojtas
This patch enables compilation of the Armada 8040 DB device tree. Also disable OS access to the SPI flash. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marcin Wojtas --- Platform/Marvell/Armada80x0Db/Armada80x0Db.dsc | 3 +++ Silicon/Marvell/Armada7k8k/Device

[edk2] [platforms: PATCH v2 7/9] Marvell/Armada70x0Db: Enable ACPI support

2018-08-07 Thread Marcin Wojtas
This patch introduces DSDT table and adds necessary wiring in order to enable ACPI support on Armada 7040 DB. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marcin Wojtas --- Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc | 14 ++ Platform/Marvell/Armada70x0

[edk2] [platforms: PATCH v2 0/9] Armada7k8k DT/ACPI support

2018-08-07 Thread Marcin Wojtas
Hi, The second version of the patchset modifies AcpiTables directory structure in order to avoid passing relative paths in the boards' .inf files. The patches are available in the github: https://github.com/MarvellEmbeddedProcessors/edk2-open-platform/commits/dt-acpi-upstream-r20180807 I'm looki

[edk2] [platforms: PATCH v2 2/9] Marvell/Armada7k8k: Enable including additional DXE FV components

2018-08-07 Thread Marcin Wojtas
Unified .fdf file allows to update all Armada7k8k-based boards at the same time. However there may be a need to add unique DXE firmware volume contents like DTB or ACPI. For this purpose create empty files for existing boards that are included as defined in BOARD_DXE_FV_COMPONENTS macro. Contribu

Re: [edk2] [platforms: PATCH 7/9] Marvell/Armada70x0Db: Enable ACPI support

2018-08-07 Thread Ard Biesheuvel
On 6 August 2018 at 19:55, Marcin Wojtas wrote: > pon., 6 sie 2018 o 19:44 Leif Lindholm napisał(a): >> >> >> >> On Mon, 6 Aug 2018, 17:09 Ard Biesheuvel, wrote: >>> >>> On 6 August 2018 at 18:08, Marcin Wojtas wrote: >>> > HI Ard, >>> > >>> > pon., 6 sie 2018 o 13:54 Ard Biesheuvel >>> > nap