Fix the parameter in EfiBootManagerAddKeyOptionVariable (). Otherwise,
the hotkey of boot option won't be registered correctly.
Cc: Laszlo Ersek
Cc: Leif Lindholm
Cc: Ard Biesheuvel
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Haojian Zhuang
---
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Guo Mang
Reviewed-by: David Wei
Reviewed-by: David Wei
---
.../Common/Library/PlatformBootManagerLib/PlatformBootOption.c | 10 --
.../Common/PlatformSettings/PlatformPostMemPei/BootMode.c | 10 +-
Initialize some pointers which may be used without initialization
Cc: David Wei
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Guo Mang
Reviewed-by: David Wei
---
.../Common/Library/PlatformBootManagerLib/PlatformBootManager.c | 5 -
Cc: David Wei
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Guo Mang
Reviewed-by: David Wei
---
.../SmBiosMiscDxe/MiscSystemManufacturerFunction.c | 16 +---
.../DxeSmbiosProcessorLib/DxeSmbiosProcessorLib.c| 7 ++-
Guo Mang (5):
Fix klocwork issues
Change StrCpy() to StrCpyS()
Add NULL checking for some pointers
Initialize some pointers
Correct code format
.../Common/Acpi/AcpiPlatformDxe/AcpiPlatform.c | 2 +-
.../Application/FirmwareUpdate/FirmwareUpdate.c| 4 +--
Fix klocwork issues: change StrCpy() to StrCpyS()
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Guo Mang
Reviewed-by: David Wei
---
.../Common/Application/FirmwareUpdate/FirmwareUpdate.c| 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff
Cc: David Wei
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Guo Mang
---
.../Common/Acpi/AcpiPlatformDxe/AcpiPlatform.c | 2 +-
.../Smbios/SmBiosMiscDxe/MiscOemType0x94Function.c | 4 +--
.../PlatformPreMemPei/FvCallback.c | 4 +--
Hi All,
Intel is pleased to announce that Coffee Lake FSP is now available on
https://github.com/IntelFsp/FSP. In addition, the previously discussed
reorganization to move all FSP binaries in the master branch has been completed.
With Best Regards,
Nate
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1099
Add SMBIOS 3.2.0 definitions according to
www.dmtf.org/sites/default/files/standards/documents/DSP0134_3.2.0.pdf.
Processor Information (Type 4):
- SMBIOSCR00163: add socket LGA2066
- SMBIOSCR00173: add Intel Core i9
- SMBIOSCR00176: add
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1099
Cc: Liming Gao
Cc: Dandan Bi
Cc: Michael D Kinney
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Star Zeng
---
MdeModulePkg/MdeModulePkg.dec | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git
https://bugzilla.tianocore.org/show_bug.cgi?id=1099
This patch series updates
1. MdePkg/Include/IndustryStandard/Smbios.h
2. gEfiMdeModulePkgTokenSpaceGuid.PcdSmbiosVersion and
gEfiMdeModulePkgTokenSpaceGuid.PcdSmbiosDocRev
V2:
Add missing update to MISC_PORT_TYPE and
SMBIOS_TABLE_TYPE9 in
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1109
Today's restriction of VGA device is to have only one VGA device
enabled per PCI segment. It's not correct because several segments
may share one IO / MMIO address space.
We should restrict to have one VGA per Host Bridge because each
Host
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1109
Today's restriction of VGA device is to have only one VGA device
enabled per PCI segment. It's not correct because several segments
may share one IO / MMIO address space.
We should restrict to have one VGA per Host Bridge because each
Host
V2: Add --target-name to specify the file name to create
Because Ecc.py was renamed to EccMain.py
Cc: Liming Gao
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Yonghong Zhu
---
BaseTools/Source/Python/Makefile | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
Hi Sami,
On Tue, Aug 21, 2018 at 11:14:43AM +0100, Sami Mujawar wrote:
> Updated Redistributor base calculation to allow for the fact that
> GICv4 has 2 additional 64KB frames (for VLPI and a reserved frame).
> The code now tests the VLPIS bit in the GICR_TYPER register
Can you expand the name
Hi Ming,
I have finished reviewing v2/v3.
Please go ahead and start putting together and sending out a v4 of
both the edk2-platforms part and the edk2-non-osi part.
Regards,
Leif
On Tue, Aug 14, 2018 at 04:08:20PM +0800, Ming Huang wrote:
> The major features of this patchset include:
> 1 D06
So, on the whole, I am really not happy for any of these commands to
go into 18.08. I understand they may be handy for development, but I
do not understand why they make sense to upstream.
On Tue, Aug 14, 2018 at 04:09:02PM +0800, Ming Huang wrote:
> Add Hisilicon Oem Shell libraries for some
On Tue, Aug 14, 2018 at 04:08:56PM +0800, Ming Huang wrote:
> This module support updating the boot CPU firmware only.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ming Huang
As I said on v1, I have no further comments on this.
Reviewed-by: Leif Lindholm
Ard
Please correct the subject as per my prevoious comments on this.
On the whole, I think the enable/disable SMMU is a likely enough
scenario that we should probably have some core functionality for it
like for SPCR. For now I'm OK with this.
On Tue, Aug 14, 2018 at 04:09:00PM +0800, Ming Huang
On Wed, Aug 22, 2018 at 11:16:26PM +0800, Ming wrote:
>
>
> On 8/22/2018 10:27 PM, Leif Lindholm wrote:
> > On Tue, Aug 14, 2018 at 04:08:43PM +0800, Ming Huang wrote:
> >> Because I2C Port5 salve device connect under I2C extender
> >> (9545 device), it will cost more time to access I2C slave
>
On Wed, Aug 22, 2018 at 10:54:54PM +0800, Ming wrote:
>
>
> On 8/22/2018 5:49 PM, Leif Lindholm wrote:
> > On Tue, Aug 14, 2018 at 04:08:32PM +0800, Ming Huang wrote:
> >> Add PcdCoreCount to fix build issue while add binary components.
> >
> > This commit message fails to describe what is
On 08/22/18 18:34, Gao, Liming wrote:
> Reviewed-by: Liming Gao
Thanks!
> And, push at aa4e0df1f0c7ffdff07d7e382c9da89cbe207cdb
That's very kind of you! Thanks! :)
Laszlo
> Thanks
> Liming
>> -Original Message-
>> From: Laszlo Ersek [mailto:ler...@redhat.com]
>> Sent: Thursday,
On Sat, Aug 18, 2018 at 02:20:49PM +0800, Ming wrote:
>
>
> 在 8/17/2018 8:23 PM, Leif Lindholm 写道:
> > Hi Ming,
> >
> > Please do not send new revisions while I'm still reviewing the
> > previous one. It is possible you inferred that I wanted this from some
> > comment I made about changes I
Reviewed-by: Liming Gao
And, push at aa4e0df1f0c7ffdff07d7e382c9da89cbe207cdb
Thanks
Liming
> -Original Message-
> From: Laszlo Ersek [mailto:ler...@redhat.com]
> Sent: Thursday, August 16, 2018 7:38 PM
> To: edk2-devel-01
> Cc: Gao, Liming ; Zhu, Yonghong
> Subject: [PATCH]
Reviewed-by: Liming Gao
> -Original Message-
> From: Zhu, Yonghong
> Sent: Wednesday, August 22, 2018 1:41 AM
> To: edk2-devel@lists.01.org
> Cc: Gao, Liming
> Subject: [Patch] BaseTools: Update Makefile for ECC tool
>
> Because Ecc.py was renamed to EccMain.py
>
> Cc: Liming Gao
>
On Tue, Aug 14, 2018 at 04:09:01PM +0800, Ming Huang wrote:
> Add a Null PciPlatformLib for build D06. The switch generic
> PciHostBridge patch set add two api for PciPlatform driver,
> so need to implement the two api for D06.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
>
On Tue, Aug 14, 2018 at 04:09:03PM +0800, Ming Huang wrote:
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ming Huang
Reviewed-by: Leif Lindholm
> ---
> Platform/Hisilicon/D03/D03.dsc | 2 +-
> Platform/Hisilicon/D05/D05.dsc | 2 +-
> Platform/Hisilicon/D06/D06.dsc
On Tue, Aug 14, 2018 at 04:08:58PM +0800, Ming Huang wrote:
> During the period of I2c accessing, if the board is reset
> unexpectedly, and because the I2c client can not reset,
> the SDA will be always pull down, then it cause I2C bus
> Exception.
>
> Follow the Hi1620 I2C FS chapter 1.8.2
On Tue, Aug 14, 2018 at 04:08:57PM +0800, Ming Huang wrote:
> From: ZhenYao
>
> When BIOS booting, the power consumption is too high, so need close
> some clusters clock that don't work to reduce power consumption.
>
> The implementation of functions is in edk2-non-osi.
>
> Contributed-under:
On Tue, Aug 14, 2018 at 04:08:54PM +0800, Ming Huang wrote:
> From: Luqi Jiang
>
> This driver provide a means for the platform to
> convey error information to OSPM.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Luqi Jiang
> ---
> Platform/Hisilicon/D06/D06.dsc
On 8/22/2018 10:27 PM, Leif Lindholm wrote:
> On Tue, Aug 14, 2018 at 04:08:43PM +0800, Ming Huang wrote:
>> Because I2C Port5 salve device connect under I2C extender
>> (9545 device), it will cost more time to access I2C slave
>> device, so add delay time for HNS auto config.
>>
>>
On 8/22/2018 10:14 PM, Leif Lindholm wrote:
> On Tue, Aug 14, 2018 at 04:08:38PM +0800, Ming Huang wrote:
>> From: Yang XinYi
>>
>> This library is added for oem setup menu item.
>> Setup item include:
>> 1 DDR option item;
>> 2 BMC option item;
>> 3 Ras option item;
>> 4 Misc option item;
>>
On Tue, Aug 14, 2018 at 04:08:53PM +0800, Ming Huang wrote:
> PciHostBridgeLib which is need by PciHostBridgeDxe, provide
> root bridges and deal with resource conflict.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ming Huang
All of my comments from v1 have been
On Tue, Aug 14, 2018 at 04:08:52PM +0800, Ming Huang wrote:
> This peim configuare SMMU,BSP,MN(Miscellaneous Node).
configuare still needs to change to
configures
With that change:
Reviewed-by: Leif Lindholm
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ming Huang
On 8/22/2018 6:25 PM, Leif Lindholm wrote:
> (Commenting on the v3 patch since I know it supersedes the v2 patch.)
>
> On Thu, Aug 16, 2018 at 08:12:10PM +0800, Ming Huang wrote:
>> This patch is relative to D06 SasDxe driver. The SasDxe set a
>> variable to notice this libray. Here Wait for
On Tue, Aug 14, 2018 at 04:08:51PM +0800, Ming Huang wrote:
> From: Sun Yuanchen
>
> Move board level code to OemMiscLibD0x for unifying D0x.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Sun Yuanchen
> ---
>
On Tue, Aug 14, 2018 at 04:08:50PM +0800, Ming Huang wrote:
> This Driver provide Get/Set Mac function.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ming Huang
Reviewed-by: Leif Lindholm
> ---
> Platform/Hisilicon/D06/D06.dsc
Responding to v3 since that contains some of the things still problematic
in v2.
On 16 August 2018 at 13:12, Ming Huang wrote:
>
> OemNicLib provide nic related api like GetMac,SetMac.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ming Huang
> ---
>
On 8/22/2018 5:49 PM, Leif Lindholm wrote:
> On Tue, Aug 14, 2018 at 04:08:32PM +0800, Ming Huang wrote:
>> Add PcdCoreCount to fix build issue while add binary components.
>
> This commit message fails to describe what is being done, apart from a
> single thing that should be a separate
On Tue, Aug 14, 2018 at 04:08:48PM +0800, Ming Huang wrote:
> From: Heyi Guo
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Heyi Guo
Replace Heyi's Signed-off-by with your own.
Then
Reviewed-by: Leif Lindholm
> ---
> Platform/Hisilicon/D06/D06.dsc | 1 +
>
On Tue, Aug 14, 2018 at 04:08:47PM +0800, Ming Huang wrote:
> From: Heyi Guo
>
> This driver fetches information from MADT, so it is adaptable for
> partial good and 1P/2P, since MADT is updated for different
> configurations by certain mechanism.
>
> Since L2 cache is also private resource of
On Tue, Aug 14, 2018 at 04:08:46PM +0800, Ming Huang wrote:
> From: Yang XinYi
>
> Add Setup Item "EnableGOP" for D06, This Item only takes
> effect on VGA device SM750.
Feedback on v1 was:
What is SM750? Please add more detail to commit message.
Please address.
Rest of patch is fine.
/
On Tue, Aug 14, 2018 at 04:08:45PM +0800, Ming Huang wrote:
> From: shaochangliang
>
> Use I2C 400KB speed for config CDR.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ming Huang
The start of the subject line is supposed to reflect the code that is
being
On Tue, Aug 14, 2018 at 04:08:43PM +0800, Ming Huang wrote:
> Because I2C Port5 salve device connect under I2C extender
> (9545 device), it will cost more time to access I2C slave
> device, so add delay time for HNS auto config.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
>
On Tue, Aug 14, 2018 at 04:08:42PM +0800, Ming Huang wrote:
> I2C may enable failed in D06, so retry I2C enable while
> enable failed.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ming Huang
> ---
> Silicon/Hisilicon/Library/I2CLib/I2CLib.c | 18
On Tue, Aug 14, 2018 at 04:08:39PM +0800, Ming Huang wrote:
> according as watchdog design on D06, watchdog should be
> stopped before boot a option.
>
> This is an out of band watchdog timer in BMC; it is used
> to monitor the whole BIOS boot process and reset the system
> in case BIOS hangs
On Tue, Aug 14, 2018 at 04:08:38PM +0800, Ming Huang wrote:
> From: Yang XinYi
>
> This library is added for oem setup menu item.
> Setup item include:
> 1 DDR option item;
> 2 BMC option item;
> 3 Ras option item;
> 4 Misc option item;
>
> Contributed-under: TianoCore Contribution Agreement
Hi Star,
Agree, will update to that name when check in the code.
Thanks,
Eric
> -Original Message-
> From: Zeng, Star
> Sent: Wednesday, August 22, 2018 7:11 PM
> To: Dong, Eric ; edk2-devel@lists.01.org
> Cc: Zeng, Star
> Subject: RE: [Patch v2] MdeModulePkg/PiSmmCore: Check valid
On Tue, Aug 14, 2018 at 04:08:37PM +0800, Ming Huang wrote:
> ACPI tables for D06 2P, especially,Hi1620Iort.asl is include smmu
> and Hi1620IortNoSmmu.asl is without smmu.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ming Huang
As per last feedback:
Reviewed-by:
On Tue, Aug 14, 2018 at 04:08:36PM +0800, Ming Huang wrote:
> From: Heyi Guo
>
> Hi1620 have two physical PL011 serial ports on the board,
> one for serial port console (described by ACPI SPCR) and
> the other for standard debug port (described by ACPI DBG2).
> This driver is to initialize the
On Tue, Aug 14, 2018 at 04:08:35PM +0800, Ming Huang wrote:
> The EFI_ACPI_STATIC_RESOURCE_AFFINITY_TABLE struct is used by
> UpdateAcpiTable.c and Srat aslc. The struct may be different
> according to chips, so move some macro to PlatformArch.h.
>
> Contributed-under: TianoCore Contribution
(Commenting on the v3 patch since I know it supersedes the v2 patch.)
On Thu, Aug 16, 2018 at 08:12:10PM +0800, Ming Huang wrote:
> This patch is relative to D06 SasDxe driver. The SasDxe set a
> variable to notice this libray. Here Wait for all disk ready
> for 15S at most.
>
> D06:
> For using
On Tue, Aug 14, 2018 at 04:08:32PM +0800, Ming Huang wrote:
> Add PcdCoreCount to fix build issue while add binary components.
This commit message fails to describe what is being done, apart from a
single thing that should be a separate patch.
Pleas add a proper commit message describing which
Because Ecc.py was renamed to EccMain.py
Cc: Liming Gao
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Yonghong Zhu
---
BaseTools/Source/Python/Makefile | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/BaseTools/Source/Python/Makefile
Hi Liming,
On 08/17/18 04:38, Laszlo Ersek wrote:
> In commit 81502cee20ac ("BaseTools/Source/C: take EXTRA_LDFLAGS from the
> caller", 2018-08-16), I missed that "VfrCompile/GNUmakefile" does not use
> BUILD_LFLAGS in the APPLICATION linking rule, unlike "app.makefile" does.
> Instead,
On 08/22/18 09:13, Wang, Jian J wrote:
> Hi Laszlo,
>
> Regards,
> Jian
>
> From: Laszlo Ersek [mailto:ler...@redhat.com]
> Sent: Tuesday, August 21, 2018 10:59 PM
> To: Wang, Jian J ; edk2-devel@lists.01.org
> Cc: Ni, Ruiyu ; Dong, Eric
> Subject: Re: [edk2] [PATCH v2 3/4] UefiCpuPkg/CpuDxe:
current use (0x41>=~0x0&0x41|0x0) as Pcd value cause build failure
because the ~ is not correctly recognized.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Yonghong Zhu
---
BaseTools/Source/Python/Common/Expression.py | 2 +-
1 file changed, 1 insertion(+), 1
Hi Laszlo,
Thanks.
Regards,
Jian
From: Laszlo Ersek [mailto:ler...@redhat.com]
Sent: Tuesday, August 21, 2018 11:45 PM
To: Wang, Jian J ; edk2-devel@lists.01.org
Cc: Ni, Ruiyu ; Dong, Eric
Subject: Re: [edk2] [PATCH v2 4/4] UefiCpuPkg/PiSmmCpuDxeSmm: implement
non-stop mode for SMM
On
Hi Laszlo,
Regards,
Jian
From: Laszlo Ersek [mailto:ler...@redhat.com]
Sent: Tuesday, August 21, 2018 10:59 PM
To: Wang, Jian J ; edk2-devel@lists.01.org
Cc: Ni, Ruiyu ; Dong, Eric
Subject: Re: [edk2] [PATCH v2 3/4] UefiCpuPkg/CpuDxe: implement non-stop mode
for uefi
I only have some
Fixed the GCC build errors.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Yunshan Tu
Reviewed-by: David Wei
---
BuildBIOS.sh | 4 +++
.../Board/UP2/BoardInitDxe/BoardInitDxe.c | 8 +++---
Hi Laszlo,
Regards,
Jian
From: Laszlo Ersek [mailto:ler...@redhat.com]
Sent: Tuesday, August 21, 2018 10:28 PM
To: Wang, Jian J ; edk2-devel@lists.01.org
Subject: Re: [edk2] [PATCH v2 0/4] Support non-stop mode in heap guard and null
detection
On 08/21/18 05:05, Jian J Wang wrote:
>> v2
61 matches
Mail list logo
