Good idea on LocateNextAcpiTable().
> -Original Message-
> From: Ni, Ruiyu
> Sent: Saturday, September 1, 2018 12:29 AM
> To: Yao, Jiewen
> Cc: Zeng, Star ; edk2-devel@lists.01.org; Kinney, Michael
> D ; Younas khan
> ; Gao, Liming
> Subject: Re: [edk2] [PATCH 1/6] MdePkg UefiLib: Add
Hi Ming,
Thanks for the quick turnaround. The difference since v4 is
substantial.
I think this is good to go - I spotted a couple of misplaced spaces
and such, bit I think I'll let them slip.
Will wait with pushing until Monday, when my head is hopefully a bit
clearer.
Have a great weekend,
On 08/31/18 13:29, Star Zeng wrote:
> https://bugzilla.tianocore.org/show_bug.cgi?id=967
> Request to add a library function for GetAcpiTable() in order
> to get ACPI table using signature as input.
>
> After evaluation, we found there are many duplicated code to
> find ACPI table by signature in
Mike,
On 08/31/18 01:58, Henri Yandell wrote:
> The CLA is missing an ‘or’ in section 3.
>
> See https://github.com/tianocore/edk2/pull/133/files for an example of the
> specific text.
could you please turn this report into a real patch (if the suggested
change is valid)? Technically it's easy
I think LocateNextAcpiTable() is more proper to handle the multiple tables with
same signature. It will carry three parameters, one is the table header stored
in configuration table, one is the signature, another is the previous located
table. Can we return a common table header other than
I think LocateNextAcpiTable() is more proper to handle the multiple tables with
same signature. It will carry three parameters, one is the table header stored
in configuration table, one is the signature, another is the previous located
table. Can we return a common table header other than
Commit 09943f5ecc0f ("MdeModulePkg: Skip to manage usb debug port in EDKII
EHCI driver if it's used by usb debug port driver", 2012-04-28) made the
host controller reset in EhcDriverBindingStart() conditional. The intent
was to avoid the reset when
- one of the USB ports on the host controller was
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ming Huang
Reviewed-by: Leif Lindholm
---
Platform/Hisilicon/D03/D03.dsc | 2 +-
Platform/Hisilicon/D05/D05.dsc | 2 +-
Platform/Hisilicon/D06/D06.dsc | 4 ++--
3 files changed, 4 insertions(+), 4 deletions(-)
diff --git
From: ZhenYao
When BIOS booting, the power consumption is too high, so need
disable some clusters clock that don't work to reduce power
consumption.
The implementation of functions is in edk2-non-osi.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ming Huang
---
If install SPCR table, KVM will not output while install or boot
some OS, like ubuntu, so add SPCR switch setup item and set it
disable by default.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ming Huang
Reviewed-by: Leif Lindholm
---
Platform/Hisilicon/D06/D06.dsc |
Select without SMMU iort while SMMU item is disable,
Select with SMMU iort while SMMU item is enable.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ming Huang
Reviewed-by: Leif Lindholm
---
Silicon/Hisilicon/Drivers/HisiAcpiPlatformDxe/AcpiPlatformDxe.inf | 1 +
During the period of I2c accessing, if the board is reset
unexpectedly, and because the I2c client can not reset,
the SDA will be always pull down, then it cause I2C bus
Exception.
Follow the Hi1620 I2C FS chapter 1.8.2 design, add I2C
Bus Exception handle function. It will Config SCL and SDA
to
This module support updating the boot CPU firmware only.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ming Huang
Reviewed-by: Leif Lindholm
Reviewed-by: Ard Biesheuvel
---
Platform/Hisilicon/D06/D06.dsc
| 14
PciHostBridgeLib which is need by PciHostBridgeDxe, provide
root bridges and deal with resource conflict.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ming Huang
Reviewed-by: Leif Lindholm
---
Platform/Hisilicon/D06/D06.dsc | 2
From: Luqi Jiang
This driver provide a means for the platform to
convey error information to OSPM.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ming Huang
Reviewed-by: Leif Lindholm
---
Platform/Hisilicon/D06/D06.dsc | 1 +
This Driver provide Get/Set Mac function.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ming Huang
Reviewed-by: Leif Lindholm
---
Platform/Hisilicon/D06/D06.dsc | 2 +-
Platform/Hisilicon/D06/D06.fdf
This peim configures SMMU,BSP,MN(Miscellaneous Node).
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ming Huang
Reviewed-by: Leif Lindholm
---
Platform/Hisilicon/D06/D06.dsc| 1 +
Platform/Hisilicon/D06/D06.fdf
From: Heyi Guo
This driver fetches information from MADT, so it is adaptable for
partial good and 1P/2P, since MADT is updated for different
configurations by certain mechanism.
Since L2 cache is also private resource of core, so we need to set the
next level of cache for L1I and L1D, which is
OemNicLib provide nic related api like GetMac,SetMac.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ming Huang
Reviewed-by: Leif Lindholm
---
Platform/Hisilicon/D06/D06.dsc | 1 +
Platform/Hisilicon/D06/Library/OemNicLib/OemNicLib.inf | 35 ++
From: Sun Yuanchen
Move board level code to OemMiscLibD0x for unifying D0x.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ming Huang
Reviewed-by: Leif Lindholm
---
Platform/Hisilicon/D03/Library/OemMiscLib2P/OemMiscLib2PHi1610.inf | 1 +
From: Heyi Guo
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ming Huang
Reviewed-by: Leif Lindholm
---
Platform/Hisilicon/D06/D06.dsc | 1 +
Platform/Hisilicon/D06/D06.fdf | 2 ++
2 files changed, 3 insertions(+)
diff --git a/Platform/Hisilicon/D06/D06.dsc
This patch is relative to D06 SasDxe driver. The SasDxe set a
variable to notice this libray. Here Wait for all disk ready
for 15S at most.
D06:
For using straight-through hard disk backboard, some disk need
15 seconds to ready. Actually, wait less 15 seconds here(minus
the time from end of SAS
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ming Huang
Reviewed-by: Leif Lindholm
---
Platform/Hisilicon/D06/D06.dsc | 7 +++
Platform/Hisilicon/D06/D06.fdf | 17 +
2 files changed, 24 insertions(+)
diff --git a/Platform/Hisilicon/D06/D06.dsc
These modules depend on some binary modules, like IpmiCmdLib,
PlatformSysCtrlLib. So add these modules after adding binary
components.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ming Huang
---
Platform/Hisilicon/D06/D06.dsc | 13 +
according as watchdog design on D06, watchdog should be
stopped before boot a option.
This is an out of band watchdog timer in BMC; it is used
to monitor the whole BIOS boot process and reset the system
in case BIOS hangs somewhere, i.e. it is armed when system
is power on, and disabled before
Add M41T83RealTimeClockLib for RTC.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ming Huang
Reviewed-by: Leif Lindholm
---
Platform/Hisilicon/D06/D06.dsc |
1 +
From: Yang XinYi
Add Setup Item "EnableGOP" for D06, This Item only takes
effect on SM750. The SM750 is a VGA device under BMC and
the KVM output to SM750.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ming Huang
Reviewed-by: Leif Lindholm
---
From: Heyi Guo
Hi1620 have two physical PL011 serial ports on the board,
one for serial port console (described by ACPI SPCR) and
the other for standard debug port (described by ACPI DBG2).
This driver is to initialize the debug UART, not the serial
console.
Contributed-under: TianoCore
From: Yang XinYi
This library is added for oem setup menu item.
Setup item include:
1 DDR option item;
2 BMC option item;
3 Ras option item;
4 Misc option item;
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ming Huang
Reviewed-by: Leif Lindholm
---
The tail "|VOID*|0x0001006b" is no need for PcdBootManagerMenuFile,
and build failed with that, so remove it.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ming Huang
---
Platform/Hisilicon/D03/D03.dsc | 2 +-
Platform/Hisilicon/D05/D05.dsc | 2 +-
2 files changed, 2
The EFI_ACPI_STATIC_RESOURCE_AFFINITY_TABLE struct is used by
UpdateAcpiTable.c and Srat aslc. The struct may be different
according to chips, so move some macro to PlatformArch.h.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ming Huang
Reviewed-by: Leif Lindholm
---
From: Sun Yuanchen
Move some RAS macros definition to PlatformArch.h for
unifying D0x
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ming Huang
Reviewed-by: Leif Lindholm
---
Silicon/Hisilicon/Hi1610/Include/PlatformArch.h | 9 +++--
This library include BoardFeatureD06.c and OemMiscLibD06.c c file,
use for several modules like PciHostBridgeLib and Smbios.
Enlarge macro PCIEDEVICE_REPORT_MAX for D06.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ming Huang
Reviewed-by: Leif Lindholm
---
The major features of this patchset include:
1 D06 source code;
2 Unify some D0x modules;
Change since v4:
1 build on every commit:
Squash "Add PciPlatformLib" to "Add several base file for D06";
Reorder OemMiscLibD06 before "Add edk2-non-osi components for D06";
Move some mudules after
Add several base head files and add several build
files for D06.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ming Huang
Reviewed-by: Leif Lindholm
---
Platform/Hisilicon/D06/D06.dec
| 29 ++
On 08/30/18 22:17, aaron.yo...@oracle.com wrote:
> We have encountered what we believe to be a regression in the
> OvmfPkg/VirtioNetDxe driver.
>
> This regression causes PXE boot to fail with the following ASSERT:
>
> ASSERT
>
Good enhancement.
I have 2 additional thought:
1) How to handle DSDT?
We have special code to handle FACS, but no DSDT.
2) How to handle SSDT or other multiple ACPI tables?
We may have multiple SSDT. Usually, it is identified as OEMID.
Do we want to provide similar function for them?
Anyway,
https://bugzilla.tianocore.org/show_bug.cgi?id=967
Request to add a library function for GetAcpiTable() in order
to get ACPI table using signature as input.
After evaluation, we found there are many duplicated code to
find ACPI table by signature in different modules.
This patch updates
https://bugzilla.tianocore.org/show_bug.cgi?id=967
Request to add a library function for GetAcpiTable() in order
to get ACPI table using signature as input.
After evaluation, we found there are many duplicated code to
find ACPI table by signature in different modules.
This patch updates
https://bugzilla.tianocore.org/show_bug.cgi?id=967
Request to add a library function for GetAcpiTable() in order
to get ACPI table using signature as input.
After evaluation, we found there are many duplicated code to
find ACPI table by signature in different modules.
This patch updates
https://bugzilla.tianocore.org/show_bug.cgi?id=967
Request to add a library function for GetAcpiTable() in order
to get ACPI table using signature as input.
After evaluation, we found there are many duplicated code to
find ACPI table by signature in different modules.
This patch updates
https://bugzilla.tianocore.org/show_bug.cgi?id=967
Request to add a library function for GetAcpiTable() in order
to get ACPI table using signature as input.
After evaluation, we found there are many duplicated code to
find ACPI table by signature in different modules.
This patch updates
https://bugzilla.tianocore.org/show_bug.cgi?id=967
Request to add a library function for GetAcpiTable() in order
to get ACPI table using signature as input.
After evaluation, we found there are many duplicated code to
find ACPI table by signature in different modules.
This patch adds new
The code for this patch series is also at
g...@github.com:lzeng14/edk2.git branch FindAcpiTableBySignature_UefiLib
https://bugzilla.tianocore.org/show_bug.cgi?id=967
Request to add a library function for GetAcpiTable() in order
to get ACPI table using signature as input.
After evaluation, we
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Guo Mang
---
Platform/BroxtonPlatformPkg/BiosId.env | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/Platform/BroxtonPlatformPkg/BiosId.env
b/Platform/BroxtonPlatformPkg/BiosId.env
index
Reviewed-by: Ye Ting
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Jiaxin Wu
Sent: Friday, August 31, 2018 9:50 AM
To: edk2-devel@lists.01.org
Cc: Ye, Ting ; Fu, Siyuan ; Wu, Jiaxin
Subject: [edk2] [Patch] MdeModulePkg/Ip4Dxe: Sync the
Hi Siyuan,
Please fix below typo when check in the patch. "...cancelled"
Callback function when ARP request are finished. It will cancelled @@
-814,6 +897,7 @@ Ip4OnArpResolvedDpc (
Also do we need define a macro for "0x"/"0xu" used in Mtftp4
and ifconfig?
Reviewed-by:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1128
When an exception happens in AP, system hangs at
GetPeiServicesTablePointer(), complaining the PeiServices retrieved
from memory before IDT is NULL.
Due to the following commit:
c563077a380437c114aba4c95be65eb963ebc1f3
*
Today's implementation of handling HOOK_BEFORE and HOOK_AFTER is
a bit complex. More comments is better.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ruiyu Ni
Cc: Fan Jeff
Cc: Jian J Wang
---
.../CpuExceptionHandlerLib/Ia32/ArchExceptionHandler.c | 8 +---
1st patch adds more comments to the code to make it more readable.
2nd patch fixes the real assertion issue.
Ruiyu Ni (2):
CpuExceptionHandlerLib: Add comments to make code more readable
UefiCpuPkg/CpuExceptionHandlerLib: Avoid calling PEI services from AP
Reveiewed-by: Ye Ting
-Original Message-
From: Fu, Siyuan
Sent: Tuesday, August 28, 2018 9:53 AM
To: edk2-devel@lists.01.org
Cc: Ni, Ruiyu ; Ye, Ting ; Wu, Jiaxin
Subject: [Patch 2/2] ShellPkg: Update Ifconfig command to accept 32bit subnet
mask.
Contributed-under: TianoCore
On 8/31/2018 12:15 AM, Leif Lindholm wrote:
> On Fri, Aug 24, 2018 at 12:07:42AM +0800, Ming Huang wrote:
>> Add a Null PciPlatformLib for build D06. The switch generic
>> PciHostBridge patch set add two api for PciPlatform driver,
>> so need to implement the two api for D06.
>>
>>
52 matches
Mail list logo
