Re: [edk2] [PATCH 0/7] SdMmc fixes and SdMmcOverride extension

2018-09-04 Thread Wu, Hao A
Hi, I will take a look into this series. It might take me some time for the review, please help to ping this mail thread if there is no response from me in 2 weeks. Sorry for the possible delay. Also, cc Ard in the list to see if he has any comment on this. As Ard is the contributor of the SD/MMC

[edk2] [Patch] UefiCpuPkg/MpInitLib: Fix ECC issues.

2018-09-04 Thread Eric Dong
Fix trailing white spaces and invalid line ending issue. Cc: Dandan Bi Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Eric Dong --- UefiCpuPkg/Library/MpInitLib/MpLib.c | 2 +- UefiCpuPkg/Library/MpInitLib/MpLib.h

Re: [edk2] [PATCH 3/4] UefiCpuPkg/MpInitLib: fix register restore issue in AP wakeup

2018-09-04 Thread Dong, Eric
Reviewed-by: Eric Dong > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] > Sent: Monday, September 3, 2018 11:16 AM > To: edk2-devel@lists.01.org > Cc: Ni, Ruiyu ; Dong, Eric ; Yao, > Jiewen ; Laszlo Ersek ; Zeng, > Star > Subject: [edk2] [PATCH 3/4] UefiCp

Re: [edk2] [PATCH] MdeModulePkg: Remove trailing white space

2018-09-04 Thread Bi, Dandan
Reviewed-by: Dandan Bi Thanks, Dandan -Original Message- From: Zeng, Star Sent: Wednesday, September 5, 2018 10:01 AM To: edk2-devel@lists.01.org Cc: Zeng, Star ; Bi, Dandan ; Gao, Liming ; Wang, Jian J ; Fu, Siyuan ; Wu, Jiaxin Subject: [PATCH] MdeModulePkg: Remove trailing white s

[edk2] [Patch] BaseTools: Fix the RaiseError variable issue caused by 855698fb69f

2018-09-04 Thread Yonghong Zhu
The bug is that it cause the RaiseError always be set to TRUE even we call the function with FALSE parameter. Cc: Hess Chen Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Yonghong Zhu --- BaseTools/Source/Python/Common/EdkLogger.py | 4 ++-- 1 file change

[edk2] [Patch] BaseTools: Fix a bug about list the PCD in "not used" section

2018-09-04 Thread Yonghong Zhu
From: zhijufan Defined a pcd in Ovmf.dec and used that pcd in AcpiPlatformDxe.inf, then assign a value to that pcd from DSC, then build Ovmf platform successfully. But this Pcd was wrongly listed into not used section in the report.txt file. Cc: Liming Gao Cc: Yonghong Zhu Contributed-under: T

Re: [edk2] [PATCH] MdeModulePkg: Remove trailing white space

2018-09-04 Thread Fu, Siyuan
Reviewed-by: Fu Siyuan > -Original Message- > From: Zeng, Star > Sent: Wednesday, September 5, 2018 10:01 AM > To: edk2-devel@lists.01.org > Cc: Zeng, Star ; Bi, Dandan ; > Gao, Liming ; Wang, Jian J ; > Fu, Siyuan ; Wu, Jiaxin > Subject: [PATCH] MdeModulePkg: Remove trailing white space

[edk2] [PATCH] MdeModulePkg: Remove trailing white space

2018-09-04 Thread Star Zeng
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1144 Cc: Dandan Bi Cc: Liming Gao Cc: Jian J Wang Cc: Siyuan Fu Cc: Jiaxin Wu Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Star Zeng --- MdeModulePkg/Core/Pei/Ppi/Ppi.c| 4 +-- MdeModulePkg/In

[edk2] [Patch] MdeModulePkg PeiCore: Remove the copy logic for PeiImageRead function

2018-09-04 Thread Liming Gao
The copy PeiImageRead function doesn't improve the boot performance. This patch removes this copy logic to simplify the code logic. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Liming Gao --- MdeModulePkg/Core/Pei/Image/Image.c | 65 +

Re: [edk2] [Patch] BaseTools: Report more clear error message for PCD used in expression

2018-09-04 Thread Zhu, Yonghong
Reviewed-by: Yonghong Zhu Best Regards, Zhu Yonghong -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Yonghong Zhu Sent: Tuesday, September 04, 2018 3:16 PM To: edk2-devel@lists.01.org Cc: Gao, Liming Subject: [edk2] [Patch] BaseTools: Report

Re: [edk2] [PATCH] MdeModulePkg PeiCore: Fix VS2012 build failure

2018-09-04 Thread Bi, Dandan
Reviewed-by: Dandan Bi Thanks, Dandan -Original Message- From: Zeng, Star Sent: Tuesday, September 4, 2018 9:18 AM To: edk2-devel@lists.01.org Cc: Zeng, Star ; Bi, Dandan ; Gao, Liming ; Wang, Jian J Subject: [PATCH] MdeModulePkg PeiCore: Fix VS2012 build failure fwvol.c(1572) : warni

Re: [edk2] [staging/MicroPythonTestFramework][PATCH] MpyTestFrameworkPkg: use minified jquery source

2018-09-04 Thread Long, Qin
Reviewed-by: Long Qin Best Regards & Thanks, LONG, Qin > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Stephano Cetola > Sent: Tuesday, September 4, 2018 10:51 AM > To: edk2-devel@lists.01.org > Cc: Long, Qin > Subject: [edk2] [staging/Mi

[edk2] [staging/MicroPythonTestFramework][PATCH] MpyTestFrameworkPkg: use minified jquery source

2018-09-04 Thread Stephano Cetola
We should be using the compressed "minified" jquery source file rather than the uncompressed version, as it will reduce the page load times. This updates the relevant FreeMaker templates, the readme, and the setup script. It also corrects a small mistake in the error text of the setup script. Con

Re: [edk2] [PATCH v2 00/12] Add WinHost support in EmulatorPkg

2018-09-04 Thread Kinney, Michael D
Krishna, I agree this type of information is very useful. I recommend that the Readme.md in the EmulatorPkg contain a brief summary and basic instructions to build and run. It should also provide a pointer to the EmulatorPkg Wiki page for additional details on the design and implementation. http

Re: [edk2] [Patch] BaseTools: Involve Dec default value to calculate Maxsize

2018-09-04 Thread Carsey, Jaben
Reviewed-by: Jaben Carsey > -Original Message- > From: Feng, Bob C > Sent: Sunday, September 02, 2018 6:06 PM > To: edk2-devel@lists.01.org > Cc: Gao, Liming ; Zhu, Yonghong > ; Carsey, Jaben ; > Feng, Bob C > Subject: [Patch] BaseTools: Involve Dec default value to calculate Maxsize > I

Re: [edk2] [Patch] MdeModulePkg/Library/DxeHttpLib: Handle the blank value in HTTP header.

2018-09-04 Thread Stephen Benjamin
On Tue, Sep 4, 2018 at 7:02 AM Laszlo Ersek wrote: > > On 09/04/18 09:17, Jiaxin Wu wrote: > > This patch is to resolve the lock-up issue if the value of HTTP header > > is blank. The issue is recorded @ > > https://bugzilla.tianocore.org/show_bug.cgi?id=1102. > > > > Cc: Stephen Benjamin > > Cc

Re: [edk2] [PATCH] EmulatorPkg: Update package level Readme.md

2018-09-04 Thread Wu, Hao A
Reviewed-by: Hao Wu Best Regards, Hao Wu > -Original Message- > From: Ni, Ruiyu > Sent: Tuesday, September 04, 2018 9:19 AM > To: edk2-devel@lists.01.org > Cc: Kinney, Michael D; Wu, Hao A > Subject: [PATCH] EmulatorPkg: Update package level Readme.md > > Since the emulator under Windo

Re: [edk2] [Patch] MdeModulePkg/Library/DxeHttpLib: Handle the blank value in HTTP header.

2018-09-04 Thread Laszlo Ersek
On 09/04/18 09:17, Jiaxin Wu wrote: > This patch is to resolve the lock-up issue if the value of HTTP header > is blank. The issue is recorded @ > https://bugzilla.tianocore.org/show_bug.cgi?id=1102. > > Cc: Stephen Benjamin > Cc: Laszlo Ersek > Cc: Ye Ting > Cc: Fu Siyuan > Contributed-under

Re: [edk2] [PATCH] MdeModulePkg/EhciDxe: fix host controller reset condition in BindingStart

2018-09-04 Thread Laszlo Ersek
On 09/04/18 03:27, Zeng, Star wrote: > Oh, yes. Got the point, the patch is correct indeed. :) > Thanks for the explanation. > > Maybe, an abstracted function will make the logic more clear, like > EhcIsDebugPortInUse(). > What do you think? Haha, I thought of almost exactly the same name (just "I

[edk2] [PATCH] BaseTools: Check the index of array.

2018-09-04 Thread Zhaozh1x
For structure PCD, add the checker for the ARRAY element assignment and Buffer FieldSize. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: ZhiqiangX Zhao Cc: Liming Gao Cc: Yonghong Zhu Cc: Bob Feng --- BaseTools/Source/C/Common/PcdValueCommon.h| 7 +++ BaseT

Re: [edk2] [PATCH] Emulator/Win: Fix build failure using VS2015x86

2018-09-04 Thread Wu, Hao A
Reviewed-by: Hao Wu Best Regards, Hao Wu > -Original Message- > From: Ni, Ruiyu > Sent: Tuesday, September 04, 2018 9:19 AM > To: edk2-devel@lists.01.org > Cc: Kinney, Michael D; Wu, Hao A > Subject: [PATCH] Emulator/Win: Fix build failure using VS2015x86 > > Contributed-under: TianoCo

[edk2] [PATCH] BaseTools: SKU inheritance.

2018-09-04 Thread Zhaozh1x
If the SkuB’s parent SkuA is not in SKUID_IDENTIFIER, then make SkuB inherit from SkuA as if the SKUID_INDENTIFIER is ALL. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: ZhiqiangX Zhao Cc: Liming Gao Cc: Yonghong Zhu Cc: Bob Feng --- BaseTools/Source/Python/Workspace/D

[edk2] [Patch v2] MdeModulePkg/Ip4Dxe: Sync the direct route entry setting.

2018-09-04 Thread Jiaxin Wu
v2: use "IP & Netmask" directly instead of defining an additional variable. This patch is to sync the direct route entry setting in both the default and Instance route table {Subnet, Mask, NextHope} ( https://bugzilla.tianocore.org/show_bug.cgi?id=1143). Cc: Ye Ting Cc: Fu Siyuan Contributed-un

[edk2] [Patch] MdeModulePkg/Library/DxeHttpLib: Handle the blank value in HTTP header.

2018-09-04 Thread Jiaxin Wu
This patch is to resolve the lock-up issue if the value of HTTP header is blank. The issue is recorded @ https://bugzilla.tianocore.org/show_bug.cgi?id=1102. Cc: Stephen Benjamin Cc: Laszlo Ersek Cc: Ye Ting Cc: Fu Siyuan Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by:

[edk2] [Patch] BaseTools: Report more clear error message for PCD used in expression

2018-09-04 Thread Yonghong Zhu
From: zhijufan Only the FeatureFlag type or FixedAtBuild type can be used in the expression. Cc: Liming Gao Cc: Yonghong Zhu Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Zhiju.Fan --- BaseTools/Source/Python/Common/Expression.py | 2 +- BaseTools/Source/Python/

[edk2] [PATCH] BaseTools: Check PcdNvStoreDefaultValueBuffer.

2018-09-04 Thread Zhaozh1x
Build tool should report warning if a platform defines [DefaultStores] but forgets to defined PcdNvStoreDefaultValueBuffer as PcdsDynamicExVpd in dsc file. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: ZhiqiangX Zhao Cc: Liming Gao Cc: Yonghong Zhu Cc: Bob Feng --- Ba