[edk2] [PATCH] MdePkg UefiPciSegmentLibPciRootBridgeIo: Remove redundant dependency

2018-09-17 Thread shenglei
PiDxe.h is not used PciSegmentLib.h. So "#include " is deleted. https://bugzilla.tianocore.org/show_bug.cgi?id=1183 Cc: Michael D Kinney Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: shenglei ---

[edk2] [PATCH] MdePkg UefiPciLibPciRootBridgeIo: Remove redundant dependency

2018-09-17 Thread shenglei
PiDxe.h is not used PciSegmentLib.h. So "#include " is deleted. https://bugzilla.tianocore.org/show_bug.cgi?id=1183 Cc: Michael D Kinney Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: shenglei --- MdePkg/Library/UefiPciLibPciRootBridgeIo/PciLib.c | 2 --

Re: [edk2] [Patch 00/14] Update MSR definitions.

2018-09-17 Thread Ni, Ruiyu
On 9/18/2018 9:43 AM, Eric Dong wrote: Current MSR definition are follow the SDM 2016-09 version. The latest SDM is 2018-05. This patch serial update the MSR related definition to follow the latest SDM 2018-05 version. MSR related defintion are saved at UefiCpuPkg\Include\Register\. The changes

[edk2] [Patch 01/14] UefiCpuPkg/Include/Register/Msr: Update reference spec info.

2018-09-17 Thread Eric Dong
Latest SDM has moved MSR related content from volume 3 chapter 35 to volume 4 chapter 2. Current MSR's comments need to be updated to reference the new chapter info. Changes includes: 1. Update referenced chapter info from some MSRs. 2. Update referenced SDM version info. Cc: Michael D

[edk2] [Patch 02/14] UefiCpuPkg/Include/Register/Msr/GoldmontPlusMsr.h: Add new MSR file for goldmont plus microarchitecture.

2018-09-17 Thread Eric Dong
Changes includes: 1. Add new MSR file which used for goldmont plus microarchitecture. Cc: Michael D Kinney Cc: Ruiyu Ni Cc: Laszlo Ersek Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Eric Dong --- UefiCpuPkg/Include/Register/Msr.h | 7 +-

[edk2] [Patch 09/14] UefiCpuPkg/Include/Register/Msr/Core2Msr.h: Remove old MSR.

2018-09-17 Thread Eric Dong
Changes includes: 1. Remove old MSR which not existed in 2018-05 version spec: 1. MSR_CORE2_BBL_CR_CTL3 Cc: Michael D Kinney Cc: Ruiyu Ni Cc: Laszlo Ersek Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Eric Dong --- UefiCpuPkg/Include/Register/Msr/Core2Msr.h |

[edk2] [Patch 12/14] UefiCpuPkg/Include/Register/Msr/SkylakeMsr.h: Add new MSR name and keep old one.

2018-09-17 Thread Eric Dong
Changes includes: 1. Change MSR name: 1. MSR_SKYLAKE_SGXOWNER0 => MSR_SKYLAKE_SGXOWNEREPOCH0 2. MSR_SKYLAKE_SGXOWNER1 => MSR_SKYLAKE_SGXOWNEREPOCH1 2. Keep old MSR definition(MSR_SKYLAKE_SGXOWNER0/1) for compatibility 1. Use below coding style to define old MSR #define

[edk2] [Patch 14/14] UefiCpuPkg/Include/Register/Msr/XeonPhiMsr.h: Change structure definition.

2018-09-17 Thread Eric Dong
Changes includes: 1. Update MSR structure definition, change some reserved fields to useful fields: 1. MSR_XEON_PHI_PKG_CST_CONFIG_CONTROL_REGISTER 2. MSR_XEON_PHI_SMM_MCA_CAP_REGISTER 2. For MSR_XEON_PHI_PMG_IO_CAPTURE_BASE_REGISTER structure, it expand the field range. Old

[edk2] [Patch 13/14] UefiCpuPkg/Include/Register/Msr/GoldmontMsr.h: Add new MSR name and keep old one.

2018-09-17 Thread Eric Dong
Changes includes: 1. Change MSR name: 1. MSR_GOLDMONT_SGXOWNER0 => MSR_GOLDMONT_SGXOWNEREPOCH0 2. MSR_GOLDMONT_SGXOWNER1 => MSR_GOLDMONT_SGXOWNEREPOCH1 2. Keep old MSR definition (MSR_GOLDMONT_SGXOWNER0/1) for compatibility. 1. Define old MSR like below style: #define

[edk2] [Patch 08/14] UefiCpuPkg/Include/Register/ArchitecturalMsr.h: Change structure definition.

2018-09-17 Thread Eric Dong
Changes includes: 1. Change fields which is reserved in old version: MSR_IA32_RTIT_CTL_REGISTER Cc: Michael D Kinney Cc: Ruiyu Ni Cc: Laszlo Ersek Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Eric Dong --- UefiCpuPkg/Include/Register/ArchitecturalMsr.h | 22

[edk2] [Patch 11/14] UefiCpuPkg/Include/Register/Msr/CoreMsr.h: Remove old MSR.

2018-09-17 Thread Eric Dong
Changes includes: 1. Remove old MSR which not existed in 2018-05 version spec: 1. MSR_CORE_ROB_CR_BKUPTMPDR6 Cc: Michael D Kinney Cc: Ruiyu Ni Cc: Laszlo Ersek Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Eric Dong ---

[edk2] [Patch 05/14] UefiCpuPkg/Include/Register/Msr/XeonPhiMsr.h: Add new MSR.

2018-09-17 Thread Eric Dong
Changes includes: 1. Add new MSR definition: 1. MSR_XEON_PHI_PPIN_CTL 2. MSR_XEON_PHI_PPIN 3. MSR_XEON_PHI_MISC_FEATURE_ENABLES 4. MSR_XEON_PHI_MSRUNCORE_RATIO_LIMIT 2. Add DisplayModule == 0x85 supports. Cc: Michael D Kinney Cc: Ruiyu Ni Cc: Laszlo Ersek

[edk2] [Patch 07/14] UefiCpuPkg/Include/Register/ArchitecturalMsr.h: Add new MSR.

2018-09-17 Thread Eric Dong
Changes includes: 1. Add new MSRs: MSR_IA32_L2_QOS_CFG/MSR_IA32_CSTAR. Cc: Michael D Kinney Cc: Ruiyu Ni Cc: Laszlo Ersek Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Eric Dong --- UefiCpuPkg/Include/Register/ArchitecturalMsr.h | 64 ++ 1

[edk2] [Patch 10/14] UefiCpuPkg/Include/Register/Msr/P6Msr.h: Remove old MSR.

2018-09-17 Thread Eric Dong
Changes includes: 1. Remove MSR which not existed in 2018-05 version spec: MSR_P6_ROB_CR_BKUPTMPDR6. Cc: Michael D Kinney Cc: Ruiyu Ni Cc: Laszlo Ersek Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Eric Dong --- UefiCpuPkg/Include/Register/Msr/P6Msr.h | 48

[edk2] [Patch 04/14] UefiCpuPkg/Include/Register/Msr/*.h: Add new MSR.

2018-09-17 Thread Eric Dong
Changes includes: 1. Add new MSR: MSR_*_MSRUNCORE_RATIO_LIMIT Cc: Michael D Kinney Cc: Ruiyu Ni Cc: Laszlo Ersek Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Eric Dong --- UefiCpuPkg/Include/Register/Msr/BroadwellMsr.h | 54 +

[edk2] [Patch 00/14] Update MSR definitions.

2018-09-17 Thread Eric Dong
Current MSR definition are follow the SDM 2016-09 version. The latest SDM is 2018-05. This patch serial update the MSR related definition to follow the latest SDM 2018-05 version. MSR related defintion are saved at UefiCpuPkg\Include\Register\. The changes for this serial includes: 1. Add new MSR

[edk2] [Patch 03/14] UefiCpuPkg/Include/Register/Msr/SilvermontMsr.h: Add new MSR.

2018-09-17 Thread Eric Dong
Changes includes: 1. Add new MSR: MSR_SILVERMONT_PLATFORM_INFO Cc: Michael D Kinney Cc: Ruiyu Ni Cc: Laszlo Ersek Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Eric Dong --- UefiCpuPkg/Include/Register/Msr/SilvermontMsr.h | 48 + 1 file

Re: [edk2] [PATCH v3 2/3] MdeModulePkg/SdMmcPciHcDxe: Fix SdMmcHcReset to set only necesery bits

2018-09-17 Thread Wu, Hao A
> -Original Message- > From: Marcin Wojtas [mailto:m...@semihalf.com] > Sent: Monday, September 17, 2018 11:00 PM > To: Wu, Hao A > Cc: edk2-devel-01; Tomasz Michalec; nad...@marvell.com; Gao, Liming; > Kinney, Michael D > Subject: Re: [edk2] [PATCH v3 2/3] MdeModulePkg/SdMmcPciHcDxe: Fix

Re: [edk2] [Patch] MdeModulePkg/Ip4Dxe: Refine the coding style.

2018-09-17 Thread Bi, Dandan
Reviewed-by: Dandan Bi Thanks, Dandan -Original Message- From: Wu, Jiaxin Sent: Monday, September 17, 2018 11:14 AM To: edk2-devel@lists.01.org Cc: Ye, Ting ; Fu, Siyuan ; Bi, Dandan ; Wu, Jiaxin Subject: [Patch] MdeModulePkg/Ip4Dxe: Refine the coding style. Ref:

Re: [edk2] [PATCH] MdeModulePkg/DxeIpl: support more NX related PCDs

2018-09-17 Thread Wang, Jian J
I have no strong opinion for this proposal. But if we decide to do it finally, I'd suggest to add some warning messages for any probably surprising setting combinations. Regards, Jian > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Monday, September 17, 2018

Re: [edk2] [PATCH v3 1/3] MdeModulePkg/SdMmcPciHcDxe: Adjust eMMC clock and bus width sequence

2018-09-17 Thread Marcin Wojtas
Hi Hao, pon., 17 wrz 2018 o 09:18 Wu, Hao A napisał(a): > > > -Original Message- > > From: Marcin Wojtas [mailto:m...@semihalf.com] > > Sent: Sunday, September 16, 2018 6:26 AM > > To: edk2-devel@lists.01.org > > Cc: Tian, Feng; Kinney, Michael D; Gao, Liming; leif.lindh...@linaro.org;

Re: [edk2] [Patch 3/5] ShellPkg/TftpDynamicCommand: Add one option for tftp command to specify windowsize.

2018-09-17 Thread Carsey, Jaben
Reviewed-by: Jaben Carsey > -Original Message- > From: Wu, Jiaxin > Sent: Sunday, September 16, 2018 10:44 PM > To: edk2-devel@lists.01.org > Cc: Ye, Ting ; Fu, Siyuan ; Carsey, > Jaben ; Shao, Ming ; Wu, > Jiaxin > Subject: [Patch 3/5] ShellPkg/TftpDynamicCommand: Add one option for

Re: [edk2] [PATCH] UefiCpuPkg/MtrrLib: Add flag to skip disabling MTRRs prior to MTRR change.

2018-09-17 Thread Laszlo Ersek
On 09/17/18 18:20, Duran, Leo wrote: > >> -Original Message- >> From: Ni, Ruiyu >> Sent: Thursday, September 13, 2018 11:44 PM >> To: Duran, Leo ; Laszlo Ersek ; >> edk2-devel@lists.01.org >> Cc: Dong, Eric >> Subject: Re: [edk2] [PATCH] UefiCpuPkg/MtrrLib: Add flag to skip disabling >>

Re: [edk2] [PATCH] UefiCpuPkg/MtrrLib: Add flag to skip disabling MTRRs prior to MTRR change.

2018-09-17 Thread Duran, Leo
> -Original Message- > From: Ni, Ruiyu > Sent: Thursday, September 13, 2018 11:44 PM > To: Duran, Leo ; Laszlo Ersek ; > edk2-devel@lists.01.org > Cc: Dong, Eric > Subject: Re: [edk2] [PATCH] UefiCpuPkg/MtrrLib: Add flag to skip disabling > MTRRs prior to MTRR change. > > On 9/14/2018

Re: [edk2] [PATCH v3 3/3] MdeModulePkg/SdMmcPciHcDxe: Execute card detect only for RemovableSlot

2018-09-17 Thread Marcin Wojtas
Hi Hao, pon., 17 wrz 2018 o 09:18 Wu, Hao A napisał(a): > > Hi, > > Could you help to file a EDK2 Bugzilla tracker at: > https://bugzilla.tianocore.org/enter_bug.cgi?product=EDK2 > > to have a general description of the issue you met? And reference the > tracker within the commit message? >

Re: [edk2] [PATCH v3 2/3] MdeModulePkg/SdMmcPciHcDxe: Fix SdMmcHcReset to set only necesery bits

2018-09-17 Thread Marcin Wojtas
Hi Hao, pon., 17 wrz 2018 o 09:17 Wu, Hao A napisał(a): > > > -Original Message- > > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > > Marcin Wojtas > > Sent: Sunday, September 16, 2018 6:26 AM > > To: edk2-devel@lists.01.org > > Cc: Tian, Feng;

[edk2] [Patch][edk2-platforms/devel-MinnowBoardMax-UDK2017] Produce SMBIOS type 1

2018-09-17 Thread Guo, Mang
Produce SMBIOS type 1 table before ready to boot event so BDS driver can get product name, CUP info from SMBIOS table and show the info in front page before boot. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Guo Mang CC: David Wei ---

Re: [edk2] bootloader only see first disk

2018-09-17 Thread Aurelien Minet
Hi Thomas, Le 17/09/2018 à 10:34, Thomas Lamprecht a écrit : > Hi Laszlo, > > On 9/16/18 12:04 PM, Laszlo Ersek wrote: >> Hello Aurélien, >> >> adding Thomas to the CC list, and commenting at the bottom: > thanks for CC'ing and thanks to you Aurélien for writing your report. > >> On 09/15/18

[edk2] bootloader only see first disk

2018-09-17 Thread Aurelien
Hi Laszlo, On 16/09/2018 12:04, Laszlo Ersek wrote: > Hello Aurélien, > > adding Thomas to the CC list, and commenting at the bottom: > > On 09/15/18 18:36, Aurélien wrote: >> Hi, >> >> I don't know if it is the right place to report a bug, sorry if not. >> >> I'm a Promox user and the last

Re: [edk2] [PATCH] MdeModulePkg/DxeIpl: support more NX related PCDs

2018-09-17 Thread Laszlo Ersek
On 09/17/18 07:57, Zeng, Star wrote: > How about we see the problem in another way? > > If my understanding is correct, current discussion and patches think FALSE/0 > means disable/clear NX, but that is not the fact. > According to the code implementation, FALSE/0 seems mean *AS IS* to do thing

Re: [edk2] [PATCH V3 1/6] MdePkg UefiLib: Add new EfiLocateXXXAcpiTable() APIs

2018-09-17 Thread Ni, Ruiyu
On 9/17/2018 5:08 PM, Star Zeng wrote: https://bugzilla.tianocore.org/show_bug.cgi?id=967 Request to add a library function for GetAcpiTable() in order to get ACPI table using signature as input. After evaluation, we found there are many duplicated code to find ACPI table by signature in

Re: [edk2] [PATCH V3 4/6] PcAtChipsetPkg PcRtc: Use new EfiLocateFirstAcpiTable()

2018-09-17 Thread Ni, Ruiyu
On 9/17/2018 5:08 PM, Star Zeng wrote: https://bugzilla.tianocore.org/show_bug.cgi?id=967 Request to add a library function for GetAcpiTable() in order to get ACPI table using signature as input. After evaluation, we found there are many duplicated code to find ACPI table by signature in

[edk2] [PATCH V3 4/6] PcAtChipsetPkg PcRtc: Use new EfiLocateFirstAcpiTable()

2018-09-17 Thread Star Zeng
https://bugzilla.tianocore.org/show_bug.cgi?id=967 Request to add a library function for GetAcpiTable() in order to get ACPI table using signature as input. After evaluation, we found there are many duplicated code to find ACPI table by signature in different modules. This patch updates

[edk2] [PATCH V3 3/6] MdeModulePkg S3SaveStateDxe: Use new EfiLocateFirstAcpiTable()

2018-09-17 Thread Star Zeng
https://bugzilla.tianocore.org/show_bug.cgi?id=967 Request to add a library function for GetAcpiTable() in order to get ACPI table using signature as input. After evaluation, we found there are many duplicated code to find ACPI table by signature in different modules. This patch updates

[edk2] [PATCH V3 2/6] IntelSiliconPkg IntelVTdDxe: Use new EfiLocateFirstAcpiTable()

2018-09-17 Thread Star Zeng
https://bugzilla.tianocore.org/show_bug.cgi?id=967 Request to add a library function for GetAcpiTable() in order to get ACPI table using signature as input. After evaluation, we found there are many duplicated code to find ACPI table by signature in different modules. This patch updates

[edk2] [PATCH V3 5/6] ShellPkg DpDynamicCommand: Use new EfiLocateFirstAcpiTable()

2018-09-17 Thread Star Zeng
https://bugzilla.tianocore.org/show_bug.cgi?id=967 Request to add a library function for GetAcpiTable() in order to get ACPI table using signature as input. After evaluation, we found there are many duplicated code to find ACPI table by signature in different modules. This patch updates

[edk2] [PATCH V3 0/6] Add new EfiLocateXXXAcpiTable() APIs

2018-09-17 Thread Star Zeng
It is the V3 patch series of https://lists.01.org/pipermail/edk2-devel/2018-August/029214.html It is according to the discussion at https://lists.01.org/pipermail/edk2-devel/2018-September/029750.html V3: 1. Pick Ray/Laszlo/Eric's RB. 2. Remove ASSERT about Signature check. 3. Merge

[edk2] [PATCH V3 6/6] UefiCpuPkg PiSmmCpuDxeSmm: Use new EfiLocateFirstAcpiTable()

2018-09-17 Thread Star Zeng
https://bugzilla.tianocore.org/show_bug.cgi?id=967 Request to add a library function for GetAcpiTable() in order to get ACPI table using signature as input. After evaluation, we found there are many duplicated code to find ACPI table by signature in different modules. This patch updates

[edk2] [PATCH V3 1/6] MdePkg UefiLib: Add new EfiLocateXXXAcpiTable() APIs

2018-09-17 Thread Star Zeng
https://bugzilla.tianocore.org/show_bug.cgi?id=967 Request to add a library function for GetAcpiTable() in order to get ACPI table using signature as input. After evaluation, we found there are many duplicated code to find ACPI table by signature in different modules. This patch adds new

Re: [edk2] bootloader only see first disk

2018-09-17 Thread Thomas Lamprecht
Hi Laszlo, On 9/16/18 12:04 PM, Laszlo Ersek wrote: > Hello Aurélien, > > adding Thomas to the CC list, and commenting at the bottom: thanks for CC'ing and thanks to you Aurélien for writing your report. > > On 09/15/18 18:36, Aurélien wrote: >> Hi, >> >> I don't know if it is the right place

[edk2] [Patch] BaseTools: remove the not used PyUtility file

2018-09-17 Thread Yonghong Zhu
the PyUtility is not used, so we remove it. Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Yonghong Zhu --- BaseTools/Source/C/PyUtility/Makefile| 25 --- BaseTools/Source/C/PyUtility/PyUtility.c | 106 ---

Re: [edk2] [Patch] BaseTools: remove PyUtility and open the file with unbuffered

2018-09-17 Thread Zhu, Yonghong
Please ignore this one, I will separate it into two patches. Best Regards, Zhu Yonghong -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Yonghong Zhu Sent: Monday, September 17, 2018 2:43 PM To: edk2-devel@lists.01.org Cc: Gao, Liming Subject:

Re: [edk2] [PATCH v3 3/3] MdeModulePkg/SdMmcPciHcDxe: Execute card detect only for RemovableSlot

2018-09-17 Thread Wu, Hao A
Hi, Could you help to file a EDK2 Bugzilla tracker at: https://bugzilla.tianocore.org/enter_bug.cgi?product=EDK2 to have a general description of the issue you met? And reference the tracker within the commit message? Really appreciate the help, thanks in advance. With that, Reviewed-by: Hao Wu

Re: [edk2] [PATCH v3 1/3] MdeModulePkg/SdMmcPciHcDxe: Adjust eMMC clock and bus width sequence

2018-09-17 Thread Wu, Hao A
> -Original Message- > From: Marcin Wojtas [mailto:m...@semihalf.com] > Sent: Sunday, September 16, 2018 6:26 AM > To: edk2-devel@lists.01.org > Cc: Tian, Feng; Kinney, Michael D; Gao, Liming; leif.lindh...@linaro.org; Wu, > Hao A; ard.biesheu...@linaro.org; nad...@marvell.com;

Re: [edk2] [PATCH v3 2/3] MdeModulePkg/SdMmcPciHcDxe: Fix SdMmcHcReset to set only necesery bits

2018-09-17 Thread Wu, Hao A
> -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Marcin Wojtas > Sent: Sunday, September 16, 2018 6:26 AM > To: edk2-devel@lists.01.org > Cc: Tian, Feng; t...@semihalf.com; Wu, Hao A; nad...@marvell.com; Gao, > Liming; Kinney, Michael D >

Re: [edk2] [PATCH V2 1/6] MdePkg UefiLib: Add new EfiLocateXXXAcpiTable() APIs

2018-09-17 Thread Zeng, Star
Ray, Thanks for the good feedbacks. I can remove the ASSERT and update the description in the function header. I can also merge ScanTableInRSDT and ScanTableInXSDT. Thanks, Star -Original Message- From: Ni, Ruiyu Sent: Friday, September 14, 2018 12:41 PM To: Zeng, Star ;

Re: [edk2] [PATCH V2 5/6] ShellPkg DpDynamicCommand: Use new EfiLocateFirstAcpiTable()

2018-09-17 Thread Ni, Ruiyu
Reviewed-by: Ruiyu Ni Thanks/Ray > -Original Message- > From: Zeng, Star > Sent: Thursday, September 13, 2018 6:27 PM > To: edk2-devel@lists.01.org > Cc: Zeng, Star ; Younas khan > ; Kinney, Michael D > ; Gao, Liming ; Yao, > Jiewen ; Ni, Ruiyu ; Bi, Dandan > > Subject: [PATCH V2 5/6]

[edk2] [PATCH] BaseTools: Unused StructurePcd value is not requried to be calculated.

2018-09-17 Thread Zhaozh1x
Now, BaseTools always calculates StructurePcd value only if it is declared in DEC file. In fact, it only needs to calculate StructurePcd value only when this PCD is used by any module. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: ZhiqiangX Zhao Cc: Liming Gao Cc:

[edk2] [Patch] BaseTools: remove PyUtility and open the file with unbuffered

2018-09-17 Thread Yonghong Zhu
the PyUtility is not used, so we remove it. And update the open file with unbuffered to avoid the case that the file is not wrote but directly used in later when the host's multiple thread is very strong. Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: