[edk2] [Patch] BaseTools: refactor the error for PCD value is negative or exceed max

2018-09-28 Thread Yonghong Zhu
From: zhijufan refactor the error handling for the PCD value that is negative or it exceed the max value. Cc: Liming Gao Cc: Yonghong Zhu Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Zhiju.Fan --- BaseTools/Source/Python/AutoGen/GenC.py | 57

[edk2] [PATCH v3] MdeModulePkg/RegularExpressionDxe:disable wraning to pass gcc4.8 build

2018-09-28 Thread Dongao Guo
Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Dongao Guo --- MdeModulePkg/Universal/RegularExpressionDxe/RegularExpressionDxe.inf | 3 +++ 1 file changed, 3 insertions(+) diff --git a/MdeModulePkg/Universal/RegularExpressionDxe/RegularExpressionDxe.inf

Re: [edk2] [PATCH v2 1/5] MdePkg/BaseLib: Add new AsmLfence API

2018-09-28 Thread Gao, Liming
Reviewed-by: Liming Gao > -Original Message- > From: Wu, Hao A > Sent: Tuesday, September 25, 2018 2:13 PM > To: edk2-devel@lists.01.org > Cc: Wu, Hao A ; Ard Biesheuvel > ; Leif Lindholm ; Laszlo > Ersek ; Yao, Jiewen ; Kinney, > Michael D ; Gao, Liming > > Subject: [PATCH v2 1/5]

[edk2] [PATCH V2] MdeModulePkg/RegularExpressionDxe:disable wraning to pass gcc4.8 build

2018-09-28 Thread Dongao Guo
Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.1 --- MdeModulePkg/Universal/RegularExpressionDxe/RegularExpressionDxe.inf | 3 +++ 1 file changed, 3 insertions(+) diff --git a/MdeModulePkg/Universal/RegularExpressionDxe/RegularExpressionDxe.inf

Re: [edk2] [PATCH] MdeModulePkg:disable wraning to pass gcc4.8 build

2018-09-28 Thread Zeng, Star
No Signed-off-by? Thanks, Star -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Dongao Guo Sent: Saturday, September 29, 2018 9:55 AM To: edk2-devel@lists.01.org Cc: Gao, Liming Subject: [edk2] [PATCH] MdeModulePkg:disable wraning to pass gcc4.8

Re: [edk2] [PATCH] MdeModulePkg:disable wraning to pass gcc4.8 build

2018-09-28 Thread Gao, Liming
Dongao: Please remove Change-id in commit message. And, update commit title: MdeModulePkg RegularExpressionDxe: Disable warning to pass gcc4.8 build Thanks Liming > -Original Message- > From: Guo, Dongao > Sent: Saturday, September 29, 2018 9:55 AM > To: edk2-devel@lists.01.org > Cc:

[edk2] [PATCH] MdeModulePkg:disable wraning to pass gcc4.8 build

2018-09-28 Thread Dongao Guo
Change-Id: I782962e4994a8edf14beb7ede8b1aabe233dc3a8 Contributed-under: TianoCore Contribution Agreement 1.1 --- MdeModulePkg/Universal/RegularExpressionDxe/RegularExpressionDxe.inf | 3 +++ 1 file changed, 3 insertions(+) diff --git

[edk2] [Patch] UefiCpuPkg/Include/Register/Msr/GoldmontPlusMsr.h: Change to DOS format file.

2018-09-28 Thread Eric Dong
Follow EDKII coding style, change file format to dos style. BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1213 Cc: Dandan Bi Cc: Laszlo Ersek Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Eric Dong --- UefiCpuPkg/Include/Register/Msr/GoldmontPlusMsr.h | 544

[edk2] [PATCH v2 7/7] BaseTools/GenFds: create and use new variable in FdfParser

2018-09-28 Thread Jaben Carsey
replace lots of '}' and "}" with a shared new consistent variable. Cc: Bob Feng Cc: Yonghong Zhu Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jaben Carsey --- BaseTools/Source/Python/GenFds/FdfParser.py | 45 ++-- 1 file changed, 23

[edk2] [PATCH v2 4/7] BaseTools/GenFds: remove MacroDict parameter

2018-09-28 Thread Jaben Carsey
The MacroDict parameter goes around in circles through 4 functions without use. 1. GetSectionData calls into GetLeafSection, otherwise doesn’t use MacroDict 2. GetLeafSection calls into GetFileStatement, otherwise doesn’t use MacroDict 3. GetFileStatement calls into GetFilePart, otherwise doesn’t

[edk2] [PATCH v2 2/7] BaseTools/GenFds: change objects to sets

2018-09-28 Thread Jaben Carsey
Change lists and tuples used solely for "in" testing to sets. These operations are not order dependent. fixed some line length for PEP8 compliance on some. Cc: Liming Gao Cc: Yonghong Zhu Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jaben Carsey ---

[edk2] [PATCH v2 6/7] BaseTools/GenFds: Remove duplicate function calls

2018-09-28 Thread Jaben Carsey
every call to GetAprioriSection() is duplicated on the line below. remove one of the calls. Cc: Bob Feng Cc: Yonghong Zhu Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jaben Carsey --- BaseTools/Source/Python/GenFds/FdfParser.py | 2 -- 1 file changed,

[edk2] [PATCH v2 5/7] BaseTools/GenFds: refactor FdfParser warnings

2018-09-28 Thread Jaben Carsey
make functions for common error messages refactor to use these functions Cc: Yonghong Zhu Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jaben Carsey --- BaseTools/Source/Python/GenFds/FdfParser.py | 603 ++-- 1 file changed, 303

[edk2] [PATCH v2 0/7] BaseTools/GenFds: cleanup GenFds

2018-09-28 Thread Jaben Carsey
Cleanup to many files for GenFds. No command line visible changes are included. 1) refactor imports to reduce namespace clutter. 2) refactor to use existing sharable objects (and create a few new) 3) eliminate shadowing of names 4) remove double underscored private methods for PEP8 5) eliminate

[edk2] [PATCH v2 3/7] Basetools/GenFds: refactor class FV

2018-09-28 Thread Jaben Carsey
1) initialize UiFvName via __init__ parameter. No change to default behavior. 2) initialize 3 empty lists in __init__. Curently not guarenteed initialized. Cc: Yonghong Zhu Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jaben Carsey ---

[edk2] UEFI PI Spec 1.6 SPI stack question

2018-09-28 Thread Kirkendall, Garrett
Is there any example implementation in EDK2 of the UEFI PI spec 1.6 SPI stack? I'm finding there are some things that aren't defined in the spec or the header support in EDK2. (at least in UDK2018) Garrett Kirkendall SMTS Firmware Engineer | CTE 7171 Southwest Parkway, Austin, TX 78735 USA AMD

Re: [edk2] [PATCH v2 0/5] [CVE-2017-5753] Bounds Check Bypass issue in SMI handlers

2018-09-28 Thread Yao, Jiewen
Reviewed-by: jiewen@intel.com > -Original Message- > From: Wu, Hao A > Sent: Tuesday, September 25, 2018 2:13 PM > To: edk2-devel@lists.01.org > Cc: Wu, Hao A ; Ard Biesheuvel > ; Leif Lindholm ; > Laszlo Ersek ; Yao, Jiewen ; > Kinney, Michael D ; Gao, Liming > ; Zeng, Star ; Dong,

Re: [edk2] [PATCH v2 1/2] MdePkg/IndustryStandard: Add Global Plaform header file

2018-09-28 Thread Leif Lindholm
Hi Sumit, On Fri, Sep 28, 2018 at 11:59:33AM +0530, Sumit Garg wrote: > > > Please help to answer below query from Michael regarding licensing > > > concerns for using Global Platform specs content in OP-TEE. > > > > This dates back to ~2014 before OP-TEE had been pushed as an open source > >

Re: [edk2] [PATCH v3 1/7] MdeModulePkg: introduce PE/COFF image emulator protocol

2018-09-28 Thread Zeng, Star
Good questions. 1. The emulator needs three interfaces currently. The Version I mentioned is for the case that the emulator may need extra interface later in future for some new consideration, then we can just update the Version value and extend the structure with new interface, and no new

Re: [edk2] [PATCH v3 1/7] MdeModulePkg: introduce PE/COFF image emulator protocol

2018-09-28 Thread Ni, Ruiyu
On 9/28/2018 11:08 AM, Zeng, Star wrote: Good idea. You prefer to introduce a new feature PCD for this with default value = TRUE? Could we group the emulator APIs to one structure like below? And add a Version field for potential further extension? typedef struct { UINTN

Re: [edk2] [PATCH v2 1/2] MdePkg/IndustryStandard: Add Global Plaform header file

2018-09-28 Thread Sumit Garg
On Thu, 27 Sep 2018 at 18:21, Joakim Bech wrote: > > Hi, > > On Thu, Sep 27, 2018 at 05:40:49PM +0530, Sumit Garg wrote: > > +Joakim > > > > Joakim, > > > > Please help to answer below query from Michael regarding licensing > > concerns for using Global Platform specs content in OP-TEE. > > >

Re: [edk2] [RFC MdeModulePkg/UefiBootManagerLib v1 1/1] MdeModulePkg/UefiBootManagerLib: Fix raid card repair fail issue

2018-09-28 Thread Ming Huang
On 9/26/2018 1:00 PM, Ni, Ruiyu wrote: >> @@ -507,12 +552,13 @@ BmRepairAllControllers ( >> FormBrowser2, >> [Index], >> 1, >> - PcdGetPtr