[edk2] [PATCH] BaseTools/edksetup.sh: Handle the return value from grep

2018-10-01 Thread Gary Lin
When SetupPython3() parses the possible python binary paths, it uses `grep "[[:digit:]]$"` to filter the python versions in the file name. Since grep would return 1 when the last character of the file name is not a digit, OvmfPkg/build.sh would fail immediately when the function is handling some ca

[edk2] GenFds broken in latest basetools-win32

2018-10-01 Thread Kurt Kennett
"genfds" seems broken in latest tiano-win32 Can anybody else repo this: C:\repo\tiano-win32>genfds Traceback (most recent call last): File "C:\Python27\lib\site-packages\cx_Freeze\initscripts\Console.py", line 27, in File "GenFds\GenFds.py", line 24, in ValueError: Attempted relative impor

Re: [edk2] [PATCH 5/5] MdePkg/BaseSynchronizationLib GCC: simplify IA32 InternalSyncCompareExchange64()

2018-10-01 Thread Laszlo Ersek
On 10/01/18 20:27, Philippe Mathieu-Daudé wrote: > On 30/09/2018 00:23, Laszlo Ersek wrote: >> The IA32 variant of InternalSyncCompareExchange64() is correct, but we can >> simplify it. We don't need to load the lower 32 bits of ExchangeValue into >> EBX in two steps (first into a general register,

Re: [edk2] [PATCH 5/5] MdePkg/BaseSynchronizationLib GCC: simplify IA32 InternalSyncCompareExchange64()

2018-10-01 Thread Philippe Mathieu-Daudé
On 30/09/2018 00:23, Laszlo Ersek wrote: > The IA32 variant of InternalSyncCompareExchange64() is correct, but we can > simplify it. We don't need to load the lower 32 bits of ExchangeValue into > EBX in two steps (first into a general register, then into EBX); we can > ask GCC to populate EBX like

Re: [edk2] [PATCH] MdeModulePkg:disable wraning to pass gcc4.8 build

2018-10-01 Thread Laszlo Ersek
Wait a sec: On 10/01/18 19:48, Laszlo Ersek wrote: > However, this (edk2) commit message seems to suggest that the warnings > are only present with gcc-4.8 (and no later gcc releases). This in turn > suggests that the warnings are spurious (presumably, later gcc releases > recognize that none of

Re: [edk2] [PATCH] MdeModulePkg:disable wraning to pass gcc4.8 build

2018-10-01 Thread Laszlo Ersek
On 10/01/18 11:23, Tomas Pilar (tpilar) wrote: > Wouldn't it be better to fix the warnings in code rather than > silencing them? The same idea occurred to me, but it really depends on upstream Oniguruma. The upstream project's issue tracker on github seems quite active: https://github.com/kkos/

Re: [edk2] [PATCH v1 1/1] OvmfPkg/PlatformPei: clear CPU caches

2018-10-01 Thread Laszlo Ersek
On 10/01/18 13:45, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > The TCG "Platform Reset Attack Mitigation Specification" requires to > clear the processor caches when the MOR bit is set at boot time. > > According to Paolo Bonzini, clearing the CPU cache takes only a few > hu

Re: [edk2] [PATCH v1 1/1] OvmfPkg/PlatformPei: clear CPU caches

2018-10-01 Thread Kinney, Michael D
Hi, Could you use a service from the CacheMaintenanceLib instead? /** Writes back and invalidates the entire data cache in cache coherency domain of the calling CPU. Writes back and invalidates the entire data cache in cache coherency domain of the calling CPU. This function guarantees t

Re: [edk2] [Patch] BaseTools Python: Migrate Python27 to Python36

2018-10-01 Thread Kinney, Michael D
Gary, Please send the patch to edk2-devel. Yonghong may not be available much this week, so you may not see a response form him till next week. Thanks, Mike > -Original Message- > From: edk2-devel [mailto:edk2-devel- > boun...@lists.01.org] On Behalf Of Gary Lin > Sent: Monday, October

Re: [edk2] [PATCH] ShellPkg ShellLib.h: Fix wrong parameter name for ShellOpenFileByName

2018-10-01 Thread Carsey, Jaben
I think we need to update description. I guess that OpenFileByName may search CWD and or PATH, but DevicePath is absolute and therefore will not.. > -Original Message- > From: Zeng, Star > Sent: Saturday, September 29, 2018 6:20 PM > To: Ni, Ruiyu ; edk2-devel@lists.01.org > Cc: Carsey, J

[edk2] [PATCH v1 1/1] OvmfPkg/PlatformPei: clear CPU caches

2018-10-01 Thread marcandre . lureau
From: Marc-André Lureau The TCG "Platform Reset Attack Mitigation Specification" requires to clear the processor caches when the MOR bit is set at boot time. According to Paolo Bonzini, clearing the CPU cache takes only a few hundred clock cycles, so it can be done unconditionally. Flush the ca

Re: [edk2] [PATCH 4/5] MdePkg/BaseSynchronizationLib GCC: fix X64 InternalSyncCompareExchange64()

2018-10-01 Thread Philippe Mathieu-Daudé
On 30/09/2018 00:23, Laszlo Ersek wrote: > (This patch is identical to the X64 half of the last one, except for the > InternalSyncCompareExchange32() -> InternalSyncCompareExchange64() and > "cmpxchgl" -> "cmpxchgq" replacements.) > > The CMPXCHG instruction has the following operands: > - AX (imp

Re: [edk2] [PATCH 3/5] MdePkg/BaseSynchronizationLib GCC: fix InternalSyncCompareExchange32()

2018-10-01 Thread Philippe Mathieu-Daudé
On 30/09/2018 00:23, Laszlo Ersek wrote: > (This patch is identical to the last one, except for the > InternalSyncCompareExchange16() -> InternalSyncCompareExchange32() and > "cmpxchgw" -> "cmpxchgl" replacements.) > > The CMPXCHG instruction has the following operands: > - AX (implicit, CompareVa

Re: [edk2] [PATCH 2/5] MdePkg/BaseSynchronizationLib GCC: fix InternalSyncCompareExchange16()

2018-10-01 Thread Philippe Mathieu-Daudé
On 30/09/2018 00:23, Laszlo Ersek wrote: > The CMPXCHG instruction has the following operands: > - AX (implicit, CompareValue):input and output > - destination operand (*Value): input and output > - source operand (ExchangeValue): input > > The IA32 version of InternalSyncCompareExchange16()

Re: [edk2] [Patch] BaseTools Python: Migrate Python27 to Python36

2018-10-01 Thread Gary Lin
On Wed, Sep 26, 2018 at 01:02:05PM +, Zhu, Yonghong wrote: > Hi All, > Hi Yonghong, > Now we are working on bugzilla > 55 > (https://bugzilla.tianocore.org/show_bug.cgi?id=55) to migrate BaseTools > python tool from Python27 to Python36.

Re: [edk2] [PATCH 1/5] MdePkg/BaseSynchronizationLib GCC: fix whitespace and comments

2018-10-01 Thread Philippe Mathieu-Daudé
On 30/09/2018 00:23, Laszlo Ersek wrote: > The "GccInline.c" files have some inconsistent whitespace, and missing (or > incorrect) operand comments. Fix and unify them. > > This patch doesn't change behavior. > > Cc: Liming Gao > Cc: Michael D Kinney > Ref: https://bugzilla.tianocore.org/show_b

Re: [edk2] [PATCH] MdeModulePkg:disable wraning to pass gcc4.8 build

2018-10-01 Thread Tomas Pilar (tpilar)
Wouldn't it be better to fix the warnings in code rather than silencing them? Tom On 29/09/18 02:55, Dongao Guo wrote: > Change-Id: I782962e4994a8edf14beb7ede8b1aabe233dc3a8 > Contributed-under: TianoCore Contribution Agreement 1.1 > --- > MdeModulePkg/Universal/RegularExpressionDxe/RegularExpre