Re: [edk2] [PATCH V2] IntelFsp2Pkg/GenCfgOpt.py: Support PCD input from command line

2018-10-09 Thread Yao, Jiewen
Reviewed-by: jiewen@intel.com > -Original Message- > From: Chiu, Chasel > Sent: Monday, October 8, 2018 4:11 PM > To: edk2-devel@lists.01.org > Cc: Yao, Jiewen ; Gao, Liming > ; Zhu, Yonghong ; Chiu, > Chasel > Subject: [PATCH V2] IntelFsp2Pkg/GenCfgOpt.py: Support PCD input from > co

Re: [edk2] [Patch] BaseTools: do basic check in FvImage with header size and signature

2018-10-09 Thread Zhu, Yonghong
Reviewed-by: Yonghong Zhu Best Regards, Zhu Yonghong -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Yonghong Zhu Sent: Saturday, September 29, 2018 4:47 PM To: edk2-devel@lists.01.org Cc: Gao, Liming Subject: [edk2] [Patch] BaseTools: do basi

[edk2] [PATCH v4 1/1] ArmPkg/OpteeLib: Add APIs to communicate with OP-TEE

2018-10-09 Thread Sumit Garg
Add following APIs to communicate with OP-TEE pseudo/early TAs: 1. OpteeInit 2. OpteeOpenSession 3. OpteeCloseSession 4. OpteeInvokeFunc Cc: Ard Biesheuvel Cc: Leif Lindholm Cc: Michael D Kinney Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Sumit Garg --- ArmPkg/Libra

[edk2] [PATCH v4 0/1] Add ArmPkg/Optee library APIs

2018-10-09 Thread Sumit Garg
Changes in v4: Replaced abbreviations with full name which are not defined in [1]. Also used EFI_GUID for Trusted Application UUIDs. [1] https://edk2-docs.gitbooks.io/edk-ii-c-coding-standards-specification/content/v/release/2.20/4_naming_conventions/#table-2-efi-supported-abbreviations Changes

Re: [edk2] [PATCH] BaseTools: Convert string value of void* pcd in command line to array.

2018-10-09 Thread Gao, Liming
Reviewed-by: Liming Gao >-Original Message- >From: Zhao, ZhiqiangX >Sent: Wednesday, September 26, 2018 6:06 PM >To: edk2-devel@lists.01.org >Cc: Zhao, ZhiqiangX ; Gao, Liming >; Zhu, Yonghong ; Feng, >Bob C >Subject: [PATCH] BaseTools: Convert string value of void* pcd in command >line

Re: [edk2] [Patch] edk2-BaseTools-win32: Add notes to announce BaseTools Win32 doesn't work

2018-10-09 Thread krishnaLee
Hi, I think someone needs update the wiki if the BaseTools_win32_bin no longer work, https://github.com/tianocore/tianocore.github.io/wiki/Windows-systems thanks, krishna. At 2018-10-10 08:33:19, "Liming Gao" wrote: >https://lists.01.org/pipermail/edk2-devel/2018-September/029436.htm

[edk2] [PATCH v4] MdeModulePkg/RegularExpressionDxe:disable wraning to pass gcc4.8 build

2018-10-09 Thread Dongao Guo
There are three warnings reported by GCC 4.8 and the later GCC release are workaround with them. And all the three warnings are invalid,so I just disable warnings rather than fix them at now. Following is the analysis from Laszlo Ersek. (1) > MdeModulePkg/Universal/RegularExpressionDxe/Oniguruma/

Re: [edk2] [Patch] edk2-BaseTools-win32: Add notes to announce BaseTools Win32 doesn't work

2018-10-09 Thread Zhu, Yonghong
Reviewed-by: Yonghong Zhu Best Regards, Zhu Yonghong -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Liming Gao Sent: Wednesday, October 10, 2018 8:33 AM To: edk2-devel@lists.01.org Subject: [edk2] [Patch] edk2-BaseTools-win32: Add notes to ann

Re: [edk2] [PATCH] MdeModulePkg/RegularExpressionDxe:omit unused variable

2018-10-09 Thread Gao, Liming
Reviewed-by: Liming Gao >-Original Message- >From: Guo, Dongao >Sent: Monday, October 08, 2018 3:57 PM >To: edk2-devel@lists.01.org >Cc: Gao, Liming >Subject: [PATCH] MdeModulePkg/RegularExpressionDxe:omit unused >variable > > >comment unused variable to avoid warning,and modify inf buil

Re: [edk2] GenFds broken in latest basetools-win32

2018-10-09 Thread Gao, Liming
K2: Thanks for your suggestion. I just send the patch to update Notes in edk2-basetools-win32. Thanks Liming >-Original Message- >From: Kurt Kennett [mailto:kurt.kenn...@microsoft.com] >Sent: Tuesday, October 09, 2018 11:29 PM >To: Gao, Liming ; Zhu, Yonghong >; edk2-devel@lists.01.or

[edk2] [Patch] edk2-BaseTools-win32: Add notes to announce BaseTools Win32 doesn't work

2018-10-09 Thread Liming Gao
https://lists.01.org/pipermail/edk2-devel/2018-September/029436.html Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Liming Gao --- Readme.txt | 5 + 1 file changed, 5 insertions(+) diff --git a/Readme.txt b/Readme.txt index 9caee63..793d1cd 100644 --- a/Readme.txt ++

[edk2] [PATCH v2 0/2] [SdMmcPciDxe] SDHCI v4+ support

2018-10-09 Thread Jeff Brasen
Allow host controllers with spec. version higher than 3.0 recognizable by the driver https://bugzilla.tianocore.org/show_bug.cgi?id=1233 V2 changes - Restrict supported versions to versions defined in SDHCI specification - Add bugzilla link V1 - Initial support for controllers with versions > 3.

[edk2] [PATCH v2 1/2] MdeModulePkg/SdMmcPciHcDxe: Add controller version defines

2018-10-09 Thread Jeff Brasen
Add SDHCI controller defines, this is useful as the version in the register does not explictly map to a specification version. For example vesion 4.10 of the specification is version 0x04. https://bugzilla.tianocore.org/show_bug.cgi?id=1233 Contributed-under: TianoCore Contribution Agreement 1.1

[edk2] [PATCH v2 2/2] MdeModulePkg/SdMmcPciHcDxe: Allow additional SDHCI versions

2018-10-09 Thread Jeff Brasen
Clock control is similar in SDHCI versions greater then version 2. Add support for more recent versions of the controller specification. SD card support for 1.8V is also present in controller versions 3 and greater. https://bugzilla.tianocore.org/show_bug.cgi?id=1233 Contributed-under: TianoCore

[edk2] [PATCH v3 1/1] ArmPkg: Add support for GICv4

2018-10-09 Thread Sami Mujawar
Updated Redistributor base calculation to allow for the fact that GICv4 has 2 additional 64KB frames (for VLPI and a reserved frame). The code now tests the VLPIS bit in the GIC Redistributor Type Register (GICR_TYPER) and calculates the Redistributor granularity accordingly. The code changes are:

Re: [edk2] GenFds broken in latest basetools-win32

2018-10-09 Thread Kurt Kennett
Ok. May want to clean up the git .readme pages to not tell people to use something that is broken. K2 -Original Message- From: Gao, Liming Sent: Monday, October 8, 2018 6:16 PM To: Kurt Kennett ; Zhu, Yonghong ; edk2-devel@lists.01.org Subject: RE: GenFds broken in latest basetools-w

Re: [edk2] [PATCH] MdeModulePkg/NonDiscoverablePciDeviceDxe: expose unique B/D/F identifiers

2018-10-09 Thread Marcin Wojtas
Hi Ard, wt., 9 paź 2018 o 16:01 Ard Biesheuvel napisał(a): > > Currently, the implementation of EFI_PCI_IO_PROTOCOL::GetLocation() > in NonDiscoverablePciDeviceDxe returns the same set of dummy values > for each instance of the NON_DISCOVERABLE_DEVICE protocol that it > attaches itself to. Howeve

Re: [edk2] [PATCH v2 1/1] ArmPkg: Add support for GICv4

2018-10-09 Thread Ard Biesheuvel
On 9 October 2018 at 13:20, Sami Mujawar wrote: > Updated Redistributor base calculation to allow for the fact that > GICv4 has 2 additional 64KB frames (for VLPI and a reserved frame). > The code now tests the VLPIS bit in the GIC Redistributor Type > Register (GICR_TYPER) and calculates the Redi

[edk2] [PATCH] MdeModulePkg/NonDiscoverablePciDeviceDxe: expose unique B/D/F identifiers

2018-10-09 Thread Ard Biesheuvel
Currently, the implementation of EFI_PCI_IO_PROTOCOL::GetLocation() in NonDiscoverablePciDeviceDxe returns the same set of dummy values for each instance of the NON_DISCOVERABLE_DEVICE protocol that it attaches itself to. However, this turns out to be causing problems in cases where software (such

Re: [edk2] [PATCH v2 2/4] MdeModulePkg/SdMmcPciHcDxe: Add UhsSignaling to SdMmcOverride protocol

2018-10-09 Thread Marcin Wojtas
wt., 9 paź 2018 o 13:45 Ard Biesheuvel napisał(a): > > On 9 October 2018 at 13:32, Marcin Wojtas wrote: > > wt., 9 paź 2018 o 13:28 Wu, Hao A napisał(a): > >> > >> > -Original Message- > >> > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > >> > Ard > >> > Bieshe

Re: [edk2] [PATCH v2 2/4] MdeModulePkg/SdMmcPciHcDxe: Add UhsSignaling to SdMmcOverride protocol

2018-10-09 Thread Ard Biesheuvel
On 9 October 2018 at 13:32, Marcin Wojtas wrote: > wt., 9 paź 2018 o 13:28 Wu, Hao A napisał(a): >> >> > -Original Message- >> > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ard >> > Biesheuvel >> > Sent: Monday, October 08, 2018 11:10 PM >> > To: Marcin Wojtas;

Re: [edk2] [PATCH] MdePkg-BaseLib: Fix PathCleanUpDirectories() error involving "\..\.."

2018-10-09 Thread Jim.Dailey
>-Original Message- >From: Ni, Ruiyu [mailto:ruiyu...@intel.com] >Sent: Monday, October 8, 2018 9:55 PM >To: Dailey, Jim >Cc: michael.d.kin...@intel.com; liming@intel.com; edk2-devel@lists.01.org >Subject: Re: [edk2] [PATCH] MdePkg-BaseLib: Fix PathCleanUpDirectories() error >involvin

Re: [edk2] [PATCH v2 2/4] MdeModulePkg/SdMmcPciHcDxe: Add UhsSignaling to SdMmcOverride protocol

2018-10-09 Thread Marcin Wojtas
wt., 9 paź 2018 o 13:28 Wu, Hao A napisał(a): > > > -Original Message- > > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ard > > Biesheuvel > > Sent: Monday, October 08, 2018 11:10 PM > > To: Marcin Wojtas; Ni, Ruiyu; Wu, Hao A > > Cc: Tian, Feng; Tomasz Michalec;

Re: [edk2] [PATCH v2 2/4] MdeModulePkg/SdMmcPciHcDxe: Add UhsSignaling to SdMmcOverride protocol

2018-10-09 Thread Wu, Hao A
> -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ard > Biesheuvel > Sent: Monday, October 08, 2018 11:10 PM > To: Marcin Wojtas; Ni, Ruiyu; Wu, Hao A > Cc: Tian, Feng; Tomasz Michalec; Dong, Eric; edk2-devel-01; Gao, Liming; > Nadav Haklai; Kinne

Re: [edk2] [PATCH 2/2] MdeModulePkg/SdMmcPciHcDxe: Allow additional SDHCI versions

2018-10-09 Thread Wu, Hao A
> -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Jeff > Brasen > Sent: Saturday, October 06, 2018 1:13 AM > To: edk2-devel@lists.01.org > Cc: Jeff Brasen > Subject: [edk2] [PATCH 2/2] MdeModulePkg/SdMmcPciHcDxe: Allow additional > SDHCI versions

[edk2] [PATCH v2 1/1] ArmPkg: Add support for GICv4

2018-10-09 Thread Sami Mujawar
Updated Redistributor base calculation to allow for the fact that GICv4 has 2 additional 64KB frames (for VLPI and a reserved frame). The code now tests the VLPIS bit in the GIC Redistributor Type Register (GICR_TYPER) and calculates the Redistributor granularity accordingly. The code changes are:

Re: [edk2] RuntimeDXE unable to save variables to flash

2018-10-09 Thread Laszlo Ersek
On 10/09/18 12:25, Hristo Mihaylov wrote: > Thanks Laszlo, > >> Accessing invalid MSRs may raise injections. How do you know the MSR 0x1FE >> is valid (and the Data32 value is valid)? > > I'll investigate this further. > >> That's an Fvb->Write() call. Do you have access to the source of the fl

Re: [edk2] [Patch] BaseTools LzmaCompress: Fix GCC warning misleading-indentation

2018-10-09 Thread Gao, Liming
Thanks! > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo > Ersek > Sent: Tuesday, October 9, 2018 6:14 PM > To: Zeng, Star ; Ard Biesheuvel > ; Gao, Liming > Cc: edk2-devel@lists.01.org > Subject: Re: [edk2] [Patch] BaseTools LzmaCompr

Re: [edk2] RuntimeDXE unable to save variables to flash

2018-10-09 Thread Hristo Mihaylov
Thanks Laszlo, > Accessing invalid MSRs may raise injections. How do you know the MSR 0x1FE is > valid (and the Data32 value is valid)? I'll investigate this further. > That's an Fvb->Write() call. Do you have access to the source of the flash > driver (which produces the FVB protocol instance

Re: [edk2] [Patch] BaseTools LzmaCompress: Fix GCC warning misleading-indentation

2018-10-09 Thread Laszlo Ersek
On 10/09/18 10:24, Zeng, Star wrote: > Reviewed-by: Star Zeng > > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ard > Biesheuvel > Sent: Tuesday, October 9, 2018 3:13 PM > To: Gao, Liming > Cc: edk2-devel@lists.01.org > Subject: Re: [edk2] [

Re: [edk2] Need clarification on ImageUpdatable field in EFI_FIRMWARE_MANAGEMENT_PROTOCOL.CheckImage()

2018-10-09 Thread Varun Kumar
Awesome, thanks! On Tue, 9 Oct 2018, 2:56 pm Laszlo Ersek, wrote: > Hi, > > On 10/09/18 11:07, Varun Kumar wrote: > > I need clarification on ImageUpdatable field in > > EFI_FIRMWARE_MANAGEMENT_PROTOCOL.CheckImage(). ImageUpdatable is of 32 > > bit wide > > That seems to be the case, yes. (OUT U

Re: [edk2] Need clarification on ImageUpdatable field in EFI_FIRMWARE_MANAGEMENT_PROTOCOL.CheckImage()

2018-10-09 Thread Laszlo Ersek
Hi, On 10/09/18 11:07, Varun Kumar wrote: > I need clarification on ImageUpdatable field in > EFI_FIRMWARE_MANAGEMENT_PROTOCOL.CheckImage(). ImageUpdatable is of 32 > bit wide That seems to be the case, yes. (OUT UINT32 *). > but ImageUpdatable Definitions for this field is of 64 bit wide. That

Re: [edk2] [Patch v3] UefiCpuPkg/S3Resume2Pei: disable paging before creating new page table.

2018-10-09 Thread Laszlo Ersek
On 10/09/18 10:59, Ni, Ruiyu wrote: > On 10/9/2018 4:25 PM, Laszlo Ersek wrote: >> - for clarity, please use ~(UINTN)BIT31 as mask (even though it makes no >>    practical difference). > Actually we could use IA32_CR0 structure to avoid BIT31 usage. That's a great idea. I wish I had known about

[edk2] Need clarification on ImageUpdatable field in EFI_FIRMWARE_MANAGEMENT_PROTOCOL.CheckImage()

2018-10-09 Thread Varun Kumar
Hi, I need clarification on ImageUpdatable field in EFI_FIRMWARE_MANAGEMENT_PROTOCOL.CheckImage(). ImageUpdatable is of 32 bit wide but ImageUpdatable Definitions for this field is of 64 bit wide. I hope it's not defined intentionally if so, please clarify me on this. Please find the attached scre

Re: [edk2] [Patch v3] UefiCpuPkg/S3Resume2Pei: disable paging before creating new page table.

2018-10-09 Thread Ni, Ruiyu
On 10/9/2018 4:25 PM, Laszlo Ersek wrote: On 10/09/18 08:01, Eric Dong wrote: V3 changes: No need to change inf file. Also update commit message to include regression info. V2 changes: Only disable paging in 32 bit mode, no matter it is enable or not. V1 changes: PEI Stack Guard needs to enab

[edk2] [edk2-test] The initial version of UEFI SCT has been uploaded

2018-10-09 Thread Jin, Eric
Hi All, The initial version of UEFI SCT has been uploaded to https://github.com/tianocore/edk2-test and under the uefi-sct sub directory. If you have interest, please help review. If you find any issue, please contact Supreeth and Eric in the cc-list. Thank you. Best Regards Eric ___

Re: [edk2] [Patch] BaseTools Python: Migrate Python27 to Python36

2018-10-09 Thread Zhu, Yonghong
Hi All, If no more comment, I hope to sync Python3 migration patches to edk2 master in this week. Thanks. Best Regards, Zhu Yonghong -Original Message- From: Kinney, Michael D Sent: Monday, October 01, 2018 11:14 PM To: Gary Lin ; Zhu, Yonghong ; Kinney, Michael D Cc: Sun, Yanyan ;

Re: [edk2] [Patch] UefiCpuPkg/S3Resume2Pei: disable paging before creating new page table.

2018-10-09 Thread Laszlo Ersek
On 10/09/18 10:26, Ni, Ruiyu wrote: > On 10/9/2018 4:09 PM, Laszlo Ersek wrote: >>> >>> Two comments: >>> 1. We'd better not map the PcdCpuStackGuard to paging-enable. Maybe some >>> other feature also enables the paging in PEI phase but the >>> PcdCpuStackGuard is FALSE. >> >> I think I agree. >>

Re: [edk2] [Patch] UefiCpuPkg/S3Resume2Pei: disable paging before creating new page table.

2018-10-09 Thread Ni, Ruiyu
On 10/9/2018 4:09 PM, Laszlo Ersek wrote: Two comments: 1. We'd better not map the PcdCpuStackGuard to paging-enable. Maybe some other feature also enables the paging in PEI phase but the PcdCpuStackGuard is FALSE. I think I agree. 2. When PEI is in 64bit mode, disabling paging may not work

Re: [edk2] [Patch v3] UefiCpuPkg/S3Resume2Pei: disable paging before creating new page table.

2018-10-09 Thread Laszlo Ersek
On 10/09/18 08:01, Eric Dong wrote: > V3 changes: > No need to change inf file. Also update commit message to include regression > info. > > V2 changes: > Only disable paging in 32 bit mode, no matter it is enable or not. > > V1 changes: > PEI Stack Guard needs to enable paging. This might cause

Re: [edk2] [Patch] BaseTools LzmaCompress: Fix GCC warning misleading-indentation

2018-10-09 Thread Zeng, Star
Reviewed-by: Star Zeng -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ard Biesheuvel Sent: Tuesday, October 9, 2018 3:13 PM To: Gao, Liming Cc: edk2-devel@lists.01.org Subject: Re: [edk2] [Patch] BaseTools LzmaCompress: Fix GCC warning mislead

Re: [edk2] [Patch] UefiCpuPkg/S3Resume2Pei: disable paging before creating new page table.

2018-10-09 Thread Laszlo Ersek
On 10/09/18 04:15, Ni, Ruiyu wrote: > On 10/9/2018 10:05 AM, Dong, Eric wrote: >> Add BZ link for this issue: >> https://bugzilla.tianocore.org/show_bug.cgi?id=1232 >> >> Thanks, >> Eric >> >>> -Original Message- >>> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of >>>

Re: [edk2] [Patch v3] UefiCpuPkg/S3Resume2Pei: disable paging before creating new page table.

2018-10-09 Thread Ni, Ruiyu
On 10/9/2018 2:01 PM, Eric Dong wrote: V3 changes: No need to change inf file. Also update commit message to include regression info. V2 changes: Only disable paging in 32 bit mode, no matter it is enable or not. V1 changes: PEI Stack Guard needs to enable paging. This might cause #GP if code

Re: [edk2] [Patch] BaseTools LzmaCompress: Fix GCC warning misleading-indentation

2018-10-09 Thread Ard Biesheuvel
On 9 October 2018 at 09:11, Gao, Liming wrote: > This issue in LzmaEnc.c is for encode. The copy SDK in MdeModulePkg and > IntelFrameworkModulepkg is for decode. So, other copy SDK has no this issue. > I understand. Thanks for the fix Acked-by: Ard Biesheuvel >> -Original Message- >>

Re: [edk2] [Patch] BaseTools LzmaCompress: Fix GCC warning misleading-indentation

2018-10-09 Thread Gao, Liming
This issue in LzmaEnc.c is for encode. The copy SDK in MdeModulePkg and IntelFrameworkModulepkg is for decode. So, other copy SDK has no this issue. Thanks Liming > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ard > Biesheuvel > Sent: Tuesd

Re: [edk2] [Patch] BaseTools LzmaCompress: Fix GCC warning misleading-indentation

2018-10-09 Thread Ard Biesheuvel
On 9 October 2018 at 09:06, Liming Gao wrote: > GCC 6 or above reports the warning misleading-indentation. > This patch fixes it. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Liming Gao > Cc: Ard Biesheuvel > --- > BaseTools/Source/C/LzmaCompress/Sdk/C/LzmaEnc.c

[edk2] [Patch] BaseTools LzmaCompress: Fix GCC warning misleading-indentation

2018-10-09 Thread Liming Gao
GCC 6 or above reports the warning misleading-indentation. This patch fixes it. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Liming Gao Cc: Ard Biesheuvel --- BaseTools/Source/C/LzmaCompress/Sdk/C/LzmaEnc.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff