[edk2] [PATCH v2 12/12] MdeModulePkg/UsbMass: Reject device whose block size is 0 or > 64K

Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ruiyu Ni Cc: Star Zeng --- MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassBoot.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassBoot.c

[edk2] [PATCH v2 10/12] MdeModulePkg/UsbBus: Deny when the string descriptor length is odd

Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ruiyu Ni Cc: Jiewen Yao Cc: Star Zeng --- MdeModulePkg/Bus/Usb/UsbBusDxe/UsbDesc.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/MdeModulePkg/Bus/Usb/UsbBusDxe/UsbDesc.c

[edk2] [PATCH v2 11/12] MdeModulePkg/Bus/Ufs: Ensure device not return more data than expected

From: Hao Wu This commit adds checks to make sure the UFS devices do not return more data than the driver expected. Cc: Ruiyu Ni Cc: Jiewen Yao Cc: Star Zeng Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Hao Wu Reviewed-by: Star Zeng ---

[edk2] [PATCH v2 03/12] MdeModulePkg/UsbBus: Fix out-of-bound read access to descriptors

Today's implementation reads the Type/Length field in the USB descriptors data without checking whether the offset to read is beyond the data boundary. The patch fixes this issue. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ruiyu Ni Cc: Star Zeng Cc: Jiewen Yao ---

[edk2] [PATCH v2 00/12] Need to validate data from HW

The patches contain logic to check the data from HW before using. It can avoid corrupted data from HW causes software behave abnormally. V2: adopt all comments from Star. The block size 0/64K handle is in a separate patch "MdeModulePkg/UsbMass: Reject device whose block size is 0 or > 64K" Hao

[edk2] [PATCH v2 02/12] MdeModulePkg/UsbMass: Fix integer overflow when BlockSize is 1

UsbBootReadWriteBlocks() and UsbBootReadWriteBlocks16() use a UINT16 local variable to hold the value of USB_BOOT_MAX_CARRY_SIZE (=0x1) / BlockSize. When BlockSize is 1, the UINT16 local variable is set to 0x1 but the high-16 bits are truncated resulting the final value be 0. It causes

[edk2] [PATCH v2 05/12] MdeModulePkg/Usb: Make sure data from HW is no more than expected

Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ruiyu Ni Cc: Jiewen Yao Cc: Star Zeng Cc: Hao A Wu Reviewed-by: Hao Wu Reviewed-by: Star Zeng --- MdeModulePkg/Bus/Pci/EhciDxe/EhciSched.c | 9 ++--- MdeModulePkg/Bus/Pci/UhciDxe/UhciSched.c | 7 ---

[edk2] [PATCH v2 06/12] SourceLevelDebugPkg/Usb3: Make sure data from HW can fit in buffer

Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ruiyu Ni Cc: Hao A Wu Reviewed-by: Hao Wu --- .../DebugCommunicationLibUsb3/DebugCommunicationLibUsb3Transfer.c | 7 +++ 1 file changed, 7 insertions(+) diff --git

[edk2] [PATCH v2 09/12] MdeModulePkg/UsbMouse: Don't access key codes when length is wrong

Per USB HID spec, the buffer holding key codes should at least 3-byte long. Today's code assumes that the key codes buffer length is longer than 3-byte and unconditionally accesses the key codes buffer. It's incorrect. The patch fixes the issue by returning Device Error when the length is less

[edk2] [PATCH v2 08/12] MdeModulePkg/AbsPointer: Don't access key codes when length is wrong

Per USB HID spec, the buffer holding key codes should at least 3-byte long. Today's code assumes that the key codes buffer length is longer than 3-byte and unconditionally accesses the key codes buffer. It's incorrect. The patch fixes the issue by returning Device Error when the length is less

[edk2] [PATCH v2 01/12] MdeModulePkg/UsbMass: Merge UsbBoot(Read|Write)Blocks(16)

The change doesn't have functionality impact. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ruiyu Ni Cc: Star Zeng --- .../Bus/Usb/UsbMassStorageDxe/UsbMassBoot.c| 248 + .../Bus/Usb/UsbMassStorageDxe/UsbMassBoot.h| 76 ++-

[edk2] [PATCH v2 07/12] MdeModulePkg/UsbKb: Don't access key codes when length is wrong

Per USB HID spec, the buffer holding key codes should be 8-byte long. Today's code assumes that the key codes buffer length is 8-byte long and unconditionally accesses the key codes buffer. It's incorrect. The patch fixes the issue by returning Device Error when the length is less than 8-byte.

[edk2] [PATCH v2 04/12] MdeModulePkg/UsbBus: Reject descriptor whose length is bad

Today's implementation doesn't check whether the length of descriptor is valid before using it. The patch fixes this issue. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ruiyu Ni Cc: Star Zeng Cc: Jiewen Yao Reviewed-by: Star Zeng ---

[edk2] [Patch] NetworkPkg: Correct the time stamp and fix the integer overflow issue.

Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=883. Cc: Fu Siyuan Cc: Ye Ting Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Wu Jiaxin --- NetworkPkg/Dhcp6Dxe/Dhcp6Utility.c | 18 +- NetworkPkg/UefiPxeBcDxe/PxeBcSupport.c | 16

Re: [edk2] PACKAGES_PATH in !include path in Dsc files

Hi, You can directly include it. BaseTools will search it from WORKSPACE and PACKAGES_PATH. So, you only need to set edk2-platforms directory into PACKAGES_PATH env. !include Silicon/NXP/.dsc Thanks Liming >-Original Message- >From: Pankaj Bansal [mailto:pankaj.ban...@nxp.com]

Re: [edk2] [PATCH 11/11] MdeModulePkg/Bus/Ufs: Ensure device not return more data than expected

On 2018/10/15 14:38, Ruiyu Ni wrote: From: Hao Wu This commit adds checks to make sure the UFS devices do not return more data than the driver expected. Cc: Ruiyu Ni Cc: Jiewen Yao Cc: Star Zeng Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Hao Wu Thanks for the

Re: [edk2] [Patch 1/4] UefiCpuPkg/Include/AcpiCpuData.h: Add Semaphore related Information.

Hi Ruiyu, > -Original Message- > From: Ni, Ruiyu > Sent: Tuesday, October 16, 2018 10:27 AM > To: Dong, Eric ; edk2-devel@lists.01.org > Cc: Laszlo Ersek > Subject: Re: [Patch 1/4] UefiCpuPkg/Include/AcpiCpuData.h: Add > Semaphore related Information. > > On 10/15/2018 10:49 AM, Eric

Re: [edk2] PACKAGES_PATH in !include path in Dsc files

> -Original Message- > From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > Sent: Tuesday, October 16, 2018 8:41 AM > To: Pankaj Bansal > Cc: Gao, Liming ; Zhu, Yonghong > ; Leif Lindholm ; Michael > D Kinney ; edk2-devel@lists.01.org; Udit Kumar > ; Varun Sethi > Subject: Re:

Re: [edk2] [PATCH 10/11] MdeModulePkg/UsbBus: Deny when the string descriptor length is odd

On 2018/10/15 14:38, Ruiyu Ni wrote: Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ruiyu Ni Cc: Jiewen Yao Cc: Star Zeng --- MdeModulePkg/Bus/Usb/UsbBusDxe/UsbDesc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [edk2] [PATCH 09/11] MdeModulePkg/UsbMouse: Don't access key codes when length is wrong

On 2018/10/15 14:38, Ruiyu Ni wrote: Per USB HID spec, the buffer holding key codes should at least 3-byte long. Today's code assumes that the key codes buffer length is longer than 3-byte and unconditionally accesses the key codes buffer. It's incorrect. The patch fixes the issue by returning

Re: [edk2] [PATCH 08/11] MdeModulePkg/AbsPointer: Don't access key codes when length is wrong

On 2018/10/15 14:38, Ruiyu Ni wrote: Per USB HID spec, the buffer holding key codes should at least 3-byte long. Today's code assumes that the key codes buffer length is longer than 3-byte and unconditionally accesses the key codes buffer. It's incorrect. The patch fixes the issue by returning

Re: [edk2] [PATCH 07/11] MdeModulePkg/UsbKb: Don't access key codes when length is wrong

On 2018/10/15 14:38, Ruiyu Ni wrote: Per USB HID spec, the buffer holding key codes should be 8-byte long. Today's code assumes that the key codes buffer length is 8-byte long and unconditionally accesses the key codes buffer. It's incorrect. The patch fixes the issue by returning Device Error

Re: [edk2] [PATCH 05/11] MdeModulePkg/Usb: Make sure data from HW is no more than expected

On 2018/10/15 14:38, Ruiyu Ni wrote: Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ruiyu Ni Cc: Jiewen Yao Cc: Star Zeng Cc: Hao A Wu Ray, Thanks for the patch. Reviewed-by: Star Zeng Star --- MdeModulePkg/Bus/Pci/EhciDxe/EhciSched.c | 9 ++---

Re: [edk2] [Patch 1/4] UefiCpuPkg/Include/AcpiCpuData.h: Add Semaphore related Information.

Hi Laszlo, > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Tuesday, October 16, 2018 12:03 AM > To: Dong, Eric ; edk2-devel@lists.01.org > Cc: Ni, Ruiyu > Subject: Re: [Patch 1/4] UefiCpuPkg/Include/AcpiCpuData.h: Add > Semaphore related Information. > > On

Re: [edk2] [PATCH 04/11] MdeModulePkg/UsbBus: Reject descriptor whose length is bad

On 2018/10/15 14:38, Ruiyu Ni wrote: Today's implementation doesn't check whether the length of descriptor is valid before using it. The patch fixes this issue. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ruiyu Ni Cc: Star Zeng Cc: Jiewen Yao Ray, Thanks for

[edk2] [PATCH] Edk2Platforms: Replace FatBinPkg with FatPkg

In order to remove FatBinPkg, relationships depend on FatBinPkg need to be replaced by FatPkg in fdf. And FatPkg needs to be added in dsc. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Shenglei Zhang --- Platform/ARM/JunoPkg/ArmJuno.dsc | 1 +

Re: [edk2] [PATCH 03/11] MdeModulePkg/UsbBus: Fix out-of-bound read access to descriptors

On 2018/10/15 14:38, Ruiyu Ni wrote: Today's implementation reads the Type/Length field in the USB descriptors data without checking whether the offset to read is beyond the data boundary. The patch fixes this issue. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ruiyu

Re: [edk2] [PATCH 02/11] MdeModulePkg/UsbMass: Fix integer overflow when BlockSize is 1

On 10/16/2018 11:19 AM, Zeng, Star wrote: On 2018/10/15 14:38, Ruiyu Ni wrote: UsbBootReadWriteBlocks() and UsbBootReadWriteBlocks16() use a UINT16 local variable to hold the value of USB_BOOT_MAX_CARRY_SIZE (=0x1) / BlockSize. When BlockSize is 1, the UINT16 local variable is set to

Re: [edk2] [PATCH 02/11] MdeModulePkg/UsbMass: Fix integer overflow when BlockSize is 1

On 2018/10/15 14:38, Ruiyu Ni wrote: UsbBootReadWriteBlocks() and UsbBootReadWriteBlocks16() use a UINT16 local variable to hold the value of USB_BOOT_MAX_CARRY_SIZE (=0x1) / BlockSize. When BlockSize is 1, the UINT16 local variable is set to 0x1 Ray, Thanks for the patch. Is it

Re: [edk2] [Patch 4/4] UefiCpuPkg/PiSmmCpuDxeSmm: Add logic to support semaphore type.

On 10/15/2018 10:49 AM, Eric Dong wrote: Because this driver needs to set MSRs saved in normal boot phase, sync semaphore logic from RegisterCpuFeaturesLib code which used for normal boot phase. Detail see change SHA-1: dcdf1774212d87e2d7feb36286a408ea7475fd7b for RegisterCpuFeaturesLib. Cc:

Re: [edk2] PACKAGES_PATH in !include path in Dsc files

On 16 October 2018 at 10:40, Pankaj Bansal wrote: > +edk2-platforms maintainers in To list > > > > Thank you Liming for replying. > > > > Our entire code is in edk2-platforms > (https://github.com/tianocore/edk2-platforms) which is denoted by > PACKAGES_PATH. > > The PACKAGES_PATH directory can

Re: [edk2] [PATCH 01/11] MdeModulePkg/UsbMass: Merge UsbBoot(Read|Write)Blocks(16)

On 2018/10/15 14:38, Ruiyu Ni wrote: The change doesn't have functionality impact. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ruiyu Ni Cc: Star Zeng Ray, Thanks for the patch. I have a very very minor comment below. Reviewed-by: Star Zeng . ---

Re: [edk2] [Patch 3/4] UefiCpuPkg/RegisterCpuFeaturesLib: Add logic to support semaphore type.

On 10/15/2018 10:49 AM, Eric Dong wrote: In a system which has multiple cores, current set register value task costs huge times. After investigation, current set MSR task costs most of the times. Current logic uses SpinLock to let set MSR task as an single thread task for all cores. Because

Re: [edk2] [PATCH 0/6] Add kvmtool emulated platform support for ARM

On Sat, Oct 13, 2018 at 11:42:00PM +0200, Laszlo Ersek wrote: > On 10/12/18 16:40, Sami Mujawar wrote: > > Kvmtool is a virtual machine manager that enables hosting KVM > > guests. ARM is working to enhance kvmtool support to enable > > launching of KVM guest with UEFI support. > > Why is QEMU

[edk2] [PATCH] MdeModulePkg Variable: Fix Timestamp zeroing issue on APPEND_WRITE

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=415 When SetVariable() to a time based auth variable with APPEND_WRITE attribute, and if the EFI_VARIABLE_AUTHENTICATION_2.TimeStamp in the input Data is earlier than current value, it will cause timestamp zeroing. This issue may bring time

Re: [edk2] PACKAGES_PATH in !include path in Dsc files

+edk2-platforms maintainers in To list Thank you Liming for replying. Our entire code is in edk2-platforms (https://github.com/tianocore/edk2-platforms) which is denoted by PACKAGES_PATH. The PACKAGES_PATH directory can be anywhere in WORKSPACE depending on the sync directory defined by user.

Re: [edk2] [PATCH] uefi-sct/SctPkg:Add conformance test cases for deprecated EFI_VARIABLE_AUTHENTICATED_WRITE_ACCESS attribute.

Hi Eric, 1) Really happy to see the first SCT patch out for public review! 2) Could you go through Laszlo's excellent guide for contributions at https://github.com/tianocore/tianocore.github.io/wiki/Laszlo's-unkempt-git-guide-for-edk2-contributors-and-maintainers ? Specifically the bits

Re: [edk2] [Patch 1/4] UefiCpuPkg/Include/AcpiCpuData.h: Add Semaphore related Information.

On 10/15/2018 10:49 AM, Eric Dong wrote: In order to support semaphore related logic, add new definition for it. Cc: Ruiyu Ni Cc: Laszlo Ersek Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Eric Dong --- UefiCpuPkg/Include/AcpiCpuData.h | 23 ++-

Re: [edk2] Does edk2 still support python 2?

OK, got it, thank you! Thanks, Fan -Original Message- From: Leif Lindholm [mailto:leif.lindh...@linaro.org] Sent: Tuesday, October 16, 2018 10:13 AM To: Chen, Farrah Cc: edk2-devel@lists.01.org Subject: Re: [edk2] Does edk2 still support python 2? Hi Fan, This change has been

Re: [edk2] Does edk2 still support python 2?

Hi Fan, This change has been reverted for now. Please update to latest version of edk2. Python3 migration will happen at some point, but not this abrupt. Best Regards, Leif On Sat, Oct 13, 2018 at 01:17:05PM +, Chen, Farrah wrote: > Hello, > > When we make edk2 "OvmfPkg/build.sh -a X64

Re: [edk2] Where to find the fix for security issue id 686

Rafael: https://bugzilla.tianocore.org/show_bug.cgi?id=686 public now. You can view it. I also send the patches to fix it. Please check. Thanks Liming >-Original Message- >From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of >Rafael Machado >Sent: Tuesday, October

[edk2] [Patch 3/3] BaseTools: Add more checker in Decompress algorithm to access the valid buffer

https://bugzilla.tianocore.org/show_bug.cgi?id=686 Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Holtsclaw Brent Signed-off-by: Liming Gao --- BaseTools/Source/C/Common/Decompress.c | 23 +++-- BaseTools/Source/C/TianoCompress/TianoCompress.c

[edk2] [Patch 2/3] IntelFrameworkModulePkg: Add more checker in UefiTianoDecompressLib

https://bugzilla.tianocore.org/show_bug.cgi?id=686 To make sure the valid buffer be accessed only. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Holtsclaw Brent Signed-off-by: Liming Gao --- .../BaseUefiTianoCustomDecompressLib.c | 16 ++--

[edk2] [Patch 1/3] MdePkg: Add more checker in UefiDecompressLib to access the valid buffer only

https://bugzilla.tianocore.org/show_bug.cgi?id=686 Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Holtsclaw Brent Signed-off-by: Liming Gao --- .../BaseUefiDecompressLib/BaseUefiDecompressLib.c | 17 +++-- 1 file changed, 15 insertions(+), 2

[edk2] [Patch 0/3] Add more checker for Tianocompress and Ueficompress

https://bugzilla.tianocore.org/show_bug.cgi?id=686 Liming Gao (3): MdePkg: Add more checker in UefiDecompressLib to access the valid buffer only IntelFrameworkModulePkg: Add more checker in UefiTianoDecompressLib BaseTools: Add more checker in Decompress algorithm to access the

Re: [edk2] [Patch] NetworkPkg/TlsDxe: Remove the redundant library class.

Reviewed-by: Fu Siyuan > -Original Message- > From: Wu, Jiaxin > Sent: Tuesday, October 16, 2018 9:55 AM > To: edk2-devel@lists.01.org > Cc: Fu, Siyuan ; Ye, Ting ; Wu, > Jiaxin > Subject: [Patch] NetworkPkg/TlsDxe: Remove the redundant library class. > > Ref:

Re: [edk2] Regression with PXE boot on OvmfPkg/VirtioNetDxe driver on aarch64 system

On 15 October 2018 at 22:52, wrote: > > > On 10/04/18 06:06, Laszlo Ersek wrote: >> >> On 10/04/18 11:24, Leif Lindholm wrote: >>> >>> +Peter >>> >>> On Wed, Oct 03, 2018 at 04:59:54PM -0700, aaron.yo...@oracle.com wrote: I am suspecting that this patch to GRUB is the cause of a

[edk2] [Patch] NetworkPkg/TlsDxe: Remove the redundant library class.

Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1018. Cc: Fu Siyuan Cc: Ye Ting Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Wu Jiaxin --- NetworkPkg/TlsDxe/TlsDxe.inf | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git

Re: [edk2] [Patch 0/4] Fix performance issue caused by Set MSR task.

Hi Laszlo, > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Monday, October 15, 2018 11:52 PM > To: Dong, Eric ; edk2-devel@lists.01.org > Cc: Ni, Ruiyu > Subject: Re: [Patch 0/4] Fix performance issue caused by Set MSR task. > > Hi Eric, > > On 10/15/18

Re: [edk2] PACKAGES_PATH in !include path in Dsc files

What's your usage model in DSC? BaseTools will try to replace $(WORKSPACE) with WORKSPACE and PACKAGES_PATH, and find the first existing file. So, if you want to refer to one file in PACKAGES_PATH directory, you can also use $(WORKSPACE) macro to refer to it. Thanks Liming From: Pankaj Bansal

[edk2] [Patch] NetworkPkg/IpSecDxe: Fix issue to parse SA Payload.

Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1251 IpSecDxe failed to create the Child SA during parsing SA Payload, the issue was caused by the below commit: SHA-1: 1e0db7b11987d0ec93be7dfe26102a327860fdbd * MdeModulePkg/NetworkPkg: Checking for NULL pointer before use. In above commit,

Re: [edk2] [PATCH 0/5] MdePkg/BaseSynchronizationLib GCC: fixes, cleanups

Laszlo: Sorry for the delay. Your change is good. Reviewed-by: Liming Gao Thanks Liming >-Original Message- >From: Kinney, Michael D >Sent: Tuesday, October 16, 2018 3:29 AM >To: Laszlo Ersek ; Gao, Liming ; >Kinney, Michael D >Cc: edk2-devel-01 >Subject: RE: [edk2] [PATCH 0/5]

[edk2] [Patch] Expression spec: Add clarification for String compare

Relational and equality operators require both operands to be of the same type. Treat the string 'A' and "A" as same type, but for "A" and L"A" are not same type since one is general string, another is unicode string. Cc: Liming Gao Cc: Michael Kinney Cc: Kevin W Shaw Contributed-under:

Re: [edk2] [PATCH] MdePkg/BaseStackCheckLib: add MSFT toolchain support

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1239 Regards, Jian > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] > Sent: Tuesday, October 16, 2018 8:55 AM > To: edk2-devel@lists.01.org > Cc: Kinney, Michael D ; Yao, Jiewen > ; Andrew Fish ; Gao,

[edk2] [PATCH] MdePkg/BaseStackCheckLib: add MSFT toolchain support

This patch adds stack check support for MSFT toolchain, with compiler option /GS and /RTCs. This functionality is similar to the original ones supported by GCC toolchain. Usage example: This is a NULL library instance. Add it under a [LibraryClasses] section in dsc file to let it be built into

Re: [edk2] Where to find the fix for security issue id 686

I understood this issue's fix was already released at some branch. With your message things make sense again. In this case I can wait for this fix to be publicly available. Thanks for the clarification! Best Regards Rafael Em seg, 15 de out de 2018 às 16:42, Zimmer, Vincent <

Re: [edk2] [Patch] BaseTools: Support to use struct name as datum type before max size

Reviewed-by: Liming Gao >-Original Message- >From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of >Yonghong Zhu >Sent: Monday, October 15, 2018 9:23 PM >To: edk2-devel@lists.01.org >Subject: [edk2] [Patch] BaseTools: Support to use struct name as datum type >before max

Re: [edk2] [PATCH] CorebootPayloadPkg: don't use serial output for Release build

Hi, Kim, Looks good to me. Reviewed-by: Maurice Ma -Maurice -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Wonkyu Kim Sent: Monday, October 15, 2018 15:45 To: edk2-devel@lists.01.org Cc: Williams, Hannah ; gauml...@gmail.com; Zhao, Lijian ;

Re: [edk2] TianoCore Community Meeting Minutes (stephano)

Some additional feedback... General --- We would like to have a discussion around goals, what are the top issues we are trying to solve with these solutions? We believe a primary challenge is getting code integrated downstream. We would like to see security patches flow to more systems,

[edk2] [PATCH] CorebootPayloadPkg: don't use serial output for Release build

From: Wonkyu Kim Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Wonkyu Kim --- CorebootPayloadPkg/CorebootPayloadPkgIa32.dsc| 4 CorebootPayloadPkg/CorebootPayloadPkgIa32X64.dsc | 4 2 files changed, 8 insertions(+) diff --git

Re: [edk2] Missing Library in StandaloneMmPkg

Hi Eugene, Apologies for the confusion and inconvenience! I will try and explain. The original patchset for MM Standalone support on x86 and AArch64 had around 16 patches. These included changes to the StandaloneMmPkg, ArmPkg, BaseTools & the Arm VExpressPkg mainly. This patchset was split into

Re: [edk2] [PATCH] BaseTools/EOT: Change to call a program instead of calling Python API.

Hess, Thanks for the clarification. Makes sense! I glanced at, but didn't read in detail the code... so. Acked-by: Jaben Carsey > -Original Message- > From: Chen, Hesheng > Sent: Monday, October 15, 2018 2:34 PM > To: Carsey, Jaben ; Zhu, Yonghong > ; edk2-devel@lists.01.org >

Re: [edk2] [PATCH] BaseTools/EOT: Change to call a program instead of calling Python API.

Hello Jaben, The API is provided by C code and we want Python tool to use it. The tool used to call Python API from DLL files and now we need run Python tools from source so we can't build a specific version of DLL binary for it. The DLL file may be different for different version of Python. So

Re: [edk2] Regression with PXE boot on OvmfPkg/VirtioNetDxe driver on aarch64 system

On 10/04/18 06:06, Laszlo Ersek wrote: On 10/04/18 11:24, Leif Lindholm wrote: +Peter On Wed, Oct 03, 2018 at 04:59:54PM -0700, aaron.yo...@oracle.com wrote: I am suspecting that this patch to GRUB is the cause of a Buffer being re-transmitted before reaping the Buffer via

Re: [edk2] Missing Library in StandaloneMmPkg

Supreeth, thanks for the fast response. I'm struggling with what to do next - it sounds like we have a partial StandaloneMmPkg implementation on master. I'm willing to complete the implementation for our needs but would first like to understand what the plan is for completing and maintaining

Re: [edk2] Missing Library in StandaloneMmPkg

Eugene, The working StandaloneMm available here: https://github.com/supven01/edk2 https://github.com/supven01/edk2-platforms (Caveat: Working Version as of July 2018, May not be latest) As you mentioned, the patches were sent in June/July for Review. I have not received any comments/feedback on

Re: [edk2] Where to find the fix for security issue id 686

Ah ok From https://github.com/tianocore/tianocore.github.io/wiki/Reporting-Security-Issues you will see that issues are only visible to the report and infosec group of Bugzilla, namely “Issues in the Tianocore Security Issue product are only visible to the Reporter of the issue and the

[edk2] Missing Library in StandaloneMmPkg

Greetings, It appears that StandaloneMmPkg/StandaloneMmPkg.dsc contains a reference to this library: ArmMmuLib|ArmPkg/Library/ArmMmuLib/ArmMmuStandaloneMmCoreLib.inf but it does not actually appear in the tree. The AArch64StandaloneMm branch on edk2-staging is "stale" (not my words

Re: [edk2] [PATCH 0/5] MdePkg/BaseSynchronizationLib GCC: fixes, cleanups

Laszlo, Thanks for the reminder. My knowledge of inline GCC assembly syntax is very limited, so I am not able to review this patch for correctness. I can ack it. Acked-by: Michael D Kinney Perhaps Liming can do a more complete review. Mike > -Original Message- > From: edk2-devel

Re: [edk2] Where to find the fix for security issue id 686

Hi Vincent Thanks for the answer. The problem is that when I try to access this link I have this message: "You are not authorized to access bug #686." Any idea? Em seg, 15 de out de 2018 às 14:28, Zimmer, Vincent < vincent.zim...@intel.com> escreveu: > You can find reference to patches via the

Re: [edk2] [PATCH 0/5] MdePkg/BaseSynchronizationLib GCC: fixes, cleanups

On 10/08/18 15:44, Laszlo Ersek wrote: > On 09/30/18 00:23, Laszlo Ersek wrote: >> Repo: https://github.com/lersek/edk2.git >> Branch: inline_asm_rw_ops_1208 >> >> This series mainly fixes the operand constraints (missing input-output >> qualifications) in "BaseSynchronizationLib/*/GccInline.c".

Re: [edk2] [PATCH] BaseTools/EOT: Change to call a program instead of calling Python API.

> -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Yonghong Zhu > Sent: Monday, October 15, 2018 3:24 AM > To: edk2-devel@lists.01.org > Cc: Chen, Hesheng > Subject: [edk2] [PATCH] BaseTools/EOT: Change to call a program instead of > calling

Re: [edk2] [Patch] BaseTools: Add check for the string type whether is same

Reviewed-by: Jaben Carsey > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Yonghong Zhu > Sent: Monday, October 15, 2018 5:45 AM > To: edk2-devel@lists.01.org > Cc: Gao, Liming > Subject: [edk2] [Patch] BaseTools: Add check for the string

Re: [edk2] [Patch] BaseTools: Fix bugs use special character in the --pcd option

Reviewed-by: Jaben Carsey > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Yonghong Zhu > Sent: Monday, October 15, 2018 5:46 AM > To: edk2-devel@lists.01.org > Subject: [edk2] [Patch] BaseTools: Fix bugs use special character in the --pcd >

Re: [edk2] Where to find the fix for security issue id 686

You can find reference to patches via the advisory entry "31. EDK II TIANOCOMPRESS BOUNDS CHECKING ISSUES" advisory entry https://edk2-docs.gitbooks.io/security-advisory/content/edk-ii-tianocompress-bounds-checking-issues.html has an embedded link to

Re: [edk2] [Patch 4/4] UefiCpuPkg/PiSmmCpuDxeSmm: Add logic to support semaphore type.

On 10/15/18 04:49, Eric Dong wrote: > Because this driver needs to set MSRs saved in normal boot phase, sync > semaphore > logic from RegisterCpuFeaturesLib code which used for normal boot phase. (My review of this patch is going to be superficial. I'm not trying to validate the actual

Re: [edk2] [Patch 1/4] UefiCpuPkg/Include/AcpiCpuData.h: Add Semaphore related Information.

On 10/15/18 04:49, Eric Dong wrote: > In order to support semaphore related logic, add new definition for it. > > Cc: Ruiyu Ni > Cc: Laszlo Ersek > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Eric Dong > --- > UefiCpuPkg/Include/AcpiCpuData.h | 23

Re: [edk2] [Patch 0/4] Fix performance issue caused by Set MSR task.

Hi Eric, On 10/15/18 04:49, Eric Dong wrote: > In a system which has multiple cores, current set register value task costs > huge times. > After investigation, current set MSR task costs most of the times. Current > logic uses > SpinLock to let set MSR task as an single thread task for all

[edk2] [Patch] BaseTools: Support to use struct name as datum type before max size

Original it hard code to use "VOID*", this patch extend it to both support VOID* and valid struct name. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Yonghong Zhu --- BaseTools/Source/Python/Common/Misc.py | 4 +++-

Re: [edk2] [PATCH] uefi-sct/SctPkg:Fix the flaw in BBTestCreateEventEx_Func_Sub3 on certain situation. Besides AllocatePages(), CreateEventEx may cause the memorymap change itself. Enhance the test to

On 10/15/2018 02:33 AM, Supreeth Venkatesh wrote: Please use a commit message less than 80 Cols. On 10/13/2018 04:42 PM, Eric Jin wrote: Cc: Supreeth Venkatesh Cc: Jiaxin Wu Contributed-under: TianoCore Contribution Agreement

Re: [edk2] [PATCH] uefi-sct/SctPkg:The original design for the 'EraseLengthGranularity' test need consider this case

FYI On 10/15/2018 03:08 AM, Supreeth Venkatesh wrote: Commit Message less than 80 cols please. On 10/13/2018 04:51 PM, Eric Jin wrote: For the SD device, no same as the eMMC, the 'EraseLengthGranularity' is 1. Cc: Supreeth Venkatesh Cc: Jiaxin Wu

Re: [edk2] [PATCH] uefi-sct/SctPkg:Implement the iSCSI devicepath to text

FYI On 10/15/2018 03:33 AM, Supreeth Venkatesh wrote: On 10/14/2018 03:25 AM, Eric Jin wrote: Cc: Supreeth Venkatesh Cc: Jiaxin Wu Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Eric Jin

Re: [edk2] [PATCH] uefi-sct/SctPkg: Fix the Possible numeric underflow

FYI On 10/15/2018 03:20 AM, Supreeth Venkatesh wrote: Reviewed-by: Supreeth Venkatesh On 10/13/2018 05:27 PM, Eric Jin wrote: Possible numeric underflow when calculating the starting LBA for ReadBlocks_Func test Cc: Supreeth Venkatesh

Re: [edk2] [PATCH] uefi-sct/SctPkg:Enhance the EraseBlock Test

FYI On 10/15/2018 03:43 AM, Supreeth Venkatesh wrote: On 10/14/2018 05:26 PM, Eric Jin wrote: The EraseSize in the EraseBlocks conf test should be bytes. Cover the case that the size of the data to erase is a multiple of the 'EraseLengthGranularity' value of an Erase Block Protocol instance.

Re: [edk2] [PATCH] uefi-sct/SctPkg:The original design for the 'EraseLengthGranularity' test need consider this case

FYI On 10/15/2018 02:44 AM, Supreeth Venkatesh wrote: Commit Message less than 80 cols please. On 10/13/2018 04:51 PM, Eric Jin wrote: For the SD device, no same as the eMMC, the 'EraseLengthGranularity' is 1. Cc: Supreeth Venkatesh Cc: Jiaxin Wu

Re: [edk2] [PATCH] uefi-sct/SctPkg:Assign 0 to the tail of HwErrRecVariableName

FYI On 10/15/2018 03:23 AM, Supreeth Venkatesh wrote: On 10/14/2018 02:31 AM, Eric Jin wrote: Ensure the HwErrRecVariable could be deleted before the test exit. Cc: Supreeth Venkatesh Cc: Jiaxin Wu Contributed-under: TianoCore

Re: [edk2] [PATCH] uefi-sct/SctPkg:The Lun display order issue in iSCSI device path text

FYI On 10/15/2018 03:22 AM, Supreeth Venkatesh wrote: On 10/13/2018 05:33 PM, Eric Jin wrote: Cc: Supreeth Venkatesh Cc: Jiaxin Wu Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Eric Jin

Re: [edk2] [PATCH] uefi-sct/SctPkg: Fix the BlueTooth Guid and Enable BLE test

FYI On 10/15/2018 03:36 AM, Supreeth Venkatesh wrote: On 10/14/2018 04:54 AM, Eric Jin wrote: Correct the guid of EFI_GUID gEfiBlueToothIoProtocolGuid and gEfiBlueToothConfigProtocolGuid Add BlueToothLE support test in the EfiCompliant part Cc: Supreeth Venkatesh

Re: [edk2] [PATCH] uefi-sct/SctPkg:Add the checkpoint of Toggle state of ReadKeyStrokeEx

FYI On 10/15/2018 03:17 AM, Supreeth Venkatesh wrote: On 10/13/2018 05:21 PM, Eric Jin wrote: UEFI Spec clarify the Toggle state Cc: Supreeth Venkatesh Cc: Jiaxin Wu Contributed-under: TianoCore Contribution Agreement 1.1

Re: [edk2] [PATCH] uefi-sct/SctPkg:Fix the incorrect buffer free in SctAPrint()

On 10/15/2018 03:24 AM, Supreeth Venkatesh wrote: Reviewed-by: Supreeth Venkatesh On 10/14/2018 02:58 AM, Eric Jin wrote: Cc: Supreeth Venkatesh Cc: Jiaxin Wu Contributed-under: TianoCore

Re: [edk2] [PATCH] uefi-sct/SctPkg:Enhance the SimpleNetwork Test

FYI On 10/15/2018 03:30 AM, Supreeth Venkatesh wrote: On 10/14/2018 03:06 AM, Eric Jin wrote: Add the EFI_SIMPLE_NETWORK_RECEIVE_MULTICAST bit in the Enable parameter Add one checkpoint to MCastFilterCount is zero Cc: Supreeth Venkatesh Cc: Jiaxin Wu

Re: [edk2] [PATCH] uefi-sct/SctPkg:One checkpoint in the ExtractConfigFunction need be removed

FYI On 10/15/2018 03:48 AM, Supreeth Venkatesh wrote: Reviewed-by: Supreeth Venkatesh On 10/13/2018 04:30 PM, Eric Jin wrote: The Results output from ExtractConfigFunction() may be different during two calls in some case. Cc: Supreeth Venkatesh

Re: [edk2] [PATCH] uefi-sct/SctPkg:Add conformance test cases for deprecated EFI_VARIABLE_AUTHENTICATED_WRITE_ACCESS attribute.

FYI On 10/15/2018 03:46 AM, Supreeth Venkatesh wrote: Reviewed-by: Supreeth Venkatesh If the commit message is broken down into multiple lines less than 80 cols. On 10/13/2018 04:19 PM, Eric Jin wrote: Cc: Supreeth Venkatesh

[edk2] [Patch] BaseTools: Fix bugs use special character in the --pcd option

Cases: --pcd Token.Name="!" --pcd Token.Name="\'W&\'" --pcd Token.Name="2*h" Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Yonghong Zhu --- BaseTools/Source/Python/Workspace/DscBuildData.py | 2 ++ 1 file changed, 2 insertions(+) diff --git

[edk2] [Patch] BaseTools: Add check for the string type whether is same

From: zhijufan Relational and equality operators require both operands to be of the same type. Treat the string 'A' and "A" as same type, but for "A" and L"A" are not same type since one is general string, another is unicode string. True:'A'<'B', "A"<"B" 'A'<"B", L'A' Cc: Yonghong Zhu

[edk2] Where to find the fix for security issue id 686

Hi everyone I was tying to find the patch to fix the reported security issue id 686 ( https://bugzilla.tianocore.org/show_bug.cgi?id=686), but was not able to access it. Could someone please tell if this patch, or series of patches, was already merged to some branch that is public available?

Re: [edk2] [PATCH v1 0/7] Code refinements in UdfDxe

Hi, Hao Wu writes: > This series will refine the codes in MdeModulePkg/Universal/Disk/UdfDxe > for: > > A. Refine asserts used for memory allocation failure and error cases that >are possible to happen. Will use error handling logic for them; > > B. Address some dead codes within this

Re: [edk2] [PATCH 06/11] SourceLevelDebugPkg/Usb3: Make sure data from HW can fit in buffer

Reviewed-by: Hao Wu Best Regards, Hao Wu > -Original Message- > From: Ni, Ruiyu > Sent: Monday, October 15, 2018 2:38 PM > To: edk2-devel@lists.01.org > Cc: Wu, Hao A > Subject: [PATCH 06/11] SourceLevelDebugPkg/Usb3: Make sure data from > HW can fit in buffer > > Contributed-under:

Re: [edk2] [PATCH 05/11] MdeModulePkg/Usb: Make sure data from HW is no more than expected

Reviewed-by: Hao Wu Best Regards, Hao Wu > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Ruiyu Ni > Sent: Monday, October 15, 2018 2:38 PM > To: edk2-devel@lists.01.org > Cc: Wu, Hao A; Yao, Jiewen; Zeng, Star > Subject: [edk2] [PATCH

Re: [edk2] Revert BaseTools Python3 Migration has been done at 1ccc4d895dd8d659d016efcd6ef8a48749aba1d0

On 10/15/18 02:43, Gao, Liming wrote: > Hi, all > With the community discussion, Python3 migration is the fundamental change. > It requires every developer to install Python3. Before this migration, the > well communication and wide verification must be done. But now, most people > is not

  1   2   >